@zhuxixi/pi-agent-board 0.6.2 → 0.8.0

package/src/ui/dashboard.ts

@@ -11,7 +11,7 @@ import { CustomEditor } from "@earendil-works/pi-coding-agent";
 import type { Component, EditorTheme, KeybindingsManager, TUI } from "@earendil-works/pi-tui";
 import { Key, matchesKey, truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
 import { requestDashboardRender } from "../core/dashboard-render.mjs";
-import { isGenericStatusText, normalizeGenericStatusText } from "../core/derive.mjs";
+import { normalizeGenericStatusText } from "../core/derive.mjs";
 import { firstSentence, truncate } from "../core/heuristics.mjs";
 import {
 	canonicalModelRef,
@@ -31,7 +31,7 @@ import { filterRows, groupRowsByFolder, rowState, stateGlyph } from "../core/row
 import { loadSessionView } from "../core/session-view.mjs";
 import { GROUP_LABELS } from "../core/types.mjs";
 import { buildEvidencePanel } from "./dashboard-evidence.mjs";
-import { readState, writeState, type Row } from "../core/store.mjs";
+import { type Row } from "../core/store.mjs";
 import type { createService } from "../runtime/service.mjs";
 
 type Service = ReturnType<typeof createService>;
@@ -440,7 +440,7 @@ export class DashboardComponent implements Component {
 		const page = Math.max(1, termRows - 8);
 		if (matchesKey(data, Key.left) || matchesKey(data, Key.escape) || data === "<") {
 			const row = this.selectedRow();
-			if (row) this.deps.service.markVisited?.(row.meta.id);
+			if (row) void this.deps.service.markVisited?.(row.meta.id)?.catch(() => {});
 			this.mode = "list";
 			return;
 		}
@@ -847,13 +847,28 @@ export class DashboardComponent implements Component {
 		const launchCwd = launchOpts?.cwd ?? this.deps.defaultCwd;
 		const launchModel = launchOpts?.model ?? (this.launch?.model ? canonicalModelRef(this.launch.model) : null);
 		const launchThinking = launchOpts?.thinkingLevel ?? this.launch?.thinking ?? this.deps.currentThinkingLevel;
-		const res = this.deps.service.dispatch(text, {
-			cwd: launchCwd,
-			model: launchModel,
-			thinkingLevel: launchThinking,
-		});
-		if (!res.ok) this.notice(res.error ?? "Dispatch failed", "error");
-		else {
+		// Clear synchronously, BEFORE the async dispatch: closes the double-submit
+		// window — a second Enter during the coordinator round-trip (mark_queued
+		// lands before the runner spawns, issue #91) must not re-dispatch.
+		this.setInput("");
+		this.launch = null;
+		this.mode = "list";
+		this.inputNotice = null;
+		this.refresh();
+		// dispatch is async (mark_queued routes through the view-state coordinator
+		// before the runner spawns, issue #91); notices/attach land when it settles.
+		void Promise.resolve(
+			this.deps.service.dispatch(text, {
+				cwd: launchCwd,
+				model: launchModel,
+				thinkingLevel: launchThinking,
+			}),
+		).then((res) => {
+			if (!res.ok) {
+				this.notice(res.error ?? "Dispatch failed", "error");
+				this.refresh();
+				return;
+			}
 			this.lastLaunchPrefs = { ...this.deps.service.getLaunchPrefs?.(), cwd: launchCwd, model: launchModel, thinkingLevel: launchThinking };
 			try {
 				recordCwdLaunch(this.deps.root, launchCwd);
@@ -867,10 +882,6 @@ export class DashboardComponent implements Component {
 			}
 			this.selectedId = res.viewId ?? this.selectedId;
 			if (launchOpts?.attach && res.hostMode === "pty" && res.viewId) {
-				this.setInput("");
-				this.launch = null;
-				this.mode = "list";
-				this.inputNotice = null;
 				this.done({ action: "attach", viewId: res.viewId, stopFirst: false });
 				return;
 			}
@@ -879,12 +890,14 @@ export class DashboardComponent implements Component {
 			} else {
 				this.notice(`Dispatched: ${truncate(text, 40)}`, "info");
 			}
-		}
-		this.setInput("");
-		this.launch = null;
-		this.mode = "list";
-		this.inputNotice = null;
-		this.refresh();
+			this.refresh();
+		}).catch(() => {
+			// dispatch() is not expected to reject (its failures surface as
+			// {ok:false}); this guards fs-class throws from escaping as unhandled
+			// rejections (issue #91 hygiene).
+			this.notice("Dispatch failed", "error");
+			this.refresh();
+		});
 	}
 
 	private async submitReply(): Promise<void> {
@@ -947,10 +960,11 @@ export class DashboardComponent implements Component {
 		this.pending = {
 			prompt: `Mark "${row.meta.name}" as done? (y/N)`,
 			onYes: () => {
-				const res = this.markCompleted(row);
-				if (!res.ok) this.notice(res.error ?? "Mark done failed", "error");
-				else this.notice("Marked done", "info");
-				this.refresh();
+				void this.markCompleted(row).then((res) => {
+					if (!res.ok) this.notice(res.error ?? "Mark done failed", "error");
+					else this.notice("Marked done", "info");
+					this.refresh();
+				});
 			},
 		};
 		this.mode = "confirm";
@@ -966,57 +980,25 @@ export class DashboardComponent implements Component {
 			prompt: `Mark ${doneIds.length} selected session${doneIds.length === 1 ? "" : "s"} as done?${skipped ? ` ${skipped} will be skipped.` : ""} (y/N)`,
 			returnMode: "select",
 			onYes: () => {
-				const res = this.deps.service.markCompletedMany?.(doneIds) ?? { ok: true, completed: 0, skipped: doneIds.length, completedIds: [] };
-				if (!res.ok) this.notice("Mark done failed", "error");
-				else {
-					if (res.completedIds?.length) this.selectedId = res.completedIds[0];
-					this.notice(`Moved ${res.completed} to Done${res.skipped ? ` · skipped ${res.skipped}` : ""}`, "info");
-				}
-				this.refresh();
+				void Promise.resolve(this.deps.service.markCompletedMany?.(doneIds) ?? { ok: true, completed: 0, skipped: doneIds.length, completedIds: [] }).then((res) => {
+					if (!res.ok) this.notice("Mark done failed", "error");
+					else {
+						if (res.completedIds?.length) this.selectedId = res.completedIds[0];
+						this.notice(`Moved ${res.completed} to Done${res.skipped ? ` · skipped ${res.skipped}` : ""}`, "info");
+					}
+					this.refresh();
+				});
 			},
 		};
 		this.mode = "confirm";
 	}
 
-	private markCompleted(row: Row): { ok: boolean; error?: string } {
-		const service = this.deps.service as Service & { markCompleted?: (viewId: string) => { ok: boolean; error?: string } };
-		if (typeof service.markCompleted === "function") return service.markCompleted(row.meta.id);
-
-		// Compatibility guard for an already-open dashboard whose service object came
-		// from an older module instance. The service owns this path normally.
-		const state = readState(service.root, row.meta.id) ?? row.state ?? {
-			version: 1,
-			viewId: row.meta.id,
-			currentRunId: null,
-			semanticState: "idle",
-			processState: "exited",
-			summary: "Needs instructions",
-			lastActivityAt: Date.now(),
-			updatedAt: Date.now(),
-			needsInput: false,
-			hasError: false,
-			latestAssistantPreview: "",
-			latestTool: null,
-			question: null,
-			pendingQuestions: [],
-			error: null,
-			lastVisitedAt: null,
-			lastAgentActivityAt: null,
-			autoState: null,
-		};
-		state.semanticState = "completed";
-		state.processState = "exited";
-		state.needsInput = false;
-		state.hasError = false;
-		state.question = null;
-		state.pendingQuestions = [];
-		state.error = null;
-		state.autoState = null;
-		state.summary = completedSummary(state.summary, state.latestAssistantPreview);
-		state.lastActivityAt = Date.now();
-		state.updatedAt = Date.now();
-		writeState(service.root, state);
-		return { ok: true };
+	// Routes through the View State Coordinator (issue #91): the service's
+	// markCompleted submits a fenced state command. No compat fallback for stale
+	// pre-coordinator service objects — the window is transient and self-heals
+	// on the next dashboard reload.
+	private markCompleted(row: Row): Promise<{ ok: boolean; error?: string }> {
+		return this.deps.service.markCompleted(row.meta.id);
 	}
 
 	private handleDeleteKey(): void {
@@ -1025,10 +1007,13 @@ export class DashboardComponent implements Component {
 		const now = Date.now();
 		if (this.deleteArm !== null && this.deleteArm.id === row.meta.id && now - this.deleteArm.at <= DELETE_DOUBLE_PRESS_MS) {
 			this.deleteArm = null;
-			const res = this.deps.service.archive(row.meta.id);
-			if (!res.ok) this.notice(res.error ?? "Delete failed", "error");
-			else this.notice(`Deleted "${row.meta.name}"`, "info");
-			this.refresh();
+			// archive is async (routes through the view-state coordinator, issue #91);
+			// the notice + refresh land when the command settles.
+			void Promise.resolve(this.deps.service.archive(row.meta.id)).then((res) => {
+				if (!res.ok) this.notice(res.error ?? "Delete failed", "error");
+				else this.notice(`Deleted "${row.meta.name}"`, "info");
+				this.refresh();
+			});
 			return;
 		}
 		this.deleteArm = { id: row.meta.id, at: now };
@@ -1063,11 +1048,13 @@ export class DashboardComponent implements Component {
 			prompt: `Delete ${rows.length} done session${rows.length === 1 ? "" : "s"}? Session files are preserved. (y/N)`,
 			returnMode: "select",
 			onYes: () => {
-				const res = this.deps.service.archiveMany?.(rows.map((row) => row.meta.id)) ?? { ok: true, archived: 0, skipped: rows.length };
-				if (!res.ok) this.notice("Delete failed", "error");
-				else this.notice(`Deleted ${res.archived}${res.skipped ? ` · skipped ${res.skipped}` : ""}`, "info");
-				this.exitSelectionMode(true);
-				this.refresh();
+				// archiveMany is async (coordinator-routed, issue #91).
+				void Promise.resolve(this.deps.service.archiveMany?.(rows.map((row) => row.meta.id)) ?? { ok: true, archived: 0, skipped: rows.length }).then((res) => {
+					if (!res.ok) this.notice("Delete failed", "error");
+					else this.notice(`Deleted ${res.archived}${res.skipped ? ` · skipped ${res.skipped}` : ""}`, "info");
+					this.exitSelectionMode(true);
+					this.refresh();
+				});
 			},
 		};
 		this.mode = "confirm";
@@ -1088,7 +1075,7 @@ export class DashboardComponent implements Component {
 
 	private openSessionView(): void {
 		if (!this.selectedId) return;
-		this.deps.service.markVisited?.(this.selectedId);
+		void this.deps.service.markVisited?.(this.selectedId)?.catch(() => {});
 		this.sessionScrollTop = 0;
 		this.mode = "session";
 	}
@@ -2009,18 +1996,6 @@ function isAgentBusy(row: Row): boolean {
 	return Boolean(row.alive && (st === "queued" || st === "working" || waitingOnTool));
 }
 
-function completedSummary(summary: string, _latestAssistantPreview: string): string {
-	if (!isGenericStatusText(summary)) return compactCompletedSummary(summary);
-	return "Done";
-}
-
-function compactCompletedSummary(text: string): string {
-	const cleaned = String(text || "").replace(/\s+/g, " ").trim();
-	if (!cleaned) return "Done";
-	const first = firstSentence(cleaned);
-	return truncate(first.length >= 12 ? first : cleaned, 80);
-}
-
 function displayPath(path: string): string {
 	const home = process.env.HOME;
 	if (home && path.startsWith(home)) return `~${path.slice(home.length)}` || "~";