@zhuxixi/pi-agent-board 0.6.2 → 0.7.0

package/src/ui/dashboard.ts

@@ -11,7 +11,7 @@ import { CustomEditor } from "@earendil-works/pi-coding-agent";
 import type { Component, EditorTheme, KeybindingsManager, TUI } from "@earendil-works/pi-tui";
 import { Key, matchesKey, truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
 import { requestDashboardRender } from "../core/dashboard-render.mjs";
-import { isGenericStatusText, normalizeGenericStatusText } from "../core/derive.mjs";
+import { normalizeGenericStatusText } from "../core/derive.mjs";
 import { firstSentence, truncate } from "../core/heuristics.mjs";
 import {
 	canonicalModelRef,
@@ -31,7 +31,7 @@ import { filterRows, groupRowsByFolder, rowState, stateGlyph } from "../core/row
 import { loadSessionView } from "../core/session-view.mjs";
 import { GROUP_LABELS } from "../core/types.mjs";
 import { buildEvidencePanel } from "./dashboard-evidence.mjs";
-import { readState, writeState, type Row } from "../core/store.mjs";
+import { type Row } from "../core/store.mjs";
 import type { createService } from "../runtime/service.mjs";
 
 type Service = ReturnType<typeof createService>;
@@ -847,44 +847,49 @@ export class DashboardComponent implements Component {
 		const launchCwd = launchOpts?.cwd ?? this.deps.defaultCwd;
 		const launchModel = launchOpts?.model ?? (this.launch?.model ? canonicalModelRef(this.launch.model) : null);
 		const launchThinking = launchOpts?.thinkingLevel ?? this.launch?.thinking ?? this.deps.currentThinkingLevel;
-		const res = this.deps.service.dispatch(text, {
-			cwd: launchCwd,
-			model: launchModel,
-			thinkingLevel: launchThinking,
-		});
-		if (!res.ok) this.notice(res.error ?? "Dispatch failed", "error");
-		else {
-			this.lastLaunchPrefs = { ...this.deps.service.getLaunchPrefs?.(), cwd: launchCwd, model: launchModel, thinkingLevel: launchThinking };
-			try {
-				recordCwdLaunch(this.deps.root, launchCwd);
-			} catch {
-				/* best effort: stats must never block dispatch */
-			}
-			try {
-				this.deps.service.saveLaunchPrefs?.(this.lastLaunchPrefs);
-			} catch {
-				/* best effort */
-			}
-			this.selectedId = res.viewId ?? this.selectedId;
-			if (launchOpts?.attach && res.hostMode === "pty" && res.viewId) {
-				this.setInput("");
-				this.launch = null;
-				this.mode = "list";
-				this.inputNotice = null;
-				this.done({ action: "attach", viewId: res.viewId, stopFirst: false });
-				return;
-			}
-			if (res.hostMode === "json-runner") {
-				this.notice(launchOpts?.attach ? `Start & attach needs PTY; launched in background: ${res.fallbackReason ?? "PTY unavailable"}` : `Dispatched with non-live fallback: ${res.fallbackReason ?? "PTY unavailable"}`, "warn");
-			} else {
-				this.notice(`Dispatched: ${truncate(text, 40)}`, "info");
+		// dispatch is async (mark_queued routes through the view-state coordinator
+		// before the runner spawns, issue #91); notices/attach land when it settles.
+		void Promise.resolve(
+			this.deps.service.dispatch(text, {
+				cwd: launchCwd,
+				model: launchModel,
+				thinkingLevel: launchThinking,
+			}),
+		).then((res) => {
+			if (!res.ok) this.notice(res.error ?? "Dispatch failed", "error");
+			else {
+				this.lastLaunchPrefs = { ...this.deps.service.getLaunchPrefs?.(), cwd: launchCwd, model: launchModel, thinkingLevel: launchThinking };
+				try {
+					recordCwdLaunch(this.deps.root, launchCwd);
+				} catch {
+					/* best effort: stats must never block dispatch */
+				}
+				try {
+					this.deps.service.saveLaunchPrefs?.(this.lastLaunchPrefs);
+				} catch {
+					/* best effort */
+				}
+				this.selectedId = res.viewId ?? this.selectedId;
+				if (launchOpts?.attach && res.hostMode === "pty" && res.viewId) {
+					this.setInput("");
+					this.launch = null;
+					this.mode = "list";
+					this.inputNotice = null;
+					this.done({ action: "attach", viewId: res.viewId, stopFirst: false });
+					return;
+				}
+				if (res.hostMode === "json-runner") {
+					this.notice(launchOpts?.attach ? `Start & attach needs PTY; launched in background: ${res.fallbackReason ?? "PTY unavailable"}` : `Dispatched with non-live fallback: ${res.fallbackReason ?? "PTY unavailable"}`, "warn");
+				} else {
+					this.notice(`Dispatched: ${truncate(text, 40)}`, "info");
+				}
 			}
-		}
-		this.setInput("");
-		this.launch = null;
-		this.mode = "list";
-		this.inputNotice = null;
-		this.refresh();
+			this.setInput("");
+			this.launch = null;
+			this.mode = "list";
+			this.inputNotice = null;
+			this.refresh();
+		});
 	}
 
 	private async submitReply(): Promise<void> {
@@ -947,10 +952,11 @@ export class DashboardComponent implements Component {
 		this.pending = {
 			prompt: `Mark "${row.meta.name}" as done? (y/N)`,
 			onYes: () => {
-				const res = this.markCompleted(row);
-				if (!res.ok) this.notice(res.error ?? "Mark done failed", "error");
-				else this.notice("Marked done", "info");
-				this.refresh();
+				void this.markCompleted(row).then((res) => {
+					if (!res.ok) this.notice(res.error ?? "Mark done failed", "error");
+					else this.notice("Marked done", "info");
+					this.refresh();
+				});
 			},
 		};
 		this.mode = "confirm";
@@ -966,57 +972,25 @@ export class DashboardComponent implements Component {
 			prompt: `Mark ${doneIds.length} selected session${doneIds.length === 1 ? "" : "s"} as done?${skipped ? ` ${skipped} will be skipped.` : ""} (y/N)`,
 			returnMode: "select",
 			onYes: () => {
-				const res = this.deps.service.markCompletedMany?.(doneIds) ?? { ok: true, completed: 0, skipped: doneIds.length, completedIds: [] };
-				if (!res.ok) this.notice("Mark done failed", "error");
-				else {
-					if (res.completedIds?.length) this.selectedId = res.completedIds[0];
-					this.notice(`Moved ${res.completed} to Done${res.skipped ? ` · skipped ${res.skipped}` : ""}`, "info");
-				}
-				this.refresh();
+				void Promise.resolve(this.deps.service.markCompletedMany?.(doneIds) ?? { ok: true, completed: 0, skipped: doneIds.length, completedIds: [] }).then((res) => {
+					if (!res.ok) this.notice("Mark done failed", "error");
+					else {
+						if (res.completedIds?.length) this.selectedId = res.completedIds[0];
+						this.notice(`Moved ${res.completed} to Done${res.skipped ? ` · skipped ${res.skipped}` : ""}`, "info");
+					}
+					this.refresh();
+				});
 			},
 		};
 		this.mode = "confirm";
 	}
 
-	private markCompleted(row: Row): { ok: boolean; error?: string } {
-		const service = this.deps.service as Service & { markCompleted?: (viewId: string) => { ok: boolean; error?: string } };
-		if (typeof service.markCompleted === "function") return service.markCompleted(row.meta.id);
-
-		// Compatibility guard for an already-open dashboard whose service object came
-		// from an older module instance. The service owns this path normally.
-		const state = readState(service.root, row.meta.id) ?? row.state ?? {
-			version: 1,
-			viewId: row.meta.id,
-			currentRunId: null,
-			semanticState: "idle",
-			processState: "exited",
-			summary: "Needs instructions",
-			lastActivityAt: Date.now(),
-			updatedAt: Date.now(),
-			needsInput: false,
-			hasError: false,
-			latestAssistantPreview: "",
-			latestTool: null,
-			question: null,
-			pendingQuestions: [],
-			error: null,
-			lastVisitedAt: null,
-			lastAgentActivityAt: null,
-			autoState: null,
-		};
-		state.semanticState = "completed";
-		state.processState = "exited";
-		state.needsInput = false;
-		state.hasError = false;
-		state.question = null;
-		state.pendingQuestions = [];
-		state.error = null;
-		state.autoState = null;
-		state.summary = completedSummary(state.summary, state.latestAssistantPreview);
-		state.lastActivityAt = Date.now();
-		state.updatedAt = Date.now();
-		writeState(service.root, state);
-		return { ok: true };
+	// Routes through the View State Coordinator (issue #91): the service's
+	// markCompleted submits a fenced state command. No compat fallback for stale
+	// pre-coordinator service objects — the window is transient and self-heals
+	// on the next dashboard reload.
+	private markCompleted(row: Row): Promise<{ ok: boolean; error?: string }> {
+		return this.deps.service.markCompleted(row.meta.id);
 	}
 
 	private handleDeleteKey(): void {
@@ -1025,10 +999,13 @@ export class DashboardComponent implements Component {
 		const now = Date.now();
 		if (this.deleteArm !== null && this.deleteArm.id === row.meta.id && now - this.deleteArm.at <= DELETE_DOUBLE_PRESS_MS) {
 			this.deleteArm = null;
-			const res = this.deps.service.archive(row.meta.id);
-			if (!res.ok) this.notice(res.error ?? "Delete failed", "error");
-			else this.notice(`Deleted "${row.meta.name}"`, "info");
-			this.refresh();
+			// archive is async (routes through the view-state coordinator, issue #91);
+			// the notice + refresh land when the command settles.
+			void Promise.resolve(this.deps.service.archive(row.meta.id)).then((res) => {
+				if (!res.ok) this.notice(res.error ?? "Delete failed", "error");
+				else this.notice(`Deleted "${row.meta.name}"`, "info");
+				this.refresh();
+			});
 			return;
 		}
 		this.deleteArm = { id: row.meta.id, at: now };
@@ -1063,11 +1040,13 @@ export class DashboardComponent implements Component {
 			prompt: `Delete ${rows.length} done session${rows.length === 1 ? "" : "s"}? Session files are preserved. (y/N)`,
 			returnMode: "select",
 			onYes: () => {
-				const res = this.deps.service.archiveMany?.(rows.map((row) => row.meta.id)) ?? { ok: true, archived: 0, skipped: rows.length };
-				if (!res.ok) this.notice("Delete failed", "error");
-				else this.notice(`Deleted ${res.archived}${res.skipped ? ` · skipped ${res.skipped}` : ""}`, "info");
-				this.exitSelectionMode(true);
-				this.refresh();
+				// archiveMany is async (coordinator-routed, issue #91).
+				void Promise.resolve(this.deps.service.archiveMany?.(rows.map((row) => row.meta.id)) ?? { ok: true, archived: 0, skipped: rows.length }).then((res) => {
+					if (!res.ok) this.notice("Delete failed", "error");
+					else this.notice(`Deleted ${res.archived}${res.skipped ? ` · skipped ${res.skipped}` : ""}`, "info");
+					this.exitSelectionMode(true);
+					this.refresh();
+				});
 			},
 		};
 		this.mode = "confirm";
@@ -2009,18 +1988,6 @@ function isAgentBusy(row: Row): boolean {
 	return Boolean(row.alive && (st === "queued" || st === "working" || waitingOnTool));
 }
 
-function completedSummary(summary: string, _latestAssistantPreview: string): string {
-	if (!isGenericStatusText(summary)) return compactCompletedSummary(summary);
-	return "Done";
-}
-
-function compactCompletedSummary(text: string): string {
-	const cleaned = String(text || "").replace(/\s+/g, " ").trim();
-	if (!cleaned) return "Done";
-	const first = firstSentence(cleaned);
-	return truncate(first.length >= 12 ? first : cleaned, 80);
-}
-
 function displayPath(path: string): string {
 	const home = process.env.HOME;
 	if (home && path.startsWith(home)) return `~${path.slice(home.length)}` || "~";

package/src/ui/pty-attach.ts

@@ -7,7 +7,7 @@ import type { Component, KeybindingsManager, TUI } from "@earendil-works/pi-tui"
 import { CURSOR_MARKER, Key, matchesKey, truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
 import { isProbablyEmptyPiInputLine, isProbablyPiInputLine, resolveEditorEmpty } from "../core/pty-input.mjs";
 import { findHttpUrlAtCells, findWordRangeAtCells } from "../core/pty-links.mjs";
-import { createAttachOutputRenderScheduler, nextAttachRender, projectPtyCursor, shouldScheduleAttachRenderForMessage } from "../core/pty-attach-render.mjs";
+import { createAttachOutputRenderScheduler, detectCursorDesync, nextAttachRender, projectPtyCursor, shouldScheduleAttachRenderForMessage } from "../core/pty-attach-render.mjs";
 import { evaluateAttachReconnect, shouldEscapeAttach } from "../core/pty-attach-reconnect.mjs";
 import { installImeCursorCoalesce } from "../core/ime-cursor-coalesce.mjs";
 import { createJiggleRetryController } from "../core/pty-attach-jiggle-controller.mjs";
@@ -42,6 +42,15 @@ const ATTACH_SETTLE_MS = 250;
 const ATTACH_HARD_TIMEOUT_MS = 2500;
 /** Give ordered detach packets time to flush before using destroy as a fallback. */
 const GRACEFUL_SOCKET_CLOSE_MS = 1000;
+/** Desync detection window: how long output must stay silent before a
+ * misaligned cursor counts as desync (issue #11). Streaming keeps the cursor
+ * on plain output cells legitimately; a healthy idle child re-parks it on the
+ * inverse fake-cursor cell on its last rendered frame. */
+const DESYNC_QUIET_MS = 1500;
+/** How often the post-settle probe runs checkDesync() (issue #11). */
+const DESYNC_PROBE_INTERVAL_MS = 2000;
+/** Minimum spacing between two runtime heals (issue #11). */
+const HEAL_RATELIMIT_MS = 10000;
 /** How many tail bytes of the screen log to replay on attach. Read from the file tail
  * (not the whole file) so multi-MB logs don't block startup; ~60KB covers the last
  * handful of screens, which is all a fresh attach needs. */
@@ -150,6 +159,13 @@ export class PtyAttachComponent implements Component {
 	private rows = 24;
 	// Absolute buffer line shown at the top of the viewport. null means follow bottom.
 	private viewportTop: number | null = null;
+	// Runtime desync backstop state (issue #11): last socket-output timestamp,
+	// last heal timestamp, the probe timer, and an injectable clock for tests.
+	private lastOutputAt = 0;
+	private lastHealAt = 0;
+	private desyncProbeTimer: ReturnType<typeof setInterval> | null = null;
+	/** Injectable clock for desync gating (tests override this). */
+	private nowFn: () => number = () => Date.now();
 	private selection: MouseSelection | null = null;
 	private selectionDragging = false;
 	private selectionAutoScrollTimer: ReturnType<typeof setInterval> | null = null;
@@ -541,6 +557,48 @@ export class PtyAttachComponent implements Component {
 		// Force a full clear so the loading banner is replaced atomically by the settled
 		// buffer, instead of diffing banner lines into buffer lines.
 		this.scheduleRender(true);
+		this.startDesyncProbe();
+	}
+
+	private startDesyncProbe(): void {
+		this.stopDesyncProbe();
+		// The probe is deliberately NOT hooked into the render path: rendering is
+		// event-driven (socket output / keypress / resize) and stops exactly when
+		// desync strikes (output goes quiet). A self-contained timer is the only
+		// way an idle desynced screen gets its self-heal without user action.
+		this.desyncProbeTimer = setInterval(() => this.checkDesync(), DESYNC_PROBE_INTERVAL_MS);
+		this.desyncProbeTimer.unref?.();
+	}
+
+	private stopDesyncProbe(): void {
+		if (this.desyncProbeTimer) {
+			clearInterval(this.desyncProbeTimer);
+			this.desyncProbeTimer = null;
+		}
+	}
+
+	/**
+	 * Runtime desync backstop (issue #11). Seven gates, cheapest first:
+	 * settled+connected, child is a TUI (frame seen), chain idle, output quiet,
+	 * heal rate limit, misaligned cursor. All pass → heal() re-arms
+	 * shrink-and-hold; the child's fullRender clear then restores the size
+	 * and repaints a consistent screen.
+	 */
+	private checkDesync(): void {
+		if (this.closed || this.attaching || !this.connected) return; // gates 1, 7
+		const chain = this.jiggleRetry.getState();
+		if (!chain.tuiFrameSeen) return; // gate 2: shell/vim children never heal
+		if (!chain.stopped || chain.held) return; // gate 5: attach/heal chain active
+		const now = this.nowFn();
+		if (now - this.lastOutputAt <= DESYNC_QUIET_MS) return; // gate 4: streaming
+		if (now - this.lastHealAt <= HEAL_RATELIMIT_MS) return; // gate 6: rate limit
+		const height = this.bodyHeight();
+		this.clampViewportTop(height);
+		const start = this.viewportTop ?? this.bottomViewportTop(height);
+		const buf = this.term.buffer.active;
+		if (detectCursorDesync(buf, projectPtyCursor(buf, start, height)) !== "misaligned") return; // gate 3
+		this.lastHealAt = now;
+		this.jiggleRetry.heal(this.cols, this.rows);
 	}
 
 	private clearMouseRefreshTimers(): void {
@@ -1060,6 +1118,9 @@ export class PtyAttachComponent implements Component {
 
 	private pushOutput(data: string, opts: { forwardProtocols?: boolean } = {}): void {
 		if (data.length === 0) return;
+		// Recorded synchronously BEFORE term.write (whose callback is async): the
+		// desync quiet-window must measure when output ARRIVED, not when parsing finished.
+		this.lastOutputAt = this.nowFn();
 		if (opts.forwardProtocols) this.forwardTerminalProtocols(data);
 		// @xterm/headless parses asynchronously; the buffer is only populated once this
 		// callback fires. Mark the buffer as ready (so the project path can paint it), but
@@ -1110,6 +1171,7 @@ export class PtyAttachComponent implements Component {
 		this.clearRetry();
 		this.stopLoadingTicker();
 		this.outputRenderScheduler.dispose();
+		this.stopDesyncProbe();
 		if (this.attachSettleTimer) {
 			clearTimeout(this.attachSettleTimer);
 			this.attachSettleTimer = null;