@zhushanwen/pi-todo 0.1.6 → 0.2.0

package/src/__tests__/todo.test.ts

@@ -1,4 +1,5 @@
-import { describe, expect,it } from "vitest";
+import type { Theme } from "@mariozechner/pi-coding-agent";
+import { describe, expect, it } from "vitest";
 
 import {
 	addTodos,
@@ -9,179 +10,101 @@ import {
 	updateTodos,
 	VALID_STATUSES,
 } from "../model";
+import { renderWidgetLines } from "../render";
 
-// ── Task 1: 数据模型增强 + 向后兼容 ──────────────────
+// ── 数据模型 + 向后兼容 ──────────────────────────────
 
-describe("Todo data model - Task 1", () => {
+describe("Todo data model", () => {
 	it("should load old data without verifyText/verifyAttempts", () => {
-		// 旧格式: 没有 verifyText 和 verifyAttempts 字段
 		const oldTodo = { id: 1, text: "test", status: "completed" } as unknown as Todo;
 		const migrated = migrateTodo(oldTodo);
 
-		expect(migrated.verifyText).toBeUndefined();
-		expect(migrated.verifyAttempts).toBe(0);
 		expect(migrated.status).toBe("completed");
 		expect(migrated.text).toBe("test");
 		expect(migrated.id).toBe(1);
 	});
 
-	it("should accept failed status", () => {
-		const todo: Todo = {
-			id: 1,
-			text: "test",
-			status: "failed",
-			verifyAttempts: 2,
-		};
-		const migrated = migrateTodo(todo);
-
-		expect(migrated.status).toBe("failed");
-		expect(migrated.verifyAttempts).toBe(2);
-		expect(VALID_STATUSES).toContain("failed");
+	it("should include exactly three valid statuses", () => {
+		expect(VALID_STATUSES).toEqual(["pending", "in_progress", "completed"]);
 	});
 
-	it("should set verifyAttempts default to 0 when migrating old data", () => {
-		const oldTodo = { id: 5, text: "old task", status: "pending" } as unknown as Todo;
+	it("should migrate verifying → in_progress", () => {
+		const oldTodo = { id: 1, text: "test", status: "verifying" } as unknown as Todo;
 		const migrated = migrateTodo(oldTodo);
-
-		expect(migrated.verifyAttempts).toBe(0);
+		expect(migrated.status).toBe("in_progress");
 	});
 
-	it("should preserve verifyText when present in old data", () => {
-		const todo = {
-			id: 2,
-			text: "task",
-			status: "completed",
-			verifyText: "check output",
-			verifyAttempts: 1,
-		} as unknown as Todo;
-		const migrated = migrateTodo(todo);
-
-		expect(migrated.verifyText).toBe("check output");
-		expect(migrated.verifyAttempts).toBe(1);
+	it("should migrate failed → pending", () => {
+		const oldTodo = { id: 1, text: "test", status: "failed" } as unknown as Todo;
+		const migrated = migrateTodo(oldTodo);
+		expect(migrated.status).toBe("pending");
 	});
 
-	it("should migrate done:true to completed with default verify fields", () => {
-		// 极旧格式: done: boolean
+	it("should migrate done:true to completed", () => {
 		const veryOldTodo = { id: 3, text: "ancient", done: true } as unknown as Todo;
 		const migrated = migrateTodo(veryOldTodo);
-
 		expect(migrated.status).toBe("completed");
-		expect(migrated.verifyText).toBeUndefined();
-		expect(migrated.verifyAttempts).toBe(0);
 	});
 
-	it("should migrate done:false to pending with default verify fields", () => {
+	it("should migrate done:false to pending", () => {
 		const veryOldTodo = { id: 4, text: "ancient2", done: false } as unknown as Todo;
 		const migrated = migrateTodo(veryOldTodo);
-
 		expect(migrated.status).toBe("pending");
-		expect(migrated.verifyText).toBeUndefined();
-		expect(migrated.verifyAttempts).toBe(0);
-	});
-
-	it("should include all five valid statuses", () => {
-		expect(VALID_STATUSES).toEqual(["pending", "in_progress", "verifying", "completed", "failed"]);
-	});
-
-	it("should preserve evidence when migrating old data", () => {
-		const todo = {
-			id: 1,
-			text: "task",
-			status: "verifying",
-			verifyText: "check X",
-			evidence: "grep confirmed no residual",
-			verifyAttempts: 0,
-		} as unknown as Todo;
-		const migrated = migrateTodo(todo);
-		expect(migrated.evidence).toBe("grep confirmed no residual");
-		expect(migrated.status).toBe("verifying");
-	});
-
-	it("should default evidence to undefined when absent", () => {
-		const oldTodo = { id: 1, text: "test", status: "pending" } as unknown as Todo;
-		const migrated = migrateTodo(oldTodo);
-		expect(migrated.evidence).toBeUndefined();
 	});
 });
 
-// ── Task 2: todo add 支持 verifyTexts 参数 ────────────
-
-describe("todo add verifyTexts - Task 2", () => {
-	it("should map verifyTexts to todos at corresponding indices", () => {
-		const result = addTodos([], 1, ["A", "B"], ["V1"]);
+// ── todo add ────────────────────────────────────────
 
+describe("todo add", () => {
+	it("should add todos with sequential IDs", () => {
+		const result = addTodos([], 1, ["A", "B"]);
 		expect(result.error).toBeUndefined();
 		expect(result.newTodos).toHaveLength(2);
-		expect(result.newTodos[0].verifyText).toBe("V1");
-		expect(result.newTodos[1].verifyText).toBeUndefined();
-		expect(result.newTodos[0].verifyAttempts).toBe(0);
-		expect(result.newTodos[1].verifyAttempts).toBe(0);
-	});
-
-	it("should reject verifyTexts longer than texts", () => {
-		const result = addTodos([], 1, ["A"], ["V1", "V2"]);
-
-		expect(result.error).toBe("verifyTexts too long");
-		expect(result.resultText).toContain("Error");
-		expect(result.newTodos).toHaveLength(0);
-	});
-
-	it("should work without verifyTexts (backward compat)", () => {
-		const result = addTodos([], 1, ["A"]);
-
-		expect(result.error).toBeUndefined();
-		expect(result.newTodos).toHaveLength(1);
-		expect(result.newTodos[0].verifyText).toBeUndefined();
-		expect(result.newTodos[0].verifyAttempts).toBe(0);
+		expect(result.newTodos[0].id).toBe(1);
+		expect(result.newTodos[1].id).toBe(2);
+		expect(result.newTodos[0].status).toBe("pending");
 	});
 
-	it("should map all verifyTexts when lengths match", () => {
-		const result = addTodos([], 1, ["A", "B", "C"], ["V1", "V2", "V3"]);
-
+	it("should append to existing todos", () => {
+		const existing: Todo[] = [{ id: 1, text: "existing", status: "pending" }];
+		const result = addTodos(existing, 2, ["new task"]);
 		expect(result.error).toBeUndefined();
-		expect(result.newTodos).toHaveLength(3);
-		expect(result.newTodos[0].verifyText).toBe("V1");
-		expect(result.newTodos[1].verifyText).toBe("V2");
-		expect(result.newTodos[2].verifyText).toBe("V3");
+		expect(result.newTodos).toHaveLength(2);
+		expect(result.newTodos[1].id).toBe(2);
+		expect(result.newTodos[1].text).toBe("new task");
+		expect(result.newNextId).toBe(3);
 	});
 
 	it("should return error when texts is empty", () => {
 		const result = addTodos([], 1, []);
-
 		expect(result.error).toBe("texts required");
 	});
 
 	it("should return error when all texts are empty after trim", () => {
 		const result = addTodos([], 1, ["  ", " "]);
-
 		expect(result.error).toBe("all texts empty");
 	});
 
-	it("should trim texts and assign correct IDs", () => {
-		const existing: Todo[] = [{ id: 1, text: "existing", status: "pending", verifyAttempts: 0 }];
-		const result = addTodos(existing, 2, ["  new task  "]);
-
+	it("should trim texts", () => {
+		const result = addTodos([], 1, ["  new task  "]);
 		expect(result.error).toBeUndefined();
-		expect(result.newTodos).toHaveLength(2);
-		expect(result.newTodos[1].id).toBe(2);
-		expect(result.newTodos[1].text).toBe("new task");
-		expect(result.newNextId).toBe(3);
+		expect(result.newTodos[0].text).toBe("new task");
 	});
 });
 
-// ── Task 3: todo update batch updates[] ──────────────
+// ── todo update batch ───────────────────────────────
 
-describe("todo update batch - Task 3", () => {
+describe("todo update batch", () => {
 	it("should update multiple todos with updates[]", () => {
 		const todos: Todo[] = [
-			{ id: 1, text: "A", status: "pending", verifyAttempts: 0 },
-			{ id: 2, text: "B", status: "in_progress", verifyAttempts: 0 },
-			{ id: 3, text: "C", status: "pending", verifyAttempts: 0 },
+			{ id: 1, text: "A", status: "pending" },
+			{ id: 2, text: "B", status: "in_progress" },
+			{ id: 3, text: "C", status: "pending" },
 		];
 		const result = updateTodos(todos, [
 			{ id: 1, status: "completed" },
 			{ id: 2, text: "B updated" },
-			{ id: 3, status: "failed", text: "C failed" },
+			{ id: 3, status: "completed", text: "C done" },
 		]);
 
 		expect(result.error).toBeUndefined();
@@ -189,222 +112,217 @@ describe("todo update batch - Task 3", () => {
 		expect(result.updatedTodos[0].status).toBe("completed");
 		expect(result.updatedTodos[0].text).toBe("A");
 		expect(result.updatedTodos[1].text).toBe("B updated");
-		expect(result.updatedTodos[1].status).toBe("in_progress"); // unchanged
-		expect(result.updatedTodos[2].status).toBe("failed");
-		expect(result.updatedTodos[2].text).toBe("C failed");
-		expect(result.resultText).toBe("Updated 3 todo(s)");
+		expect(result.updatedTodos[1].status).toBe("in_progress");
+		expect(result.updatedTodos[2].status).toBe("completed");
+		expect(result.updatedTodos[2].text).toBe("C done");
 	});
 
 	it("should reject duplicate ids in updates[]", () => {
-		const todos: Todo[] = [
-			{ id: 1, text: "A", status: "pending", verifyAttempts: 0 },
-		];
+		const todos: Todo[] = [{ id: 1, text: "A", status: "pending" }];
 		const result = updateTodos(todos, [
 			{ id: 1, status: "completed" },
 			{ id: 1, status: "pending" },
 		]);
-
 		expect(result.error).toBe("duplicate ids in updates");
-		expect(result.updatedTodos).toEqual(todos); // unchanged
+		expect(result.updatedTodos).toEqual(todos);
 	});
 
-	it("should reject non-existent ids in updates[] (all-or-nothing)", () => {
-		const todos: Todo[] = [
-			{ id: 1, text: "A", status: "pending", verifyAttempts: 0 },
-		];
-		const result = updateTodos(todos, [
-			{ id: 1, status: "completed" },
-			{ id: 999, status: "pending" },
-		]);
-
+	it("should reject non-existent ids", () => {
+		const todos: Todo[] = [{ id: 1, text: "A", status: "pending" }];
+		const result = updateTodos(todos, [{ id: 999, status: "pending" }]);
 		expect(result.error).toBe("id 999 not found");
-		expect(result.updatedTodos[0].status).toBe("pending"); // #1 not modified
 	});
 
 	it("should reject updates[] item missing both status and text", () => {
-		const todos: Todo[] = [
-			{ id: 1, text: "A", status: "pending", verifyAttempts: 0 },
-		];
+		const todos: Todo[] = [{ id: 1, text: "A", status: "pending" }];
 		const result = updateTodos(todos, [{ id: 1 }]);
-
 		expect(result.error).toContain("neither status nor text");
-		expect(result.updatedTodos[0].status).toBe("pending"); // unchanged
 	});
-});
 
-// ── Task 4: todo list verifyText ────────────────────
-
-describe("todo list verifyText - Task 4", () => {
-	it("should include verifyText in list output when present", () => {
-		const todo: Todo = {
-			id: 1,
-			text: "check output",
-			status: "pending",
-			verifyText: "check X",
-			verifyAttempts: 0,
-		};
-		const line = formatTodoLine(todo);
-
-		expect(line).toContain(" | 验证: check X");
-		expect(line).toContain("#1");
-		expect(line).toContain("check output");
-	});
-
-	it("should not include verify suffix when verifyText is absent", () => {
-		const todo: Todo = {
-			id: 2,
-			text: "plain task",
-			status: "completed",
-			verifyAttempts: 0,
-		};
-		const line = formatTodoLine(todo);
-
-		expect(line).not.toContain("验证");
-		expect(line).toContain("#2");
-		expect(line).toContain("plain task");
-	});
-
-	it("should show verifying status with evidence", () => {
-		const todo: Todo = {
-			id: 3,
-			text: "fix auth",
-			status: "verifying",
-			verifyText: "check status codes",
-			evidence: "grep confirmed no display:true residual",
-			verifyAttempts: 0,
-		};
-		const line = formatTodoLine(todo);
-
-		expect(line).toContain("[v]");
-		expect(line).toContain("验证中: grep confirmed no display:true residual");
-	});
-
-	it("should show completed with evidence", () => {
-		const todo: Todo = {
-			id: 4,
-			text: "fix login",
-			status: "completed",
-			verifyText: "密码错误时返回正确错误码",
-			evidence: "42 测试全通过，typecheck 无错误",
-			verifyAttempts: 0,
-		};
-		const line = formatTodoLine(todo);
-
-		expect(line).toContain("[x]");
-		expect(line).toContain("已验证: 42 测试全通过");
+	it("should reject invalid status values", () => {
+		const todos: Todo[] = [{ id: 1, text: "A", status: "pending" }];
+		const result = updateTodos(todos, [{ id: 1, status: "banana" }]);
+		expect(result.error).toContain("invalid status");
 	});
 });
 
-// ── Task 5: agent_end loop logic (pure data model tests) ──────────
+// ── completed 无拦截 ────────────────────────────────
 
-describe("agent_end loop logic - Task 5", () => {
-	const MAX_VERIFY_ATTEMPTS = 2;
+describe("completed without interception", () => {
+	it("should allow in_progress → completed directly", () => {
+		const todos: Todo[] = [{ id: 1, text: "simple", status: "in_progress" }];
+		const result = updateTodos(todos, [{ id: 1, status: "completed" }]);
+		expect(result.error).toBeUndefined();
+		expect(result.updatedTodos[0].status).toBe("completed");
+	});
+
+	it("should allow pending → completed directly", () => {
+		const todos: Todo[] = [{ id: 1, text: "skip", status: "pending" }];
+		const result = updateTodos(todos, [{ id: 1, status: "completed" }]);
+		expect(result.error).toBeUndefined();
+		expect(result.updatedTodos[0].status).toBe("completed");
+	});
 
-	it("should detect completed tasks needing verification", () => {
+	it("should allow batch all completed without evidence", () => {
 		const todos: Todo[] = [
-			{
-				id: 1,
-				text: "task A",
-				status: "completed",
-				verifyText: "check output",
-				verifyAttempts: 0,
-			},
+			{ id: 1, text: "A", status: "in_progress" },
+			{ id: 2, text: "B", status: "in_progress" },
 		];
+		const result = updateTodos(todos, [
+			{ id: 1, status: "completed" },
+			{ id: 2, status: "completed" },
+		]);
+		expect(result.error).toBeUndefined();
+		expect(result.updatedTodos[0].status).toBe("completed");
+		expect(result.updatedTodos[1].status).toBe("completed");
+	});
+});
 
-		const needsVerify = todos.find(
-			(t) =>
-				t.status === "completed" &&
-				t.verifyText &&
-				t.verifyAttempts < MAX_VERIFY_ATTEMPTS,
-		);
+// ── formatTodoLine ──────────────────────────────────
 
-		expect(needsVerify).toBeDefined();
-		expect(needsVerify!.id).toBe(1);
-		expect(needsVerify!.verifyText).toBe("check output");
+describe("formatTodoLine", () => {
+	it("should format pending todo", () => {
+		const todo: Todo = { id: 1, text: "task A", status: "pending" };
+		expect(formatTodoLine(todo)).toBe("[ ] #1: task A");
 	});
 
-	it("should not trigger verify for tasks without verifyText", () => {
-		const todos: Todo[] = [
-			{
-				id: 1,
-				text: "task A",
-				status: "completed",
-				verifyAttempts: 0,
-			},
-		];
-
-		const needsVerify = todos.find(
-			(t) =>
-				t.status === "completed" &&
-				t.verifyText &&
-				t.verifyAttempts < MAX_VERIFY_ATTEMPTS,
-		);
+	it("should format in_progress todo", () => {
+		const todo: Todo = { id: 2, text: "task B", status: "in_progress" };
+		expect(formatTodoLine(todo)).toBe("[~] #2: task B");
+	});
 
-		expect(needsVerify).toBeUndefined();
+	it("should format completed todo", () => {
+		const todo: Todo = { id: 3, text: "task C", status: "completed" };
+		expect(formatTodoLine(todo)).toBe("[x] #3: task C");
 	});
+});
 
-	it("should detect verify failure when attempts exceed max (completed status)", () => {
+// ── buildRender ─────────────────────────────────────
+
+describe("buildRender", () => {
+	it("should calculate summary correctly", () => {
 		const todos: Todo[] = [
-			{
-				id: 2,
-				text: "task B",
-				status: "completed",
-				verifyText: "check B",
-				verifyAttempts: MAX_VERIFY_ATTEMPTS,
-			},
+			{ id: 1, text: "a", status: "completed" },
+			{ id: 2, text: "b", status: "pending" },
+			{ id: 3, text: "c", status: "in_progress" },
 		];
+		const render = buildRender(todos);
+		expect(render).toBeDefined();
+		expect(render!.summary).toBe("1/3 completed");
+		expect(render!.data.items).toHaveLength(3);
+	});
 
-		const failed = todos.find(
-			(t) =>
-				t.status === "completed" &&
-				t.verifyText &&
-				t.verifyAttempts >= MAX_VERIFY_ATTEMPTS,
-		);
-
-		expect(failed).toBeDefined();
-		failed!.status = "failed";
-		expect(failed!.status).toBe("failed");
+	it("should handle empty list", () => {
+		const render = buildRender([]);
+		expect(render!.summary).toBe("0/0 completed");
 	});
+});
 
-	it("should increment verifyAttempts when AI re-opens completed task with verifyText", () => {
+// ── widget 渲染布局 ────────────────────────────────
+
+const mockTheme = {
+	fg: (_color: string, text: string) => text,
+	bg: (_color: string, text: string) => text,
+	bold: (text: string) => text,
+	italic: (text: string) => text,
+	underline: (text: string) => text,
+	inverse: (text: string) => text,
+	strikethrough: (text: string) => text,
+	getFgAnsi: (_color: string) => "",
+	getBgAnsi: (_color: string) => "",
+	getColorMode: () => "truecolor" as const,
+	getThinkingBorderColor: () => (text: string) => text,
+	getBashModeBorderColor: () => (text: string) => text,
+} as unknown as Theme;
+
+describe("widget rendering", () => {
+	it("should render empty list as empty widget", () => {
+		expect(renderWidgetLines([], mockTheme, 80)).toEqual([]);
+	});
+
+	it("should use single column for 3 tasks", () => {
 		const todos: Todo[] = [
-			{ id: 1, text: "task A", status: "completed", verifyText: "check A", verifyAttempts: 0 },
+			{ id: 1, text: "A", status: "pending" },
+			{ id: 2, text: "B", status: "in_progress" },
+			{ id: 3, text: "C", status: "completed" },
 		];
+		const lines = renderWidgetLines(todos, mockTheme, 80);
+		expect(lines.length).toBe(4); // 1 header + 3 items
+		expect(lines[0]).toContain("1/3");
+		expect(lines[1]).toContain("#1");
+		expect(lines[2]).toContain("#2");
+		expect(lines[3]).toContain("#3");
+	});
+
+	it("should use single column up to 8 tasks", () => {
+		const todos: Todo[] = Array.from({ length: 8 }, (_, i) => ({
+			id: i + 1,
+			text: `Task ${i + 1}`,
+			status: "pending" as const,
+		}));
+		const lines = renderWidgetLines(todos, mockTheme, 80);
+		expect(lines.length).toBe(9); // 1 header + 8 items
+		for (let i = 1; i < lines.length; i++) {
+			expect(lines[i]).toContain(`#${i}`);
+		}
+	});
 
-		todos[0].status = "in_progress";
-		todos[0].verifyAttempts++;
-		expect(todos[0].verifyAttempts).toBe(1);
+	it("should switch to dual column for 9 tasks", () => {
+		const todos: Todo[] = Array.from({ length: 9 }, (_, i) => ({
+			id: i + 1,
+			text: `Task ${i + 1}`,
+			status: "pending" as const,
+		}));
+		const lines = renderWidgetLines(todos, mockTheme, 80);
+		expect(lines.length).toBe(6); // 1 header + ceil(9/2)=5 rows
+		expect(lines[0]).toContain("0/9");
+	});
+
+	it("should keep dual column within Pi widget max lines for 18 tasks", () => {
+		const todos: Todo[] = Array.from({ length: 18 }, (_, i) => ({
+			id: i + 1,
+			text: `Task ${i + 1}`,
+			status: "pending" as const,
+		}));
+		const lines = renderWidgetLines(todos, mockTheme, 80);
+		expect(lines.length).toBe(10); // 1 header + 9 rows
+	});
+
+	it("should keep widget lines within Pi max for 19 tasks", () => {
+		const todos: Todo[] = Array.from({ length: 19 }, (_, i) => ({
+			id: i + 1,
+			text: `Task ${i + 1}`,
+			status: "pending" as const,
+		}));
+		const lines = renderWidgetLines(todos, mockTheme, 80);
+		expect(lines.length).toBe(11); // 1 header + ceil(19/2)=10 rows; Pi truncates at 10
 	});
+});
+
+// ── agent_end logic (pure data) ─────────────────────
 
+describe("agent_end logic", () => {
 	it("should detect stall when no todo activity for threshold rounds", () => {
 		const STALL_THRESHOLD = 5;
 		const userMessageCount = 10;
 		const lastTodoCallCount = 3;
-		const todos: Todo[] = [
-			{ id: 1, text: "pending task", status: "pending", verifyAttempts: 0 },
-		];
-		const allCompletedAtCount = null;
+		const todos: Todo[] = [{ id: 1, text: "pending task", status: "pending" }];
 
 		const isStalled =
 			todos.length > 0 &&
-			allCompletedAtCount === null &&
 			userMessageCount - lastTodoCallCount >= STALL_THRESHOLD;
 
 		expect(isStalled).toBe(true);
 	});
 
 	it("should detect reminder when interval elapsed", () => {
-		const REMINDER_INTERVAL = 3;
-		const userMessageCount = 8;
-		const lastTodoCallCount = 4;
-		const todos: Todo[] = [
-			{ id: 1, text: "task", status: "pending", verifyAttempts: 0 },
-		];
-		const allCompletedAtCount = null;
+		const REMINDER_INTERVAL = 2;
+		const userMessageCount = 5;
+		const lastTodoCallCount = 3;
+		const todos: Todo[] = [{ id: 1, text: "task", status: "pending" }];
 
 		const needsReminder =
 			todos.length > 0 &&
-			allCompletedAtCount === null &&
 			userMessageCount - lastTodoCallCount >= REMINDER_INTERVAL;
 
 		expect(needsReminder).toBe(true);
@@ -434,327 +352,14 @@ describe("agent_end loop logic - Task 5", () => {
 		expect(shouldClear).toBe(false);
 	});
 
-	it("should format pending tasks with verifyText for context injection", () => {
-		const todos: Todo[] = [
-			{
-				id: 1,
-				text: "task A",
-				status: "pending",
-				verifyText: "check A",
-				verifyAttempts: 0,
-			},
-			{
-				id: 2,
-				text: "task B",
-				status: "in_progress",
-				verifyAttempts: 0,
-			},
-		];
-
-		const pendingTodos = todos.filter((t) => t.status !== "completed");
-		const lines = pendingTodos.map((t) => {
-			const verifyTag = t.verifyText
-				? ` [待验证: ${t.verifyText}]`
-				: "";
-			return `#${t.id}: ${t.text}${verifyTag}`;
-		});
-
-		expect(lines).toHaveLength(2);
-		expect(lines[0]).toBe("#1: task A [待验证: check A]");
-		expect(lines[1]).toBe("#2: task B");
-	});
-
-	it("should include verifying tasks as pending (not completed)", () => {
-		const todos: Todo[] = [
-			{ id: 1, text: "A", status: "verifying", verifyText: "check A", verifyAttempts: 0, evidence: "testing..." },
-			{ id: 2, text: "B", status: "completed", verifyAttempts: 0 },
-		];
-
-		const pendingTodos = todos.filter((t) => t.status !== "completed");
-		expect(pendingTodos).toHaveLength(1);
-		expect(pendingTodos[0].status).toBe("verifying");
-	});
-});
-
-// ── batch update validation - Task 3b ─────────────────
-
-describe("batch update validation - Task 3b", () => {
-	it("should reject invalid status values in updates[]", () => {
-		const todos: Todo[] = [{ id: 1, text: "A", status: "pending", verifyAttempts: 0 }];
-		const result = updateTodos(todos, [{ id: 1, status: "banana" }]);
-		expect(result.error).toContain("invalid status");
-		expect(result.updatedTodos[0].status).toBe("pending"); // unchanged
-	});
-
-	it("should accept valid status values in updates[]", () => {
-		const todos: Todo[] = [{ id: 1, text: "A", status: "pending", verifyAttempts: 0 }];
-		const result = updateTodos(todos, [{ id: 1, status: "completed" }]);
-		expect(result.error).toBeUndefined();
-		expect(result.updatedTodos[0].status).toBe("completed");
-	});
-});
-
-// ── verifyAttempts increment on re-open ─────────────
-
-describe("verifyAttempts increment on re-open", () => {
-	it("should increment verifyAttempts when status changes from completed to in_progress with verifyText", () => {
-		const todo: Todo = { id: 1, text: "fix auth", status: "completed", verifyText: "check status codes", verifyAttempts: 0 };
-
-		const oldStatus = todo.status;
-		todo.status = "in_progress";
-		if (oldStatus === "completed" && todo.verifyText && todo.verifyAttempts < 2) {
-			todo.verifyAttempts++;
-		}
-
-		expect(todo.verifyAttempts).toBe(1);
-		expect(todo.status).toBe("in_progress");
-	});
-
-	it("should NOT increment verifyAttempts when re-opening task without verifyText", () => {
-		const todo: Todo = { id: 1, text: "simple task", status: "completed", verifyAttempts: 0 };
-
-		const oldStatus = todo.status;
-		todo.status = "in_progress";
-		if (oldStatus === "completed" && todo.verifyText && todo.verifyAttempts < 2) {
-			todo.verifyAttempts++;
-		}
-
-		expect(todo.verifyAttempts).toBe(0); // no verifyText → no increment
-	});
-});
-
-// ── verifying state transitions ────────────────────
-
-describe("verifying state transitions", () => {
-	it("should block verifying on task without verifyText", () => {
-		const todos: Todo[] = [
-			{ id: 1, text: "simple", status: "in_progress", verifyAttempts: 0 },
-		];
-		const result = updateTodos(todos, [{ id: 1, status: "verifying", evidence: "this should be blocked" }]);
-
-		expect(result.blocked).toBeDefined();
-		expect(result.blocked!.length).toBe(1);
-		expect(result.blocked![0].reason).toContain("verifyText");
-		expect(result.updatedTodos[0].status).toBe("in_progress"); // unchanged
-	});
-
-	it("should block verifying without evidence", () => {
-		const todos: Todo[] = [
-			{ id: 1, text: "fix auth", status: "in_progress", verifyText: "check codes", verifyAttempts: 0 },
-		];
-		const result = updateTodos(todos, [{ id: 1, status: "verifying" }]);
-
-		expect(result.blocked).toBeDefined();
-		expect(result.blocked![0].reason).toContain("evidence");
-		expect(result.updatedTodos[0].status).toBe("in_progress");
-	});
-
-	it("should block verifying with evidence shorter than 10 chars", () => {
-		const todos: Todo[] = [
-			{ id: 1, text: "fix auth", status: "in_progress", verifyText: "check codes", verifyAttempts: 0 },
-		];
-		const result = updateTodos(todos, [{ id: 1, status: "verifying", evidence: "short" }]);
-
-		expect(result.blocked).toBeDefined();
-		expect(result.blocked![0].reason).toContain("10");
-	});
-
-	it("should allow verifying with valid evidence", () => {
-		const todos: Todo[] = [
-			{ id: 1, text: "fix auth", status: "in_progress", verifyText: "check codes", verifyAttempts: 0 },
-		];
-		const result = updateTodos(todos, [{ id: 1, status: "verifying", evidence: "grep confirmed no residual code" }]);
-
-		expect(result.error).toBeUndefined();
-		expect(result.blocked).toBeUndefined();
-		expect(result.updatedTodos[0].status).toBe("verifying");
-		expect(result.updatedTodos[0].evidence).toBe("grep confirmed no residual code");
-	});
-
-	it("should block verifying → completed without evidence", () => {
-		const todos: Todo[] = [
-			{ id: 1, text: "fix auth", status: "verifying", verifyText: "check codes", verifyAttempts: 0, evidence: "testing" },
-		];
-		const result = updateTodos(todos, [{ id: 1, status: "completed" }]);
-
-		expect(result.blocked).toBeDefined();
-		expect(result.blocked![0].reason).toContain("evidence");
-		expect(result.updatedTodos[0].status).toBe("verifying"); // unchanged
-	});
-
-	it("should allow verifying → completed with evidence", () => {
-		const todos: Todo[] = [
-			{ id: 1, text: "fix auth", status: "verifying", verifyText: "check codes", verifyAttempts: 0, evidence: "testing in progress" },
-		];
-		const result = updateTodos(todos, [{ id: 1, status: "completed", evidence: "all 42 tests passed, typecheck clean" }]);
-
-		expect(result.error).toBeUndefined();
-		expect(result.updatedTodos[0].status).toBe("completed");
-		expect(result.updatedTodos[0].evidence).toBe("all 42 tests passed, typecheck clean");
-	});
-
-	it("should allow in_progress → completed directly for tasks without verifyText", () => {
-		const todos: Todo[] = [
-			{ id: 1, text: "simple", status: "in_progress", verifyAttempts: 0 },
-		];
-		const result = updateTodos(todos, [{ id: 1, status: "completed" }]);
-
-		expect(result.error).toBeUndefined();
-		expect(result.blocked).toBeUndefined();
-		expect(result.updatedTodos[0].status).toBe("completed");
-	});
-
-	it("should block in_progress → completed on verifyText task without verified+evidence", () => {
-		const todos: Todo[] = [
-			{ id: 1, text: "fix auth", status: "in_progress", verifyText: "check codes", verifyAttempts: 0 },
-		];
-		const result = updateTodos(todos, [{ id: 1, status: "completed" }]);
-
-		expect(result.blocked).toBeDefined();
-		expect(result.blocked![0].reason).toContain("verifying");
-	});
-
-	it("should allow in_progress → completed with verified=true + evidence (skip verifying)", () => {
-		const todos: Todo[] = [
-			{ id: 1, text: "fix auth", status: "in_progress", verifyText: "check codes", verifyAttempts: 0 },
-		];
-		const result = updateTodos(todos, [{ id: 1, status: "completed", verified: true, evidence: "all tests passed confirmed" }]);
-
-		expect(result.error).toBeUndefined();
-		expect(result.updatedTodos[0].status).toBe("completed");
-		expect(result.updatedTodos[0].evidence).toBe("all tests passed confirmed");
-	});
-
-	it("should block in_progress → completed with verified=true but no evidence", () => {
-		const todos: Todo[] = [
-			{ id: 1, text: "fix auth", status: "in_progress", verifyText: "check codes", verifyAttempts: 0 },
-		];
-		const result = updateTodos(todos, [{ id: 1, status: "completed", verified: true }]);
-
-		expect(result.blocked).toBeDefined();
-		expect(result.blocked![0].reason).toContain("evidence");
-	});
-
-	it("should block batch completed when mixed verifyText tasks lack evidence", () => {
-		const todos: Todo[] = [
-			{ id: 1, text: "A", status: "in_progress", verifyText: "check A", verifyAttempts: 0 },
-			{ id: 2, text: "B", status: "in_progress", verifyAttempts: 0 },
-		];
-		const result = updateTodos(todos, [
-			{ id: 1, status: "completed" },
-			{ id: 2, status: "completed" },
-		]);
-
-		expect(result.blocked).toBeDefined();
-		expect(result.blocked!.length).toBe(1); // only #1 blocked
-		expect(result.blocked![0].id).toBe(1);
-		// both unchanged (all-or-nothing)
-		expect(result.updatedTodos[0].status).toBe("in_progress");
-		expect(result.updatedTodos[1].status).toBe("in_progress");
-	});
-
-	it("should allow batch when verifyText task has verified+evidence and non-verifyText task is plain", () => {
-		const todos: Todo[] = [
-			{ id: 1, text: "A", status: "in_progress", verifyText: "check A", verifyAttempts: 0 },
-			{ id: 2, text: "B", status: "in_progress", verifyAttempts: 0 },
-		];
-		const result = updateTodos(todos, [
-			{ id: 1, status: "completed", verified: true, evidence: "confirmed via grep" },
-			{ id: 2, status: "completed" },
-		]);
-
-		expect(result.error).toBeUndefined();
-		expect(result.updatedTodos[0].status).toBe("completed");
-		expect(result.updatedTodos[1].status).toBe("completed");
-	});
-
-	it("should allow non-completed status changes without evidence", () => {
-		const todos: Todo[] = [
-			{ id: 1, text: "A", status: "pending", verifyText: "check A", verifyAttempts: 0 },
-		];
-		const result = updateTodos(todos, [{ id: 1, status: "in_progress" }]);
-
-		expect(result.error).toBeUndefined();
-		expect(result.blocked).toBeUndefined();
-		expect(result.updatedTodos[0].status).toBe("in_progress");
-	});
-
-	it("should allow verifying → in_progress (verification failed, rework)", () => {
+	it("should pick first pending todo as next recommended", () => {
 		const todos: Todo[] = [
-			{ id: 1, text: "fix auth", status: "verifying", verifyText: "check codes", verifyAttempts: 0, evidence: "initial check" },
+			{ id: 1, text: "A", status: "completed" },
+			{ id: 2, text: "B", status: "pending" },
+			{ id: 3, text: "C", status: "pending" },
 		];
-		const result = updateTodos(todos, [{ id: 1, status: "in_progress" }]);
-
-		expect(result.error).toBeUndefined();
-		expect(result.updatedTodos[0].status).toBe("in_progress");
-	});
-});
-
-// ── buildRender ───────────────────────────────────────
-
-describe("buildRender", () => {
-	it("should calculate summary correctly", () => {
-		const todos: Todo[] = [
-			{ id: 1, text: "a", status: "completed", verifyAttempts: 0 },
-			{ id: 2, text: "b", status: "pending", verifyAttempts: 0 },
-			{ id: 3, text: "c", status: "failed", verifyAttempts: 2 },
-		];
-		const render = buildRender(todos);
-
-		expect(render).toBeDefined();
-		expect(render!.summary).toBe("1/3 completed");
-		expect(render!.data.items).toHaveLength(3);
-	});
-
-	it("should handle empty list", () => {
-		const render = buildRender([]);
-
-		expect(render).toBeDefined();
-		expect(render!.summary).toBe("0/0 completed");
-		expect(render!.data.items).toHaveLength(0);
-	});
-});
-
-// ── batch update verifyAttempts increment ───────────
-
-describe("batch update verifyAttempts increment", () => {
-	it("should increment verifyAttempts when batch reverts completed → in_progress with verifyText", () => {
-		const todos: Todo[] = [
-			{ id: 1, text: "fix auth", status: "completed", verifyText: "check codes", verifyAttempts: 0 },
-		];
-		const result = updateTodos(todos, [{ id: 1, status: "in_progress" }]);
-
-		expect(result.error).toBeUndefined();
-		expect(result.updatedTodos[0].verifyAttempts).toBe(1);
-	});
-
-	it("should increment verifyAttempts when batch reverts verifying → in_progress with verifyText", () => {
-		const todos: Todo[] = [
-			{ id: 1, text: "fix auth", status: "verifying", verifyText: "check codes", verifyAttempts: 1, evidence: "testing" },
-		];
-		const result = updateTodos(todos, [{ id: 1, status: "in_progress" }]);
-
-		expect(result.error).toBeUndefined();
-		expect(result.updatedTodos[0].verifyAttempts).toBe(2);
-	});
-
-	it("should NOT increment verifyAttempts for tasks without verifyText", () => {
-		const todos: Todo[] = [
-			{ id: 1, text: "simple", status: "completed", verifyAttempts: 0 },
-		];
-		const result = updateTodos(todos, [{ id: 1, status: "in_progress" }]);
-
-		expect(result.error).toBeUndefined();
-		expect(result.updatedTodos[0].verifyAttempts).toBe(0);
-	});
-
-	it("should NOT increment verifyAttempts when already at MAX (2)", () => {
-		const todos: Todo[] = [
-			{ id: 1, text: "fix auth", status: "completed", verifyText: "check codes", verifyAttempts: 2 },
-		];
-		const result = updateTodos(todos, [{ id: 1, status: "in_progress" }]);
-
-		expect(result.error).toBeUndefined();
-		expect(result.updatedTodos[0].verifyAttempts).toBe(2); // capped
+		const next = todos.find((t) => t.status !== "completed");
+		expect(next!.id).toBe(2);
+		expect(next!.text).toBe("B");
 	});
 });