@zhushanwen/pi-subagent-workflow 8.6.0 → 8.8.0

package/src/execution/__tests__/conversation-wiring.test.ts

@@ -1,198 +0,0 @@
-// src/execution/__tests__/conversation-wiring.test.ts
-//
-// [M9] conversation:true → record.chatMode 接线穿透测试。
-//
-// 背景：「持续对话」特性的 LLM 入口接线（subagent-tool params → startHandler 透传 →
-// execute → createRecordForMode 的 `chatMode: opts.conversation === true` +
-// `idleTimeoutMs: opts.idleTimeoutMs`，subagent-service.ts L1234-1235）此前无任何测试——
-// 全部 chatMode 测试手工构造 chatMode:true record，startHandler 测试不传 conversation。
-// 若参数名漂移或透传丢失（subagent-actions.ts L206-207），1970 个用例仍全绿。
-//
-// 两层验证：
-//   1. 接线层：真实 SubagentService.execute（mock runSpawn pending 阻断 detached 收尾）
-//      → 断言内存 record.chatMode === true / idleTimeoutMs 生效；缺省对照 chatMode === false
-//   2. 透传层：startHandler + mock service → 断言 execute 收到 conversation/idleTimeoutMs 原值
-
-import * as fs from "node:fs";
-import * as os from "node:os";
-import * as path from "node:path";
-
-import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
-
-const { loggerMock } = vi.hoisted(() => ({
-  loggerMock: { debug: vi.fn(), warn: vi.fn(), error: vi.fn(), info: vi.fn() },
-}));
-vi.mock("@zhushanwen/pi-extension-logger", () => ({ getLogger: () => loggerMock }));
-
-// mock session-runner：runSpawn 返回永不 resolve 的 promise（阻断 runAndFinalize 收尾，
-// record 停在 running，execute 返回后立即可断言 createRecordForMode 的接线产物）。
-vi.mock("../session-runner.ts", () => ({
-  runSpawn: vi.fn(() => new Promise(() => {})),
-  killAllSpawnedChildren: vi.fn(),
-  getChildByRecord: vi.fn(() => undefined),
-  spawnedChildren: new Map(),
-}));
-
-import { runSpawn } from "../session-runner.ts";
-import { startHandler } from "../../interface/subagent-actions.ts";
-import { ModelConfigService } from "../model-config-service.ts";
-import type { ModelInfo, ModelRegistryLike } from "../model-resolver.ts";
-import { RecordStore } from "../record-store.ts";
-import { SubagentService } from "../subagent-service.ts";
-import type { ExecutionHandle, SubagentToolDetails } from "../types.ts";
-
-const mockRunSpawn = vi.mocked(runSpawn);
-
-const STUB_MODEL: ModelInfo = { id: "test-model", name: "Test", provider: "test", reasoning: false };
-
-/** 最小合法 registry（initModel fail-fast 需要；resolveModel 第三层直接透传 ctxModel）。 */
-function makeEmptyRegistry(): ModelRegistryLike {
-  return { getAvailable: () => [], find: () => undefined, hasConfiguredAuth: () => true };
-}
-
-/** initSession 注入的最小 pi duck-type（同 subagent-service PiLike 形状，结构匹配即可）。 */
-interface PiStub {
-  appendEntry(customType: string, data?: unknown): void;
-  events: { emit(channel: string, data: unknown): void };
-  sendMessage(
-    message: { customType: string; content: string; display: boolean; details?: unknown },
-    options?: { triggerTurn?: boolean; deliverAs?: "steer" | "followUp" | "nextTurn" },
-  ): void;
-}
-
-function makePi(): PiStub {
-  return {
-    appendEntry: vi.fn(),
-    events: { emit: vi.fn() },
-    sendMessage: vi.fn(),
-  };
-}
-
-/** 暴露私有 store 的接口（测试专用 cast）。 */
-interface ServiceInternals {
-  store: RecordStore;
-}
-
-// ============================================================
-// 1. 接线层：execute({conversation, idleTimeoutMs}) → record 字段
-// ============================================================
-
-describe("[M9] conversation:true 接线：execute → createRecordForMode", () => {
-  let agentDir: string;
-  let service: SubagentService;
-  let store: RecordStore;
-
-  beforeEach(() => {
-    agentDir = fs.mkdtempSync(path.join(os.tmpdir(), "conv-wiring-"));
-    const modelService = new ModelConfigService({ agentDir, cwd: agentDir });
-    modelService.initModel({
-      modelRegistry: makeEmptyRegistry(),
-      sessionId: "root-session",
-      ctxModel: STUB_MODEL,
-    });
-    service = new SubagentService({ cwd: agentDir, modelService });
-    service.initSession({ pi: makePi(), sessionId: "root-session" });
-    store = (service as unknown as ServiceInternals).store;
-    mockRunSpawn.mockClear();
-  });
-
-  afterEach(() => {
-    service.dispose();
-    fs.rmSync(agentDir, { recursive: true, force: true });
-  });
-
-  it("conversation:true + idleTimeoutMs:12345 → record.chatMode===true、idleTimeoutMs 生效", async () => {
-    const handle = await service.execute({
-      task: "keep chatting with me",
-      slug: "conv-test",
-      conversation: true,
-      idleTimeoutMs: 12345,
-    });
-
-    const record = store.getMutable(handle.subagentId);
-    expect(record).toBeDefined();
-    expect(record!.chatMode).toBe(true);
-    expect(record!.idleTimeoutMs).toBe(12345);
-    expect(record!.status).toBe("running");
-    // execute 走到 kickOffBackground（runSpawn 已被调用）——完整接线而非 early return
-    expect(mockRunSpawn).toHaveBeenCalledTimes(1);
-  });
-
-  it("conversation 缺省 → record.chatMode===false、idleTimeoutMs undefined（一次性模式不误升级）", async () => {
-    const handle = await service.execute({
-      task: "one shot task",
-      slug: "oneshot-test",
-    });
-
-    const record = store.getMutable(handle.subagentId);
-    expect(record).toBeDefined();
-    expect(record!.chatMode).toBe(false);
-    expect(record!.idleTimeoutMs).toBeUndefined();
-  });
-});
-
-// ============================================================
-// 2. 透传层：startHandler(service, {conversation, idleTimeoutMs}) → service.execute
-// ============================================================
-
-function makeHandle(subagentId: string): ExecutionHandle {
-  const details: SubagentToolDetails = {
-    status: "running",
-    mode: "background",
-    agent: "worker",
-    model: "test/model",
-    thinkingLevel: undefined,
-    slug: "conv-test",
-    turns: 0,
-    totalTokens: 0,
-    elapsedSeconds: 0,
-    eventLog: [],
-    displayItems: [],
-    result: undefined,
-  };
-  return { mode: "background", subagentId, sessionFile: undefined, details };
-}
-
-function makeService(): SubagentService & { execute: ReturnType<typeof vi.fn> } {
-  return {
-    execute: vi.fn(async () => makeHandle("sa-conv-1")),
-    findRecord: vi.fn(() => undefined),
-    cancel: vi.fn(() => false),
-    collectRecords: vi.fn(() => []),
-    getFullRecord: vi.fn(() => undefined),
-  } as unknown as SubagentService & { execute: ReturnType<typeof vi.fn> };
-}
-
-describe("[M9] startHandler 透传：conversation/idleTimeoutMs → execute 入参", () => {
-  it("conversation:true + idleTimeoutMs:12345 原值透传给 service.execute", async () => {
-    const svc = makeService();
-    const result = await startHandler(
-      svc,
-      { task: "chat task", slug: "conv-pass", conversation: true, idleTimeoutMs: 12345 },
-      undefined,
-    );
-
-    expect(svc.execute).toHaveBeenCalledTimes(1);
-    expect(svc.execute).toHaveBeenCalledWith(
-      expect.objectContaining({
-        task: "chat task",
-        slug: "conv-pass",
-        conversation: true,
-        idleTimeoutMs: 12345,
-      }),
-    );
-    // bg 响应回执（LLM 可见）：detached + running
-    expect(result.kind).toBe("bg");
-    expect(result.subagentId).toBe("sa-conv-1");
-    expect(result.response.status).toBe("running");
-  });
-
-  it("conversation 缺省 → execute 入参 conversation===undefined（不误置 true）", async () => {
-    const svc = makeService();
-    await startHandler(svc, { task: "plain task", slug: "plain-pass" }, undefined);
-
-    expect(svc.execute).toHaveBeenCalledWith(
-      expect.objectContaining({ conversation: undefined, idleTimeoutMs: undefined }),
-    );
-  });
-});

package/src/execution/__tests__/crash-recovery.test.ts

@@ -1,320 +0,0 @@
-// src/execution/__tests__/crash-recovery.test.ts
-//
-// MF-5: session_start crash recovery 路径测试。
-//
-// 覆盖 store.loadAll 的 4 个分支：
-//   1. loadAll 成功 + running run → 重建（transition done,failed + emit pending:unregister failed）
-//   2. loadAll 成功 + 已终态 run → 直接 set 到 runs Map，不 transition
-//   3. loadAll 失败 → storeHealthy=false，pi.__workflowRun 返回失败（fail-fast）
-//   4. loadAll 失败后 subagent 域不受影响（subagent tool 注册仍被调用）
-//
-// 通过 vi.mock("../../orchestration/jsonl-run-store.ts") 注入可控的 loadAll 行为。
-// 路径说明：index.ts 从 ./orchestration/jsonl-run-store.ts 导入 JsonlRunStore，
-// 该文件绝对路径 src/orchestration/jsonl-run-store.ts，从本测试文件
-// （src/execution/__tests/）相对路径为 ../../orchestration/jsonl-run-store.ts。
-
-import { beforeEach, describe, expect, it, vi } from "vitest";
-
-// ── mock modules（在 import 前声明）──
-
-vi.mock("@earendil-works/pi-coding-agent", () => ({
-  getAgentDir: () => "/home/user/.pi/agent",
-}));
-vi.mock("@earendil-works/pi-coding-agent", () => ({
-  getAgentDir: () => "/home/user/.pi/agent",
-}));
-vi.mock("@earendil-works/pi-ai", () => ({
-  StringEnum: (values: string[]) => ({ type: "string", enum: values }),
-}));
-vi.mock("@earendil-works/pi-ai", () => ({
-  StringEnum: (values: string[]) => ({ type: "string", enum: values }),
-}));
-vi.mock("typebox", () => ({
-  Type: {
-    Object: (props: Record<string, unknown>) => ({ type: "object", properties: props }),
-    Optional: (schema: unknown) => ({ ...(schema as object), optional: true }),
-    String: () => ({ type: "string" }),
-    Boolean: () => ({ type: "boolean" }),
-    Number: () => ({ type: "number" }),
-    Array: (items: unknown) => ({ type: "array", items }),
-    Record: (key: unknown, value: unknown) => ({ type: "object", additionalProperties: value, key }),
-    Unknown: () => ({ type: "unknown" }),
-    Union: (members: unknown[]) => ({ type: "union", members }),
-    Literal: (value: unknown) => ({ type: "literal", value }),
-  },
-}));
-
-// ── hoisted mock 实例：store loadAll 可控 + 工具注册可观察 ──
-
-const { mockLoadAll, mockRegisterSubagentTool, mockScan } = vi.hoisted(() => ({
-  mockLoadAll: vi.fn(async () => []),
-  mockScan: vi.fn(),
-  mockRegisterSubagentTool: vi.fn(),
-}));
-
-// JsonlRunStore mock：loadAll 由各 test 配置。构造参数忽略（sessionDir/pi/ctx 都 mock 掉）。
-// dispose/flushPendingSaves：session_shutdown handler 会调 state.store.dispose()（W2C5），
-// 本文件用例虽不触发 handler body，防御性补齐防 mock 缺方法 TypeError。
-vi.mock("../../orchestration/jsonl-run-store.ts", () => ({
-  JsonlRunStore: class {
-    loadAll = mockLoadAll;
-    save = vi.fn(async () => {});
-    dispose = vi.fn(async () => {});
-    flushPendingSaves = vi.fn(async () => {});
-  },
-}));
-
-vi.mock("../worktree-manager.ts", () => ({
-  WorktreeManager: class {
-    constructor(_agentDir: string) {
-      /* mock */
-    }
-    scan = mockScan;
-    cleanup = vi.fn();
-    create = vi.fn();
-    collectPatch = vi.fn();
-    registerPid = vi.fn();
-  },
-}));
-
-vi.mock("../session-file-gc.ts", () => ({
-  maybeCleanupExpiredSessionFiles: vi.fn(),
-}));
-
-vi.mock("../model-config-service.ts", () => ({
-  ModelConfigService: class {
-    initModel = vi.fn();
-  },
-  getModelConfigService: () => null,
-  setModelConfigService: vi.fn(),
-}));
-
-vi.mock("../subagent-service.ts", () => ({
-  SubagentService: class {
-    initSession = vi.fn();
-    // W3: index.ts session_start 注入 UI handler 时调用
-    setUiRequestHandler = vi.fn();
-    recoverManifestTmpFiles = vi.fn(async () => ({ deleted: 0, recovered: 0 }));
-    startGcTimer = vi.fn();
-  },
-  getSubagentService: () => null,
-  setSubagentService: vi.fn(),
-}));
-
-// interface 层模块：mock 掉，避免触发真实 pi.registerTool（pi 是 Proxy，真实模块访问 pi
-// 属性时仍可能抛错）。路径相对 src/execution/__tests/ → ../../interface/...
-vi.mock("../../interface/subagent-tool.ts", () => ({
-  registerSubagentTool: mockRegisterSubagentTool,
-}));
-vi.mock("../../interface/subagents.ts", () => ({
-  registerSubagentsCommand: vi.fn(),
-}));
-vi.mock("../../interface/bg-notify-render.ts", () => ({
-  renderBgNotifyMessage: vi.fn(),
-}));
-vi.mock("../../interface/tool-workflow.ts", () => ({
-  registerWorkflowTool: vi.fn(),
-}));
-vi.mock("../../interface/tool-workflow-script.ts", () => ({
-  registerWorkflowScriptTool: vi.fn(),
-}));
-vi.mock("../../interface/commands.ts", () => ({
-  registerWorkflowsCommand: vi.fn(),
-}));
-
-// ── import 被测工厂 ──
-import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
-
-import subagentsExtension from "../../index.ts";
-import { Budget } from "../../orchestration/models/budget.ts";
-import { Trace } from "../../orchestration/models/trace.ts";
-import type { WorkflowRun as WorkflowRunType } from "../../orchestration/models/workflow-run.ts";
-import { WorkflowRun } from "../../orchestration/models/workflow-run.ts";
-
-// ── helpers ──
-
-/** 构造一个可重水合的 WorkflowRun（用 WorkflowRun.reconstruct 跳过 I1 校验）。 */
-function makeRun(
-  runId: string,
-  status: "running" | "done",
-  reason?: "completed" | "failed" | "aborted" | "budget_limited" | "time_limited",
-): WorkflowRunType {
-  return WorkflowRun.reconstruct(
-    runId,
-    {
-      scriptSource: "execute() {}",
-      args: {},
-      scriptName: "test",
-      scriptPath: "/fake/test.js",
-    },
-    {
-      status,
-      reason,
-      budget: new Budget({ maxTokens: 1000 }),
-      calls: new Map(),
-      trace: new Trace(),
-      errorLogs: [],
-    },
-    { startedAt: new Date().toISOString() },
-  );
-}
-
-/** 创建可观察 eventBus.emit 的 mock ExtensionAPI，捕获 session_start handler。 */
-function createMockPi(overrides: Record<string, unknown> = {}): {
-  pi: ExtensionAPI;
-  emits: Array<{ channel: string; data: unknown }>;
-  getSessionStartHandler: () => ((event: unknown, ctx: unknown) => Promise<void>) | undefined;
-} {
-  let sessionStartHandler: ((event: unknown, ctx: unknown) => Promise<void>) | undefined;
-  const emits: Array<{ channel: string; data: unknown }> = [];
-  const events = {
-    emit(channel: string, data: unknown): void {
-      emits.push({ channel, data });
-    },
-  };
-  const noop = (): void => {
-    /* mock */
-  };
-  const pi = new Proxy<ExtensionAPI>(overrides as ExtensionAPI, {
-    get(target, prop: string | symbol): unknown {
-      if (prop === "on") {
-        return (event: string, handler: (...args: unknown[]) => unknown) => {
-          if (event === "session_start") {
-            sessionStartHandler = handler as (event: unknown, ctx: unknown) => Promise<void>;
-          }
-        };
-      }
-      if (prop === "events") return events;
-      if (prop === "appendEntry") return noop;
-      if (prop === "registerMessageRenderer") return noop;
-      if (prop in target) return target[prop as keyof ExtensionAPI];
-      return noop;
-    },
-  });
-  return {
-    pi,
-    emits,
-    getSessionStartHandler: () => sessionStartHandler,
-  };
-}
-
-/** 最小 ExtensionContext mock。 */
-function createMockCtx(): Record<string, unknown> {
-  return {
-    cwd: "/home/user/project",
-    // [Wave1 #21] mode 必填（与 SDK ExtensionContext 契约一致）；默认 tui。
-    mode: "tui",
-    modelRegistry: {
-      getAvailable: () => [],
-      find: () => undefined,
-      hasConfiguredAuth: () => false,
-    },
-    model: undefined,
-    sessionManager: {
-      getSessionId: () => "session-crash",
-      getSessionFile: () => "/home/user/.pi/agent/sessions/session-crash.jsonl",
-      getSessionDir: () => "/home/user/.pi/agent/sessions",
-      getCwd: () => "/home/user/project",
-      getEntries: () => [],
-      getBranch: () => [],
-      getLeafId: () => null,
-      getLeafEntry: () => undefined,
-      getEntry: () => undefined,
-      getHeader: () => null,
-      getTree: () => [],
-      getSessionName: () => undefined,
-    },
-  };
-}
-
-beforeEach(() => {
-  vi.clearAllMocks();
-  mockLoadAll.mockResolvedValue([]);
-});
-
-// ── tests ──
-
-describe("session_start crash recovery（store.loadAll 路径）", () => {
-  it("loadAll 成功 + running run：transition done,failed + emit pending:unregister failed", async () => {
-    const runningRun = makeRun("wf-crash-1", "running");
-    mockLoadAll.mockResolvedValue([runningRun]);
-
-    const { pi, emits, getSessionStartHandler } = createMockPi();
-    subagentsExtension(pi);
-
-    const handler = getSessionStartHandler();
-    expect(handler).toBeDefined();
-    await handler!({ type: "session_start" }, createMockCtx());
-
-    // run 被转为 done,failed（crash recovery）
-    expect(runningRun.state.status).toBe("done");
-    expect(runningRun.state.reason).toBe("failed");
-    expect(runningRun.state.error).toContain("Process killed");
-
-    // emit pending:unregister（reason=failed）
-    const unregister = emits.find((e) => e.channel === "pending:unregister");
-    expect(unregister).toBeDefined();
-    expect(unregister!.data).toEqual({ id: "wf-crash-1", reason: "failed" });
-  });
-
-  it("loadAll 成功 + 已终态 run：直接 set 到 runs Map，不 transition", async () => {
-    const doneRun = makeRun("wf-done-1", "done", "completed");
-    const originalCompletedAt = doneRun.meta.completedAt;
-    mockLoadAll.mockResolvedValue([doneRun]);
-
-    const { pi, emits, getSessionStartHandler } = createMockPi();
-    subagentsExtension(pi);
-
-    const handler = getSessionStartHandler();
-    await handler!({ type: "session_start" }, createMockCtx());
-
-    // 状态不变（仍 done/completed），不重新 transition（completedAt 不变）
-    expect(doneRun.state.status).toBe("done");
-    expect(doneRun.state.reason).toBe("completed");
-    expect(doneRun.meta.completedAt).toBe(originalCompletedAt);
-
-    // 终态 run 不触发 pending:unregister（恢复路径只处理 status==="running"）
-    const unregister = emits.filter((e) => e.channel === "pending:unregister");
-    expect(unregister).toHaveLength(0);
-
-    // run 已被 set 到 runs Map —— pi.__workflowRun 在 storeHealthy=true 时
-    // 不会因 store unavailable 提前返回
-    const result = (await (pi as unknown as {
-      __workflowRun: (n: string, a: Record<string, unknown>) => Promise<unknown>;
-    }).__workflowRun("any", {})) as { error?: string };
-    expect(result.error).not.toContain("store unavailable");
-  });
-
-  it("loadAll 失败 → storeHealthy=false：pi.__workflowRun 返回 store unavailable 失败", async () => {
-    mockLoadAll.mockRejectedValue(new Error("disk corruption"));
-
-    const { pi, getSessionStartHandler } = createMockPi();
-    subagentsExtension(pi);
-
-    const handler = getSessionStartHandler();
-    await handler!({ type: "session_start" }, createMockCtx());
-
-    // pi.__workflowRun 在 store 不健康时 fail-fast
-    const result = (await (pi as unknown as {
-      __workflowRun: (n: string, a: Record<string, unknown>) => Promise<unknown>;
-    }).__workflowRun("any", {})) as { status: string; reason: string; error: string };
-
-    expect(result.status).toBe("done");
-    expect(result.reason).toBe("failed");
-    expect(result.error).toContain("store unavailable");
-    expect(result.error).toContain("loadAll failed");
-  });
-
-  it("loadAll 失败后 subagent 域不受影响：registerSubagentTool 仍被调用", async () => {
-    mockLoadAll.mockRejectedValue(new Error("disk corruption"));
-
-    const { pi, getSessionStartHandler } = createMockPi();
-    subagentsExtension(pi);
-
-    const handler = getSessionStartHandler();
-    await handler!({ type: "session_start" }, createMockCtx());
-
-    // subagent tool 注册在 factory 入口（session_start 之外），与 store 健康无关
-    expect(mockRegisterSubagentTool).toHaveBeenCalledTimes(1);
-  });
-});