@zhushanwen/pi-subagent-workflow 7.3.4 → 8.0.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (166) hide show
  1. package/README.md +39 -12
  2. package/agents/analyst.md +61 -0
  3. package/agents/coder.md +70 -0
  4. package/agents/debugger.md +67 -0
  5. package/agents/doc-reviewer.md +3 -3
  6. package/agents/explorer.md +50 -18
  7. package/agents/general-purpose.md +19 -8
  8. package/agents/orchestrator.md +37 -32
  9. package/agents/planner.md +45 -11
  10. package/agents/researcher.md +53 -11
  11. package/agents/reviewer.md +74 -0
  12. package/package.json +1 -1
  13. package/skills/workflow-script-format/SKILL.md +1 -1
  14. package/src/execution/__tests__/__fixtures__/truncline.snapshot.json +1 -0
  15. package/src/execution/__tests__/agent-registry.test.ts +13 -11
  16. package/src/execution/__tests__/ask-user-transit-e2e.test.ts +10 -4
  17. package/src/execution/__tests__/before-agent-start-injection.test.ts +132 -0
  18. package/src/execution/__tests__/bg-notify-render.test.ts +15 -15
  19. package/src/execution/__tests__/chatmode-first-round-closure-service.test.ts +365 -0
  20. package/src/execution/__tests__/chatmode-first-round-closure-spawn.test.ts +190 -0
  21. package/src/execution/__tests__/chatmode-round-notify-real-chain.test.ts +215 -0
  22. package/src/execution/__tests__/conversation-wiring.test.ts +198 -0
  23. package/src/execution/__tests__/crash-recovery.test.ts +8 -2
  24. package/src/execution/__tests__/delivery-methods.test.ts +385 -0
  25. package/src/execution/__tests__/epipe-fallback.test.ts +241 -0
  26. package/src/execution/__tests__/execute-and-await-worktree.test.ts +49 -2
  27. package/src/execution/__tests__/execute-nesting.test.ts +20 -72
  28. package/src/execution/__tests__/execution-record.test.ts +199 -0
  29. package/src/execution/__tests__/finalize-record.test.ts +170 -14
  30. package/src/execution/__tests__/format.test.ts +131 -7
  31. package/src/execution/__tests__/gc-timer.test.ts +184 -0
  32. package/src/execution/__tests__/get-record-for-action-restart.test.ts +254 -0
  33. package/src/execution/__tests__/helpers/spawn-mock.ts +25 -7
  34. package/src/execution/__tests__/index-session-start-identity.test.ts +371 -0
  35. package/src/execution/__tests__/index-session-start.test.ts +257 -5
  36. package/src/execution/__tests__/lifecycle-manager-lock.test.ts +211 -0
  37. package/src/execution/__tests__/lifecycle-manager.test.ts +337 -0
  38. package/src/execution/__tests__/lifecycle-predicates.test.ts +116 -0
  39. package/src/execution/__tests__/list-component.test.ts +59 -5
  40. package/src/execution/__tests__/list-fields.test.ts +109 -0
  41. package/src/execution/__tests__/model-resolver.test.ts +38 -1
  42. package/src/execution/__tests__/nested-visibility-env-propagation.test.ts +287 -0
  43. package/src/execution/__tests__/nested-visibility.test.ts +325 -0
  44. package/src/execution/__tests__/notifier-flush.test.ts +209 -7
  45. package/src/execution/__tests__/one-shot-upgrade.test.ts +205 -0
  46. package/src/execution/__tests__/parent-child-matrix.test.ts +336 -0
  47. package/src/execution/__tests__/record-store.test.ts +158 -52
  48. package/src/execution/__tests__/recursive-visibility-baseline.test.ts +11 -12
  49. package/src/execution/__tests__/recursive-visibility-env.test.ts +18 -20
  50. package/src/execution/__tests__/resource-policy.test.ts +109 -0
  51. package/src/execution/__tests__/run-and-finalize-chatmode.test.ts +267 -0
  52. package/src/execution/__tests__/run-spawn-chatmode-settled.test.ts +253 -0
  53. package/src/execution/__tests__/run-spawn-edges.test.ts +18 -25
  54. package/src/execution/__tests__/run-spawn-integration.test.ts +29 -25
  55. package/src/execution/__tests__/run-spawn-resume.test.ts +322 -0
  56. package/src/execution/__tests__/run-spawn-rpc-mode.test.ts +14 -11
  57. package/src/execution/__tests__/session-pending.test.ts +61 -2
  58. package/src/execution/__tests__/session-reconstructor.test.ts +4 -4
  59. package/src/execution/__tests__/session-runner-epipe.test.ts +178 -0
  60. package/src/execution/__tests__/session-runner-schema-env.test.ts +15 -21
  61. package/src/execution/__tests__/session-start-reaper.test.ts +10 -8
  62. package/src/execution/__tests__/spawn-args.test.ts +127 -49
  63. package/src/execution/__tests__/spawn-worktree-guidance.test.ts +1 -0
  64. package/src/execution/__tests__/spawned-children.test.ts +92 -0
  65. package/src/execution/__tests__/status-refactor.test.ts +345 -0
  66. package/src/execution/__tests__/stdin-writer.test.ts +97 -0
  67. package/src/execution/__tests__/subagent-service-message-close.test.ts +598 -0
  68. package/src/execution/__tests__/subagent-service-parent-guard.test.ts +180 -0
  69. package/src/execution/__tests__/subagent-service.test.ts +49 -11
  70. package/src/execution/__tests__/timeout-integration.test.ts +27 -13
  71. package/src/execution/__tests__/tool-action.test.ts +12 -10
  72. package/src/execution/__tests__/truncline-snapshot.test.ts +81 -0
  73. package/src/execution/__tests__/turn-limiter-semantics.test.ts +194 -0
  74. package/src/execution/__tests__/worktree-manager.test.ts +292 -89
  75. package/src/execution/__tests__/worktree-pid-registration.integration.test.ts +13 -12
  76. package/src/execution/argv-mirror.ts +21 -2
  77. package/src/execution/execution-record.ts +126 -9
  78. package/src/execution/finalize-record.ts +90 -13
  79. package/src/execution/host-mode.ts +1 -1
  80. package/src/execution/lifecycle-manager.ts +484 -0
  81. package/src/execution/lifecycle-predicates.ts +65 -0
  82. package/src/execution/manifest-store.ts +61 -16
  83. package/src/execution/model-resolver.ts +26 -5
  84. package/src/execution/notifier.ts +69 -12
  85. package/src/execution/pi-invocation.ts +21 -1
  86. package/src/execution/record-store.ts +554 -107
  87. package/src/execution/session-pending.ts +116 -45
  88. package/src/execution/session-reconstructor.ts +224 -7
  89. package/src/execution/session-runner.ts +290 -75
  90. package/src/execution/sessions-index.ts +304 -0
  91. package/src/execution/stdin-writer.ts +93 -7
  92. package/src/execution/stream-sink.ts +20 -3
  93. package/src/execution/subagent-service.ts +867 -138
  94. package/src/execution/turn-limiter.ts +14 -0
  95. package/src/execution/types.ts +204 -22
  96. package/src/execution/worktree-manager.ts +128 -49
  97. package/src/execution/worktree-registry.ts +13 -2
  98. package/src/index.ts +277 -19
  99. package/src/injectors/subagent-list-injector.ts +26 -8
  100. package/src/injectors/workflow-list-injector.ts +25 -8
  101. package/src/interface/__tests__/subagent-tool-prompt.test.ts +18 -5
  102. package/src/interface/__tests__/tool-render.test.ts +15 -13
  103. package/src/interface/bg-notify-render.ts +32 -8
  104. package/src/interface/command-actions.ts +26 -7
  105. package/src/interface/commands.ts +21 -22
  106. package/src/interface/format.ts +44 -17
  107. package/src/interface/gui-mappers.ts +6 -8
  108. package/src/interface/helpers.ts +170 -10
  109. package/src/interface/list-component.ts +53 -14
  110. package/src/interface/subagent-actions.ts +235 -17
  111. package/src/interface/subagent-tool.ts +82 -17
  112. package/src/interface/subagents.ts +2 -1
  113. package/src/interface/tool-render.ts +11 -24
  114. package/src/interface/tool-workflow.ts +20 -35
  115. package/src/interface/views/WorkflowsView.ts +89 -32
  116. package/src/interface/views/__tests__/WorkflowsView-signature.test.ts +264 -0
  117. package/src/interface/views/__tests__/detail-content-session-file.test.ts +1 -1
  118. package/src/interface/views/format.ts +3 -3
  119. package/src/orchestration/__tests__/__fixtures__/worker-template.snapshot.txt +325 -0
  120. package/src/orchestration/__tests__/args-validator.test.ts +1 -1
  121. package/src/orchestration/__tests__/config-loader.test.ts +38 -0
  122. package/src/orchestration/__tests__/error-recovery-handlers.test.ts +394 -4
  123. package/src/orchestration/__tests__/error-recovery-workflow-call.test.ts +4 -4
  124. package/src/orchestration/__tests__/execute-agent-call.test.ts +95 -0
  125. package/src/orchestration/__tests__/jsonl-run-store-session-file.test.ts +657 -18
  126. package/src/orchestration/__tests__/launcher-nested-workflow.test.ts +0 -2
  127. package/src/orchestration/__tests__/lifecycle.test.ts +332 -149
  128. package/src/orchestration/__tests__/skill-discovery.test.ts +157 -0
  129. package/src/orchestration/__tests__/test-mocks.ts +191 -0
  130. package/src/orchestration/__tests__/worker-script-template-snapshot.test.ts +98 -0
  131. package/src/orchestration/__tests__/workflow-nesting-e2e.test.ts +0 -2
  132. package/src/orchestration/__tests__/workflow-script-lint-memo.test.ts +110 -0
  133. package/src/orchestration/__tests__/workflows-e2e.test.ts +1 -1
  134. package/src/orchestration/agent-opts-resolver.ts +4 -1
  135. package/src/orchestration/args-validator.ts +2 -2
  136. package/src/orchestration/config-loader.ts +30 -1
  137. package/src/orchestration/error-recovery.ts +133 -29
  138. package/src/orchestration/execute-agent-call.ts +31 -7
  139. package/src/orchestration/jsonl-run-store.ts +287 -40
  140. package/src/orchestration/launcher.ts +7 -1
  141. package/src/orchestration/lifecycle.ts +135 -132
  142. package/src/orchestration/models/__tests__/trace.test.ts +408 -0
  143. package/src/orchestration/models/budget.ts +1 -1
  144. package/src/orchestration/models/run-runtime.ts +15 -17
  145. package/src/orchestration/models/run-spec.ts +2 -2
  146. package/src/orchestration/models/run-state.ts +3 -3
  147. package/src/orchestration/models/trace.ts +95 -15
  148. package/src/orchestration/models/types.ts +8 -9
  149. package/src/orchestration/models/workflow-run.ts +50 -71
  150. package/src/orchestration/models/workflow-script.ts +32 -1
  151. package/src/orchestration/skill-discovery.ts +30 -0
  152. package/src/orchestration/worker-handle.ts +1 -1
  153. package/src/orchestration/worker-host.ts +1 -1
  154. package/src/orchestration/worker-script-builder.ts +29 -10
  155. package/src/shared/__tests__/agent-ref.test.ts +34 -0
  156. package/src/shared/__tests__/resource-discovery-manifest-cache.test.ts +280 -0
  157. package/src/shared/__tests__/resource-discovery.test.ts +55 -0
  158. package/src/shared/__tests__/schema-jsonify.test.ts +81 -0
  159. package/src/shared/agent-ref.ts +16 -0
  160. package/src/shared/resource-discovery.ts +147 -58
  161. package/src/shared/schema-jsonify.ts +53 -0
  162. package/workflows/README.md +4 -4
  163. package/agents/code-reviewer.md +0 -47
  164. package/agents/context-builder.md +0 -21
  165. package/agents/oracle.md +0 -34
  166. package/agents/worker.md +0 -20
@@ -0,0 +1,385 @@
1
+ // src/execution/__tests__/delivery-methods.test.ts
2
+ //
3
+ // resumeRound + deliverMessage 单元测试(M2-B1 投递基础设施)。
4
+ //
5
+ // mock session-runner(runSpawn 受控 + killAllSpawnedChildren 空实现 + getChildByRecord/spawnedChildren
6
+ // 真实 Map 语义),走 SubagentService 真实的 resumeRound/deliverMessage 逻辑:
7
+ // - resumeRound:idle→running→detached kickOff runSpawn 收到 resume 参数;chatMode+done 回 idle/round+1;
8
+ // 非 idle / 无 sessionFile / 无 controller throw
9
+ // - deliverMessage:按进程死活分流(热路径 prompt+streamingBehavior / 冷路径 resume)
10
+ //
11
+ // stdin-writer 不 mock(端到端验证 deliverMessage→sendPromptCommand→child.stdin 字节)。
12
+ // [review 修复] 已删除 deliverToRunning describe(busy follow_up/steer 投递)——随
13
+ // deliverToRunning 方法一并移除(无生产调用方,pendingMessages 消费确认制死机制)。
14
+
15
+ import * as fs from "node:fs";
16
+ import * as os from "node:os";
17
+ import * as path from "node:path";
18
+ import type { ChildProcess } from "node:child_process";
19
+ import { PassThrough } from "node:stream";
20
+
21
+ import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
22
+
23
+ const { loggerMock } = vi.hoisted(() => ({
24
+ loggerMock: { debug: vi.fn(), warn: vi.fn(), error: vi.fn(), info: vi.fn() },
25
+ }));
26
+ vi.mock("@zhushanwen/pi-extension-logger", () => ({ getLogger: () => loggerMock }));
27
+
28
+ // mock session-runner:runSpawn 受控 + killAllSpawnedChildren 空实现;
29
+ // getChildByRecord/spawnedChildren 提供真实 Map 语义(deliverToRunning 注册 mock child 用)。
30
+ vi.mock("../session-runner.ts", () => {
31
+ const spawnedChildren = new Map<string, unknown>();
32
+ return {
33
+ runSpawn: vi.fn(),
34
+ killAllSpawnedChildren: vi.fn(),
35
+ spawnedChildren,
36
+ getChildByRecord: (id: string): unknown => spawnedChildren.get(id),
37
+ };
38
+ });
39
+
40
+ import { runSpawn, spawnedChildren, type SessionRunnerContext } from "../session-runner.ts";
41
+ import * as lifecycle from "../lifecycle-manager.ts";
42
+ import { createRecord } from "../execution-record.ts";
43
+ import { ModelConfigService } from "../model-config-service.ts";
44
+ import type { ModelInfo } from "../model-resolver.ts";
45
+ import { SubagentService } from "../subagent-service.ts";
46
+ import type { PiLike } from "../subagent-service.ts";
47
+ import type { AgentResult, ExecutionRecord } from "../types.ts";
48
+
49
+ const mockRunSpawn = vi.mocked(runSpawn);
50
+
51
+ const STUB_MODEL: ModelInfo = { id: "test-model", name: "Test", provider: "test", reasoning: false };
52
+
53
+ function makeTmpAgentDir(): string {
54
+ return fs.mkdtempSync(path.join(os.tmpdir(), "delivery-test-"));
55
+ }
56
+
57
+ function makePi(): PiLike & {
58
+ appendEntry: ReturnType<typeof vi.fn>;
59
+ events: { emit: ReturnType<typeof vi.fn> };
60
+ sendMessage: ReturnType<typeof vi.fn>;
61
+ } {
62
+ return { appendEntry: vi.fn(), events: { emit: vi.fn() }, sendMessage: vi.fn() };
63
+ }
64
+
65
+ function makeResult(success: boolean): AgentResult {
66
+ return {
67
+ text: success ? "done" : "err",
68
+ turns: 1,
69
+ durationMs: 100,
70
+ success,
71
+ error: success ? undefined : "boom",
72
+ sessionId: "sess-1",
73
+ toolCalls: [],
74
+ };
75
+ }
76
+
77
+ /** chatMode idle record(第一轮已完成,等待续聊)。sessionFile 由调用方覆盖为 agentDir 下路径。 */
78
+ function makeIdleRecord(id = "sa-chat"): ExecutionRecord {
79
+ const record = createRecord(id, {
80
+ agent: "general-purpose",
81
+ model: "test/test-model",
82
+ thinkingLevel: "low",
83
+ mode: "background",
84
+ task: "initial task",
85
+ slug: "chat",
86
+ startedAt: 1000,
87
+ rootSessionId: "root-session",
88
+ chatMode: true,
89
+ });
90
+ // v4 B-1:idle 折入 running。"等待续聊"态现为 status="running"(isIdle/isResumable 派生谓词区分)。
91
+ record.status = "running";
92
+ record.round = 1;
93
+ record.controller = new AbortController();
94
+ return record;
95
+ }
96
+
97
+ /** PassThrough child(可读出 stdin 字节验证 deliverToRunning 写入)。 */
98
+ function makeStreamChild(): ChildProcess {
99
+ return { stdin: new PassThrough() } as unknown as ChildProcess;
100
+ }
101
+
102
+ function readStdinLines(child: ChildProcess): unknown[] {
103
+ const stream = child.stdin as unknown as PassThrough;
104
+ stream.pause();
105
+ const text = stream.read()?.toString() ?? "";
106
+ return text
107
+ .split("\n")
108
+ .map((l) => l.trim())
109
+ .filter((l) => l.length > 0)
110
+ .map((l) => JSON.parse(l));
111
+ }
112
+
113
+ describe("resumeRound (M2-B1 idle 投递)", () => {
114
+ let agentDir: string;
115
+ let service: SubagentService;
116
+ let record: ExecutionRecord;
117
+
118
+ beforeEach(() => {
119
+ agentDir = makeTmpAgentDir();
120
+ const modelService = new ModelConfigService({ agentDir });
121
+ service = new SubagentService({ cwd: agentDir, modelService });
122
+ service.initSession({ pi: makePi(), sessionId: "root-session" });
123
+ record = makeIdleRecord();
124
+ // sessionFile 用 agentDir 下路径(finalizeRoundToIdle 写 .idle sidecar 不留 /tmp 垃圾)
125
+ record.sessionFile = path.join(agentDir, "fake-session.jsonl");
126
+ mockRunSpawn.mockReset();
127
+ });
128
+
129
+ afterEach(() => {
130
+ service.dispose();
131
+ fs.rmSync(agentDir, { recursive: true, force: true });
132
+ });
133
+
134
+ it("resumeRound(running) → kickOff runSpawn 收到 resume 参数;chatMode+done 回 running/round+1", async () => {
135
+ mockRunSpawn.mockResolvedValueOnce(makeResult(true));
136
+ const beforeRound = record.round;
137
+
138
+ service.resumeRound(record, "next round msg");
139
+
140
+ // 同步:status 已手动设回 running(M2-A 边界,绕过 tryTransition)
141
+ expect(record.status).toBe("running");
142
+
143
+ // detached:等 runSpawn 被调
144
+ await vi.waitFor(() => expect(mockRunSpawn).toHaveBeenCalledTimes(1));
145
+ const call = mockRunSpawn.mock.calls[0]!;
146
+ // [record, task, opts, ctx, resume]
147
+ expect(call[1]).toBe("next round msg");
148
+ expect(call[4]).toEqual({
149
+ sessionFile: record.sessionFile,
150
+ model: record.model, // 防漂移(P-10):从 record identity 读
151
+ thinkingLevel: record.thinkingLevel,
152
+ });
153
+ expect((call[4] as { model: string }).model).toBe("test/test-model");
154
+
155
+ // 等 detached 完成:chatMode+done→running(v4 B-1 idle 折入 running,M2-A 分流),round 累加
156
+ await vi.waitFor(() => expect(record.status).toBe("running"));
157
+ expect(record.round).toBe(beforeRound! + 1);
158
+ });
159
+
160
+ it("终态 closed record → throw 行动语言(MF-4,仅 running 可续聊),不触发 kickOff", () => {
161
+ record.status = "closed";
162
+ // MF-4:行动语言(spec §3.1),不暴露 resume/controller 内部词汇
163
+ expect(() => service.resumeRound(record, "msg")).toThrow(/not ready for a new message/);
164
+ expect(mockRunSpawn).not.toHaveBeenCalled();
165
+ });
166
+
167
+ it("record 无 sessionFile → throw 行动语言(MF-4 canonical session unavailable),不触发 kickOff", () => {
168
+ record.sessionFile = undefined;
169
+ expect(() => service.resumeRound(record, "msg")).toThrow(/session unavailable/);
170
+ expect(mockRunSpawn).not.toHaveBeenCalled();
171
+ });
172
+
173
+ it("record 无 controller → throw 行动语言(MF-4),不触发 kickOff", () => {
174
+ record.controller = undefined;
175
+ expect(() => service.resumeRound(record, "msg")).toThrow(/not ready for a new message/);
176
+ expect(mockRunSpawn).not.toHaveBeenCalled();
177
+ });
178
+ });
179
+
180
+ // ============================================================
181
+ // deliverMessage(V2 决策 3 chatMode 统一投递:按进程死活分流)
182
+ // ============================================================
183
+
184
+ describe("deliverMessage (V2 决策 3 chatMode 统一投递)", () => {
185
+ let agentDir: string;
186
+ let service: SubagentService;
187
+ let record: ExecutionRecord;
188
+
189
+ beforeEach(() => {
190
+ agentDir = makeTmpAgentDir();
191
+ const modelService = new ModelConfigService({ agentDir });
192
+ service = new SubagentService({ cwd: agentDir, modelService });
193
+ service.initSession({ pi: makePi(), sessionId: "root-session" });
194
+ record = makeIdleRecord(); // chatMode:true, idle, round=1
195
+ // sessionFile:冷路径 resumeRound 需要(热路径不用,设了无害)
196
+ record.sessionFile = path.join(agentDir, "fake-session.jsonl");
197
+ spawnedChildren.clear();
198
+ mockRunSpawn.mockReset();
199
+ lifecycle._resetLifecycleState();
200
+ });
201
+
202
+ afterEach(() => {
203
+ service.dispose();
204
+ spawnedChildren.clear();
205
+ lifecycle._resetLifecycleState();
206
+ fs.rmSync(agentDir, { recursive: true, force: true });
207
+ });
208
+
209
+ it("热路径 interrupt=false:进程活 → prompt streamingBehavior:followUp + status=running + pid 记录", () => {
210
+ const child = makeStreamChild();
211
+ Object.assign(child, { pid: 12345 });
212
+ spawnedChildren.set(record.id, child);
213
+
214
+ service.deliverMessage(record, "after you finish", false);
215
+
216
+ const lines = readStdinLines(child);
217
+ expect(lines).toHaveLength(1);
218
+ // [验收 4] sendPromptCommand 收到的命令含 streamingBehavior 字段(followUp)
219
+ expect(lines[0]).toMatchObject({ type: "prompt", message: "after you finish", streamingBehavior: "followUp" });
220
+ expect(record.status).toBe("running");
221
+ expect(record.pid).toBe(12345);
222
+ });
223
+
224
+ it("热路径 interrupt=true:进程活 → prompt streamingBehavior:steer", () => {
225
+ const child = makeStreamChild();
226
+ spawnedChildren.set(record.id, child);
227
+
228
+ service.deliverMessage(record, "stop now", true);
229
+
230
+ const lines = readStdinLines(child);
231
+ expect(lines[0]).toMatchObject({ type: "prompt", message: "stop now", streamingBehavior: "steer" });
232
+ expect(record.status).toBe("running");
233
+ });
234
+
235
+ it("热路径 disarm idle timer:arm 后 deliverMessage → timer 清除(防 turn 期间误杀)", () => {
236
+ const child = makeStreamChild();
237
+ spawnedChildren.set(record.id, child);
238
+ // 先 arm idle timer(模拟 Step 4a agent_settled 后 armed)
239
+ lifecycle.armIdleTimer(record.id, () => {}, 10000);
240
+ expect(lifecycle.hasIdleTimer(record.id)).toBe(true);
241
+
242
+ service.deliverMessage(record, "msg", false);
243
+
244
+ // disarmIdleTimer 被调 → timer 清除(新 turn 不被 idle timer 误杀)
245
+ expect(lifecycle.hasIdleTimer(record.id)).toBe(false);
246
+ });
247
+
248
+ it("冷路径:进程死(无 child)→ resumeRound spawn(runSpawn 收到 resume 参数)", async () => {
249
+ mockRunSpawn.mockResolvedValueOnce(makeResult(true));
250
+ // spawnedChildren 无该 record → getChildByRecord 返回 undefined → 冷路径
251
+
252
+ service.deliverMessage(record, "resume msg", false);
253
+
254
+ await vi.waitFor(() => expect(mockRunSpawn).toHaveBeenCalledTimes(1));
255
+ const call = mockRunSpawn.mock.calls[0]!;
256
+ expect(call[1]).toBe("resume msg");
257
+ expect(call[4]).toEqual({
258
+ sessionFile: record.sessionFile,
259
+ model: record.model,
260
+ thinkingLevel: record.thinkingLevel,
261
+ });
262
+ });
263
+
264
+ it("冷路径 child.killed=true → 走 resume(判活用 !child.killed)", async () => {
265
+ mockRunSpawn.mockResolvedValueOnce(makeResult(true));
266
+ const child = makeStreamChild();
267
+ Object.assign(child, { killed: true }); // 进程已 kill
268
+ spawnedChildren.set(record.id, child);
269
+
270
+ service.deliverMessage(record, "after kill", false);
271
+
272
+ await vi.waitFor(() => expect(mockRunSpawn).toHaveBeenCalledTimes(1));
273
+ });
274
+
275
+ it("续聊后 agent_settled → onRoundSettled 设 running + round+1(v4 B-1 idle 折入 running,复用 Step 4a 链路)", () => {
276
+ // buildSessionRunnerContext 是 private,类型断言访问(测试专用)
277
+ const ctx = (service as unknown as { buildSessionRunnerContext(): SessionRunnerContext }).buildSessionRunnerContext();
278
+ record.status = "running"; // 模拟 deliverMessage 热路径设的新 turn 状态
279
+ const beforeRound = record.round;
280
+
281
+ // 模拟 session-runner 在 agent_settled 时调本回调(Step 4a 接入点)
282
+ ctx.onRoundSettled!(record);
283
+
284
+ expect(record.status).toBe("running");
285
+ expect(record.round).toBe(beforeRound! + 1);
286
+ });
287
+ });
288
+
289
+ // ============================================================
290
+ // 冷路径并发守卫(review round2 MF1:同 turn 批量两条 message 双冷路径双 spawn)
291
+ // ============================================================
292
+ // 复现链(reviewer 探针实证):pi 对同一条 assistant message 的 tool calls 顺序执行
293
+ // (subagent tool sequential),tool1 的 deliverMessage 在冷路径 resumeRound 返回即
294
+ // resolve——早于 runSpawn 完成 spawn 注册(session-runner spawnedChildren.set 前有
295
+ // pool.acquire await / writePromptToTempFile 等多个异步点);tool2 立即执行 →
296
+ // getChildByRecord 仍 undefined → 再次冷路径。v4 两态收敛后 resumeRound 的
297
+ // `status !== "running"` 守卫对 idle-resumable record 恒放行(idle 本来就是 running)、
298
+ // `status = "running"` 是幂等写 → 两次 kickOff → runSpawn 被调 2 次 → 两个 pi 子进程
299
+ // 以 --session 同一 JSONL 双写 + 第一个进程脱离 kill 记账成孤儿。
300
+ describe("deliverMessage 冷路径并发守卫(review round2 MF1)", () => {
301
+ let agentDir: string;
302
+ let service: SubagentService;
303
+ let record: ExecutionRecord;
304
+
305
+ beforeEach(() => {
306
+ agentDir = makeTmpAgentDir();
307
+ const modelService = new ModelConfigService({ agentDir });
308
+ service = new SubagentService({ cwd: agentDir, modelService });
309
+ service.initSession({ pi: makePi(), sessionId: "root-session" });
310
+ record = makeIdleRecord();
311
+ record.sessionFile = path.join(agentDir, "fake-session.jsonl");
312
+ spawnedChildren.clear();
313
+ mockRunSpawn.mockReset();
314
+ lifecycle._resetLifecycleState();
315
+ });
316
+
317
+ afterEach(() => {
318
+ service.dispose();
319
+ spawnedChildren.clear();
320
+ lifecycle._resetLifecycleState();
321
+ fs.rmSync(agentDir, { recursive: true, force: true });
322
+ });
323
+
324
+ it("同 record 连续两条 message 冷路径 → 第二条 throw 行动语言,runSpawn 仅 1 次", async () => {
325
+ // runSpawn 挂起不 resolve:模拟真实 spawn 异步窗口(pool.acquire 排队 + tempFile + spawn),
326
+ // 此窗口内 spawnedChildren 尚未注册 → 第二条 message 必再走冷路径。
327
+ let releaseFirst!: (r: AgentResult) => void;
328
+ mockRunSpawn.mockImplementationOnce(
329
+ () => new Promise<AgentResult>((res) => { releaseFirst = res; }),
330
+ );
331
+
332
+ // 第一条:正常冷路径 resume
333
+ await expect(service.deliverMessage(record, "first msg", false)).resolves.toBeUndefined();
334
+ await vi.waitFor(() => expect(mockRunSpawn).toHaveBeenCalledTimes(1));
335
+
336
+ // 第二条:spawn 仍在途(getChildByRecord undefined)→ 再走冷路径。
337
+ // 修复前:resumeRound 守卫恒放行 → 第二次 kickOff → runSpawn 2 次(双 spawn 双写 session)。
338
+ // 修复后:in-flight 守卫 throw 行动语言(MF-4)。
339
+ await expect(service.deliverMessage(record, "second msg", false)).rejects.toThrow(
340
+ /already starting a new round/,
341
+ );
342
+ expect(mockRunSpawn).toHaveBeenCalledTimes(1);
343
+
344
+ // 轮次完成 → 守卫清除 → 后续冷路径可再 resume(守卫不得永久死锁 record)
345
+ releaseFirst(makeResult(true));
346
+ await vi.waitFor(() =>
347
+ expect((service as unknown as { resumesInFlight: Set<string> }).resumesInFlight.has(record.id)).toBe(false),
348
+ );
349
+ mockRunSpawn.mockResolvedValueOnce(makeResult(true));
350
+ await expect(service.deliverMessage(record, "third msg", false)).resolves.toBeUndefined();
351
+ await vi.waitFor(() => expect(mockRunSpawn).toHaveBeenCalledTimes(2));
352
+ expect(mockRunSpawn.mock.calls[1]![1]).toBe("third msg");
353
+ });
354
+
355
+ it("守卫是 record 级:A 在途 resume 不拦截 B 的冷路径 message", async () => {
356
+ const recordB = makeIdleRecord("sa-chat-b");
357
+ recordB.sessionFile = path.join(agentDir, "fake-session-b.jsonl");
358
+ let releaseA!: (r: AgentResult) => void;
359
+ mockRunSpawn.mockImplementation(
360
+ () => new Promise<AgentResult>((res) => { releaseA = res; }),
361
+ );
362
+
363
+ await service.deliverMessage(record, "A msg", false);
364
+ await vi.waitFor(() => expect(mockRunSpawn).toHaveBeenCalledTimes(1));
365
+
366
+ // B 的冷路径不受 A 在途影响
367
+ await expect(service.deliverMessage(recordB, "B msg", false)).resolves.toBeUndefined();
368
+ await vi.waitFor(() => expect(mockRunSpawn).toHaveBeenCalledTimes(2));
369
+ expect(mockRunSpawn.mock.calls[1]![0]).toBe(recordB);
370
+
371
+ releaseA(makeResult(true));
372
+ });
373
+
374
+ it("resume 在途时直接调 resumeRound(不经 deliverMessage)同样被守卫拦截", () => {
375
+ // promise 同步创建:release 立即可用(runSpawn 在 pool.acquire 微任务后才被调)
376
+ let release!: (r: AgentResult) => void;
377
+ const gate = new Promise<AgentResult>((res) => { release = res; });
378
+ mockRunSpawn.mockImplementationOnce(() => gate);
379
+
380
+ service.resumeRound(record, "first");
381
+ expect(() => service.resumeRound(record, "second")).toThrow(/already starting a new round/);
382
+
383
+ release(makeResult(true));
384
+ });
385
+ });
@@ -0,0 +1,241 @@
1
+ // src/execution/__tests__/epipe-fallback.test.ts
2
+ //
3
+ // deliverMessage EPIPE 兜底集成测试——热路径 stdin 写入 EPIPE 时自动转冷路径 resume + 消息重放。
4
+ //
5
+ // 场景覆盖:
6
+ // 1. 首次 EPIPE → 自动转冷路径 resumeRound(runSpawn 收到 resume 参数 + 原消息)
7
+ // 2. 连续 2 次 EPIPE → throw 含恢复指引(防无限循环)
8
+ // 3. 热路径成功写入后清零 EPIPE 计数(正常路径不受影响)
9
+
10
+ import * as fs from "node:fs";
11
+ import * as os from "node:os";
12
+ import * as path from "node:path";
13
+ import type { ChildProcess } from "node:child_process";
14
+ import { PassThrough } from "node:stream";
15
+
16
+ import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
17
+
18
+ const { loggerMock } = vi.hoisted(() => ({
19
+ loggerMock: { debug: vi.fn(), warn: vi.fn(), error: vi.fn(), info: vi.fn() },
20
+ }));
21
+ vi.mock("@zhushanwen/pi-extension-logger", () => ({ getLogger: () => loggerMock }));
22
+
23
+ // mock session-runner:runSpawn 受控 + killAllSpawnedChildren 空实现;
24
+ // getChildByRecord/spawnedChildren 提供真实 Map 语义。
25
+ vi.mock("../session-runner.ts", () => {
26
+ const spawnedChildren = new Map<string, unknown>();
27
+ return {
28
+ runSpawn: vi.fn(),
29
+ killAllSpawnedChildren: vi.fn(),
30
+ spawnedChildren,
31
+ getChildByRecord: (id: string): unknown => spawnedChildren.get(id),
32
+ };
33
+ });
34
+
35
+ import { runSpawn, spawnedChildren } from "../session-runner.ts";
36
+ import * as lifecycle from "../lifecycle-manager.ts";
37
+ import { createRecord } from "../execution-record.ts";
38
+ import { ModelConfigService } from "../model-config-service.ts";
39
+ import type { ModelInfo } from "../model-resolver.ts";
40
+ import { SubagentService } from "../subagent-service.ts";
41
+ import type { PiLike } from "../subagent-service.ts";
42
+ import type { AgentResult, ExecutionRecord } from "../types.ts";
43
+
44
+ const mockRunSpawn = vi.mocked(runSpawn);
45
+
46
+ function makeTmpAgentDir(): string {
47
+ return fs.mkdtempSync(path.join(os.tmpdir(), "epipe-test-"));
48
+ }
49
+
50
+ function makePi(): PiLike & {
51
+ appendEntry: ReturnType<typeof vi.fn>;
52
+ events: { emit: ReturnType<typeof vi.fn> };
53
+ sendMessage: ReturnType<typeof vi.fn>;
54
+ } {
55
+ return { appendEntry: vi.fn(), events: { emit: vi.fn() }, sendMessage: vi.fn() };
56
+ }
57
+
58
+ function makeResult(success: boolean): AgentResult {
59
+ return {
60
+ text: success ? "done" : "err",
61
+ turns: 1,
62
+ durationMs: 100,
63
+ success,
64
+ error: success ? undefined : "boom",
65
+ sessionId: "sess-1",
66
+ toolCalls: [],
67
+ };
68
+ }
69
+
70
+ /** chatMode running-resumable record(第一轮已完成,等待续聊;v4 B-1 旧 idle 折入 running)。 */
71
+ function makeIdleRecord(id = "sa-epipe"): ExecutionRecord {
72
+ const record = createRecord(id, {
73
+ agent: "general-purpose",
74
+ model: "test/test-model",
75
+ thinkingLevel: "low",
76
+ mode: "background",
77
+ task: "initial task",
78
+ slug: "epipe-chat",
79
+ startedAt: 1000,
80
+ rootSessionId: "root-session",
81
+ chatMode: true,
82
+ });
83
+ record.status = "running";
84
+ record.round = 1;
85
+ record.controller = new AbortController();
86
+ return record;
87
+ }
88
+
89
+ /**
90
+ * 构造 EPIPE child:stdin.write 抛 {code:'EPIPE'},模拟子进程已退出但 close 事件尚未到达的窗口。
91
+ */
92
+ function makeEpipeChild(): ChildProcess {
93
+ const fakeStdin = {
94
+ write: vi.fn(() => {
95
+ const err = Object.assign(new Error("write after end"), { code: "EPIPE" });
96
+ throw err;
97
+ }),
98
+ destroyed: false,
99
+ } as unknown as PassThrough;
100
+ return { stdin: fakeStdin, pid: 99999 } as unknown as ChildProcess;
101
+ }
102
+
103
+ /**
104
+ * 构造正常 child:PassThrough stdin(可正常写入)。
105
+ */
106
+ function makeNormalChild(): ChildProcess {
107
+ return { stdin: new PassThrough(), pid: 88888 } as unknown as ChildProcess;
108
+ }
109
+
110
+ // ============================================================
111
+ // deliverMessage EPIPE 兜底
112
+ // ============================================================
113
+
114
+ describe("deliverMessage EPIPE 兜底(热路径 stdin EPIPE → 冷路径 resume)", () => {
115
+ let agentDir: string;
116
+ let service: SubagentService;
117
+ let record: ExecutionRecord;
118
+
119
+ beforeEach(() => {
120
+ agentDir = makeTmpAgentDir();
121
+ const modelService = new ModelConfigService({ agentDir });
122
+ service = new SubagentService({ cwd: agentDir, modelService });
123
+ service.initSession({ pi: makePi(), sessionId: "root-session" });
124
+ record = makeIdleRecord();
125
+ record.sessionFile = path.join(agentDir, "fake-session.jsonl");
126
+ spawnedChildren.clear();
127
+ mockRunSpawn.mockReset();
128
+ lifecycle._resetLifecycleState();
129
+ loggerMock.warn.mockClear();
130
+ });
131
+
132
+ afterEach(() => {
133
+ service.dispose();
134
+ spawnedChildren.clear();
135
+ lifecycle._resetLifecycleState();
136
+ fs.rmSync(agentDir, { recursive: true, force: true });
137
+ });
138
+
139
+ it("首次 EPIPE → 自动转冷路径 resumeRound + 原消息重放", async () => {
140
+ mockRunSpawn.mockResolvedValueOnce(makeResult(true));
141
+ // 注册 EPIPE child(热路径会命中但 stdin.write 抛 EPIPE)
142
+ spawnedChildren.set(record.id, makeEpipeChild());
143
+
144
+ // deliverMessage 不 throw(首次 EPIPE 走 resume 兜底)
145
+ await expect(service.deliverMessage(record, "msg after epipe", false)).resolves.toBeUndefined();
146
+
147
+ // spawnedChildren 中的死进程条目已清理(EPIPE catch 块 delete)
148
+ expect(spawnedChildren.has(record.id)).toBe(false);
149
+
150
+ // resumeRound 被触发(冷路径),runSpawn 收到 resume 参数 + 原消息
151
+ await vi.waitFor(() => expect(mockRunSpawn).toHaveBeenCalledTimes(1));
152
+ const call = mockRunSpawn.mock.calls[0]!;
153
+ expect(call[1]).toBe("msg after epipe");
154
+ expect(call[4]).toEqual({
155
+ sessionFile: record.sessionFile,
156
+ model: record.model,
157
+ thinkingLevel: record.thinkingLevel,
158
+ });
159
+
160
+ // warn 日志包含 EPIPE 关键词
161
+ expect(loggerMock.warn).toHaveBeenCalled();
162
+ const warnCalls = loggerMock.warn.mock.calls;
163
+ const epipeWarn = warnCalls.find((c: unknown[]) =>
164
+ typeof c[0] === "string" && c[0].includes("EPIPE"),
165
+ );
166
+ expect(epipeWarn).toBeDefined();
167
+ });
168
+
169
+ it("连续 2 次 EPIPE → throw 含恢复指引(防无限循环)", async () => {
170
+ mockRunSpawn.mockResolvedValue(makeResult(true));
171
+ // 注册 EPIPE child
172
+ spawnedChildren.set(record.id, makeEpipeChild());
173
+
174
+ // 第 1 次:EPIPE → resume(不 throw)
175
+ await service.deliverMessage(record, "first epipe", false);
176
+ await vi.waitFor(() => expect(mockRunSpawn).toHaveBeenCalledTimes(1));
177
+
178
+ // resume 完成后 record 回 running(v4 B-1:finalizeRoundToIdle 设 running,旧 idle 折入)
179
+ await vi.waitFor(() => expect(record.status).toBe("running"));
180
+
181
+ // 第 2 次:再次注入 EPIPE child + EPIPE
182
+ spawnedChildren.set(record.id, makeEpipeChild());
183
+
184
+ // 第 2 次 EPIPE → throw 含恢复指引(连续 2 次触发 exhaustion)
185
+ // 注意:第二 EPIPE 时 count 已为 2,catch 块立即 throw(不经过 resumeRound)。
186
+ let thrown: unknown;
187
+ try {
188
+ await service.deliverMessage(record, "second epipe", false);
189
+ } catch (err) {
190
+ thrown = err;
191
+ }
192
+ expect(thrown).toBeInstanceOf(Error);
193
+ expect((thrown as Error).message).toContain("EPIPE fallback exhausted");
194
+ expect((thrown as Error).message).toContain("2 consecutive EPIPE");
195
+ expect((thrown as Error).message).toContain("action:'close'");
196
+ expect((thrown as Error).message).toContain("action:'start'");
197
+ });
198
+
199
+ it("热路径成功写入后清零 EPIPE 计数(正常路径不受 EPIPE 计数影响)", async () => {
200
+ mockRunSpawn.mockResolvedValue(makeResult(true));
201
+
202
+ // 第 1 轮:EPIPE → resume
203
+ spawnedChildren.set(record.id, makeEpipeChild());
204
+ await service.deliverMessage(record, "epipe msg", false);
205
+ await vi.waitFor(() => expect(mockRunSpawn).toHaveBeenCalledTimes(1));
206
+ await vi.waitFor(() => expect(record.status).toBe("running"));
207
+
208
+ // 第 2 轮:正常 child,成功写入(清零 EPIPE 计数)
209
+ spawnedChildren.set(record.id, makeNormalChild());
210
+ await service.deliverMessage(record, "normal msg", true);
211
+ // 不 throw,status=running(热路径成功)
212
+ expect(record.status).toBe("running");
213
+
214
+ // 第 3 轮:再次 EPIPE → 但因为第 2 轮清零了计数,这次是首次 EPIPE(不 throw)
215
+ // 需要先让 record 回 running(等待续聊态)
216
+ record.status = "running";
217
+ spawnedChildren.set(record.id, makeEpipeChild());
218
+ await expect(service.deliverMessage(record, "after reset", false)).resolves.toBeUndefined();
219
+ });
220
+
221
+ it("EPIPE 兜底与冷路径共用 in-flight 守卫:resume 在途时 EPIPE 兜底不再二次 spawn(review round2 MF1)", async () => {
222
+ // 冷路径发起 resume,runSpawn 挂起(spawn 异步窗口内)
223
+ let releaseFirst!: (r: AgentResult) => void;
224
+ mockRunSpawn.mockImplementationOnce(
225
+ () => new Promise<AgentResult>((res) => { releaseFirst = res; }),
226
+ );
227
+ await service.deliverMessage(record, "cold path first", false);
228
+ await vi.waitFor(() => expect(mockRunSpawn).toHaveBeenCalledTimes(1));
229
+
230
+ // 注册 EPIPE child → deliverMessage 走热路径 → stdin EPIPE → 兜底调 resumeRound
231
+ // → in-flight 命中 → throw(不再走第二次 spawn。EPIPE 计数仍 +1 但未达阈值 2,
232
+ // exhaustion 分支不触发;throw 由兜底路径的 resumeRound 守卫抛出)
233
+ spawnedChildren.set(record.id, makeEpipeChild());
234
+ await expect(service.deliverMessage(record, "epipe during resume", false)).rejects.toThrow(
235
+ /already starting a new round/,
236
+ );
237
+ expect(mockRunSpawn).toHaveBeenCalledTimes(1);
238
+
239
+ releaseFirst(makeResult(true));
240
+ });
241
+ });