@zhushanwen/pi-subagent-workflow 0.4.0 → 0.4.2

package/src/orchestration/worker-script-builder.ts

@@ -69,6 +69,17 @@ export function buildWorkerScript(userScript: string): string {
     '  console.error = function (...args) { _pushWorkerLog("error", args); };',
     '  console.info = function (...args) { _pushWorkerLog("info", args); };',
     '',
+    '  // ── safePostMessage wrapper: 统一 postMessage 防御（DataCloneError 等）──',
+    '  function _safePost(msg, context) {',
+    '    try { parentPort.postMessage(msg); return true; }',
+    '    catch (e) {',
+    '      const errMsg = e && e.message ? e.message : String(e);',
+    '      const stack = e && e.stack ? e.stack : "";',
+    '      _pushWorkerLog("error", ["[postMessage failed:" + context + "]", errMsg, stack]);',
+    '      return false;',
+    '    }',
+    '  }',
+    '',
     '  // ── Internal state ──',
     '  let _callIdCounter = 0;',
     '  let _agentCallCount = 0;',
@@ -201,7 +212,9 @@ export function buildWorkerScript(userScript: string): string {
     '    const _effectivePhase = opts.phase || _currentPhase;\n' +
       '    delete opts.phase;\n' +
       '\n' +
-      '    parentPort.postMessage({ type: "agent-call", callId, opts, phase: _effectivePhase });',
+      '    if (!_safePost({ type: "agent-call", callId, opts, phase: _effectivePhase }, "agent-call")) {',
+    '      return Promise.reject(new Error("postMessage failed for agent-call (callId=" + callId + "): see workerLogs"));',
+    '    }',
     '    return new Promise((resolve, reject) => {',
     '      _pendingCalls.set(callId, { resolve, reject });',
     '    });',
@@ -219,7 +232,21 @@ export function buildWorkerScript(userScript: string): string {
     '      if (typeof c === "object" && c !== null && (c.task || c.agent)) { return agent(c); }',
     '      return agent(c);',
     '    }));',
-    '    return settled.map((r) => r.status === "fulfilled" ? r.value : (r.reason instanceof Error ? r.reason.message : String(r.reason)));',
+    '    return settled.map((r) => {',
+    '      if (r.status === "fulfilled") {',
+    '        const v = r.value;',
+    '        if (v !== null && typeof v === "object" && !Array.isArray(v)) {',
+    '          // 主线程 fallback（postAgentResult/postResult serialization failed）回发的对象含 error 字段',
+    '          // → 归一化为 failed 形状，与脚本侧 r.status === "failed" 检查统一',
+    '          if (typeof v.error === "string" && v.error.length > 0) return { status: "failed", error: v.error };',
+    '          return v;',
+    '        }',
+    '        return { status: "failed", error: "agent returned non-object result (type=" + typeof v + ")" };',
+    '      }',
+    '      const reason = r.reason;',
+    '      const errMsg = reason instanceof Error ? reason.message : String(reason);',
+    '      return { status: "failed", error: errMsg };',
+    '    });',
     '  }',
     '',
  // ── pipeline global ──
@@ -227,19 +254,31 @@ export function buildWorkerScript(userScript: string): string {
     '    // Single-arg mode: pipeline([stage1, stage2, ...])',
     '    if (Array.isArray(firstArg) && restStages.length === 0) {',
     '      let result;',
-    '      for (const stage of firstArg) { result = await stage(result); }',
+    '      for (let i = 0; i < firstArg.length; i++) {',
+    '        try { result = await firstArg[i](result); }',
+    '        catch (e) {',
+    '          const msg = e && e.message ? e.message : String(e);',
+    '          _pushWorkerLog("error", ["[pipeline stage " + i + " failed]", msg]);',
+    '          throw e;',
+    '        }',
+    '      }',
     '      return result;',
     '    }',
     '    // Cartesian product mode: pipeline([items], stage1, stage2, ...)',
     '    if (Array.isArray(firstArg) && restStages.length > 0 && typeof restStages[0] === "function") {',
     '      const results = [];',
-    '      for (const item of firstArg) {',
+    '      for (let idx = 0; idx < firstArg.length; idx++) {',
+    '        const item = firstArg[idx];',
     '        let val = item;',
     '        let failed = false;',
     '        for (const stage of restStages) {',
     '          if (failed) break;',
     '          try { val = await stage(val); }',
-    '          catch (e) { val = null; failed = true; }',
+    '          catch (e) {',
+    '          const msg = e && e.message ? e.message : String(e);',
+    '          _pushWorkerLog("error", ["[pipeline cartesian stage failed for item " + (idx + 1) + "]", msg]);',
+    '          val = null; failed = true;',
+    '          }',
     '        }',
     '        results.push(val);',
     '      }',
@@ -256,7 +295,9 @@ export function buildWorkerScript(userScript: string): string {
     '    const workflowArgs = (typeof args === "object" && args !== null) ? args : {};',
     '    const callId = _callIdCounter;',
     '    _callIdCounter++;',
-    '    parentPort.postMessage({ type: "workflow-call", callId, name, args: workflowArgs });',
+    '    if (!_safePost({ type: "workflow-call", callId, name, args: workflowArgs }, "workflow-call")) {',
+    '      return Promise.reject(new Error("postMessage failed for workflow-call (name=" + name + "): see workerLogs"));',
+    '    }',
     '    return new Promise((resolve, reject) => {',
     '      _pendingCalls.set(callId, { resolve, reject });',
     '    });',
@@ -272,11 +313,11 @@ export function buildWorkerScript(userScript: string): string {
     '})().then((result) => {',
     '  const { parentPort, workerData } = require("node:worker_threads");',
     '  const runId = (workerData.args && typeof workerData.args === "object" && workerData.args._runId) || "";',
-    '  parentPort.postMessage({ type: "return", runId, result, workerLogs: _workerLogs });',
+    '  _safePost({ type: "return", runId, result, workerLogs: _workerLogs }, "return");',
     '}).catch((err) => {',
     '  const { parentPort, workerData } = require("node:worker_threads");',
     '  const runId = (workerData.args && typeof workerData.args === "object" && workerData.args._runId) || "";',
-    '  parentPort.postMessage({ type: "error", runId, error: err.message || String(err), workerLogs: _workerLogs });',
+    '  _safePost({ type: "error", runId, error: err.message || String(err), workerLogs: _workerLogs }, "error");',
     '});',
   ].join("\n");
 }

package/workflows/README.md

@@ -28,7 +28,9 @@ workflow run parallel --args target="src/auth/login.ts"
 workflow run parallel --args target="..." --args 'perspectives=["security","readability"]'
 ```
 
-`perspectives` 默认 `["security","performance","maintainability"]`。每个视角一个并行 agent，各自返回评分+发现的问题；最后再一个 agent 汇总成总体评分+top 问题+共识。
+`perspectives` 默认 `["security","performance","maintainability"]`。每个视角一个并行 agent，各自返回评分+发现的问题，最后纯代码拼接各视角的 findings。
+
+> **Note (breaking)**: `outcome.aggregate` is now a concatenated string of each perspective's findings (format: `[perspective] finding1; finding2`, joined by newlines). Previously it was an LLM-produced object `{overallScore, topIssues, consensus}`. If you have generated workflows or downstream tools parsing the old object shape, update them to read `outcome.per_perspective` for structured per-perspective scores/findings, or treat `outcome.aggregate` as plain text.
 
 ### scatter-gather — 分发-收集
 
@@ -36,7 +38,7 @@ workflow run parallel --args target="..." --args 'perspectives=["security","read
 workflow run scatter-gather --args task="重构认证模块，涉及 session/jwt/oauth 三块"
 ```
 
-三段：第一个 agent 把大任务拆成 2-4 个可并行子任务 → `parallel()` 并行处理每个子任务 → 最后一个 agent 合并所有结果。
+三段：第一个 agent 把大任务拆成 2-4 个可并行子任务 → `parallel()` 并行处理每个子任务 → gather 阶段用 `agent()` 把各子任务结果合并成最终结论（LLM 合并，非纯代码拼接）。
 
 ### map-reduce — 映射-归约
 
@@ -45,7 +47,7 @@ workflow run map-reduce --args 'items=["file1.ts","file2.ts","file3.ts"]' --args
 workflow run map-reduce --args itemsJson=/path/to/items.json --args operation="..."
 ```
 
-`items` 直接传 JSON 数组，或 `itemsJson` 传 JSON 文件路径（二选一）。`parallel()` 对每个 item 并行执行 `operation` → 一个 agent 把所有结果归约成单一结论。
+`items` 直接传 JSON 数组，或 `itemsJson` 传 JSON 文件路径（二选一）。`parallel()` 对每个 item 并行执行 `operation` → reduce 阶段用 `agent()` 把各 item 的 map 结果归约成单一结论（LLM 归约，非纯代码拼接）。
 
 ## 编排 API
 

package/workflows/chain.js

@@ -19,8 +19,8 @@ const meta = {
 
 // ── 入参（$ARGS）──────────────────────────────────────────────────
 const task = $ARGS.task;
-if (!task) {
-  throw new Error("chain 缺少必需参数 task。用法：workflow run chain --args task=\"<任务描述>\"");
+if (typeof task !== "string" || task.trim() === "") {
+  throw new Error("chain 缺少必需参数 task（非空字符串）。用法：workflow run chain --args task=\"<描述>\"");
 }
 
 log("chain 开始，task=" + task);

package/workflows/map-reduce.js

@@ -82,12 +82,12 @@ try {
   let mapFailed = 0;
   for (let i = 0; i < mappedRaw.length; i++) {
     const r = mappedRaw[i];
-    if (!r || r.error) {
+    if (!r || r.status === "failed" || r.error) {
       mapped.push({
         itemIndex: i,
         item: items[i],
         status: "failed",
-        error: r ? r.error : "agent 无返回",
+        error: r ? (r.error || "agent 返回 failed 状态") : "agent 无返回",
       });
       mapFailed++;
     } else {
@@ -95,7 +95,7 @@ try {
         itemIndex: i,
         item: items[i],
         status: "ok",
-        mapped: r.mapped,
+        mapped: (typeof r.mapped === "string" ? r.mapped : "(无结果)"),
       });
     }
   }
@@ -104,10 +104,11 @@ try {
   }
   log("map 完成：ok=" + (items.length - mapFailed) + " failed=" + mapFailed);
 
-  // ── 段 2：reduce（agent 聚合所有 map 结果）──────────────────────
+  // ── 段 2：reduce（agent 归约所有 map 结果）──────────────────────
   phase("reduce");
   currentPhase = "reduce";
-  const reduced = await agent({
+
+  const reducedResult = await agent({
     prompt:
       "以下是对 " + items.length + " 个 item 执行「" + operation + "」的结果，请归约成单一结论：\n\n" +
       JSON.stringify(mapped, null, 2),
@@ -127,7 +128,10 @@ try {
     phases_run: ["map", "reduce"],
     items_total: items.length,
     items_mapped: items.length - mapFailed,
-    reduced: { reduced: (reduced?.reduced ?? "(归约无结果)"), stats: (reduced?.stats ?? "(归约无结果)") },
+    reduced: {
+      reduced: (reducedResult?.reduced ?? "(归约无结果)"),
+      stats: (reducedResult?.stats ?? "(归约无结果)"),
+    },
     message: "map-reduce 完成：map " + items.length + " 项（失败 " + mapFailed + "）→ reduce",
   };
 } catch (err) {

package/workflows/parallel.js

@@ -28,6 +28,9 @@ if (!target) {
 const perspectives = Array.isArray($ARGS.perspectives) && $ARGS.perspectives.length > 0
   ? $ARGS.perspectives
   : ["security", "performance", "maintainability"];
+if (perspectives.some((p) => typeof p !== "string")) {
+  throw new Error("parallel 参数 perspectives 必须是字符串数组，实际含非字符串元素");
+}
 
 log("parallel 开始，target=" + target + " perspectives=" + JSON.stringify(perspectives));
 
@@ -68,15 +71,20 @@ try {
   let failedCount = 0;
   for (let i = 0; i < perPerspectiveRaw.length; i++) {
     const r = perPerspectiveRaw[i];
-    if (!r || r.error) {
+    if (!r || r.status === "failed" || r.error) {
       perPerspective.push({
         perspective: perspectives[i],
         status: "failed",
-        error: r ? r.error : "agent 无返回",
+        error: r ? (r.error || "agent 返回 failed 状态") : "agent 无返回",
       });
       failedCount++;
     } else {
-      perPerspective.push({ perspective: perspectives[i], status: "ok", ...r });
+      perPerspective.push({
+        perspective: perspectives[i],
+        status: "ok",
+        score: typeof r.score === "number" ? r.score : undefined,
+        findings: Array.isArray(r.findings) ? r.findings : [],
+      });
     }
   }
   if (failedCount === perspectives.length) {
@@ -87,36 +95,18 @@ try {
   // ── 段 2：aggregate（汇总多视角结果）────────────────────────────
   phase("aggregate");
   currentPhase = "aggregate";
-  const aggregate = await agent({
-    prompt:
-      "以下是多视角分析结果，请综合出总体评分、top 问题和共识：\n\n" +
-      JSON.stringify(perPerspective, null, 2),
-    schema: {
-      type: "object",
-      properties: {
-        overallScore: { type: "number", description: "综合评分 0-10" },
-        topIssues: {
-          type: "array",
-          items: { type: "string" },
-          description: "最关键的问题（按严重度排序）",
-        },
-        consensus: { type: "string", description: "多视角共识总结" },
-      },
-      required: ["overallScore", "topIssues", "consensus"],
-    },
-    description: "parallel-aggregate",
-  });
+
+  // 纯代码合并：拼接各视角发现的问题（不调用 LLM）
+  const aggregateResult = perPerspective
+    .map((p) => "[" + (p.perspective || "?") + "] " + (p.findings ? p.findings.join("; ") : "(no findings)"))
+    .join("\n");
 
   outcome = {
     status: failedCount > 0 ? "partial" : "ok",
     phases_run: ["parallel-analyze", "aggregate"],
     perspectives_analyzed: perspectives.length,
     per_perspective: perPerspective,
-    aggregate: {
-      overallScore: (aggregate?.overallScore ?? "(聚合无结果)"),
-      topIssues: (aggregate?.topIssues ?? []),
-      consensus: (aggregate?.consensus ?? "(聚合无结果)"),
-    },
+    aggregate: aggregateResult,
     message: "parallel 完成：" + perspectives.length + " 视角（失败 " + failedCount + "）→ 聚合",
   };
 } catch (err) {

package/workflows/scatter-gather.js

@@ -62,6 +62,9 @@ try {
   if (subtasks.length === 0) {
     throw new Error("scatter 返回的 subtasks 为空");
   }
+  if (subtasks.some((s) => !s || typeof s.name !== "string")) {
+    throw new Error("scatter 返回的 subtasks 每项需含 name 字符串字段");
+  }
   log("scatter 出 " + subtasks.length + " 个子任务");
 
   // ── 段 2：process（parallel 并行处理每个子任务）──────────────────
@@ -89,15 +92,19 @@ try {
   let failedCount = 0;
   for (let i = 0; i < processedRaw.length; i++) {
     const r = processedRaw[i];
-    if (!r || r.error) {
+    if (!r || r.status === "failed" || r.error) {
       processed.push({
         subtask: subtasks[i].name,
         status: "failed",
-        error: r ? r.error : "agent 无返回",
+        error: r ? (r.error || "agent 返回 failed 状态") : "agent 无返回",
       });
       failedCount++;
     } else {
-      processed.push({ subtask: subtasks[i].name, status: "ok", result: r.result });
+      processed.push({
+        subtask: subtasks[i].name,
+        status: "ok",
+        result: (typeof r.result === "string" ? r.result : "(无结果)"),
+      });
     }
   }
   if (failedCount === subtasks.length) {
@@ -105,10 +112,11 @@ try {
   }
   log("process 完成：ok=" + (subtasks.length - failedCount) + " failed=" + failedCount);
 
-  // ── 段 3：gather（合并所有子任务结果）───────────────────────────
+  // ── 段 3：gather（agent 合并所有子任务结果）─────────────────────
   phase("gather");
   currentPhase = "gather";
-  const gathered = await agent({
+
+  const gatheredResult = await agent({
     prompt:
       "以下是各子任务的处理结果，请合并成一个完整、一致的最终结果：\n\n" +
       JSON.stringify(processed, null, 2),
@@ -129,8 +137,8 @@ try {
     subtasks_total: subtasks.length,
     subtasks_processed: subtasks.length - failedCount,
     gathered: {
-      mergedResult: (gathered?.mergedResult ?? "(合并无结果)"),
-      completeness: (gathered?.completeness ?? "(合并无结果)"),
+      mergedResult: (gatheredResult?.mergedResult ?? "(合并无结果)"),
+      completeness: (gatheredResult?.completeness ?? "(合并无结果)"),
     },
     message: "scatter-gather 完成：split " + subtasks.length + " → process（失败 " + failedCount + "）→ merge",
   };