@zhushanwen/pi-rename-session 0.12.1 → 0.13.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zhushanwen/pi-rename-session",
-  "version": "0.12.1",
+  "version": "0.13.0",
   "type": "module",
   "main": "index.ts",
   "taiji": {
@@ -35,6 +35,7 @@
     "pi-package"
   ],
   "dependencies": {
+    "@zhushanwen/extension-protocol": "0.21.0",
     "@zhushanwen/pi-ext-guards": "0.5.0",
     "@zhushanwen/pi-extension-logger": "0.6.2",
     "@zhushanwen/pi-llm-shared": "0.11.3"
@@ -52,6 +53,7 @@
   "peerDependencies": {
     "@earendil-works/pi-coding-agent": "^1.0.0",
     "@earendil-works/pi-ai": "^1.0.0",
+    "@earendil-works/pi-tui": "^1.0.0",
     "typebox": "1.3.27"
   },
   "peerDependenciesMeta": {
@@ -61,6 +63,9 @@
     "@earendil-works/pi-ai": {
       "optional": true
     },
+    "@earendil-works/pi-tui": {
+      "optional": true
+    },
     "typebox": {
       "optional": true
     }

package/src/__tests__/index.test.ts

@@ -786,7 +786,10 @@ interface RegisteredRenameTool {
 		signal: undefined,
 		onUpdate: undefined,
 		ctx: ExtensionContext,
-	) => Promise<unknown>;
+	) => Promise<{
+		content: Array<{ type: string; text: string }>;
+		details: { summary: string };
+	}>;
 }
 
 describe("rename_session 工具注册与 execute 守卫（D3）", () => {
@@ -846,9 +849,19 @@ describe("rename_session 工具注册与 execute 守卫（D3）", () => {
 		setupWithMode(AGENT_TOOL_CONFIG);
 		const tool = setup.registeredTool as RegisteredRenameTool;
 
-		await tool.execute("call-1", { title: "  **重构配置加载**  " }, undefined, undefined, createMockCtx());
+		const result = await tool.execute(
+			"call-1",
+			{ title: "  **重构配置加载**  " },
+			undefined,
+			undefined,
+			createMockCtx(),
+		);
 
 		expect(setup.setSessionNameMock).toHaveBeenCalledWith("重构配置加载");
+		// execute 组装线：details.summary 恒写入（index.ts:123 buildRenameSessionSummary；
+		// title 用清洗后落库值，与 content 文案同源——组装行丢失时此处红）
+		expect(result.details.summary).toBe('Renamed session to "重构配置加载"');
+		expect(result.content[0].text).toBe("已命名：重构配置加载");
 	});
 
 	it("TC-T6: execute 时 title 清洗后为空（纯标点）→ isError（throw），不落库", async () => {

package/src/__tests__/render.test.ts

@@ -0,0 +1,76 @@
+import type { Theme } from "@earendil-works/pi-coding-agent";
+import { describe, expect, it } from "vitest";
+
+import {
+	buildRenameSessionSummary,
+	renderRenameSessionResult,
+} from "../render";
+
+// ── mock theme（fg 直通，便于断言纯文本）────────────
+
+const mockTheme = {
+	fg: (_color: string, text: string) => text,
+	bg: (_color: string, text: string) => text,
+	bold: (text: string) => text,
+	italic: (text: string) => text,
+	underline: (text: string) => text,
+	inverse: (text: string) => text,
+	strikethrough: (text: string) => text,
+	getFgAnsi: (_color: string) => "",
+	getBgAnsi: (_color: string) => "",
+	getColorMode: () => "truecolor" as const,
+	getThinkingBorderColor: () => (text: string) => text,
+	getBashModeBorderColor: () => (text: string) => text,
+} as unknown as Theme;
+
+/** Text 实例的渲染行（width 足够宽避免 wrap；每行被 pad 到宽度，断言用 trim 后全等） */
+function renderedText(result: unknown, expanded = false): string {
+	return renderRenameSessionResult(result, { expanded }, mockTheme)
+		.render(400)
+		.map((line) => line.trimEnd())
+		.join("\n");
+}
+
+// ── buildRenameSessionSummary ───────────────────────
+
+describe("buildRenameSessionSummary", () => {
+	it("动作 + 清洗后标题，一行英文摘要", () => {
+		expect(buildRenameSessionSummary({ title: "修复登录超时" })).toBe(
+			'Renamed session to "修复登录超时"',
+		);
+		expect(buildRenameSessionSummary({ title: "refactor-config-loader" })).toBe(
+			'Renamed session to "refactor-config-loader"',
+		);
+	});
+});
+
+// ── renderRenameSessionResult ───────────────────────
+
+describe("renderRenameSessionResult", () => {
+	const result = {
+		content: [{ type: "text", text: "已命名：修复登录超时" }],
+		details: { summary: 'Renamed session to "修复登录超时"' },
+	};
+
+	it("折叠态 → details.summary 一行摘要", () => {
+		expect(renderedText(result, false)).toBe('Renamed session to "修复登录超时"');
+	});
+
+	it("展开态 → content 纯文本", () => {
+		expect(renderedText(result, true)).toBe("已命名：修复登录超时");
+	});
+
+	it("无 details（旧版本持久化 entry）→ 折叠态回退 content 文本", () => {
+		const legacy = { content: [{ type: "text", text: "已命名：legacy" }] };
+		expect(renderedText(legacy, false)).toBe("已命名：legacy");
+	});
+
+	it("content 非 text 类型 → 折叠态兜底 Renamed", () => {
+		const odd = { content: [{ type: "image" }], details: {} };
+		expect(renderedText(odd, false)).toBe("Renamed");
+	});
+
+	it("result 非对象（防御）→ 兜底 Renamed 不抛错", () => {
+		expect(renderedText(undefined, false)).toBe("Renamed");
+	});
+});

package/src/index.ts

@@ -2,6 +2,7 @@ import type {
 	AgentToolResult,
 	ExtensionAPI,
 	ExtensionContext,
+	Theme,
 } from "@earendil-works/pi-coding-agent";
 import { getLogger, setPiHandle } from "@zhushanwen/pi-extension-logger";
 import { Type } from "typebox";
@@ -9,6 +10,11 @@ import { Type } from "typebox";
 import { registerAutoRenameCommand } from "./commands.js";
 import { landTitle } from "./landing.js";
 import { debugLog as llmDebugLog, extractMessageText, isSubagentSession } from "./llm.js";
+import {
+	buildRenameSessionSummary,
+	renderRenameSessionResult,
+	type RenameSessionDetails,
+} from "./render.js";
 import {
 	cleanTitle,
 	countSuccessfulAssistantReplies,
@@ -94,7 +100,7 @@ function registerRenameSessionTool(pi: ExtensionAPI): void {
 			_signal: AbortSignal | undefined,
 			_onUpdate: undefined,
 			ctx: ExtensionContext,
-		): Promise<AgentToolResult<Record<string, never>>> {
+		): Promise<AgentToolResult<RenameSessionDetails>> {
 			// subagent session 守卫先于 mode 守卫：subagent 拒绝与 mode 无关（即便 mode 仍为
 			// agent-tool 也不该命名临时子会话），且文案归因到 subagent 而非误导性的「模式已切换」
 			if (isSubagentSession(ctx.sessionManager.getSessionDir())) {
@@ -112,7 +118,14 @@ function registerRenameSessionTool(pi: ExtensionAPI): void {
 			}
 			pi.setSessionName(title);
 			llmDebugLog(`tool renamed to "${title}"`);
-			return { content: [{ type: "text", text: `已命名：${title}` }], details: {} };
+			return {
+				content: [{ type: "text", text: `已命名：${title}` }],
+				details: { summary: buildRenameSessionSummary({ title }) },
+			};
+		},
+
+		renderResult(result: unknown, options: { expanded: boolean }, theme: Theme) {
+			return renderRenameSessionResult(result, options, theme);
 		},
 	});
 }

package/src/render.ts

@@ -0,0 +1,54 @@
+/**
+ * rename_session 工具渲染层（收起态一行摘要）。
+ *
+ * summary 是「做了什么」的一行英文摘要：GUI 侧读 tool result 的 details.summary 展示，
+ * TUI renderResult 折叠态渲染同一份文本（dim 染色），展开态回退 content 纯文本。
+ */
+
+import type { Theme } from "@earendil-works/pi-coding-agent";
+import { Text } from "@earendil-works/pi-tui";
+import { firstContentText } from "@zhushanwen/extension-protocol";
+
+/** rename_session 工具 result 的 details 形状（summary 由 buildRenameSessionSummary 产出）。 */
+export interface RenameSessionDetails { // oe-exempt:20261017:framework:details 数据形状窄 view（单实现消费，非抽象接口）
+	summary: string;
+}
+
+/** 收起态一行摘要：动作 + 新标题。title 用清洗后落库值（execute 传入），与 content 文案同源。 */
+export function buildRenameSessionSummary(params: { title: string }): string {
+	return `Renamed session to "${params.title}"`;
+}
+
+/** unknown 值按字段名安全取值（index-signature 收窄，替代全可选结构断言）。 */
+function fieldValue(v: unknown, key: string): unknown {
+	if (typeof v !== "object" || v === null) return undefined;
+	return (v as Record<string, unknown>)[key];
+}
+
+/** 从 tool result 的 details 安全读取 summary（容错历史 entry 与非对象形态）。 */
+function readDetailsSummary(result: unknown): string | undefined {
+	const summary = fieldValue(fieldValue(result, "details"), "summary");
+	return typeof summary === "string" && summary !== "" ? summary : undefined;
+}
+
+/** content[0] 的 text 纯文本（content 缺失或非 text 类型时兜底空串）。 */
+function contentText(result: unknown): string {
+	const content = fieldValue(result, "content");
+	if (!Array.isArray(content)) return "";
+	return firstContentText({ content });
+}
+
+/**
+ * TUI renderResult：折叠态（expanded=false）= details.summary 一行（dim）；展开态 =
+ * content 纯文本。summary 缺失（旧版本持久化 entry）时折叠态回退 content 文本。
+ */
+export function renderRenameSessionResult(
+	result: unknown,
+	options: { expanded: boolean },
+	theme: Theme,
+): Text {
+	const summary = readDetailsSummary(result);
+	const collapsed = summary ?? (contentText(result) || "Renamed");
+	const text = options.expanded ? contentText(result) : collapsed;
+	return new Text(theme.fg("dim", text), 0, 0);
+}