@zhushanwen/pi-plan 0.5.2 → 1.0.0

package/src/__tests__/compact-handler.test.ts

@@ -1,348 +0,0 @@
-import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
-
-import type { PlanState } from "../state.js";
-import { PLAN_CONTEXT_CUSTOM_TYPE } from "../state.js";
-
-// Mock fs before importing compact.ts (ESM namespace is not configurable)
-vi.mock("node:fs", () => ({
-  readFileSync: vi.fn(),
-}));
-
-// Import after mock setup
-import { handlePlanComplete, registerPlanEventHandlers } from "../compact.js";
-
-const fsMock = vi.mocked(await import("node:fs"));
-
-// --- Shared mock factories ---
-
-function makePi() {
-  return {
-    on: vi.fn(),
-    appendEntry: vi.fn(),
-    sendMessage: vi.fn(),
-  };
-}
-
-type CtxMock = ReturnType<typeof makeCtx>;
-function makeCtx() {
-  const onCompleteFns: Array<() => void> = [];
-  const onErrorFns: Array<(e: Error) => void> = [];
-
-  return {
-    sessionManager: { getSessionId: () => "test-session", getEntries: () => [] as unknown[] },
-    ui: { notify: vi.fn() },
-    compact: vi.fn((opts: { onComplete?: () => void; onError?: (e: Error) => void }) => {
-      if (opts.onComplete) onCompleteFns.push(opts.onComplete);
-      if (opts.onError) onErrorFns.push(opts.onError);
-    }),
-    _onCompleteFns: onCompleteFns,
-    _onErrorFns: onErrorFns,
-  };
-}
-
-function makeActiveState(): PlanState {
-  return {
-    isActive: true,
-    planFilePath: "/tmp/plan.md",
-    requirement: "Add login page",
-    templateName: "default",
-  };
-}
-
-function setupFsMock(content: string) {
-  fsMock.readFileSync.mockReturnValue(content);
-}
-
-/**
- * goal 桥 slot key——与 compact.ts / goal 侧 index.ts 的字符串一致（本地声明，
- * 不 import 对方包：pi-goal 是 optional peer，两侧靠同一字符串共享 slot）。
- */
-const GOAL_INIT_SLOT_KEY = Symbol.for("@zhushanwen/pi-goal.goalInit");
-
-/** 在 globalThis slot 上挂 goal 桥——mock 形态与真实通道同构（goal-bridge-cross-extension.md §3.4：goal 侧 Reflect.set 挂 slot，本测试同款挂载）。 */
-function attachGoalInit(impl: () => boolean) {
-  const fn = vi.fn(impl);
-  Reflect.set(globalThis, GOAL_INIT_SLOT_KEY, fn);
-  return fn;
-}
-
-/** 清 slot 防跨用例 globalThis 泄漏（设计 §3.4：teardown 两侧通用）。 */
-afterEach(() => {
-  Reflect.set(globalThis, GOAL_INIT_SLOT_KEY, undefined);
-});
-
-/** 最近一次 sendMessage 的正文（P8 custom message 的 content 字段）。 */
-function lastSteer(pi: ReturnType<typeof makePi>): string {
-  const calls = (pi.sendMessage as ReturnType<typeof vi.fn>).mock.calls;
-  const last = calls[calls.length - 1]?.[0] as { content?: string } | undefined;
-  return String(last?.content ?? "");
-}
-
-/** P8 执行通知断言形态：custom message 三要素 + streaming steer options（A6）。 */
-function executionNotice(content: unknown) {
-  return [
-    { customType: PLAN_CONTEXT_CUSTOM_TYPE, content, display: false },
-    { deliverAs: "steer", triggerTurn: true },
-  ];
-}
-
-// --- handlePlanComplete tests ---
-
-describe("handlePlanComplete", () => {
-  let pi: ReturnType<typeof makePi>;
-  let ctx: CtxMock;
-
-  beforeEach(() => {
-    vi.clearAllMocks();
-    pi = makePi();
-    ctx = makeCtx();
-    setupFsMock("## 实现步骤\n1. Step one\n2. Step two");
-  });
-
-  describe("compact isolation", () => {
-    it("execute mode: goalInit deferred to onComplete, then goal steer on success (D2 时序——goal entry 在压缩后世界创建)", () => {
-      const goalInit = attachGoalInit(() => true);
-
-      const outcome = handlePlanComplete(pi as never, ctx as never, makeActiveState(), "compact", "execute");
-
-      expect(outcome).toBeUndefined(); // compact 档 outcome 在回调内产生，不进同步返回值
-      expect(ctx.compact).toHaveBeenCalledOnce();
-      expect(goalInit).not.toHaveBeenCalled(); // 压缩完成前不创建 goal entry
-
-      ctx._onCompleteFns[0]();
-
-      expect(goalInit).toHaveBeenCalledWith(
-        "Execute plan: /tmp/plan.md",
-        undefined,
-        ctx,
-        "plan",
-        [
-          "All 2 steps of plan executed and verified",
-          "1. Step one",
-          "2. Step two",
-        ],
-      );
-      expect(pi.sendMessage).toHaveBeenCalledWith(...executionNotice(expect.stringContaining("Goal tracking is active via /goal")));
-      expect(ctx.ui.notify).not.toHaveBeenCalled();
-    });
-
-    it("execute mode (compact, bridge unmounted): onComplete sends degraded direct-execution steer, no goalInit", () => {
-      // execute 档整合 goal 桥：桥未挂载（goal-unavailable）→ 降级为直接执行指引
-      handlePlanComplete(pi as never, ctx as never, makeActiveState(), "compact", "execute");
-      ctx._onCompleteFns[0]();
-
-      const steer = lastSteer(pi);
-      expect(steer).toContain("Goal tracking was not started (goal-unavailable)");
-      expect(steer).toContain("subagents"); // 降级后仍指到 auto-parallel 直接执行
-      expect(steer).toContain("current session");
-    });
-
-    it("skill mode (compact): onComplete steer carries the skill entry path (D10 skillEntryPath 通路)", () => {
-      const goalInit = attachGoalInit(() => true);
-      const skillEntryPath = "/tmp/fixtures/skills/dev-flow/SKILL.md";
-
-      handlePlanComplete(pi as never, ctx as never, makeActiveState(), "compact", "skill:dev-flow", skillEntryPath);
-      ctx._onCompleteFns[0]();
-
-      expect(goalInit).not.toHaveBeenCalled();
-      const steer = lastSteer(pi);
-      expect(steer).toContain("skill:dev-flow"); // Execution mode 行透传 execMode
-      expect(steer).toContain("dev-flow"); // 指引按名加载
-      expect(steer).toContain("/tmp/fixtures/skills/dev-flow/SKILL.md"); // 路径读取指引（skillEntryPath = 入口文件路径，直接透传）
-    });
-
-    it("onError (execute mode, init-refused): compact-failure notify + degraded steer + warning notify, no /goal promise", () => {
-      attachGoalInit(() => false); // goalInit 返回 false：已有 active goal
-
-      handlePlanComplete(pi as never, ctx as never, makeActiveState(), "compact", "execute");
-      ctx._onErrorFns[0](new Error("compact failed"));
-
-      const notifyTexts = (ctx.ui.notify as ReturnType<typeof vi.fn>).mock.calls.map((c) => String(c[0]));
-      expect(notifyTexts.some((t) => t.includes("Compact failed"))).toBe(true);
-      expect(notifyTexts.some((t) => t.includes("init-refused"))).toBe(true);
-
-      const steer = lastSteer(pi);
-      expect(steer).toContain("Goal tracking was not started (init-refused)");
-      expect(steer).toContain("/goal clear"); // 恢复动作
-      expect(steer).not.toContain("Goal tracking is active via /goal"); // 承诺不再无凭据发出
-    });
-  });
-
-  describe("direct isolation", () => {
-    it("execute mode success: returns outcome synchronously, goal steer, no notify", () => {
-      attachGoalInit(() => true);
-
-      const outcome = handlePlanComplete(pi as never, ctx as never, makeActiveState(), "direct", "execute");
-
-      expect(outcome).toEqual({ started: true });
-      expect(pi.sendMessage).toHaveBeenCalledWith(...executionNotice(expect.stringContaining("Goal tracking is active via /goal")));
-      expect(ctx.compact).not.toHaveBeenCalled();
-      expect(ctx.ui.notify).not.toHaveBeenCalled();
-    });
-
-    it("skill mode (direct): returns undefined, steer with skill entry path (steer 文案含 skillEntryPath，D10)", () => {
-      attachGoalInit(() => true);
-      const skillEntryPath = "/tmp/fixtures/skills/dev-flow/SKILL.md";
-
-      const outcome = handlePlanComplete(pi as never, ctx as never, makeActiveState(), "direct", "skill:dev-flow", skillEntryPath);
-
-      expect(outcome).toBeUndefined();
-      const steer = lastSteer(pi);
-      expect(steer).toContain("Execution mode: skill:dev-flow");
-      expect(steer).toContain("/tmp/fixtures/skills/dev-flow/SKILL.md");
-      expect(steer).toContain("follow its workflow");
-    });
-
-    it("skill mode (散 .md 形态): steer carries the file path itself, not a dangling joined SKILL.md", () => {
-      attachGoalInit(() => true);
-      const looseEntryPath = "/tmp/fixtures/skills/loose-tool.md";
-
-      handlePlanComplete(pi as never, ctx as never, makeActiveState(), "direct", "skill:loose-tool", looseEntryPath);
-
-      const steer = lastSteer(pi);
-      expect(steer).toContain("/tmp/fixtures/skills/loose-tool.md"); // 文件路径本身
-      expect(steer).not.toContain("loose-tool.md/SKILL.md"); // 不再拼接 SKILL.md（悬空指引根修）
-      expect(steer).not.toContain("/tmp/fixtures/skills/SKILL.md"); // 旧缺陷形态：散 .md 的 dirname + SKILL.md
-    });
-
-    it("skill mode without skillEntryPath falls back to name-only guidance (防御形态)", () => {
-      attachGoalInit(() => true);
-
-      handlePlanComplete(pi as never, ctx as never, makeActiveState(), "direct", "skill:dev-flow");
-
-      const steer = lastSteer(pi);
-      expect(steer).toContain("load the dev-flow skill");
-      expect(steer).not.toContain("SKILL.md");
-    });
-
-    it("unknown isolation value falls through to direct delivery instead of silently dropping the choice (D1 防御形态)", () => {
-      attachGoalInit(() => true);
-
-      handlePlanComplete(pi as never, ctx as never, makeActiveState(), "tree", "execute");
-
-      expect(pi.sendMessage).toHaveBeenCalledWith(...executionNotice(expect.stringContaining("Goal tracking is active via /goal")));
-      expect(ctx.compact).not.toHaveBeenCalled();
-      expect(ctx.ui.notify).not.toHaveBeenCalledWith(expect.stringContaining("/tree"), "info");
-    });
-  });
-
-  // goal 桥五个失败出口 → GoalBridgeOutcome 五值（D2）
-  describe("tryGoalInit failure exits (execute mode, direct isolation)", () => {
-    it("goal-unavailable: bridge not mounted → degraded steer + warning notify", () => {
-      const outcome = handlePlanComplete(pi as never, ctx as never, makeActiveState(), "direct", "execute");
-
-      expect(outcome).toEqual({ started: false, reason: "goal-unavailable" });
-      const steer = lastSteer(pi);
-      expect(steer).toContain("Goal tracking was not started (goal-unavailable)");
-      expect(steer).not.toContain("Goal tracking is active via /goal");
-      expect(ctx.ui.notify).toHaveBeenCalledWith(expect.stringContaining("goal-unavailable"), "warning");
-    });
-
-    it("plan-unreadable: plan file read fails → recovery points at the plan file", () => {
-      attachGoalInit(() => true);
-      fsMock.readFileSync.mockImplementation(() => { throw new Error("ENOENT: plan.md"); });
-
-      const outcome = handlePlanComplete(pi as never, ctx as never, makeActiveState(), "direct", "execute");
-
-      expect(outcome).toEqual({ started: false, reason: "plan-unreadable" });
-      expect(lastSteer(pi)).toContain("Check that the plan file exists");
-      expect(ctx.ui.notify).toHaveBeenCalledWith(expect.stringContaining("plan-unreadable"), "warning");
-    });
-
-    it("no-steps: plan content has no extractable steps", () => {
-      attachGoalInit(() => true);
-      setupFsMock("# Plan\n\nProse without any numbered list.");
-
-      const outcome = handlePlanComplete(pi as never, ctx as never, makeActiveState(), "direct", "execute");
-
-      expect(outcome).toEqual({ started: false, reason: "no-steps" });
-      expect(lastSteer(pi)).toContain("Implementation Steps");
-      expect(ctx.ui.notify).toHaveBeenCalledWith(expect.stringContaining("no-steps"), "warning");
-    });
-
-    it("init-refused: goalInit returns false (active goal exists)", () => {
-      attachGoalInit(() => false);
-
-      const outcome = handlePlanComplete(pi as never, ctx as never, makeActiveState(), "direct", "execute");
-
-      expect(outcome).toEqual({ started: false, reason: "init-refused" });
-      expect(lastSteer(pi)).toContain("/goal clear");
-      expect(ctx.ui.notify).toHaveBeenCalledWith(expect.stringContaining("init-refused"), "warning");
-    });
-
-    it("internal-error: goalInit throws → outcome carries detail, notify includes it, does not propagate", () => {
-      attachGoalInit(() => { throw new Error("goalInit exploded"); });
-
-      const outcome = handlePlanComplete(pi as never, ctx as never, makeActiveState(), "direct", "execute");
-
-      expect(outcome).toEqual({ started: false, reason: "internal-error", detail: "goalInit exploded" });
-      expect(lastSteer(pi)).toContain("Goal tracking was not started (internal-error)");
-      expect(lastSteer(pi)).not.toContain("Goal tracking is active via /goal");
-      expect(ctx.ui.notify).toHaveBeenCalledWith(expect.stringContaining("goalInit exploded"), "warning");
-    });
-  });
-});
-
-// --- registerPlanEventHandlers tests ---
-
-describe("registerPlanEventHandlers", () => {
-  let pi: ReturnType<typeof makePi>;
-
-  beforeEach(() => {
-    vi.clearAllMocks();
-    pi = makePi();
-    setupFsMock("Plan content here");
-  });
-
-  function captureHandlers(): Record<string, (...args: unknown[]) => Promise<unknown>> {
-    const handlers: Record<string, (...args: unknown[]) => Promise<unknown>> = {};
-    for (const call of pi.on.mock.calls) {
-      handlers[call[0] as string] = call[1];
-    }
-    return handlers;
-  }
-
-  it("session_before_compact (active): returns compaction summary with plan content", async () => {
-    const sessions = new Map();
-    sessions.set("test-session", makeActiveState());
-
-    registerPlanEventHandlers(pi as never, sessions);
-    const handlers = captureHandlers();
-
-    const result = await handlers["session_before_compact"]({}, makeCtx() as never);
-    const r = result as { compaction: { summary: string } };
-
-    expect(r.compaction.summary).toContain("Plan content here");
-    expect(r.compaction.summary).toContain("Add login page");
-  });
-
-  it("session_before_compact (inactive): returns empty object {}", async () => {
-    registerPlanEventHandlers(pi as never, new Map());
-    const handlers = captureHandlers();
-
-    const result = await handlers["session_before_compact"]({}, makeCtx() as never);
-    expect(result).toEqual({});
-  });
-
-  it("session_before_tree (active): returns summary with plan content", async () => {
-    const sessions = new Map();
-    sessions.set("test-session", makeActiveState());
-
-    registerPlanEventHandlers(pi as never, sessions);
-    const handlers = captureHandlers();
-
-    const result = await handlers["session_before_tree"]({}, makeCtx() as never);
-    const r = result as { summary: { summary: string } };
-
-    expect(r.summary.summary).toContain("Plan content here");
-    expect(r.summary.summary).toContain("/tmp/plan.md");
-  });
-
-  it("session_before_tree (inactive): returns empty object {}", async () => {
-    registerPlanEventHandlers(pi as never, new Map());
-    const handlers = captureHandlers();
-
-    const result = await handlers["session_before_tree"]({}, makeCtx() as never);
-    expect(result).toEqual({});
-  });
-});