@zhushanwen/pi-permission 0.0.1

package/src/__tests__/rule-editor.test.ts

@@ -0,0 +1,252 @@
+/**
+ * rule-editor.test.ts — W8 T8: rule-editor 三模式分发 + RPC 循环测试。
+ *
+ * 覆盖：
+ *  - editRulesViaOverlay headless 降级（notify + undefined）
+ *  - editRulesViaOverlay TUI 模式（mock custom → done）
+ *  - editViaRpc：cancel（第一次 select undefined）
+ *  - editViaRpc：[Done] → undefined（无变更）
+ *  - editViaRpc：[+ Add rule] → 选模板 → 选命令 → ops
+ *  - editViaRpc：选已有规则 → delete → ops
+ *  - editViaRpc：G16 多循环反映前序 ops
+ */
+import { describe, expect, it, vi } from "vitest";
+
+import { editRulesViaOverlay,type RuleEditorContext } from "../rule-editor.js";
+import type { Rule } from "../types.js";
+
+// ──────────────────────── helpers ────────────────────────
+
+function makeRule(overrides: Partial<Rule> = {}): Rule {
+	return {
+		id: "user-1",
+		tool: "bash",
+		pattern: "npm *",
+		action: "allow",
+		source: "user",
+		...overrides,
+	};
+}
+
+function makeCtx(overrides: Partial<RuleEditorContext> = {}): RuleEditorContext {
+	const ctx: RuleEditorContext = {
+		mode: overrides.mode ?? "rpc",
+		ui: {
+			notify: overrides.ui?.notify ?? vi.fn(),
+			select: overrides.ui?.select ?? vi.fn(() => Promise.resolve(undefined)),
+			custom: overrides.ui?.custom ?? vi.fn(() => Promise.resolve(undefined)),
+		},
+	};
+	// 透传可选 input（M7：rule-editor custom 模板用真实文本输入）
+	if (overrides.ui?.input !== undefined) {
+		ctx.ui.input = overrides.ui.input;
+	}
+	return ctx;
+}
+
+function makeCounter(): () => string {
+	let n = 1;
+	return (): string => `user-${n++}`;
+}
+
+// ──────────────────────── headless 降级 ────────────────────────
+
+describe("RE1: headless 模式降级", () => {
+	it("json mode → notify + undefined", async () => {
+		const notify = vi.fn();
+		const ctx = makeCtx({ mode: "json", ui: { notify, select: vi.fn(), custom: vi.fn() } });
+		const result = await editRulesViaOverlay(ctx, [], makeCounter());
+		expect(result).toBeUndefined();
+		expect(notify).toHaveBeenCalledWith(expect.stringContaining("not available in headless"), "warning");
+	});
+
+	it("print mode → notify + undefined", async () => {
+		const notify = vi.fn();
+		const ctx = makeCtx({ mode: "print", ui: { notify, select: vi.fn(), custom: vi.fn() } });
+		const result = await editRulesViaOverlay(ctx, [], makeCounter());
+		expect(result).toBeUndefined();
+		expect(notify).toHaveBeenCalledOnce();
+	});
+});
+
+// ──────────────────────── TUI 模式 ────────────────────────
+
+describe("RE2: TUI 模式", () => {
+	it("custom factory 被调用，comp cancel settle 空 ops", async () => {
+		const customMock = vi.fn(
+			<T,>(factory: (tui: unknown, theme: unknown, kb: unknown, done: (r: T) => void) => unknown) =>
+				new Promise<T>((resolve) => {
+					const comp = factory({}, {}, {}, (r: T) => resolve(r));
+					// 模拟 cancel：comp 是 RuleEditorComponent，调 cancel → done(ops)
+					if (comp !== null && typeof comp === "object" && "cancel" in comp) {
+						(comp as { cancel: () => void }).cancel();
+					}
+				}),
+		);
+		const ctx = makeCtx({ mode: "tui", ui: { notify: vi.fn(), select: vi.fn(), custom: customMock } });
+		const result = await editRulesViaOverlay(ctx, [], makeCounter());
+		expect(customMock).toHaveBeenCalledOnce();
+		expect(result).toEqual([]);
+	});
+});
+
+// ──────────────────────── RPC: cancel ────────────────────────
+
+describe("RE3: RPC cancel", () => {
+	it("第一次 select undefined → 返回 undefined", async () => {
+		const ctx = makeCtx({
+			mode: "rpc",
+			ui: { notify: vi.fn(), select: vi.fn(() => Promise.resolve(undefined)), custom: vi.fn() },
+		});
+		const result = await editRulesViaOverlay(ctx, [makeRule()], makeCounter());
+		expect(result).toBeUndefined();
+	});
+});
+
+// ──────────────────────── RPC: [Done] ────────────────────────
+
+describe("RE4: RPC [Done]", () => {
+	it("选 [Done]（无变更）→ undefined", async () => {
+		const selectMock = vi.fn()
+			.mockResolvedValueOnce("[Done]"); // list 选 [Done]
+		const ctx = makeCtx({
+			mode: "rpc",
+			ui: { notify: vi.fn(), select: selectMock, custom: vi.fn() },
+		});
+		const result = await editRulesViaOverlay(ctx, [makeRule()], makeCounter());
+		expect(result).toBeUndefined();
+	});
+});
+
+// ──────────────────────── RPC: add flow ────────────────────────
+
+describe("RE5: RPC add flow", () => {
+	it("[+ Add rule] → 选 allow-family → 选 npm → ops 含 add", async () => {
+		// rpcAddFlow 调用序列（allow-family 模板，无 scope 选择）：
+		//   list → template → rpcSelectCommand[mode: Browse] → rpcSelectCommand[cmd: npm] → 第二次 list
+		// 注：rpcSelectCommand 现先问 "How to select command?"（Browse / Type-to-search），多一步 select。
+		//     allow-family 模板在 build 前不再追加 scope 选择（仅 deny-family/allow-subcmd 需要）。
+		const selectMock = vi.fn()
+			.mockResolvedValueOnce("[+ Add rule]") // list（call 0）
+			.mockResolvedValueOnce("Allow command family") // template（call 1）
+			.mockResolvedValueOnce("[Browse list]") // rpcSelectCommand mode（call 2）
+			.mockResolvedValueOnce("npm (Node package manager)") // command（call 3）
+			.mockResolvedValueOnce("[Done]"); // list 第二次循环（call 4）
+		const ctx = makeCtx({
+			mode: "rpc",
+			ui: { notify: vi.fn(), select: selectMock, custom: vi.fn() },
+		});
+		const result = await editRulesViaOverlay(ctx, [], makeCounter());
+		expect(result).toBeDefined();
+		expect(result).toHaveLength(1);
+		expect(result![0]!.kind).toBe("add");
+		expect(result![0]!.rule.pattern).toBe("npm *");
+	});
+});
+
+// ──────────────────────── RPC: delete flow ────────────────────────
+
+describe("RE6: RPC delete flow", () => {
+	it("选已有规则 → [Delete this rule] → ops 含 delete", async () => {
+		const existingRule = makeRule({ id: "user-1", pattern: "npm *" });
+		const selectMock = vi.fn()
+			.mockResolvedValueOnce("[allow] npm *") // list 选规则
+			.mockResolvedValueOnce("[Delete this rule]") // edit action
+			.mockResolvedValueOnce("[Done]"); // list（第二次循环）
+		const ctx = makeCtx({
+			mode: "rpc",
+			ui: { notify: vi.fn(), select: selectMock, custom: vi.fn() },
+		});
+		const result = await editRulesViaOverlay(ctx, [existingRule], makeCounter());
+		expect(result).toBeDefined();
+		expect(result).toHaveLength(1);
+		expect(result![0]!.kind).toBe("delete");
+		expect(result![0]!.id).toBe("user-1");
+	});
+});
+
+// ──────────────────────── RPC: G16 多循环反映前序 ops ────────────────────────
+
+describe("RE7: G16 多循环反映前序 ops", () => {
+	it("add 后第二次 list 包含新规则", async () => {
+		// ask-before 模板调用序列（无 scope 选择）：
+		//   list → template → rpcSelectCommand[mode: Browse] → rpcSelectCommand[cmd: docker] → 第二次 list
+		// rpcSelectCommand 现多一步 mode 选择，故第二次 list 落在 call 4（非 call 3）。
+		const selectMock = vi.fn()
+			.mockResolvedValueOnce("[+ Add rule]") // list 1 (call 0)
+			.mockResolvedValueOnce("Ask before command") // template (call 1)
+			.mockResolvedValueOnce("[Browse list]") // rpcSelectCommand mode (call 2)
+			.mockResolvedValueOnce("docker (container runtime)") // command (call 3)
+			.mockResolvedValueOnce("[Done]"); // list 2 (call 4, 应含新规则)
+		const ctx = makeCtx({
+			mode: "rpc",
+			ui: { notify: vi.fn(), select: selectMock, custom: vi.fn() },
+		});
+		await editRulesViaOverlay(ctx, [], makeCounter());
+		// 第五次 select（index 4）是第二次 list，options 应包含新规则
+		const secondListArgs = selectMock.mock.calls[4] as [string, string[]];
+		expect(secondListArgs[1]).toContain("[ask] docker *");
+	});
+});
+
+// ──────────────────────── RPC: custom 模板用真实 ctx.ui.input（M7） ────────────────────────
+
+describe("RE8: RPC custom 模板用真实 ctx.ui.input（M7）", () => {
+	it("ctx.ui.input 可用 → custom 模板 pattern/description 走真实 input（不 fallback select）", async () => {
+		const selectMock = vi.fn()
+			.mockResolvedValueOnce("[+ Add rule]") // list
+			.mockResolvedValueOnce("Custom (advanced)") // template
+			.mockResolvedValueOnce("allow") // action select
+			.mockResolvedValueOnce("[Done]"); // list（第二次循环）
+		const inputMock = vi.fn()
+			.mockResolvedValueOnce("foo *") // pattern input
+			.mockResolvedValueOnce("my rule"); // description input
+		const ctx = makeCtx({
+			mode: "rpc",
+			ui: {
+				notify: vi.fn(),
+				select: selectMock,
+				custom: vi.fn(),
+				input: inputMock,
+			},
+		});
+		const result = await editRulesViaOverlay(ctx, [], makeCounter());
+		expect(result).toBeDefined();
+		expect(result).toHaveLength(1);
+		expect(result![0]!.kind).toBe("add");
+		// custom 模板的 pattern 来自真实 input
+		expect(result![0]!.rule.pattern).toBe("foo *");
+		// input 被调 2 次（pattern + description），且首参是提示文案
+		expect(inputMock).toHaveBeenCalledTimes(2);
+		expect(inputMock.mock.calls[0]![0]).toContain("Pattern");
+		expect(inputMock.mock.calls[1]![0]).toContain("Description");
+		// select 不应被当作 fallback input（pattern/description 走 input，非 select）
+		// select 仅用于：list / template / action / 第二次 list，无一含 Pattern/Description
+		for (const call of selectMock.mock.calls) {
+			const title = call[0] as string;
+			expect(title).not.toContain("Pattern");
+			expect(title).not.toContain("Description");
+		}
+	});
+
+	it("ctx.ui.input 缺失 → fallback 用 select 占位（保底，不崩）", async () => {
+		// input 降级为单选项 select：返回占位符文本（= 用户"选了"占位符）
+		const selectMock = vi.fn()
+			.mockResolvedValueOnce("[+ Add rule]") // list
+			.mockResolvedValueOnce("Custom (advanced)") // template
+			// pattern fallback select 返回占位符 "npm *"
+			.mockResolvedValueOnce("npm *")
+			.mockResolvedValueOnce("allow") // action select
+			// description fallback select 返回占位符 ""（空）→ 模板 description=undefined
+			.mockResolvedValueOnce("")
+			.mockResolvedValueOnce("[Done]"); // list（第二次循环）
+		const ctx = makeCtx({
+			mode: "rpc",
+			ui: { notify: vi.fn(), select: selectMock, custom: vi.fn() },
+		});
+		const result = await editRulesViaOverlay(ctx, [], makeCounter());
+		expect(result).toBeDefined();
+		expect(result).toHaveLength(1);
+		expect(result![0]!.rule.pattern).toBe("npm *");
+	});
+});

package/src/__tests__/rule-templates.test.ts

@@ -0,0 +1,264 @@
+/**
+ * rule-templates.test.ts — W8 T6: rule-templates 单元测试。
+ *
+ * 覆盖：
+ *  - PRESET_COMMANDS 结构（31 命令，7 类 + Other）
+ *  - 5 个模板 build（G4 wildcard pattern）
+ *  - classifyRuleTemplate（FAMILY_RE / SUBCMD_RE + action 映射）
+ *  - applyOps（add / edit / delete，纯函数）
+ *  - makeNextIdCounter（从已有规则提取最大 user-N）
+ */
+import { describe, expect, it } from "vitest";
+
+import {
+	allowFamilyTemplate,
+	allowSubcmdTemplate,
+	applyOps,
+	askBeforeTemplate,
+	classifyRuleTemplate,
+	customTemplate,
+	denyFamilyTemplate,
+	makeNextIdCounter,
+	PRESET_COMMANDS,
+} from "../rule-templates.js";
+import type { Rule } from "../types.js";
+
+// ──────────────────────── helpers ────────────────────────
+
+function makeRule(overrides: Partial<Rule> = {}): Rule {
+	return {
+		id: "user-1",
+		tool: "bash",
+		pattern: "npm *",
+		action: "allow",
+		source: "user",
+		...overrides,
+	};
+}
+
+// ──────────────────────── PRESET_COMMANDS ────────────────────────
+
+describe("RT1: PRESET_COMMANDS", () => {
+	it("共 53 个命令", () => {
+		expect(PRESET_COMMANDS).toHaveLength(53);
+	});
+
+	it("每个命令有 cmd / label / category", () => {
+		for (const cmd of PRESET_COMMANDS) {
+			expect(typeof cmd.cmd).toBe("string");
+			expect(cmd.cmd.length).toBeGreaterThan(0);
+			expect(typeof cmd.label).toBe("string");
+			expect(typeof cmd.category).toBe("string");
+		}
+	});
+
+	it("涵盖 9 个 category", () => {
+		const categories = new Set(PRESET_COMMANDS.map((c) => c.category));
+		expect(categories.size).toBe(9);
+		expect(categories.has("Package Managers")).toBe(true);
+		expect(categories.has("Containers & Cloud")).toBe(true);
+		expect(categories.has("Version Control")).toBe(true);
+		expect(categories.has("Build & Tasks")).toBe(true);
+		expect(categories.has("Network & Download")).toBe(true);
+		expect(categories.has("Filesystem")).toBe(true);
+		expect(categories.has("Runtime")).toBe(true);
+		expect(categories.has("Text Processing")).toBe(true);
+		expect(categories.has("System & Info")).toBe(true);
+	});
+
+	it("cmd 不含空格（单 token）", () => {
+		for (const cmd of PRESET_COMMANDS) {
+			expect(cmd.cmd).not.toMatch(/\s/);
+		}
+	});
+});
+
+// ──────────────────────── 模板 build（G4 wildcard） ────────────────────────
+
+describe("RT2: 模板 build（G4 wildcard pattern）", () => {
+	it("allow-family：{tool:'bash', pattern:'npm *', action:'allow', source:'user'}", () => {
+		const built = allowFamilyTemplate.build({ cmd: "npm" });
+		expect(built.tool).toBe("bash");
+		expect(built.pattern).toBe("npm *");
+		expect(built.action).toBe("allow");
+		expect(built.source).toBe("user");
+		expect(built).not.toHaveProperty("id"); // G8：无 id
+	});
+
+	it("deny-family any：{pattern:'git *', action:'deny'}", () => {
+		const built = denyFamilyTemplate.build({ cmd: "git", subcmd: "__any__" });
+		expect(built.pattern).toBe("git *");
+		expect(built.action).toBe("deny");
+	});
+
+	it("deny-family specific：{pattern:'git push *', action:'deny'}", () => {
+		const built = denyFamilyTemplate.build({ cmd: "git", subcmd: "push" });
+		expect(built.pattern).toBe("git push *");
+		expect(built.action).toBe("deny");
+	});
+
+	it("ask-before：{pattern:'docker *', action:'ask'}", () => {
+		const built = askBeforeTemplate.build({ cmd: "docker" });
+		expect(built.pattern).toBe("docker *");
+		expect(built.action).toBe("ask");
+	});
+
+	it("allow-subcmd：{pattern:'git status *', action:'allow'}", () => {
+		const built = allowSubcmdTemplate.build({ cmd: "git", subcmd: "status" });
+		expect(built.pattern).toBe("git status *");
+		expect(built.action).toBe("allow");
+	});
+
+	it("allow-subcmd __any__：退化为 allow-family 语义（pattern:'git *'）", () => {
+		const built = allowSubcmdTemplate.build({ cmd: "git", subcmd: "__any__" });
+		expect(built.pattern).toBe("git *");
+		expect(built.action).toBe("allow");
+	});
+
+	it("allow-subcmd undefined subcmd：也退化为 allow-family", () => {
+		const built = allowSubcmdTemplate.build({ cmd: "npm" });
+		expect(built.pattern).toBe("npm *");
+	});
+
+	it("custom：直接用 selections 字段组装", () => {
+		const built = customTemplate.build({
+			pattern: "rm -rf *",
+			action: "deny",
+			tool: "bash",
+			description: "never rm -rf",
+		});
+		expect(built.pattern).toBe("rm -rf *");
+		expect(built.action).toBe("deny");
+		expect(built.description).toBe("never rm -rf");
+	});
+
+	it("build 无 id 字段（G8）", () => {
+		const built = allowFamilyTemplate.build({ cmd: "npm" });
+		expect(built).not.toHaveProperty("id");
+	});
+
+	it("pattern 用 wildcard 不用正则（无 \\b 等）", () => {
+		const built = denyFamilyTemplate.build({ cmd: "git", subcmd: "push" });
+		expect(built.pattern).not.toContain("\\b");
+		expect(built.pattern).not.toContain("\\s");
+		expect(built.pattern).toBe("git push *");
+	});
+});
+
+// ──────────────────────── classifyRuleTemplate ────────────────────────
+
+describe("RT3: classifyRuleTemplate", () => {
+	it("npm * + allow → allow-family", () => {
+		expect(classifyRuleTemplate(makeRule({ pattern: "npm *", action: "allow" }))).toBe("allow-family");
+	});
+
+	it("git * + deny → deny-family（any）", () => {
+		expect(classifyRuleTemplate(makeRule({ pattern: "git *", action: "deny" }))).toBe("deny-family");
+	});
+
+	it("git push * + deny → deny-family（specific）", () => {
+		expect(classifyRuleTemplate(makeRule({ pattern: "git push *", action: "deny" }))).toBe("deny-family");
+	});
+
+	it("docker * + ask → ask-before", () => {
+		expect(classifyRuleTemplate(makeRule({ pattern: "docker *", action: "ask" }))).toBe("ask-before");
+	});
+
+	it("git status * + allow → allow-subcmd", () => {
+		expect(classifyRuleTemplate(makeRule({ pattern: "git status *", action: "allow" }))).toBe("allow-subcmd");
+	});
+
+	it("不匹配已知格式 → custom", () => {
+		expect(classifyRuleTemplate(makeRule({ pattern: "rm -rf /tmp/*", action: "deny" }))).toBe("custom");
+	});
+
+	it("* alone + allow → custom（不匹配 FAMILY_RE，无 cmd 前缀）", () => {
+		expect(classifyRuleTemplate(makeRule({ pattern: "*", action: "allow" }))).toBe("custom");
+	});
+});
+
+// ──────────────────────── applyOps ────────────────────────
+
+describe("RT4: applyOps", () => {
+	it("空 ops → 原数组不变", () => {
+		const rules = [makeRule()];
+		const result = applyOps(rules, []);
+		expect(result).toEqual(rules);
+		expect(result).not.toBe(rules); // 新数组
+	});
+
+	it("add：push 新规则", () => {
+		const rules = [makeRule({ id: "user-1" })];
+		const newRule = makeRule({ id: "user-2", pattern: "git *" });
+		const result = applyOps(rules, [{ kind: "add", rule: newRule }]);
+		expect(result).toHaveLength(2);
+		expect(result[1]!.id).toBe("user-2");
+	});
+
+	it("edit：替换指定 id 的规则", () => {
+		const rules = [makeRule({ id: "user-1", pattern: "npm *" })];
+		const edited = makeRule({ id: "user-1", pattern: "yarn *" });
+		const result = applyOps(rules, [{ kind: "edit", id: "user-1", rule: edited }]);
+		expect(result).toHaveLength(1);
+		expect(result[0]!.pattern).toBe("yarn *");
+	});
+
+	it("delete：过滤指定 id", () => {
+		const rules = [makeRule({ id: "user-1" }), makeRule({ id: "user-2" })];
+		const result = applyOps(rules, [{ kind: "delete", id: "user-1" }]);
+		expect(result).toHaveLength(1);
+		expect(result[0]!.id).toBe("user-2");
+	});
+
+	it("多 ops 顺序执行", () => {
+		const rules = [makeRule({ id: "user-1" })];
+		const ops = [
+			{ kind: "add" as const, rule: makeRule({ id: "user-2", pattern: "git *" }) },
+			{ kind: "edit" as const, id: "user-1", rule: makeRule({ id: "user-1", pattern: "yarn *" }) },
+			{ kind: "delete" as const, id: "user-2" },
+		];
+		const result = applyOps(rules, ops);
+		expect(result).toHaveLength(1);
+		expect(result[0]!.id).toBe("user-1");
+		expect(result[0]!.pattern).toBe("yarn *");
+	});
+
+	it("edit 不存在的 id → 不变", () => {
+		const rules = [makeRule({ id: "user-1" })];
+		const result = applyOps(rules, [{ kind: "edit", id: "user-999", rule: makeRule({ id: "user-999" }) }]);
+		expect(result).toHaveLength(1);
+		expect(result[0]!.id).toBe("user-1");
+	});
+});
+
+// ──────────────────────── makeNextIdCounter ────────────────────────
+
+describe("RT5: makeNextIdCounter", () => {
+	it("空规则 → 从 user-1 开始", () => {
+		const counter = makeNextIdCounter([]);
+		expect(counter()).toBe("user-1");
+		expect(counter()).toBe("user-2");
+	});
+
+	it("已有 user-3 → 从 user-4 开始", () => {
+		const existing = [makeRule({ id: "user-1" }), makeRule({ id: "user-3" })];
+		const counter = makeNextIdCounter(existing);
+		expect(counter()).toBe("user-4");
+		expect(counter()).toBe("user-5");
+	});
+
+	it("忽略非 user-<n> 格式的 id", () => {
+		const existing = [makeRule({ id: "builtin-safe-1" }), makeRule({ id: "user-5" })];
+		const counter = makeNextIdCounter(existing);
+		expect(counter()).toBe("user-6");
+	});
+
+	it("单调递增（多次调用）", () => {
+		const counter = makeNextIdCounter([]);
+		const ids = Array.from({ length: 10 }, () => counter());
+		expect(ids).toEqual([
+			"user-1", "user-2", "user-3", "user-4", "user-5",
+			"user-6", "user-7", "user-8", "user-9", "user-10",
+		]);
+	});
+});