@zhixuan92/multi-model-agent-core 4.5.4 → 4.6.0

package/dist/lifecycle/handlers/prepare-execution-context-handler.js

@@ -1,60 +1,83 @@
 import { DiffTracker } from '../diff-tracker.js';
 /**
- * StageHandler for row 2.5 (prepare_execution_context).
+ * Stage handler: row 2.5 — prepare_execution_context.
  *
- * Reads from state:
- *   - state.task / state.executionContext: idempotency guards. If callers
- *     pre-populate them via DispatchInput.context (or a future intake step),
- *     this handler is a structural acknowledgment.
- *   - state.request: the rawRequest passed to dispatch. Used as a fallback
- *     to surface the tasks list when callers haven't supplied state.task.
+ * Seeding: populates state.task, state.reviewPolicy, state.diffTracker.
+ * This handler is the canonical "state was set up correctly" acknowledgment
+ * for downstream handlers that read from these slots.
  *
- * Writes to state (only when slots are empty AND request is shaped for it):
- *   - state.task: the first TaskSpec from a delegate-style request payload.
- *     runTasks (in task-runner.ts) dispatches one StagePlan per TaskSpec,
- *     so state.task is the per-dispatch task. This handler surfaces task[0]
- *     as a fallback for downstream handlers that need a TaskSpec.
+ * §5.1 payload: null. Gate exists only for the per-stage telemetry slot.
  */
 export async function prepareExecutionContextHandler(state) {
-    // Fallback: if rawRequest carries a TaskSpec[] and state.task is empty,
-    // surface the first task so per-task handlers have something to read.
-    if (!state.task) {
-        const req = state.request;
-        const first = req?.tasks?.[0];
-        if (first)
-            state.task = first;
-    }
-    // #45 Step 7e: per-task reviewPolicy lives on TaskSpec, not on rawRequest's
-    // top-level. Override state.reviewPolicy from state.task when present so
-    // the per-row runConditions (gating spec/quality/diff chains) see the
-    // right value. This must run unconditionally — callers via
-    // runTaskViaDispatcher pre-populate state.task + state.executionContext but
-    // the dispatcher's initialState defaults state.reviewPolicy to 'full' since
-    // the per-task reviewPolicy isn't visible at top-level rawRequest.
-    const task = state.task;
-    if (task && task.reviewPolicy) {
-        state.reviewPolicy = task.reviewPolicy;
-    }
-    // Tool sweep #6: snapshot the worker's declared filePaths BEFORE the
-    // implementer runs so reviewer stages can produce a cumulative diff
-    // against the pre-task baseline. Skip read-only routes (audit / review
-    // / verify / debug / investigate / explore) — they don't write files
-    // by sandbox policy, so a tracker would just be empty noise.
-    if (!state.diffTracker && task && state.toolCategory !== 'read_only') {
-        const cwd = task.cwd;
-        const filePaths = Array.isArray(task.filePaths) ? task.filePaths : [];
-        if (cwd && filePaths.length > 0) {
-            const tracker = new DiffTracker(cwd);
-            try {
-                await tracker.snapshot(filePaths);
-                state.diffTracker = tracker;
-            }
-            catch {
-                // Snapshot failures (permission, unreadable) shouldn't block the
-                // task. Reviewer just sees an empty diff and falls back to the
-                // worker-output-only path — degraded but not broken.
+    const t0 = Date.now();
+    try {
+        // Fallback: if rawRequest carries a TaskSpec[] and state.task is empty,
+        // surface the first task so per-task handlers have something to read.
+        if (!state.task) {
+            const req = state.request;
+            const first = req?.tasks?.[0];
+            if (first)
+                state.task = first;
+        }
+        // #45 Step 7e: per-task reviewPolicy lives on TaskSpec, not on rawRequest's
+        // top-level. Override state.reviewPolicy from state.task when present so
+        // the per-row runConditions (gating spec/quality/diff chains) see the
+        // right value.
+        const task = state.task;
+        if (task?.reviewPolicy) {
+            state.reviewPolicy = task.reviewPolicy;
+        }
+        // Tool sweep #6: snapshot the worker's declared filePaths BEFORE the
+        // implementer runs so reviewer stages can produce a cumulative diff
+        // against the pre-task baseline. Skip read-only routes (audit / review
+        // / verify / debug / investigate / explore) — they don't write files
+        // by sandbox policy, so a tracker would just be empty noise.
+        if (!state.diffTracker && task && state.toolCategory !== 'read_only') {
+            const cwd = task.cwd;
+            const filePaths = Array.isArray(task.filePaths) ? task.filePaths : [];
+            if (cwd && filePaths.length > 0) {
+                const tracker = new DiffTracker(cwd);
+                try {
+                    await tracker.snapshot(filePaths);
+                    state.diffTracker = tracker;
+                }
+                catch {
+                    // Snapshot failures (permission, unreadable) shouldn't block the
+                    // task. Reviewer just sees an empty diff and falls back to the
+                    // worker-output-only path — degraded but not broken.
+                }
             }
         }
+        return {
+            outcome: 'advance',
+            payload: null,
+            telemetry: {
+                stageLabel: 'prepare',
+                durationMs: Date.now() - t0,
+                costUSD: 0,
+                turnsUsed: 0,
+                stopReason: 'normal',
+            },
+        };
+    }
+    catch (err) {
+        const msg = err instanceof Error ? err.message : String(err);
+        const comment = /brief schema|invalid brief/i.test(msg) ? `brief_invalid: ${msg}` :
+            /workspace|traversal|sandbox/i.test(msg) ? `workspace_violation: ${msg}` :
+                /context_block|missing/i.test(msg) ? `context_block_missing: ${msg}` :
+                    `prepare_failed: ${msg}`;
+        return {
+            outcome: 'halt',
+            comment,
+            payload: null,
+            telemetry: {
+                stageLabel: 'prepare',
+                durationMs: Date.now() - t0,
+                costUSD: 0,
+                turnsUsed: 0,
+                stopReason: 'transport_error',
+            },
+        };
     }
 }
 //# sourceMappingURL=prepare-execution-context-handler.js.map

package/dist/lifecycle/handlers/prepare-execution-context-handler.js.map

@@ -1 +1 @@
-{"version":3,"file":"prepare-execution-context-handler.js","sourceRoot":"","sources":["../../../src/lifecycle/handlers/prepare-execution-context-handler.ts"],"names":[],"mappings":"AAEA,OAAO,EAAE,WAAW,EAAE,MAAM,oBAAoB,CAAC;AAEjD;;;;;;;;;;;;;;;GAeG;AACH,MAAM,CAAC,KAAK,UAAU,8BAA8B,CAAC,KAAqB;IACxE,wEAAwE;IACxE,sEAAsE;IACtE,IAAI,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC;QAChB,MAAM,GAAG,GAAG,KAAK,CAAC,OAA6C,CAAC;QAChE,MAAM,KAAK,GAAG,GAAG,EAAE,KAAK,EAAE,CAAC,CAAC,CAAC,CAAC;QAC9B,IAAI,KAAK;YAAE,KAAK,CAAC,IAAI,GAAG,KAAK,CAAC;IAChC,CAAC;IAED,4EAA4E;IAC5E,yEAAyE;IACzE,sEAAsE;IACtE,2DAA2D;IAC3D,4EAA4E;IAC5E,4EAA4E;IAC5E,mEAAmE;IACnE,MAAM,IAAI,GAAG,KAAK,CAAC,IAA4B,CAAC;IAChD,IAAI,IAAI,IAAI,IAAI,CAAC,YAAY,EAAE,CAAC;QAC9B,KAAK,CAAC,YAAY,GAAG,IAAI,CAAC,YAAY,CAAC;IACzC,CAAC;IAED,qEAAqE;IACrE,oEAAoE;IACpE,uEAAuE;IACvE,qEAAqE;IACrE,6DAA6D;IAC7D,IAAI,CAAC,KAAK,CAAC,WAAW,IAAI,IAAI,IAAI,KAAK,CAAC,YAAY,KAAK,WAAW,EAAE,CAAC;QACrE,MAAM,GAAG,GAAG,IAAI,CAAC,GAAG,CAAC;QACrB,MAAM,SAAS,GAAG,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC;QACtE,IAAI,GAAG,IAAI,SAAS,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YAChC,MAAM,OAAO,GAAG,IAAI,WAAW,CAAC,GAAG,CAAC,CAAC;YACrC,IAAI,CAAC;gBACH,MAAM,OAAO,CAAC,QAAQ,CAAC,SAAS,CAAC,CAAC;gBAClC,KAAK,CAAC,WAAW,GAAG,OAAO,CAAC;YAC9B,CAAC;YAAC,MAAM,CAAC;gBACP,iEAAiE;gBACjE,+DAA+D;gBAC/D,qDAAqD;YACvD,CAAC;QACH,CAAC;IACH,CAAC;AACH,CAAC"}
+{"version":3,"file":"prepare-execution-context-handler.js","sourceRoot":"","sources":["../../../src/lifecycle/handlers/prepare-execution-context-handler.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,WAAW,EAAE,MAAM,oBAAoB,CAAC;AAEjD;;;;;;;;GAQG;AACH,MAAM,CAAC,KAAK,UAAU,8BAA8B,CAClD,KAAqB;IAErB,MAAM,EAAE,GAAG,IAAI,CAAC,GAAG,EAAE,CAAC;IAEtB,IAAI,CAAC;QACH,wEAAwE;QACxE,sEAAsE;QACtE,IAAI,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC;YAChB,MAAM,GAAG,GAAG,KAAK,CAAC,OAA6C,CAAC;YAChE,MAAM,KAAK,GAAG,GAAG,EAAE,KAAK,EAAE,CAAC,CAAC,CAAC,CAAC;YAC9B,IAAI,KAAK;gBAAE,KAAK,CAAC,IAAI,GAAG,KAAK,CAAC;QAChC,CAAC;QAED,4EAA4E;QAC5E,yEAAyE;QACzE,sEAAsE;QACtE,eAAe;QACf,MAAM,IAAI,GAAG,KAAK,CAAC,IAA4B,CAAC;QAChD,IAAI,IAAI,EAAE,YAAY,EAAE,CAAC;YACvB,KAAK,CAAC,YAAY,GAAG,IAAI,CAAC,YAAY,CAAC;QACzC,CAAC;QAED,qEAAqE;QACrE,oEAAoE;QACpE,uEAAuE;QACvE,qEAAqE;QACrE,6DAA6D;QAC7D,IAAI,CAAC,KAAK,CAAC,WAAW,IAAI,IAAI,IAAI,KAAK,CAAC,YAAY,KAAK,WAAW,EAAE,CAAC;YACrE,MAAM,GAAG,GAAG,IAAI,CAAC,GAAG,CAAC;YACrB,MAAM,SAAS,GAAG,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC;YACtE,IAAI,GAAG,IAAI,SAAS,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;gBAChC,MAAM,OAAO,GAAG,IAAI,WAAW,CAAC,GAAG,CAAC,CAAC;gBACrC,IAAI,CAAC;oBACH,MAAM,OAAO,CAAC,QAAQ,CAAC,SAAS,CAAC,CAAC;oBAClC,KAAK,CAAC,WAAW,GAAG,OAAO,CAAC;gBAC9B,CAAC;gBAAC,MAAM,CAAC;oBACP,iEAAiE;oBACjE,+DAA+D;oBAC/D,qDAAqD;gBACvD,CAAC;YACH,CAAC;QACH,CAAC;QAED,OAAO;YACL,OAAO,EAAE,SAAS;YAClB,OAAO,EAAE,IAAI;YACb,SAAS,EAAE;gBACT,UAAU,EAAE,SAAS;gBACrB,UAAU,EAAE,IAAI,CAAC,GAAG,EAAE,GAAG,EAAE;gBAC3B,OAAO,EAAE,CAAC;gBACV,SAAS,EAAE,CAAC;gBACZ,UAAU,EAAE,QAAQ;aACrB;SACF,CAAC;IACJ,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,MAAM,GAAG,GAAG,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC;QAC7D,MAAM,OAAO,GACX,6BAA6B,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,kBAAkB,GAAG,EAAE,CAAC,CAAC;YACnE,8BAA8B,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,wBAAwB,GAAG,EAAE,CAAC,CAAC;gBAC1E,wBAAwB,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,0BAA0B,GAAG,EAAE,CAAC,CAAC;oBACtE,mBAAmB,GAAG,EAAE,CAAC;QAE3B,OAAO;YACL,OAAO,EAAE,MAAM;YACf,OAAO;YACP,OAAO,EAAE,IAAI;YACb,SAAS,EAAE;gBACT,UAAU,EAAE,SAAS;gBACrB,UAAU,EAAE,IAAI,CAAC,GAAG,EAAE,GAAG,EAAE;gBAC3B,OAAO,EAAE,CAAC;gBACV,SAAS,EAAE,CAAC;gBACZ,UAAU,EAAE,iBAAiB;aAC9B;SACF,CAAC;IACJ,CAAC;AACH,CAAC"}

package/dist/lifecycle/handlers/register-context-block-handlers.d.ts

@@ -1,3 +1,4 @@
 import type { LifecycleState } from '../stage-plan-types.js';
-export declare function registerToBlockStoreHandler(state: LifecycleState): void;
+import type { StageGate, RegisterBlockPayload } from '../stage-io.js';
+export declare function registerToBlockStoreHandler(state: LifecycleState): Promise<StageGate<RegisterBlockPayload>>;
 //# sourceMappingURL=register-context-block-handlers.d.ts.map

package/dist/lifecycle/handlers/register-context-block-handlers.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"register-context-block-handlers.d.ts","sourceRoot":"","sources":["../../../src/lifecycle/handlers/register-context-block-handlers.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,wBAAwB,CAAC;AAG7D,wBAAgB,2BAA2B,CAAC,KAAK,EAAE,cAAc,GAAG,IAAI,CAevE"}
+{"version":3,"file":"register-context-block-handlers.d.ts","sourceRoot":"","sources":["../../../src/lifecycle/handlers/register-context-block-handlers.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,wBAAwB,CAAC;AAC7D,OAAO,KAAK,EAAE,SAAS,EAAE,oBAAoB,EAAE,MAAM,gBAAgB,CAAC;AAItE,wBAAsB,2BAA2B,CAAC,KAAK,EAAE,cAAc,GAAG,OAAO,CAAC,SAAS,CAAC,oBAAoB,CAAC,CAAC,CAqCjH"}

package/dist/lifecycle/handlers/register-context-block-handlers.js

@@ -1,18 +1,39 @@
-export function registerToBlockStoreHandler(state) {
-    if (state.terminal)
-        return;
-    const pc = state.projectContext;
+const MAX_BYTES = 50 * 1024 * 1024;
+export async function registerToBlockStoreHandler(state) {
+    const t0 = Date.now();
     const req = state.request;
-    if (!pc || !req?.content) {
-        state.terminal = true;
-        state.errorCode = 'invalid_request';
-        return;
+    const bytes = Buffer.byteLength(req?.content ?? '', 'utf-8');
+    if (bytes > MAX_BYTES) {
+        return {
+            outcome: 'halt',
+            comment: `payload_too_large: ${bytes} bytes`,
+            payload: { blockId: '', bytes },
+            telemetry: { stageLabel: 'register-block', durationMs: Date.now() - t0, costUSD: 0, turnsUsed: 0, stopReason: 'normal' },
+        };
+    }
+    try {
+        // Existing API: pc.contextBlocks.register(content) → RegisteredBlock { id, ... }
+        // See packages/core/src/lifecycle/handlers/register-context-block-handlers.ts:13
+        // and packages/core/src/stores/context-block-tool.ts:23 for the interface.
+        const pc = state.projectContext;
+        const registered = pc.contextBlocks.register(req?.content ?? '');
+        // v4 back-compat: compose_response reads state.blockRegistration to detect
+        // the register-context-block route. v5 emits the same data via the gate's
+        // payload; we keep this state slot populated for the existing compose path.
+        state.blockRegistration = { id: registered.id, size: bytes, ttlMs: pc.contextBlocks.ttlMs };
+        return {
+            outcome: 'advance',
+            payload: { blockId: registered.id, bytes },
+            telemetry: { stageLabel: 'register-block', durationMs: Date.now() - t0, costUSD: 0, turnsUsed: 0, stopReason: 'normal' },
+        };
+    }
+    catch (err) {
+        return {
+            outcome: 'halt',
+            comment: `store_write_failed: ${err instanceof Error ? err.message : String(err)}`,
+            payload: { blockId: '', bytes },
+            telemetry: { stageLabel: 'register-block', durationMs: Date.now() - t0, costUSD: 0, turnsUsed: 0, stopReason: 'transport_error' },
+        };
     }
-    const registered = pc.contextBlocks.register(req.content);
-    state.blockRegistration = {
-        id: registered.id,
-        size: Buffer.byteLength(req.content, 'utf8'),
-        ttlMs: pc.contextBlocks.ttlMs,
-    };
 }
 //# sourceMappingURL=register-context-block-handlers.js.map

package/dist/lifecycle/handlers/register-context-block-handlers.js.map

@@ -1 +1 @@
-{"version":3,"file":"register-context-block-handlers.js","sourceRoot":"","sources":["../../../src/lifecycle/handlers/register-context-block-handlers.ts"],"names":[],"mappings":"AAGA,MAAM,UAAU,2BAA2B,CAAC,KAAqB;IAC/D,IAAI,KAAK,CAAC,QAAQ;QAAE,OAAO;IAC3B,MAAM,EAAE,GAAG,KAAK,CAAC,cAA4C,CAAC;IAC9D,MAAM,GAAG,GAAG,KAAK,CAAC,OAA0C,CAAC;IAC7D,IAAI,CAAC,EAAE,IAAI,CAAC,GAAG,EAAE,OAAO,EAAE,CAAC;QACzB,KAAK,CAAC,QAAQ,GAAG,IAAI,CAAC;QACtB,KAAK,CAAC,SAAS,GAAG,iBAAiB,CAAC;QACpC,OAAO;IACT,CAAC;IACD,MAAM,UAAU,GAAG,EAAE,CAAC,aAAa,CAAC,QAAQ,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC;IAC1D,KAAK,CAAC,iBAAiB,GAAG;QACxB,EAAE,EAAE,UAAU,CAAC,EAAE;QACjB,IAAI,EAAE,MAAM,CAAC,UAAU,CAAC,GAAG,CAAC,OAAO,EAAE,MAAM,CAAC;QAC5C,KAAK,EAAE,EAAE,CAAC,aAAa,CAAC,KAAK;KAC9B,CAAC;AACJ,CAAC"}
+{"version":3,"file":"register-context-block-handlers.js","sourceRoot":"","sources":["../../../src/lifecycle/handlers/register-context-block-handlers.ts"],"names":[],"mappings":"AAGA,MAAM,SAAS,GAAG,EAAE,GAAG,IAAI,GAAG,IAAI,CAAC;AAEnC,MAAM,CAAC,KAAK,UAAU,2BAA2B,CAAC,KAAqB;IACrE,MAAM,EAAE,GAAG,IAAI,CAAC,GAAG,EAAE,CAAC;IACtB,MAAM,GAAG,GAAG,KAAK,CAAC,OAA0C,CAAC;IAC7D,MAAM,KAAK,GAAG,MAAM,CAAC,UAAU,CAAC,GAAG,EAAE,OAAO,IAAI,EAAE,EAAE,OAAO,CAAC,CAAC;IAE7D,IAAI,KAAK,GAAG,SAAS,EAAE,CAAC;QACtB,OAAO;YACL,OAAO,EAAE,MAAM;YACf,OAAO,EAAE,sBAAsB,KAAK,QAAQ;YAC5C,OAAO,EAAE,EAAE,OAAO,EAAE,EAAE,EAAE,KAAK,EAAE;YAC/B,SAAS,EAAE,EAAE,UAAU,EAAE,gBAAgB,EAAE,UAAU,EAAE,IAAI,CAAC,GAAG,EAAE,GAAG,EAAE,EAAE,OAAO,EAAE,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,UAAU,EAAE,QAAQ,EAAE;SACzH,CAAC;IACJ,CAAC;IAED,IAAI,CAAC;QACH,iFAAiF;QACjF,iFAAiF;QACjF,2EAA2E;QAC3E,MAAM,EAAE,GAAG,KAAK,CAAC,cAAqB,CAAC;QACvC,MAAM,UAAU,GAAG,EAAE,CAAC,aAAa,CAAC,QAAQ,CAAC,GAAG,EAAE,OAAO,IAAI,EAAE,CAAC,CAAC;QACjE,2EAA2E;QAC3E,0EAA0E;QAC1E,4EAA4E;QAC3E,KAAa,CAAC,iBAAiB,GAAG,EAAE,EAAE,EAAE,UAAU,CAAC,EAAE,EAAE,IAAI,EAAE,KAAK,EAAE,KAAK,EAAE,EAAE,CAAC,aAAa,CAAC,KAAK,EAAE,CAAC;QACrG,OAAO;YACL,OAAO,EAAE,SAAS;YAClB,OAAO,EAAE,EAAE,OAAO,EAAE,UAAU,CAAC,EAAE,EAAE,KAAK,EAAE;YAC1C,SAAS,EAAE,EAAE,UAAU,EAAE,gBAAgB,EAAE,UAAU,EAAE,IAAI,CAAC,GAAG,EAAE,GAAG,EAAE,EAAE,OAAO,EAAE,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,UAAU,EAAE,QAAQ,EAAE;SACzH,CAAC;IACJ,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,OAAO;YACL,OAAO,EAAE,MAAM;YACf,OAAO,EAAE,uBAAuB,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC,EAAE;YAClF,OAAO,EAAE,EAAE,OAAO,EAAE,EAAE,EAAE,KAAK,EAAE;YAC/B,SAAS,EAAE,EAAE,UAAU,EAAE,gBAAgB,EAAE,UAAU,EAAE,IAAI,CAAC,GAAG,EAAE,GAAG,EAAE,EAAE,OAAO,EAAE,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,UAAU,EAAE,iBAAiB,EAAE;SAClI,CAAC;IACJ,CAAC;AACH,CAAC"}

package/dist/lifecycle/handlers/review-handler.d.ts

@@ -1,3 +1,4 @@
 import type { LifecycleState } from '../stage-plan-types.js';
-export declare function reviewHandler(state: LifecycleState): Promise<void>;
+import type { StageGate, ReviewPayload } from '../stage-io.js';
+export declare function reviewHandler(state: LifecycleState): Promise<StageGate<ReviewPayload>>;
 //# sourceMappingURL=review-handler.d.ts.map

package/dist/lifecycle/handlers/review-handler.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"review-handler.d.ts","sourceRoot":"","sources":["../../../src/lifecycle/handlers/review-handler.ts"],"names":[],"mappings":"AAQA,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,wBAAwB,CAAC;AA4C7D,wBAAsB,aAAa,CAAC,KAAK,EAAE,cAAc,GAAG,OAAO,CAAC,IAAI,CAAC,CAsIxE"}
+{"version":3,"file":"review-handler.d.ts","sourceRoot":"","sources":["../../../src/lifecycle/handlers/review-handler.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,wBAAwB,CAAC;AAC7D,OAAO,KAAK,EAAE,SAAS,EAAE,aAAa,EAAW,MAAM,gBAAgB,CAAC;AAQxE,wBAAsB,aAAa,CAAC,KAAK,EAAE,cAAc,GAAG,OAAO,CAAC,SAAS,CAAC,aAAa,CAAC,CAAC,CAiJ5F"}

package/dist/lifecycle/handlers/review-handler.js

@@ -1,169 +1,167 @@
-// v4.4.x — Review stage.
-//
-// One complex session, two sequential turns: spec review, then quality
-// review. Same session = same cached prefix on the 2nd turn. Combined
-// verdict is `approved` only if BOTH reviewers approve; otherwise
-// `changes_required`. Combined `reviewConcerns` is the concat of both
-// reviewers' concerns.
-import { specLintTemplate } from '../../review/templates/spec-review.js';
-import { qualityLintTemplate } from '../../review/templates/quality-review.js';
+import { specReviewPrompt } from '../../review/templates/spec-review.js';
+import { qualityReviewPrompt } from '../../review/templates/quality-review.js';
 import { parseReviewReport } from '../../review/parse-review-report.js';
+import { runReviewerTurn, invertedReviewerTier } from '../../review/run-reviewer.js';
 import { mergeStageStats } from '../merge-stage-stats.js';
-import { HUMAN_LABEL } from '../stage-labels.js';
-import { buildWarmFollowupMessage } from '../warm-followup.js';
-async function runOneReviewer(session, task, source, diff, workerOutput, isWarmFollowup) {
-    const template = source === 'spec' ? specLintTemplate : qualityLintTemplate;
-    const promptCtx = {
-        brief: task.prompt ?? '',
-        workerOutput,
-        diff,
-        planContext: task.planContext,
+export async function reviewHandler(state) {
+    const t0 = Date.now();
+    const policy = state.reviewPolicy; // 'full' | 'quality_only' | 'diff_only' | 'none'
+    // v5 review-policy mapping (per spec §14 assumption 2 — adapted to v4 enum):
+    //   'full'         → run BOTH spec + quality
+    //   'quality_only' → run ONLY quality
+    //   'diff_only'    → run ONLY spec (spec reviewer is the closest analog)
+    //   'none'         → skip (handled upstream)
+    const runSpec = policy === 'full' || policy === 'diff_only';
+    const runQuality = policy === 'full' || policy === 'quality_only';
+    const impl = (state.gates?.['implement']?.payload ?? {});
+    const briefObj = (state.task ?? {});
+    const briefStr = briefObj.brief ?? '';
+    const context = {
+        brief: briefStr,
+        workerSummary: (impl?.summary ?? ""),
+        filesChanged: impl.filesChanged ?? [],
     };
-    // Warm follow-up: the same reviewer session already loaded brief +
-    // diff + planContext on turn 1. Send only the new instruction via
-    // the standard preamble. systemPrompt is intentionally not
-    // re-prepended — it lives in the resumed session's history.
-    // Cold open: full system prompt + brief + diff + planContext.
-    const fullPrompt = isWarmFollowup && template.buildWarmFollowup
-        ? buildWarmFollowupMessage(template.buildWarmFollowup(promptCtx))
-        : template.systemPrompt + '\n\n' + template.buildUserPrompt(promptCtx);
-    try {
-        const turn = await session.send(fullPrompt, { stageLabel: HUMAN_LABEL.review });
-        return { turn };
-    }
-    catch (err) {
-        return { transportError: err instanceof Error ? err.message : String(err) };
+    const subResults = [];
+    // Cross-tier inversion (per design): reviewer runs on the opposite tier of
+    // the implementer. Read implementer tier from the executionContext; fall
+    // back to inferring from the implementing stage's gate payload, then
+    // 'standard' if neither is known (defensive — matches legacy default).
+    const implementerTier = state.executionContext?.assignedTier
+        ?? (state.gates?.['implement']?.payload?.agentTier)
+        ?? 'standard';
+    const resolvedReviewerTier = invertedReviewerTier(implementerTier);
+    if (runSpec) {
+        const r = await runReviewerWithRetries(state, specReviewPrompt(context), 'spec', implementerTier);
+        subResults.push({
+            name: 'spec', result: r.parsed, cost: r.costUSD, ms: r.ms,
+            model: r.model,
+            inputTokens: r.inputTokens, outputTokens: r.outputTokens,
+            cachedReadTokens: r.cachedReadTokens, cachedNonReadTokens: r.cachedNonReadTokens,
+            turnsUsed: r.turnsUsed,
+        });
     }
-}
-export async function reviewHandler(state) {
-    if (state.terminal)
-        return;
-    if (state.reviewVerdict !== undefined)
-        return;
-    const ctx = state.executionContext;
-    const task = state.task;
-    const last = state.lastRunResult;
-    if (!ctx || !task || !last)
-        return;
-    if (state.reviewPolicy === 'none') {
-        state.reviewVerdict = 'approved';
-        state.reviewFindings = [];
-        return;
+    if (runQuality) {
+        const r = await runReviewerWithRetries(state, qualityReviewPrompt(context), 'quality', implementerTier);
+        subResults.push({
+            name: 'quality', result: r.parsed, cost: r.costUSD, ms: r.ms,
+            model: r.model,
+            inputTokens: r.inputTokens, outputTokens: r.outputTokens,
+            cachedReadTokens: r.cachedReadTokens, cachedNonReadTokens: r.cachedNonReadTokens,
+            turnsUsed: r.turnsUsed,
+        });
     }
-    let cumulativeDiff = '';
-    if (state.diffTracker) {
-        try {
-            cumulativeDiff = await state.diffTracker.cumulativeDiff();
+    const succeeded = subResults.filter(s => s.result.verdict).map(s => s.name);
+    const errored = subResults.filter(s => !s.result.verdict).map(s => ({
+        reviewer: s.name, error: s.result.parseError ?? 'unknown',
+    }));
+    const findings = [];
+    let nextId = 1;
+    for (const s of subResults) {
+        for (const f of s.result.findings ?? []) {
+            findings.push({ ...f, id: `F${nextId++}`, source: 'reviewer' });
         }
-        catch { /* tolerated */ }
-    }
-    const workerOutput = last.output ?? '';
-    // v4.4.x: spec and quality run sequentially on the SAME complex
-    // session so the second call benefits from the cached prefix.
-    const reviewerTier = ctx.assignedTier === 'standard' ? 'complex' : 'standard';
-    if (!ctx.providers[reviewerTier]) {
-        state.reviewVerdict = 'changes_required';
-        state.reviewError = `no provider available for tier ${reviewerTier}`;
-        state.reviewFindings = [];
-        return;
     }
-    // Which sub-reviews to run, per reviewPolicy.
-    const runSpec = state.reviewPolicy === 'full';
-    const runQuality = state.reviewPolicy === 'full'
-        || state.reviewPolicy === 'quality_only'
-        || state.reviewPolicy === 'diff_only';
-    const sources = [];
-    if (runSpec)
-        sources.push('spec');
-    if (runQuality)
-        sources.push('quality');
-    if (sources.length === 0) {
-        state.reviewVerdict = 'approved';
-        state.reviewFindings = [];
-        return;
+    // Combined verdict: approved iff EVERY configured reviewer returned approved.
+    let verdict;
+    if (succeeded.length === 0) {
+        verdict = 'changes_required';
+        findings.push({
+            id: `F${nextId++}`, severity: 'high', category: 'reviewer-availability',
+            claim: 'All configured reviewers failed to parse their output; defaulting to changes_required.',
+            evidence: errored.map(e => `${e.reviewer}: ${e.error}`).join(' | '),
+            source: 'reviewer',
+        });
     }
-    const findings = [];
-    const errors = [];
-    let anyChangesRequired = false;
-    let anySuccess = false;
-    // Sequential — second turn hits the cached prefix on the same session.
-    // The warm-follow-up form is valid ONLY when iteration > 0 AND the
-    // session reference is the same as iteration 0. Today ctx.getSession
-    // is idempotent on tier so both iterations see the same session; the
-    // identity guard exists so a future change that rotates the reviewer
-    // session mid-stage (escalation rotation, retry-after-failure) falls
-    // back to cold-open automatically rather than sending a warm follow-up
-    // into a fresh thread that lacks the prior history.
-    const settled = [];
-    let firstSession = null;
-    for (let iteration = 0; iteration < sources.length; iteration++) {
-        const source = sources[iteration];
-        const currentSession = ctx.getSession(reviewerTier);
-        if (iteration === 0)
-            firstSession = currentSession;
-        const isWarmFollowup = iteration > 0 && currentSession === firstSession;
-        const outcome = await runOneReviewer(currentSession, task, source, cumulativeDiff, workerOutput, isWarmFollowup);
-        settled.push({ source, outcome });
+    else if (subResults.some(s => s.result.verdict === 'changes_required')) {
+        verdict = 'changes_required';
     }
-    let combinedInput = 0, combinedOutput = 0, combinedCached = 0, combinedNonRead = 0;
-    let combinedTurns = 0;
-    let combinedCost = null;
-    let combinedDuration = 0;
-    for (const { source, outcome } of settled) {
-        if ('transportError' in outcome) {
-            if (source === 'spec')
-                state.specReviewError = outcome.transportError;
-            else
-                state.qualityReviewError = outcome.transportError;
-            errors.push(`${source}: ${outcome.transportError}`);
-            process.stderr.write(`[review-handler] ${source} transportError: ${outcome.transportError}\n`);
-            continue;
+    else if (errored.length > 0) {
+        // Mixed: some approved, some errored.
+        verdict = 'changes_required';
+        for (const e of errored) {
+            findings.push({
+                id: `F${nextId++}`, severity: 'high', category: 'reviewer-availability',
+                claim: `Reviewer ${e.reviewer} failed to parse; treating as changes_required.`,
+                evidence: e.error.length >= 20 ? e.error : `parse error: ${e.error}`,
+                source: 'reviewer',
+            });
         }
-        anySuccess = true;
-        const parsed = parseReviewReport(outcome.turn.output ?? '');
-        if (source === 'spec') {
-            state.specReviewerNotes = outcome.turn.output;
-            state.specReviewVerdict = parsed.verdict;
-        }
-        else {
-            state.qualityReviewerNotes = outcome.turn.output;
-            state.qualityReviewVerdict = parsed.verdict;
-        }
-        if (parsed.verdict === 'changes_required')
-            anyChangesRequired = true;
-        for (const dev of parsed.deviations)
-            findings.push({ source, text: dev });
-        combinedInput += outcome.turn.usage?.inputTokens ?? 0;
-        combinedOutput += outcome.turn.usage?.outputTokens ?? 0;
-        combinedCached += outcome.turn.usage?.cachedReadTokens ?? 0;
-        combinedNonRead += outcome.turn.usage?.cachedNonReadTokens ?? 0;
-        combinedTurns += outcome.turn.turns ?? 1;
-        combinedDuration += outcome.turn.durationMs ?? 0;
-        const c = outcome.turn.costUSD;
-        if (c !== null && c !== undefined)
-            combinedCost = (combinedCost ?? 0) + c;
     }
-    state.reviewFindings = findings;
-    state.reviewConcerns = findings.map((f) => f.text);
-    if (!anySuccess) {
-        state.reviewVerdict = 'changes_required';
-        state.reviewError = errors.join(' | ');
-        return;
+    else {
+        verdict = 'approved';
     }
-    state.reviewVerdict = anyChangesRequired ? 'changes_required' : 'approved';
-    mergeStageStats(state, 'review', {
-        inputTokens: combinedInput,
-        outputTokens: combinedOutput,
-        cachedReadTokens: combinedCached,
-        cachedNonReadTokens: combinedNonRead,
-        turnCount: combinedTurns,
-        toolCallCount: 0,
-        costUSD: combinedCost,
-        durationMs: combinedDuration || null,
-    }, {
-        tier: reviewerTier,
-        model: ctx.providers[reviewerTier]?.config?.model ?? null,
-        verdict: state.reviewVerdict,
+    const totalCost = subResults.reduce((s, x) => s + (x.cost ?? 0), 0);
+    const totalMs = subResults.reduce((s, x) => s + x.ms, 0);
+    const totalInput = subResults.reduce((s, x) => s + x.inputTokens, 0);
+    const totalOutput = subResults.reduce((s, x) => s + x.outputTokens, 0);
+    const totalCachedRead = subResults.reduce((s, x) => s + x.cachedReadTokens, 0);
+    const totalCachedNonRead = subResults.reduce((s, x) => s + x.cachedNonReadTokens, 0);
+    const totalTurns = subResults.reduce((s, x) => s + x.turnsUsed, 0);
+    // Both reviewers run on the standard tier through the same Session — same
+    // canonical model in practice. Pick the first non-null.
+    const reviewerModel = subResults.find(s => s.model !== null)?.model ?? null;
+    // Write reviewer stage stats so event-builder.buildReviewStage(rr.stageStats?.review)
+    // produces a real stage entry instead of returning null. Without this, the
+    // review stage was silently invisible in telemetry for reviewPolicy=full runs.
+    if (subResults.length > 0) {
+        mergeStageStats(state, 'review', {
+            inputTokens: totalInput,
+            outputTokens: totalOutput,
+            cachedReadTokens: totalCachedRead,
+            cachedNonReadTokens: totalCachedNonRead,
+            turnCount: totalTurns,
+            toolCallCount: 0,
+            costUSD: totalCost,
+            durationMs: Math.max(totalMs, Date.now() - t0),
+            filesReadCount: 0,
+            filesWrittenCount: 0,
+        }, { tier: resolvedReviewerTier, model: reviewerModel });
+    }
+    return {
+        outcome: 'advance',
+        payload: { verdict, findings, reviewersSucceeded: succeeded, reviewersErrored: errored },
+        telemetry: {
+            stageLabel: 'review',
+            durationMs: Math.max(totalMs, Date.now() - t0),
+            costUSD: totalCost > 0 ? totalCost : null,
+            turnsUsed: subResults.length,
+            stopReason: 'normal',
+        },
+    };
+}
+async function runReviewerWithRetries(state, prompt, name, implementerTier) {
+    const turn = await runReviewerTurn({
+        prompt,
+        ctx: state.executionContext,
+        reviewer: name,
+        implementerTier,
     });
+    if (turn.kind === 'transport_error') {
+        // Final failure surfaces as a parse-failure shape so the aggregator treats
+        // this reviewer as errored — same downstream effect as an unparseable response.
+        return {
+            parsed: { verdict: undefined, findings: [], parseError: turn.message },
+            costUSD: null,
+            ms: turn.ms,
+            model: null,
+            inputTokens: 0,
+            outputTokens: 0,
+            cachedReadTokens: 0,
+            cachedNonReadTokens: 0,
+            turnsUsed: 0,
+        };
+    }
+    const parsed = parseReviewReport(turn.text);
+    return {
+        parsed,
+        costUSD: turn.costUSD,
+        ms: turn.ms,
+        model: turn.model,
+        inputTokens: turn.inputTokens,
+        outputTokens: turn.outputTokens,
+        cachedReadTokens: turn.cachedReadTokens,
+        cachedNonReadTokens: turn.cachedNonReadTokens,
+        turnsUsed: turn.turnsUsed,
+    };
 }
 //# sourceMappingURL=review-handler.js.map