@zhixuan92/multi-model-agent-core 4.0.2 → 4.0.4

package/dist/review/reviewer-engine.js

@@ -20,6 +20,11 @@ export class ReviewerEngine {
             systemPrompt, userMessage: userPrompt, toolDefinitions: [],
             maxTurns: 5, cwd: input.cwd,
             abortSignal: input.abortSignal, deadlineMs: input.deadlineMs,
+            ...(input.bus && { bus: input.bus }),
+            ...(input.batchId !== undefined && { batchId: input.batchId }),
+            ...(input.taskIndex !== undefined && { taskIndex: input.taskIndex }),
+            ...(input.tier !== undefined && { tier: input.tier }),
+            ...(input.stageLabel !== undefined && { stageLabel: input.stageLabel }),
         });
         const parsed = this.parser.parse(result.finalAssistantText ?? '');
         return { ...parsed, cost: extractCost(result) };
@@ -30,6 +35,11 @@ export class ReviewerEngine {
             systemPrompt, userMessage: userPrompt, toolDefinitions: [],
             maxTurns: 5, cwd: input.cwd,
             abortSignal: input.abortSignal, deadlineMs: input.deadlineMs,
+            ...(input.bus && { bus: input.bus }),
+            ...(input.batchId !== undefined && { batchId: input.batchId }),
+            ...(input.taskIndex !== undefined && { taskIndex: input.taskIndex }),
+            ...(input.tier !== undefined && { tier: input.tier }),
+            ...(input.stageLabel !== undefined && { stageLabel: input.stageLabel }),
         });
         const parsed = this.parser.parse(result.finalAssistantText ?? '');
         return { ...parsed, cost: extractCost(result) };
@@ -40,6 +50,11 @@ export class ReviewerEngine {
             systemPrompt, userMessage: userPrompt, toolDefinitions: [],
             maxTurns: 5, cwd: input.cwd,
             abortSignal: input.abortSignal, deadlineMs: input.deadlineMs,
+            ...(input.bus && { bus: input.bus }),
+            ...(input.batchId !== undefined && { batchId: input.batchId }),
+            ...(input.taskIndex !== undefined && { taskIndex: input.taskIndex }),
+            ...(input.tier !== undefined && { tier: input.tier }),
+            ...(input.stageLabel !== undefined && { stageLabel: input.stageLabel }),
         });
         const parsed = this.parser.parseDiff(result.finalAssistantText ?? '');
         return { ...parsed, cost: extractCost(result) };
@@ -51,7 +66,9 @@ function extractCost(r) {
         outputTokens: r.usage?.outputTokens ?? 0,
         turnCount: r.turns ?? 0,
         toolCallCount: r.toolCalls?.length ?? 0,
-        costUSD: r.cost?.costUSD ?? r.usage?.costUSD ?? null,
+        // shell.run now exposes top-level costUSD; legacy paths used cost.costUSD or usage.costUSD.
+        costUSD: r.costUSD ?? r.cost?.costUSD ?? r.usage?.costUSD ?? null,
+        durationMs: r.durationMs ?? null,
     };
 }
 export { ReviewerParseError };

package/dist/review/reviewer-engine.js.map

@@ -1 +1 @@
-{"version":3,"file":"reviewer-engine.js","sourceRoot":"","sources":["../../src/review/reviewer-engine.ts"],"names":[],"mappings":"AAEA,OAAO,EAAE,oBAAoB,EAA0D,kBAAkB,EAAE,MAAM,6BAA6B,CAAC;AAO/I,OAAO,EAAE,YAAY,EAAE,MAAM,4BAA4B,CAAC;AAC1D,OAAO,EAAE,iBAAiB,EAAE,MAAM,wCAAwC,CAAC;AAC3E,OAAO,EAAE,YAAY,EAAE,MAAM,4BAA4B,CAAC;AAC1D,OAAO,EAAE,oBAAoB,EAAE,MAAM,qCAAqC,CAAC;AAC3E,OAAO,EAAE,qBAAqB,EAAE,MAAM,sCAAsC,CAAC;AAC7E,OAAO,EAAE,qBAAqB,EAAE,MAAM,sCAAsC,CAAC;AAC7E,OAAO,EAAE,oBAAoB,EAAE,MAAM,qCAAqC,CAAC;AAC3E,OAAO,EAAE,0BAA0B,EAAE,MAAM,2CAA2C,CAAC;AACvF,OAAO,EAAE,qBAAqB,EAAE,MAAM,8BAA8B,CAAC;AAyBrE,MAAM,OAAO,cAAc;IAEL;IADZ,MAAM,GAAG,IAAI,oBAAoB,EAAE,CAAC;IAC5C,YAAoB,OAA8B;QAA9B,YAAO,GAAP,OAAO,CAAuB;IAAG,CAAC;IAEtD,KAAK,CAAC,OAAO,CAAC,KAAkB,EAAE,KAAoB;QACpD,MAAM,EAAE,YAAY,EAAE,UAAU,EAAE,GAAG,IAAI,CAAC,OAAO,CAAC,SAAS,CAAC,EAAE,GAAG,KAAK,EAAE,CAAC,CAAC;QAC1E,MAAM,MAAM,GAAG,MAAM,KAAK,CAAC,GAAG,CAAC;YAC7B,YAAY,EAAE,WAAW,EAAE,UAAU,EAAE,eAAe,EAAE,EAAE;YAC1D,QAAQ,EAAE,CAAC,EAAE,GAAG,EAAE,KAAK,CAAC,GAAG;YAC3B,WAAW,EAAE,KAAK,CAAC,WAAW,EAAE,UAAU,EAAE,KAAK,CAAC,UAAU;SAC7D,CAAC,CAAC;QACH,MAAM,MAAM,GAAG,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,kBAAkB,IAAI,EAAE,CAAC,CAAC;QAClE,OAAO,EAAE,GAAG,MAAM,EAAE,IAAI,EAAE,WAAW,CAAC,MAAM,CAAC,EAAE,CAAC;IAClD,CAAC;IAED,KAAK,CAAC,YAAY,CAAC,KAAkB,EAAE,KAAoB;QACzD,MAAM,EAAE,YAAY,EAAE,UAAU,EAAE,GAAG,IAAI,CAAC,OAAO,CAAC,cAAc,CAAC,EAAE,GAAG,KAAK,EAAE,CAAC,CAAC;QAC/E,MAAM,MAAM,GAAG,MAAM,KAAK,CAAC,GAAG,CAAC;YAC7B,YAAY,EAAE,WAAW,EAAE,UAAU,EAAE,eAAe,EAAE,EAAE;YAC1D,QAAQ,EAAE,CAAC,EAAE,GAAG,EAAE,KAAK,CAAC,GAAG;YAC3B,WAAW,EAAE,KAAK,CAAC,WAAW,EAAE,UAAU,EAAE,KAAK,CAAC,UAAU;SAC7D,CAAC,CAAC;QACH,MAAM,MAAM,GAAG,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,kBAAkB,IAAI,EAAE,CAAC,CAAC;QAClE,OAAO,EAAE,GAAG,MAAM,EAAE,IAAI,EAAE,WAAW,CAAC,MAAM,CAAC,EAAE,CAAC;IAClD,CAAC;IAED,KAAK,CAAC,OAAO,CAAC,KAAkB,EAAE,KAAoB;QACpD,MAAM,EAAE,YAAY,EAAE,UAAU,EAAE,GAAG,IAAI,CAAC,OAAO,CAAC,SAAS,CAAC,EAAE,GAAG,KAAK,EAAE,CAAC,CAAC;QAC1E,MAAM,MAAM,GAAG,MAAM,KAAK,CAAC,GAAG,CAAC;YAC7B,YAAY,EAAE,WAAW,EAAE,UAAU,EAAE,eAAe,EAAE,EAAE;YAC1D,QAAQ,EAAE,CAAC,EAAE,GAAG,EAAE,KAAK,CAAC,GAAG;YAC3B,WAAW,EAAE,KAAK,CAAC,WAAW,EAAE,UAAU,EAAE,KAAK,CAAC,UAAU;SAC7D,CAAC,CAAC;QACH,MAAM,MAAM,GAAG,IAAI,CAAC,MAAM,CAAC,SAAS,CAAC,MAAM,CAAC,kBAAkB,IAAI,EAAE,CAAC,CAAC;QACtE,OAAO,EAAE,GAAG,MAAM,EAAE,IAAI,EAAE,WAAW,CAAC,MAAM,CAAC,EAAE,CAAC;IAClD,CAAC;CACF;AAED,SAAS,WAAW,CAAC,CAAkK;IACrL,OAAO;QACL,WAAW,EAAE,CAAC,CAAC,KAAK,EAAE,WAAW,IAAI,CAAC;QACtC,YAAY,EAAE,CAAC,CAAC,KAAK,EAAE,YAAY,IAAI,CAAC;QACxC,SAAS,EAAE,CAAC,CAAC,KAAK,IAAI,CAAC;QACvB,aAAa,EAAE,CAAC,CAAC,SAAS,EAAE,MAAM,IAAI,CAAC;QACvC,OAAO,EAAE,CAAC,CAAC,IAAI,EAAE,OAAO,IAAI,CAAC,CAAC,KAAK,EAAE,OAAO,IAAI,IAAI;KACrD,CAAC;AACJ,CAAC;AAED,OAAO,EAAE,kBAAkB,EAAE,CAAC"}
+{"version":3,"file":"reviewer-engine.js","sourceRoot":"","sources":["../../src/review/reviewer-engine.ts"],"names":[],"mappings":"AAEA,OAAO,EAAE,oBAAoB,EAA0D,kBAAkB,EAAE,MAAM,6BAA6B,CAAC;AAO/I,OAAO,EAAE,YAAY,EAAE,MAAM,4BAA4B,CAAC;AAC1D,OAAO,EAAE,iBAAiB,EAAE,MAAM,wCAAwC,CAAC;AAC3E,OAAO,EAAE,YAAY,EAAE,MAAM,4BAA4B,CAAC;AAC1D,OAAO,EAAE,oBAAoB,EAAE,MAAM,qCAAqC,CAAC;AAC3E,OAAO,EAAE,qBAAqB,EAAE,MAAM,sCAAsC,CAAC;AAC7E,OAAO,EAAE,qBAAqB,EAAE,MAAM,sCAAsC,CAAC;AAC7E,OAAO,EAAE,oBAAoB,EAAE,MAAM,qCAAqC,CAAC;AAC3E,OAAO,EAAE,0BAA0B,EAAE,MAAM,2CAA2C,CAAC;AACvF,OAAO,EAAE,qBAAqB,EAAE,MAAM,8BAA8B,CAAC;AAgDrE,MAAM,OAAO,cAAc;IAEL;IADZ,MAAM,GAAG,IAAI,oBAAoB,EAAE,CAAC;IAC5C,YAAoB,OAA8B;QAA9B,YAAO,GAAP,OAAO,CAAuB;IAAG,CAAC;IAEtD,KAAK,CAAC,OAAO,CAAC,KAAkB,EAAE,KAAoB;QACpD,MAAM,EAAE,YAAY,EAAE,UAAU,EAAE,GAAG,IAAI,CAAC,OAAO,CAAC,SAAS,CAAC,EAAE,GAAG,KAAK,EAAE,CAAC,CAAC;QAC1E,MAAM,MAAM,GAAG,MAAM,KAAK,CAAC,GAAG,CAAC;YAC7B,YAAY,EAAE,WAAW,EAAE,UAAU,EAAE,eAAe,EAAE,EAAE;YAC1D,QAAQ,EAAE,CAAC,EAAE,GAAG,EAAE,KAAK,CAAC,GAAG;YAC3B,WAAW,EAAE,KAAK,CAAC,WAAW,EAAE,UAAU,EAAE,KAAK,CAAC,UAAU;YAC5D,GAAG,CAAC,KAAK,CAAC,GAAG,IAAI,EAAE,GAAG,EAAE,KAAK,CAAC,GAAG,EAAE,CAAC;YACpC,GAAG,CAAC,KAAK,CAAC,OAAO,KAAK,SAAS,IAAI,EAAE,OAAO,EAAE,KAAK,CAAC,OAAO,EAAE,CAAC;YAC9D,GAAG,CAAC,KAAK,CAAC,SAAS,KAAK,SAAS,IAAI,EAAE,SAAS,EAAE,KAAK,CAAC,SAAS,EAAE,CAAC;YACpE,GAAG,CAAC,KAAK,CAAC,IAAI,KAAK,SAAS,IAAI,EAAE,IAAI,EAAE,KAAK,CAAC,IAAI,EAAE,CAAC;YACrD,GAAG,CAAC,KAAK,CAAC,UAAU,KAAK,SAAS,IAAI,EAAE,UAAU,EAAE,KAAK,CAAC,UAAU,EAAE,CAAC;SACxE,CAAC,CAAC;QACH,MAAM,MAAM,GAAG,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,kBAAkB,IAAI,EAAE,CAAC,CAAC;QAClE,OAAO,EAAE,GAAG,MAAM,EAAE,IAAI,EAAE,WAAW,CAAC,MAAM,CAAC,EAAE,CAAC;IAClD,CAAC;IAED,KAAK,CAAC,YAAY,CAAC,KAAkB,EAAE,KAAoB;QACzD,MAAM,EAAE,YAAY,EAAE,UAAU,EAAE,GAAG,IAAI,CAAC,OAAO,CAAC,cAAc,CAAC,EAAE,GAAG,KAAK,EAAE,CAAC,CAAC;QAC/E,MAAM,MAAM,GAAG,MAAM,KAAK,CAAC,GAAG,CAAC;YAC7B,YAAY,EAAE,WAAW,EAAE,UAAU,EAAE,eAAe,EAAE,EAAE;YAC1D,QAAQ,EAAE,CAAC,EAAE,GAAG,EAAE,KAAK,CAAC,GAAG;YAC3B,WAAW,EAAE,KAAK,CAAC,WAAW,EAAE,UAAU,EAAE,KAAK,CAAC,UAAU;YAC5D,GAAG,CAAC,KAAK,CAAC,GAAG,IAAI,EAAE,GAAG,EAAE,KAAK,CAAC,GAAG,EAAE,CAAC;YACpC,GAAG,CAAC,KAAK,CAAC,OAAO,KAAK,SAAS,IAAI,EAAE,OAAO,EAAE,KAAK,CAAC,OAAO,EAAE,CAAC;YAC9D,GAAG,CAAC,KAAK,CAAC,SAAS,KAAK,SAAS,IAAI,EAAE,SAAS,EAAE,KAAK,CAAC,SAAS,EAAE,CAAC;YACpE,GAAG,CAAC,KAAK,CAAC,IAAI,KAAK,SAAS,IAAI,EAAE,IAAI,EAAE,KAAK,CAAC,IAAI,EAAE,CAAC;YACrD,GAAG,CAAC,KAAK,CAAC,UAAU,KAAK,SAAS,IAAI,EAAE,UAAU,EAAE,KAAK,CAAC,UAAU,EAAE,CAAC;SACxE,CAAC,CAAC;QACH,MAAM,MAAM,GAAG,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,kBAAkB,IAAI,EAAE,CAAC,CAAC;QAClE,OAAO,EAAE,GAAG,MAAM,EAAE,IAAI,EAAE,WAAW,CAAC,MAAM,CAAC,EAAE,CAAC;IAClD,CAAC;IAED,KAAK,CAAC,OAAO,CAAC,KAAkB,EAAE,KAAoB;QACpD,MAAM,EAAE,YAAY,EAAE,UAAU,EAAE,GAAG,IAAI,CAAC,OAAO,CAAC,SAAS,CAAC,EAAE,GAAG,KAAK,EAAE,CAAC,CAAC;QAC1E,MAAM,MAAM,GAAG,MAAM,KAAK,CAAC,GAAG,CAAC;YAC7B,YAAY,EAAE,WAAW,EAAE,UAAU,EAAE,eAAe,EAAE,EAAE;YAC1D,QAAQ,EAAE,CAAC,EAAE,GAAG,EAAE,KAAK,CAAC,GAAG;YAC3B,WAAW,EAAE,KAAK,CAAC,WAAW,EAAE,UAAU,EAAE,KAAK,CAAC,UAAU;YAC5D,GAAG,CAAC,KAAK,CAAC,GAAG,IAAI,EAAE,GAAG,EAAE,KAAK,CAAC,GAAG,EAAE,CAAC;YACpC,GAAG,CAAC,KAAK,CAAC,OAAO,KAAK,SAAS,IAAI,EAAE,OAAO,EAAE,KAAK,CAAC,OAAO,EAAE,CAAC;YAC9D,GAAG,CAAC,KAAK,CAAC,SAAS,KAAK,SAAS,IAAI,EAAE,SAAS,EAAE,KAAK,CAAC,SAAS,EAAE,CAAC;YACpE,GAAG,CAAC,KAAK,CAAC,IAAI,KAAK,SAAS,IAAI,EAAE,IAAI,EAAE,KAAK,CAAC,IAAI,EAAE,CAAC;YACrD,GAAG,CAAC,KAAK,CAAC,UAAU,KAAK,SAAS,IAAI,EAAE,UAAU,EAAE,KAAK,CAAC,UAAU,EAAE,CAAC;SACxE,CAAC,CAAC;QACH,MAAM,MAAM,GAAG,IAAI,CAAC,MAAM,CAAC,SAAS,CAAC,MAAM,CAAC,kBAAkB,IAAI,EAAE,CAAC,CAAC;QACtE,OAAO,EAAE,GAAG,MAAM,EAAE,IAAI,EAAE,WAAW,CAAC,MAAM,CAAC,EAAE,CAAC;IAClD,CAAC;CACF;AAED,SAAS,WAAW,CAAC,CAAuN;IAC1O,OAAO;QACL,WAAW,EAAE,CAAC,CAAC,KAAK,EAAE,WAAW,IAAI,CAAC;QACtC,YAAY,EAAE,CAAC,CAAC,KAAK,EAAE,YAAY,IAAI,CAAC;QACxC,SAAS,EAAE,CAAC,CAAC,KAAK,IAAI,CAAC;QACvB,aAAa,EAAE,CAAC,CAAC,SAAS,EAAE,MAAM,IAAI,CAAC;QACvC,4FAA4F;QAC5F,OAAO,EAAE,CAAC,CAAC,OAAO,IAAI,CAAC,CAAC,IAAI,EAAE,OAAO,IAAI,CAAC,CAAC,KAAK,EAAE,OAAO,IAAI,IAAI;QACjE,UAAU,EAAE,CAAC,CAAC,UAAU,IAAI,IAAI;KACjC,CAAC;AACJ,CAAC;AAED,OAAO,EAAE,kBAAkB,EAAE,CAAC"}

package/dist/review/reviewer-output-parser.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"reviewer-output-parser.d.ts","sourceRoot":"","sources":["../../src/review/reviewer-output-parser.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,eAAe,EAAE,mBAAmB,EAAE,MAAM,mBAAmB,CAAC;AAE9E,MAAM,WAAW,mBAAmB;IAClC,OAAO,EAAE,eAAe,CAAC;IACzB,QAAQ,EAAE,MAAM,EAAE,CAAC;CACpB;AAED,MAAM,WAAW,uBAAuB;IACtC,OAAO,EAAE,mBAAmB,CAAC;IAC7B,QAAQ,EAAE,MAAM,EAAE,CAAC;CACpB;AA6CD,qBAAa,oBAAoB;IAC/B,KAAK,CAAC,IAAI,EAAE,MAAM,GAAG,mBAAmB;IASxC,SAAS,CAAC,IAAI,EAAE,MAAM,GAAG,uBAAuB;CAMjD;AAED,qBAAa,kBAAmB,SAAQ,KAAK;gBAC/B,OAAO,EAAE,MAAM;CAC5B"}
+{"version":3,"file":"reviewer-output-parser.d.ts","sourceRoot":"","sources":["../../src/review/reviewer-output-parser.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,eAAe,EAAE,mBAAmB,EAAE,MAAM,mBAAmB,CAAC;AAE9E,MAAM,WAAW,mBAAmB;IAClC,OAAO,EAAE,eAAe,CAAC;IACzB,QAAQ,EAAE,MAAM,EAAE,CAAC;CACpB;AAED,MAAM,WAAW,uBAAuB;IACtC,OAAO,EAAE,mBAAmB,CAAC;IAC7B,QAAQ,EAAE,MAAM,EAAE,CAAC;CACpB;AAwKD,qBAAa,oBAAoB;IAC/B,KAAK,CAAC,IAAI,EAAE,MAAM,GAAG,mBAAmB;IAkCxC,SAAS,CAAC,IAAI,EAAE,MAAM,GAAG,uBAAuB;CAgBjD;AAED,qBAAa,kBAAmB,SAAQ,KAAK;gBAC/B,OAAO,EAAE,MAAM;CAC5B"}

package/dist/review/reviewer-output-parser.js

@@ -2,20 +2,164 @@ function extractSummarySection(text) {
     const match = text.match(/##\s*Summary\s*\n([\s\S]*?)(?=\n##\s|$)/i);
     return match ? match[1].trim() : null;
 }
-function extractDeviationsAndUnresolved(text) {
-    const concerns = [];
-    const jsonMatch = text.match(/```json\s*\n([\s\S]*?)\n```/i);
-    if (jsonMatch) {
+/**
+ * Extract the verdict from a JSON block in the reviewer's output.
+ * Two acceptable shapes:
+ *   1. Fenced: ```json {"verdict":"...","concerns":[...]} ```
+ *   2. Bare:   {"verdict":"...","concerns":[...]}    (no fence)
+ *
+ * Some models freelance the format and skip the ```json``` wrapper —
+ * the fenced-only parser would then drop a perfectly valid verdict
+ * and fall through to the markdown-section path, which also fails
+ * (since the JSON template doesn't emit `## Summary`), causing the
+ * spurious "missing structured verdict" meta-concern that triggered
+ * spec_rework spirals.
+ *
+ * Recognized verdict values (case-insensitive):
+ *   - "approved" / "approve" → ReviewerVerdict.approved
+ *   - "changes_required" / "changes-required" → changes_required
+ *   - "concerns" → mapped to approved (parser convention: concerns
+ *     ≠ blocking; use changes_required for blocking).
+ */
+function extractJsonVerdict(text) {
+    // Pass 1: fenced ```json ... ``` block.
+    const fenced = text.match(/```json\s*\n([\s\S]*?)\n```/i);
+    const fencedVerdict = fenced ? tryReadVerdict(fenced[1]) : null;
+    if (fencedVerdict)
+        return fencedVerdict;
+    // Pass 2: scan for the first balanced `{...}` that parses as a JSON
+    // object containing a "verdict" key. Pre-fix the parser only tried
+    // FIRST `{` to LAST `}` — that fails when the text has prose with
+    // its own `{...}` (e.g., "the diff matches {file} criteria...
+    // {"verdict":"approved",...}"). We now walk each `{` left-to-right
+    // and find its matching `}` via balanced-brace counting (string-
+    // literal aware) so prose braces and JSON braces don't collide.
+    return findFirstParseableJsonVerdict(text);
+}
+/**
+ * Walk every `{` in `text` from left to right, find its balanced `}`
+ * (respecting strings + escapes), and try to parse the slice as JSON
+ * with a "verdict" field. Returns the first successful match, or null.
+ */
+function findFirstParseableJsonVerdict(text) {
+    const len = text.length;
+    for (let start = text.indexOf('{'); start !== -1; start = text.indexOf('{', start + 1)) {
+        const end = matchingBrace(text, start);
+        if (end === -1)
+            continue;
+        const candidate = text.slice(start, end + 1);
+        if (!/"verdict"\s*:/i.test(candidate))
+            continue;
+        const v = tryReadVerdict(candidate);
+        if (v)
+            return v;
+        // Bound the scan: don't try crazy-large prefixes from the same
+        // position. matchingBrace already returns at most `len`.
+        if (end >= len - 1)
+            break;
+    }
+    return null;
+}
+/**
+ * Return the index of the `}` that balances the `{` at `openPos`,
+ * accounting for nested objects and string literals. Returns -1 when
+ * unbalanced (don't try to parse).
+ */
+function matchingBrace(text, openPos) {
+    let depth = 0;
+    let inString = false;
+    let escape = false;
+    for (let i = openPos; i < text.length; i++) {
+        const ch = text[i];
+        if (inString) {
+            if (escape) {
+                escape = false;
+                continue;
+            }
+            if (ch === '\\') {
+                escape = true;
+                continue;
+            }
+            if (ch === '"') {
+                inString = false;
+                continue;
+            }
+            continue;
+        }
+        if (ch === '"') {
+            inString = true;
+            continue;
+        }
+        if (ch === '{')
+            depth++;
+        else if (ch === '}') {
+            depth--;
+            if (depth === 0)
+                return i;
+        }
+    }
+    return -1;
+}
+function readConcernsFromJsonText(text) {
+    const tryParse = (s) => {
         try {
-            const parsed = JSON.parse(jsonMatch[1]);
-            if (Array.isArray(parsed.concerns)) {
-                concerns.push(...parsed.concerns);
+            const obj = JSON.parse(s);
+            if (Array.isArray(obj.concerns)) {
+                return obj.concerns.filter((x) => typeof x === 'string');
             }
         }
         catch {
-            // fall through to markdown sections
+            /* not parseable */
         }
+        return [];
+    };
+    const fenced = text.match(/```json\s*\n([\s\S]*?)\n```/i);
+    if (fenced) {
+        const out = tryParse(fenced[1]);
+        if (out.length > 0)
+            return out;
     }
+    // Bare JSON fallback — same balanced-brace walk as extractJsonVerdict
+    // so the two helpers stay in sync. Pre-fix used a fragile first-`{`-
+    // to-last-`}` slice that broke when prose contained `{}`.
+    for (let start = text.indexOf('{'); start !== -1; start = text.indexOf('{', start + 1)) {
+        const end = matchingBrace(text, start);
+        if (end === -1)
+            continue;
+        const candidate = text.slice(start, end + 1);
+        if (!/"concerns"\s*:/i.test(candidate))
+            continue;
+        const out = tryParse(candidate);
+        if (out.length > 0)
+            return out;
+    }
+    return [];
+}
+function tryReadVerdict(jsonText) {
+    let parsed;
+    try {
+        parsed = JSON.parse(jsonText);
+    }
+    catch {
+        return null;
+    }
+    const obj = parsed;
+    const v = typeof obj.verdict === 'string' ? obj.verdict.toLowerCase().trim() : '';
+    if (v === 'approved' || v === 'approve')
+        return 'approved';
+    if (v === 'changes_required' || v === 'changes-required')
+        return 'changes_required';
+    if (v === 'concerns')
+        return 'approved';
+    return null;
+}
+function extractDeviationsAndUnresolved(text) {
+    const concerns = [];
+    // Try fenced ```json``` first, then bare JSON (same lenient pattern
+    // as extractJsonVerdict — keeps both helpers in sync so a parser
+    // that recognizes the verdict also recognizes the concerns).
+    const fromJson = readConcernsFromJsonText(text);
+    concerns.push(...fromJson);
     const devMatch = text.match(/##\s*Deviations from brief\s*\n([\s\S]*?)(?=\n##\s|$)/i);
     if (devMatch) {
         const lines = devMatch[1].trim().split('\n').filter(l => l.trim().startsWith('-'));
@@ -40,19 +184,52 @@ function extractDiffVerdict(text) {
 }
 export class ReviewerOutputParser {
     parse(text) {
+        // Source priority:
+        //   1. JSON block ```json ... ``` containing {"verdict":"...","concerns":[...]}
+        //      — what spec/quality templates actually instruct the LLM to emit
+        //      (tool sweep #6 rewrite). The pre-fix parser only looked at
+        //      `## Summary` markdown sections, defaulted every JSON-only
+        //      response to `changes_required` with a meta-concern, and
+        //      triggered exactly the spec_rework spirals we're trying to
+        //      eliminate.
+        //   2. `## Summary` markdown section (back-compat for any reviewer
+        //      that still emits the older format).
+        //   3. Fall through to changes_required with a meta-concern when
+        //      neither path produced a verdict — keeps malformed output
+        //      from crashing the run.
+        const jsonVerdict = extractJsonVerdict(text);
+        const concerns = extractDeviationsAndUnresolved(text);
+        if (jsonVerdict) {
+            return { verdict: jsonVerdict, concerns };
+        }
         const summary = extractSummarySection(text);
-        if (!summary)
-            throw new ReviewerParseError('reviewer output missing ## Summary section');
+        if (!summary) {
+            return {
+                verdict: 'changes_required',
+                concerns: [
+                    'reviewer output missing structured verdict (no JSON block, no `## Summary` section) — defaulting to changes_required',
+                    ...concerns,
+                ],
+            };
+        }
         const lower = summary.toLowerCase();
         const verdict = lower.includes('changes_required') ? 'changes_required' : 'approved';
-        const concerns = extractDeviationsAndUnresolved(text);
         return { verdict, concerns };
     }
     parseDiff(text) {
+        // Same leniency for diff review: missing verdict marker → concerns
+        // (default conservative) plus a meta-concern. Don't crash the run.
         const verdict = extractDiffVerdict(text);
-        if (!verdict)
-            throw new ReviewerParseError('diff reviewer output missing verdict');
         const concerns = extractDeviationsAndUnresolved(text);
+        if (!verdict) {
+            return {
+                verdict: 'concerns',
+                concerns: [
+                    'diff reviewer output missing APPROVE / CONCERNS: / REJECT: marker — defaulting verdict to concerns',
+                    ...concerns,
+                ],
+            };
+        }
         return { verdict, concerns };
     }
 }

package/dist/review/reviewer-output-parser.js.map

@@ -1 +1 @@
-{"version":3,"file":"reviewer-output-parser.js","sourceRoot":"","sources":["../../src/review/reviewer-output-parser.ts"],"names":[],"mappings":"AAYA,SAAS,qBAAqB,CAAC,IAAY;IACzC,MAAM,KAAK,GAAG,IAAI,CAAC,KAAK,CAAC,0CAA0C,CAAC,CAAC;IACrE,OAAO,KAAK,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC;AACxC,CAAC;AAED,SAAS,8BAA8B,CAAC,IAAY;IAClD,MAAM,QAAQ,GAAa,EAAE,CAAC;IAE9B,MAAM,SAAS,GAAG,IAAI,CAAC,KAAK,CAAC,8BAA8B,CAAC,CAAC;IAC7D,IAAI,SAAS,EAAE,CAAC;QACd,IAAI,CAAC;YACH,MAAM,MAAM,GAAG,IAAI,CAAC,KAAK,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC;YACxC,IAAI,KAAK,CAAC,OAAO,CAAC,MAAM,CAAC,QAAQ,CAAC,EAAE,CAAC;gBACnC,QAAQ,CAAC,IAAI,CAAC,GAAG,MAAM,CAAC,QAAQ,CAAC,CAAC;YACpC,CAAC;QACH,CAAC;QAAC,MAAM,CAAC;YACP,oCAAoC;QACtC,CAAC;IACH,CAAC;IAED,MAAM,QAAQ,GAAG,IAAI,CAAC,KAAK,CAAC,wDAAwD,CAAC,CAAC;IACtF,IAAI,QAAQ,EAAE,CAAC;QACb,MAAM,KAAK,GAAG,QAAQ,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,CAAC;QACnF,QAAQ,CAAC,IAAI,CAAC,GAAG,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;IAClE,CAAC;IAED,MAAM,UAAU,GAAG,IAAI,CAAC,KAAK,CAAC,6CAA6C,CAAC,CAAC;IAC7E,IAAI,UAAU,EAAE,CAAC;QACf,MAAM,KAAK,GAAG,UAAU,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,CAAC;QACrF,QAAQ,CAAC,IAAI,CAAC,GAAG,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;IAClE,CAAC;IAED,OAAO,QAAQ,CAAC;AAClB,CAAC;AAED,SAAS,kBAAkB,CAAC,IAAY;IACtC,MAAM,OAAO,GAAG,IAAI,CAAC,IAAI,EAAE,CAAC;IAC5B,IAAI,aAAa,CAAC,IAAI,CAAC,OAAO,CAAC;QAAE,OAAO,SAAS,CAAC;IAClD,IAAI,aAAa,CAAC,IAAI,CAAC,OAAO,CAAC;QAAE,OAAO,UAAU,CAAC;IACnD,IAAI,WAAW,CAAC,IAAI,CAAC,OAAO,CAAC;QAAE,OAAO,QAAQ,CAAC;IAC/C,OAAO,IAAI,CAAC;AACd,CAAC;AAED,MAAM,OAAO,oBAAoB;IAC/B,KAAK,CAAC,IAAY;QAChB,MAAM,OAAO,GAAG,qBAAqB,CAAC,IAAI,CAAC,CAAC;QAC5C,IAAI,CAAC,OAAO;YAAE,MAAM,IAAI,kBAAkB,CAAC,4CAA4C,CAAC,CAAC;QACzF,MAAM,KAAK,GAAG,OAAO,CAAC,WAAW,EAAE,CAAC;QACpC,MAAM,OAAO,GAAoB,KAAK,CAAC,QAAQ,CAAC,kBAAkB,CAAC,CAAC,CAAC,CAAC,kBAAkB,CAAC,CAAC,CAAC,UAAU,CAAC;QACtG,MAAM,QAAQ,GAAG,8BAA8B,CAAC,IAAI,CAAC,CAAC;QACtD,OAAO,EAAE,OAAO,EAAE,QAAQ,EAAE,CAAC;IAC/B,CAAC;IAED,SAAS,CAAC,IAAY;QACpB,MAAM,OAAO,GAAG,kBAAkB,CAAC,IAAI,CAAC,CAAC;QACzC,IAAI,CAAC,OAAO;YAAE,MAAM,IAAI,kBAAkB,CAAC,sCAAsC,CAAC,CAAC;QACnF,MAAM,QAAQ,GAAG,8BAA8B,CAAC,IAAI,CAAC,CAAC;QACtD,OAAO,EAAE,OAAO,EAAE,QAAQ,EAAE,CAAC;IAC/B,CAAC;CACF;AAED,MAAM,OAAO,kBAAmB,SAAQ,KAAK;IAC3C,YAAY,OAAe,IAAI,KAAK,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,GAAG,oBAAoB,CAAC,CAAC,CAAC;CACnF"}
+{"version":3,"file":"reviewer-output-parser.js","sourceRoot":"","sources":["../../src/review/reviewer-output-parser.ts"],"names":[],"mappings":"AAYA,SAAS,qBAAqB,CAAC,IAAY;IACzC,MAAM,KAAK,GAAG,IAAI,CAAC,KAAK,CAAC,0CAA0C,CAAC,CAAC;IACrE,OAAO,KAAK,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC;AACxC,CAAC;AAED;;;;;;;;;;;;;;;;;;GAkBG;AACH,SAAS,kBAAkB,CAAC,IAAY;IACtC,wCAAwC;IACxC,MAAM,MAAM,GAAG,IAAI,CAAC,KAAK,CAAC,8BAA8B,CAAC,CAAC;IAC1D,MAAM,aAAa,GAAG,MAAM,CAAC,CAAC,CAAC,cAAc,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;IAChE,IAAI,aAAa;QAAE,OAAO,aAAa,CAAC;IAExC,oEAAoE;IACpE,mEAAmE;IACnE,kEAAkE;IAClE,8DAA8D;IAC9D,mEAAmE;IACnE,iEAAiE;IACjE,gEAAgE;IAChE,OAAO,6BAA6B,CAAC,IAAI,CAAC,CAAC;AAC7C,CAAC;AAED;;;;GAIG;AACH,SAAS,6BAA6B,CAAC,IAAY;IACjD,MAAM,GAAG,GAAG,IAAI,CAAC,MAAM,CAAC;IACxB,KAAK,IAAI,KAAK,GAAG,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,EAAE,KAAK,KAAK,CAAC,CAAC,EAAE,KAAK,GAAG,IAAI,CAAC,OAAO,CAAC,GAAG,EAAE,KAAK,GAAG,CAAC,CAAC,EAAE,CAAC;QACvF,MAAM,GAAG,GAAG,aAAa,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;QACvC,IAAI,GAAG,KAAK,CAAC,CAAC;YAAE,SAAS;QACzB,MAAM,SAAS,GAAG,IAAI,CAAC,KAAK,CAAC,KAAK,EAAE,GAAG,GAAG,CAAC,CAAC,CAAC;QAC7C,IAAI,CAAC,gBAAgB,CAAC,IAAI,CAAC,SAAS,CAAC;YAAE,SAAS;QAChD,MAAM,CAAC,GAAG,cAAc,CAAC,SAAS,CAAC,CAAC;QACpC,IAAI,CAAC;YAAE,OAAO,CAAC,CAAC;QAChB,+DAA+D;QAC/D,yDAAyD;QACzD,IAAI,GAAG,IAAI,GAAG,GAAG,CAAC;YAAE,MAAM;IAC5B,CAAC;IACD,OAAO,IAAI,CAAC;AACd,CAAC;AAED;;;;GAIG;AACH,SAAS,aAAa,CAAC,IAAY,EAAE,OAAe;IAClD,IAAI,KAAK,GAAG,CAAC,CAAC;IACd,IAAI,QAAQ,GAAG,KAAK,CAAC;IACrB,IAAI,MAAM,GAAG,KAAK,CAAC;IACnB,KAAK,IAAI,CAAC,GAAG,OAAO,EAAE,CAAC,GAAG,IAAI,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;QAC3C,MAAM,EAAE,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;QACnB,IAAI,QAAQ,EAAE,CAAC;YACb,IAAI,MAAM,EAAE,CAAC;gBAAC,MAAM,GAAG,KAAK,CAAC;gBAAC,SAAS;YAAC,CAAC;YACzC,IAAI,EAAE,KAAK,IAAI,EAAE,CAAC;gBAAC,MAAM,GAAG,IAAI,CAAC;gBAAC,SAAS;YAAC,CAAC;YAC7C,IAAI,EAAE,KAAK,GAAG,EAAE,CAAC;gBAAC,QAAQ,GAAG,KAAK,CAAC;gBAAC,SAAS;YAAC,CAAC;YAC/C,SAAS;QACX,CAAC;QACD,IAAI,EAAE,KAAK,GAAG,EAAE,CAAC;YAAC,QAAQ,GAAG,IAAI,CAAC;YAAC,SAAS;QAAC,CAAC;QAC9C,IAAI,EAAE,KAAK,GAAG;YAAE,KAAK,EAAE,CAAC;aACnB,IAAI,EAAE,KAAK,GAAG,EAAE,CAAC;YACpB,KAAK,EAAE,CAAC;YACR,IAAI,KAAK,KAAK,CAAC;gBAAE,OAAO,CAAC,CAAC;QAC5B,CAAC;IACH,CAAC;IACD,OAAO,CAAC,CAAC,CAAC;AACZ,CAAC;AAED,SAAS,wBAAwB,CAAC,IAAY;IAC5C,MAAM,QAAQ,GAAG,CAAC,CAAS,EAAY,EAAE;QACvC,IAAI,CAAC;YACH,MAAM,GAAG,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,CAA2B,CAAC;YACpD,IAAI,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC,QAAQ,CAAC,EAAE,CAAC;gBAChC,OAAO,GAAG,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,EAAe,EAAE,CAAC,OAAO,CAAC,KAAK,QAAQ,CAAC,CAAC;YACxE,CAAC;QACH,CAAC;QAAC,MAAM,CAAC;YACP,mBAAmB;QACrB,CAAC;QACD,OAAO,EAAE,CAAC;IACZ,CAAC,CAAC;IACF,MAAM,MAAM,GAAG,IAAI,CAAC,KAAK,CAAC,8BAA8B,CAAC,CAAC;IAC1D,IAAI,MAAM,EAAE,CAAC;QACX,MAAM,GAAG,GAAG,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC;QAChC,IAAI,GAAG,CAAC,MAAM,GAAG,CAAC;YAAE,OAAO,GAAG,CAAC;IACjC,CAAC;IACD,sEAAsE;IACtE,qEAAqE;IACrE,0DAA0D;IAC1D,KAAK,IAAI,KAAK,GAAG,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,EAAE,KAAK,KAAK,CAAC,CAAC,EAAE,KAAK,GAAG,IAAI,CAAC,OAAO,CAAC,GAAG,EAAE,KAAK,GAAG,CAAC,CAAC,EAAE,CAAC;QACvF,MAAM,GAAG,GAAG,aAAa,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;QACvC,IAAI,GAAG,KAAK,CAAC,CAAC;YAAE,SAAS;QACzB,MAAM,SAAS,GAAG,IAAI,CAAC,KAAK,CAAC,KAAK,EAAE,GAAG,GAAG,CAAC,CAAC,CAAC;QAC7C,IAAI,CAAC,iBAAiB,CAAC,IAAI,CAAC,SAAS,CAAC;YAAE,SAAS;QACjD,MAAM,GAAG,GAAG,QAAQ,CAAC,SAAS,CAAC,CAAC;QAChC,IAAI,GAAG,CAAC,MAAM,GAAG,CAAC;YAAE,OAAO,GAAG,CAAC;IACjC,CAAC;IACD,OAAO,EAAE,CAAC;AACZ,CAAC;AAED,SAAS,cAAc,CAAC,QAAgB;IACtC,IAAI,MAAe,CAAC;IACpB,IAAI,CAAC;QACH,MAAM,GAAG,IAAI,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC;IAChC,CAAC;IAAC,MAAM,CAAC;QACP,OAAO,IAAI,CAAC;IACd,CAAC;IACD,MAAM,GAAG,GAAG,MAA+B,CAAC;IAC5C,MAAM,CAAC,GAAG,OAAO,GAAG,CAAC,OAAO,KAAK,QAAQ,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,WAAW,EAAE,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;IAClF,IAAI,CAAC,KAAK,UAAU,IAAI,CAAC,KAAK,SAAS;QAAE,OAAO,UAAU,CAAC;IAC3D,IAAI,CAAC,KAAK,kBAAkB,IAAI,CAAC,KAAK,kBAAkB;QAAE,OAAO,kBAAkB,CAAC;IACpF,IAAI,CAAC,KAAK,UAAU;QAAE,OAAO,UAAU,CAAC;IACxC,OAAO,IAAI,CAAC;AACd,CAAC;AAED,SAAS,8BAA8B,CAAC,IAAY;IAClD,MAAM,QAAQ,GAAa,EAAE,CAAC;IAE9B,oEAAoE;IACpE,iEAAiE;IACjE,6DAA6D;IAC7D,MAAM,QAAQ,GAAG,wBAAwB,CAAC,IAAI,CAAC,CAAC;IAChD,QAAQ,CAAC,IAAI,CAAC,GAAG,QAAQ,CAAC,CAAC;IAE3B,MAAM,QAAQ,GAAG,IAAI,CAAC,KAAK,CAAC,wDAAwD,CAAC,CAAC;IACtF,IAAI,QAAQ,EAAE,CAAC;QACb,MAAM,KAAK,GAAG,QAAQ,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,CAAC;QACnF,QAAQ,CAAC,IAAI,CAAC,GAAG,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;IAClE,CAAC;IAED,MAAM,UAAU,GAAG,IAAI,CAAC,KAAK,CAAC,6CAA6C,CAAC,CAAC;IAC7E,IAAI,UAAU,EAAE,CAAC;QACf,MAAM,KAAK,GAAG,UAAU,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,CAAC;QACrF,QAAQ,CAAC,IAAI,CAAC,GAAG,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;IAClE,CAAC;IAED,OAAO,QAAQ,CAAC;AAClB,CAAC;AAED,SAAS,kBAAkB,CAAC,IAAY;IACtC,MAAM,OAAO,GAAG,IAAI,CAAC,IAAI,EAAE,CAAC;IAC5B,IAAI,aAAa,CAAC,IAAI,CAAC,OAAO,CAAC;QAAE,OAAO,SAAS,CAAC;IAClD,IAAI,aAAa,CAAC,IAAI,CAAC,OAAO,CAAC;QAAE,OAAO,UAAU,CAAC;IACnD,IAAI,WAAW,CAAC,IAAI,CAAC,OAAO,CAAC;QAAE,OAAO,QAAQ,CAAC;IAC/C,OAAO,IAAI,CAAC;AACd,CAAC;AAED,MAAM,OAAO,oBAAoB;IAC/B,KAAK,CAAC,IAAY;QAChB,mBAAmB;QACnB,gFAAgF;QAChF,uEAAuE;QACvE,kEAAkE;QAClE,iEAAiE;QACjE,+DAA+D;QAC/D,iEAAiE;QACjE,kBAAkB;QAClB,mEAAmE;QACnE,2CAA2C;QAC3C,iEAAiE;QACjE,gEAAgE;QAChE,8BAA8B;QAC9B,MAAM,WAAW,GAAG,kBAAkB,CAAC,IAAI,CAAC,CAAC;QAC7C,MAAM,QAAQ,GAAG,8BAA8B,CAAC,IAAI,CAAC,CAAC;QACtD,IAAI,WAAW,EAAE,CAAC;YAChB,OAAO,EAAE,OAAO,EAAE,WAAW,EAAE,QAAQ,EAAE,CAAC;QAC5C,CAAC;QACD,MAAM,OAAO,GAAG,qBAAqB,CAAC,IAAI,CAAC,CAAC;QAC5C,IAAI,CAAC,OAAO,EAAE,CAAC;YACb,OAAO;gBACL,OAAO,EAAE,kBAAkB;gBAC3B,QAAQ,EAAE;oBACR,sHAAsH;oBACtH,GAAG,QAAQ;iBACZ;aACF,CAAC;QACJ,CAAC;QACD,MAAM,KAAK,GAAG,OAAO,CAAC,WAAW,EAAE,CAAC;QACpC,MAAM,OAAO,GAAoB,KAAK,CAAC,QAAQ,CAAC,kBAAkB,CAAC,CAAC,CAAC,CAAC,kBAAkB,CAAC,CAAC,CAAC,UAAU,CAAC;QACtG,OAAO,EAAE,OAAO,EAAE,QAAQ,EAAE,CAAC;IAC/B,CAAC;IAED,SAAS,CAAC,IAAY;QACpB,mEAAmE;QACnE,mEAAmE;QACnE,MAAM,OAAO,GAAG,kBAAkB,CAAC,IAAI,CAAC,CAAC;QACzC,MAAM,QAAQ,GAAG,8BAA8B,CAAC,IAAI,CAAC,CAAC;QACtD,IAAI,CAAC,OAAO,EAAE,CAAC;YACb,OAAO;gBACL,OAAO,EAAE,UAAU;gBACnB,QAAQ,EAAE;oBACR,oGAAoG;oBACpG,GAAG,QAAQ;iBACZ;aACF,CAAC;QACJ,CAAC;QACD,OAAO,EAAE,OAAO,EAAE,QAAQ,EAAE,CAAC;IAC/B,CAAC;CACF;AAED,MAAM,OAAO,kBAAmB,SAAQ,KAAK;IAC3C,YAAY,OAAe,IAAI,KAAK,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,GAAG,oBAAoB,CAAC,CAAC,CAAC;CACnF"}

package/dist/review/reviewer-prompt-builder.d.ts

@@ -1,4 +1,4 @@
-import type { ReviewTemplate } from './templates/shared.js';
+import type { ReviewTemplate, ReviewTemplateContext } from './templates/shared.js';
 export type QualityReviewRoute = 'delegate' | 'execute-plan' | 'audit' | 'review' | 'verify' | 'investigate' | 'debug' | 'explore';
 export declare class ReviewerPromptBuilder {
     private templates;
@@ -8,25 +8,17 @@ export declare class ReviewerPromptBuilder {
         qualityForAP: ReviewTemplate;
         diff: ReviewTemplate;
     }, qualityTemplates?: Partial<Record<QualityReviewRoute, ReviewTemplate>>);
-    buildSpec(ctx: {
-        workerOutput: string;
-        brief: string;
-    }): {
+    buildSpec(ctx: ReviewTemplateContext): {
         systemPrompt: string;
         userPrompt: string;
     };
-    buildQualityAP(ctx: {
-        workerOutput: string;
-        brief: string;
+    buildQualityAP(ctx: ReviewTemplateContext & {
         route?: QualityReviewRoute;
     }): {
         systemPrompt: string;
         userPrompt: string;
     };
-    buildDiff(ctx: {
-        workerOutput: string;
-        brief: string;
-    }): {
+    buildDiff(ctx: ReviewTemplateContext): {
         systemPrompt: string;
         userPrompt: string;
     };

package/dist/review/reviewer-prompt-builder.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"reviewer-prompt-builder.d.ts","sourceRoot":"","sources":["../../src/review/reviewer-prompt-builder.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,uBAAuB,CAAC;AAE5D,MAAM,MAAM,kBAAkB,GAAG,UAAU,GAAG,cAAc,GAAG,OAAO,GAAG,QAAQ,GAAG,QAAQ,GAAG,aAAa,GAAG,OAAO,GAAG,SAAS,CAAC;AAEnI,qBAAa,qBAAqB;IAE9B,OAAO,CAAC,SAAS;IAKjB,OAAO,CAAC,gBAAgB;gBALhB,SAAS,EAAE;QACjB,IAAI,EAAE,cAAc,CAAC;QACrB,YAAY,EAAE,cAAc,CAAC;QAC7B,IAAI,EAAE,cAAc,CAAC;KACtB,EACO,gBAAgB,GAAE,OAAO,CAAC,MAAM,CAAC,kBAAkB,EAAE,cAAc,CAAC,CAAM;IAGpF,SAAS,CAAC,GAAG,EAAE;QAAE,YAAY,EAAE,MAAM,CAAC;QAAC,KAAK,EAAE,MAAM,CAAA;KAAE,GAAG;QAAE,YAAY,EAAE,MAAM,CAAC;QAAC,UAAU,EAAE,MAAM,CAAA;KAAE;IAOrG,cAAc,CAAC,GAAG,EAAE;QAAE,YAAY,EAAE,MAAM,CAAC;QAAC,KAAK,EAAE,MAAM,CAAC;QAAC,KAAK,CAAC,EAAE,kBAAkB,CAAA;KAAE,GAAG;QAAE,YAAY,EAAE,MAAM,CAAC;QAAC,UAAU,EAAE,MAAM,CAAA;KAAE;IAQtI,SAAS,CAAC,GAAG,EAAE;QAAE,YAAY,EAAE,MAAM,CAAC;QAAC,KAAK,EAAE,MAAM,CAAA;KAAE,GAAG;QAAE,YAAY,EAAE,MAAM,CAAC;QAAC,UAAU,EAAE,MAAM,CAAA;KAAE;CAMtG"}
+{"version":3,"file":"reviewer-prompt-builder.d.ts","sourceRoot":"","sources":["../../src/review/reviewer-prompt-builder.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,cAAc,EAAE,qBAAqB,EAAE,MAAM,uBAAuB,CAAC;AAEnF,MAAM,MAAM,kBAAkB,GAAG,UAAU,GAAG,cAAc,GAAG,OAAO,GAAG,QAAQ,GAAG,QAAQ,GAAG,aAAa,GAAG,OAAO,GAAG,SAAS,CAAC;AAEnI,qBAAa,qBAAqB;IAE9B,OAAO,CAAC,SAAS;IAKjB,OAAO,CAAC,gBAAgB;gBALhB,SAAS,EAAE;QACjB,IAAI,EAAE,cAAc,CAAC;QACrB,YAAY,EAAE,cAAc,CAAC;QAC7B,IAAI,EAAE,cAAc,CAAC;KACtB,EACO,gBAAgB,GAAE,OAAO,CAAC,MAAM,CAAC,kBAAkB,EAAE,cAAc,CAAC,CAAM;IAGpF,SAAS,CAAC,GAAG,EAAE,qBAAqB,GAAG;QAAE,YAAY,EAAE,MAAM,CAAC;QAAC,UAAU,EAAE,MAAM,CAAA;KAAE;IAOnF,cAAc,CAAC,GAAG,EAAE,qBAAqB,GAAG;QAAE,KAAK,CAAC,EAAE,kBAAkB,CAAA;KAAE,GAAG;QAAE,YAAY,EAAE,MAAM,CAAC;QAAC,UAAU,EAAE,MAAM,CAAA;KAAE;IAQzH,SAAS,CAAC,GAAG,EAAE,qBAAqB,GAAG;QAAE,YAAY,EAAE,MAAM,CAAC;QAAC,UAAU,EAAE,MAAM,CAAA;KAAE;CAMpF"}

package/dist/review/reviewer-prompt-builder.js.map

@@ -1 +1 @@
-{"version":3,"file":"reviewer-prompt-builder.js","sourceRoot":"","sources":["../../src/review/reviewer-prompt-builder.ts"],"names":[],"mappings":"AAIA,MAAM,OAAO,qBAAqB;IAEtB;IAKA;IANV,YACU,SAIP,EACO,mBAAwE,EAAE;QAL1E,cAAS,GAAT,SAAS,CAIhB;QACO,qBAAgB,GAAhB,gBAAgB,CAA0D;IACjF,CAAC;IAEJ,SAAS,CAAC,GAA4C;QACpD,OAAO;YACL,YAAY,EAAE,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,YAAY;YAC9C,UAAU,EAAE,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,eAAe,CAAC,GAAG,CAAC;SACrD,CAAC;IACJ,CAAC;IAED,cAAc,CAAC,GAAwE;QACrF,MAAM,QAAQ,GAAG,CAAC,GAAG,CAAC,KAAK,KAAK,SAAS,IAAI,IAAI,CAAC,gBAAgB,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC,IAAI,IAAI,CAAC,SAAS,CAAC,YAAY,CAAC;QAC9G,OAAO;YACL,YAAY,EAAE,QAAQ,CAAC,YAAY;YACnC,UAAU,EAAE,QAAQ,CAAC,eAAe,CAAC,GAAG,CAAC;SAC1C,CAAC;IACJ,CAAC;IAED,SAAS,CAAC,GAA4C;QACpD,OAAO;YACL,YAAY,EAAE,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,YAAY;YAC9C,UAAU,EAAE,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,eAAe,CAAC,GAAG,CAAC;SACrD,CAAC;IACJ,CAAC;CACF"}
+{"version":3,"file":"reviewer-prompt-builder.js","sourceRoot":"","sources":["../../src/review/reviewer-prompt-builder.ts"],"names":[],"mappings":"AAIA,MAAM,OAAO,qBAAqB;IAEtB;IAKA;IANV,YACU,SAIP,EACO,mBAAwE,EAAE;QAL1E,cAAS,GAAT,SAAS,CAIhB;QACO,qBAAgB,GAAhB,gBAAgB,CAA0D;IACjF,CAAC;IAEJ,SAAS,CAAC,GAA0B;QAClC,OAAO;YACL,YAAY,EAAE,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,YAAY;YAC9C,UAAU,EAAE,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,eAAe,CAAC,GAAG,CAAC;SACrD,CAAC;IACJ,CAAC;IAED,cAAc,CAAC,GAA2D;QACxE,MAAM,QAAQ,GAAG,CAAC,GAAG,CAAC,KAAK,KAAK,SAAS,IAAI,IAAI,CAAC,gBAAgB,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC,IAAI,IAAI,CAAC,SAAS,CAAC,YAAY,CAAC;QAC9G,OAAO;YACL,YAAY,EAAE,QAAQ,CAAC,YAAY;YACnC,UAAU,EAAE,QAAQ,CAAC,eAAe,CAAC,GAAG,CAAC;SAC1C,CAAC;IACJ,CAAC;IAED,SAAS,CAAC,GAA0B;QAClC,OAAO;YACL,YAAY,EAAE,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,YAAY;YAC9C,UAAU,EAAE,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,eAAe,CAAC,GAAG,CAAC;SACrD,CAAC;IACJ,CAAC;CACF"}

package/dist/review/templates/diff-review.d.ts

@@ -1,3 +1,11 @@
 import type { ReviewTemplate } from './shared.js';
+/**
+ * Diff reviewer — the final cross-check that looks at the cumulative
+ * diff in isolation and decides if it's acceptable as a whole.
+ *
+ * Tool sweep #6 fix: the template name was a misnomer pre-fix —
+ * the reviewer received only the worker's text summary, never the
+ * actual diff. Now it sees the diff (matches the name).
+ */
 export declare const diffTemplate: ReviewTemplate;
 //# sourceMappingURL=diff-review.d.ts.map

package/dist/review/templates/diff-review.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"diff-review.d.ts","sourceRoot":"","sources":["../../../src/review/templates/diff-review.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,aAAa,CAAC;AAElD,eAAO,MAAM,YAAY,EAAE,cAK1B,CAAC"}
+{"version":3,"file":"diff-review.d.ts","sourceRoot":"","sources":["../../../src/review/templates/diff-review.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,aAAa,CAAC;AAElD;;;;;;;GAOG;AACH,eAAO,MAAM,YAAY,EAAE,cAgC1B,CAAC"}

package/dist/review/templates/diff-review.js

@@ -1,7 +1,39 @@
+/**
+ * Diff reviewer — the final cross-check that looks at the cumulative
+ * diff in isolation and decides if it's acceptable as a whole.
+ *
+ * Tool sweep #6 fix: the template name was a misnomer pre-fix —
+ * the reviewer received only the worker's text summary, never the
+ * actual diff. Now it sees the diff (matches the name).
+ */
 export const diffTemplate = {
-    systemPrompt: `You are reviewing a diff. Reply with EXACTLY one of: APPROVE, CONCERNS: <reasons>, or REJECT: <reason>`,
+    systemPrompt: [
+        'You are reviewing the cumulative diff produced by all rework rounds. Decide whether the overall change is acceptable.',
+        '',
+        'Reply with EXACTLY one of these single-line verdicts:',
+        '- `APPROVE` — the diff is acceptable as-is.',
+        '- `CONCERNS: <one-line summary of concerns>` — the diff has flaws but is on the right track.',
+        '- `REJECT: <one-line reason>` — the diff is wrong enough that it should not be applied.',
+        '',
+        'Decision criteria:',
+        '- Is the diff scoped to what the brief asked for? Out-of-scope edits are a CONCERN at minimum.',
+        '- Are the changes internally consistent (e.g., a renamed symbol updated everywhere it appears in the diff)?',
+        '- Does the diff introduce obvious correctness or security issues that the spec/quality reviews missed?',
+        '',
+        'Do NOT re-litigate the brief itself — that is the spec reviewer\'s job. Focus on the diff as a whole.',
+    ].join('\n'),
     buildUserPrompt(ctx) {
-        return `Task: ${ctx.brief}\n\nWorker output:\n${ctx.workerOutput}`;
+        const parts = [];
+        parts.push(`# Task brief\n${ctx.brief}`);
+        parts.push(`# Worker's most recent summary\n${ctx.workerOutput || '(no summary)'}`);
+        if (ctx.diff && ctx.diff.length > 0) {
+            parts.push(`# Cumulative diff (what you are reviewing)\n\n\`\`\`diff\n${ctx.diff}\n\`\`\``);
+        }
+        else {
+            parts.push(`# Cumulative diff\n(no file changes detected — APPROVE only if the brief requested a no-op)`);
+        }
+        parts.push(`# Decide\nReply with one of APPROVE, CONCERNS: <text>, or REJECT: <text>.`);
+        return parts.join('\n\n');
     },
 };
 //# sourceMappingURL=diff-review.js.map

package/dist/review/templates/diff-review.js.map

@@ -1 +1 @@
-{"version":3,"file":"diff-review.js","sourceRoot":"","sources":["../../../src/review/templates/diff-review.ts"],"names":[],"mappings":"AAEA,MAAM,CAAC,MAAM,YAAY,GAAmB;IAC1C,YAAY,EAAE,wGAAwG;IACtH,eAAe,CAAC,GAAG;QACjB,OAAO,SAAS,GAAG,CAAC,KAAK,uBAAuB,GAAG,CAAC,YAAY,EAAE,CAAC;IACrE,CAAC;CACF,CAAC"}
+{"version":3,"file":"diff-review.js","sourceRoot":"","sources":["../../../src/review/templates/diff-review.ts"],"names":[],"mappings":"AAEA;;;;;;;GAOG;AACH,MAAM,CAAC,MAAM,YAAY,GAAmB;IAC1C,YAAY,EAAE;QACZ,uHAAuH;QACvH,EAAE;QACF,uDAAuD;QACvD,6CAA6C;QAC7C,8FAA8F;QAC9F,yFAAyF;QACzF,EAAE;QACF,oBAAoB;QACpB,gGAAgG;QAChG,6GAA6G;QAC7G,wGAAwG;QACxG,EAAE;QACF,uGAAuG;KACxG,CAAC,IAAI,CAAC,IAAI,CAAC;IAEZ,eAAe,CAAC,GAAG;QACjB,MAAM,KAAK,GAAa,EAAE,CAAC;QAC3B,KAAK,CAAC,IAAI,CAAC,iBAAiB,GAAG,CAAC,KAAK,EAAE,CAAC,CAAC;QACzC,KAAK,CAAC,IAAI,CAAC,mCAAmC,GAAG,CAAC,YAAY,IAAI,cAAc,EAAE,CAAC,CAAC;QAEpF,IAAI,GAAG,CAAC,IAAI,IAAI,GAAG,CAAC,IAAI,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACpC,KAAK,CAAC,IAAI,CAAC,6DAA6D,GAAG,CAAC,IAAI,UAAU,CAAC,CAAC;QAC9F,CAAC;aAAM,CAAC;YACN,KAAK,CAAC,IAAI,CAAC,6FAA6F,CAAC,CAAC;QAC5G,CAAC;QAED,KAAK,CAAC,IAAI,CAAC,2EAA2E,CAAC,CAAC;QAExF,OAAO,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;IAC5B,CAAC;CACF,CAAC"}

package/dist/review/templates/finding-criteria.d.ts

@@ -0,0 +1,39 @@
+/**
+ * Shared finding-quality criteria — the single source of truth for what
+ * makes a "good finding" across the implementer + annotator stages.
+ *
+ * Tool sweep #12: the implementer prompts didn't share the annotator's
+ * rubric, so workers emitted weak narrative (miscalibrated severity,
+ * unsupported claims, speculative scope) and the annotator had to
+ * either downgrade everything or rubber-stamp. This module gives
+ * implementer prompts the SAME calibration the annotator uses, so the
+ * two stages converge:
+ *
+ *   - Implementer is told what counts as evidence, what severity means,
+ *     and what's out of scope BEFORE it writes findings.
+ *   - Annotator validates the worker emitted them properly (its rubric
+ *     in `annotator-shared.ts` references the same definitions).
+ *
+ * Result: fewer false positives, fewer missed criticals, less rework
+ * (the worker self-aligned with what the reviewer will check). No
+ * heuristic short-circuits — both stages run, they just spend less
+ * time correcting each other.
+ */
+/** Severity ladder for read-only finding emission AND annotator
+ *  validation. Same words, same meaning across stages. */
+export declare const SEVERITY_LADDER: string;
+/** Evidence-grounding rule. Required for every finding the worker
+ *  emits. The annotator rejects findings without quotable evidence. */
+export declare const EVIDENCE_GROUNDING: string;
+/** Scope discipline. Workers commonly hallucinate citations into files
+ *  they didn't open; this rule blocks the most common failure mode. */
+export declare const SCOPE_DISCIPLINE: string;
+/** What the annotator (which doubles as the read-only quality reviewer)
+ *  will check the worker's output against. Pre-fix the worker had no
+ *  visibility into this; now it can self-align. */
+export declare const ANNOTATOR_CHECK_AWARENESS_RO: string;
+/** Awareness block for delegate / execute-plan / retry implementers.
+ *  Tells the worker what spec_review and quality_review will judge,
+ *  so the worker self-aligns. */
+export declare const REVIEWER_AWARENESS_AP: string;
+//# sourceMappingURL=finding-criteria.d.ts.map

package/dist/review/templates/finding-criteria.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"finding-criteria.d.ts","sourceRoot":"","sources":["../../../src/review/templates/finding-criteria.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;GAoBG;AAEH;0DAC0D;AAC1D,eAAO,MAAM,eAAe,QAOhB,CAAC;AAEb;uEACuE;AACvE,eAAO,MAAM,kBAAkB,QAKnB,CAAC;AAEb;uEACuE;AACvE,eAAO,MAAM,gBAAgB,QAKjB,CAAC;AAEb;;mDAEmD;AACnD,eAAO,MAAM,4BAA4B,QAO7B,CAAC;AAEb;;iCAEiC;AACjC,eAAO,MAAM,qBAAqB,QAiBtB,CAAC"}

package/dist/review/templates/finding-criteria.js

@@ -0,0 +1,80 @@
+/**
+ * Shared finding-quality criteria — the single source of truth for what
+ * makes a "good finding" across the implementer + annotator stages.
+ *
+ * Tool sweep #12: the implementer prompts didn't share the annotator's
+ * rubric, so workers emitted weak narrative (miscalibrated severity,
+ * unsupported claims, speculative scope) and the annotator had to
+ * either downgrade everything or rubber-stamp. This module gives
+ * implementer prompts the SAME calibration the annotator uses, so the
+ * two stages converge:
+ *
+ *   - Implementer is told what counts as evidence, what severity means,
+ *     and what's out of scope BEFORE it writes findings.
+ *   - Annotator validates the worker emitted them properly (its rubric
+ *     in `annotator-shared.ts` references the same definitions).
+ *
+ * Result: fewer false positives, fewer missed criticals, less rework
+ * (the worker self-aligned with what the reviewer will check). No
+ * heuristic short-circuits — both stages run, they just spend less
+ * time correcting each other.
+ */
+/** Severity ladder for read-only finding emission AND annotator
+ *  validation. Same words, same meaning across stages. */
+export const SEVERITY_LADDER = [
+    'Severity (your judgment, calibrated to impact):',
+    '- critical: must fix first — RCE, data loss, auth bypass, build broken, data corruption.',
+    '- high:     real bug or security gap; blocks release.',
+    '- medium:   real issue; fix soon; not blocking.',
+    '- low:      minor or cosmetic issue; nice-to-fix; PASS in checklist contexts.',
+    'Calibrate to actual impact, not how alarming the wording sounds. Workers commonly inflate — resist the urge.',
+].join('\n');
+/** Evidence-grounding rule. Required for every finding the worker
+ *  emits. The annotator rejects findings without quotable evidence. */
+export const EVIDENCE_GROUNDING = [
+    'Evidence grounding (REQUIRED for every finding):',
+    '- Cite `file:line` (or `file:line-line` for a span) where the issue lives.',
+    '- Quote the exact code excerpt or command output that demonstrates the issue. Don\'t paraphrase — quote.',
+    '- If you cannot quote evidence directly, do NOT raise the finding. Note "investigation needed" in your summary instead.',
+].join('\n');
+/** Scope discipline. Workers commonly hallucinate citations into files
+ *  they didn't open; this rule blocks the most common failure mode. */
+export const SCOPE_DISCIPLINE = [
+    'Scope discipline:',
+    '- Only flag issues you verified by reading the file directly.',
+    '- If a claim depends on caller behavior or files outside the requested scope, mark "investigation needed" in your summary — do NOT speculate.',
+    '- Stay within the requested files. Don\'t audit dependencies you weren\'t asked about.',
+].join('\n');
+/** What the annotator (which doubles as the read-only quality reviewer)
+ *  will check the worker's output against. Pre-fix the worker had no
+ *  visibility into this; now it can self-align. */
+export const ANNOTATOR_CHECK_AWARENESS_RO = [
+    'After your output, an annotator validates each finding against this rubric:',
+    '- Is the severity calibrated to actual impact (or did you inflate)?',
+    '- Does the evidence directly support the claim, or is it paraphrased?',
+    '- Is the finding within scope, or is it speculation about untouched files?',
+    '- Is the finding on-brief (matching the focus / audit type / checklist item)?',
+    'Findings that fail any of these are downgraded or dropped. Self-check before emitting.',
+].join('\n');
+/** Awareness block for delegate / execute-plan / retry implementers.
+ *  Tells the worker what spec_review and quality_review will judge,
+ *  so the worker self-aligns. */
+export const REVIEWER_AWARENESS_AP = [
+    'After your edit, two reviewers see the cumulative diff (every change since task start):',
+    '',
+    '1. SPEC reviewer — "does the diff fulfill the brief?"',
+    '   - APPROVED requires: every brief item present in the diff, no missing pieces, no out-of-scope edits.',
+    '   - CHANGES_REQUIRED requires: a concrete concern tied to a specific diff line.',
+    '   - Empty diff = changes_required UNLESS the brief explicitly requested a no-op.',
+    '',
+    '2. QUALITY reviewer — "is the diff sound, safe, maintainable?"',
+    '   - Flags: correctness bugs, broken tests, races, security gaps, speculative dependencies.',
+    '   - Does NOT flag: stylistic preferences, comment bikeshedding, unrelated pre-existing code.',
+    '',
+    'Self-check before declaring done:',
+    '- Implemented EVERY item in the brief? (no gaps)',
+    '- No edits OUTSIDE the brief? (no scope creep)',
+    '- If your edit affects callers / tests not in your filePaths, note them in your summary — even if you can\'t update them.',
+    '- Are the changes minimal and verifiable, or could they be smaller?',
+].join('\n');
+//# sourceMappingURL=finding-criteria.js.map

package/dist/review/templates/finding-criteria.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"finding-criteria.js","sourceRoot":"","sources":["../../../src/review/templates/finding-criteria.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;GAoBG;AAEH;0DAC0D;AAC1D,MAAM,CAAC,MAAM,eAAe,GAAG;IAC7B,iDAAiD;IACjD,0FAA0F;IAC1F,uDAAuD;IACvD,iDAAiD;IACjD,+EAA+E;IAC/E,8GAA8G;CAC/G,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AAEb;uEACuE;AACvE,MAAM,CAAC,MAAM,kBAAkB,GAAG;IAChC,kDAAkD;IAClD,4EAA4E;IAC5E,0GAA0G;IAC1G,yHAAyH;CAC1H,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AAEb;uEACuE;AACvE,MAAM,CAAC,MAAM,gBAAgB,GAAG;IAC9B,mBAAmB;IACnB,+DAA+D;IAC/D,+IAA+I;IAC/I,wFAAwF;CACzF,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AAEb;;mDAEmD;AACnD,MAAM,CAAC,MAAM,4BAA4B,GAAG;IAC1C,6EAA6E;IAC7E,qEAAqE;IACrE,uEAAuE;IACvE,4EAA4E;IAC5E,+EAA+E;IAC/E,wFAAwF;CACzF,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AAEb;;iCAEiC;AACjC,MAAM,CAAC,MAAM,qBAAqB,GAAG;IACnC,yFAAyF;IACzF,EAAE;IACF,uDAAuD;IACvD,yGAAyG;IACzG,kFAAkF;IAClF,mFAAmF;IACnF,EAAE;IACF,gEAAgE;IAChE,6FAA6F;IAC7F,+FAA+F;IAC/F,EAAE;IACF,mCAAmC;IACnC,kDAAkD;IAClD,gDAAgD;IAChD,2HAA2H;IAC3H,qEAAqE;CACtE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC"}

package/dist/review/templates/quality-review-artifact.d.ts

@@ -1,3 +1,16 @@
 import type { ReviewTemplate } from './shared.js';
+/**
+ * Quality reviewer for artifact-producing routes (delegate, execute-plan,
+ * retry).
+ *
+ * Tool sweep #6: pre-fix this template only saw `Task: <brief>` +
+ * `Worker output: <text>`. Quality findings were rooted in the
+ * worker's prose claim — false positives ("the worker claimed X but
+ * didn't really") were common, and real regressions in the diff
+ * could be missed if the worker's summary glossed over them.
+ *
+ * Post-fix: reviewer sees the cumulative diff. Findings must be
+ * specific to diff lines.
+ */
 export declare const qualityAPTemplate: ReviewTemplate;
 //# sourceMappingURL=quality-review-artifact.d.ts.map

package/dist/review/templates/quality-review-artifact.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"quality-review-artifact.d.ts","sourceRoot":"","sources":["../../../src/review/templates/quality-review-artifact.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,aAAa,CAAC;AAElD,eAAO,MAAM,iBAAiB,EAAE,cAM/B,CAAC"}
+{"version":3,"file":"quality-review-artifact.d.ts","sourceRoot":"","sources":["../../../src/review/templates/quality-review-artifact.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,aAAa,CAAC;AAElD;;;;;;;;;;;;GAYG;AACH,eAAO,MAAM,iBAAiB,EAAE,cAsC/B,CAAC"}