@zgeoff/oxlint-config 0.2.8 → 0.2.10

package/README.md

@@ -9,7 +9,8 @@ await arguments, awaits hidden inside a control-flow condition or a `&&`/`||`/`?
 that loosens either comment rule. `zgeoff/function-verb` enforces the function-naming taxonomy from
 the shared agent guidelines, `zgeoff/test-beside-module` keeps each test file beside the module it
 tests, `zgeoff/import-zones` fails an import that crosses a module boundary the repo declares,
-`zgeoff/no-restricted-words` keeps the words in its `words` option out of a path's text, and
+`zgeoff/no-restricted-words` keeps the words in its `words` option out of a path's text,
+`zgeoff/no-abbreviated-names` reports each abbreviated value name it lists with its full word, and
 `zgeoff/no-file-snapshot` bans file snapshots.
 
 ## Usage
@@ -106,6 +107,15 @@ the paths that may name the words:
 }
 ```
 
+## `zgeoff/no-abbreviated-names`
+
+The `names` option maps each abbreviation to the text that replaces it, and the rule reports a
+variable, parameter, catch parameter, destructured name, import, property, getter or setter that has
+one of those names. A name matches whole, so `ms` reports `ms` but not `timeoutMs`. A destructured
+key that an alias renames belongs to the object being read, and the rule reports only the alias. The
+shipped config lists the abbreviations that the code-style skill bans and turns on `id-length`
+beside the rule, so a one-letter name fails too, other than `x`, `y`, `z`, `$` and `_`.
+
 ## `zgeoff/no-file-snapshot`
 
 Snapshots are inline only, so the golden value sits in the test that pins it. The rule reports every
@@ -122,17 +132,21 @@ the boundaries between them. A file belongs to every zone its path matches, so z
 Each entry has a `name`, which starts its report, an optional `reason`, which ends it, and optional
 `from` zones and `ignore` globs that limit which importing files it judges.
 
-- `edges` judge an import that resolves to a file: relative, or the package's own name resolved
-  through its `exports` under `conditions` plus `default`. A target in a `to` zone fails unless it
-  is also in an `allow` zone; with `allow` alone, a target in none of the `allow` zones fails, a
-  target in no zone included. `allowTypeOnly` exempts type-only imports (`true`, or globs the target
-  must match), and `allowWithin: "src/*"` exempts an import inside the importer's own `src/<name>/`.
+- `edges` judge an import that resolves to a file: relative, with any bundler query such as `?url`
+  dropped, or the package's own name resolved through its `exports` under `conditions` plus
+  `default`. A target in a `to` zone fails unless it is also in an `allow` zone; with `allow` alone,
+  a target in none of the `allow` zones fails, a target in no zone included. `allowTypeOnly` exempts
+  type-only imports (`true`, or globs the target must match), and `allowWithin: "src/*"` exempts an
+  import inside the importer's own `src/<name>/`.
 - `modules` restrict a package or builtin (`node:` prefix optional, subpaths included) to the
-  `allow` zones; `allowTypeOnly: true` exempts type-only imports.
+  `allow` zones; `allowTypeOnly: true` exempts type-only imports. A name that ends in `*` restricts
+  every specifier that starts with the text before it, such as `@scope/*`, and `node:*` restricts
+  every builtin.
 - `globals` restrict a call to a global, bare or through `globalThis`, `self` or `window`.
 - `unzoned` reports a file in a `from` zone that belongs to none of `zones`.
 - `unresolved` reports a relative or self-referencing import that resolves to no file, and a dynamic
-  `import()` or `require()` whose specifier is computed.
+  `import()`, `require()` or `import.meta.require()` whose specifier is computed. Bun's
+  `import.meta.require` used as a value counts as computed too.
 
 ```jsonc
 {

package/import-zones.js

@@ -1,3 +1,4 @@
+import { isBuiltin } from 'node:module';
 import { relative, sep } from 'node:path';
 import findRepoRoot from './find-repo-root.js';
 import importZonesSchema from './import-zones-schema.js';
@@ -114,12 +115,25 @@ function isRestrictedModule(entry, specifier) {
   const name = toModuleName(specifier);
 
   return entry.modules.some((module) => {
+    if (module.endsWith('*')) {
+      return isPrefixMatch(module.slice(0, -1), specifier);
+    }
+
     const restricted = toModuleName(module);
 
     return name === restricted || name.startsWith(`${restricted}/`);
   });
 }
 
+// `node:*` names every builtin, which a specifier may write without the prefix
+function isPrefixMatch(prefix, specifier) {
+  if (specifier.startsWith(prefix)) {
+    return true;
+  }
+
+  return prefix === 'node:' && isBuiltin(specifier);
+}
+
 function toModuleName(specifier) {
   return specifier.replace(/^node:/u, '');
 }
@@ -235,6 +249,18 @@ function isTypeOnlyExport(node) {
   );
 }
 
+function isImportMetaRequire(node) {
+  return (
+    node.type === 'MemberExpression' &&
+    !node.computed &&
+    node.object.type === 'MetaProperty' &&
+    node.object.meta.name === 'import' &&
+    node.object.property.name === 'meta' &&
+    node.property.type === 'Identifier' &&
+    node.property.name === 'require'
+  );
+}
+
 const importZones = {
   meta: {
     type: 'problem',
@@ -284,10 +310,21 @@ const importZones = {
       CallExpression(node) {
         checkGlobalCall(file, node);
 
-        if (node.callee.type === 'Identifier' && node.callee.name === 'require') {
+        if (
+          (node.callee.type === 'Identifier' && node.callee.name === 'require') ||
+          isImportMetaRequire(node.callee)
+        ) {
           checkImport(file, { node, source: node.arguments[0], typeOnly: false });
         }
       },
+
+      // Bun's import.meta.require used as a value, such as `const load =
+      // import.meta.require`, loads modules no specifier names
+      MemberExpression(node) {
+        if (isImportMetaRequire(node) && node.parent?.callee !== node) {
+          emitUnresolved(file, node, { messageId: 'computed', data: {} });
+        }
+      },
     };
   },
 };

package/no-abbreviated-names.js

@@ -0,0 +1,159 @@
+// each `names` key is a short name and its value the text that replaces it;
+// the rule matches a whole name, so `timeoutMs` passes when `ms` is listed
+const noAbbreviatedNames = {
+  meta: {
+    type: 'suggestion',
+    messages: {
+      abbreviated:
+        'Rename `{{name}}` to {{replacement}}: name a value for what it holds, in full words.',
+    },
+    schema: [
+      {
+        type: 'object',
+        properties: {
+          names: { type: 'object', additionalProperties: { type: 'string', minLength: 1 } },
+        },
+        additionalProperties: false,
+      },
+    ],
+  },
+  create(context) {
+    const names = new Map(Object.entries(context.options[0]?.names ?? {}));
+
+    if (names.size === 0) {
+      return {};
+    }
+
+    const checkName = (node) => {
+      const isName = node?.type === 'Identifier' || node?.type === 'PrivateIdentifier';
+
+      if (!isName || !names.has(node.name)) {
+        return;
+      }
+
+      const prefix = node.type === 'PrivateIdentifier' ? '#' : '';
+
+      context.report({
+        node,
+        messageId: 'abbreviated',
+        data: { name: `${prefix}${node.name}`, replacement: names.get(node.name) },
+      });
+    };
+
+    const checkPattern = (node) => {
+      for (const identifier of collectPatternIdentifiers(node)) {
+        checkName(identifier);
+      }
+    };
+
+    const checkKey = (node) => {
+      if (!node.computed) {
+        checkName(node.key);
+      }
+    };
+
+    const checkParams = (node) => {
+      for (const param of node.params) {
+        checkPattern(param);
+      }
+    };
+
+    return {
+      VariableDeclarator(node) {
+        checkPattern(node.id);
+      },
+      FunctionDeclaration: checkParams,
+      FunctionExpression: checkParams,
+      ArrowFunctionExpression: checkParams,
+
+      // a signature without a body names its parameters as an implementation does
+      TSDeclareFunction: checkParams,
+      TSEmptyBodyFunctionExpression: checkParams,
+      TSFunctionType: checkParams,
+      TSConstructorType: checkParams,
+      TSMethodSignature: checkParams,
+      TSCallSignatureDeclaration: checkParams,
+      TSConstructSignatureDeclaration: checkParams,
+      CatchClause(node) {
+        checkPattern(node.param);
+      },
+      'ObjectExpression > Property': checkKey,
+      PropertyDefinition: checkKey,
+      AccessorProperty: checkKey,
+      TSAbstractPropertyDefinition: checkKey,
+      TSAbstractAccessorProperty: checkKey,
+      TSPropertySignature: checkKey,
+
+      // a getter or setter is read and written as a property, so its key is a
+      // value name
+      "MethodDefinition[kind='get']": checkKey,
+      "MethodDefinition[kind='set']": checkKey,
+      "TSAbstractMethodDefinition[kind='get']": checkKey,
+      "TSAbstractMethodDefinition[kind='set']": checkKey,
+      "TSMethodSignature[kind='get']": checkKey,
+      "TSMethodSignature[kind='set']": checkKey,
+
+      // an import's local binding is a value name in this module, whatever the
+      // exporting module calls it; a type-only import names a type, not a value
+      'ImportSpecifier, ImportDefaultSpecifier, ImportNamespaceSpecifier'(node) {
+        if (!isTypeOnlyImport(node)) {
+          checkName(node.local);
+        }
+      },
+      TSImportEqualsDeclaration(node) {
+        if (node.importKind !== 'type') {
+          checkName(node.id);
+        }
+      },
+      'AssignmentExpression > MemberExpression.left'(node) {
+        if (!node.computed) {
+          checkName(node.property);
+        }
+      },
+    };
+  },
+};
+
+function isTypeOnlyImport(specifier) {
+  return specifier.importKind === 'type' || specifier.parent.importKind === 'type';
+}
+
+// the names a binding pattern declares: a destructured key's alias, not the
+// key, since the key belongs to the object being read
+function collectPatternIdentifiers(node) {
+  if (node === null || node === undefined) {
+    return [];
+  }
+
+  if (node.type === 'Identifier') {
+    return [node];
+  }
+
+  if (node.type === 'ObjectPattern') {
+    return node.properties.flatMap((property) => {
+      const binding = property.type === 'RestElement' ? property : property.value;
+
+      return collectPatternIdentifiers(binding);
+    });
+  }
+
+  if (node.type === 'ArrayPattern') {
+    return node.elements.flatMap((element) => collectPatternIdentifiers(element));
+  }
+
+  if (node.type === 'AssignmentPattern') {
+    return collectPatternIdentifiers(node.left);
+  }
+
+  if (node.type === 'RestElement') {
+    return collectPatternIdentifiers(node.argument);
+  }
+
+  if (node.type === 'TSParameterProperty') {
+    return collectPatternIdentifiers(node.parameter);
+  }
+
+  return [];
+}
+
+export default noAbbreviatedNames;

package/oxlintrc.json

@@ -33,6 +33,35 @@
     "zgeoff/test-beside-module": "error",
     "zgeoff/no-file-snapshot": "error",
 
+    // name a value for what it holds, in full words: one letter only for a
+    // coordinate, zod's `z`, Bun's shell `$` or an unread `_` placeholder, and
+    // each listed abbreviation reported with its full word; both rules read
+    // every binding (destructured aliases and imports included) and every
+    // property key, but a type parameter is not a value, so generics stay
+    // unchecked
+    "id-length": [
+      "error",
+      { "min": 2, "exceptions": ["x", "y", "z", "$", "_"], "checkGeneric": false }
+    ],
+    // oxlintrc.test.ts holds the same names with their full words, and fails
+    // when an entry changes here without it
+    "zgeoff/no-abbreviated-names": [
+      "error",
+      {
+        "names": {
+          "mgr": "`manager`",
+          "dir": "`directory`",
+          "tmp": "`temporary`",
+          "proc": "`process`",
+          "src": "`source`",
+          "dest": "`destination`",
+          "prev": "`previous`",
+          "msg": "`message`",
+          "ms": "a name for the value with `Ms` as its unit suffix, such as `timeoutMs`"
+        }
+      }
+    ],
+
     // enforced comment style — line comments unless JSDoc or exclamation
     "@stylistic/multiline-comment-style": [
       "error",
@@ -114,14 +143,13 @@
     // category-enabled rules that contradict this config's style: inline named
     // export declarations are the convention (group-exports demands the exact
     // form no-bare-named-exports bans), keys group by meaning not alphabet,
-    // comments stay lowercase, short identifiers and literal numbers are fine
+    // comments stay lowercase, and literal numbers are fine
     "import/prefer-default-export": "off",
     "import/no-named-export": "off",
     "import/exports-last": "off",
     "import/group-exports": "off",
     "sort-keys": "off",
     "capitalized-comments": "off",
-    "id-length": "off",
     "no-magic-numbers": "off",
     // prefer-ternary (only-single-line, above) wants ternaries where they fit
     // on one line; no-ternary would ban the same code

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zgeoff/oxlint-config",
-  "version": "0.2.8",
+  "version": "0.2.10",
   "description": "Shareable oxlint config: strict categories, house-style rules, and a custom JS plugin",
   "license": "MIT",
   "repository": {
@@ -13,6 +13,7 @@
     "plugin.js",
     "function-verb.js",
     "no-restricted-words.js",
+    "no-abbreviated-names.js",
     "max-consecutive-line-comments.js",
     "no-jsdoc.js",
     "no-comment-rule-override.js",

package/plugin.js

@@ -1,6 +1,7 @@
 import functionVerb from './function-verb.js';
 import importZones from './import-zones.js';
 import maxConsecutiveLineComments from './max-consecutive-line-comments.js';
+import noAbbreviatedNames from './no-abbreviated-names.js';
 import noCommentRuleOverride from './no-comment-rule-override.js';
 import noFileSnapshot from './no-file-snapshot.js';
 import noJSDoc from './no-jsdoc.js';
@@ -107,6 +108,7 @@ const plugin = {
     'no-comment-rule-override': noCommentRuleOverride,
     'function-verb': functionVerb,
     'no-restricted-words': noRestrictedWords,
+    'no-abbreviated-names': noAbbreviatedNames,
     'test-beside-module': testBesideModule,
     'no-file-snapshot': noFileSnapshot,
     'import-zones': importZones,

package/resolve-import-target.js

@@ -9,7 +9,7 @@ const sourceExtensions = { '.js': ['.ts', '.tsx'], '.mjs': ['.mts'], '.cjs': ['.
 // own name resolves through its `exports`, and `#` names through its `imports`.
 export default function resolveImportTarget(filename, specifier, settings) {
   if (isPathSpecifier(specifier)) {
-    return toTarget(findImportedFile(filename, specifier, settings.extensions));
+    return toTarget(findImportedFile(filename, toFileSpecifier(specifier), settings.extensions));
   }
 
   const manifest = findPackageManifest(dirname(filename), settings.root);
@@ -40,6 +40,13 @@ function resolveManifestTarget(manifest, specifier, conditions) {
   return { kind: 'module', specifier };
 }
 
+// a bundler query such as Vite's `./styles.css?url` names the file before it
+function toFileSpecifier(specifier) {
+  const query = specifier.indexOf('?');
+
+  return query === -1 ? specifier : specifier.slice(0, query);
+}
+
 function toTarget(path) {
   return path === null ? { kind: 'missing' } : { kind: 'file', path };
 }