@zgeoff/oxlint-config 0.2.6 → 0.2.7

package/README.md

@@ -8,7 +8,8 @@ await arguments, awaits hidden inside a control-flow condition or a `&&`/`||`/`?
 `switch` statement, every JSDoc block, any run of more than three line comments, and a repo config
 that loosens either comment rule. `zgeoff/function-verb` enforces the function-naming taxonomy from
 the shared agent guidelines, `zgeoff/test-beside-module` keeps each test file beside the module it
-tests, and `zgeoff/import-zones` fails an import that crosses a module boundary the repo declares.
+tests, `zgeoff/import-zones` fails an import that crosses a module boundary the repo declares, and
+`zgeoff/no-file-snapshot` bans file snapshots.
 
 ## Usage
 
@@ -85,6 +86,15 @@ first statement, so put the comment above it:
 A second test file for a module (`<name>.host.test.ts`) needs its own `<name>.host.<ext>`, so the
 rule reports it beside only `<name>.ts`.
 
+## `zgeoff/no-file-snapshot`
+
+Snapshots are inline only, so the golden value sits in the test that pins it. The rule reports every
+`toMatchSnapshot` and `toThrowErrorMatchingSnapshot`, which write a `.snap` file;
+`toMatchInlineSnapshot` and `toThrowErrorMatchingInlineSnapshot` stay allowed. It also reports a
+linted file that has a `__snapshots__/<file name>.snap` beside it, at the first statement, so a
+file-level disable comment covers it. oxlint never visits a `.snap` file, so a snapshot file whose
+test file is gone is not reported.
+
 ## `zgeoff/import-zones`
 
 Off unless a repo configures it. The options name zones (path globs, relative to the repo root) and

package/no-file-snapshot.js

@@ -0,0 +1,58 @@
+import { statSync } from 'node:fs';
+import { basename, dirname, join } from 'node:path';
+
+// the matchers that write `__snapshots__/<test file>.snap`; their inline
+// counterparts keep the golden value in the test itself
+const fileMatchers = ['toMatchSnapshot', 'toThrowErrorMatchingSnapshot'];
+
+const noFileSnapshot = {
+  meta: {
+    type: 'problem',
+    messages: {
+      matcher:
+        'Replace `{{matcher}}` with its inline form: snapshots are inline only, so the golden value sits in the test.',
+      file: 'Delete `__snapshots__/{{name}}` and pin its values inline: snapshots are inline only, so the golden value sits in the test.',
+    },
+    schema: [],
+  },
+  create(context) {
+    const entries = fileMatchers
+      .flatMap((matcher) => [
+        `MemberExpression[computed=false] > Identifier.property[name='${matcher}']`,
+        `MemberExpression[computed=true] > Literal.property[value='${matcher}']`,
+      ])
+      .map((selector) => [
+        selector,
+        (node) =>
+          context.report({ node, messageId: 'matcher', data: { matcher: getMatcherName(node) } }),
+      ]);
+
+    return {
+      ...Object.fromEntries(entries),
+      Program() {
+        const filename = context.physicalFilename;
+        const name = `${basename(filename)}.snap`;
+
+        if (!isFile(join(dirname(filename), '__snapshots__', name))) {
+          return;
+        }
+
+        // anchor on the first statement, not offset 0, so a disable comment
+        // at the top of the file sits before the report and covers it
+        const start = context.sourceCode.ast.body[0]?.loc.start ?? { line: 1, column: 0 };
+
+        context.report({ loc: { start, end: start }, messageId: 'file', data: { name } });
+      },
+    };
+  },
+};
+
+function getMatcherName(node) {
+  return node.type === 'Identifier' ? node.name : node.value;
+}
+
+function isFile(path) {
+  return statSync(path, { throwIfNoEntry: false })?.isFile() ?? false;
+}
+
+export default noFileSnapshot;

package/oxlintrc.json

@@ -31,6 +31,7 @@
     "zgeoff/no-comment-rule-override": "error",
     "zgeoff/function-verb": "error",
     "zgeoff/test-beside-module": "error",
+    "zgeoff/no-file-snapshot": "error",
 
     // enforced comment style — line comments unless JSDoc or exclamation
     "@stylistic/multiline-comment-style": [

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zgeoff/oxlint-config",
-  "version": "0.2.6",
+  "version": "0.2.7",
   "description": "Shareable oxlint config: strict categories, house-style rules, and a custom JS plugin",
   "license": "MIT",
   "repository": {
@@ -16,6 +16,7 @@
     "no-jsdoc.js",
     "no-comment-rule-override.js",
     "test-beside-module.js",
+    "no-file-snapshot.js",
     "import-zones.js",
     "import-zones-schema.js",
     "find-repo-root.js",
@@ -40,8 +41,8 @@
     "@stylistic/eslint-plugin": "5.10.0"
   },
   "devDependencies": {
-    "@types/bun": "1.3.14",
-    "typescript": "7.0.1-rc"
+    "@types/bun": "1.4.2",
+    "typescript": "7.0.2"
   },
   "peerDependencies": {
     "oxlint": ">=1.78.0"

package/plugin.js

@@ -2,6 +2,7 @@ import functionVerb from './function-verb.js';
 import importZones from './import-zones.js';
 import maxConsecutiveLineComments from './max-consecutive-line-comments.js';
 import noCommentRuleOverride from './no-comment-rule-override.js';
+import noFileSnapshot from './no-file-snapshot.js';
 import noJSDoc from './no-jsdoc.js';
 import testBesideModule from './test-beside-module.js';
 
@@ -105,6 +106,7 @@ const plugin = {
     'no-comment-rule-override': noCommentRuleOverride,
     'function-verb': functionVerb,
     'test-beside-module': testBesideModule,
+    'no-file-snapshot': noFileSnapshot,
     'import-zones': importZones,
   },
 };