@zgeoff/oxlint-config 0.10.2 → 0.10.3
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/build-max-test-timeout.js +7 -24
- package/build-seed-only.js +133 -38
- package/collect-created-tables.js +13 -0
- package/collect-sql-writes.js +1 -1
- package/find-const-initializer.js +15 -0
- package/find-variable.js +11 -0
- package/package.json +4 -1
|
@@ -1,5 +1,7 @@
|
|
|
1
1
|
import { basename } from 'node:path';
|
|
2
2
|
import buildLaneLimits from './build-lane-limits.js';
|
|
3
|
+
import findConstInitializer from './find-const-initializer.js';
|
|
4
|
+
import findVariable from './find-variable.js';
|
|
3
5
|
import getImportedName from './get-imported-name.js';
|
|
4
6
|
import resolveSuiteDirectory from './resolve-suite-directory.js';
|
|
5
7
|
|
|
@@ -103,6 +105,7 @@ function findRunnerName(context, callee) {
|
|
|
103
105
|
|
|
104
106
|
const variable = findVariable(context, current);
|
|
105
107
|
|
|
108
|
+
// a name with no declaration reads the global that `bun test` defines
|
|
106
109
|
if (variable === null) {
|
|
107
110
|
return current.name;
|
|
108
111
|
}
|
|
@@ -124,19 +127,6 @@ function findRunnerName(context, callee) {
|
|
|
124
127
|
return definition.node.type === 'ImportSpecifier' ? getImportedName(definition.node) : null;
|
|
125
128
|
}
|
|
126
129
|
|
|
127
|
-
// a name with no declaration reads the global that `bun test` defines
|
|
128
|
-
function findVariable(context, identifier) {
|
|
129
|
-
for (let scope = context.sourceCode.getScope(identifier); scope !== null; scope = scope.upper) {
|
|
130
|
-
const variable = scope.set.get(identifier.name);
|
|
131
|
-
|
|
132
|
-
if (variable !== undefined && variable.defs.length > 0) {
|
|
133
|
-
return variable;
|
|
134
|
-
}
|
|
135
|
-
}
|
|
136
|
-
|
|
137
|
-
return null;
|
|
138
|
-
}
|
|
139
|
-
|
|
140
130
|
function emitTimeouts(context, args, limit) {
|
|
141
131
|
for (const argument of args) {
|
|
142
132
|
const value = argument.type === 'ObjectExpression' ? findTimeoutValue(argument) : argument;
|
|
@@ -182,16 +172,9 @@ function findNumber(context, node, seen) {
|
|
|
182
172
|
return null;
|
|
183
173
|
}
|
|
184
174
|
|
|
185
|
-
const
|
|
186
|
-
|
|
187
|
-
if (
|
|
188
|
-
definition?.type !== 'Variable' ||
|
|
189
|
-
definition.parent.kind !== 'const' ||
|
|
190
|
-
definition.node.id.type !== 'Identifier' ||
|
|
191
|
-
definition.node.init === null
|
|
192
|
-
) {
|
|
193
|
-
return null;
|
|
194
|
-
}
|
|
175
|
+
const initializer = findConstInitializer(context, node);
|
|
195
176
|
|
|
196
|
-
return
|
|
177
|
+
return initializer === null
|
|
178
|
+
? null
|
|
179
|
+
: findNumber(context, initializer, new Set([...seen, node.name]));
|
|
197
180
|
}
|
package/build-seed-only.js
CHANGED
|
@@ -1,8 +1,8 @@
|
|
|
1
1
|
import { basename, dirname } from 'node:path';
|
|
2
|
+
import collectCreatedTables from './collect-created-tables.js';
|
|
2
3
|
import collectSQLWrites from './collect-sql-writes.js';
|
|
3
4
|
import collectWrittenTables from './collect-written-tables.js';
|
|
4
|
-
import
|
|
5
|
-
import findChainRoot from './find-chain-root.js';
|
|
5
|
+
import findConstInitializer from './find-const-initializer.js';
|
|
6
6
|
import findFunctionName from './find-function-name.js';
|
|
7
7
|
import isInTestUtils from './is-in-test-utils.js';
|
|
8
8
|
import isVerbMatch from './is-verb-match.js';
|
|
@@ -49,44 +49,64 @@ export default function buildSeedOnly(readFolderSources) {
|
|
|
49
49
|
return {};
|
|
50
50
|
}
|
|
51
51
|
|
|
52
|
-
|
|
53
|
-
|
|
52
|
+
// a table the file creates is the test's own, so a write to it counts only once the whole
|
|
53
|
+
// file is read
|
|
54
|
+
const writes = [];
|
|
55
|
+
const createdTables = new Set();
|
|
56
|
+
|
|
57
|
+
const collectText = (node) => {
|
|
58
|
+
const text = toSQLText(context, node, new Set());
|
|
59
|
+
|
|
60
|
+
if (text === null) {
|
|
54
61
|
return;
|
|
55
62
|
}
|
|
56
63
|
|
|
57
|
-
|
|
58
|
-
|
|
59
|
-
|
|
60
|
-
|
|
64
|
+
for (const table of collectSQLWrites(text)) {
|
|
65
|
+
// the statement, not its call, so a disable comment above a statement inside a
|
|
66
|
+
// multi-line call covers it
|
|
67
|
+
writes.push({ node, table });
|
|
68
|
+
}
|
|
69
|
+
|
|
70
|
+
for (const table of collectCreatedTables(text)) {
|
|
71
|
+
createdTables.add(table);
|
|
61
72
|
}
|
|
62
73
|
};
|
|
63
74
|
|
|
64
|
-
const
|
|
65
|
-
if (
|
|
66
|
-
|
|
67
|
-
|
|
68
|
-
|
|
75
|
+
const checkWrite = (write) => {
|
|
76
|
+
if ((kind.inTestUtils && isInSeedFunction(write.node)) || createdTables.has(write.table)) {
|
|
77
|
+
return;
|
|
78
|
+
}
|
|
79
|
+
|
|
80
|
+
if (write.table === null) {
|
|
81
|
+
context.report({ node: write.node, messageId: 'nonLiteral' });
|
|
82
|
+
} else if (!kind.isTest || !readFolderTables(dirname(filename)).has(write.table)) {
|
|
83
|
+
context.report({ node: write.node, messageId: 'write', data: { table: write.table } });
|
|
69
84
|
}
|
|
70
85
|
};
|
|
71
86
|
|
|
72
87
|
return {
|
|
73
88
|
CallExpression(node) {
|
|
74
89
|
if (isKyselyWrite(node)) {
|
|
75
|
-
|
|
90
|
+
writes.push({ node, table: findLiteralTable(node.arguments[0]) });
|
|
91
|
+
} else if (isKyselyCreateTable(node)) {
|
|
92
|
+
const table = findLiteralTable(node.arguments[0]);
|
|
93
|
+
|
|
94
|
+
if (table !== null) {
|
|
95
|
+
createdTables.add(table);
|
|
96
|
+
}
|
|
97
|
+
} else if (isSQLCall(context, node.callee)) {
|
|
98
|
+
collectText(node.arguments[0]);
|
|
76
99
|
}
|
|
77
100
|
},
|
|
78
|
-
|
|
79
|
-
if (
|
|
80
|
-
|
|
101
|
+
TaggedTemplateExpression(node) {
|
|
102
|
+
if (isSQLTag(node.tag)) {
|
|
103
|
+
collectText(node.quasi);
|
|
81
104
|
}
|
|
82
105
|
},
|
|
83
|
-
|
|
84
|
-
const
|
|
85
|
-
|
|
86
|
-
|
|
87
|
-
.join('${}');
|
|
88
|
-
|
|
89
|
-
checkText(node, text);
|
|
106
|
+
'Program:exit'() {
|
|
107
|
+
for (const write of writes) {
|
|
108
|
+
checkWrite(write);
|
|
109
|
+
}
|
|
90
110
|
},
|
|
91
111
|
};
|
|
92
112
|
},
|
|
@@ -109,6 +129,40 @@ function pickFileKind(repoPath, name) {
|
|
|
109
129
|
return isTest || inTestUtils ? { inTestUtils, isTest } : null;
|
|
110
130
|
}
|
|
111
131
|
|
|
132
|
+
// oxlint-disable-next-line no-template-curly-in-string -- marks an interpolation as a module's text shows it
|
|
133
|
+
const interpolation = '${}';
|
|
134
|
+
|
|
135
|
+
function toSQLText(context, node, seen) {
|
|
136
|
+
if (node?.type === 'Literal' && typeof node.value === 'string') {
|
|
137
|
+
return node.value;
|
|
138
|
+
}
|
|
139
|
+
|
|
140
|
+
if (node?.type === 'TemplateLiteral') {
|
|
141
|
+
return node.quasis.map((quasi) => quasi.value.cooked ?? quasi.value.raw).join(interpolation);
|
|
142
|
+
}
|
|
143
|
+
|
|
144
|
+
// a part the rule cannot read stands for an interpolation, so its table name counts as not a
|
|
145
|
+
// string literal
|
|
146
|
+
if (node?.type === 'BinaryExpression' && node.operator === '+') {
|
|
147
|
+
const left = toSQLText(context, node.left, seen);
|
|
148
|
+
const right = toSQLText(context, node.right, seen);
|
|
149
|
+
|
|
150
|
+
return left === null && right === null
|
|
151
|
+
? null
|
|
152
|
+
: `${left ?? interpolation}${right ?? interpolation}`;
|
|
153
|
+
}
|
|
154
|
+
|
|
155
|
+
if (node?.type !== 'Identifier' || seen.has(node.name)) {
|
|
156
|
+
return null;
|
|
157
|
+
}
|
|
158
|
+
|
|
159
|
+
const initializer = findConstInitializer(context, node);
|
|
160
|
+
|
|
161
|
+
return initializer === null
|
|
162
|
+
? null
|
|
163
|
+
: toSQLText(context, initializer, new Set([...seen, node.name]));
|
|
164
|
+
}
|
|
165
|
+
|
|
112
166
|
const functionTypes = new Set([
|
|
113
167
|
'FunctionDeclaration',
|
|
114
168
|
'FunctionExpression',
|
|
@@ -134,20 +188,6 @@ function isInSeedFunction(node) {
|
|
|
134
188
|
return name !== null && isVerbMatch(name.name, 'seed');
|
|
135
189
|
}
|
|
136
190
|
|
|
137
|
-
const testRunnerNames = new Set(['test', 'it', 'describe']);
|
|
138
|
-
|
|
139
|
-
function isTestTitle(context, node) {
|
|
140
|
-
const call = node.parent;
|
|
141
|
-
|
|
142
|
-
if (call?.type !== 'CallExpression' || call.arguments[0] !== node) {
|
|
143
|
-
return false;
|
|
144
|
-
}
|
|
145
|
-
|
|
146
|
-
const root = findChainRoot(call.callee, true);
|
|
147
|
-
|
|
148
|
-
return root !== null && testRunnerNames.has(findBunTestName(context, root));
|
|
149
|
-
}
|
|
150
|
-
|
|
151
191
|
const kyselyWriteMethods = new Set(['insertInto', 'updateTable', 'deleteFrom']);
|
|
152
192
|
|
|
153
193
|
function isKyselyWrite(node) {
|
|
@@ -166,3 +206,58 @@ function findLiteralTable(argument) {
|
|
|
166
206
|
? toTableName(argument.value)
|
|
167
207
|
: null;
|
|
168
208
|
}
|
|
209
|
+
|
|
210
|
+
function isKyselyCreateTable(node) {
|
|
211
|
+
const callee = node.callee;
|
|
212
|
+
|
|
213
|
+
return (
|
|
214
|
+
callee.type === 'MemberExpression' &&
|
|
215
|
+
!callee.computed &&
|
|
216
|
+
callee.property.type === 'Identifier' &&
|
|
217
|
+
callee.property.name === 'createTable'
|
|
218
|
+
);
|
|
219
|
+
}
|
|
220
|
+
|
|
221
|
+
// bun:sqlite and better-sqlite3 run SQL through `run`, `exec`, `query` and `prepare`, Kysely
|
|
222
|
+
// through `sql.raw` and `CompiledQuery.raw`, and postgres.js through `sql(…)` and `sql.unsafe`
|
|
223
|
+
const sqlMethods = new Set(['run', 'exec', 'query', 'prepare', 'raw', 'unsafe']);
|
|
224
|
+
|
|
225
|
+
function isSQLCall(context, callee) {
|
|
226
|
+
if (callee.type === 'Identifier') {
|
|
227
|
+
return callee.name === 'sql';
|
|
228
|
+
}
|
|
229
|
+
|
|
230
|
+
// a regular expression's `exec` takes prose
|
|
231
|
+
return (
|
|
232
|
+
callee.type === 'MemberExpression' &&
|
|
233
|
+
!callee.computed &&
|
|
234
|
+
callee.property.type === 'Identifier' &&
|
|
235
|
+
sqlMethods.has(callee.property.name) &&
|
|
236
|
+
!isRegularExpression(context, callee.object)
|
|
237
|
+
);
|
|
238
|
+
}
|
|
239
|
+
|
|
240
|
+
function isRegularExpression(context, node) {
|
|
241
|
+
if (node.type === 'Identifier') {
|
|
242
|
+
const initializer = findConstInitializer(context, node);
|
|
243
|
+
|
|
244
|
+
return (
|
|
245
|
+
initializer !== null &&
|
|
246
|
+
initializer.type !== 'Identifier' &&
|
|
247
|
+
isRegularExpression(context, initializer)
|
|
248
|
+
);
|
|
249
|
+
}
|
|
250
|
+
|
|
251
|
+
return (
|
|
252
|
+
node.regex !== undefined ||
|
|
253
|
+
((node.type === 'NewExpression' || node.type === 'CallExpression') &&
|
|
254
|
+
node.callee.type === 'Identifier' &&
|
|
255
|
+
node.callee.name === 'RegExp')
|
|
256
|
+
);
|
|
257
|
+
}
|
|
258
|
+
|
|
259
|
+
function isSQLTag(tag) {
|
|
260
|
+
const name = tag.type === 'MemberExpression' && !tag.computed ? tag.property : tag;
|
|
261
|
+
|
|
262
|
+
return name.type === 'Identifier' && name.name === 'sql';
|
|
263
|
+
}
|
|
@@ -0,0 +1,13 @@
|
|
|
1
|
+
import { tablePattern } from './collect-sql-writes.js';
|
|
2
|
+
import toTableName from './to-table-name.js';
|
|
3
|
+
|
|
4
|
+
const createTablePattern = new RegExp(
|
|
5
|
+
String.raw`\bcreate\s+(?:(?:temp|temporary|virtual)\s+)?table\s+(?:if\s+not\s+exists\s+)?${tablePattern}`,
|
|
6
|
+
'giu',
|
|
7
|
+
);
|
|
8
|
+
|
|
9
|
+
export default function collectCreatedTables(text) {
|
|
10
|
+
return [...text.matchAll(createTablePattern)]
|
|
11
|
+
.map((match) => toTableName(match.groups.table))
|
|
12
|
+
.filter((table) => table !== null);
|
|
13
|
+
}
|
package/collect-sql-writes.js
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
import toTableName from './to-table-name.js';
|
|
2
2
|
|
|
3
|
-
const tablePattern = String.raw`(?<table>[^\s(),;'\x60]+)`;
|
|
3
|
+
export const tablePattern = String.raw`(?<table>[^\s(),;'\x60]+)`;
|
|
4
4
|
|
|
5
5
|
const sqlWritePatterns = [
|
|
6
6
|
new RegExp(String.raw`\binsert\s+(?:or\s+[a-z]+\s+)?into\s+${tablePattern}`, 'giu'),
|
|
@@ -0,0 +1,15 @@
|
|
|
1
|
+
import findVariable from './find-variable.js';
|
|
2
|
+
|
|
3
|
+
export default function findConstInitializer(context, identifier) {
|
|
4
|
+
const definition = findVariable(context, identifier)?.defs[0];
|
|
5
|
+
|
|
6
|
+
if (
|
|
7
|
+
definition?.type !== 'Variable' ||
|
|
8
|
+
definition.parent.kind !== 'const' ||
|
|
9
|
+
definition.node.id.type !== 'Identifier'
|
|
10
|
+
) {
|
|
11
|
+
return null;
|
|
12
|
+
}
|
|
13
|
+
|
|
14
|
+
return definition.node.init;
|
|
15
|
+
}
|
package/find-variable.js
ADDED
|
@@ -0,0 +1,11 @@
|
|
|
1
|
+
export default function findVariable(context, identifier) {
|
|
2
|
+
for (let scope = context.sourceCode.getScope(identifier); scope !== null; scope = scope.upper) {
|
|
3
|
+
const variable = scope.set.get(identifier.name);
|
|
4
|
+
|
|
5
|
+
if (variable !== undefined && variable.defs.length > 0) {
|
|
6
|
+
return variable;
|
|
7
|
+
}
|
|
8
|
+
}
|
|
9
|
+
|
|
10
|
+
return null;
|
|
11
|
+
}
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@zgeoff/oxlint-config",
|
|
3
|
-
"version": "0.10.
|
|
3
|
+
"version": "0.10.3",
|
|
4
4
|
"description": "Shareable oxlint config: strict categories, house-style rules, and a custom JS plugin",
|
|
5
5
|
"license": "MIT",
|
|
6
6
|
"repository": {
|
|
@@ -76,6 +76,9 @@
|
|
|
76
76
|
"read-folder-sources.js",
|
|
77
77
|
"collect-written-tables.js",
|
|
78
78
|
"collect-sql-writes.js",
|
|
79
|
+
"collect-created-tables.js",
|
|
80
|
+
"find-const-initializer.js",
|
|
81
|
+
"find-variable.js",
|
|
79
82
|
"to-table-name.js",
|
|
80
83
|
"resolve-repo-path.js",
|
|
81
84
|
"is-in-test-utils.js",
|