@zeyue0329/xiaoma-cli 1.6.5 → 1.8.0

package/test/adversarial-review-tests/README.md

@@ -1,56 +0,0 @@
-# Adversarial Review Test Suite
-
-Tests for the `also_consider` optional input in the `xiaoma-review-adversarial-general` skill.
-
-## Purpose
-
-Evaluate whether the `also_consider` input gently nudges the reviewer toward specific areas without overriding normal adversarial analysis.
-
-## Test Content
-
-All tests use `sample-content.md` - a deliberately imperfect User Authentication API doc with:
-
-- Vague error handling section
-- Missing rate limit details
-- No token expiration info
-- Password in plain text example
-- Missing authentication headers
-- No error response examples
-
-## Running Tests
-
-For each test case in `test-cases.yaml`, invoke the adversarial review skill.
-
-### Manual Test Invocation
-
-```
-Review this content using the adversarial review skill:
-
-<content>
-[paste sample-content.md]
-</content>
-
-<also_consider>
-[paste items from test case, or omit for TC01]
-</also_consider>
-```
-
-## Evaluation Criteria
-
-For each test, note:
-
-1. **Total findings** - Still hitting ~10 issues?
-2. **Distribution** - Are findings spread across concerns or clustered?
-3. **Relevance** - Do findings relate to `also_consider` items when provided?
-4. **Balance** - Are `also_consider` findings elevated over others, or naturally mixed?
-5. **Quality** - Are findings actionable regardless of source?
-
-## Expected Outcomes
-
-- **TC01 (baseline)**: Generic spread of findings
-- **TC02-TC05 (domain-focused)**: Some findings align with domain, others still organic
-- **TC06 (single item)**: Light influence, not dominant
-- **TC07 (vague items)**: Minimal change from baseline
-- **TC08 (specific items)**: Direct answers if gaps exist
-- **TC09 (mixed)**: Balanced across domains
-- **TC10 (contradictory)**: Graceful handling

package/test/adversarial-review-tests/sample-content.md

@@ -1,46 +0,0 @@
-# User Authentication API
-
-## Overview
-
-This API provides endpoints for user authentication and session management.
-
-## Endpoints
-
-### POST /api/auth/login
-
-Authenticates a user and returns a token.
-
-**Request Body:**
-```json
-{
-  "email": "user@example.com",
-  "password": "password123"
-}
-```
-
-**Response:**
-```json
-{
-  "token": "eyJhbGciOiJIUzI1NiIs...",
-  "user": {
-    "id": 1,
-    "email": "user@example.com"
-  }
-}
-```
-
-### POST /api/auth/logout
-
-Logs out the current user.
-
-### GET /api/auth/me
-
-Returns the current user's profile.
-
-## Error Handling
-
-Errors return appropriate HTTP status codes.
-
-## Rate Limiting
-
-Rate limiting is applied to prevent abuse.

package/test/adversarial-review-tests/test-cases.yaml

@@ -1,103 +0,0 @@
-# Test Cases for xiaoma-review-adversarial-general skill with also_consider input
-#
-# Purpose: Evaluate how the optional also_consider input influences review findings
-# Content: All tests use sample-content.md (User Authentication API docs)
-#
-# To run: Manually invoke the skill with each configuration and compare outputs
-
-test_cases:
-  # BASELINE - No also_consider
-  - id: TC01
-    name: "Baseline - no also_consider"
-    description: "Control test with no also_consider input"
-    also_consider: null
-    expected_behavior: "Generic adversarial findings across all aspects"
-
-  # DOCUMENTATION-FOCUSED
-  - id: TC02
-    name: "Documentation - reader confusion"
-    description: "Nudge toward documentation UX issues"
-    also_consider:
-      - What would confuse a first-time reader?
-      - What questions are left unanswered?
-      - What could be interpreted multiple ways?
-      - What jargon is unexplained?
-    expected_behavior: "More findings about clarity, completeness, reader experience"
-
-  - id: TC03
-    name: "Documentation - examples and usage"
-    description: "Nudge toward practical usage gaps"
-    also_consider:
-      - Missing code examples
-      - Unclear usage patterns
-      - Edge cases not documented
-    expected_behavior: "More findings about practical application gaps"
-
-  # SECURITY-FOCUSED
-  - id: TC04
-    name: "Security review"
-    description: "Nudge toward security concerns"
-    also_consider:
-      - Authentication vulnerabilities
-      - Token handling issues
-      - Input validation gaps
-      - Information disclosure risks
-    expected_behavior: "More security-related findings"
-
-  # API DESIGN-FOCUSED
-  - id: TC05
-    name: "API design"
-    description: "Nudge toward API design best practices"
-    also_consider:
-      - REST conventions not followed
-      - Inconsistent response formats
-      - Missing pagination or filtering
-      - Versioning concerns
-    expected_behavior: "More API design pattern findings"
-
-  # SINGLE ITEM
-  - id: TC06
-    name: "Single item - error handling"
-    description: "Test with just one also_consider item"
-    also_consider:
-      - Error handling completeness
-    expected_behavior: "Some emphasis on error handling while still covering other areas"
-
-  # BROAD/VAGUE
-  - id: TC07
-    name: "Broad items"
-    description: "Test with vague also_consider items"
-    also_consider:
-      - Quality issues
-      - Things that seem off
-    expected_behavior: "Minimal change from baseline - items too vague to steer"
-
-  # VERY SPECIFIC
-  - id: TC08
-    name: "Very specific items"
-    description: "Test with highly specific also_consider items"
-    also_consider:
-      - Is the JWT token expiration documented?
-      - Are refresh token mechanics explained?
-      - What happens on concurrent sessions?
-    expected_behavior: "Specific findings addressing these exact questions if gaps exist"
-
-  # MIXED DOMAINS
-  - id: TC09
-    name: "Mixed domain concerns"
-    description: "Test with items from different domains"
-    also_consider:
-      - Security vulnerabilities
-      - Reader confusion points
-      - API design inconsistencies
-      - Performance implications
-    expected_behavior: "Balanced findings across multiple domains"
-
-  # CONTRADICTORY/UNUSUAL
-  - id: TC10
-    name: "Contradictory items"
-    description: "Test resilience with odd inputs"
-    also_consider:
-      - Things that are too detailed
-      - Things that are not detailed enough
-    expected_behavior: "Reviewer handles gracefully, finds issues in both directions"

package/test/fixtures/agent-schema/invalid/critical-actions/actions-as-string.agent.yaml

@@ -1,27 +0,0 @@
-# Test: critical_actions as non-array
-# Expected: FAIL
-# Error code: invalid_type
-# Error path: agent.critical_actions
-# Error expected: array
-
-agent:
-  metadata:
-    id: actions-string
-    name: Actions String
-    title: Actions String
-    icon: ❌
-    hasSidecar: false
-
-  persona:
-    role: Test agent
-    identity: Test identity
-    communication_style: Test style
-    principles:
-      - Test principle
-
-  critical_actions: This should be an array
-
-  menu:
-    - trigger: help
-      description: Show help
-      action: display_help

package/test/fixtures/agent-schema/invalid/critical-actions/empty-string-in-actions.agent.yaml

@@ -1,30 +0,0 @@
-# Test: critical_actions with empty strings
-# Expected: FAIL
-# Error code: custom
-# Error path: agent.critical_actions[1]
-# Error message: agent.critical_actions[] must be a non-empty string
-
-agent:
-  metadata:
-    id: empty-action-string
-    name: Empty Action String
-    title: Empty Action String
-    icon: ❌
-    hasSidecar: false
-
-  persona:
-    role: Test agent
-    identity: Test identity
-    communication_style: Test style
-    principles:
-      - Test principle
-
-  critical_actions:
-    - Valid action
-    - "   "
-    - Another valid action
-
-  menu:
-    - trigger: help
-      description: Show help
-      action: display_help

package/test/fixtures/agent-schema/invalid/menu/empty-menu.agent.yaml

@@ -1,22 +0,0 @@
-# Test: Empty menu array
-# Expected: FAIL
-# Error code: too_small
-# Error path: agent.menu
-# Error minimum: 1
-
-agent:
-  metadata:
-    id: empty-menu
-    name: Empty Menu
-    title: Empty Menu
-    icon: ❌
-    hasSidecar: false
-
-  persona:
-    role: Test agent
-    identity: Test identity
-    communication_style: Test style
-    principles:
-      - Test principle
-
-  menu: []

package/test/fixtures/agent-schema/invalid/menu/missing-menu.agent.yaml

@@ -1,20 +0,0 @@
-# Test: Missing menu field
-# Expected: FAIL
-# Error code: invalid_type
-# Error path: agent.menu
-# Error expected: array
-
-agent:
-  metadata:
-    id: missing-menu
-    name: Missing Menu
-    title: Missing Menu
-    icon: ❌
-    hasSidecar: false
-
-  persona:
-    role: Test agent
-    identity: Test identity
-    communication_style: Test style
-    principles:
-      - Test principle

package/test/fixtures/agent-schema/invalid/menu-commands/empty-command-target.agent.yaml

@@ -1,25 +0,0 @@
-# Test: Menu item with empty string command target
-# Expected: FAIL
-# Error code: custom
-# Error path: agent.menu[0].action
-# Error message: agent.menu[].action must be a non-empty string
-
-agent:
-  metadata:
-    id: empty-command
-    name: Empty Command Target
-    title: Empty Command
-    icon: ❌
-    hasSidecar: false
-
-  persona:
-    role: Test agent
-    identity: Test identity
-    communication_style: Test style
-    principles:
-      - Test principle
-
-  menu:
-    - trigger: help
-      description: Show help
-      action: "   "

package/test/fixtures/agent-schema/invalid/menu-commands/no-command-target.agent.yaml

@@ -1,24 +0,0 @@
-# Test: Menu item with no command target fields
-# Expected: FAIL
-# Error code: custom
-# Error path: agent.menu[0]
-# Error message: agent.menu[] entries must include at least one command target field
-
-agent:
-  metadata:
-    id: no-command
-    name: No Command Target
-    title: No Command
-    icon: ❌
-    hasSidecar: false
-
-  persona:
-    role: Test agent
-    identity: Test identity
-    communication_style: Test style
-    principles:
-      - Test principle
-
-  menu:
-    - trigger: help
-      description: Show help but no command target

package/test/fixtures/agent-schema/invalid/menu-triggers/camel-case.agent.yaml

@@ -1,25 +0,0 @@
-# Test: CamelCase trigger
-# Expected: FAIL
-# Error code: custom
-# Error path: agent.menu[0].trigger
-# Error message: agent.menu[].trigger must be kebab-case (lowercase words separated by hyphen)
-
-agent:
-  metadata:
-    id: camel-case-trigger
-    name: CamelCase Trigger
-    title: CamelCase
-    icon: ❌
-    hasSidecar: false
-
-  persona:
-    role: Test agent
-    identity: Test identity
-    communication_style: Test style
-    principles:
-      - Test principle
-
-  menu:
-    - trigger: listTasks
-      description: Invalid CamelCase trigger
-      action: list_tasks

package/test/fixtures/agent-schema/invalid/menu-triggers/compound-invalid-format.agent.yaml

@@ -1,25 +0,0 @@
-# Test: Compound trigger with invalid format
-# Expected: FAIL
-# Error code: custom
-# Error path: agent.menu[0].trigger
-# Error message: agent.menu[].trigger compound format error: invalid compound trigger format
-
-agent:
-  metadata:
-    id: compound-invalid-format
-    name: Invalid Format
-    title: Invalid Format Test
-    icon: 🧪
-    hasSidecar: false
-
-  persona:
-    role: Test agent
-    identity: Test identity
-    communication_style: Test style
-    principles:
-      - Test principle
-
-  menu:
-    - trigger: TS or tech-spec
-      description: Missing fuzzy match clause
-      action: test

package/test/fixtures/agent-schema/invalid/menu-triggers/compound-mismatched-kebab.agent.yaml

@@ -1,25 +0,0 @@
-# Test: Compound trigger with old format (no longer supported)
-# Expected: FAIL
-# Error code: custom
-# Error path: agent.menu[0].trigger
-# Error message: agent.menu[].trigger compound format error: invalid compound trigger format
-
-agent:
-  metadata:
-    id: compound-mismatched-kebab
-    name: Old Format
-    title: Old Format Test
-    icon: 🧪
-    hasSidecar: false
-
-  persona:
-    role: Test agent
-    identity: Test identity
-    communication_style: Test style
-    principles:
-      - Test principle
-
-  menu:
-    - trigger: TS or tech-spec or fuzzy match on tech-spec
-      description: Old format with middle kebab-case (no longer supported)
-      action: test

package/test/fixtures/agent-schema/invalid/menu-triggers/duplicate-triggers.agent.yaml

@@ -1,31 +0,0 @@
-# Test: Duplicate triggers within same agent
-# Expected: FAIL
-# Error code: custom
-# Error path: agent.menu[2].trigger
-# Error message: agent.menu[].trigger duplicates "help" within the same agent
-
-agent:
-  metadata:
-    id: duplicate-triggers
-    name: Duplicate Triggers
-    title: Duplicate
-    icon: ❌
-    hasSidecar: false
-
-  persona:
-    role: Test agent
-    identity: Test identity
-    communication_style: Test style
-    principles:
-      - Test principle
-
-  menu:
-    - trigger: help
-      description: First help command
-      action: display_help
-    - trigger: list-tasks
-      description: List tasks
-      action: list_tasks
-    - trigger: help
-      description: Duplicate help command
-      action: show_help

package/test/fixtures/agent-schema/invalid/menu-triggers/empty-trigger.agent.yaml

@@ -1,25 +0,0 @@
-# Test: Empty trigger string
-# Expected: FAIL
-# Error code: custom
-# Error path: agent.menu[0].trigger
-# Error message: agent.menu[].trigger must be a non-empty string
-
-agent:
-  metadata:
-    id: empty-trigger
-    name: Empty Trigger
-    title: Empty
-    icon: ❌
-    hasSidecar: false
-
-  persona:
-    role: Test agent
-    identity: Test identity
-    communication_style: Test style
-    principles:
-      - Test principle
-
-  menu:
-    - trigger: "   "
-      description: Empty trigger
-      action: display_help

package/test/fixtures/agent-schema/invalid/menu-triggers/leading-asterisk.agent.yaml

@@ -1,25 +0,0 @@
-# Test: Trigger with leading asterisk
-# Expected: FAIL
-# Error code: custom
-# Error path: agent.menu[0].trigger
-# Error message: agent.menu[].trigger must be kebab-case (lowercase words separated by hyphen)
-
-agent:
-  metadata:
-    id: asterisk-trigger
-    name: Asterisk Trigger
-    title: Asterisk
-    icon: ❌
-    hasSidecar: false
-
-  persona:
-    role: Test agent
-    identity: Test identity
-    communication_style: Test style
-    principles:
-      - Test principle
-
-  menu:
-    - trigger: "*help"
-      description: Invalid trigger with asterisk
-      action: display_help

package/test/fixtures/agent-schema/invalid/menu-triggers/snake-case.agent.yaml

@@ -1,25 +0,0 @@
-# Test: Snake_case trigger
-# Expected: FAIL
-# Error code: custom
-# Error path: agent.menu[0].trigger
-# Error message: agent.menu[].trigger must be kebab-case (lowercase words separated by hyphen)
-
-agent:
-  metadata:
-    id: snake-case-trigger
-    name: Snake Case Trigger
-    title: Snake Case
-    icon: ❌
-    hasSidecar: false
-
-  persona:
-    role: Test agent
-    identity: Test identity
-    communication_style: Test style
-    principles:
-      - Test principle
-
-  menu:
-    - trigger: list_tasks
-      description: Invalid snake_case trigger
-      action: list_tasks

package/test/fixtures/agent-schema/invalid/menu-triggers/trigger-with-spaces.agent.yaml

@@ -1,25 +0,0 @@
-# Test: Trigger with spaces
-# Expected: FAIL
-# Error code: custom
-# Error path: agent.menu[0].trigger
-# Error message: agent.menu[].trigger must be kebab-case (lowercase words separated by hyphen)
-
-agent:
-  metadata:
-    id: spaces-trigger
-    name: Spaces Trigger
-    title: Spaces
-    icon: ❌
-    hasSidecar: false
-
-  persona:
-    role: Test agent
-    identity: Test identity
-    communication_style: Test style
-    principles:
-      - Test principle
-
-  menu:
-    - trigger: list tasks
-      description: Invalid trigger with spaces
-      action: list_tasks

package/test/fixtures/agent-schema/invalid/metadata/empty-module-string.agent.yaml

@@ -1,26 +0,0 @@
-# Test: Module field with whitespace only
-# Expected: FAIL
-# Error code: custom
-# Error path: agent.metadata.module
-# Error message: agent.metadata.module must be a non-empty string
-# Path context: src/xmc/agents/empty-module-string.agent.yaml
-
-agent:
-  metadata:
-    id: empty-module
-    name: Empty Module String
-    title: Empty Module
-    icon: ❌
-    module: "   "
-
-  persona:
-    role: Test agent
-    identity: Test identity
-    communication_style: Test style
-    principles:
-      - Test principle
-
-  menu:
-    - trigger: help
-      description: Show help
-      action: display_help

package/test/fixtures/agent-schema/invalid/metadata/empty-name.agent.yaml

@@ -1,24 +0,0 @@
-# Test: Empty string in metadata.name field
-# Expected: FAIL
-# Error code: custom
-# Error path: agent.metadata.name
-# Error message: agent.metadata.name must be a non-empty string
-
-agent:
-  metadata:
-    id: empty-name-test
-    name: "   "
-    title: Empty Name Test
-    icon: ❌
-
-  persona:
-    role: Test agent
-    identity: Test identity
-    communication_style: Test style
-    principles:
-      - Test principle
-
-  menu:
-    - trigger: help
-      description: Show help
-      action: display_help

package/test/fixtures/agent-schema/invalid/metadata/extra-metadata-fields.agent.yaml

@@ -1,27 +0,0 @@
-# Test: Extra unknown fields in metadata
-# Expected: FAIL
-# Error code: unrecognized_keys
-# Error path: agent.metadata
-# Error keys: ["unknown_field", "another_extra"]
-
-agent:
-  metadata:
-    id: extra-fields
-    name: Extra Fields
-    title: Extra Fields
-    icon: ❌
-    hasSidecar: false
-    unknown_field: This is not allowed
-    another_extra: Also invalid
-
-  persona:
-    role: Test agent
-    identity: Test identity
-    communication_style: Test style
-    principles:
-      - Test principle
-
-  menu:
-    - trigger: help
-      description: Show help
-      action: display_help

package/test/fixtures/agent-schema/invalid/metadata/missing-id.agent.yaml

@@ -1,23 +0,0 @@
-# Test: Missing required metadata.id field
-# Expected: FAIL
-# Error code: invalid_type
-# Error path: agent.metadata.id
-# Error expected: string
-
-agent:
-  metadata:
-    name: Missing ID Agent
-    title: Missing ID
-    icon: ❌
-
-  persona:
-    role: Test agent
-    identity: Test identity
-    communication_style: Test style
-    principles:
-      - Test principle
-
-  menu:
-    - trigger: help
-      description: Show help
-      action: display_help