@zereight/mcp-gitlab 2.1.70 → 2.2.0

package/build/test/stateless/client-id.test.js

@@ -1,177 +0,0 @@
-/**
- * Integration tests for the stateless `client_id` DCR path.
- *
- * The key cross-pod claim is that two GitLabOAuthServerProvider instances,
- * sharing only OAUTH_STATELESS_SECRET, can successfully issue a client_id on
- * one and validate it on the other — matching the scenario where a Kubernetes
- * load balancer routes POST /register to pod A and GET /authorize to pod B.
- */
-import assert from "node:assert/strict";
-import { randomBytes } from "node:crypto";
-import { describe, test } from "node:test";
-import { createGitLabOAuthProvider } from "../../oauth-proxy.js";
-import { mintClientId, openClientId, looksLikeStatelessClientId, } from "../../stateless/client-id.js";
-import { loadKeyMaterialFromEnv } from "../../stateless/index.js";
-// ---------------------------------------------------------------------------
-// Helpers
-// ---------------------------------------------------------------------------
-function secret() {
-    return randomBytes(32).toString("base64url");
-}
-function loadMaterial(current, previous) {
-    const env = {
-        OAUTH_STATELESS_SECRET: current,
-    };
-    if (previous)
-        env.OAUTH_STATELESS_SECRET_PREVIOUS = previous;
-    const m = loadKeyMaterialFromEnv(true, env);
-    assert.ok(m, "expected material to load");
-    return m;
-}
-function makeProvider(material, { callbackProxy = false } = {}) {
-    return createGitLabOAuthProvider("https://gitlab.example.com", "real-gitlab-app-id", "GitLab MCP Server (test)", false, // readOnly
-    undefined, // customScopes
-    undefined, // allowedGroups
-    callbackProxy, callbackProxy ? "https://mcp.example.com/callback" : "", material
-        ? {
-            material,
-            clientTtlSeconds: 86400,
-            pendingTtlSeconds: 600,
-            storedTtlSeconds: 600,
-        }
-        : null);
-}
-// ---------------------------------------------------------------------------
-// mint / open helpers (direct)
-// ---------------------------------------------------------------------------
-describe("mintClientId / openClientId", () => {
-    test("roundtrips redirect_uris", () => {
-        const m = loadMaterial(secret());
-        const cid = mintClientId(m, {
-            redirectUris: ["https://client.example.com/cb"],
-            grantTypes: ["authorization_code"],
-            clientName: "Test Client",
-        });
-        assert.ok(looksLikeStatelessClientId(cid));
-        const p = openClientId(m, cid, 86400);
-        assert.ok(p);
-        assert.deepEqual(p.ruris, ["https://client.example.com/cb"]);
-        assert.deepEqual(p.gt, ["authorization_code"]);
-        assert.equal(p.cn, "Test Client");
-    });
-    test("openClientId returns null on signature error", () => {
-        const m1 = loadMaterial(secret());
-        const m2 = loadMaterial(secret()); // different secret entirely
-        const cid = mintClientId(m1, {
-            redirectUris: ["https://client.example.com/cb"],
-        });
-        assert.equal(openClientId(m2, cid, 86400), null);
-    });
-    test("openClientId returns null when expired", () => {
-        const m = loadMaterial(secret());
-        // Mint at t-3600
-        const past = Math.floor(Date.now() / 1000) - 3600;
-        const cid = mintClientId(m, {
-            redirectUris: ["https://client.example.com/cb"],
-            now: () => past,
-        });
-        // TTL = 60s ⇒ expired
-        assert.equal(openClientId(m, cid, 60), null);
-    });
-    test("rotation: cid minted under previous secret still opens", () => {
-        const s1 = secret();
-        const s2 = secret();
-        const mOld = loadMaterial(s1);
-        const cid = mintClientId(mOld, {
-            redirectUris: ["https://client.example.com/cb"],
-        });
-        // Operator rotated: new is current, old is previous.
-        const mRotated = loadMaterial(s2, s1);
-        assert.ok(openClientId(mRotated, cid, 86400));
-    });
-});
-// ---------------------------------------------------------------------------
-// clientsStore end-to-end across two provider instances (cross-pod)
-// ---------------------------------------------------------------------------
-describe("clientsStore cross-pod (stateless)", () => {
-    test("register on pod A ⇒ getClient succeeds on pod B", async () => {
-        const sharedSecret = secret();
-        const podA = makeProvider(loadMaterial(sharedSecret));
-        const podB = makeProvider(loadMaterial(sharedSecret));
-        // Register on A
-        const registered = await podA.clientsStore.registerClient({
-            redirect_uris: ["https://client.example.com/cb"],
-            token_endpoint_auth_method: "none",
-        });
-        assert.ok(looksLikeStatelessClientId(registered.client_id));
-        assert.deepEqual(registered.redirect_uris, ["https://client.example.com/cb"]);
-        // Lookup on B — no shared memory, only shared secret
-        const looked = await podB.clientsStore.getClient(registered.client_id);
-        assert.ok(looked, "B should resolve the signed client_id");
-        assert.equal(looked.client_id, registered.client_id);
-        assert.deepEqual(looked.redirect_uris, ["https://client.example.com/cb"]);
-        // token_endpoint_auth_method defaults to "none" for DCR
-        assert.equal(looked.token_endpoint_auth_method, "none");
-    });
-    test("getClient on pod B with different secret rejects the client_id", async () => {
-        const podA = makeProvider(loadMaterial(secret()));
-        const podB = makeProvider(loadMaterial(secret())); // different secret
-        const registered = await podA.clientsStore.registerClient({
-            redirect_uris: ["https://client.example.com/cb"],
-            token_endpoint_auth_method: "none",
-        });
-        const looked = await podB.clientsStore.getClient(registered.client_id);
-        assert.equal(looked, undefined);
-    });
-    test("non-stateless provider falls back to legacy cache path", async () => {
-        // Simulating a pod with stateless mode OFF — it should keep working
-        // against its own in-memory cache.
-        const provider = makeProvider(null);
-        const registered = await provider.clientsStore.registerClient({
-            redirect_uris: ["https://client.example.com/cb"],
-            token_endpoint_auth_method: "none",
-        });
-        // Legacy mode uses UUID client_ids, not stateless v1.cid.*
-        assert.ok(!looksLikeStatelessClientId(registered.client_id));
-        const looked = await provider.clientsStore.getClient(registered.client_id);
-        assert.ok(looked);
-        assert.deepEqual(looked.redirect_uris, ["https://client.example.com/cb"]);
-    });
-    test("legacy client_id is unchanged in stateless mode (e.g. pre-existing GitLab app uid)", async () => {
-        // A caller that passes a non-stateless client_id should receive the
-        // legacy stub so unrelated flows (like token exchange with a pre-registered
-        // GitLab app) continue to work.
-        const provider = makeProvider(loadMaterial(secret()));
-        const looked = await provider.clientsStore.getClient("legacy-app-id");
-        assert.ok(looked);
-        assert.equal(looked.client_id, "legacy-app-id");
-        // Stub has empty redirect_uris — the caller's code path must tolerate this.
-        assert.deepEqual(looked.redirect_uris, []);
-    });
-    test("rotation: client_id minted on pod-old verifies on pod-rotated", async () => {
-        const s1 = secret();
-        const s2 = secret();
-        const podOld = makeProvider(loadMaterial(s1));
-        const podRotated = makeProvider(loadMaterial(s2, s1));
-        const registered = await podOld.clientsStore.registerClient({
-            redirect_uris: ["https://client.example.com/cb"],
-            token_endpoint_auth_method: "none",
-        });
-        const looked = await podRotated.clientsStore.getClient(registered.client_id);
-        assert.ok(looked);
-        assert.deepEqual(looked.redirect_uris, ["https://client.example.com/cb"]);
-    });
-    test("long redirect_uri list roundtrips", async () => {
-        const sharedSecret = secret();
-        const podA = makeProvider(loadMaterial(sharedSecret));
-        const podB = makeProvider(loadMaterial(sharedSecret));
-        const ruris = Array.from({ length: 5 }, (_, i) => `https://client.example.com/cb-${i}`);
-        const registered = await podA.clientsStore.registerClient({
-            redirect_uris: ruris,
-            token_endpoint_auth_method: "none",
-        });
-        const looked = await podB.clientsStore.getClient(registered.client_id);
-        assert.ok(looked);
-        assert.deepEqual(looked.redirect_uris, ruris);
-    });
-});

package/build/test/stateless/codec.test.js

@@ -1,328 +0,0 @@
-/**
- * Unit tests for the stateless token codec.
- *
- * Covers:
- * - secret loading from env (valid, missing, malformed, rotation)
- * - HKDF subkey derivation (purpose isolation)
- * - sign / verify roundtrip (happy path, tamper, TTL, purpose mismatch)
- * - seal / open roundtrip (happy path, tamper, TTL, purpose mismatch)
- * - rotation: values minted under previous secret still verify
- */
-import assert from "node:assert/strict";
-import { randomBytes, createHmac } from "node:crypto";
-import { describe, test } from "node:test";
-import { open, seal, sign, verify, STATELESS_PURPOSES, StatelessCodecError, StatelessConfigError, decodeSecret, deriveSubkey, deriveSubkeys, loadKeyMaterialFromEnv, } from "../../stateless/index.js";
-// ---------------------------------------------------------------------------
-// Helpers
-// ---------------------------------------------------------------------------
-/** Generate a 32-byte secret string as an operator would. */
-function genSecret() {
-    return randomBytes(32).toString("base64url");
-}
-function buildMaterial(current, previous) {
-    const env = {
-        OAUTH_STATELESS_SECRET: current ?? genSecret(),
-    };
-    if (previous)
-        env.OAUTH_STATELESS_SECRET_PREVIOUS = previous;
-    const material = loadKeyMaterialFromEnv(true, env);
-    assert.ok(material, "material should load");
-    return material;
-}
-function dummyPayload(now = Math.floor(Date.now() / 1000)) {
-    return { v: 1, iat: now, hello: "world" };
-}
-// ---------------------------------------------------------------------------
-// loadKeyMaterialFromEnv
-// ---------------------------------------------------------------------------
-describe("loadKeyMaterialFromEnv", () => {
-    test("returns null when mode disabled", () => {
-        // `enabled=false` short-circuits regardless of env contents.
-        assert.equal(loadKeyMaterialFromEnv(false, {}), null);
-        assert.equal(loadKeyMaterialFromEnv(false, { OAUTH_STATELESS_SECRET: genSecret() }), null);
-    });
-    test("ignores env.OAUTH_STATELESS_MODE — enablement is caller-resolved", () => {
-        // The loader must not re-parse the raw env var; the resolved config flag
-        // (which honors the CLI --oauth-stateless-mode) is the single source of
-        // truth. Regression guard for the silent fallback-to-per-pod bug when
-        // stateless mode was enabled only via CLI.
-        const secret = genSecret();
-        // enabled=true with no env.OAUTH_STATELESS_MODE set → still loads.
-        const m = loadKeyMaterialFromEnv(true, { OAUTH_STATELESS_SECRET: secret });
-        assert.ok(m, "loader must not require env.OAUTH_STATELESS_MODE");
-        // enabled=false with env.OAUTH_STATELESS_MODE=true → still null.
-        assert.equal(loadKeyMaterialFromEnv(false, {
-            OAUTH_STATELESS_MODE: "true",
-            OAUTH_STATELESS_SECRET: secret,
-        }), null);
-    });
-    test("throws when mode enabled but secret missing", () => {
-        assert.throws(() => loadKeyMaterialFromEnv(true, {}), StatelessConfigError);
-    });
-    test("throws on too-short secret", () => {
-        assert.throws(() => loadKeyMaterialFromEnv(true, {
-            OAUTH_STATELESS_SECRET: Buffer.from("short").toString("base64url"),
-        }), StatelessConfigError);
-    });
-    test("loads current only", () => {
-        const m = loadKeyMaterialFromEnv(true, {
-            OAUTH_STATELESS_SECRET: genSecret(),
-        });
-        assert.ok(m);
-        assert.equal(m.previous, undefined);
-    });
-    test("loads current + previous", () => {
-        const m = loadKeyMaterialFromEnv(true, {
-            OAUTH_STATELESS_SECRET: genSecret(),
-            OAUTH_STATELESS_SECRET_PREVIOUS: genSecret(),
-        });
-        assert.ok(m);
-        assert.equal(m.current.length, 32);
-        assert.equal(m.previous.length, 32);
-    });
-    test("rejects malformed base64url previous", () => {
-        assert.throws(() => loadKeyMaterialFromEnv(true, {
-            OAUTH_STATELESS_SECRET: genSecret(),
-            OAUTH_STATELESS_SECRET_PREVIOUS: "!!!not-base64!!!",
-        }), StatelessConfigError);
-    });
-});
-// ---------------------------------------------------------------------------
-// decodeSecret direct
-// ---------------------------------------------------------------------------
-describe("decodeSecret", () => {
-    test("rejects empty", () => {
-        assert.throws(() => decodeSecret("   ", "X"), StatelessConfigError);
-    });
-    test("accepts exactly 32 bytes", () => {
-        const s = randomBytes(32).toString("base64url");
-        assert.equal(decodeSecret(s, "X").length, 32);
-    });
-    test("accepts more than 32 bytes", () => {
-        const s = randomBytes(64).toString("base64url");
-        assert.equal(decodeSecret(s, "X").length, 64);
-    });
-});
-// ---------------------------------------------------------------------------
-// deriveSubkey / deriveSubkeys — purpose isolation
-// ---------------------------------------------------------------------------
-describe("HKDF subkey derivation", () => {
-    test("same purpose + same secret ⇒ same key", () => {
-        const secret = genSecret();
-        const m1 = buildMaterial(secret);
-        const m2 = buildMaterial(secret);
-        const k1 = deriveSubkey(m1, "current", STATELESS_PURPOSES.CLIENT_ID);
-        const k2 = deriveSubkey(m2, "current", STATELESS_PURPOSES.CLIENT_ID);
-        assert.ok(k1.equals(k2));
-    });
-    test("different purposes ⇒ different keys", () => {
-        const m = buildMaterial();
-        const kC = deriveSubkey(m, "current", STATELESS_PURPOSES.CLIENT_ID);
-        const kS = deriveSubkey(m, "current", STATELESS_PURPOSES.SESSION_ID);
-        const kP = deriveSubkey(m, "current", STATELESS_PURPOSES.PENDING_AUTH);
-        const kT = deriveSubkey(m, "current", STATELESS_PURPOSES.STORED_TOKENS);
-        const set = new Set([kC.toString("hex"), kS.toString("hex"), kP.toString("hex"), kT.toString("hex")]);
-        assert.equal(set.size, 4);
-    });
-    test("different master secrets ⇒ different keys", () => {
-        const m1 = buildMaterial();
-        const m2 = buildMaterial();
-        assert.notEqual(deriveSubkey(m1, "current", STATELESS_PURPOSES.CLIENT_ID).toString("hex"), deriveSubkey(m2, "current", STATELESS_PURPOSES.CLIENT_ID).toString("hex"));
-    });
-    test("deriveSubkeys returns [current] when no previous", () => {
-        const m = buildMaterial();
-        const ks = deriveSubkeys(m, STATELESS_PURPOSES.CLIENT_ID);
-        assert.equal(ks.length, 1);
-        assert.equal(ks[0].slot, "current");
-    });
-    test("deriveSubkeys returns [current, previous] when rotated", () => {
-        const m = buildMaterial(genSecret(), genSecret());
-        const ks = deriveSubkeys(m, STATELESS_PURPOSES.CLIENT_ID);
-        assert.equal(ks.length, 2);
-        assert.equal(ks[0].slot, "current");
-        assert.equal(ks[1].slot, "previous");
-        assert.notEqual(ks[0].key.toString("hex"), ks[1].key.toString("hex"));
-    });
-});
-// ---------------------------------------------------------------------------
-// sign / verify (CLIENT_ID purpose)
-// ---------------------------------------------------------------------------
-describe("sign / verify", () => {
-    test("happy-path roundtrip", () => {
-        const m = buildMaterial();
-        const p = dummyPayload();
-        const token = sign(m, STATELESS_PURPOSES.CLIENT_ID, p);
-        const { payload, slot } = verify(m, STATELESS_PURPOSES.CLIENT_ID, token, {
-            ttlSeconds: 3600,
-        });
-        assert.deepEqual(payload, p);
-        assert.equal(slot, "current");
-        assert.match(token, /^v1\.cid\.[A-Za-z0-9_-]+\.[A-Za-z0-9_-]+$/);
-    });
-    test("tampered payload fails verify", () => {
-        const m = buildMaterial();
-        const token = sign(m, STATELESS_PURPOSES.CLIENT_ID, dummyPayload());
-        const parts = token.split(".");
-        const tampered = Buffer.from('{"v":1,"iat":1,"hello":"EVIL"}').toString("base64url");
-        parts[2] = tampered;
-        const bad = parts.join(".");
-        assert.throws(() => verify(m, STATELESS_PURPOSES.CLIENT_ID, bad, { ttlSeconds: 3600 }), (err) => err instanceof StatelessCodecError && err.reason === "bad_signature");
-    });
-    test("tampered signature fails verify", () => {
-        const m = buildMaterial();
-        const token = sign(m, STATELESS_PURPOSES.CLIENT_ID, dummyPayload());
-        const parts = token.split(".");
-        const evilMac = Buffer.alloc(32, 7).toString("base64url");
-        parts[3] = evilMac;
-        const bad = parts.join(".");
-        assert.throws(() => verify(m, STATELESS_PURPOSES.CLIENT_ID, bad, { ttlSeconds: 3600 }), (err) => err instanceof StatelessCodecError && err.reason === "bad_signature");
-    });
-    test("wrong purpose on verify is rejected", () => {
-        const m = buildMaterial();
-        const token = sign(m, STATELESS_PURPOSES.CLIENT_ID, dummyPayload());
-        assert.throws(() => verify(m, STATELESS_PURPOSES.SESSION_ID, token, { ttlSeconds: 3600 }), (err) => err instanceof StatelessCodecError && err.reason === "purpose_mismatch");
-    });
-    test("expired token is rejected", () => {
-        const m = buildMaterial();
-        const longAgo = Math.floor(Date.now() / 1000) - 10_000;
-        const token = sign(m, STATELESS_PURPOSES.CLIENT_ID, dummyPayload(longAgo));
-        assert.throws(() => verify(m, STATELESS_PURPOSES.CLIENT_ID, token, { ttlSeconds: 60 }), (err) => err instanceof StatelessCodecError && err.reason === "expired");
-    });
-    test("future iat beyond skew rejected", () => {
-        const m = buildMaterial();
-        const future = Math.floor(Date.now() / 1000) + 3600;
-        const token = sign(m, STATELESS_PURPOSES.CLIENT_ID, dummyPayload(future));
-        assert.throws(() => verify(m, STATELESS_PURPOSES.CLIENT_ID, token, { ttlSeconds: 60 }), (err) => err instanceof StatelessCodecError && err.reason === "future_iat");
-    });
-    test("malformed prefix rejected", () => {
-        const m = buildMaterial();
-        assert.throws(() => verify(m, STATELESS_PURPOSES.CLIENT_ID, "not-a-token", { ttlSeconds: 60 }), (err) => err instanceof StatelessCodecError && err.reason === "malformed");
-    });
-    test("wrong version rejected", () => {
-        const m = buildMaterial();
-        const token = sign(m, STATELESS_PURPOSES.CLIENT_ID, dummyPayload());
-        const bad = token.replace(/^v1\./, "v9.");
-        assert.throws(() => verify(m, STATELESS_PURPOSES.CLIENT_ID, bad, { ttlSeconds: 60 }), (err) => err instanceof StatelessCodecError && err.reason === "unknown_version");
-    });
-    test("rotation: verify with previous secret succeeds", () => {
-        const oldSecret = genSecret();
-        const newSecret = genSecret();
-        const minter = buildMaterial(oldSecret); // minted under old
-        const token = sign(minter, STATELESS_PURPOSES.CLIENT_ID, dummyPayload());
-        // Verifier has rotated: new is current, old is previous.
-        const verifier = buildMaterial(newSecret, oldSecret);
-        const { slot } = verify(verifier, STATELESS_PURPOSES.CLIENT_ID, token, {
-            ttlSeconds: 3600,
-        });
-        assert.equal(slot, "previous");
-    });
-    test("cross-pod: two independently-loaded materials with same secret agree", () => {
-        const secret = genSecret();
-        const podA = buildMaterial(secret);
-        const podB = buildMaterial(secret);
-        const token = sign(podA, STATELESS_PURPOSES.CLIENT_ID, dummyPayload());
-        const { payload } = verify(podB, STATELESS_PURPOSES.CLIENT_ID, token, {
-            ttlSeconds: 3600,
-        });
-        assert.equal(payload.hello, "world");
-    });
-});
-// ---------------------------------------------------------------------------
-// seal / open (SESSION_ID purpose)
-// ---------------------------------------------------------------------------
-describe("seal / open", () => {
-    test("happy-path roundtrip", () => {
-        const m = buildMaterial();
-        const p = dummyPayload();
-        const token = seal(m, STATELESS_PURPOSES.SESSION_ID, p);
-        const { payload, slot } = open(m, STATELESS_PURPOSES.SESSION_ID, token, {
-            ttlSeconds: 3600,
-        });
-        assert.deepEqual(payload, p);
-        assert.equal(slot, "current");
-        assert.match(token, /^v1\.sid\.[A-Za-z0-9_-]+$/);
-    });
-    test("each seal uses a fresh nonce (different ciphertexts)", () => {
-        const m = buildMaterial();
-        const p = dummyPayload();
-        const t1 = seal(m, STATELESS_PURPOSES.SESSION_ID, p);
-        const t2 = seal(m, STATELESS_PURPOSES.SESSION_ID, p);
-        assert.notEqual(t1, t2);
-    });
-    test("tampered ciphertext fails open", () => {
-        const m = buildMaterial();
-        const token = seal(m, STATELESS_PURPOSES.SESSION_ID, dummyPayload());
-        // Flip a bit in the middle of the blob.
-        const parts = token.split(".");
-        const blob = Buffer.from(parts[2], "base64url");
-        const midIndex = Math.floor(blob.length / 2);
-        blob[midIndex] ^= 0xff;
-        parts[2] = blob.toString("base64url");
-        const bad = parts.join(".");
-        assert.throws(() => open(m, STATELESS_PURPOSES.SESSION_ID, bad, { ttlSeconds: 3600 }), (err) => err instanceof StatelessCodecError && err.reason === "bad_ciphertext");
-    });
-    test("wrong purpose rejected at parse", () => {
-        const m = buildMaterial();
-        const token = seal(m, STATELESS_PURPOSES.SESSION_ID, dummyPayload());
-        assert.throws(() => open(m, STATELESS_PURPOSES.CLIENT_ID, token, { ttlSeconds: 3600 }), (err) => err instanceof StatelessCodecError && err.reason === "purpose_mismatch");
-    });
-    test("forging a sealed value for wrong purpose fails AAD check", () => {
-        // Build a token under SESSION_ID but then relabel as PENDING_AUTH.
-        const m = buildMaterial();
-        const token = seal(m, STATELESS_PURPOSES.SESSION_ID, dummyPayload());
-        const relabeled = token.replace(/^v1\.sid\./, "v1.ps.");
-        assert.throws(() => open(m, STATELESS_PURPOSES.PENDING_AUTH, relabeled, { ttlSeconds: 3600 }), 
-        // AAD mismatch surfaces as bad_ciphertext (AEAD integrity failure).
-        (err) => err instanceof StatelessCodecError && err.reason === "bad_ciphertext");
-    });
-    test("expired sealed value rejected", () => {
-        const m = buildMaterial();
-        const longAgo = Math.floor(Date.now() / 1000) - 10_000;
-        const token = seal(m, STATELESS_PURPOSES.SESSION_ID, dummyPayload(longAgo));
-        assert.throws(() => open(m, STATELESS_PURPOSES.SESSION_ID, token, { ttlSeconds: 60 }), (err) => err instanceof StatelessCodecError && err.reason === "expired");
-    });
-    test("malformed blob (too short) rejected", () => {
-        const m = buildMaterial();
-        const tooShort = "v1.sid." + Buffer.alloc(4).toString("base64url");
-        assert.throws(() => open(m, STATELESS_PURPOSES.SESSION_ID, tooShort, { ttlSeconds: 60 }), (err) => err instanceof StatelessCodecError &&
-            (err.reason === "malformed" || err.reason === "bad_ciphertext"));
-    });
-    test("rotation: sealed value minted under previous secret still opens", () => {
-        const oldSecret = genSecret();
-        const newSecret = genSecret();
-        const minter = buildMaterial(oldSecret);
-        const token = seal(minter, STATELESS_PURPOSES.SESSION_ID, dummyPayload());
-        const verifier = buildMaterial(newSecret, oldSecret);
-        const { slot } = open(verifier, STATELESS_PURPOSES.SESSION_ID, token, {
-            ttlSeconds: 3600,
-        });
-        assert.equal(slot, "previous");
-    });
-    test("two pods sharing secret interop", () => {
-        const secret = genSecret();
-        const podA = buildMaterial(secret);
-        const podB = buildMaterial(secret);
-        const token = seal(podA, STATELESS_PURPOSES.SESSION_ID, dummyPayload());
-        const { payload } = open(podB, STATELESS_PURPOSES.SESSION_ID, token, {
-            ttlSeconds: 3600,
-        });
-        assert.equal(payload.hello, "world");
-    });
-});
-// ---------------------------------------------------------------------------
-// Mixed purpose / payload-shape validation
-// ---------------------------------------------------------------------------
-describe("payload schema validation", () => {
-    test("payload without v rejected", () => {
-        const m = buildMaterial();
-        // Hand-craft a signed token with bogus shape.
-        const badPayload = Buffer.from(JSON.stringify({ iat: Math.floor(Date.now() / 1000) }));
-        // Compute matching HMAC so we reach the shape check, not the sig check.
-        const [{ key }] = deriveSubkeys(m, STATELESS_PURPOSES.CLIENT_ID).filter((k) => k.slot === "current");
-        const mac = createHmac("sha256", key)
-            .update(Buffer.concat([Buffer.from("cid"), Buffer.from([0]), badPayload]))
-            .digest();
-        const token = `v1.cid.${badPayload.toString("base64url")}.${mac.toString("base64url")}`;
-        assert.throws(() => verify(m, STATELESS_PURPOSES.CLIENT_ID, token, { ttlSeconds: 3600 }), (err) => err instanceof StatelessCodecError && err.reason === "bad_schema");
-    });
-});

package/build/test/stateless/config-ttl.test.js

@@ -1,149 +0,0 @@
-/**
- * Regression tests for OAUTH_STATELESS_SESSION_TTL_SECONDS parsing.
- *
- * Maintainer feedback (zereight, PR #442):
- *   "This can still disable stateless session expiry when
- *   OAUTH_STATELESS_SESSION_TTL_SECONDS is unset and SESSION_TIMEOUT_SECONDS
- *   is invalid. In that state, this fallback becomes NaN; _intEnv() returns
- *   the fallback directly when the stateless-specific value is missing, so
- *   OAUTH_STATELESS_SESSION_TTL_SECONDS becomes NaN instead of falling back
- *   to a safe positive default."
- *
- * The fix validates both the direct env/CLI value and the fallback inside
- * _intEnv, and also sanitizes SESSION_TIMEOUT_SECONDS itself through the
- * same helper so its downstream consumers always see a finite positive
- * integer.
- *
- * config.ts reads process.env / process.argv at module load, so these
- * tests use a child process per scenario to control the environment.
- */
-import assert from "node:assert/strict";
-import { execFileSync } from "node:child_process";
-import * as path from "node:path";
-import * as url from "node:url";
-import { describe, test } from "node:test";
-const __dirname = path.dirname(url.fileURLToPath(import.meta.url));
-const CONFIG_PATH = path.resolve(__dirname, "../../config.ts");
-/**
- * Spawn a child Node process that imports config.ts with the given env
- * overrides, and returns a structured snapshot of the parsed numeric
- * config values. We pipe a tiny evaluator script through stdin (`--eval`
- * with tsx via `--import`) to keep the test hermetic.
- */
-function loadConfig(env) {
-    const script = `
-    import(${JSON.stringify(url.pathToFileURL(CONFIG_PATH).href)}).then((m) => {
-      const out = {
-        SESSION_TIMEOUT_SECONDS: m.SESSION_TIMEOUT_SECONDS,
-        OAUTH_STATELESS_SESSION_TTL_SECONDS: m.OAUTH_STATELESS_SESSION_TTL_SECONDS,
-        OAUTH_STATELESS_CLIENT_TTL_SECONDS: m.OAUTH_STATELESS_CLIENT_TTL_SECONDS,
-        PORT: m.PORT,
-      };
-      process.stdout.write(JSON.stringify(out));
-    }).catch((err) => {
-      process.stderr.write(String(err && err.stack || err));
-      process.exit(2);
-    });
-  `;
-    // Strip undefined entries so they truly aren't set in the child's env.
-    const childEnv = {
-        // Keep PATH / basic vars so tsx can spawn.
-        ...process.env,
-    };
-    // Reset anything that could interfere with the test even if our caller
-    // didn't set it — make every variable start clean.
-    delete childEnv.SESSION_TIMEOUT_SECONDS;
-    delete childEnv.OAUTH_STATELESS_SESSION_TTL_SECONDS;
-    delete childEnv.OAUTH_STATELESS_CLIENT_TTL_SECONDS;
-    delete childEnv.PORT;
-    // Apply the per-test overrides last.
-    for (const [k, v] of Object.entries(env)) {
-        if (v === undefined) {
-            delete childEnv[k];
-        }
-        else {
-            childEnv[k] = v;
-        }
-    }
-    const stdout = execFileSync(process.execPath, ["--import", "tsx/esm", "--input-type=module", "--eval", script], {
-        env: childEnv,
-        encoding: "utf8",
-        stdio: ["ignore", "pipe", "pipe"],
-    });
-    return JSON.parse(stdout);
-}
-describe("config.ts TTL parsing — finite-positive guards", () => {
-    test("happy path: both TTLs default to 3600 when unset", () => {
-        const cfg = loadConfig({});
-        assert.equal(cfg.SESSION_TIMEOUT_SECONDS, 3600);
-        assert.equal(cfg.OAUTH_STATELESS_SESSION_TTL_SECONDS, 3600);
-    });
-    test("OAUTH_STATELESS_SESSION_TTL_SECONDS honors its own env value", () => {
-        const cfg = loadConfig({
-            OAUTH_STATELESS_SESSION_TTL_SECONDS: "7200",
-        });
-        assert.equal(cfg.OAUTH_STATELESS_SESSION_TTL_SECONDS, 7200);
-    });
-    test("OAUTH_STATELESS_SESSION_TTL_SECONDS inherits valid SESSION_TIMEOUT_SECONDS", () => {
-        const cfg = loadConfig({
-            SESSION_TIMEOUT_SECONDS: "1800",
-        });
-        assert.equal(cfg.SESSION_TIMEOUT_SECONDS, 1800);
-        assert.equal(cfg.OAUTH_STATELESS_SESSION_TTL_SECONDS, 1800);
-    });
-    test("invalid SESSION_TIMEOUT_SECONDS must not poison OAUTH_STATELESS_SESSION_TTL_SECONDS (NaN regression)", () => {
-        // Regression for zereight's P-level PR review feedback. Before the
-        // fix, _intEnv returned NaN verbatim from the fallback when the
-        // stateless-specific var was unset, which silently disabled TTL
-        // checks in checkIat (`ttlSec > 0` is false for NaN).
-        const cfg = loadConfig({
-            SESSION_TIMEOUT_SECONDS: "not-a-number",
-        });
-        assert.equal(cfg.OAUTH_STATELESS_SESSION_TTL_SECONDS, 3600, "OAUTH_STATELESS_SESSION_TTL_SECONDS must fall back to the hardcoded 3600 default when SESSION_TIMEOUT_SECONDS is invalid");
-        assert.equal(cfg.SESSION_TIMEOUT_SECONDS, 3600, "SESSION_TIMEOUT_SECONDS must sanitize its own input too");
-        assert.ok(Number.isFinite(cfg.OAUTH_STATELESS_SESSION_TTL_SECONDS), "OAUTH_STATELESS_SESSION_TTL_SECONDS must be a finite number");
-        assert.ok(cfg.OAUTH_STATELESS_SESSION_TTL_SECONDS > 0, "OAUTH_STATELESS_SESSION_TTL_SECONDS must be strictly positive");
-    });
-    test("zero and negative SESSION_TIMEOUT_SECONDS fall back to the safe default", () => {
-        for (const badValue of ["0", "-1", "-3600"]) {
-            const cfg = loadConfig({ SESSION_TIMEOUT_SECONDS: badValue });
-            assert.equal(cfg.SESSION_TIMEOUT_SECONDS, 3600, `SESSION_TIMEOUT_SECONDS=${badValue} should sanitize to default`);
-            assert.equal(cfg.OAUTH_STATELESS_SESSION_TTL_SECONDS, 3600, `OAUTH_STATELESS_SESSION_TTL_SECONDS should inherit the sanitized default from SESSION_TIMEOUT_SECONDS=${badValue}`);
-        }
-    });
-    test("garbage OAUTH_STATELESS_SESSION_TTL_SECONDS falls back to SESSION_TIMEOUT_SECONDS (when valid) or safe default", () => {
-        const cfg = loadConfig({
-            OAUTH_STATELESS_SESSION_TTL_SECONDS: "garbage",
-            SESSION_TIMEOUT_SECONDS: "1800",
-        });
-        assert.equal(cfg.OAUTH_STATELESS_SESSION_TTL_SECONDS, 1800, "invalid direct value should defer to the valid fallback");
-        const cfg2 = loadConfig({
-            OAUTH_STATELESS_SESSION_TTL_SECONDS: "garbage",
-            SESSION_TIMEOUT_SECONDS: "also-garbage",
-        });
-        assert.equal(cfg2.OAUTH_STATELESS_SESSION_TTL_SECONDS, 3600, "both invalid should hit the hardcoded safe default");
-    });
-    test("other _intEnv consumers remain unaffected (client TTL default)", () => {
-        // Guards against an accidental over-broad change to _intEnv.
-        const cfg = loadConfig({});
-        assert.equal(cfg.OAUTH_STATELESS_CLIENT_TTL_SECONDS, 86_400);
-    });
-    test("PORT uses the hardened _intEnv and rejects invalid values", () => {
-        const cfg = loadConfig({ PORT: "not-a-port" });
-        assert.equal(cfg.PORT, 3002, "invalid PORT should fall back to the default rather than NaN");
-    });
-    test("empty-string SESSION_TIMEOUT_SECONDS falls back to the safe default", () => {
-        // getConfig returns the value only when truthy; empty string is falsy
-        // and picks the default branch. This guards against regressions in the
-        // "raw empty" → "use defaultValue" short-circuit at getConfig.
-        const cfg = loadConfig({ SESSION_TIMEOUT_SECONDS: "" });
-        assert.equal(cfg.SESSION_TIMEOUT_SECONDS, 3600);
-        assert.equal(cfg.OAUTH_STATELESS_SESSION_TTL_SECONDS, 3600);
-    });
-    test("whitespace-only SESSION_TIMEOUT_SECONDS also falls back", () => {
-        // parseInt("   ", 10) is NaN, so the _intEnv guard must catch it.
-        const cfg = loadConfig({ SESSION_TIMEOUT_SECONDS: "   " });
-        assert.equal(cfg.SESSION_TIMEOUT_SECONDS, 3600);
-        assert.equal(cfg.OAUTH_STATELESS_SESSION_TTL_SECONDS, 3600);
-    });
-});