@zereight/mcp-gitlab 2.1.14 → 2.1.15

package/build/schemas.js

@@ -2580,7 +2580,7 @@ export const GitLabProjectMemberSchema = z.object({
 });
 // Markdown upload schemas
 export const GitLabMarkdownUploadSchema = z.object({
-    id: z.coerce.number(),
+    id: z.preprocess((val) => (val == null ? undefined : val), z.coerce.number().optional()),
     alt: z.string(),
     url: z.string(),
     full_path: z.string(),

package/build/test/schema-tests.js

@@ -1,5 +1,5 @@
 #!/usr/bin/env ts-node
-import { GetFileContentsSchema, GitLabFileContentSchema, GitLabRepositorySchema, CreatePipelineSchema, CreateCommitStatusSchema, ListCommitStatusesSchema, CreateIssueNoteSchema, CreateMergeRequestEmojiReactionSchema, CreateIssueEmojiReactionSchema, DeleteMergeRequestEmojiReactionSchema, DeleteIssueEmojiReactionSchema, CreateWorkItemEmojiReactionSchema, CreateWorkItemNoteEmojiReactionSchema, CreateIssueSchema, ListIssuesSchema, ListMergeRequestsSchema, ListLabelsSchema, GitLabMergeRequestSchema, GitLabTreeItemSchema, GetMergeRequestSchema, ListMergeRequestPipelinesSchema, GetRepositoryTreeSchema, GitLabUserFullSchema } from '../schemas.js';
+import { GetFileContentsSchema, GitLabFileContentSchema, GitLabRepositorySchema, CreatePipelineSchema, CreateCommitStatusSchema, ListCommitStatusesSchema, CreateIssueNoteSchema, CreateMergeRequestEmojiReactionSchema, CreateIssueEmojiReactionSchema, DeleteMergeRequestEmojiReactionSchema, DeleteIssueEmojiReactionSchema, CreateWorkItemEmojiReactionSchema, CreateWorkItemNoteEmojiReactionSchema, CreateIssueSchema, ListIssuesSchema, ListMergeRequestsSchema, ListLabelsSchema, GitLabMergeRequestSchema, GitLabTreeItemSchema, GetMergeRequestSchema, ListMergeRequestPipelinesSchema, GetRepositoryTreeSchema, GitLabUserFullSchema, GitLabMarkdownUploadSchema, } from '../schemas.js';
 function runGetFileContentsSchemaTests() {
     console.log('🧪 Testing GetFileContentsSchema...');
     const cases = [
@@ -1122,6 +1122,75 @@ function runGetRepositoryTreeSchemaTests() {
     console.log(`\nResults: ${passed} passed, ${failed} failed`);
     return { passed, failed };
 }
+function runGitLabMarkdownUploadSchemaTests() {
+    console.log('\n=== GitLabMarkdownUpload Schema Tests ===');
+    const idlessUpload = {
+        alt: 'report.md',
+        url: '/uploads/c617e74a47dfb1a6dd59d419619b725d/report.md',
+        full_path: '/group/project/uploads/c617e74a47dfb1a6dd59d419619b725d/report.md',
+        markdown: '[report.md](/uploads/c617e74a47dfb1a6dd59d419619b725d/report.md)',
+    };
+    const cases = [
+        {
+            name: 'schema:markdown_upload:accepts-idless-response',
+            input: idlessUpload,
+            expectedId: 'absent',
+        },
+        {
+            name: 'schema:markdown_upload:accepts-numeric-id',
+            input: { ...idlessUpload, id: 42 },
+            expectedId: 42,
+        },
+        {
+            name: 'schema:markdown_upload:coerces-string-id',
+            input: { ...idlessUpload, id: '99' },
+            expectedId: 99,
+        },
+        {
+            name: 'schema:markdown_upload:treats-null-id-as-absent',
+            input: { ...idlessUpload, id: null },
+            expectedId: 'absent',
+        },
+        {
+            name: 'schema:markdown_upload:rejects-invalid-id',
+            input: { ...idlessUpload, id: 'not-a-number' },
+            shouldFail: true,
+        },
+    ];
+    let passed = 0;
+    let failed = 0;
+    cases.forEach(testCase => {
+        const result = { name: testCase.name, status: 'failed' };
+        const parsed = GitLabMarkdownUploadSchema.safeParse(testCase.input);
+        if (testCase.shouldFail) {
+            result.status = parsed.success ? 'failed' : 'passed';
+            if (parsed.success)
+                result.error = 'Expected schema validation to fail';
+        }
+        else if (!parsed.success) {
+            result.error = parsed.error?.message || 'Schema validation failed';
+        }
+        else if (testCase.expectedId === 'absent' && parsed.data.id !== undefined) {
+            result.error = `Expected id undefined, got ${parsed.data.id}`;
+        }
+        else if (typeof testCase.expectedId === 'number' && parsed.data.id !== testCase.expectedId) {
+            result.error = `Expected id ${testCase.expectedId}, got ${parsed.data.id}`;
+        }
+        else {
+            result.status = 'passed';
+        }
+        if (result.status === 'passed') {
+            passed++;
+            console.log(`✅ ${result.name}`);
+        }
+        else {
+            failed++;
+            console.log(`❌ ${result.name}: ${result.error}`);
+        }
+    });
+    console.log(`\nResults: ${passed} passed, ${failed} failed`);
+    return { passed, failed };
+}
 function runGitLabUserFullSchemaTests() {
     console.log('🧪 Testing GitLabUserFullSchema...');
     const adminResponse = {
@@ -1219,8 +1288,9 @@ if (import.meta.url === `file://${process.argv[1]}`) {
     const treeItemResult = runGitLabTreeItemSchemaTests();
     const repositoryTreeResult = runGetRepositoryTreeSchemaTests();
     const gitLabUserFullResult = runGitLabUserFullSchemaTests();
-    const totalPassed = getFileContentsResult.passed + fileContentResult.passed + createPipelineResult.passed + commitStatusResult.passed + createIssueNoteResult.passed + getMergeRequestResult.passed + listMergeRequestPipelinesResult.passed + gitLabMergeRequestResult.passed + emojiReactionResult.passed + repositorySchemaResult.passed + labelsCoercionResult.passed + listLabelsResult.passed + treeItemResult.passed + repositoryTreeResult.passed + gitLabUserFullResult.passed;
-    const totalFailed = getFileContentsResult.failed + fileContentResult.failed + createPipelineResult.failed + commitStatusResult.failed + createIssueNoteResult.failed + getMergeRequestResult.failed + listMergeRequestPipelinesResult.failed + gitLabMergeRequestResult.failed + emojiReactionResult.failed + repositorySchemaResult.failed + labelsCoercionResult.failed + listLabelsResult.failed + treeItemResult.failed + repositoryTreeResult.failed + gitLabUserFullResult.failed;
+    const gitLabMarkdownUploadResult = runGitLabMarkdownUploadSchemaTests();
+    const totalPassed = getFileContentsResult.passed + fileContentResult.passed + createPipelineResult.passed + commitStatusResult.passed + createIssueNoteResult.passed + getMergeRequestResult.passed + listMergeRequestPipelinesResult.passed + gitLabMergeRequestResult.passed + emojiReactionResult.passed + repositorySchemaResult.passed + labelsCoercionResult.passed + listLabelsResult.passed + treeItemResult.passed + repositoryTreeResult.passed + gitLabUserFullResult.passed + gitLabMarkdownUploadResult.passed;
+    const totalFailed = getFileContentsResult.failed + fileContentResult.failed + createPipelineResult.failed + commitStatusResult.failed + createIssueNoteResult.failed + getMergeRequestResult.failed + listMergeRequestPipelinesResult.failed + gitLabMergeRequestResult.failed + emojiReactionResult.failed + repositorySchemaResult.failed + labelsCoercionResult.failed + listLabelsResult.failed + treeItemResult.failed + repositoryTreeResult.failed + gitLabUserFullResult.failed + gitLabMarkdownUploadResult.failed;
     console.log(`\nTotal Results: ${totalPassed} passed, ${totalFailed} failed`);
     if (totalFailed > 0) {
         process.exit(1);

package/build/test/test-upload-markdown.js

@@ -1,4 +1,4 @@
-import { describe, test, before, after } from 'node:test';
+import { describe, test, before, after, beforeEach } from 'node:test';
 import assert from 'node:assert';
 import { spawn } from 'node:child_process';
 import fs from 'node:fs';
@@ -55,12 +55,18 @@ const MOCK_UPLOAD_RESPONSE = {
     full_path: '/test-group/test-project/uploads/abc123secret/test-file.txt',
     markdown: '[test-file.txt](/uploads/abc123secret/test-file.txt)',
 };
+let uploadResponse = MOCK_UPLOAD_RESPONSE;
 describe('upload_markdown', () => {
     let mockGitLab;
     let env;
     // Captured per-request state, reset before each invocation via the handler
     let lastContentType;
     let lastRawBody;
+    beforeEach(() => {
+        uploadResponse = MOCK_UPLOAD_RESPONSE;
+        lastContentType = undefined;
+        lastRawBody = undefined;
+    });
     before(async () => {
         const port = await findMockServerPort(9200);
         mockGitLab = new MockGitLabServer({ port, validTokens: [MOCK_TOKEN] });
@@ -75,7 +81,7 @@ describe('upload_markdown', () => {
             req.on('data', (chunk) => chunks.push(chunk));
             req.on('end', () => {
                 lastRawBody = Buffer.concat(chunks).toString('binary');
-                res.status(201).json(MOCK_UPLOAD_RESPONSE);
+                res.status(201).json(uploadResponse);
             });
         });
     });
@@ -139,6 +145,27 @@ describe('upload_markdown', () => {
             fs.unlinkSync(tmpFile);
         }
     });
+    test('accepts upload responses without id from older self-hosted GitLab', async () => {
+        const { id: _id, ...idlessUploadResponse } = MOCK_UPLOAD_RESPONSE;
+        uploadResponse = idlessUploadResponse;
+        const tmpFile = path.join(os.tmpdir(), 'mcp-upload-idless-response-test.txt');
+        fs.writeFileSync(tmpFile, 'idless response field test');
+        try {
+            const raw = await callUploadMarkdown({ project_id: TEST_PROJECT_ID, file_path: tmpFile }, env);
+            assert.ok(!raw.error, `Unexpected RPC error: ${raw.error?.message}`);
+            const text = raw.result?.content?.[0]?.text;
+            assert.ok(text, 'Result should contain a text content block');
+            const parsed = JSON.parse(text);
+            assert.strictEqual(parsed.id, undefined);
+            assert.strictEqual(parsed.markdown, MOCK_UPLOAD_RESPONSE.markdown);
+            assert.strictEqual(parsed.url, MOCK_UPLOAD_RESPONSE.url);
+            assert.strictEqual(parsed.alt, MOCK_UPLOAD_RESPONSE.alt);
+            assert.strictEqual(parsed.full_path, MOCK_UPLOAD_RESPONSE.full_path);
+        }
+        finally {
+            fs.unlinkSync(tmpFile);
+        }
+    });
     test('returns an error when the file does not exist', async () => {
         const raw = await callUploadMarkdown({ project_id: TEST_PROJECT_ID, file_path: '/nonexistent/no-such-file.txt' }, env);
         const hasError = typeof raw.error?.message === 'string' ||

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zereight/mcp-gitlab",
-  "version": "2.1.14",
+  "version": "2.1.15",
   "mcpName": "io.github.zereight/gitlab-mcp",
   "description": "GitLab MCP server for projects, merge requests, issues, pipelines, wiki, releases, and more",
   "keywords": [
@@ -51,7 +51,7 @@
     "changelog": "auto-changelog -p",
     "test": "npm run test:all",
     "test:all": "npm run build && npm run test:mock && npm run test:live",
-    "test:mock": "node --import tsx/esm --test test/remote-auth-simple-test.ts && node --import tsx/esm --test test/mcp-oauth-tests.ts && node --import tsx/esm --test test/streamable-http-static-token-auth.test.ts && tsx test/oauth-tests.ts && tsx test/test-list-merge-requests.ts && node --import tsx/esm --test test/test-merge-request-pipelines.ts && tsx test/test-list-project-members.ts && tsx test/test-download-attachment.ts && node --import tsx/esm --test test/test-job-artifacts.ts && node --import tsx/esm --test test/test-deployment-tools.ts && node --import tsx/esm --test test/test-merge-request-approval-state-tools.ts && node --import tsx/esm --test test/test-search-code.ts && node --import tsx/esm --test test/test-tags.ts && node --import tsx/esm --test test/test-toolset-filtering.ts && node --import tsx/esm --test test/test-ci-lint.ts && node --import tsx/esm --test test/test-todos.ts && node --import tsx/esm --test test/test-auth-retry.ts && node --import tsx/esm --test test/test-issue-description-patch.ts && node --import tsx/esm --test test/test-geteffectiveprojectid.ts && node --import tsx/esm --test test/test-get-file-blame.ts && node --import tsx/esm --test test/stateless/codec.test.ts test/stateless/client-id.test.ts test/stateless/callback-proxy.test.ts test/stateless/session-id.test.ts test/stateless/session-id-integration.test.ts test/stateless/config-ttl.test.ts",
+    "test:mock": "node --import tsx/esm --test test/remote-auth-simple-test.ts && node --import tsx/esm --test test/mcp-oauth-tests.ts && node --import tsx/esm --test test/streamable-http-static-token-auth.test.ts && tsx test/oauth-tests.ts && tsx test/test-list-merge-requests.ts && node --import tsx/esm --test test/test-merge-request-pipelines.ts && tsx test/test-list-project-members.ts && tsx test/test-download-attachment.ts && node --import tsx/esm --test test/test-upload-markdown.ts && node --import tsx/esm --test test/test-job-artifacts.ts && node --import tsx/esm --test test/test-deployment-tools.ts && node --import tsx/esm --test test/test-merge-request-approval-state-tools.ts && node --import tsx/esm --test test/test-search-code.ts && node --import tsx/esm --test test/test-tags.ts && node --import tsx/esm --test test/test-toolset-filtering.ts && node --import tsx/esm --test test/test-ci-lint.ts && node --import tsx/esm --test test/test-todos.ts && node --import tsx/esm --test test/test-auth-retry.ts && node --import tsx/esm --test test/test-issue-description-patch.ts && node --import tsx/esm --test test/test-geteffectiveprojectid.ts && node --import tsx/esm --test test/test-get-file-blame.ts && node --import tsx/esm --test test/stateless/codec.test.ts test/stateless/client-id.test.ts test/stateless/callback-proxy.test.ts test/stateless/session-id.test.ts test/stateless/session-id-integration.test.ts test/stateless/config-ttl.test.ts",
     "test:stateless": "npm run build && node --import tsx/esm --test test/stateless/codec.test.ts test/stateless/client-id.test.ts test/stateless/callback-proxy.test.ts test/stateless/session-id.test.ts test/stateless/session-id-integration.test.ts test/stateless/config-ttl.test.ts",
     "test:mcp-oauth": "npm run build && node --import tsx/esm --test test/mcp-oauth-tests.ts",
     "test:live": "node test/validate-api.js",