@zephyrdeng/pi-review 0.7.1 → 0.8.1

package/extensions/panel-tool.test.ts

@@ -1,13 +1,45 @@
 import assert from "node:assert/strict";
-import { test } from "node:test";
+import { test } from "vitest";
 import { createPanelViewState, reducePanelEvent } from "@zephyrdeng/pi-review";
-import { renderPanelResult } from "./panel-tool.js";
+import {
+  buildPanelResultContent,
+  expandHint,
+  panelToolParamError,
+  PanelResultView,
+  registerPanelReviewTool,
+  renderPanelResult,
+} from "./panel-tool.js";
 
 const theme = {
   fg: (_color: "toolTitle" | "muted" | "error" | "success" | "accent", text: string) => text,
   bold: (text: string) => text,
 };
 
+test("panel tool boundary rejects single-reviewer and out-of-range widths", () => {
+  assert.match(panelToolParamError({ target: "@src", reviewers: 1 }) ?? "", /between 2 and 8/);
+  assert.match(panelToolParamError({ target: "@src", reviewers: 9 }) ?? "", /between 2 and 8/);
+  assert.match(panelToolParamError({ target: "@src", panel: "code-experts", reviewers: 2 }) ?? "", /cannot be combined/);
+  assert.equal(panelToolParamError({ target: "@src", reviewers: 2 }), undefined);
+  assert.equal(panelToolParamError({ target: "@src", panel: "code-experts" }), undefined);
+});
+
+test("registered pi_review rejects reviewers=1 before spawning the panel CLI", async () => {
+  let registered: { execute: (...args: any[]) => Promise<any> } | undefined;
+  registerPanelReviewTool({
+    registerTool(tool: { execute: (...args: any[]) => Promise<any> }) {
+      registered = tool;
+    },
+  } as never);
+  assert.ok(registered);
+  const result = await registered!.execute(
+    "tool-call",
+    { target: "@src", reviewers: 1 },
+    new AbortController().signal,
+  );
+  assert.equal(result.isError, true);
+  assert.match(result.content[0].text, /between 2 and 8/);
+});
+
 test("Pi panel renderer exposes compact reviewer progress and expanded activity", () => {
   const now = Date.now();
   const started = reducePanelEvent(createPanelViewState(), {
@@ -18,13 +50,339 @@ test("Pi panel renderer exposes compact reviewer progress and expanded activity"
     type: "panel.started",
     target: "@src",
     mode: "code",
-    reviewers: [{ reviewerId: "security", role: "Security", model: "openai/gpt" }],
+    reviewers: [{ reviewerId: "security", role: "Security", model: "openai/gpt", thinking: "high" }],
   });
   const reviewerStarted = reducePanelEvent(started, { v: 1, runId: "run-1", seq: 2, at: now, type: "reviewer.started", reviewerId: "security" });
-  const running = reducePanelEvent(reviewerStarted, { v: 1, runId: "run-1", seq: 3, at: now, type: "reviewer.tool.started", reviewerId: "security", tool: "read" });
-  const compact = renderPanelResult({ state: running }, false, theme).render(120).join("\n");
-  const expanded = renderPanelResult({ state: running }, true, theme).render(120).join("\n");
-  assert.match(compact, /pi-review panel 0\/1 completed/);
-  assert.match(compact, /security Security · read · 0s/);
+  const running = reducePanelEvent(reviewerStarted, { v: 1, runId: "run-1", seq: 3, at: now - 4500, type: "reviewer.tool.started", reviewerId: "security", tool: "read", summary: "src/panel.ts" });
+  const compact = renderPanelResult({ state: running }, false, theme, undefined, false, now).render(120).join("\n");
+  const expanded = renderPanelResult({ state: running }, true, theme, undefined, false, now).render(120).join("\n");
+  assert.match(compact, /Pi Review Panel 0\/1 completed/);
+  assert.match(compact, /security Security · running · openai\/gpt · high · read · src\/panel\.ts · 0s · idle 4s/);
+  assert.match(compact, /expand/i);
   assert.match(expanded, /security activity/);
+  assert.doesNotMatch(expanded, /to expand/);
+});
+
+test("Pi panel renderer reuses the same PanelResultView across updates", () => {
+  const now = Date.now();
+  let state = reducePanelEvent(createPanelViewState(), {
+    v: 1,
+    runId: "run-reuse",
+    seq: 1,
+    at: now,
+    type: "panel.started",
+    target: "@src",
+    mode: "code",
+    reviewers: [{ reviewerId: "r1", role: "Independent reviewer", model: "openai/gpt", thinking: "high" }],
+  });
+  const first = renderPanelResult({ state }, false, theme, undefined, true, now);
+  assert.ok(first instanceof PanelResultView);
+
+  state = reducePanelEvent(state, { v: 1, runId: "run-reuse", seq: 2, at: now, type: "reviewer.started", reviewerId: "r1" });
+  const second = renderPanelResult({ state }, false, theme, first, true, now);
+  assert.equal(second, first);
+
+  const expanded = renderPanelResult({ state }, true, theme, second, true, now);
+  assert.equal(expanded, first);
+  assert.match(expanded.render(120).join("\n"), /r1 Independent reviewer · running/);
+});
+
+test("expandHint stays usable outside a live Pi session", () => {
+  assert.match(expandHint(), /expand/i);
+});
+
+test("Pi panel partial renderer shows explicit lifecycle state and uses the human-facing name", () => {
+  const now = Date.now();
+  let state = reducePanelEvent(createPanelViewState(), {
+    v: 1,
+    runId: "run-live",
+    seq: 1,
+    at: now,
+    type: "panel.started",
+    target: "@src",
+    mode: "code",
+    reviewers: [
+      { reviewerId: "r1", role: "Independent reviewer", model: "openai/gpt", thinking: "high" },
+      { reviewerId: "r2", role: "Independent reviewer", model: "openai/gpt", thinking: "high" },
+    ],
+  });
+  state = reducePanelEvent(state, { v: 1, runId: "run-live", seq: 2, at: now, type: "reviewer.started", reviewerId: "r1" });
+  state = reducePanelEvent(state, { v: 1, runId: "run-live", seq: 3, at: now, type: "reviewer.tool.started", reviewerId: "r1", tool: "read", summary: "src/panel.ts" });
+
+  const partial = renderPanelResult({ state }, false, theme, undefined, true).render(160).join("\n");
+  assert.match(partial, /Pi Review Panel/);
+  assert.doesNotMatch(partial, /pi_review/);
+  assert.match(partial, /r1 Independent reviewer · running · openai\/gpt · high · read · src\/panel\.ts/);
+  assert.match(partial, /r2 Independent reviewer · queued · openai\/gpt · high/);
+});
+
+test("Pi panel tool call uses the same human-facing name as its result", () => {
+  let registered: { renderCall: (...args: any[]) => any } | undefined;
+  registerPanelReviewTool({
+    registerTool(tool: { renderCall: (...args: any[]) => any }) {
+      registered = tool;
+    },
+  } as never);
+  assert.ok(registered);
+  const rendered = registered!.renderCall(
+    { target: "@src", reviewers: 2, mode: "code" },
+    theme,
+    { lastComponent: undefined },
+  ).render(160).join("\n");
+  assert.match(rendered, /Pi Review Panel/);
+  assert.doesNotMatch(rendered, /pi_review/);
+});
+
+test("Pi panel renderer expands final findings and reviewer provenance", () => {
+  const now = Date.now();
+  let state = reducePanelEvent(createPanelViewState(), {
+    v: 1,
+    runId: "run-1",
+    seq: 1,
+    at: now,
+    type: "panel.started",
+    target: "@src",
+    mode: "code",
+    reviewers: [{ reviewerId: "security", role: "Security", model: "openai/gpt", thinking: "high" }],
+  });
+  state = reducePanelEvent(state, {
+    v: 1,
+    runId: "run-1",
+    seq: 2,
+    at: now,
+    type: "panel.completed",
+    meta: {
+      strategy: "panel",
+      reviewMode: "code",
+      status: "has_findings",
+      verdict: "request_changes",
+      verdictSource: "parsed",
+      findings: [],
+      actionableCount: 1,
+      durationMs: 1200,
+      model: "openai/gpt",
+      configuredReviewers: 1,
+      successfulReviewers: 1,
+      consensusPolicy: "quorum",
+      consensusThreshold: 1,
+      panelHealth: "healthy",
+      confirmedClusters: [{ id: "C1", summary: "Auth bypass", supportingReviewerIds: ["security"], sourceFindingIds: ["F1"], confirmed: true, severity: "high", path: "src/auth.ts", supportCount: 1, actionableSupportCount: 1 }],
+      advisories: [{ id: "C2", summary: "Naming nit", supportingReviewerIds: ["security"], sourceFindingIds: ["F2"], confirmed: false, supportCount: 1, actionableSupportCount: 0 }],
+      reviewers: [{ reviewerId: "security", role: "Security", model: "openai/gpt", thinking: "high", durationMs: 1100, status: "has_findings", verdict: "request_changes", verdictSource: "parsed", contributed: true }],
+      adjudicationUsed: false,
+    },
+  });
+  const expanded = renderPanelResult({ state }, true, theme).render(120).join("\n");
+  assert.match(expanded, /── pi-review panel/);
+  assert.match(expanded, /Confirmed findings:|Auth bypass/);
+  assert.match(expanded, /Auth bypass/);
+  assert.match(expanded, /Advisories \(non-blocking\)|Naming nit/);
+  assert.match(expanded, /Naming nit/);
+  assert.match(expanded, /security/);
+  assert.match(expanded, /openai\/gpt/);
+  assert.match(expanded, /HAS FINDINGS|has_findings/);
+  // No markdown chrome in the expanded tool view.
+  assert.doesNotMatch(expanded, /### |```/);
+
+  state = reducePanelEvent(createPanelViewState(), {
+    v: 1,
+    runId: "run-2",
+    seq: 1,
+    at: now,
+    type: "panel.completed",
+    meta: {
+      strategy: "panel",
+      reviewMode: "code",
+      status: "clean",
+      verdict: "approve",
+      verdictSource: "parsed",
+      findings: [],
+      actionableCount: 0,
+      durationMs: 10,
+      model: null,
+      configuredReviewers: 0,
+      successfulReviewers: 0,
+      consensusPolicy: "quorum",
+      consensusThreshold: 1,
+      panelHealth: "healthy",
+      confirmedClusters: [],
+      advisories: [],
+      reviewers: [],
+      adjudicationUsed: false,
+    },
+  });
+  const empty = renderPanelResult({ state }, true, theme).render(120).join("\n");
+  // Clean panel with no findings: ASCII footer only (no empty ### sections).
+  assert.match(empty, /── pi-review panel/);
+  assert.match(empty, /Status\s+CLEAN|CLEAN/);
+  assert.match(empty, /Confirmed\s+0 actionable/);
+  assert.match(empty, /Advisories\s+0 non-blocking/);
+});
+
+test("Pi panel result content includes duration, token, and cost metrics", () => {
+  const state = reducePanelEvent(createPanelViewState(), {
+    v: 1,
+    runId: "run-metrics",
+    seq: 1,
+    at: Date.now(),
+    type: "panel.completed",
+    meta: {
+      strategy: "panel",
+      reviewMode: "code",
+      status: "clean",
+      verdict: "approve",
+      verdictSource: "parsed",
+      findings: [],
+      actionableCount: 0,
+      durationMs: 1234,
+      model: "openai/gpt",
+      usage: { input: 900, output: 200, cacheRead: 100, cacheWrite: 0, reasoning: 50, totalTokens: 1200, costTotal: 0.1234 },
+      configuredReviewers: 2,
+      successfulReviewers: 2,
+      consensusPolicy: "quorum",
+      consensusThreshold: 2,
+      panelHealth: "healthy",
+      confirmedClusters: [],
+      advisories: [],
+      reviewers: [
+        {
+          reviewerId: "r1",
+          role: "Independent reviewer",
+          model: "openai/gpt",
+          durationMs: 1100,
+          usage: { input: 450, output: 100, cacheRead: 50, cacheWrite: 0, reasoning: 25, totalTokens: 600, costTotal: 0.0617 },
+          status: "clean",
+          verdict: "approve",
+          verdictSource: "parsed",
+          contributed: false,
+        },
+      ],
+      adjudicationUsed: false,
+    },
+  });
+
+  const compact = renderPanelResult({ state }, false, theme).render(160).join("\n");
+  assert.match(compact, /1\.2K tok/);
+  assert.match(compact, /\$0\.1234/);
+
+  const content = buildPanelResultContent(state);
+  // Classic CLI-style ASCII footer (not the old ### Run metrics markdown table).
+  assert.match(content, /── pi-review panel/);
+  assert.match(content, /Duration\s+1\.2s/);
+  assert.match(content, /Tokens\s+.*total 1\.2K|Tokens\s+.*1\.2K total|total:1\.2K|total 1\.2K/);
+  assert.match(content, /Cost\s+\$0\.1234|cost:\$0\.1234/);
+  assert.match(content, /r1/);
+  assert.match(content, /\$0\.0617/);
+});
+
+test("panel tool updates and clears ambient footer status during execute", async () => {
+  const statuses: Array<string | undefined> = [];
+  let registered: { execute: (...args: any[]) => Promise<any> } | undefined;
+  registerPanelReviewTool({
+    registerTool(tool: { execute: (...args: any[]) => Promise<any> }) {
+      registered = tool;
+    },
+  } as never);
+  assert.ok(registered);
+
+  const result = await registered!.execute(
+    "tool-call",
+    { target: "@src", reviewers: 1 },
+    new AbortController().signal,
+    undefined,
+    {
+      ui: {
+        setStatus(key: string, text: string | undefined) {
+          assert.equal(key, "pi-review");
+          statuses.push(text);
+        },
+      },
+    },
+  );
+
+  assert.equal(result.isError, true);
+  // Param errors clear status immediately; never leave a stale footer entry.
+  assert.ok(statuses.includes(undefined));
+});
+
+test("panel tool content carries full conclusion for the parent LLM", () => {
+  const now = Date.now();
+  let state = reducePanelEvent(createPanelViewState(), {
+    v: 1,
+    runId: "run-content",
+    seq: 1,
+    at: now,
+    type: "panel.started",
+    target: "@src",
+    mode: "code",
+    reviewers: [{ reviewerId: "security", role: "Security", model: "openai/gpt", thinking: "high" }],
+  });
+  state = reducePanelEvent(state, {
+    v: 1,
+    runId: "run-content",
+    seq: 2,
+    at: now,
+    type: "reviewer.completed",
+    reviewerId: "security",
+    submission: {
+      reviewerId: "security",
+      role: "Security",
+      model: "openai/gpt",
+      thinking: "high",
+      durationMs: 100,
+      result: {
+        status: "has_findings",
+        verdict: "request_changes",
+        verdictSource: "parsed",
+        actionableCount: 1,
+        findings: [{ summary: "Auth bypass in session cookie", actionable: true, path: "src/auth.ts" }],
+      },
+    },
+  });
+  state = reducePanelEvent(state, {
+    v: 1,
+    runId: "run-content",
+    seq: 3,
+    at: now,
+    type: "panel.completed",
+    meta: {
+      strategy: "panel",
+      reviewMode: "code",
+      status: "has_findings",
+      verdict: "request_changes",
+      verdictSource: "parsed",
+      findings: [],
+      actionableCount: 1,
+      durationMs: 1200,
+      model: "openai/gpt",
+      configuredReviewers: 1,
+      successfulReviewers: 1,
+      consensusPolicy: "quorum",
+      consensusThreshold: 1,
+      panelHealth: "healthy",
+      confirmedClusters: [{ id: "C1", summary: "Auth bypass", supportingReviewerIds: ["security"], sourceFindingIds: ["F1"], confirmed: true, severity: "high", path: "src/auth.ts", supportCount: 1, actionableSupportCount: 1 }],
+      advisories: [{ id: "C2", summary: "Naming nit", supportingReviewerIds: ["security"], sourceFindingIds: ["F2"], confirmed: false, supportCount: 1, actionableSupportCount: 0 }],
+      reviewers: [{ reviewerId: "security", role: "Security", model: "openai/gpt", thinking: "high", durationMs: 1100, status: "has_findings", verdict: "request_changes", verdictSource: "parsed", contributed: true }],
+      adjudicationUsed: false,
+    },
+  });
+
+  const content = buildPanelResultContent(state);
+  assert.match(content, /── pi-review panel/);
+  assert.match(content, /Confirmed findings:/);
+  assert.match(content, /Auth bypass/);
+  assert.match(content, /Advisories \(non-blocking\):/);
+  assert.match(content, /Naming nit/);
+  assert.match(content, /Status\s+has findings|HAS FINDINGS|has_findings/);
+  assert.match(content, /security/);
+  assert.match(content, /openai\/gpt/);
+  assert.match(content, /Reviewer summaries:/);
+  assert.match(content, /Auth bypass in session cookie/);
+  assert.doesNotMatch(content, /### |```/);
+
+  const expanded = renderPanelResult({ state }, true, theme).render(160).join("\n");
+  assert.match(expanded, /── pi-review panel/);
+  assert.match(expanded, /Reviewer summaries:/);
+  assert.match(expanded, /Auth bypass in session cookie/);
+  assert.doesNotMatch(expanded, /### |```/);
 });