@zephyrdeng/pi-review 0.7.0 → 0.7.1

package/dist/types.js.map

@@ -1 +1 @@
-{"version":3,"file":"types.js","sourceRoot":"","sources":["../src/types.ts"],"names":[],"mappings":"AAAA,MAAM,CAAC,MAAM,QAAQ,GAAG,CAAC,SAAS,EAAE,iBAAiB,EAAE,qBAAqB,EAAE,SAAS,CAAU,CAAC;AAGlG,MAAM,CAAC,MAAM,eAAe,GAAG,CAAC,OAAO,EAAE,cAAc,EAAE,aAAa,EAAE,SAAS,CAAU,CAAC;AA4F5F,8EAA8E;AAC9E,eAAe;AACf,8EAA8E;AAE9E,MAAM,CAAC,MAAM,kBAAkB,GAAG,CAAC,KAAK,EAAE,QAAQ,EAAE,UAAU,EAAE,WAAW,CAAU,CAAC;AActF,mEAAmE;AACnE,MAAM,CAAC,MAAM,aAAa,GAAG,CAAC,CAAC;AAE/B,mEAAmE;AACnE,MAAM,CAAC,MAAM,uBAAuB,GAAG,CAAC,CAAC;AAEzC,iFAAiF;AACjF,MAAM,CAAC,MAAM,mCAAmC,GAAG,GAAG,CAAC"}
+{"version":3,"file":"types.js","sourceRoot":"","sources":["../src/types.ts"],"names":[],"mappings":"AAAA,MAAM,CAAC,MAAM,QAAQ,GAAG,CAAC,SAAS,EAAE,iBAAiB,EAAE,qBAAqB,EAAE,SAAS,CAAU,CAAC;AAGlG,MAAM,CAAC,MAAM,eAAe,GAAG,CAAC,OAAO,EAAE,cAAc,EAAE,aAAa,EAAE,SAAS,CAAU,CAAC;AA8F5F,8EAA8E;AAC9E,eAAe;AACf,8EAA8E;AAE9E,MAAM,CAAC,MAAM,kBAAkB,GAAG,CAAC,KAAK,EAAE,QAAQ,EAAE,UAAU,EAAE,WAAW,CAAU,CAAC;AActF,mEAAmE;AACnE,MAAM,CAAC,MAAM,aAAa,GAAG,CAAC,CAAC;AAE/B,yDAAyD;AACzD,MAAM,CAAC,MAAM,qBAAqB,GAAG,CAAC,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,IAAI,CAAU,CAAC;AAE7E,mEAAmE;AACnE,MAAM,CAAC,MAAM,uBAAuB,GAAG,CAAC,CAAC;AAEzC,iFAAiF;AACjF,MAAM,CAAC,MAAM,mCAAmC,GAAG,GAAG,CAAC"}

package/extensions/panel-tool.test.ts

@@ -0,0 +1,30 @@
+import assert from "node:assert/strict";
+import { test } from "node:test";
+import { createPanelViewState, reducePanelEvent } from "@zephyrdeng/pi-review";
+import { renderPanelResult } from "./panel-tool.js";
+
+const theme = {
+  fg: (_color: "toolTitle" | "muted" | "error" | "success" | "accent", text: string) => text,
+  bold: (text: string) => text,
+};
+
+test("Pi panel renderer exposes compact reviewer progress and expanded activity", () => {
+  const now = Date.now();
+  const started = reducePanelEvent(createPanelViewState(), {
+    v: 1,
+    runId: "run-1",
+    seq: 1,
+    at: now,
+    type: "panel.started",
+    target: "@src",
+    mode: "code",
+    reviewers: [{ reviewerId: "security", role: "Security", model: "openai/gpt" }],
+  });
+  const reviewerStarted = reducePanelEvent(started, { v: 1, runId: "run-1", seq: 2, at: now, type: "reviewer.started", reviewerId: "security" });
+  const running = reducePanelEvent(reviewerStarted, { v: 1, runId: "run-1", seq: 3, at: now, type: "reviewer.tool.started", reviewerId: "security", tool: "read" });
+  const compact = renderPanelResult({ state: running }, false, theme).render(120).join("\n");
+  const expanded = renderPanelResult({ state: running }, true, theme).render(120).join("\n");
+  assert.match(compact, /pi-review panel 0\/1 completed/);
+  assert.match(compact, /security Security · read · 0s/);
+  assert.match(expanded, /security activity/);
+});

package/extensions/panel-tool.ts

@@ -0,0 +1,169 @@
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+import { Writable } from "node:stream";
+import { Type } from "typebox";
+import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
+import { Container, Markdown, Spacer, Text, type Component } from "@earendil-works/pi-tui";
+import { createPanelViewState, reducePanelEvent, spawnStreamingChild, type PanelViewState, type ReviewEvent } from "@zephyrdeng/pi-review";
+
+type Theme = { fg: (color: "toolTitle" | "muted" | "error" | "success" | "accent", text: string) => string; bold: (text: string) => string };
+type PanelToolDetails = { state: PanelViewState; error?: string };
+
+const extensionDir = path.dirname(fileURLToPath(import.meta.url));
+const cliPath = path.resolve(extensionDir, "../bin/pi-review.js");
+
+function duration(ms: number | undefined): string {
+  if (!ms) return "0s";
+  return `${Math.floor(ms / 1000)}s`;
+}
+
+function usageTokens(state: PanelViewState): string {
+  return state.aggregate.usage ? `${state.aggregate.usage.totalTokens.toLocaleString()} tok` : "—";
+}
+
+function statusSymbol(status: string): string {
+  return status === "completed" ? "✓" : status === "failed" || status === "cancelled" ? "✗" : status === "running" ? "●" : "○";
+}
+
+function compactText(state: PanelViewState, theme: Theme): string {
+  const elapsed = state.startedAt ? duration((state.completedAt ?? Date.now()) - state.startedAt) : "0s";
+  const progress = `${state.aggregate.completed}/${state.aggregate.total} completed`;
+  const header = theme.fg("toolTitle", theme.bold(`pi-review panel ${progress}`)) + theme.fg("muted", ` · ${state.phase} · ${elapsed} · ${usageTokens(state)}`);
+  const rows = Object.values(state.reviewers).map((reviewer) => {
+    const active = reviewer.activeTool ? ` · ${reviewer.activeTool}` : "";
+    const elapsed = reviewer.startedAt ? ` · ${duration((reviewer.completedAt ?? Date.now()) - reviewer.startedAt)}` : "";
+    const tokens = reviewer.usage ? ` · ${reviewer.usage.totalTokens.toLocaleString()} tok` : "";
+    return `${theme.fg(reviewer.status === "failed" ? "error" : reviewer.status === "completed" ? "success" : "accent", statusSymbol(reviewer.status))} ${theme.fg("toolTitle", reviewer.reviewerId)}${theme.fg("muted", ` ${reviewer.role}${active}${elapsed}${tokens}`)}`;
+  });
+  return [header, ...rows].join("\n");
+}
+
+function finalMarkdown(state: PanelViewState): string {
+  const meta = state.meta;
+  if (!meta) return "";
+  const confirmed = meta.confirmedClusters.map((finding) => `- ${finding.summary} (${finding.supportingReviewerIds.join(", ")})`);
+  const advisories = meta.advisories.map((finding) => `- ${finding.summary} (${finding.supportingReviewerIds.join(", ")})`);
+  return [
+    "### Panel result",
+    `Health: ${meta.panelHealth}; status: ${meta.status}.`,
+    confirmed.length ? `### Confirmed findings\n${confirmed.join("\n")}` : "### Confirmed findings\nNone.",
+    advisories.length ? `### Advisories\n${advisories.join("\n")}` : "",
+  ].filter(Boolean).join("\n\n");
+}
+
+export function renderPanelResult(details: PanelToolDetails | undefined, expanded: boolean, theme: Theme, previous?: Component): Component {
+  if (!details) return new Text(theme.fg("muted", "Panel review has no progress details."), 0, 0);
+  if (!expanded) {
+    const text = previous instanceof Text ? previous : new Text("", 0, 0);
+    text.setText(compactText(details.state, theme));
+    return text;
+  }
+  const container = new Container();
+  container.addChild(new Text(compactText(details.state, theme), 0, 0));
+  for (const reviewer of Object.values(details.state.reviewers)) {
+    if (reviewer.recentActivity.length === 0) continue;
+    container.addChild(new Spacer(1));
+    container.addChild(new Text(theme.fg("muted", `${reviewer.reviewerId} activity`), 0, 0));
+    container.addChild(new Text(reviewer.recentActivity.join("\n"), 0, 0));
+  }
+  const markdown = finalMarkdown(details.state);
+  if (markdown) {
+    container.addChild(new Spacer(1));
+    // Pi supplies a Markdown theme to built-in renderers; plain text keeps this
+    // extension portable across public API versions while still using Markdown.
+    container.addChild(new Markdown(markdown, 0, 0, {
+      heading: theme.bold,
+      link: (text) => text,
+      linkUrl: (text) => text,
+      code: (text) => text,
+      codeBlock: (text) => text,
+      codeBlockBorder: (text) => text,
+      quote: (text) => text,
+      quoteBorder: (text) => text,
+      hr: (text) => text,
+      listBullet: (text) => text,
+      bold: theme.bold,
+      italic: (text) => text,
+      strikethrough: (text) => text,
+      underline: (text) => text,
+    }));
+  }
+  if (details.error) {
+    container.addChild(new Spacer(1));
+    container.addChild(new Text(theme.fg("error", details.error), 0, 0));
+  }
+  return container;
+}
+
+export function registerPanelReviewTool(pi: ExtensionAPI): void {
+  pi.registerTool({
+    name: "pi_review",
+    label: "Pi Review Panel",
+    description: "Run an isolated read-only pi-review panel and render each reviewer live.",
+    renderShell: "self",
+    parameters: Type.Object({
+      target: Type.String({ description: "Review target, such as @src or a code-review brief." }),
+      mode: Type.Optional(Type.String({ description: "Review mode; defaults to code." })),
+      panel: Type.Optional(Type.String({ description: "Named panel preset; defaults to code-experts." })),
+      model: Type.Optional(Type.String({ description: "Optional reviewer model." })),
+      thinking: Type.Optional(Type.String({ description: "Optional thinking level." })),
+    }),
+    async execute(_toolCallId, params, signal, onUpdate) {
+      let state = createPanelViewState();
+      let buffer = "";
+      let stderr = "";
+      const publish = () => onUpdate?.({ content: [{ type: "text", text: `Panel: ${state.aggregate.completed}/${state.aggregate.total} completed` }], details: { state } });
+      const consume = (chunk: string) => {
+        buffer += chunk;
+        let newline: number;
+        while ((newline = buffer.indexOf("\n")) >= 0) {
+          const line = buffer.slice(0, newline);
+          buffer = buffer.slice(newline + 1);
+          try {
+            state = reducePanelEvent(state, JSON.parse(line) as ReviewEvent);
+            publish();
+          } catch {
+            // Only the stable pi-review event protocol reaches this stream.
+          }
+        }
+      };
+      const stdoutSink = new Writable({ write(chunk, _encoding, callback) { consume(String(chunk)); callback(); } });
+      const stderrSink = new Writable({
+        write(chunk, _encoding, callback) {
+          const next = stderr + String(chunk);
+          stderr = next.length > 2000 ? next.slice(-2000) : next;
+          callback();
+        },
+      });
+      const args = [cliPath, "--panel", params.panel ?? "code-experts", "--mode", params.mode ?? "code", "--output-format", "events-jsonl"];
+      if (params.model) args.push("--model", params.model);
+      if (params.thinking) args.push("--thinking", params.thinking);
+      args.push("--", params.target);
+      const child = await spawnStreamingChild(process.execPath, args, { cwd: process.cwd(), env: process.env, stdoutSink, stderrSink, signal, processGroup: true });
+      if (buffer.trim()) {
+        const tail = buffer;
+        buffer = "";
+        consume(`${tail}\n`);
+      }
+      const error = child.error
+        ? child.error.message
+        : state.meta
+          ? undefined
+          : [`pi-review ended before a final event (${child.status ?? child.signal ?? "unknown"})`, stderr.trim()].filter(Boolean).join(": ");
+      const details: PanelToolDetails = { state, ...(error ? { error } : {}) };
+      return {
+        content: [{ type: "text", text: error ?? `Panel completed: ${state.meta?.status ?? "unknown"}` }],
+        details,
+        ...(error ? { isError: true } : {}),
+      };
+    },
+    renderCall(args, theme, context) {
+      const text = context.lastComponent instanceof Text ? context.lastComponent : new Text("", 0, 0);
+      text.setText(theme.fg("toolTitle", theme.bold("pi_review ")) + theme.fg("muted", `${args.panel ?? "code-experts"} · ${args.mode ?? "code"} · ${args.target}`));
+      return text;
+    },
+    renderResult(result, { expanded }, theme, context) {
+      return renderPanelResult(result.details as PanelToolDetails | undefined, expanded, theme, context.lastComponent);
+    },
+  });
+}

package/extensions/review.ts

@@ -10,6 +10,7 @@ import {
   RV_COMPLETIONS,
   validateRvParsed,
 } from "./rv-prompts.js";
+import { registerPanelReviewTool } from "./panel-tool.js";
 
 /**
  * Captured at `session_start` so the synchronous-ish `getArgumentCompletions`
@@ -68,6 +69,7 @@ function toModelInfo(m: {
 }
 
 export default function piReviewExtension(pi: ExtensionAPI) {
+  registerPanelReviewTool(pi);
   pi.on("session_start", (_event, ctx) => {
     try {
       const available = ctx.modelRegistry?.getAvailable?.() ?? [];
@@ -130,4 +132,4 @@ export default function piReviewExtension(pi: ExtensionAPI) {
       pi.sendUserMessage(buildRvOrchestrationPrompt(parsed, localeForHandler(ctx)));
     },
   });
-}
+}

package/extensions/rv-prompts.test.ts

@@ -70,10 +70,17 @@ describe("parseRvArgs / validateRvParsed", () => {
     const p = parseRvArgs("@src/foo.ts");
     const prompt = buildRvOrchestrationPrompt(p);
     assert.match(prompt, /Do NOT add --no-stream or --progress-log/);
+    assert.match(prompt, /rendered panel result and status/);
     assert.match(prompt, /ASCII pi-review footer/);
     assert.doesNotMatch(prompt, /PI_REVIEW_META:/);
   });
 
+  it("continuations retain the session-aware CLI path", () => {
+    const prompt = buildRvOrchestrationPrompt(parseRvArgs("--continue /tmp/review.jsonl @src/foo.ts"));
+    assert.match(prompt, /Execute:\npi-review --continue \/tmp\/review\.jsonl -- @src\/foo\.ts/);
+    assert.doesNotMatch(prompt, /Call pi_review with target/);
+  });
+
   it("buildPiReviewArgv matches for initial and continue", () => {
     const initial = parseRvArgs("--mode plan --model m/a @doc.md");
     assert.deepEqual(buildPiReviewArgv(initial, "@doc.md"), [
@@ -99,4 +106,4 @@ describe("parseRvArgs / validateRvParsed", () => {
       "more",
     ]);
   });
-});
+});

package/extensions/rv-prompts.ts

@@ -144,10 +144,10 @@ function piHostRules(): string {
   return [
     "Follow the pi-review skill.",
     "Host: Pi interactive session (/rv).",
-    "Run pi-review in an isolated child session; return the review conclusion (Markdown sections) plus the ASCII pi-review footer.",
+    "For new review runs, call the pi_review custom tool. It launches pi-review in isolated reviewer sessions and renders panel progress live.",
     "CLI defaults: stream child output live. Do NOT add --no-stream or --progress-log unless the user explicitly asked.",
     "Do not edit, patch, commit, or implement findings unless the user asks separately.",
-    "After pi-review exits, show the user the ASCII footer (lines starting with ── pi-review). Do not paste PI_REVIEW_META_JSON to the user; use Session from the footer for /rv --continue.",
+    "For pi_review panel runs, report the tool's rendered panel result and status. For CLI fallback and --continue runs, show the ASCII pi-review footer (lines starting with ── pi-review). Do not paste PI_REVIEW_META_JSON to the user; use Session from a CLI footer for /rv --continue.",
   ].join(" ");
 }
 
@@ -216,7 +216,9 @@ export function buildRvOrchestrationPrompt(parsed: RvParsed, locale: RvLocale =
       `Mode: ${parsed.mode}. Follow the preset named in review-presets.json when present.`,
     modelStep,
     continueNote,
-    `Execute:\n${cliLine}`,
+    parsed.continueHandle || parsed.keepSession || parsed.noStream
+      ? `Execute:\n${cliLine}`
+      : `Call pi_review with target=${JSON.stringify(target)}, mode=${JSON.stringify(parsed.mode)}, and any selected model/thinking values. The tool uses the code-experts panel by default.`,
   ]
     .filter(Boolean)
     .join("\n\n");
@@ -233,4 +235,4 @@ export const RV_COMPLETIONS: { value: string; hint: string }[] = [
   { value: "--keep-session", hint: "persist session for follow-up" },
   { value: "--no-stream", hint: "rare: buffer until exit (not default in Pi)" },
   { value: "--continue ", hint: "resume session; same optional flags as initial /rv" },
-];
+];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zephyrdeng/pi-review",
-  "version": "0.7.0",
+  "version": "0.7.1",
   "description": "Isolated AI-powered code and plan reviews from the command line",
   "type": "module",
   "author": "ZephyrDeng <zephyrTang@aliyun.com>",
@@ -50,14 +50,20 @@
     ]
   },
   "peerDependencies": {
-    "@earendil-works/pi-coding-agent": "*"
+    "@earendil-works/pi-coding-agent": "*",
+    "@earendil-works/pi-tui": "*"
   },
   "peerDependenciesMeta": {
     "@earendil-works/pi-coding-agent": {
       "optional": true
+    },
+    "@earendil-works/pi-tui": {
+      "optional": true
     }
   },
   "devDependencies": {
+    "@earendil-works/pi-coding-agent": "^0.80.7",
+    "@earendil-works/pi-tui": "^0.80.7",
     "@types/node": "^22.0.0",
     "husky": "^9.1.7",
     "typescript": "^5.8.0"
@@ -65,14 +71,17 @@
   "scripts": {
     "prepare": "husky",
     "build": "tsc",
-    "check": "tsc --noEmit",
+    "check": "tsc --noEmit && tsc --noEmit -p tsconfig.extension.json",
     "smoke": "node dist/cli.js --help >/dev/null",
-    "test": "npx --yes tsx --test src/args.test.ts src/cli-exit.test.ts src/child-process.test.ts src/review.meta.test.ts src/review-result.test.ts src/loop.test.ts src/meta-footer.test.ts src/prompt.test.ts src/skill-protocol.test.ts src/json-events.test.ts src/install-args.test.ts src/panel-aggregate.test.ts src/matcher.test.ts src/panel-config.test.ts src/panel-loop.test.ts src/panel-cli.test.ts extensions/rv-prompts.test.ts extensions/rv-completions.test.ts extensions/rv-model-priorities.test.ts extensions/rv-locale.test.ts extensions/rv-semantic.test.ts",
+    "test": "npm run build && npx --yes tsx --test src/args.test.ts src/cli-exit.test.ts src/child-process.test.ts src/review.meta.test.ts src/review-result.test.ts src/loop.test.ts src/meta-footer.test.ts src/prompt.test.ts src/skill-protocol.test.ts src/json-events.test.ts src/install-args.test.ts src/panel-aggregate.test.ts src/matcher.test.ts src/panel-config.test.ts src/panel-loop.test.ts src/panel-cli.test.ts src/review-events.test.ts src/panel-view.test.ts src/panel-cancellation.test.ts src/panel-tools.test.ts extensions/rv-prompts.test.ts extensions/rv-completions.test.ts extensions/rv-model-priorities.test.ts extensions/rv-locale.test.ts extensions/rv-semantic.test.ts extensions/panel-tool.test.ts",
     "test:rv": "npx --yes tsx --test extensions/rv-prompts.test.ts extensions/rv-completions.test.ts extensions/rv-model-priorities.test.ts extensions/rv-locale.test.ts extensions/rv-semantic.test.ts",
     "prepublishOnly": "npm run build",
     "pack:dry": "npm pack --dry-run"
   },
   "engines": {
     "node": ">=20"
+  },
+  "dependencies": {
+    "typebox": "^1.1.38"
   }
 }

package/resources/review-presets.json

@@ -1,9 +1,9 @@
 {
   "code": {
     "description": "Code review only: inspect provided files, diffs, or paths and return review conclusions without editing.",
-    "tools": ["read", "grep", "find", "ls", "bash"],
+    "tools": ["read", "grep", "find", "ls"],
     "thinking": "high",
-    "instructions": "Review code or code changes only. Do not edit, write, patch, format, commit, or otherwise mutate files. Use bash only for read-only inspection commands such as git diff, git status, git show, tests with explicit user permission, or listing files. Focus on correctness, regressions, security, concurrency, API contracts, edge cases, maintainability, and missing tests."
+    "instructions": "Review code or code changes only. Do not edit, write, patch, format, commit, or otherwise mutate files. Use the enabled read-only tools for inspection. Focus on correctness, regressions, security, concurrency, API contracts, edge cases, maintainability, and missing tests."
   },
   "plan": {
     "description": "High-level plan review with multiple expert lenses; output a decisive conclusion.",

package/skills/pi-review/SKILL.md

@@ -34,14 +34,14 @@ When resolving this fallback, use the actual directory that contains this `SKILL
 
 | Host | How to run `pi-review` |
 |------|-------------------------|
-| **Pi** (`/rv`) | Foreground CLI, **default streaming** only. Do **not** add `--no-stream` or `--progress-log` unless the user explicitly asks. |
+| **Pi** (`/rv`) | New reviews call the native `pi_review` tool, which launches the packaged CLI in event mode and renders live Panel state. Continuations, kept sessions, and explicit `--no-stream` retain the foreground CLI path. |
 | **Claude Code, Codex, Cursor**, and similar AI agents | **Default: `--progress-log <path>` + background run + tail** (see below). Do **not** rely on foreground Bash stdout for “streaming” — the tool buffers until exit. |
 | Scripts / CI | Foreground is fine; use `--no-stream` only when you must buffer until exit. |
 
 ## Pi host (`/rv`)
 
-- In **Pi interactive** sessions, run `pi-review` with **default streaming only** — do **not** add `--no-stream` or `--progress-log` unless the user explicitly asks.
-- The `/rv` extension injects these rules into the parent agent; ordinary `/rv @path` needs no extra flags.
+- In **Pi interactive** sessions, ordinary `/rv @path` calls the native `pi_review` tool and needs no streaming flags. The tool owns normalized events, live rendering, and the packaged CLI process.
+- `--continue`, `--keep-session`, and explicit `--no-stream` use the shell CLI path because they retain single-review session semantics.
 
 ## Streaming vs agent hosts (Claude Code / Codex)