@zephyrdeng/pi-review 0.14.0 → 0.15.0

package/extensions/rv-config.ts

@@ -0,0 +1,150 @@
+/**
+ * /rv-config: show the effective pi-review configuration — the persistent
+ * config file (~/.pi/pi-review/config.json), per-process env overrides, and
+ * the resolved paths the CLI will use. Read-only, plain text (no markdown),
+ * locale-aware like the other /rv* commands.
+ */
+
+import {
+  configFilePath,
+  loadReviewConfigFile,
+  parseReviewConfig,
+  resolveChildExtensions,
+  resolveConfig,
+} from "@zephyrdeng/pi-review";
+import type { PiReviewConfig } from "@zephyrdeng/pi-review";
+import type { RvLocale } from "./rv-locale.js";
+
+export interface RvConfigViewInput {
+  locale: RvLocale;
+  env?: NodeJS.ProcessEnv;
+  /** Override the config file path (tests). */
+  configPath?: string;
+  /** Override config file content (tests); null means the file is missing. */
+  readConfig?: (file: string) => string | null;
+  /** Override the resolved environment keys (tests). */
+  resolved?: ReturnType<typeof resolveConfig>;
+}
+
+type Strings = {
+  header: string;
+  childExtensions: string;
+  configFileLabel: string;
+  configFileMissing: string;
+  envSection: string;
+  sourceDefault: string;
+  sourceConfig: string;
+  sourceEnv: string;
+  warnFile: (reason: string) => string;
+  piBin: string;
+  reviewHome: string;
+  presetsFile: string;
+  panelPresetsFile: string;
+  systemPromptFile: string;
+  sessionsRoot: string;
+};
+
+const STRINGS: Record<RvLocale, Strings> = {
+  en: {
+    header: "Pi Review config",
+    childExtensions:
+      "Load host Pi extensions in review children so providers registered only by extensions (e.g. px:anthropic, zenmux) are usable; false keeps children isolated with --no-extensions (issue #8). Override one run: PI_REVIEW_CHILD_EXTENSIONS=1 or =0.",
+    configFileLabel: "config file",
+    configFileMissing: "(missing — using defaults)",
+    envSection: "Resolved environment",
+    sourceDefault: "default",
+    sourceConfig: "config file",
+    sourceEnv: "env override",
+    warnFile: (reason) => `config warning: ${reason} — using defaults for that key`,
+    piBin: "Pi executable used to spawn review children.",
+    reviewHome: "Directory holding the default presets and system prompt.",
+    presetsFile: "Review mode presets (code / plan / challenge).",
+    panelPresetsFile: "Named panel presets (e.g. code-experts).",
+    systemPromptFile: "Extra system prompt appended to every review child.",
+    sessionsRoot: "Persisted --keep-session review sessions.",
+  },
+  zh: {
+    header: "Pi Review 配置",
+    childExtensions:
+      "是否让评审子进程加载宿主 Pi 扩展，以使用仅由扩展注册的 provider（如 px:anthropic、zenmux）；false 表示隔离运行（--no-extensions，issue #8）。单次覆盖：PI_REVIEW_CHILD_EXTENSIONS=1 或 =0。",
+    configFileLabel: "配置文件",
+    configFileMissing: "（不存在——使用默认值）",
+    envSection: "生效环境",
+    sourceDefault: "默认",
+    sourceConfig: "配置文件",
+    sourceEnv: "env 覆盖",
+    warnFile: (reason) => `配置警告：${reason}——该键按未设置处理`,
+    piBin: "用于启动评审子进程的 Pi 可执行文件。",
+    reviewHome: "存放默认 presets 与系统提示词的目录。",
+    presetsFile: "评审模式预设（code / plan / challenge）。",
+    panelPresetsFile: "命名评审面板预设（如 code-experts）。",
+    systemPromptFile: "附加到每个评审子进程的系统提示词。",
+    sessionsRoot: "持久化 --keep-session 评审会话的目录。",
+  },
+};
+
+function warnNotes(s: Strings, warnings: string[]): string[] {
+  return warnings.map((w) => s.warnFile(w));
+}
+
+/**
+ * Build the /rv-config display lines. Pure apart from reading the config file
+ * (inject readConfig for tests; null means the file is missing).
+ *
+ * The config is advisory and lenient: nothing here can fail the CLI, so the
+ * view and the CLI always agree — warnings are displayed, values fall back.
+ */
+export function buildRvConfigLines(input: RvConfigViewInput): string[] {
+  const s = STRINGS[input.locale];
+  const env = input.env ?? process.env;
+  const file = input.configPath ?? configFilePath(env);
+
+  let cfg: PiReviewConfig = {};
+  const configNotes: string[] = [];
+  if (input.readConfig) {
+    let text: string | null;
+    try {
+      text = input.readConfig(file);
+    } catch (error) {
+      configNotes.push(s.warnFile(String((error as Error).message)));
+      text = null;
+    }
+    if (text !== null) {
+      const load = parseReviewConfig(text);
+      cfg = load.config;
+      configNotes.push(...warnNotes(s, load.warnings));
+    } else if (configNotes.length === 0) {
+      configNotes.push(s.configFileMissing);
+    }
+  } else {
+    const load = loadReviewConfigFile(file);
+    cfg = load.config;
+    configNotes.push(...warnNotes(s, load.warnings));
+  }
+
+  const decision = resolveChildExtensions(env, cfg);
+  const sourceLabel =
+    decision.source === "env" ? s.sourceEnv : decision.source === "config" ? s.sourceConfig : s.sourceDefault;
+
+  const resolved = input.resolved ?? resolveConfig();
+  const line = (key: string, value: string, description: string): string => {
+    const head = `${key}: ${value}`;
+    return [head, `  ${description}`].join("\n");
+  };
+
+  const lines: string[] = [];
+  lines.push(s.header);
+  lines.push(`childExtensions: ${decision.enabled} (${sourceLabel})`);
+  lines.push(`  ${s.childExtensions}`);
+  lines.push(`${s.configFileLabel}: ${file}`);
+  for (const note of configNotes) lines.push(`  ${note}`);
+  lines.push("");
+  lines.push(s.envSection);
+  lines.push(line("piBin", resolved.piBin, s.piBin));
+  lines.push(line("reviewHome", resolved.reviewHome, s.reviewHome));
+  lines.push(line("presetsFile", resolved.presetsFile, s.presetsFile));
+  lines.push(line("panelPresetsFile", resolved.panelPresetsFile, s.panelPresetsFile));
+  lines.push(line("systemPromptFile", resolved.systemPromptFile, s.systemPromptFile));
+  lines.push(line("sessionsRoot", resolved.sessionsRoot, s.sessionsRoot));
+  return lines;
+}

package/extensions/rv-prompts.ts

@@ -532,7 +532,7 @@ function piHostRules(strategy: RvStrategy): string {
   return [
     "Follow the pi-review skill.",
     "Host: Pi interactive session (/rv*).",
-    "Slash commands select strategy only: /rv = panel review, /rv-loop = loop closeout, /rv-models = model catalog.",
+    "Slash commands select strategy only: /rv = panel review, /rv-loop = loop closeout, /rv-models = model catalog, /rv-config = effective configuration.",
     "Everything after the command is a natural-language review request. Path mentions like @src are fine as text.",
     "Do not expand directory targets into multi-file lists. Strategy matching beyond the slash command (mode defaults, model choice, panel preset, path-vs-file handling) lives in the pi-review skill and CLI.",
     strategy === "panel"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zephyrdeng/pi-review",
-  "version": "0.14.0",
+  "version": "0.15.0",
   "description": "Isolated AI-powered code and plan reviews from the command line",
   "type": "module",
   "author": "ZephyrDeng <zephyrTang@aliyun.com>",

package/resources/providers/orcarouter.json

@@ -0,0 +1,28 @@
+{
+  "providers": {
+    "orcarouter": {
+      "baseUrl": "https://api.orcarouter.ai/v1",
+      "api": "openai-completions",
+      "apiKey": "ORCA_KEY",
+      "signupUrl": "https://www.orcarouter.ai/ref/ref_07ca74b3e41670e5ff36",
+      "models": [
+        {
+          "id": "orcarouter/auto",
+          "name": "OrcaRouter Auto",
+          "reasoning": false,
+          "input": ["text"],
+          "contextWindow": 200000,
+          "maxTokens": 8192
+        },
+        {
+          "id": "anthropic/claude-sonnet-4.6",
+          "name": "Claude Sonnet 4.6",
+          "reasoning": true,
+          "input": ["text"],
+          "contextWindow": 200000,
+          "maxTokens": 8192
+        }
+      ]
+    }
+  }
+}

package/skills/pi-review/SKILL.md

@@ -21,6 +21,17 @@ If `pi-review` is not on PATH but this skill came from the Pi package, use the p
 node ../../bin/pi-review.js --help
 ```
 
+## Registered providers (explicit opt-in)
+
+Review children stay isolated (`--no-extensions`) unless the persistent review config enables host extensions. Enable them only when the review needs an extension-registered provider (e.g. `px:anthropic`, `zenmux`) — and only with explicit user acceptance:
+
+```json
+// ~/.pi/pi-review/config.json
+{ "childExtensions": true }
+```
+
+Before writing, tell the user the config is machine-level: every later pi-review on this machine (including bare CLI) inherits it. Write it only on acceptance; when editing an existing file, keep every unknown key and never overwrite a value the user set (invalid JSON — stop, do not overwrite). Verify on Pi with `/rv-config`, elsewhere with `cat ~/.pi/pi-review/config.json`. Isolate one run with `PI_REVIEW_CHILD_EXTENSIONS=0` (env overrides config). If a child exits with stale extension ctx after dispose/reload (issue #8), retry that one run with `PI_REVIEW_CHILD_EXTENSIONS=0`.
+
 ## Default workflow by host
 
 | Host | How to run `pi-review` |
@@ -51,6 +62,7 @@ Slash commands select **strategy only**. Everything after the command is a **nat
 | `/rv <natural-language target>` | Panel review via native **Pi Review Panel** (`pi_review` API tool); preset `code-experts` unless `--reviewers`/`--panel` say otherwise |
 | `/rv-loop <natural-language target>` | Loop closeout via shell `pi-review loop`; host fix point `--max-rounds 1` by default |
 | `/rv-models` | Model catalog only |
+| `/rv-config` | Show the effective configuration (config file, env overrides, resolved paths) |
 | `/rv --continue <handle> [text]` | Continue a kept single-review session |
 
 - Pass the user target **as given**. Path mentions like `@src` or `@src/foo.ts` are fine as text. Do **not** expand directories into multi-file lists in the parent agent.
@@ -184,6 +196,7 @@ pi-review --reviewers 3 --ui web --ui-url-file /tmp/pi-review-ui-url.txt -- @src
    pi-review models [search]
    ```
    Rules:
+   - Extension-registered providers appear in the catalog only when the config enables them (`childExtensions: true`, see **Registered providers** — explicit opt-in).
    - Run this before building the review command. **Never invent a `provider/model` id** — only ids from the catalog output.
    - **Cross-model review**: identify the model this host session itself runs on (its id is in your session context), then prefer reviewer models from a different model family — same-family reviewers share the author model's blind spots. On a panel, keep the host's family to a minority of reviewers.
    - Follow **[references/model-selection.md](./references/model-selection.md)** for everything else: profile inference (code / frontend / plan), priority lists, cross-model resolution, user-named-model resolution, and thinking aliases (`max`/`最高` → `xhigh`, with fallback to the nearest supported level).
@@ -204,7 +217,7 @@ pi-review --reviewers 3 --ui web --ui-url-file /tmp/pi-review-ui-url.txt -- @src
    pi-review [--mode <name>] [--model <provider/model[:thinking]>] [--keep-session|--continue <handle>] [--progress-log <path>] -- <natural-language target...>
    ```
    Rules:
-   - Use the model decision from step 1 and the execution path from **Default workflow by host**.
+   - Use the model decision from step 1 and the execution path from **Default workflow by host**. **Registered providers** enable host extensions only after explicit user acceptance (see **Registered providers**); override a single run with `PI_REVIEW_CHILD_EXTENSIONS=0`.
    - Omit `--mode` for normal code review; the command defaults to `code`.
    - Use `--keep-session` only when the user wants follow-up questions on this review; use `--continue <handle>` only with a **Session** path from a prior ASCII footer or `sessionHandle` in `PI_REVIEW_META_JSON`.
    - Pass the review request as natural language after `--`. Path mentions (`@src`, `@src/foo.ts`) are allowed as text. Do **not** expand directories into multi-file attachment lists — the CLI keeps directory `@refs` as tool path targets and only attaches real files.

package/skills/pi-review/references/codex-tools.md

@@ -10,6 +10,8 @@ Skills may use Claude Code tool names. On **Codex**, **Claude Code**, **Cursor**
 
 This file is **pi-review–specific** and ships with the pi-review package.
 
+Skill-invoked runs inherit **Registered providers** from the parent skill: the persistent config enables extension-registered providers only after explicit user acceptance (`childExtensions: true` in `~/.pi/pi-review/config.json`). Verify with `cat ~/.pi/pi-review/config.json`; isolate one run with `PI_REVIEW_CHILD_EXTENSIONS=0`.
+
 ## Long-running `pi-review` (default on Codex / Claude Code / Cursor / agy)
 
 Native shell tools on these hosts **buffer stdout/stderr until the command exits**. A multi-minute foreground `pi-review` run looks like a silent wait, then one large dump — never promise live foreground streaming. Which side channel to use depends on the run type: panel review gets the browser dashboard; single review and `loop` get the tailed progress log.

package/skills/pi-review/references/model-selection.md

@@ -4,7 +4,7 @@ Use this after `pi-review models` (or `pi-review models <search>`). **Never inve
 
 ## Workflow (Claude Code, Codex, Cursor, agy, Pi parent agent)
 
-1. Run `pi-review models` (narrow with search if the user named a vendor or model family).
+1. Run `pi-review models` (narrow with search if the user named a vendor or model family). Extension-registered providers appear in the catalog only when the config enables them (`childExtensions: true`); if a needed provider is missing, follow the parent skill's **Registered providers** section (explicit opt-in).
 2. Infer **review profile** from the target (see table below).
 3. **Cross-model review**: identify the host session's own model — the model that wrote or will fix the code under review; its id is in your own session context. Walk the **priority list** for that profile skipping rows in the host's model family, and pick the **first** remaining row whose `idContains` matches some listed model id (case-insensitive substring). Same-family reviewers share the author model's blind spots; return to the host's own family only when no other family matches the catalog. On a panel, spread reviewer models so the host's family stays a minority. If several ids match one row, prefer the **newest** id (higher version suffix, e.g. `2.7` over `2.5`, `4-8` over `4-6`).
 4. Set `--model <exact-listed-provider/model>` from the catalog. Add `:thinking` only if that model supports it in Pi and the preset suggests it (see thinking column).