@zephyrdeng/pi-review 0.13.0 → 0.15.0

package/dist/pi-config.test.js

@@ -0,0 +1,78 @@
+import assert from "node:assert/strict";
+import fs from "node:fs";
+import os from "node:os";
+import path from "node:path";
+import { test } from "vitest";
+import { configFilePath, loadReviewConfigFile, parseReviewConfig, resolveChildExtensions, } from "./pi-config.js";
+test("parseReviewConfig accepts an empty or full valid config", () => {
+    assert.deepEqual(parseReviewConfig("{}"), { config: {}, warnings: [] });
+    assert.deepEqual(parseReviewConfig('{"childExtensions": true}'), { config: { childExtensions: true }, warnings: [] });
+    assert.deepEqual(parseReviewConfig('{"childExtensions": false}'), { config: { childExtensions: false }, warnings: [] });
+});
+test("parseReviewConfig ignores unknown keys for forward compatibility", () => {
+    assert.deepEqual(parseReviewConfig('{"childExtensions": true, "futureKey": 42}'), {
+        config: { childExtensions: true },
+        warnings: [],
+    });
+});
+test("parseReviewConfig treats null as explicitly unset", () => {
+    assert.deepEqual(parseReviewConfig('{"childExtensions": null}'), { config: {}, warnings: [] });
+});
+test("parseReviewConfig leniently ignores a non-boolean value with a warning", () => {
+    const load = parseReviewConfig('{"childExtensions": "true"}');
+    assert.deepEqual(load.config, {});
+    assert.equal(load.warnings.length, 1);
+    assert.match(load.warnings[0], /childExtensions/);
+    assert.match(load.warnings[0], /ignoring it/);
+    const num = parseReviewConfig('{"childExtensions": 1}');
+    assert.deepEqual(num.config, {});
+    assert.equal(num.warnings.length, 1);
+});
+test("parseReviewConfig leniently handles invalid JSON and non-object roots with a warning", () => {
+    const badJson = parseReviewConfig("not json");
+    assert.deepEqual(badJson.config, {});
+    assert.equal(badJson.warnings.length, 1);
+    assert.match(badJson.warnings[0], /not valid JSON/);
+    const arr = parseReviewConfig("[1, 2]");
+    assert.deepEqual(arr.config, {});
+    assert.equal(arr.warnings.length, 1);
+    const nul = parseReviewConfig("null");
+    assert.deepEqual(nul.config, {});
+    assert.equal(nul.warnings.length, 1);
+});
+test("loadReviewConfigFile treats a missing file as the empty config with no warnings", () => {
+    const missing = path.join(os.tmpdir(), `pi-review-config-missing-${Date.now()}.json`);
+    assert.deepEqual(loadReviewConfigFile(missing), { config: {}, warnings: [] });
+});
+test("loadReviewConfigFile loads and validates an existing file", () => {
+    const file = path.join(os.tmpdir(), `pi-review-config-${Date.now()}.json`);
+    fs.writeFileSync(file, '{"childExtensions": true}');
+    try {
+        assert.deepEqual(loadReviewConfigFile(file), { config: { childExtensions: true }, warnings: [] });
+    }
+    finally {
+        fs.rmSync(file, { force: true });
+    }
+});
+test("configFilePath defaults under the pi data dir and honors PI_REVIEW_CONFIG", () => {
+    assert.equal(configFilePath({}), path.join(os.homedir(), ".pi", "pi-review", "config.json"));
+    assert.equal(configFilePath({ PI_REVIEW_CONFIG: "/tmp/custom.json" }), "/tmp/custom.json");
+});
+test("resolveChildExtensions: env truthy values override config and default", () => {
+    for (const value of ["1", "true", "KEEP", " 1 "]) {
+        assert.deepEqual(resolveChildExtensions({ PI_REVIEW_CHILD_EXTENSIONS: value }, {}), { enabled: true, source: "env" });
+        assert.deepEqual(resolveChildExtensions({ PI_REVIEW_CHILD_EXTENSIONS: value }, { childExtensions: false }), { enabled: true, source: "env" });
+    }
+});
+test("resolveChildExtensions: env set to a non-truthy value forces isolation", () => {
+    assert.deepEqual(resolveChildExtensions({ PI_REVIEW_CHILD_EXTENSIONS: "0" }, { childExtensions: true }), { enabled: false, source: "env" });
+    assert.deepEqual(resolveChildExtensions({ PI_REVIEW_CHILD_EXTENSIONS: "no" }, { childExtensions: true }), { enabled: false, source: "env" });
+});
+test("resolveChildExtensions: unset or empty env falls through to config, then default", () => {
+    assert.deepEqual(resolveChildExtensions({}, { childExtensions: true }), { enabled: true, source: "config" });
+    assert.deepEqual(resolveChildExtensions({}, { childExtensions: false }), { enabled: false, source: "config" });
+    assert.deepEqual(resolveChildExtensions({ PI_REVIEW_CHILD_EXTENSIONS: "" }, { childExtensions: true }), { enabled: true, source: "config" });
+    assert.deepEqual(resolveChildExtensions({ PI_REVIEW_CHILD_EXTENSIONS: "  " }, { childExtensions: true }), { enabled: true, source: "config" });
+    assert.deepEqual(resolveChildExtensions({}, {}), { enabled: false, source: "default" });
+});
+//# sourceMappingURL=pi-config.test.js.map

package/dist/pi-config.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"pi-config.test.js","sourceRoot":"","sources":["../src/pi-config.test.ts"],"names":[],"mappings":"AAAA,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,MAAM,SAAS,CAAC;AACzB,OAAO,EAAE,MAAM,SAAS,CAAC;AACzB,OAAO,IAAI,MAAM,WAAW,CAAC;AAC7B,OAAO,EAAE,IAAI,EAAE,MAAM,QAAQ,CAAC;AAC9B,OAAO,EACL,cAAc,EACd,oBAAoB,EACpB,iBAAiB,EACjB,sBAAsB,GACvB,MAAM,gBAAgB,CAAC;AAExB,IAAI,CAAC,yDAAyD,EAAE,GAAG,EAAE;IACnE,MAAM,CAAC,SAAS,CAAC,iBAAiB,CAAC,IAAI,CAAC,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE,QAAQ,EAAE,EAAE,EAAE,CAAC,CAAC;IACxE,MAAM,CAAC,SAAS,CAAC,iBAAiB,CAAC,2BAA2B,CAAC,EAAE,EAAE,MAAM,EAAE,EAAE,eAAe,EAAE,IAAI,EAAE,EAAE,QAAQ,EAAE,EAAE,EAAE,CAAC,CAAC;IACtH,MAAM,CAAC,SAAS,CAAC,iBAAiB,CAAC,4BAA4B,CAAC,EAAE,EAAE,MAAM,EAAE,EAAE,eAAe,EAAE,KAAK,EAAE,EAAE,QAAQ,EAAE,EAAE,EAAE,CAAC,CAAC;AAC1H,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,kEAAkE,EAAE,GAAG,EAAE;IAC5E,MAAM,CAAC,SAAS,CAAC,iBAAiB,CAAC,4CAA4C,CAAC,EAAE;QAChF,MAAM,EAAE,EAAE,eAAe,EAAE,IAAI,EAAE;QACjC,QAAQ,EAAE,EAAE;KACb,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,mDAAmD,EAAE,GAAG,EAAE;IAC7D,MAAM,CAAC,SAAS,CAAC,iBAAiB,CAAC,2BAA2B,CAAC,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE,QAAQ,EAAE,EAAE,EAAE,CAAC,CAAC;AACjG,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,wEAAwE,EAAE,GAAG,EAAE;IAClF,MAAM,IAAI,GAAG,iBAAiB,CAAC,6BAA6B,CAAC,CAAC;IAC9D,MAAM,CAAC,SAAS,CAAC,IAAI,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC;IAClC,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,QAAQ,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC;IACtC,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,CAAE,EAAE,iBAAiB,CAAC,CAAC;IACnD,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,CAAE,EAAE,aAAa,CAAC,CAAC;IAE/C,MAAM,GAAG,GAAG,iBAAiB,CAAC,wBAAwB,CAAC,CAAC;IACxD,MAAM,CAAC,SAAS,CAAC,GAAG,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC;IACjC,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,QAAQ,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC;AACvC,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,sFAAsF,EAAE,GAAG,EAAE;IAChG,MAAM,OAAO,GAAG,iBAAiB,CAAC,UAAU,CAAC,CAAC;IAC9C,MAAM,CAAC,SAAS,CAAC,OAAO,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC;IACrC,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,QAAQ,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC;IACzC,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC,CAAE,EAAE,gBAAgB,CAAC,CAAC;IAErD,MAAM,GAAG,GAAG,iBAAiB,CAAC,QAAQ,CAAC,CAAC;IACxC,MAAM,CAAC,SAAS,CAAC,GAAG,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC;IACjC,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,QAAQ,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC;IAErC,MAAM,GAAG,GAAG,iBAAiB,CAAC,MAAM,CAAC,CAAC;IACtC,MAAM,CAAC,SAAS,CAAC,GAAG,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC;IACjC,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,QAAQ,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC;AACvC,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,iFAAiF,EAAE,GAAG,EAAE;IAC3F,MAAM,OAAO,GAAG,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,MAAM,EAAE,EAAE,4BAA4B,IAAI,CAAC,GAAG,EAAE,OAAO,CAAC,CAAC;IACtF,MAAM,CAAC,SAAS,CAAC,oBAAoB,CAAC,OAAO,CAAC,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE,QAAQ,EAAE,EAAE,EAAE,CAAC,CAAC;AAChF,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,2DAA2D,EAAE,GAAG,EAAE;IACrE,MAAM,IAAI,GAAG,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,MAAM,EAAE,EAAE,oBAAoB,IAAI,CAAC,GAAG,EAAE,OAAO,CAAC,CAAC;IAC3E,EAAE,CAAC,aAAa,CAAC,IAAI,EAAE,2BAA2B,CAAC,CAAC;IACpD,IAAI,CAAC;QACH,MAAM,CAAC,SAAS,CAAC,oBAAoB,CAAC,IAAI,CAAC,EAAE,EAAE,MAAM,EAAE,EAAE,eAAe,EAAE,IAAI,EAAE,EAAE,QAAQ,EAAE,EAAE,EAAE,CAAC,CAAC;IACpG,CAAC;YAAS,CAAC;QACT,EAAE,CAAC,MAAM,CAAC,IAAI,EAAE,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC;IACnC,CAAC;AACH,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,2EAA2E,EAAE,GAAG,EAAE;IACrF,MAAM,CAAC,KAAK,CAAC,cAAc,CAAC,EAAE,CAAC,EAAE,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,OAAO,EAAE,EAAE,KAAK,EAAE,WAAW,EAAE,aAAa,CAAC,CAAC,CAAC;IAC7F,MAAM,CAAC,KAAK,CAAC,cAAc,CAAC,EAAE,gBAAgB,EAAE,kBAAkB,EAAE,CAAC,EAAE,kBAAkB,CAAC,CAAC;AAC7F,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,uEAAuE,EAAE,GAAG,EAAE;IACjF,KAAK,MAAM,KAAK,IAAI,CAAC,GAAG,EAAE,MAAM,EAAE,MAAM,EAAE,KAAK,CAAC,EAAE,CAAC;QACjD,MAAM,CAAC,SAAS,CAAC,sBAAsB,CAAC,EAAE,0BAA0B,EAAE,KAAK,EAAE,EAAE,EAAE,CAAC,EAAE,EAAE,OAAO,EAAE,IAAI,EAAE,MAAM,EAAE,KAAK,EAAE,CAAC,CAAC;QACtH,MAAM,CAAC,SAAS,CAAC,sBAAsB,CAAC,EAAE,0BAA0B,EAAE,KAAK,EAAE,EAAE,EAAE,eAAe,EAAE,KAAK,EAAE,CAAC,EAAE,EAAE,OAAO,EAAE,IAAI,EAAE,MAAM,EAAE,KAAK,EAAE,CAAC,CAAC;IAChJ,CAAC;AACH,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,wEAAwE,EAAE,GAAG,EAAE;IAClF,MAAM,CAAC,SAAS,CAAC,sBAAsB,CAAC,EAAE,0BAA0B,EAAE,GAAG,EAAE,EAAE,EAAE,eAAe,EAAE,IAAI,EAAE,CAAC,EAAE,EAAE,OAAO,EAAE,KAAK,EAAE,MAAM,EAAE,KAAK,EAAE,CAAC,CAAC;IAC5I,MAAM,CAAC,SAAS,CAAC,sBAAsB,CAAC,EAAE,0BAA0B,EAAE,IAAI,EAAE,EAAE,EAAE,eAAe,EAAE,IAAI,EAAE,CAAC,EAAE,EAAE,OAAO,EAAE,KAAK,EAAE,MAAM,EAAE,KAAK,EAAE,CAAC,CAAC;AAC/I,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,kFAAkF,EAAE,GAAG,EAAE;IAC5F,MAAM,CAAC,SAAS,CAAC,sBAAsB,CAAC,EAAE,EAAE,EAAE,eAAe,EAAE,IAAI,EAAE,CAAC,EAAE,EAAE,OAAO,EAAE,IAAI,EAAE,MAAM,EAAE,QAAQ,EAAE,CAAC,CAAC;IAC7G,MAAM,CAAC,SAAS,CAAC,sBAAsB,CAAC,EAAE,EAAE,EAAE,eAAe,EAAE,KAAK,EAAE,CAAC,EAAE,EAAE,OAAO,EAAE,KAAK,EAAE,MAAM,EAAE,QAAQ,EAAE,CAAC,CAAC;IAC/G,MAAM,CAAC,SAAS,CAAC,sBAAsB,CAAC,EAAE,0BAA0B,EAAE,EAAE,EAAE,EAAE,EAAE,eAAe,EAAE,IAAI,EAAE,CAAC,EAAE,EAAE,OAAO,EAAE,IAAI,EAAE,MAAM,EAAE,QAAQ,EAAE,CAAC,CAAC;IAC7I,MAAM,CAAC,SAAS,CAAC,sBAAsB,CAAC,EAAE,0BAA0B,EAAE,IAAI,EAAE,EAAE,EAAE,eAAe,EAAE,IAAI,EAAE,CAAC,EAAE,EAAE,OAAO,EAAE,IAAI,EAAE,MAAM,EAAE,QAAQ,EAAE,CAAC,CAAC;IAC/I,MAAM,CAAC,SAAS,CAAC,sBAAsB,CAAC,EAAE,EAAE,EAAE,CAAC,EAAE,EAAE,OAAO,EAAE,KAAK,EAAE,MAAM,EAAE,SAAS,EAAE,CAAC,CAAC;AAC1F,CAAC,CAAC,CAAC"}

package/dist/provider-probe.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=provider-probe.test.d.ts.map

package/dist/provider-probe.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"provider-probe.test.d.ts","sourceRoot":"","sources":["../src/provider-probe.test.ts"],"names":[],"mappings":""}

package/dist/provider-probe.test.js

@@ -0,0 +1,192 @@
+import assert from "node:assert/strict";
+import { afterEach, beforeEach, expect, test, vi } from "vitest";
+vi.mock("node:child_process", () => ({
+    spawnSync: vi.fn(),
+}));
+import { spawnSync } from "node:child_process";
+import { splitModelProvider } from "./panel-config.js";
+import { collectPanelExtensionHints } from "./panel.js";
+import { configBlockForProvider, extensionOnlyHintText, parseModelCatalog, probeProviderAvailability, unknownProviderHintText, } from "./review.js";
+const CATALOG_WITHOUT_EXT = `provider      model                   context  max-out  thinking  images
+Ai98Pro       grok-4.5                500K     128K     yes       yes   
+DeepSeek      deepseek-v4-flash       1M       384K     yes       no    
+openai-codex  gpt-5.6-luna            272K     128K     yes       yes   
+`;
+const CATALOG_WITH_EXT = `provider             model                                              context  max-out  thinking  images
+Ai98Pro              grok-4.5                                           500K     128K     yes       yes   
+px:anthropic         claude-sonnet-5                                    1M       128K     yes       yes   
+px:openai            gpt-5.6-luna                                       272K     128K     yes       yes   
+`;
+function catalogResult(stdout) {
+    return { status: 0, stdout, stderr: "", error: undefined, pid: 0, output: [null, stdout, ""], signal: null };
+}
+const mockedSpawnSync = vi.mocked(spawnSync);
+/** Original env value captured at module load; restored after each test. */
+const ORIGINAL_CHILD_EXTENSIONS = process.env.PI_REVIEW_CHILD_EXTENSIONS;
+beforeEach(() => {
+    mockedSpawnSync.mockReset();
+    mockedSpawnSync.mockImplementation((_cmd, args) => {
+        const isolated = Array.isArray(args) && args.includes("--no-extensions");
+        return catalogResult(isolated ? CATALOG_WITHOUT_EXT : CATALOG_WITH_EXT);
+    });
+    // Establish the suite's default state deterministically.
+    delete process.env.PI_REVIEW_CHILD_EXTENSIONS;
+});
+afterEach(() => {
+    if (ORIGINAL_CHILD_EXTENSIONS === undefined) {
+        delete process.env.PI_REVIEW_CHILD_EXTENSIONS;
+    }
+    else {
+        process.env.PI_REVIEW_CHILD_EXTENSIONS = ORIGINAL_CHILD_EXTENSIONS;
+    }
+});
+test("parseModelCatalog extracts distinct provider names via header offsets", () => {
+    assert.deepEqual(parseModelCatalog(CATALOG_WITHOUT_EXT), ["Ai98Pro", "DeepSeek", "openai-codex"]);
+});
+test("parseModelCatalog keeps provider names with symbols inside a column", () => {
+    const catalog = `provider      model
+Pika(Grok)    grok-4.5
+px:anthropic  claude-sonnet-5
+`;
+    assert.deepEqual(parseModelCatalog(catalog), ["Pika(Grok)", "px:anthropic"]);
+});
+test("parseModelCatalog returns [] for non-table output", () => {
+    assert.deepEqual(parseModelCatalog("pi - AI coding assistant\n\nUsage: ..."), []);
+});
+test("probeProviderAvailability resolves available from the isolated catalog", () => {
+    assert.deepEqual(probeProviderAvailability("pi-avail", "DeepSeek"), { kind: "available" });
+    expect(mockedSpawnSync).toHaveBeenCalledTimes(1); // only the isolated catalog is consulted
+});
+test("probeProviderAvailability resolves extension_only from the with-extensions catalog", () => {
+    assert.deepEqual(probeProviderAvailability("pi-ext", "px:anthropic"), {
+        kind: "extension_only",
+        provider: "px:anthropic",
+    });
+    expect(mockedSpawnSync).toHaveBeenCalledTimes(2);
+});
+test("probeProviderAvailability resolves unknown when missing everywhere", () => {
+    assert.deepEqual(probeProviderAvailability("pi-unknown", "nonexistent"), {
+        kind: "unknown",
+        provider: "nonexistent",
+    });
+    expect(mockedSpawnSync).toHaveBeenCalledTimes(2);
+});
+test("probeProviderAvailability reports indeterminate and does not cache failed catalog queries", () => {
+    mockedSpawnSync.mockImplementation(() => ({
+        status: 1,
+        stdout: "",
+        stderr: "boom",
+        error: undefined,
+        pid: 0,
+        output: [null, "", "boom"],
+        signal: null,
+    }));
+    const first = probeProviderAvailability("pi-broken", "px:anthropic");
+    assert.deepEqual(first, { kind: "indeterminate", provider: "px:anthropic" });
+    // Failure is not cached: a later successful query re-runs the probe.
+    mockedSpawnSync.mockImplementation((_cmd, args) => {
+        const isolated = Array.isArray(args) && args.includes("--no-extensions");
+        return catalogResult(isolated ? CATALOG_WITHOUT_EXT : CATALOG_WITH_EXT);
+    });
+    const second = probeProviderAvailability("pi-broken", "px:anthropic");
+    assert.deepEqual(second, { kind: "extension_only", provider: "px:anthropic" });
+});
+test("splitModelProvider extracts the provider prefix from provider/model tokens", () => {
+    assert.equal(splitModelProvider("px:openai/agnes-2.0-flash"), "px:openai");
+    assert.equal(splitModelProvider("openai-codex/gpt-5.6-sol"), "openai-codex");
+    assert.equal(splitModelProvider("anthropic/*"), "anthropic");
+    assert.equal(splitModelProvider("gpt-5.6-sol"), undefined);
+    assert.equal(splitModelProvider("/leading-slash"), undefined);
+    assert.equal(splitModelProvider("trailing/"), undefined);
+});
+test("configBlockForProvider skips probing without an explicit provider", () => {
+    assert.equal(configBlockForProvider("pi-skip", undefined), undefined);
+    expect(mockedSpawnSync).not.toHaveBeenCalled();
+});
+test("configBlockForProvider skips probing when extensions are enabled (PI_REVIEW_CHILD_EXTENSIONS=1)", () => {
+    process.env.PI_REVIEW_CHILD_EXTENSIONS = "1";
+    assert.equal(configBlockForProvider("pi-skip", "px:anthropic"), undefined);
+    expect(mockedSpawnSync).not.toHaveBeenCalled();
+});
+test("configBlockForProvider returns undefined when the provider is isolated-available", () => {
+    assert.equal(configBlockForProvider("pi-avail2", "DeepSeek"), undefined);
+});
+test("configBlockForProvider resolves the provider from a provider/model token (F1 regression)", () => {
+    // No --provider; the provider must come from the model string.
+    const block = configBlockForProvider("pi-model-ext", undefined, "px:anthropic/claude-sonnet-5");
+    assert.ok(block, "expected a config block");
+    assert.equal(block.extensionOnly, true);
+    assert.match(block.structured.parseError ?? "", /PI_REVIEW_CHILD_EXTENSIONS=1/);
+});
+test("configBlockForProvider does not block on a failed catalog probe (F2 regression)", () => {
+    mockedSpawnSync.mockImplementation(() => ({
+        status: 1,
+        stdout: "",
+        stderr: "boom",
+        error: undefined,
+        pid: 0,
+        output: [null, "", "boom"],
+        signal: null,
+    }));
+    assert.equal(configBlockForProvider("pi-broken-f2", "px:anthropic"), undefined);
+});
+test("configBlockForProvider blocks with the extension hint for extension-only providers", () => {
+    const block = configBlockForProvider("pi-block-ext", "px:anthropic");
+    assert.ok(block, "expected a config block");
+    assert.equal(block.extensionOnly, true);
+    assert.equal(block.structured.status, "blocked");
+    assert.equal(block.structured.verdict, "blocked");
+    assert.equal(block.structured.verdictSource, "config_error");
+    assert.equal(block.structured.findings.length, 0);
+    assert.equal(block.structured.actionableCount, 0);
+    assert.match(block.structured.parseError ?? "", /PI_REVIEW_CHILD_EXTENSIONS=1/);
+});
+test("configBlockForProvider blocks with the unknown-provider message", () => {
+    const block = configBlockForProvider("pi-block-unk", "nonexistent");
+    assert.ok(block, "expected a config block");
+    assert.equal(block.extensionOnly, false);
+    assert.match(block.structured.parseError ?? "", /was not found/);
+});
+test("collectPanelExtensionHints returns undefined when no reviewer was blocked", () => {
+    const submissions = [
+        { reviewerId: "r1", model: "gpt-5.6-sol", durationMs: 1, result: { status: "clean", verdict: "approve", verdictSource: "parsed", findings: [], actionableCount: 0 } },
+    ];
+    assert.equal(collectPanelExtensionHints(submissions), undefined);
+});
+test("collectPanelExtensionHints keeps every provider, deduplicated (F3 regression)", () => {
+    const blocked = (id, provider) => ({
+        reviewerId: id,
+        model: `${provider}/m`,
+        durationMs: 0,
+        result: {
+            status: "blocked",
+            verdict: "blocked",
+            verdictSource: "config_error",
+            parseError: extensionOnlyHintText(provider),
+            findings: [],
+            actionableCount: 0,
+        },
+        extensionHint: { provider, availableViaExtension: true },
+    });
+    const hints = collectPanelExtensionHints([
+        blocked("r1", "px:anthropic"),
+        blocked("r2", "px:openai"),
+        blocked("r3", "px:anthropic"), // duplicate provider: collapsed
+    ]);
+    assert.deepEqual(hints, [
+        { provider: "px:anthropic", availableViaExtension: true },
+        { provider: "px:openai", availableViaExtension: true },
+    ]);
+});
+test("extensionOnlyHintText mentions the provider and the env var", () => {
+    const text = extensionOnlyHintText("px:anthropic");
+    assert.match(text, /px:anthropic/);
+    assert.match(text, /PI_REVIEW_CHILD_EXTENSIONS=1/);
+    assert.match(text, /no-extensions/);
+});
+test("unknownProviderHintText mentions the provider and check guidance", () => {
+    const text = unknownProviderHintText("foo");
+    assert.match(text, /foo/);
+    assert.match(text, /spelling/);
+});
+//# sourceMappingURL=provider-probe.test.js.map

package/dist/provider-probe.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"provider-probe.test.js","sourceRoot":"","sources":["../src/provider-probe.test.ts"],"names":[],"mappings":"AAAA,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,SAAS,EAAE,UAAU,EAAE,MAAM,EAAE,IAAI,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAEjE,EAAE,CAAC,IAAI,CAAC,oBAAoB,EAAE,GAAG,EAAE,CAAC,CAAC;IACnC,SAAS,EAAE,EAAE,CAAC,EAAE,EAAE;CACnB,CAAC,CAAC,CAAC;AAEJ,OAAO,EAAE,SAAS,EAAE,MAAM,oBAAoB,CAAC;AAC/C,OAAO,EAAE,kBAAkB,EAAE,MAAM,mBAAmB,CAAC;AACvD,OAAO,EAAE,0BAA0B,EAAE,MAAM,YAAY,CAAC;AAExD,OAAO,EACL,sBAAsB,EACtB,qBAAqB,EACrB,iBAAiB,EACjB,yBAAyB,EACzB,uBAAuB,GACxB,MAAM,aAAa,CAAC;AAErB,MAAM,mBAAmB,GAAG;;;;CAI3B,CAAC;AAEF,MAAM,gBAAgB,GAAG;;;;CAIxB,CAAC;AAEF,SAAS,aAAa,CAAC,MAAc;IACnC,OAAO,EAAE,MAAM,EAAE,CAAC,EAAE,MAAM,EAAE,MAAM,EAAE,EAAE,EAAE,KAAK,EAAE,SAAS,EAAE,GAAG,EAAE,CAAC,EAAE,MAAM,EAAE,CAAC,IAAI,EAAE,MAAM,EAAE,EAAE,CAAC,EAAE,MAAM,EAAE,IAAI,EAAE,CAAC;AAC/G,CAAC;AAED,MAAM,eAAe,GAAG,EAAE,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC;AAE7C,4EAA4E;AAC5E,MAAM,yBAAyB,GAAG,OAAO,CAAC,GAAG,CAAC,0BAA0B,CAAC;AAEzE,UAAU,CAAC,GAAG,EAAE;IACd,eAAe,CAAC,SAAS,EAAE,CAAC;IAC5B,eAAe,CAAC,kBAAkB,CAAC,CAAC,IAAI,EAAE,IAAI,EAAE,EAAE;QAChD,MAAM,QAAQ,GAAG,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,iBAAiB,CAAC,CAAC;QACzE,OAAO,aAAa,CAAC,QAAQ,CAAC,CAAC,CAAC,mBAAmB,CAAC,CAAC,CAAC,gBAAgB,CAAiC,CAAC;IAC1G,CAAC,CAAC,CAAC;IACH,yDAAyD;IACzD,OAAO,OAAO,CAAC,GAAG,CAAC,0BAA0B,CAAC;AAChD,CAAC,CAAC,CAAC;AAEH,SAAS,CAAC,GAAG,EAAE;IACb,IAAI,yBAAyB,KAAK,SAAS,EAAE,CAAC;QAC5C,OAAO,OAAO,CAAC,GAAG,CAAC,0BAA0B,CAAC;IAChD,CAAC;SAAM,CAAC;QACN,OAAO,CAAC,GAAG,CAAC,0BAA0B,GAAG,yBAAyB,CAAC;IACrE,CAAC;AACH,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,uEAAuE,EAAE,GAAG,EAAE;IACjF,MAAM,CAAC,SAAS,CAAC,iBAAiB,CAAC,mBAAmB,CAAC,EAAE,CAAC,SAAS,EAAE,UAAU,EAAE,cAAc,CAAC,CAAC,CAAC;AACpG,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,qEAAqE,EAAE,GAAG,EAAE;IAC/E,MAAM,OAAO,GAAG;;;CAGjB,CAAC;IACA,MAAM,CAAC,SAAS,CAAC,iBAAiB,CAAC,OAAO,CAAC,EAAE,CAAC,YAAY,EAAE,cAAc,CAAC,CAAC,CAAC;AAC/E,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,mDAAmD,EAAE,GAAG,EAAE;IAC7D,MAAM,CAAC,SAAS,CAAC,iBAAiB,CAAC,wCAAwC,CAAC,EAAE,EAAE,CAAC,CAAC;AACpF,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,wEAAwE,EAAE,GAAG,EAAE;IAClF,MAAM,CAAC,SAAS,CAAC,yBAAyB,CAAC,UAAU,EAAE,UAAU,CAAC,EAAE,EAAE,IAAI,EAAE,WAAW,EAAE,CAAC,CAAC;IAC3F,MAAM,CAAC,eAAe,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC,CAAC,yCAAyC;AAC7F,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,oFAAoF,EAAE,GAAG,EAAE;IAC9F,MAAM,CAAC,SAAS,CAAC,yBAAyB,CAAC,QAAQ,EAAE,cAAc,CAAC,EAAE;QACpE,IAAI,EAAE,gBAAgB;QACtB,QAAQ,EAAE,cAAc;KACzB,CAAC,CAAC;IACH,MAAM,CAAC,eAAe,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;AACnD,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,oEAAoE,EAAE,GAAG,EAAE;IAC9E,MAAM,CAAC,SAAS,CAAC,yBAAyB,CAAC,YAAY,EAAE,aAAa,CAAC,EAAE;QACvE,IAAI,EAAE,SAAS;QACf,QAAQ,EAAE,aAAa;KACxB,CAAC,CAAC;IACH,MAAM,CAAC,eAAe,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;AACnD,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,2FAA2F,EAAE,GAAG,EAAE;IACrG,eAAe,CAAC,kBAAkB,CAAC,GAAG,EAAE,CAAC,CAAC;QACxC,MAAM,EAAE,CAAC;QACT,MAAM,EAAE,EAAE;QACV,MAAM,EAAE,MAAM;QACd,KAAK,EAAE,SAAS;QAChB,GAAG,EAAE,CAAC;QACN,MAAM,EAAE,CAAC,IAAI,EAAE,EAAE,EAAE,MAAM,CAAC;QAC1B,MAAM,EAAE,IAAI;KACb,CAAC,CAAC,CAAC;IACJ,MAAM,KAAK,GAAG,yBAAyB,CAAC,WAAW,EAAE,cAAc,CAAC,CAAC;IACrE,MAAM,CAAC,SAAS,CAAC,KAAK,EAAE,EAAE,IAAI,EAAE,eAAe,EAAE,QAAQ,EAAE,cAAc,EAAE,CAAC,CAAC;IAC7E,qEAAqE;IACrE,eAAe,CAAC,kBAAkB,CAAC,CAAC,IAAI,EAAE,IAAI,EAAE,EAAE;QAChD,MAAM,QAAQ,GAAG,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,iBAAiB,CAAC,CAAC;QACzE,OAAO,aAAa,CAAC,QAAQ,CAAC,CAAC,CAAC,mBAAmB,CAAC,CAAC,CAAC,gBAAgB,CAAiC,CAAC;IAC1G,CAAC,CAAC,CAAC;IACH,MAAM,MAAM,GAAG,yBAAyB,CAAC,WAAW,EAAE,cAAc,CAAC,CAAC;IACtE,MAAM,CAAC,SAAS,CAAC,MAAM,EAAE,EAAE,IAAI,EAAE,gBAAgB,EAAE,QAAQ,EAAE,cAAc,EAAE,CAAC,CAAC;AACjF,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,4EAA4E,EAAE,GAAG,EAAE;IACtF,MAAM,CAAC,KAAK,CAAC,kBAAkB,CAAC,2BAA2B,CAAC,EAAE,WAAW,CAAC,CAAC;IAC3E,MAAM,CAAC,KAAK,CAAC,kBAAkB,CAAC,0BAA0B,CAAC,EAAE,cAAc,CAAC,CAAC;IAC7E,MAAM,CAAC,KAAK,CAAC,kBAAkB,CAAC,aAAa,CAAC,EAAE,WAAW,CAAC,CAAC;IAC7D,MAAM,CAAC,KAAK,CAAC,kBAAkB,CAAC,aAAa,CAAC,EAAE,SAAS,CAAC,CAAC;IAC3D,MAAM,CAAC,KAAK,CAAC,kBAAkB,CAAC,gBAAgB,CAAC,EAAE,SAAS,CAAC,CAAC;IAC9D,MAAM,CAAC,KAAK,CAAC,kBAAkB,CAAC,WAAW,CAAC,EAAE,SAAS,CAAC,CAAC;AAC3D,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,mEAAmE,EAAE,GAAG,EAAE;IAC7E,MAAM,CAAC,KAAK,CAAC,sBAAsB,CAAC,SAAS,EAAE,SAAS,CAAC,EAAE,SAAS,CAAC,CAAC;IACtE,MAAM,CAAC,eAAe,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;AACjD,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,iGAAiG,EAAE,GAAG,EAAE;IAC3G,OAAO,CAAC,GAAG,CAAC,0BAA0B,GAAG,GAAG,CAAC;IAC7C,MAAM,CAAC,KAAK,CAAC,sBAAsB,CAAC,SAAS,EAAE,cAAc,CAAC,EAAE,SAAS,CAAC,CAAC;IAC3E,MAAM,CAAC,eAAe,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;AACjD,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,kFAAkF,EAAE,GAAG,EAAE;IAC5F,MAAM,CAAC,KAAK,CAAC,sBAAsB,CAAC,WAAW,EAAE,UAAU,CAAC,EAAE,SAAS,CAAC,CAAC;AAC3E,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,0FAA0F,EAAE,GAAG,EAAE;IACpG,+DAA+D;IAC/D,MAAM,KAAK,GAAG,sBAAsB,CAAC,cAAc,EAAE,SAAS,EAAE,8BAA8B,CAAC,CAAC;IAChG,MAAM,CAAC,EAAE,CAAC,KAAK,EAAE,yBAAyB,CAAC,CAAC;IAC5C,MAAM,CAAC,KAAK,CAAC,KAAM,CAAC,aAAa,EAAE,IAAI,CAAC,CAAC;IACzC,MAAM,CAAC,KAAK,CAAC,KAAM,CAAC,UAAU,CAAC,UAAU,IAAI,EAAE,EAAE,8BAA8B,CAAC,CAAC;AACnF,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,iFAAiF,EAAE,GAAG,EAAE;IAC3F,eAAe,CAAC,kBAAkB,CAAC,GAAG,EAAE,CAAC,CAAC;QACxC,MAAM,EAAE,CAAC;QACT,MAAM,EAAE,EAAE;QACV,MAAM,EAAE,MAAM;QACd,KAAK,EAAE,SAAS;QAChB,GAAG,EAAE,CAAC;QACN,MAAM,EAAE,CAAC,IAAI,EAAE,EAAE,EAAE,MAAM,CAAC;QAC1B,MAAM,EAAE,IAAI;KACb,CAAC,CAAC,CAAC;IACJ,MAAM,CAAC,KAAK,CAAC,sBAAsB,CAAC,cAAc,EAAE,cAAc,CAAC,EAAE,SAAS,CAAC,CAAC;AAClF,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,oFAAoF,EAAE,GAAG,EAAE;IAC9F,MAAM,KAAK,GAAG,sBAAsB,CAAC,cAAc,EAAE,cAAc,CAAC,CAAC;IACrE,MAAM,CAAC,EAAE,CAAC,KAAK,EAAE,yBAAyB,CAAC,CAAC;IAC5C,MAAM,CAAC,KAAK,CAAC,KAAM,CAAC,aAAa,EAAE,IAAI,CAAC,CAAC;IACzC,MAAM,CAAC,KAAK,CAAC,KAAM,CAAC,UAAU,CAAC,MAAM,EAAE,SAAS,CAAC,CAAC;IAClD,MAAM,CAAC,KAAK,CAAC,KAAM,CAAC,UAAU,CAAC,OAAO,EAAE,SAAS,CAAC,CAAC;IACnD,MAAM,CAAC,KAAK,CAAC,KAAM,CAAC,UAAU,CAAC,aAAa,EAAE,cAAc,CAAC,CAAC;IAC9D,MAAM,CAAC,KAAK,CAAC,KAAM,CAAC,UAAU,CAAC,QAAQ,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC;IACnD,MAAM,CAAC,KAAK,CAAC,KAAM,CAAC,UAAU,CAAC,eAAe,EAAE,CAAC,CAAC,CAAC;IACnD,MAAM,CAAC,KAAK,CAAC,KAAM,CAAC,UAAU,CAAC,UAAU,IAAI,EAAE,EAAE,8BAA8B,CAAC,CAAC;AACnF,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,iEAAiE,EAAE,GAAG,EAAE;IAC3E,MAAM,KAAK,GAAG,sBAAsB,CAAC,cAAc,EAAE,aAAa,CAAC,CAAC;IACpE,MAAM,CAAC,EAAE,CAAC,KAAK,EAAE,yBAAyB,CAAC,CAAC;IAC5C,MAAM,CAAC,KAAK,CAAC,KAAM,CAAC,aAAa,EAAE,KAAK,CAAC,CAAC;IAC1C,MAAM,CAAC,KAAK,CAAC,KAAM,CAAC,UAAU,CAAC,UAAU,IAAI,EAAE,EAAE,eAAe,CAAC,CAAC;AACpE,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,2EAA2E,EAAE,GAAG,EAAE;IACrF,MAAM,WAAW,GAAyB;QACxC,EAAE,UAAU,EAAE,IAAI,EAAE,KAAK,EAAE,aAAa,EAAE,UAAU,EAAE,CAAC,EAAE,MAAM,EAAE,EAAE,MAAM,EAAE,OAAO,EAAE,OAAO,EAAE,SAAS,EAAE,aAAa,EAAE,QAAQ,EAAE,QAAQ,EAAE,EAAE,EAAE,eAAe,EAAE,CAAC,EAAE,EAAE;KACtK,CAAC;IACF,MAAM,CAAC,KAAK,CAAC,0BAA0B,CAAC,WAAW,CAAC,EAAE,SAAS,CAAC,CAAC;AACnE,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,+EAA+E,EAAE,GAAG,EAAE;IACzF,MAAM,OAAO,GAAG,CAAC,EAAU,EAAE,QAAgB,EAAsB,EAAE,CAAC,CAAC;QACrE,UAAU,EAAE,EAAE;QACd,KAAK,EAAE,GAAG,QAAQ,IAAI;QACtB,UAAU,EAAE,CAAC;QACb,MAAM,EAAE;YACN,MAAM,EAAE,SAAS;YACjB,OAAO,EAAE,SAAS;YAClB,aAAa,EAAE,cAAc;YAC7B,UAAU,EAAE,qBAAqB,CAAC,QAAQ,CAAC;YAC3C,QAAQ,EAAE,EAAE;YACZ,eAAe,EAAE,CAAC;SACnB;QACD,aAAa,EAAE,EAAE,QAAQ,EAAE,qBAAqB,EAAE,IAAI,EAAE;KACzD,CAAC,CAAC;IACH,MAAM,KAAK,GAAG,0BAA0B,CAAC;QACvC,OAAO,CAAC,IAAI,EAAE,cAAc,CAAC;QAC7B,OAAO,CAAC,IAAI,EAAE,WAAW,CAAC;QAC1B,OAAO,CAAC,IAAI,EAAE,cAAc,CAAC,EAAE,gCAAgC;KAChE,CAAC,CAAC;IACH,MAAM,CAAC,SAAS,CAAC,KAAK,EAAE;QACtB,EAAE,QAAQ,EAAE,cAAc,EAAE,qBAAqB,EAAE,IAAI,EAAE;QACzD,EAAE,QAAQ,EAAE,WAAW,EAAE,qBAAqB,EAAE,IAAI,EAAE;KACvD,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,6DAA6D,EAAE,GAAG,EAAE;IACvE,MAAM,IAAI,GAAG,qBAAqB,CAAC,cAAc,CAAC,CAAC;IACnD,MAAM,CAAC,KAAK,CAAC,IAAI,EAAE,cAAc,CAAC,CAAC;IACnC,MAAM,CAAC,KAAK,CAAC,IAAI,EAAE,8BAA8B,CAAC,CAAC;IACnD,MAAM,CAAC,KAAK,CAAC,IAAI,EAAE,eAAe,CAAC,CAAC;AACtC,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,kEAAkE,EAAE,GAAG,EAAE;IAC5E,MAAM,IAAI,GAAG,uBAAuB,CAAC,KAAK,CAAC,CAAC;IAC5C,MAAM,CAAC,KAAK,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;IAC1B,MAAM,CAAC,KAAK,CAAC,IAAI,EAAE,UAAU,CAAC,CAAC;AACjC,CAAC,CAAC,CAAC"}

package/dist/review.d.ts

@@ -1,18 +1,71 @@
-import type { ParsedArgs, ReviewRunResult } from "./types.js";
+import type { ParsedArgs, ReviewRunResult, StructuredReviewResult } from "./types.js";
 import { type ChildRunResult } from "./child-process.js";
+import type { PiReviewConfig } from "./pi-config.js";
 export declare function readReviewStdin(): string;
 export declare function childEnv(piBin: string): NodeJS.ProcessEnv;
 /**
- * Isolate review children from host Pi extension side effects.
+ * Parse `pi --list-models` table output into distinct provider names.
+ * Columns are space-padded; offsets are derived from the header row so
+ * provider names are stable even if they contain spaces.
+ */
+export declare function parseModelCatalog(stdout: string): string[];
+export type ProviderProbe = {
+    kind: "available";
+} | {
+    kind: "extension_only";
+    provider: string;
+} | {
+    kind: "unknown";
+    provider: string;
+} | {
+    kind: "indeterminate";
+    provider: string;
+};
+/**
+ * Decide whether `provider` is usable by an isolated review child
+ * (--no-extensions, issue #8). Missing from the isolated catalog but present
+ * with host extensions loaded means the provider is registered by an
+ * extension; the caller should surface a fix hint instead of a confusing
+ * unknown-provider failure. A failed catalog query is `indeterminate`: the
+ * caller must not block a possibly-valid provider on probe trouble.
+ */
+export declare function probeProviderAvailability(piBin: string, provider: string): ProviderProbe;
+/** Human-readable fix hint for a provider that only exists via host extensions. */
+export declare function extensionOnlyHintText(provider: string): string;
+/** Human-readable message for a provider missing from the catalog entirely. */
+export declare function unknownProviderHintText(provider: string): string;
+/**
+ * When isolation is active and a provider is requested, block before spawning
+ * the child if that provider only exists via host extensions (or is unknown),
+ * and return a blocked review with an actionable hint. Returns undefined when
+ * the review should proceed.
+ */
+export interface ProviderConfigBlock {
+    structured: StructuredReviewResult;
+    provider: string;
+    extensionOnly: boolean;
+}
+export declare function configBlockForProvider(piBin: string, provider: string | undefined, model?: string): ProviderConfigBlock | undefined;
+/** Isolate review children from host Pi extension side effects.
  *
  * Host extensions (usage HUDs, auto-reload bridges, etc.) may capture extension
  * ctx and touch it after session dispose/reload. That throws Pi's stale-context
  * error and can crash an otherwise successful reviewer child (issue #8).
  *
- * Opt out with PI_REVIEW_CHILD_EXTENSIONS=1 when a custom provider truly requires
- * host extension registration inside the child.
+ * The effective value comes from the persistent review config
+ * (childExtensions, ~/.pi/pi-review/config.json), overridden per process by
+ * PI_REVIEW_CHILD_EXTENSIONS (1/true/keep enable, any other set value
+ * disables). Bare CLI stays isolated (--no-extensions) until the config says
+ * otherwise.
+ */
+export declare function childIsolationArgs(env?: NodeJS.ProcessEnv, cfg?: PiReviewConfig): string[];
+/**
+ * Build the catalog command args so the models command shows the same catalog
+ * an actual review child would see: the effective isolation config applies
+ * here too (F2: catalog and review must agree on extension-registered
+ * providers).
  */
-export declare function childIsolationArgs(env?: NodeJS.ProcessEnv): string[];
+export declare function modelsArgs(args: string[], env?: NodeJS.ProcessEnv, cfg?: PiReviewConfig): string[];
 /** Prefer the larger of two captured stderr buffers; keep a readable stack tail. */
 export declare const CHILD_STDERR_DIAGNOSTIC_LIMIT = 12000;
 export declare function formatChildRuntimeDetail(runtimeError: string, stderr: string, limit?: number): string;

package/dist/review.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"review.d.ts","sourceRoot":"","sources":["../src/review.ts"],"names":[],"mappings":"AAMA,OAAO,KAAK,EAAE,UAAU,EAAc,eAAe,EAAE,MAAM,YAAY,CAAC;AAC1E,OAAO,EAA2C,KAAK,cAAc,EAAE,MAAM,oBAAoB,CAAC;AAalG,wBAAgB,eAAe,IAAI,MAAM,CAOxC;AAED,wBAAgB,QAAQ,CAAC,KAAK,EAAE,MAAM,GAAG,MAAM,CAAC,UAAU,CAczD;AAED;;;;;;;;;GASG;AACH,wBAAgB,kBAAkB,CAAC,GAAG,GAAE,MAAM,CAAC,UAAwB,GAAG,MAAM,EAAE,CAIjF;AAED,oFAAoF;AACpF,eAAO,MAAM,6BAA6B,QAAS,CAAC;AAEpD,wBAAgB,wBAAwB,CAAC,YAAY,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,KAAK,SAAgC,GAAG,MAAM,CAK5H;AAED,wFAAwF;AACxF,wBAAgB,cAAc,CAAC,WAAW,EAAE,MAAM,EAAE,UAAU,EAAE,OAAO,GAAG,MAAM,CAG/E;AAED;;gFAEgF;AAChF,wBAAgB,wBAAwB,CAAC,UAAU,EAAE,OAAO,EAAE,eAAe,EAAE,OAAO,GAAG,OAAO,CAE/F;AAED,wBAAgB,iBAAiB,CAAC,KAAK,EAAE,IAAI,CAAC,cAAc,EAAE,QAAQ,GAAG,QAAQ,GAAG,OAAO,CAAC,GAAG,MAAM,GAAG,SAAS,CAKhH;AAED,wBAAgB,SAAS,CAAC,KAAK,EAAE,MAAM,EAAE,IAAI,EAAE,MAAM,EAAE,GAAG,KAAK,CAM9D;AAED,wBAAsB,aAAa,CAAC,MAAM,EAAE,UAAU,EAAE,SAAS,SAAoB,GAAG,OAAO,CAAC,eAAe,CAAC,CAkM/G;AAED,+CAA+C;AAC/C,wBAAsB,SAAS,CAAC,MAAM,EAAE,UAAU,GAAG,OAAO,CAAC,KAAK,CAAC,CAGlE"}
+{"version":3,"file":"review.d.ts","sourceRoot":"","sources":["../src/review.ts"],"names":[],"mappings":"AAMA,OAAO,KAAK,EAAE,UAAU,EAAc,eAAe,EAAE,sBAAsB,EAAE,MAAM,YAAY,CAAC;AAClG,OAAO,EAA2C,KAAK,cAAc,EAAE,MAAM,oBAAoB,CAAC;AAclG,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,gBAAgB,CAAC;AAErD,wBAAgB,eAAe,IAAI,MAAM,CAOxC;AAED,wBAAgB,QAAQ,CAAC,KAAK,EAAE,MAAM,GAAG,MAAM,CAAC,UAAU,CAczD;AAED;;;;GAIG;AACH,wBAAgB,iBAAiB,CAAC,MAAM,EAAE,MAAM,GAAG,MAAM,EAAE,CAc1D;AAkCD,MAAM,MAAM,aAAa,GACrB;IAAE,IAAI,EAAE,WAAW,CAAA;CAAE,GACrB;IAAE,IAAI,EAAE,gBAAgB,CAAC;IAAC,QAAQ,EAAE,MAAM,CAAA;CAAE,GAC5C;IAAE,IAAI,EAAE,SAAS,CAAC;IAAC,QAAQ,EAAE,MAAM,CAAA;CAAE,GACrC;IAAE,IAAI,EAAE,eAAe,CAAC;IAAC,QAAQ,EAAE,MAAM,CAAA;CAAE,CAAC;AAEhD;;;;;;;GAOG;AACH,wBAAgB,yBAAyB,CAAC,KAAK,EAAE,MAAM,EAAE,QAAQ,EAAE,MAAM,GAAG,aAAa,CAQxF;AAED,mFAAmF;AACnF,wBAAgB,qBAAqB,CAAC,QAAQ,EAAE,MAAM,GAAG,MAAM,CAS9D;AAED,+EAA+E;AAC/E,wBAAgB,uBAAuB,CAAC,QAAQ,EAAE,MAAM,GAAG,MAAM,CAKhE;AAED;;;;;GAKG;AACH,MAAM,WAAW,mBAAmB;IAClC,UAAU,EAAE,sBAAsB,CAAC;IACnC,QAAQ,EAAE,MAAM,CAAC;IACjB,aAAa,EAAE,OAAO,CAAC;CACxB;AAED,wBAAgB,sBAAsB,CACpC,KAAK,EAAE,MAAM,EACb,QAAQ,EAAE,MAAM,GAAG,SAAS,EAC5B,KAAK,CAAC,EAAE,MAAM,GACb,mBAAmB,GAAG,SAAS,CAoBjC;AAED;;;;;;;;;;;GAWG;AACH,wBAAgB,kBAAkB,CAAC,GAAG,GAAE,MAAM,CAAC,UAAwB,EAAE,GAAG,CAAC,EAAE,cAAc,GAAG,MAAM,EAAE,CAGvG;AAED;;;;;GAKG;AACH,wBAAgB,UAAU,CAAC,IAAI,EAAE,MAAM,EAAE,EAAE,GAAG,GAAE,MAAM,CAAC,UAAwB,EAAE,GAAG,CAAC,EAAE,cAAc,GAAG,MAAM,EAAE,CAE/G;AAED,oFAAoF;AACpF,eAAO,MAAM,6BAA6B,QAAS,CAAC;AAEpD,wBAAgB,wBAAwB,CAAC,YAAY,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,KAAK,SAAgC,GAAG,MAAM,CAK5H;AAED,wFAAwF;AACxF,wBAAgB,cAAc,CAAC,WAAW,EAAE,MAAM,EAAE,UAAU,EAAE,OAAO,GAAG,MAAM,CAG/E;AAED;;gFAEgF;AAChF,wBAAgB,wBAAwB,CAAC,UAAU,EAAE,OAAO,EAAE,eAAe,EAAE,OAAO,GAAG,OAAO,CAE/F;AAED,wBAAgB,iBAAiB,CAAC,KAAK,EAAE,IAAI,CAAC,cAAc,EAAE,QAAQ,GAAG,QAAQ,GAAG,OAAO,CAAC,GAAG,MAAM,GAAG,SAAS,CAKhH;AAED,wBAAgB,SAAS,CAAC,KAAK,EAAE,MAAM,EAAE,IAAI,EAAE,MAAM,EAAE,GAAG,KAAK,CAM9D;AAED,wBAAsB,aAAa,CAAC,MAAM,EAAE,UAAU,EAAE,SAAS,SAAoB,GAAG,OAAO,CAAC,eAAe,CAAC,CAiO/G;AAED,+CAA+C;AAC/C,wBAAsB,SAAS,CAAC,MAAM,EAAE,UAAU,GAAG,OAAO,CAAC,KAAK,CAAC,CAGlE"}

package/dist/review.js

@@ -14,7 +14,9 @@ import { ProgressLogWriter } from "./progress-log.js";
 import { makeRunSessionDir, newestJsonl } from "./session.js";
 import { fail, hasPathSeparator, expandMaybeHome, normalizeTools } from "./utils.js";
 import { resolveConfig } from "./config.js";
+import { splitModelProvider } from "./panel-config.js";
 import { formatReviewMetaAscii, formatReviewMetaJsonLine } from "./meta-footer.js";
+import { currentConfig, resolveChildExtensions } from "./pi-config.js";
 export function readReviewStdin() {
     if (process.stdin.isTTY)
         return "";
@@ -40,20 +42,138 @@ export function childEnv(piBin) {
     };
 }
 /**
- * Isolate review children from host Pi extension side effects.
+ * Parse `pi --list-models` table output into distinct provider names.
+ * Columns are space-padded; offsets are derived from the header row so
+ * provider names are stable even if they contain spaces.
+ */
+export function parseModelCatalog(stdout) {
+    const lines = stdout.split("\n");
+    const headerIdx = lines.findIndex((l) => l.includes("provider") && l.includes("model"));
+    if (headerIdx === -1)
+        return [];
+    const header = lines[headerIdx];
+    const providerStart = header.indexOf("provider");
+    const modelStart = header.indexOf("model");
+    const providers = new Set();
+    for (const line of lines.slice(headerIdx + 1)) {
+        if (!line.trim())
+            continue;
+        const provider = line.slice(providerStart, modelStart).trim();
+        if (provider)
+            providers.add(provider);
+    }
+    return [...providers];
+}
+const MODEL_CATALOG_CACHE = new Map();
+function catalogCacheKey(piBin, isolated) {
+    return `${piBin}|${isolated ? "no-ext" : "with-ext"}`;
+}
+function listProviders(piBin, isolated) {
+    const key = catalogCacheKey(piBin, isolated);
+    const cached = MODEL_CATALOG_CACHE.get(key);
+    if (cached)
+        return cached;
+    const args = ["--list-models", ...(isolated ? ["--no-extensions"] : [])];
+    const result = spawnSync(piBin, args, {
+        env: childEnv(piBin),
+        encoding: "utf8",
+        maxBuffer: 16 * 1024 * 1024,
+    });
+    const query = result.status === 0 && result.stdout
+        ? { providers: new Set(parseModelCatalog(result.stdout)), ok: true }
+        : { providers: new Set(), ok: false };
+    // Only cache successful queries: a transient spawn failure (slow startup,
+    // config read hiccup) must not poison the probe for the rest of the run.
+    if (query.ok)
+        MODEL_CATALOG_CACHE.set(key, query);
+    return query;
+}
+/**
+ * Decide whether `provider` is usable by an isolated review child
+ * (--no-extensions, issue #8). Missing from the isolated catalog but present
+ * with host extensions loaded means the provider is registered by an
+ * extension; the caller should surface a fix hint instead of a confusing
+ * unknown-provider failure. A failed catalog query is `indeterminate`: the
+ * caller must not block a possibly-valid provider on probe trouble.
+ */
+export function probeProviderAvailability(piBin, provider) {
+    const isolated = listProviders(piBin, true);
+    if (!isolated.ok)
+        return { kind: "indeterminate", provider };
+    if (isolated.providers.has(provider))
+        return { kind: "available" };
+    const withExtensions = listProviders(piBin, false);
+    if (!withExtensions.ok)
+        return { kind: "indeterminate", provider };
+    if (withExtensions.providers.has(provider))
+        return { kind: "extension_only", provider };
+    return { kind: "unknown", provider };
+}
+/** Human-readable fix hint for a provider that only exists via host extensions. */
+export function extensionOnlyHintText(provider) {
+    return [
+        `provider "${provider}" is registered by a Pi extension, but review children`,
+        `run isolated with --no-extensions (issue #8).`,
+        "",
+        "Enable extension-registered providers persistently in the review config:",
+        `    ~/.pi/pi-review/config.json  →  { "childExtensions": true }`,
+        "(or override one run: PI_REVIEW_CHILD_EXTENSIONS=1 pi-review ...)",
+    ].join("\n");
+}
+/** Human-readable message for a provider missing from the catalog entirely. */
+export function unknownProviderHintText(provider) {
+    return [
+        `provider "${provider}" was not found in the Pi model catalog (with or`,
+        `without host extensions loaded). Check --provider / preset provider spelling.`,
+    ].join("\n");
+}
+export function configBlockForProvider(piBin, provider, model) {
+    const probeProvider = provider ?? (model ? splitModelProvider(model) : undefined);
+    if (!probeProvider || childIsolationArgs().length === 0)
+        return undefined;
+    const probe = probeProviderAvailability(piBin, probeProvider);
+    // available → proceed; indeterminate (catalog query failed) → proceed and
+    // let the child surface its own accurate error rather than block on probe trouble.
+    if (probe.kind === "available" || probe.kind === "indeterminate")
+        return undefined;
+    const extensionOnly = probe.kind === "extension_only";
+    return {
+        provider: probeProvider,
+        extensionOnly,
+        structured: {
+            status: "blocked",
+            verdict: "blocked",
+            verdictSource: "config_error",
+            parseError: extensionOnly ? extensionOnlyHintText(probeProvider) : unknownProviderHintText(probeProvider),
+            findings: [],
+            actionableCount: 0,
+        },
+    };
+}
+/** Isolate review children from host Pi extension side effects.
  *
  * Host extensions (usage HUDs, auto-reload bridges, etc.) may capture extension
  * ctx and touch it after session dispose/reload. That throws Pi's stale-context
  * error and can crash an otherwise successful reviewer child (issue #8).
  *
- * Opt out with PI_REVIEW_CHILD_EXTENSIONS=1 when a custom provider truly requires
- * host extension registration inside the child.
+ * The effective value comes from the persistent review config
+ * (childExtensions, ~/.pi/pi-review/config.json), overridden per process by
+ * PI_REVIEW_CHILD_EXTENSIONS (1/true/keep enable, any other set value
+ * disables). Bare CLI stays isolated (--no-extensions) until the config says
+ * otherwise.
  */
-export function childIsolationArgs(env = process.env) {
-    const raw = env.PI_REVIEW_CHILD_EXTENSIONS?.trim().toLowerCase();
-    if (raw === "1" || raw === "true" || raw === "keep")
-        return [];
-    return ["--no-extensions"];
+export function childIsolationArgs(env = process.env, cfg) {
+    const decision = resolveChildExtensions(env, cfg ?? currentConfig(env).config);
+    return decision.enabled ? [] : ["--no-extensions"];
+}
+/**
+ * Build the catalog command args so the models command shows the same catalog
+ * an actual review child would see: the effective isolation config applies
+ * here too (F2: catalog and review must agree on extension-registered
+ * providers).
+ */
+export function modelsArgs(args, env = process.env, cfg) {
+    return ["--list-models", ...childIsolationArgs(env, cfg), ...args];
 }
 /** Prefer the larger of two captured stderr buffers; keep a readable stack tail. */
 export const CHILD_STDERR_DIAGNOSTIC_LIMIT = 12_000;
@@ -86,7 +206,7 @@ export function childRuntimeError(child) {
     return undefined;
 }
 export function runModels(piBin, args) {
-    const result = spawnSync(piBin, ["--list-models", ...args], {
+    const result = spawnSync(piBin, modelsArgs(args), {
         stdio: "inherit",
         env: childEnv(piBin),
     });
@@ -138,6 +258,36 @@ export async function runReviewOnce(parsed, stdinText = readReviewStdin()) {
     }
     // Isolate single-review children from host extension side effects (issue #8).
     args.push(...childIsolationArgs());
+    // Block before spawning when the requested provider only exists via host
+    // extensions (issue #8): the isolated child would otherwise die with a
+    // confusing unknown-provider error. Surface an actionable hint so the host
+    // agent knows to re-run with PI_REVIEW_CHILD_EXTENSIONS=1.
+    const configBlock = configBlockForProvider(config.piBin, parsed.provider || preset.provider, parsed.model || preset.model);
+    if (configBlock) {
+        const hint = configBlock.structured.parseError ?? "";
+        const meta = {
+            metaVersion: REVIEW_META_VERSION,
+            reviewMode: parsed.mode,
+            ...configBlock.structured,
+            durationMs: 0,
+            model: parsed.model || preset.model || null,
+            ...(parsed.thinking || preset.thinking ? { thinking: parsed.thinking || preset.thinking } : {}),
+            ...(configBlock.extensionOnly
+                ? { extensionHint: { provider: configBlock.provider, availableViaExtension: true } }
+                : {}),
+        };
+        process.stdout.write(`${hint}\n\n`);
+        process.stdout.write(`${formatReviewMetaAscii(meta)}\n`);
+        const metaJsonDest = process.env.PI_REVIEW_META_STDOUT?.toLowerCase();
+        const jsonLine = formatReviewMetaJsonLine(meta);
+        if (metaJsonDest === "1" || metaJsonDest === "true" || metaJsonDest === "stdout") {
+            process.stdout.write(jsonLine);
+        }
+        else {
+            process.stderr.write(jsonLine);
+        }
+        return { meta, exitCode: reviewExitCode(meta.status) };
+    }
     args.push(...(payload.attachableFileRefs ?? payload.fileRefs), prompt);
     let progressWriter;
     if (parsed.progressLog) {