@zeniai/client-epic-state 5.3.2 → 5.3.3-beta0KB

package/lib/esm/view/expenseAutomationView/epics/accountRecon/fetchReconciliationViewEpic.js

@@ -26,9 +26,10 @@ export const fetchReconciliationViewEpic = (actions$, state$, zeniAPI) => action
     }
     let fetchState;
     if (accountId != null) {
+        // Period bucket can be unhydrated during app-shell load.
         fetchState =
             accountReconciliationRecords[toMonthYearPeriodId(selectedPeriod)]
-                .reconciliationByAccountID[accountId].transactionFetchState
+                ?.reconciliationByAccountID[accountId]?.transactionFetchState
                 .fetchState;
     }
     else {

package/lib/esm/view/transactionDetail/createTransaction/createTransactionPayload.js

@@ -4,6 +4,10 @@ import { getClassById } from '../../../entity/class/classSelector';
 import { toProjectBasePayload, } from '../../../entity/project/projectPayload';
 import { getProjectById } from '../../../entity/project/projectSelector';
 import { getVendorByQboId, getVendorByVendorId, } from '../../../entity/vendor/vendorSelector';
+const POSTING_TYPE_NAME = {
+    credit: 'Credit',
+    debit: 'Debit',
+};
 const toRemitToAddressPayload = (address) => {
     if (address == null) {
         return undefined;
@@ -35,10 +39,12 @@ const toLinePayload = (state, line, transactionType) => {
         });
     }
     if (transactionType === 'journal_entry') {
-        lineDetail.posting_type = line.postingType;
+        if (line.postingType != null) {
+            lineDetail.posting_type_name = POSTING_TYPE_NAME[line.postingType];
+        }
         const vendorQboId = toQboLineVendorId(state, line.vendorQboId);
         if (vendorQboId != null) {
-            lineDetail.vendor = { qbo_id: vendorQboId };
+            lineDetail.vendor = { vendor_id: vendorQboId };
         }
     }
     return {
@@ -128,7 +134,6 @@ export const prepareCreateTransactionPayload = (state, localData) => {
     if (transactionType === 'journal_entry') {
         return {
             ...base,
-            document_id: localData.documentId,
             lines,
         };
     }

package/lib/view/expenseAutomationView/epics/accountRecon/fetchReconciliationViewEpic.js

@@ -29,9 +29,10 @@ const fetchReconciliationViewEpic = (actions$, state$, zeniAPI) => actions$.pipe
     }
     let fetchState;
     if (accountId != null) {
+        // Period bucket can be unhydrated during app-shell load.
         fetchState =
             accountReconciliationRecords[(0, timePeriod_1.toMonthYearPeriodId)(selectedPeriod)]
-                .reconciliationByAccountID[accountId].transactionFetchState
+                ?.reconciliationByAccountID[accountId]?.transactionFetchState
                 .fetchState;
     }
     else {

package/lib/view/transactionDetail/createTransaction/createTransactionPayload.d.ts

@@ -12,8 +12,8 @@ import { CreateTransactionLocalData } from './createTransactionState';
  * 1. `line_detail_type` is snake_case. The PascalCase strings in the backend are Python
  *    constant NAMES; ZENI_LINE_DETAIL_TYPE_TO_QBO_LINE_DETAIL_TYPE_MAP converts them for the
  *    body the backend sends on to QuickBooks, never for ours.
- * 2. The reference number uses two different keys depending on the QBO entity. check and
- *    expense are Purchases and take `document_number`; everything else takes `document_id`.
+ * 2. Only the QBO Purchases (check, credit_card_credit) send a reference number, as
+ *    `document_number`. A journal entry sends none.
  */
 export interface CreateTransactionAccountPayload {
     qbo_id: ID;
@@ -25,14 +25,15 @@ export interface CreateTransactionLineDetailPayload {
         qbo_id: ID;
     };
     /**
-     * journal_entry only, and it MUST sit inside line_detail. The write validator's docstring
-     * warns that a misplaced posting_type is silently dropped and then rejected by QBO.
+     * journal_entry only, inside line_detail. QBOJournalEntry reads only posting_type_name; a
+     * lowercase posting_type is dropped and QBO then rejects the line.
      */
-    posting_type?: 'credit' | 'debit';
+    posting_type_name?: 'Credit' | 'Debit';
     /** Same shape the transaction update sends on a vendor line. */
     project?: ProjectBasePayload;
+    /** journal_entry only. The backend reads the QBO vendor id from `vendor_id`, not `qbo_id`. */
     vendor?: {
-        qbo_id: ID;
+        vendor_id: ID;
     };
 }
 export interface CreateTransactionLinePayload {
@@ -51,8 +52,6 @@ export interface CreateTransactionRemitToAddressPayload {
 export interface CreateTransactionRequest extends Record<string, unknown> {
     transaction_date: string;
     transaction_type: string;
-    /** journal_entry reference number. */
-    document_id?: string;
     /** check / credit_card_credit reference number (QBO Purchase). */
     document_number?: string;
     from_account_id?: ID;

package/lib/view/transactionDetail/createTransaction/createTransactionPayload.js

@@ -7,6 +7,10 @@ const classSelector_1 = require("../../../entity/class/classSelector");
 const projectPayload_1 = require("../../../entity/project/projectPayload");
 const projectSelector_1 = require("../../../entity/project/projectSelector");
 const vendorSelector_1 = require("../../../entity/vendor/vendorSelector");
+const POSTING_TYPE_NAME = {
+    credit: 'Credit',
+    debit: 'Debit',
+};
 const toRemitToAddressPayload = (address) => {
     if (address == null) {
         return undefined;
@@ -38,10 +42,12 @@ const toLinePayload = (state, line, transactionType) => {
         });
     }
     if (transactionType === 'journal_entry') {
-        lineDetail.posting_type = line.postingType;
+        if (line.postingType != null) {
+            lineDetail.posting_type_name = POSTING_TYPE_NAME[line.postingType];
+        }
         const vendorQboId = toQboLineVendorId(state, line.vendorQboId);
         if (vendorQboId != null) {
-            lineDetail.vendor = { qbo_id: vendorQboId };
+            lineDetail.vendor = { vendor_id: vendorQboId };
         }
     }
     return {
@@ -132,7 +138,6 @@ const prepareCreateTransactionPayload = (state, localData) => {
     if (transactionType === 'journal_entry') {
         return {
             ...base,
-            document_id: localData.documentId,
             lines,
         };
     }

package/lib/view/transactionDetail/createTransaction/createTransactionState.d.ts

@@ -54,8 +54,6 @@ export interface CreateTransactionLocalData {
     /** Empty for transfer, which has no lines at all. */
     lines: CreateTransactionLineLocalData[];
     transactionType: CreatableTransactionType;
-    /** journal_entry reference number. */
-    documentId?: string;
     /** check / credit_card_credit reference number. */
     documentNumber?: string;
     /** transfer */

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.3.2",
+  "version": "5.3.3-beta0KB",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",