@zeniai/client-epic-state 5.2.97-beta0KB → 5.2.97-beta1KB

package/lib/entity/genericEntity/entitySelector.d.ts

@@ -1,5 +1,3 @@
 import { ID } from '../../commonStateTypes/common';
-import { Entity } from './entity';
 import { EntityState } from './entityState';
-export declare function getEntityByEntityIDs(entityState: EntityState, entityIds: ID[]): Entity[];
-export declare function getEntityByEntityId(entityState: EntityState, entityId: ID): Entity | undefined;
+export declare function getEntityByEntityIDs(entityState: EntityState, entityIds: ID[]): import("./entity").Entity[];

package/lib/entity/genericEntity/entitySelector.js

@@ -1,16 +1,8 @@
 "use strict";
-var __importDefault = (this && this.__importDefault) || function (mod) {
-    return (mod && mod.__esModule) ? mod : { "default": mod };
-};
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.getEntityByEntityIDs = getEntityByEntityIDs;
-exports.getEntityByEntityId = getEntityByEntityId;
-const get_1 = __importDefault(require("lodash/get"));
 function getEntityByEntityIDs(entityState, entityIds) {
     return entityIds.map((entityId) => {
         return entityState.entityById[entityId];
     });
 }
-function getEntityByEntityId(entityState, entityId) {
-    return (0, get_1.default)(entityState.entityById, entityId, undefined);
-}

package/lib/esm/entity/genericEntity/entitySelector.js

@@ -1,9 +1,5 @@
-import recordGet from 'lodash/get';
 export function getEntityByEntityIDs(entityState, entityIds) {
     return entityIds.map((entityId) => {
         return entityState.entityById[entityId];
     });
 }
-export function getEntityByEntityId(entityState, entityId) {
-    return recordGet(entityState.entityById, entityId, undefined);
-}

package/lib/esm/view/transactionDetail/createTransaction/createTransactionPayload.js

@@ -1,7 +1,6 @@
 import { DEFAULT_DATE_FORMAT } from '../../../commonStateTypes/timePeriod';
 import { getAccountBaseForTransferAccounts } from '../../../entity/account/accountSelector';
 import { getClassById } from '../../../entity/class/classSelector';
-import { getEntityByEntityId } from '../../../entity/genericEntity/entitySelector';
 import { toProjectBasePayload, } from '../../../entity/project/projectPayload';
 import { getProjectById } from '../../../entity/project/projectSelector';
 import { getVendorByQboId, getVendorByVendorId, } from '../../../entity/vendor/vendorSelector';
@@ -94,14 +93,10 @@ const toSyncedVendorQboId = (vendor) => {
     }
     return vendor.qboId;
 };
-/**
- * Resolves the picked vendor to its QBO id -- `vendor_id` on the wire is a QBO id. A vendor
- * found by the server-side search is only in the entity store, keyed by its entity id.
- */
+/** Resolves a Zeni vendor id to its QBO id -- `vendor_id` on the wire is a QBO id. */
 const toQboVendorId = (state, vendorId) => vendorId == null
     ? undefined
-    : toSyncedVendorQboId(getVendorByVendorId(state.vendorState, vendorId) ??
-        getEntityByEntityId(state.entityState, vendorId));
+    : toSyncedVendorQboId(getVendorByVendorId(state.vendorState, vendorId));
 /** A journal entry line holds the QBO id already, so it is only checked against the store. */
 const toQboLineVendorId = (state, vendorQboId) => vendorQboId == null
     ? undefined
@@ -133,7 +128,6 @@ export const prepareCreateTransactionPayload = (state, localData) => {
     if (transactionType === 'journal_entry') {
         return {
             ...base,
-            document_id: localData.documentId,
             lines,
         };
     }

package/lib/view/transactionDetail/createTransaction/createTransactionPayload.d.ts

@@ -12,8 +12,8 @@ import { CreateTransactionLocalData } from './createTransactionState';
  * 1. `line_detail_type` is snake_case. The PascalCase strings in the backend are Python
  *    constant NAMES; ZENI_LINE_DETAIL_TYPE_TO_QBO_LINE_DETAIL_TYPE_MAP converts them for the
  *    body the backend sends on to QuickBooks, never for ours.
- * 2. The reference number uses two different keys depending on the QBO entity. check and
- *    expense are Purchases and take `document_number`; everything else takes `document_id`.
+ * 2. Only the QBO Purchases (check, credit_card_credit) send a reference number, as
+ *    `document_number`. A journal entry sends none.
  */
 export interface CreateTransactionAccountPayload {
     qbo_id: ID;
@@ -51,8 +51,6 @@ export interface CreateTransactionRemitToAddressPayload {
 export interface CreateTransactionRequest extends Record<string, unknown> {
     transaction_date: string;
     transaction_type: string;
-    /** journal_entry reference number. */
-    document_id?: string;
     /** check / credit_card_credit reference number (QBO Purchase). */
     document_number?: string;
     from_account_id?: ID;

package/lib/view/transactionDetail/createTransaction/createTransactionPayload.js

@@ -4,7 +4,6 @@ exports.prepareCreateTransactionPayload = exports.UnresolvedCreateTransactionIdE
 const timePeriod_1 = require("../../../commonStateTypes/timePeriod");
 const accountSelector_1 = require("../../../entity/account/accountSelector");
 const classSelector_1 = require("../../../entity/class/classSelector");
-const entitySelector_1 = require("../../../entity/genericEntity/entitySelector");
 const projectPayload_1 = require("../../../entity/project/projectPayload");
 const projectSelector_1 = require("../../../entity/project/projectSelector");
 const vendorSelector_1 = require("../../../entity/vendor/vendorSelector");
@@ -98,14 +97,10 @@ const toSyncedVendorQboId = (vendor) => {
     }
     return vendor.qboId;
 };
-/**
- * Resolves the picked vendor to its QBO id -- `vendor_id` on the wire is a QBO id. A vendor
- * found by the server-side search is only in the entity store, keyed by its entity id.
- */
+/** Resolves a Zeni vendor id to its QBO id -- `vendor_id` on the wire is a QBO id. */
 const toQboVendorId = (state, vendorId) => vendorId == null
     ? undefined
-    : toSyncedVendorQboId((0, vendorSelector_1.getVendorByVendorId)(state.vendorState, vendorId) ??
-        (0, entitySelector_1.getEntityByEntityId)(state.entityState, vendorId));
+    : toSyncedVendorQboId((0, vendorSelector_1.getVendorByVendorId)(state.vendorState, vendorId));
 /** A journal entry line holds the QBO id already, so it is only checked against the store. */
 const toQboLineVendorId = (state, vendorQboId) => vendorQboId == null
     ? undefined
@@ -137,7 +132,6 @@ const prepareCreateTransactionPayload = (state, localData) => {
     if (transactionType === 'journal_entry') {
         return {
             ...base,
-            document_id: localData.documentId,
             lines,
         };
     }

package/lib/view/transactionDetail/createTransaction/createTransactionState.d.ts

@@ -54,8 +54,6 @@ export interface CreateTransactionLocalData {
     /** Empty for transfer, which has no lines at all. */
     lines: CreateTransactionLineLocalData[];
     transactionType: CreatableTransactionType;
-    /** journal_entry reference number. */
-    documentId?: string;
     /** check / credit_card_credit reference number. */
     documentNumber?: string;
     /** transfer */

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.2.97-beta0KB",
+  "version": "5.2.97-beta1KB",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",