@zeniai/client-epic-state 5.2.59-beta0ND → 5.2.60

package/lib/view/invoicing/invoicingCatalogListView/invoicingCatalogListViewSelector.js

@@ -5,8 +5,20 @@ const toolkit_1 = require("@reduxjs/toolkit");
 const planSelector_1 = require("../../../entity/invoicing/plan/planSelector");
 const runningInvoicingActionId_1 = require("../runningInvoicingActionId");
 const invoicingCatalogListViewState_1 = require("./invoicingCatalogListViewState");
+/**
+ * Flatten catalog items into the price rows the pickers render.
+ *
+ * The parent item's `applicableItems` / `itemApplicability` are carried onto
+ * every row it produces: applicability is a property of the catalog item, not
+ * of its price points, and a row that has lost it cannot be matched against the
+ * selected plan's allow-list (see `getInvoicingItemsAllowedForPlan`). Both are
+ * written after the spread so the item's own rule wins over any stale copy a
+ * price point payload may carry.
+ */
 const getInvoicingCatalogPrices = (items) => items.flatMap((item) => (item.subFamilies ?? []).map((subFamily) => ({
     ...subFamily,
+    applicableItems: item.applicableItems,
+    itemApplicability: item.itemApplicability,
     itemID: item.id,
     itemType: item.type ?? item.itemType,
     name: subFamily.name,

package/lib/view/recommendation/recommendationPayload.d.ts

@@ -15,6 +15,7 @@ export type FetchRecommendationResponseWithCOT = ZeniAPIResponse<FetchRecommenda
 export type RecommendationFeedbackDimension = 'vendor' | 'category' | 'class';
 export type RecommendationFeedbackSource = 'primary' | 'alternate' | 'shadow' | 'qbo';
 export type RecommendationFeedbackOutcome = 'accepted' | 'override_ranked' | 'override_outside' | 'retracted';
+export declare const isPromptedRecommendationFeedback: (outcome: RecommendationFeedbackOutcome) => boolean;
 export interface RecommendationFeedbackValue {
     name: string;
     id?: string | null;

package/lib/view/recommendation/recommendationPayload.js

@@ -1,2 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.isPromptedRecommendationFeedback = void 0;
+// Only an override opens the feedback popup. Silent accepts and retractions post
+// in the background, so they must not drive the popup's loader or its toast.
+const isPromptedRecommendationFeedback = (outcome) => outcome === 'override_outside' || outcome === 'override_ranked';
+exports.isPromptedRecommendationFeedback = isPromptedRecommendationFeedback;

package/lib/view/recommendation/recommendationReducer.d.ts

@@ -58,6 +58,12 @@ export declare const fetchEntityRecommendationsByTransactionId: import("@reduxjs
 }, "recommendation/updateRecommendationForEntityFailure">, indicateReadyToInitializeRecommendation: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[entityIdOrName: string, entityType: EntityType], {
     entityIdOrName: string;
     entityType: EntityType;
-}, "recommendation/indicateReadyToInitializeRecommendation", never, never>, submitRecommendationFeedback: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[args: SubmitRecommendationFeedbackPayload], SubmitRecommendationFeedbackPayload, "recommendation/submitRecommendationFeedback", never, never>;
+}, "recommendation/indicateReadyToInitializeRecommendation", never, never>, submitRecommendationFeedback: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[args: SubmitRecommendationFeedbackPayload], SubmitRecommendationFeedbackPayload, "recommendation/submitRecommendationFeedback", never, never>, submitRecommendationFeedbackCompleted: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[args: {
+    succeeded: boolean;
+    error?: ZeniAPIStatus;
+}], {
+    succeeded: boolean;
+    error?: ZeniAPIStatus;
+}, "recommendation/submitRecommendationFeedbackCompleted", never, never>;
 declare const _default: import("redux").Reducer<EntityRecommendationState>;
 export default _default;

package/lib/view/recommendation/recommendationReducer.js

@@ -1,11 +1,13 @@
 "use strict";
 var _a;
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.submitRecommendationFeedback = exports.indicateReadyToInitializeRecommendation = exports.updateRecommendationForEntityFailure = exports.updateRecommendationForEntity = exports.fetchRecommendationByEntityId = exports.fetchRecommendationByEntityName = exports.fetchEntityRecommendationsForLineUpdate = exports.fetchEntityRecommendationsByTransactionId = exports.initialState = void 0;
+exports.submitRecommendationFeedbackCompleted = exports.submitRecommendationFeedback = exports.indicateReadyToInitializeRecommendation = exports.updateRecommendationForEntityFailure = exports.updateRecommendationForEntity = exports.fetchRecommendationByEntityId = exports.fetchRecommendationByEntityName = exports.fetchEntityRecommendationsForLineUpdate = exports.fetchEntityRecommendationsByTransactionId = exports.initialState = void 0;
 const toolkit_1 = require("@reduxjs/toolkit");
 const rootActions_1 = require("../../rootActions");
+const recommendationPayload_1 = require("./recommendationPayload");
 const recommendationState_1 = require("./recommendationState");
 exports.initialState = {
+    feedbackSubmitState: { fetchState: 'Not-Started', error: undefined },
     recommendationByEntity: {},
 };
 const recommendation = (0, toolkit_1.createSlice)({
@@ -135,13 +137,31 @@ const recommendation = (0, toolkit_1.createSlice)({
                 };
             },
         },
-        // Fire-and-forget human feedback on a recommendation (accept, ranked
-        // override or outside override). Handled by submitRecommendationFeedbackEpic
-        // which POSTs to the accounting recommendation-feedback endpoint. No state
-        // mutation: the categorization UX must not depend on the feedback round-trip.
+        // Human feedback on a recommendation (accept, ranked override or outside
+        // override). Handled by submitRecommendationFeedbackEpic, which POSTs to the
+        // accounting recommendation-feedback endpoint. The categorization itself
+        // never waits on this: only the feedback popup reads the submit state.
         submitRecommendationFeedback: {
-            reducer() {
-                // Fire-and-forget: no state mutation; the epic performs the POST.
+            reducer(draft, action) {
+                if (!(0, recommendationPayload_1.isPromptedRecommendationFeedback)(action.payload.outcome)) {
+                    return;
+                }
+                draft.feedbackSubmitState = {
+                    fetchState: 'In-Progress',
+                    error: undefined,
+                };
+            },
+            prepare(args) {
+                return { payload: args };
+            },
+        },
+        submitRecommendationFeedbackCompleted: {
+            reducer(draft, action) {
+                const { succeeded, error } = action.payload;
+                draft.feedbackSubmitState = {
+                    fetchState: succeeded ? 'Completed' : 'Error',
+                    error,
+                };
             },
             prepare(args) {
                 return { payload: args };
@@ -154,7 +174,7 @@ const recommendation = (0, toolkit_1.createSlice)({
         });
     },
 });
-_a = recommendation.actions, exports.fetchEntityRecommendationsByTransactionId = _a.fetchEntityRecommendationsByTransactionId, exports.fetchEntityRecommendationsForLineUpdate = _a.fetchEntityRecommendationsForLineUpdate, exports.fetchRecommendationByEntityName = _a.fetchRecommendationByEntityName, exports.fetchRecommendationByEntityId = _a.fetchRecommendationByEntityId, exports.updateRecommendationForEntity = _a.updateRecommendationForEntity, exports.updateRecommendationForEntityFailure = _a.updateRecommendationForEntityFailure, exports.indicateReadyToInitializeRecommendation = _a.indicateReadyToInitializeRecommendation, exports.submitRecommendationFeedback = _a.submitRecommendationFeedback;
+_a = recommendation.actions, exports.fetchEntityRecommendationsByTransactionId = _a.fetchEntityRecommendationsByTransactionId, exports.fetchEntityRecommendationsForLineUpdate = _a.fetchEntityRecommendationsForLineUpdate, exports.fetchRecommendationByEntityName = _a.fetchRecommendationByEntityName, exports.fetchRecommendationByEntityId = _a.fetchRecommendationByEntityId, exports.updateRecommendationForEntity = _a.updateRecommendationForEntity, exports.updateRecommendationForEntityFailure = _a.updateRecommendationForEntityFailure, exports.indicateReadyToInitializeRecommendation = _a.indicateReadyToInitializeRecommendation, exports.submitRecommendationFeedback = _a.submitRecommendationFeedback, exports.submitRecommendationFeedbackCompleted = _a.submitRecommendationFeedbackCompleted;
 exports.default = recommendation.reducer;
 const doUpdateRecommendationForEntity = (draft, entityId, entityType, payload) => {
     const key = (0, recommendationState_1.getEntityRecommendationKey)(entityType, entityId);

package/lib/view/recommendation/recommendationSelector.d.ts

@@ -1,3 +1,4 @@
+import { FetchStateAndError } from '../../commonStateTypes/common';
 import { Recommendation } from '../../commonStateTypes/recommendationBase';
 import { SelectorView } from '../../commonStateTypes/viewAndReport/viewAndReport';
 import { EntityType } from '../../entity/genericEntity/entity';
@@ -8,3 +9,4 @@ export interface RecommendationByEntitySelectorView extends SelectorView {
     recommendations?: Recommendation[];
 }
 export declare const getRecommendationsForEntity: (state: RootState, entityId: string, entityType: EntityType) => RecommendationByEntitySelectorView;
+export declare const getRecommendationFeedbackSubmitState: (state: RootState) => FetchStateAndError;

package/lib/view/recommendation/recommendationSelector.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.getRecommendationsForEntity = void 0;
+exports.getRecommendationFeedbackSubmitState = exports.getRecommendationsForEntity = void 0;
 const recommendationState_1 = require("./recommendationState");
 const getRecommendationsForEntity = (state, entityId, entityType) => {
     const { entityRecommendationState } = state;
@@ -15,3 +15,5 @@ const getRecommendationsForEntity = (state, entityId, entityType) => {
     };
 };
 exports.getRecommendationsForEntity = getRecommendationsForEntity;
+const getRecommendationFeedbackSubmitState = (state) => state.entityRecommendationState.feedbackSubmitState;
+exports.getRecommendationFeedbackSubmitState = getRecommendationFeedbackSubmitState;

package/lib/view/recommendation/recommendationState.d.ts

@@ -1,4 +1,4 @@
-import { FetchedState } from '../../commonStateTypes/common';
+import { FetchStateAndError, FetchedState } from '../../commonStateTypes/common';
 import { Recommendation } from '../../commonStateTypes/recommendationBase';
 import { EntityType } from '../../entity/genericEntity/entity';
 export declare const getEntityRecommendationKey: (entityType: EntityType, entityIdOrName: string) => `vendor_${string}` | `customer_${string}` | `merchant_${string}`;
@@ -8,5 +8,6 @@ export interface EntityRecommendationsStatus extends FetchedState {
 }
 export declare const initialEntityRecommendationState: EntityRecommendationsStatus;
 export interface EntityRecommendationState {
+    feedbackSubmitState: FetchStateAndError;
     recommendationByEntity: Record<EntityRecommendationKey, EntityRecommendationsStatus>;
 }

package/lib/view/recommendation/submitRecommendationFeedbackEpic.d.ts

@@ -2,6 +2,6 @@ import { ActionsObservable, StateObservable } from 'redux-observable';
 import { Observable } from 'rxjs';
 import { RootState } from '../../reducer';
 import { ZeniAPI } from '../../zeniAPI';
-import { submitRecommendationFeedback } from './recommendationReducer';
-export type ActionType = ReturnType<typeof submitRecommendationFeedback>;
+import { submitRecommendationFeedback, submitRecommendationFeedbackCompleted } from './recommendationReducer';
+export type ActionType = ReturnType<typeof submitRecommendationFeedback> | ReturnType<typeof submitRecommendationFeedbackCompleted>;
 export declare const submitRecommendationFeedbackEpic: (actions$: ActionsObservable<ActionType>, _state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => Observable<ActionType>;

package/lib/view/recommendation/submitRecommendationFeedbackEpic.js

@@ -4,6 +4,7 @@ exports.submitRecommendationFeedbackEpic = void 0;
 const rxjs_1 = require("rxjs");
 const operators_1 = require("rxjs/operators");
 const responsePayload_1 = require("../../responsePayload");
+const recommendationPayload_1 = require("./recommendationPayload");
 const recommendationReducer_1 = require("./recommendationReducer");
 const toRequestBody = (payload) => ({
     line_id: payload.lineId ?? null,
@@ -36,21 +37,32 @@ const toRequestBody = (payload) => ({
     retracts_feedback_id: payload.retractsFeedbackId ?? null,
     features: payload.features ?? null,
 });
-// Fire-and-forget: the epic never re-emits an action. Feedback delivery is a
-// side-effect that must not disrupt the categorization UX, so both the
-// success and error paths complete silently (errors are logged for debugging).
+// Always reports completion so the feedback popup can show a loader and tell the
+// user what happened. The categorization itself still never waits on this: a
+// failure is surfaced in a toast rather than blocking or reverting the change.
 const submitRecommendationFeedbackEpic = (actions$, _state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(recommendationReducer_1.submitRecommendationFeedback.match), (0, operators_1.mergeMap)((action) => {
     const { transactionId } = action.payload;
+    // Only the override that opened the popup reports completion; accepts and
+    // retractions stay fire-and-forget so they cannot settle the popup.
+    const isPrompted = (0, recommendationPayload_1.isPromptedRecommendationFeedback)(action.payload.outcome);
     return zeniAPI
         .postAndGetJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/transactions/${transactionId}/recommendation-feedback`, toRequestBody(action.payload))
         .pipe((0, operators_1.mergeMap)((response) => {
-        if (!(0, responsePayload_1.isSuccessStatus)(response)) {
+        const succeeded = (0, responsePayload_1.isSuccessStatus)(response);
+        if (!succeeded) {
             console.error('submitRecommendationFeedbackEpic: recommendation feedback was not recorded', response.status);
         }
-        return rxjs_1.EMPTY;
+        return isPrompted
+            ? (0, rxjs_1.of)((0, recommendationReducer_1.submitRecommendationFeedbackCompleted)({
+                succeeded,
+                error: succeeded ? undefined : response.status,
+            }))
+            : rxjs_1.EMPTY;
     }), (0, operators_1.catchError)((error) => {
         console.error('submitRecommendationFeedbackEpic: failed to submit recommendation feedback', error);
-        return rxjs_1.EMPTY;
+        return isPrompted
+            ? (0, rxjs_1.of)((0, recommendationReducer_1.submitRecommendationFeedbackCompleted)({ succeeded: false }))
+            : rxjs_1.EMPTY;
     }));
 }));
 exports.submitRecommendationFeedbackEpic = submitRecommendationFeedbackEpic;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.2.59-beta0ND",
+  "version": "5.2.60",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",
@@ -53,6 +53,31 @@
     "url": "https://github.com/zeni-ai/client-epic-state/issues"
   },
   "homepage": "https://github.com/zeni-ai/client-epic-state#readme",
+  "devDependencies": {
+    "@eslint/js": "^9.24.0",
+    "@liveblocks/client": "^2.23.0",
+    "@trivago/prettier-plugin-sort-imports": "^5.2.2",
+    "@types/big.js": "^6.2.2",
+    "@types/lodash": "^4.17.23",
+    "@types/node": "^20.19.0",
+    "@types/url-parse": "^1.4.11",
+    "@typescript-eslint/eslint-plugin": "^8.56.0",
+    "@typescript-eslint/parser": "^8.56.0",
+    "concurrently": "^9.1.2",
+    "eslint": "^9.24.0",
+    "eslint-config-prettier": "^10.0.2",
+    "eslint-plugin-perfectionist": "^4.15.0",
+    "eslint-plugin-unused-imports": "^4.1.4",
+    "globals": "^16.0.0",
+    "knip": "^6.21.0",
+    "madge": "^8.0.0",
+    "prettier": "^3.5.3",
+    "rimraf": "^6.0.1",
+    "semver": "^7.7.1",
+    "typescript": "^5.7.3",
+    "vite": "^7.3.5",
+    "vitest": "^4.1.11"
+  },
   "dependencies": {
     "@redux-devtools/extension": "^3.3.0",
     "@reduxjs/toolkit": "^1.6.2",