@zeniai/client-epic-state 5.2.56 → 5.2.57-beta0ND

package/lib/view/expenseAutomationView/selectors/jeSchedulesViewSelector.js

@@ -225,7 +225,7 @@ function getExpenseAutomationJESchedulesView(state) {
     const accruedSchedules = [];
     const oneTimeAccruals = [];
     const { accountState, accountListState, classState, classListState, expenseAutomationJESchedulesViewState, expenseAutomationViewState, monthEndCloseChecksState, } = state;
-    const { jeScheduleTransactionKeysByPeriodAndTab, jeScheduleAccruedKeysByPeriodAndTab, jeScheduleOneTimeAccrualKeysByPeriodAndTab, failedJeScheduleTransactionKeysByPeriodAndTab, jeScheduleLocalDataById, postStatusById, ignoreStatusById, revertStatusById, oneTimeAccrualActionStatusById, uiState, error, fetchState, refreshStatus, newSchedule, } = expenseAutomationJESchedulesViewState;
+    const { jeScheduleTransactionKeysByPeriodAndTab, jeScheduleAccruedKeysByPeriodAndTab, jeScheduleOneTimeAccrualKeysByPeriodAndTab, failedJePostings, jeScheduleLocalDataById, postStatusById, ignoreStatusById, revertStatusById, oneTimeAccrualActionStatusById, uiState, error, fetchState, refreshStatus, newSchedule, } = expenseAutomationJESchedulesViewState;
     const accountSettingsView = (0, jeAccountSettingsViewSelector_1.getJEAccountSettingsView)(state);
     const newScheduleView = newSchedule.selectedDetailScheduleType === 'fixed_assets' ||
         newSchedule.selectedDetailScheduleType === 'prepaid_expenses'
@@ -264,15 +264,11 @@ function getExpenseAutomationJESchedulesView(state) {
     const jeScheduleTransactionKeysForSelectedTab = selectedPeriodTabKey != null
         ? jeScheduleTransactionKeysByPeriodAndTab[selectedPeriodTabKey]
         : undefined;
-    const failedJeScheduleTransactionKeysForSelectedTab = selectedPeriodTabKey != null
-        ? failedJeScheduleTransactionKeysByPeriodAndTab[selectedPeriodTabKey]
-        : undefined;
     // Distinguishes "this tab has never been fetched for this period" from "fetched and genuinely
     // empty". Without it the page cannot tell a first visit from a real empty state, and renders an
     // empty table where it should render a skeleton.
     const hasLoadedForSelectedTab = jeScheduleTransactionKeysForSelectedTab != null;
     const jeScheduleTransactionKeys = jeScheduleTransactionKeysForSelectedTab ?? [];
-    const failedJeScheduleTransactionKeys = failedJeScheduleTransactionKeysForSelectedTab ?? [];
     const jeScheduleAccruedKeys = (selectedPeriodTabKey != null
         ? jeScheduleAccruedKeysByPeriodAndTab[selectedPeriodTabKey]
         : undefined) ?? [];
@@ -295,24 +291,57 @@ function getExpenseAutomationJESchedulesView(state) {
             accruedSchedules.push(accruedScheduleDetails);
         }
     });
-    failedJeScheduleTransactionKeys.forEach((jeScheduleKey) => {
-        const jeScheduleDetails = (0, jeSchedulesSelector_1.getJEScheduledTransactionByJEScheduleTransactionKey)(jeScheduleKey, state);
-        failedJeScheduledTransaction.push(jeScheduleDetails);
+    // Sourced from the tenant-wide bucket, not the per-period one: a failed posting belongs to no
+    // close month, and windowing it is what kept older failures off the only tab that can resolve
+    // them.
+    failedJePostings.jeScheduleTransactionKeys.forEach((jeScheduleKey) => {
+        // getJEScheduledTransactionByJEScheduleTransactionKey throws three different ways: it
+        // destructures the result of recordGet without a null check, and it raises explicitly for a
+        // missing vendor and for a missing base transaction. Catching rather than pre-checking each
+        // one keeps this correct if a fourth is added, and none of the three is recoverable here --
+        // the row cannot be drawn either way.
+        //
+        // This matters more for this bucket than anywhere else on the page. It is tenant-wide, so it
+        // names schedules the close-month list never loaded, and the group is defined by deleted
+        // vendors and deleted categories -- precisely the rows whose entities are most likely to be
+        // missing. Unguarded, one such key takes down the whole JE tab instead of dropping one row.
+        try {
+            failedJeScheduledTransaction.push((0, jeSchedulesSelector_1.getJEScheduledTransactionByJEScheduleTransactionKey)(jeScheduleKey, state));
+        }
+        catch {
+            // Intentionally swallowed: a failed posting we cannot resolve is one missing row, and the
+            // alternative is a blank page for every other row too.
+        }
     });
+    // What the endpoint last reported as failing. The entity store keeps every month a schedule
+    // has and an entry resolved by someone else keeps its old `error` array, so `error` alone would
+    // leave a Retry button on a posting that is no longer failing.
+    const failedScheduledJournalEntryIDs = new Set(failedJePostings.scheduledJournalEntryIDs);
     const { sortKey, sortOrder, selectedJETypeFilter } = uiState;
+    const matchesTypeFilter = (schedule) => selectedJETypeFilter == null ||
+        getJEScheduleRowType(schedule) === selectedJETypeFilter;
     const unsortedResolveSchedules = [];
     failedJeScheduledTransaction.forEach((schedule) => {
-        schedule.scheduledJournalEntry.forEach((journalEntry) => {
+        // Only the entries that actually carry an error. The schedule's entry array is shared state:
+        // opening a schedule's detail page or Quick View replaces it with every month the schedule
+        // has, posted ones included, so fanning out over all of them turned one failed posting into a
+        // row per month -- and a month that never failed has nothing to resolve, so it rendered with
+        // an empty action column.
+        //
+        // Intersected with the ids the endpoint actually returned, not just `error`: the entry array
+        // is a cache of every month, and an entry whose failure someone else resolved keeps its stale
+        // error array until something overwrites it. Only what the last fetch named is still failing.
+        schedule.scheduledJournalEntry
+            .filter((journalEntry) => journalEntry.error.length > 0 &&
+            failedScheduledJournalEntryIDs.has(journalEntry.scheduledJournalEntryID))
+            .forEach((journalEntry) => {
             unsortedResolveSchedules.push({
                 ...schedule,
                 scheduledJournalEntry: journalEntry,
             });
         });
     });
-    const resolveSchedules = sortJEScheduledTransactions(unsortedResolveSchedules, sortKey, sortOrder);
-    const validResolveForPending = unsortedResolveSchedules.filter((r) => jeScheduleLocalDataById[r.scheduledJournalEntry.scheduledJournalEntryID] != null);
-    const matchesTypeFilter = (schedule) => selectedJETypeFilter == null ||
-        getJEScheduleRowType(schedule) === selectedJETypeFilter;
+    const resolveSchedules = sortJEScheduledTransactions(unsortedResolveSchedules.filter(matchesTypeFilter), sortKey, sortOrder);
     const isCreatedStatus = (schedule) => {
         // An accrual is "created" once it is not review work: posted, reversing, reversed, or in a
         // transient posting claim.
@@ -330,7 +359,6 @@ function getExpenseAutomationJESchedulesView(state) {
     ];
     const pendingReviewSchedules = sortJEScheduledTransactions([
         ...allScheduleRows.filter((schedule) => isPendingReviewRow(schedule) && matchesTypeFilter(schedule)),
-        ...validResolveForPending,
     ], sortKey, sortOrder);
     const createdSchedules = sortJEScheduledTransactions(allScheduleRows.filter((schedule) => isCreatedStatus(schedule) && matchesTypeFilter(schedule)), sortKey, sortOrder);
     // KPI summary — derived from unfiltered schedules so counts are always accurate
@@ -449,6 +477,13 @@ function getExpenseAutomationJESchedulesView(state) {
         kpiSummary,
         pendingReviewSchedules,
         pendingReviewTotal,
+        failedPostings: resolveSchedules,
+        // Exposed so a consumer can tell "still loading" and "the lookup failed" from "nothing has
+        // failed". The bucket keeps its rows on failure precisely so an error can be shown beside
+        // them, which is only possible if the state travels with them.
+        failedPostingsFetchState: failedJePostings.fetchState,
+        // Deprecated alias of failedPostings. Still read by the section's footer-form effect and by
+        // app-ui analytics; remove once both are repointed.
         resolveSchedules: resolveSchedules,
         accountSettingsView,
         newScheduleView,

package/lib/view/expenseAutomationView/types/jeSchedulesViewState.d.ts

@@ -19,6 +19,7 @@ export type JESchedulePeriodTabKey = `${JEPageTab}_${MonthYearPeriodId}`;
 export declare const getJESchedulePeriodTabKey: (selectedPageTab: JEPageTab, monthYearPeriodId: MonthYearPeriodId) => JESchedulePeriodTabKey;
 export interface JESchedulesViewUIState {
     createdGroupCollapsed: boolean;
+    failedGroupCollapsed: boolean;
     pendingGroupCollapsed: boolean;
     scrollPosition: {
         scrollTop: number;
@@ -41,8 +42,23 @@ export interface JEScheduleLocalData {
     updatedClassId?: ID;
     updatedVendor?: VendorBase;
 }
+/**
+ * The Failed Postings bucket, and the only list on this page that is not scoped to a period.
+ *
+ * A failed posting is broken until someone resolves it, whatever month it belongs to, so windowing
+ * it the way the schedule lists are windowed is what hid a March failure from the September close.
+ * It therefore has no period-tab key, and its own fetch state rather than the slice's: the list is
+ * fetched separately from `/1.0/expenses_automation/failed_je_postings`, so a slow or failing
+ * lookup here must not blank the schedules table, or vice versa.
+ */
+export interface FailedJePostingsState {
+    fetchState: FetchStateAndError;
+    jeScheduleTransactionKeys: JEScheduleTransactionKey[];
+    scheduledJournalEntryIDs: ID[];
+}
 export interface JESchedulesViewState extends FetchedState {
     accountSettings: AccountSettingsState;
+    failedJePostings: FailedJePostingsState;
     failedJeScheduleTransactionKeysByPeriodAndTab: Record<JESchedulePeriodTabKey, JEScheduleTransactionKey[]>;
     ignoreStatusById: Record<JEScheduleTransactionKey, FetchStateAndError>;
     jeScheduleAccruedKeysByPeriodAndTab: Record<JESchedulePeriodTabKey, JEScheduleKey[]>;

package/lib/view/recommendation/recommendationReducer.d.ts

@@ -58,6 +58,10 @@ export declare const fetchEntityRecommendationsByTransactionId: import("@reduxjs
 }, "recommendation/updateRecommendationForEntityFailure">, indicateReadyToInitializeRecommendation: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[entityIdOrName: string, entityType: EntityType], {
     entityIdOrName: string;
     entityType: EntityType;
-}, "recommendation/indicateReadyToInitializeRecommendation", never, never>, submitRecommendationFeedback: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[args: SubmitRecommendationFeedbackPayload], SubmitRecommendationFeedbackPayload, "recommendation/submitRecommendationFeedback", never, never>;
+}, "recommendation/indicateReadyToInitializeRecommendation", never, never>, submitRecommendationFeedback: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[args: SubmitRecommendationFeedbackPayload], SubmitRecommendationFeedbackPayload, "recommendation/submitRecommendationFeedback", never, never>, submitRecommendationFeedbackCompleted: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[args: {
+    succeeded: boolean;
+}], {
+    succeeded: boolean;
+}, "recommendation/submitRecommendationFeedbackCompleted", never, never>;
 declare const _default: import("redux").Reducer<EntityRecommendationState>;
 export default _default;

package/lib/view/recommendation/recommendationReducer.js

@@ -1,11 +1,13 @@
 "use strict";
 var _a;
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.submitRecommendationFeedback = exports.indicateReadyToInitializeRecommendation = exports.updateRecommendationForEntityFailure = exports.updateRecommendationForEntity = exports.fetchRecommendationByEntityId = exports.fetchRecommendationByEntityName = exports.fetchEntityRecommendationsForLineUpdate = exports.fetchEntityRecommendationsByTransactionId = exports.initialState = void 0;
+exports.submitRecommendationFeedbackCompleted = exports.submitRecommendationFeedback = exports.indicateReadyToInitializeRecommendation = exports.updateRecommendationForEntityFailure = exports.updateRecommendationForEntity = exports.fetchRecommendationByEntityId = exports.fetchRecommendationByEntityName = exports.fetchEntityRecommendationsForLineUpdate = exports.fetchEntityRecommendationsByTransactionId = exports.initialState = void 0;
 const toolkit_1 = require("@reduxjs/toolkit");
 const rootActions_1 = require("../../rootActions");
 const recommendationState_1 = require("./recommendationState");
 exports.initialState = {
+    didLastFeedbackSubmitSucceed: null,
+    isSubmittingFeedback: false,
     recommendationByEntity: {},
 };
 const recommendation = (0, toolkit_1.createSlice)({
@@ -135,13 +137,23 @@ const recommendation = (0, toolkit_1.createSlice)({
                 };
             },
         },
-        // Fire-and-forget human feedback on a recommendation (accept, ranked
-        // override or outside override). Handled by submitRecommendationFeedbackEpic
-        // which POSTs to the accounting recommendation-feedback endpoint. No state
-        // mutation: the categorization UX must not depend on the feedback round-trip.
+        // Human feedback on a recommendation (accept, ranked override or outside
+        // override). Handled by submitRecommendationFeedbackEpic, which POSTs to the
+        // accounting recommendation-feedback endpoint. The categorization itself
+        // never waits on this: only the feedback popup reads isSubmittingFeedback,
+        // so it can show a loader and report the real outcome.
         submitRecommendationFeedback: {
-            reducer() {
-                // Fire-and-forget: no state mutation; the epic performs the POST.
+            reducer(draft) {
+                draft.isSubmittingFeedback = true;
+            },
+            prepare(args) {
+                return { payload: args };
+            },
+        },
+        submitRecommendationFeedbackCompleted: {
+            reducer(draft, action) {
+                draft.isSubmittingFeedback = false;
+                draft.didLastFeedbackSubmitSucceed = action.payload.succeeded;
             },
             prepare(args) {
                 return { payload: args };
@@ -154,7 +166,7 @@ const recommendation = (0, toolkit_1.createSlice)({
         });
     },
 });
-_a = recommendation.actions, exports.fetchEntityRecommendationsByTransactionId = _a.fetchEntityRecommendationsByTransactionId, exports.fetchEntityRecommendationsForLineUpdate = _a.fetchEntityRecommendationsForLineUpdate, exports.fetchRecommendationByEntityName = _a.fetchRecommendationByEntityName, exports.fetchRecommendationByEntityId = _a.fetchRecommendationByEntityId, exports.updateRecommendationForEntity = _a.updateRecommendationForEntity, exports.updateRecommendationForEntityFailure = _a.updateRecommendationForEntityFailure, exports.indicateReadyToInitializeRecommendation = _a.indicateReadyToInitializeRecommendation, exports.submitRecommendationFeedback = _a.submitRecommendationFeedback;
+_a = recommendation.actions, exports.fetchEntityRecommendationsByTransactionId = _a.fetchEntityRecommendationsByTransactionId, exports.fetchEntityRecommendationsForLineUpdate = _a.fetchEntityRecommendationsForLineUpdate, exports.fetchRecommendationByEntityName = _a.fetchRecommendationByEntityName, exports.fetchRecommendationByEntityId = _a.fetchRecommendationByEntityId, exports.updateRecommendationForEntity = _a.updateRecommendationForEntity, exports.updateRecommendationForEntityFailure = _a.updateRecommendationForEntityFailure, exports.indicateReadyToInitializeRecommendation = _a.indicateReadyToInitializeRecommendation, exports.submitRecommendationFeedback = _a.submitRecommendationFeedback, exports.submitRecommendationFeedbackCompleted = _a.submitRecommendationFeedbackCompleted;
 exports.default = recommendation.reducer;
 const doUpdateRecommendationForEntity = (draft, entityId, entityType, payload) => {
     const key = (0, recommendationState_1.getEntityRecommendationKey)(entityType, entityId);

package/lib/view/recommendation/recommendationSelector.d.ts

@@ -8,3 +8,5 @@ export interface RecommendationByEntitySelectorView extends SelectorView {
     recommendations?: Recommendation[];
 }
 export declare const getRecommendationsForEntity: (state: RootState, entityId: string, entityType: EntityType) => RecommendationByEntitySelectorView;
+export declare const getIsSubmittingRecommendationFeedback: (state: RootState) => boolean;
+export declare const getDidLastRecommendationFeedbackSubmitSucceed: (state: RootState) => boolean | null;

package/lib/view/recommendation/recommendationSelector.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.getRecommendationsForEntity = void 0;
+exports.getDidLastRecommendationFeedbackSubmitSucceed = exports.getIsSubmittingRecommendationFeedback = exports.getRecommendationsForEntity = void 0;
 const recommendationState_1 = require("./recommendationState");
 const getRecommendationsForEntity = (state, entityId, entityType) => {
     const { entityRecommendationState } = state;
@@ -15,3 +15,7 @@ const getRecommendationsForEntity = (state, entityId, entityType) => {
     };
 };
 exports.getRecommendationsForEntity = getRecommendationsForEntity;
+const getIsSubmittingRecommendationFeedback = (state) => state.entityRecommendationState.isSubmittingFeedback;
+exports.getIsSubmittingRecommendationFeedback = getIsSubmittingRecommendationFeedback;
+const getDidLastRecommendationFeedbackSubmitSucceed = (state) => state.entityRecommendationState.didLastFeedbackSubmitSucceed;
+exports.getDidLastRecommendationFeedbackSubmitSucceed = getDidLastRecommendationFeedbackSubmitSucceed;

package/lib/view/recommendation/recommendationState.d.ts

@@ -8,5 +8,7 @@ export interface EntityRecommendationsStatus extends FetchedState {
 }
 export declare const initialEntityRecommendationState: EntityRecommendationsStatus;
 export interface EntityRecommendationState {
+    didLastFeedbackSubmitSucceed: boolean | null;
+    isSubmittingFeedback: boolean;
     recommendationByEntity: Record<EntityRecommendationKey, EntityRecommendationsStatus>;
 }

package/lib/view/recommendation/submitRecommendationFeedbackEpic.d.ts

@@ -2,6 +2,6 @@ import { ActionsObservable, StateObservable } from 'redux-observable';
 import { Observable } from 'rxjs';
 import { RootState } from '../../reducer';
 import { ZeniAPI } from '../../zeniAPI';
-import { submitRecommendationFeedback } from './recommendationReducer';
-export type ActionType = ReturnType<typeof submitRecommendationFeedback>;
+import { submitRecommendationFeedback, submitRecommendationFeedbackCompleted } from './recommendationReducer';
+export type ActionType = ReturnType<typeof submitRecommendationFeedback> | ReturnType<typeof submitRecommendationFeedbackCompleted>;
 export declare const submitRecommendationFeedbackEpic: (actions$: ActionsObservable<ActionType>, _state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => Observable<ActionType>;

package/lib/view/recommendation/submitRecommendationFeedbackEpic.js

@@ -36,21 +36,22 @@ const toRequestBody = (payload) => ({
     retracts_feedback_id: payload.retractsFeedbackId ?? null,
     features: payload.features ?? null,
 });
-// Fire-and-forget: the epic never re-emits an action. Feedback delivery is a
-// side-effect that must not disrupt the categorization UX, so both the
-// success and error paths complete silently (errors are logged for debugging).
+// Always reports completion so the feedback popup can show a loader and tell the
+// user what happened. The categorization itself still never waits on this: a
+// failure is surfaced in a toast rather than blocking or reverting the change.
 const submitRecommendationFeedbackEpic = (actions$, _state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(recommendationReducer_1.submitRecommendationFeedback.match), (0, operators_1.mergeMap)((action) => {
     const { transactionId } = action.payload;
     return zeniAPI
         .postAndGetJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/transactions/${transactionId}/recommendation-feedback`, toRequestBody(action.payload))
         .pipe((0, operators_1.mergeMap)((response) => {
-        if (!(0, responsePayload_1.isSuccessStatus)(response)) {
+        const succeeded = (0, responsePayload_1.isSuccessStatus)(response);
+        if (!succeeded) {
             console.error('submitRecommendationFeedbackEpic: recommendation feedback was not recorded', response.status);
         }
-        return rxjs_1.EMPTY;
+        return (0, rxjs_1.of)((0, recommendationReducer_1.submitRecommendationFeedbackCompleted)({ succeeded }));
     }), (0, operators_1.catchError)((error) => {
         console.error('submitRecommendationFeedbackEpic: failed to submit recommendation feedback', error);
-        return rxjs_1.EMPTY;
+        return (0, rxjs_1.of)((0, recommendationReducer_1.submitRecommendationFeedbackCompleted)({ succeeded: false }));
     }));
 }));
 exports.submitRecommendationFeedbackEpic = submitRecommendationFeedbackEpic;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.2.56",
+  "version": "5.2.57-beta0ND",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",