@zeniai/client-epic-state 5.2.56-betaRD1 → 5.2.57-beta0ND

package/lib/view/invoicing/invoicingDunningCaseListView/invoicingDunningCaseListViewReducer.d.ts

@@ -26,6 +26,6 @@ export declare const fetchInvoicingDunningCaseList: import("@reduxjs/toolkit").A
     ids: ID[];
     keepExistingListItems: boolean;
     nextCursor: string | null;
-}, "invoicingDunningCaseListView/updateInvoicingDunningCaseList">, updateInvoicingDunningCaseListFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<ZeniAPIStatus<Record<string, unknown>>, "invoicingDunningCaseListView/updateInvoicingDunningCaseListFailure">, fetchInvoicingDunningCaseCounts: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"invoicingDunningCaseListView/fetchInvoicingDunningCaseCounts">, updateInvoicingDunningCaseCounts: import("@reduxjs/toolkit").ActionCreatorWithPayload<InvoicingListCounts, "invoicingDunningCaseListView/updateInvoicingDunningCaseCounts">, updateInvoicingDunningCaseCountsFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<ZeniAPIStatus<Record<string, unknown>>, "invoicingDunningCaseListView/updateInvoicingDunningCaseCountsFailure">, updateInvoicingDunningCaseFilters: import("@reduxjs/toolkit").ActionCreatorWithPayload<InvoicingDunningCaseFilters, "invoicingDunningCaseListView/updateInvoicingDunningCaseFilters">, setInvoicingDunningCaseActiveTab: import("@reduxjs/toolkit").ActionCreatorWithPayload<"Retrying" | "Scheduled" | "Manual Review" | "Resolved" | "Cancelled" | "Paused" | "all", "invoicingDunningCaseListView/setInvoicingDunningCaseActiveTab">;
+}, "invoicingDunningCaseListView/updateInvoicingDunningCaseList">, updateInvoicingDunningCaseListFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<ZeniAPIStatus<Record<string, unknown>>, "invoicingDunningCaseListView/updateInvoicingDunningCaseListFailure">, fetchInvoicingDunningCaseCounts: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"invoicingDunningCaseListView/fetchInvoicingDunningCaseCounts">, updateInvoicingDunningCaseCounts: import("@reduxjs/toolkit").ActionCreatorWithPayload<InvoicingListCounts, "invoicingDunningCaseListView/updateInvoicingDunningCaseCounts">, updateInvoicingDunningCaseCountsFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<ZeniAPIStatus<Record<string, unknown>>, "invoicingDunningCaseListView/updateInvoicingDunningCaseCountsFailure">, updateInvoicingDunningCaseFilters: import("@reduxjs/toolkit").ActionCreatorWithPayload<InvoicingDunningCaseFilters, "invoicingDunningCaseListView/updateInvoicingDunningCaseFilters">, setInvoicingDunningCaseActiveTab: import("@reduxjs/toolkit").ActionCreatorWithPayload<"cancelled" | "scheduled" | "retrying" | "manual_review" | "resolved" | "paused" | "all", "invoicingDunningCaseListView/setInvoicingDunningCaseActiveTab">;
 declare const _default: import("redux").Reducer<InvoicingDunningCaseListViewState>;
 export default _default;

package/lib/view/invoicing/invoicingDunningCaseListView/invoicingDunningCaseListViewState.d.ts

@@ -19,8 +19,8 @@ export interface InvoicingDunningCaseColumnConfig {
     sortable: boolean;
 }
 export declare const INVOICING_DUNNING_CASE_COLUMNS: InvoicingDunningCaseColumnConfig[];
-export declare const ALL_INVOICING_DUNNING_CASE_TAB_IDS: readonly ["all", "Retrying", "Scheduled", "Manual Review", "Paused", "Resolved", "Cancelled"];
-export declare const toInvoicingDunningCaseTabId: (v: string) => "Retrying" | "Scheduled" | "Manual Review" | "Resolved" | "Cancelled" | "Paused" | "all";
+export declare const ALL_INVOICING_DUNNING_CASE_TAB_IDS: readonly ["all", "retrying", "scheduled", "manual_review", "paused", "resolved", "cancelled"];
+export declare const toInvoicingDunningCaseTabId: (v: string) => "cancelled" | "scheduled" | "retrying" | "manual_review" | "resolved" | "paused" | "all";
 export type InvoicingDunningCaseTabId = ReturnType<typeof toInvoicingDunningCaseTabId>;
 export interface InvoicingDunningCaseListViewState extends FetchedState {
     /** Selected status tab (CES-owned so it persists across page revisits). */

package/lib/view/invoicing/invoicingDunningCaseListView/invoicingDunningCaseListViewState.js

@@ -26,12 +26,12 @@ exports.INVOICING_DUNNING_CASE_COLUMNS = [
 ];
 exports.ALL_INVOICING_DUNNING_CASE_TAB_IDS = [
     'all',
-    'Retrying',
-    'Scheduled',
-    'Manual Review',
-    'Paused',
-    'Resolved',
-    'Cancelled',
+    'retrying',
+    'scheduled',
+    'manual_review',
+    'paused',
+    'resolved',
+    'cancelled',
 ];
 const toInvoicingDunningCaseTabId = (v) => (0, stringToUnion_1.stringToUnion)(v, exports.ALL_INVOICING_DUNNING_CASE_TAB_IDS);
 exports.toInvoicingDunningCaseTabId = toInvoicingDunningCaseTabId;

package/lib/view/invoicing/invoicingSubscriptionListView/invoicingSubscriptionListViewReducer.d.ts

@@ -27,7 +27,7 @@ export declare const fetchInvoicingSubscriptionList: import("@reduxjs/toolkit").
     ids: ID[];
     keepExistingListItems: boolean;
     nextCursor: string | null;
-}, "invoicingSubscriptionListView/updateInvoicingSubscriptionList">, updateInvoicingSubscriptionListFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<ZeniAPIStatus<Record<string, unknown>>, "invoicingSubscriptionListView/updateInvoicingSubscriptionListFailure">, fetchInvoicingSubscriptionCounts: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"invoicingSubscriptionListView/fetchInvoicingSubscriptionCounts">, updateInvoicingSubscriptionCounts: import("@reduxjs/toolkit").ActionCreatorWithPayload<InvoicingListCounts, "invoicingSubscriptionListView/updateInvoicingSubscriptionCounts">, updateInvoicingSubscriptionCountsFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<ZeniAPIStatus<Record<string, unknown>>, "invoicingSubscriptionListView/updateInvoicingSubscriptionCountsFailure">, updateInvoicingSubscriptionFilters: import("@reduxjs/toolkit").ActionCreatorWithPayload<InvoicingSubscriptionFilters, "invoicingSubscriptionListView/updateInvoicingSubscriptionFilters">, setInvoicingSubscriptionActiveTab: import("@reduxjs/toolkit").ActionCreatorWithPayload<"active" | "cancelled" | "future" | "in_trial" | "non_renewing" | "paused" | "all", "invoicingSubscriptionListView/setInvoicingSubscriptionActiveTab">, addInvoicingSubscriptionToList: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
+}, "invoicingSubscriptionListView/updateInvoicingSubscriptionList">, updateInvoicingSubscriptionListFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<ZeniAPIStatus<Record<string, unknown>>, "invoicingSubscriptionListView/updateInvoicingSubscriptionListFailure">, fetchInvoicingSubscriptionCounts: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"invoicingSubscriptionListView/fetchInvoicingSubscriptionCounts">, updateInvoicingSubscriptionCounts: import("@reduxjs/toolkit").ActionCreatorWithPayload<InvoicingListCounts, "invoicingSubscriptionListView/updateInvoicingSubscriptionCounts">, updateInvoicingSubscriptionCountsFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<ZeniAPIStatus<Record<string, unknown>>, "invoicingSubscriptionListView/updateInvoicingSubscriptionCountsFailure">, updateInvoicingSubscriptionFilters: import("@reduxjs/toolkit").ActionCreatorWithPayload<InvoicingSubscriptionFilters, "invoicingSubscriptionListView/updateInvoicingSubscriptionFilters">, setInvoicingSubscriptionActiveTab: import("@reduxjs/toolkit").ActionCreatorWithPayload<"active" | "cancelled" | "future" | "paused" | "in_trial" | "non_renewing" | "all", "invoicingSubscriptionListView/setInvoicingSubscriptionActiveTab">, addInvoicingSubscriptionToList: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
     id: ID;
     status?: InvoicingSubscriptionStatus;
 }, "invoicingSubscriptionListView/addInvoicingSubscriptionToList">;

package/lib/view/invoicing/invoicingSubscriptionListView/invoicingSubscriptionListViewState.d.ts

@@ -23,7 +23,7 @@ export interface InvoicingSubscriptionColumnConfig {
 }
 export declare const INVOICING_SUBSCRIPTION_COLUMNS: InvoicingSubscriptionColumnConfig[];
 export declare const ALL_INVOICING_SUBSCRIPTION_TAB_IDS: readonly ["all", "active", "in_trial", "future", "non_renewing", "paused", "cancelled"];
-export declare const toInvoicingSubscriptionTabId: (v: string) => "active" | "cancelled" | "future" | "in_trial" | "non_renewing" | "paused" | "all";
+export declare const toInvoicingSubscriptionTabId: (v: string) => "active" | "cancelled" | "future" | "paused" | "in_trial" | "non_renewing" | "all";
 export type InvoicingSubscriptionTabId = ReturnType<typeof toInvoicingSubscriptionTabId>;
 export interface InvoicingSubscriptionListViewState extends FetchedState {
     /** Selected status tab (CES-owned so it persists across page revisits). */

package/lib/view/recommendation/recommendationReducer.d.ts

@@ -58,6 +58,10 @@ export declare const fetchEntityRecommendationsByTransactionId: import("@reduxjs
 }, "recommendation/updateRecommendationForEntityFailure">, indicateReadyToInitializeRecommendation: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[entityIdOrName: string, entityType: EntityType], {
     entityIdOrName: string;
     entityType: EntityType;
-}, "recommendation/indicateReadyToInitializeRecommendation", never, never>, submitRecommendationFeedback: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[args: SubmitRecommendationFeedbackPayload], SubmitRecommendationFeedbackPayload, "recommendation/submitRecommendationFeedback", never, never>;
+}, "recommendation/indicateReadyToInitializeRecommendation", never, never>, submitRecommendationFeedback: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[args: SubmitRecommendationFeedbackPayload], SubmitRecommendationFeedbackPayload, "recommendation/submitRecommendationFeedback", never, never>, submitRecommendationFeedbackCompleted: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[args: {
+    succeeded: boolean;
+}], {
+    succeeded: boolean;
+}, "recommendation/submitRecommendationFeedbackCompleted", never, never>;
 declare const _default: import("redux").Reducer<EntityRecommendationState>;
 export default _default;

package/lib/view/recommendation/recommendationReducer.js

@@ -1,11 +1,13 @@
 "use strict";
 var _a;
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.submitRecommendationFeedback = exports.indicateReadyToInitializeRecommendation = exports.updateRecommendationForEntityFailure = exports.updateRecommendationForEntity = exports.fetchRecommendationByEntityId = exports.fetchRecommendationByEntityName = exports.fetchEntityRecommendationsForLineUpdate = exports.fetchEntityRecommendationsByTransactionId = exports.initialState = void 0;
+exports.submitRecommendationFeedbackCompleted = exports.submitRecommendationFeedback = exports.indicateReadyToInitializeRecommendation = exports.updateRecommendationForEntityFailure = exports.updateRecommendationForEntity = exports.fetchRecommendationByEntityId = exports.fetchRecommendationByEntityName = exports.fetchEntityRecommendationsForLineUpdate = exports.fetchEntityRecommendationsByTransactionId = exports.initialState = void 0;
 const toolkit_1 = require("@reduxjs/toolkit");
 const rootActions_1 = require("../../rootActions");
 const recommendationState_1 = require("./recommendationState");
 exports.initialState = {
+    didLastFeedbackSubmitSucceed: null,
+    isSubmittingFeedback: false,
     recommendationByEntity: {},
 };
 const recommendation = (0, toolkit_1.createSlice)({
@@ -135,13 +137,23 @@ const recommendation = (0, toolkit_1.createSlice)({
                 };
             },
         },
-        // Fire-and-forget human feedback on a recommendation (accept, ranked
-        // override or outside override). Handled by submitRecommendationFeedbackEpic
-        // which POSTs to the accounting recommendation-feedback endpoint. No state
-        // mutation: the categorization UX must not depend on the feedback round-trip.
+        // Human feedback on a recommendation (accept, ranked override or outside
+        // override). Handled by submitRecommendationFeedbackEpic, which POSTs to the
+        // accounting recommendation-feedback endpoint. The categorization itself
+        // never waits on this: only the feedback popup reads isSubmittingFeedback,
+        // so it can show a loader and report the real outcome.
         submitRecommendationFeedback: {
-            reducer() {
-                // Fire-and-forget: no state mutation; the epic performs the POST.
+            reducer(draft) {
+                draft.isSubmittingFeedback = true;
+            },
+            prepare(args) {
+                return { payload: args };
+            },
+        },
+        submitRecommendationFeedbackCompleted: {
+            reducer(draft, action) {
+                draft.isSubmittingFeedback = false;
+                draft.didLastFeedbackSubmitSucceed = action.payload.succeeded;
             },
             prepare(args) {
                 return { payload: args };
@@ -154,7 +166,7 @@ const recommendation = (0, toolkit_1.createSlice)({
         });
     },
 });
-_a = recommendation.actions, exports.fetchEntityRecommendationsByTransactionId = _a.fetchEntityRecommendationsByTransactionId, exports.fetchEntityRecommendationsForLineUpdate = _a.fetchEntityRecommendationsForLineUpdate, exports.fetchRecommendationByEntityName = _a.fetchRecommendationByEntityName, exports.fetchRecommendationByEntityId = _a.fetchRecommendationByEntityId, exports.updateRecommendationForEntity = _a.updateRecommendationForEntity, exports.updateRecommendationForEntityFailure = _a.updateRecommendationForEntityFailure, exports.indicateReadyToInitializeRecommendation = _a.indicateReadyToInitializeRecommendation, exports.submitRecommendationFeedback = _a.submitRecommendationFeedback;
+_a = recommendation.actions, exports.fetchEntityRecommendationsByTransactionId = _a.fetchEntityRecommendationsByTransactionId, exports.fetchEntityRecommendationsForLineUpdate = _a.fetchEntityRecommendationsForLineUpdate, exports.fetchRecommendationByEntityName = _a.fetchRecommendationByEntityName, exports.fetchRecommendationByEntityId = _a.fetchRecommendationByEntityId, exports.updateRecommendationForEntity = _a.updateRecommendationForEntity, exports.updateRecommendationForEntityFailure = _a.updateRecommendationForEntityFailure, exports.indicateReadyToInitializeRecommendation = _a.indicateReadyToInitializeRecommendation, exports.submitRecommendationFeedback = _a.submitRecommendationFeedback, exports.submitRecommendationFeedbackCompleted = _a.submitRecommendationFeedbackCompleted;
 exports.default = recommendation.reducer;
 const doUpdateRecommendationForEntity = (draft, entityId, entityType, payload) => {
     const key = (0, recommendationState_1.getEntityRecommendationKey)(entityType, entityId);

package/lib/view/recommendation/recommendationSelector.d.ts

@@ -8,3 +8,5 @@ export interface RecommendationByEntitySelectorView extends SelectorView {
     recommendations?: Recommendation[];
 }
 export declare const getRecommendationsForEntity: (state: RootState, entityId: string, entityType: EntityType) => RecommendationByEntitySelectorView;
+export declare const getIsSubmittingRecommendationFeedback: (state: RootState) => boolean;
+export declare const getDidLastRecommendationFeedbackSubmitSucceed: (state: RootState) => boolean | null;

package/lib/view/recommendation/recommendationSelector.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.getRecommendationsForEntity = void 0;
+exports.getDidLastRecommendationFeedbackSubmitSucceed = exports.getIsSubmittingRecommendationFeedback = exports.getRecommendationsForEntity = void 0;
 const recommendationState_1 = require("./recommendationState");
 const getRecommendationsForEntity = (state, entityId, entityType) => {
     const { entityRecommendationState } = state;
@@ -15,3 +15,7 @@ const getRecommendationsForEntity = (state, entityId, entityType) => {
     };
 };
 exports.getRecommendationsForEntity = getRecommendationsForEntity;
+const getIsSubmittingRecommendationFeedback = (state) => state.entityRecommendationState.isSubmittingFeedback;
+exports.getIsSubmittingRecommendationFeedback = getIsSubmittingRecommendationFeedback;
+const getDidLastRecommendationFeedbackSubmitSucceed = (state) => state.entityRecommendationState.didLastFeedbackSubmitSucceed;
+exports.getDidLastRecommendationFeedbackSubmitSucceed = getDidLastRecommendationFeedbackSubmitSucceed;

package/lib/view/recommendation/recommendationState.d.ts

@@ -8,5 +8,7 @@ export interface EntityRecommendationsStatus extends FetchedState {
 }
 export declare const initialEntityRecommendationState: EntityRecommendationsStatus;
 export interface EntityRecommendationState {
+    didLastFeedbackSubmitSucceed: boolean | null;
+    isSubmittingFeedback: boolean;
     recommendationByEntity: Record<EntityRecommendationKey, EntityRecommendationsStatus>;
 }

package/lib/view/recommendation/submitRecommendationFeedbackEpic.d.ts

@@ -2,6 +2,6 @@ import { ActionsObservable, StateObservable } from 'redux-observable';
 import { Observable } from 'rxjs';
 import { RootState } from '../../reducer';
 import { ZeniAPI } from '../../zeniAPI';
-import { submitRecommendationFeedback } from './recommendationReducer';
-export type ActionType = ReturnType<typeof submitRecommendationFeedback>;
+import { submitRecommendationFeedback, submitRecommendationFeedbackCompleted } from './recommendationReducer';
+export type ActionType = ReturnType<typeof submitRecommendationFeedback> | ReturnType<typeof submitRecommendationFeedbackCompleted>;
 export declare const submitRecommendationFeedbackEpic: (actions$: ActionsObservable<ActionType>, _state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => Observable<ActionType>;

package/lib/view/recommendation/submitRecommendationFeedbackEpic.js

@@ -36,21 +36,22 @@ const toRequestBody = (payload) => ({
     retracts_feedback_id: payload.retractsFeedbackId ?? null,
     features: payload.features ?? null,
 });
-// Fire-and-forget: the epic never re-emits an action. Feedback delivery is a
-// side-effect that must not disrupt the categorization UX, so both the
-// success and error paths complete silently (errors are logged for debugging).
+// Always reports completion so the feedback popup can show a loader and tell the
+// user what happened. The categorization itself still never waits on this: a
+// failure is surfaced in a toast rather than blocking or reverting the change.
 const submitRecommendationFeedbackEpic = (actions$, _state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(recommendationReducer_1.submitRecommendationFeedback.match), (0, operators_1.mergeMap)((action) => {
     const { transactionId } = action.payload;
     return zeniAPI
         .postAndGetJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/transactions/${transactionId}/recommendation-feedback`, toRequestBody(action.payload))
         .pipe((0, operators_1.mergeMap)((response) => {
-        if (!(0, responsePayload_1.isSuccessStatus)(response)) {
+        const succeeded = (0, responsePayload_1.isSuccessStatus)(response);
+        if (!succeeded) {
             console.error('submitRecommendationFeedbackEpic: recommendation feedback was not recorded', response.status);
         }
-        return rxjs_1.EMPTY;
+        return (0, rxjs_1.of)((0, recommendationReducer_1.submitRecommendationFeedbackCompleted)({ succeeded }));
     }), (0, operators_1.catchError)((error) => {
         console.error('submitRecommendationFeedbackEpic: failed to submit recommendation feedback', error);
-        return rxjs_1.EMPTY;
+        return (0, rxjs_1.of)((0, recommendationReducer_1.submitRecommendationFeedbackCompleted)({ succeeded: false }));
     }));
 }));
 exports.submitRecommendationFeedbackEpic = submitRecommendationFeedbackEpic;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.2.56-betaRD1",
+  "version": "5.2.57-beta0ND",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",