@zeniai/client-epic-state 5.2.53-beta0ND → 5.2.54-betaRD1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (61) hide show
  1. package/lib/entity/jeSchedules/jeSchedulesReducer.d.ts +4 -1
  2. package/lib/entity/jeSchedules/jeSchedulesReducer.js +79 -5
  3. package/lib/entity/notificationRegistry/notificationRegistryReducer.d.ts +1 -2
  4. package/lib/entity/notificationRegistry/notificationRegistryReducer.js +9 -20
  5. package/lib/entity/notificationRegistry/notificationRegistrySelector.d.ts +1 -2
  6. package/lib/entity/notificationRegistry/notificationRegistrySelector.js +1 -7
  7. package/lib/entity/notificationRegistry/notificationRegistryState.d.ts +0 -5
  8. package/lib/entity/notificationRegistry/notificationRegistryState.js +1 -7
  9. package/lib/entity/sectionProjectView/sectionProjectViewReducer.js +1 -3
  10. package/lib/epic.d.ts +2 -1
  11. package/lib/epic.js +2 -0
  12. package/lib/esm/entity/jeSchedules/jeSchedulesReducer.js +78 -4
  13. package/lib/esm/entity/notificationRegistry/notificationRegistryReducer.js +9 -20
  14. package/lib/esm/entity/notificationRegistry/notificationRegistrySelector.js +0 -5
  15. package/lib/esm/entity/notificationRegistry/notificationRegistryState.js +0 -5
  16. package/lib/esm/entity/sectionProjectView/sectionProjectViewReducer.js +1 -3
  17. package/lib/esm/epic.js +2 -0
  18. package/lib/esm/index.js +7 -7
  19. package/lib/esm/view/aiCfoView/aiCfoViewReducer.js +2 -4
  20. package/lib/esm/view/aiCfoView/epics/fetchRoutineRunsEpic.js +1 -3
  21. package/lib/esm/view/expenseAutomationView/epics/jeSchedule/fetchFailedJePostingsEpic.js +39 -0
  22. package/lib/esm/view/expenseAutomationView/epics/jeSchedule/fetchJeSchedulePageEpic.js +14 -1
  23. package/lib/esm/view/expenseAutomationView/epics/jeSchedule/fetchJeSchedulesEpic.js +10 -13
  24. package/lib/esm/view/expenseAutomationView/epics/jeSchedule/initializeJeScheduleLocalDataEpic.js +38 -17
  25. package/lib/esm/view/expenseAutomationView/epics/jeSchedule/retryJeSchedulesEpic.js +17 -1
  26. package/lib/esm/view/expenseAutomationView/reducers/jeSchedulesViewReducer.js +74 -1
  27. package/lib/esm/view/expenseAutomationView/selectors/jeSchedulesViewSelector.js +49 -14
  28. package/lib/esm/view/notificationPreferencesView/epics/saveNotificationPreferencesEpic.js +7 -20
  29. package/lib/esm/view/notificationPreferencesView/notificationPreferencesViewReducer.js +17 -43
  30. package/lib/esm/view/notificationPreferencesView/notificationPreferencesViewSelector.js +4 -24
  31. package/lib/esm/view/settingsView/epic/fetchNotificationSettingsEpic.js +2 -12
  32. package/lib/index.d.ts +7 -7
  33. package/lib/index.js +50 -56
  34. package/lib/tsconfig.mocks.tsbuildinfo +1 -0
  35. package/lib/tsconfig.typecheck.tsbuildinfo +1 -0
  36. package/lib/view/aiCfoView/aiCfoViewReducer.js +2 -4
  37. package/lib/view/aiCfoView/aiCfoViewSelector.d.ts +1 -1
  38. package/lib/view/aiCfoView/epics/fetchRoutineRunsEpic.js +1 -3
  39. package/lib/view/expenseAutomationView/epics/jeSchedule/fetchFailedJePostingsEpic.d.ts +20 -0
  40. package/lib/view/expenseAutomationView/epics/jeSchedule/fetchFailedJePostingsEpic.js +43 -0
  41. package/lib/view/expenseAutomationView/epics/jeSchedule/fetchJeSchedulePageEpic.d.ts +2 -2
  42. package/lib/view/expenseAutomationView/epics/jeSchedule/fetchJeSchedulePageEpic.js +13 -0
  43. package/lib/view/expenseAutomationView/epics/jeSchedule/fetchJeSchedulesEpic.js +8 -11
  44. package/lib/view/expenseAutomationView/epics/jeSchedule/initializeJeScheduleLocalDataEpic.js +38 -17
  45. package/lib/view/expenseAutomationView/epics/jeSchedule/retryJeSchedulesEpic.d.ts +2 -2
  46. package/lib/view/expenseAutomationView/epics/jeSchedule/retryJeSchedulesEpic.js +17 -1
  47. package/lib/view/expenseAutomationView/payload/jeSchedulesPayload.d.ts +18 -0
  48. package/lib/view/expenseAutomationView/reducers/jeSchedulesViewReducer.d.ts +10 -3
  49. package/lib/view/expenseAutomationView/reducers/jeSchedulesViewReducer.js +76 -3
  50. package/lib/view/expenseAutomationView/selectorTypes/jeSchedulesSelectorTypes.d.ts +3 -0
  51. package/lib/view/expenseAutomationView/selectors/jeSchedulesViewSelector.js +49 -14
  52. package/lib/view/expenseAutomationView/types/jeSchedulesViewState.d.ts +16 -0
  53. package/lib/view/notificationPreferencesView/epics/saveNotificationPreferencesEpic.js +6 -19
  54. package/lib/view/notificationPreferencesView/notificationPreferencesViewReducer.d.ts +5 -8
  55. package/lib/view/notificationPreferencesView/notificationPreferencesViewReducer.js +17 -43
  56. package/lib/view/notificationPreferencesView/notificationPreferencesViewSelector.d.ts +0 -4
  57. package/lib/view/notificationPreferencesView/notificationPreferencesViewSelector.js +5 -30
  58. package/lib/view/notificationPreferencesView/notificationPreferencesViewState.d.ts +3 -4
  59. package/lib/view/settingsView/epic/fetchNotificationSettingsEpic.js +2 -12
  60. package/lib/view/settingsView/settingsViewPayload.d.ts +0 -2
  61. package/package.json +1 -1
@@ -1,7 +1,6 @@
1
1
  import { createSlice } from '@reduxjs/toolkit';
2
2
  import { clearAll } from '../../rootActions';
3
3
  import { mapNotificationRegistryPayloadToRegistry, } from './notificationRegistryPayload';
4
- import { NOTIFICATION_DOMAINS, } from './notificationRegistryState';
5
4
  export const initialState = { registryEpoch: 0 };
6
5
  const notificationRegistry = createSlice({
7
6
  name: 'notificationRegistry',
@@ -20,24 +19,16 @@ const notificationRegistry = createSlice({
20
19
  // `task_checklist_registry` CLEARS so tenant B doesn't inherit A's
21
20
  // Task Checklist section. Guarded by the epoch check above so a stale
22
21
  // absent-response can't wipe a fresh registry.
23
- const { registriesByDomain } = action.payload;
24
- // Absent `registriesByDomain` means a pre-domain caller: treat `registry`
25
- // as the task_checklist snapshot so their behaviour is unchanged.
26
- const snapshots = registriesByDomain ?? { task_checklist: action.payload.registry };
27
- draft.registryByDomain = {};
28
- for (const domain of NOTIFICATION_DOMAINS) {
29
- const payload = snapshots[domain];
30
- // Full-replace per domain, and an absent snapshot CLEARS that domain so
31
- // tenant B never inherits A's section. The gates are independent
32
- // server-side, so one domain clearing must not touch the other.
33
- if (payload != null) {
34
- draft.registryByDomain[domain] =
35
- mapNotificationRegistryPayloadToRegistry(payload);
36
- }
22
+ if (action.payload.registry == null) {
23
+ draft.registry = undefined;
24
+ return;
37
25
  }
38
- // Mirrored for consumers that predate the domain-keyed map.
39
- draft.registry = draft.registryByDomain.task_checklist;
40
- return;
26
+ // Full-replace contract: the registry payload is atomic — every fetch
27
+ // returns the complete group/event tree. If the backend ever ships a
28
+ // partial registry response, this write MUST switch to a merge (mirror
29
+ // the preferences slice's `mergePreferences`). Do not assume the
30
+ // current payload is partial without also updating this reducer.
31
+ draft.registry = mapNotificationRegistryPayloadToRegistry(action.payload.registry);
41
32
  },
42
33
  },
43
34
  extraReducers: (builder) => {
@@ -50,8 +41,6 @@ const notificationRegistry = createSlice({
50
41
  // — Cursor Bugbot 67d6918e. Returning `initialState` verbatim would
51
42
  // rewind the counter and let a stale in-flight GET restore A's
52
43
  // registry over B's.
53
- // Drops `registry` and `registryByDomain` together: a tenant switch must
54
- // not leave one domain's section behind.
55
44
  return { registryEpoch: draft.registryEpoch + 1 };
56
45
  });
57
46
  },
@@ -4,8 +4,3 @@
4
4
  // off for this tenant". Both currently surface as `undefined`. Distinguishing
5
5
  // them (e.g. an explicit `gate_off` signal from the server) is a follow-up.
6
6
  export const getNotificationRegistry = (slice) => slice.registry;
7
- // `undefined` conflates gate-off with no-preferences-yet; consumers hide the
8
- // section either way. Falls back to `registry` for task_checklist so state built
9
- // in the pre-domain shape (consumer mocks, older callers) still resolves.
10
- export const getNotificationRegistryForDomain = (slice, domain) => slice.registryByDomain?.[domain] ??
11
- (domain === 'task_checklist' ? slice.registry : undefined);
@@ -1,9 +1,4 @@
1
1
  import { stringToUnion } from '../../commonStateTypes/stringToUnion';
2
- // Wire vocabulary owned by the notifications service, not by this slice.
3
- export const NOTIFICATION_DOMAINS = ['task_checklist', 'commenting'];
4
- // Callers that predate the domain split mean Task Checklist.
5
- export const DEFAULT_NOTIFICATION_DOMAIN = 'task_checklist';
6
- export const toNotificationDomain = (raw) => stringToUnion(raw, NOTIFICATION_DOMAINS);
7
2
  export const NOTIFICATION_CHANNELS = ['email', 'slack', 'in_app'];
8
3
  export const toNotificationChannel = (raw) => stringToUnion(raw, NOTIFICATION_CHANNELS);
9
4
  export const NOTIFICATION_FREQUENCIES = ['instant', 'daily'];
@@ -32,9 +32,7 @@ const sectionProjectView = createSlice({
32
32
  Object.keys(sectionPayload.projects).forEach((projectId) => {
33
33
  const projectPayload = sectionPayload.projects[projectId];
34
34
  // A calculated section is grouped by project with no accounts under it.
35
- const projectAccounts = 'accounts' in projectPayload
36
- ? projectPayload.accounts
37
- : undefined;
35
+ const projectAccounts = 'accounts' in projectPayload ? projectPayload.accounts : undefined;
38
36
  const nestedAccountIds = projectAccounts != null
39
37
  ? getNestedAccountIDHierarchyForAccounts(Object.keys(projectAccounts), accountsMetadata)
40
38
  : [];
package/lib/esm/epic.js CHANGED
@@ -211,6 +211,7 @@ import { matchAndReverseAccrualsEpic, } from './view/expenseAutomationView/epics
211
211
  import { searchMatchAccrualsEpic, } from './view/expenseAutomationView/epics/jeSchedule/actualMatching/searchMatchAccrualsEpic';
212
212
  import { searchMatchTransactionsEpic, } from './view/expenseAutomationView/epics/jeSchedule/actualMatching/searchMatchTransactionsEpic';
213
213
  import { undoReversalAccrualsEpic, } from './view/expenseAutomationView/epics/jeSchedule/actualMatching/undoReversalAccrualsEpic';
214
+ import { fetchFailedJePostingsEpic as fetchExpenseAutomationFailedJePostingsEpic, } from './view/expenseAutomationView/epics/jeSchedule/fetchFailedJePostingsEpic';
214
215
  import { fetchJeSchedulesPageEpic as fetchExpenseAutomationJESchedulesPageEpic, } from './view/expenseAutomationView/epics/jeSchedule/fetchJeSchedulePageEpic';
215
216
  import { fetchJeSchedulesEpic as fetchExpenseAutomationJeSchedulesEpic, } from './view/expenseAutomationView/epics/jeSchedule/fetchJeSchedulesEpic';
216
217
  import { fetchOneTimeAccrualEpic, } from './view/expenseAutomationView/epics/jeSchedule/fetchOneTimeAccrualEpic';
@@ -1011,6 +1012,7 @@ const ALL_EPICS = [
1011
1012
  fetchExpenseAutomationActualMatchingEpic,
1012
1013
  fetchExpenseAutomationActualMatchingMatchEpic,
1013
1014
  fetchExpenseAutomationActualMatchingPageEpic,
1015
+ fetchExpenseAutomationFailedJePostingsEpic,
1014
1016
  fetchExpenseAutomationFluxAnalysisViewEpic,
1015
1017
  fetchExpenseAutomationInitializeTransactionCategorizationViewLocalDataEpic,
1016
1018
  fetchExpenseAutomationJeSchedulesEpic,
package/lib/esm/index.js CHANGED
@@ -64,8 +64,8 @@ import { ALL_JE_SCHEDULE_IGNORE_REASONS, ALL_JE_SCHEDULE_REVERT_REASONS, ALL_ONE
64
64
  import { ALL_MONTH_END_CLOSE_CHECKS_FREQUENCY, } from './entity/monthEndCloseChecks/monthEndCloseChecksState';
65
65
  import { updateCommentsNotifications, updateCommentsNotificationsStatuses, } from './entity/notification/notificationReducer';
66
66
  import { toNotificationModeStrict, } from './entity/notification/types/notificationTypes';
67
- import { getNotificationRegistry, getNotificationRegistryForDomain, } from './entity/notificationRegistry/notificationRegistrySelector';
68
- import { DEFAULT_NOTIFICATION_DOMAIN, NOTIFICATION_DOMAINS, toNotificationChannel, toNotificationDomain, toNotificationFrequency, } from './entity/notificationRegistry/notificationRegistryState';
67
+ import { getNotificationRegistry } from './entity/notificationRegistry/notificationRegistrySelector';
68
+ import { toNotificationChannel, toNotificationFrequency, } from './entity/notificationRegistry/notificationRegistryState';
69
69
  import { getPlaidPaymentAccounts } from './entity/paymentAccount/paymentAccountSelector';
70
70
  import { VERIFIED_PAYMENT_ACCOUNT_PROVIDER_VERIFICATION_STATUS, } from './entity/paymentAccount/paymentAccountState';
71
71
  import { closeSnackbar, openSnackbar } from './entity/snackbar/snackbarReducer';
@@ -188,9 +188,9 @@ import { toExpenseAutomationViewType, toExpenseAutomationViewTypeStrict, } from
188
188
  import { computeNewScheduleJeDetails } from './view/expenseAutomationView/helpers/newScheduleLocalDataHelper';
189
189
  import { isReviewTransactionBankTransferType, isReviewTransactionBillPaymentType, isReviewTransactionCreditCardCreditType, isReviewTransactionCreditCardPaymentType, isReviewTransactionDepositType, isReviewTransactionExpenseType, } from './view/expenseAutomationView/helpers/reconciliationHelpers';
190
190
  import { MAX_SELECTION_LIMIT, checkIfAllLineItemsAreCategoryClassFilled, getLineItemsByTransactionIdsFromLocalData, isAnyItemWithUncategorizedExpenseAccount, } from './view/expenseAutomationView/helpers/transactionCategorizationLocalDataHelper';
191
- import { ackCloseMatchAfterUndo, clearActualMatchingView as clearExpenseAutomationActualMatchingView, clearMatchNewModal, closeMatchNewModal, fetchActualMatching as fetchExpenseAutomationActualMatching, fetchActualMatchingMatch, fetchActualMatchingPage as fetchExpenseAutomationActualMatchingPage, matchAndReverseAccruals, openMatchNewModal, searchMatchAccruals, searchMatchTransactions, undoReversalAccruals, updateActualMatchingUIState as updateExpenseAutomationActualMatchingUIState, } from './view/expenseAutomationView/reducers/actualMatchingViewReducer';
191
+ import { ackCloseMatchAfterUndo, clearActualMatchingView as clearExpenseAutomationActualMatchingView, clearMatchNewModal, closeMatchNewModal, fetchActualMatchingMatch, fetchActualMatching as fetchExpenseAutomationActualMatching, fetchActualMatchingPage as fetchExpenseAutomationActualMatchingPage, matchAndReverseAccruals, openMatchNewModal, searchMatchAccruals, searchMatchTransactions, undoReversalAccruals, updateActualMatchingUIState as updateExpenseAutomationActualMatchingUIState, } from './view/expenseAutomationView/reducers/actualMatchingViewReducer';
192
192
  import { clearExpenseAutomationFluxAnalysisView, fetchFluxAnalysisView, reviewFluxAnalysisView, updateFluxAnalysisViewPageMetaData, updateFluxAnalysisViewUIState, updateOperatingExpensesIdsForReview, updateSelectedSectionIdsForReview, } from './view/expenseAutomationView/reducers/fluxAnalysisViewReducer';
193
- import { clearJeScheduleLocalData as clearExpenseAutomationJEScheduleLocalData, clearExpenseAutomationJESchedulesView, clearSearchTransactionsForNewSchedule as clearJeSearchTransactionsForNewSchedule, createOneTimeAccrual, createOneTimeAccrualFailure, createOneTimeAccrualSuccess, fetchJeSchedulesPage as fetchExpenseAutomationJESchedulesPage, fetchOneTimeAccrual, ignoreRecommendedJeSchedule as ignoreExpenseAutomationJESchedule, ignoreOneTimeAccrual, initializeAccountSettingsView as initializeJeAccountSettingsView, initializeNewSchedule as initializeJeNewSchedule, initializeJeScheduleLocalData, promoteOneTimeAccrual, removeJeOneTimeAccrualLocalData, removeJeScheduleTransactionKey, resetNewScheduleLocalData as resetJeNewScheduleLocalData, retryJeSchedule as retryExpenseAutomationJESchedule, revertJeSchedule, revertOneTimeAccrual, saveAccountSettings as saveJeAccountSettings, saveAccountSettingsLocalData as saveJeAccountSettingsLocalData, saveNewSchedule as saveJeNewSchedule, saveNewScheduleFailure as saveJeNewScheduleFailure, saveNewScheduleSuccess as saveJeNewScheduleSuccess, searchTransactionsForNewSchedule as searchJeTransactionsForNewSchedule, searchTransactionsForNewScheduleFailure as searchJeTransactionsForNewScheduleFailure, searchTransactionsForNewScheduleSuccess as searchJeTransactionsForNewScheduleSuccess, toggleJECreatedGroupCollapsed, toggleJEPendingGroupCollapsed, updateJESchedulesUIState as updateExpenseAutomationJESchedulesUIState, updateJEScheduleTypeFilter, updateNewScheduleLocalData as updateJeNewScheduleLocalData, updateJeOneTimeAccrualLocalData, updateJeScheduleLocalDataById, updateJeScheduleTransactionKeys, } from './view/expenseAutomationView/reducers/jeSchedulesViewReducer';
193
+ import { clearJeScheduleLocalData as clearExpenseAutomationJEScheduleLocalData, clearExpenseAutomationJESchedulesView, clearSearchTransactionsForNewSchedule as clearJeSearchTransactionsForNewSchedule, createOneTimeAccrual, createOneTimeAccrualFailure, createOneTimeAccrualSuccess, fetchJeSchedulesPage as fetchExpenseAutomationJESchedulesPage, fetchOneTimeAccrual, ignoreRecommendedJeSchedule as ignoreExpenseAutomationJESchedule, ignoreOneTimeAccrual, initializeAccountSettingsView as initializeJeAccountSettingsView, initializeNewSchedule as initializeJeNewSchedule, initializeJeScheduleLocalData, promoteOneTimeAccrual, removeJeOneTimeAccrualLocalData, removeJeScheduleTransactionKey, resetNewScheduleLocalData as resetJeNewScheduleLocalData, retryJeSchedule as retryExpenseAutomationJESchedule, revertJeSchedule, revertOneTimeAccrual, saveAccountSettings as saveJeAccountSettings, saveAccountSettingsLocalData as saveJeAccountSettingsLocalData, saveNewSchedule as saveJeNewSchedule, saveNewScheduleFailure as saveJeNewScheduleFailure, saveNewScheduleSuccess as saveJeNewScheduleSuccess, searchTransactionsForNewSchedule as searchJeTransactionsForNewSchedule, searchTransactionsForNewScheduleFailure as searchJeTransactionsForNewScheduleFailure, searchTransactionsForNewScheduleSuccess as searchJeTransactionsForNewScheduleSuccess, toggleJECreatedGroupCollapsed, toggleJEFailedGroupCollapsed, toggleJEPendingGroupCollapsed, updateJESchedulesUIState as updateExpenseAutomationJESchedulesUIState, updateJEScheduleTypeFilter, updateNewScheduleLocalData as updateJeNewScheduleLocalData, updateJeOneTimeAccrualLocalData, updateJeScheduleLocalDataById, updateJeScheduleTransactionKeys, } from './view/expenseAutomationView/reducers/jeSchedulesViewReducer';
194
194
  import { acknowledgeBulkUploadConfirmMatchComplete, bulkUploadAutomatchingTimedOut, bulkUploadReceipts, bulkUploadReceiptsFailure, bulkUploadReceiptsSuccess, clearBulkUpload, clearBulkUploadBatchDetailsForScopeChange, clearManualSearchResults, clearMissingReceiptsTabNavigation, confirmBulkUploadMatch, confirmBulkUploadMatchFailure, confirmBulkUploadMatchSuccess, fetchBulkUploadBatchDetails, fetchBulkUploadBatchDetailsFailure, fetchBulkUploadBatchDetailsSuccess, fetchBulkUploadBatches, fetchBulkUploadBatchesFailure, fetchBulkUploadBatchesSuccess, fetchCompletedTransactions, fetchCompletedTransactionsFailure, fetchCompletedTransactionsSuccess, fetchMissingReceipts as fetchExpenseAutomationMissingReceipts, fetchMoreBatchDetails, fetchMoreBatchDetailsComplete, fetchMoreBatchDetailsFailure, markBatchDetailRefreshAttempted, markMissingReceiptAsDone as markExpenseAutomationMissingReceiptAsDone, pusherBatchStatusUpdate, refreshBatchDetailsForBatchId, requestMissingReceiptsTabNavigation, restoreBulkUploadAutomatchingOnMount, restoreBulkUploadMatchingState, searchTransactionsForManualMatch, searchTransactionsForManualMatchFailure, searchTransactionsForManualMatchSuccess, setBulkUploadCompletedSubTab, setBulkUploadResultsTab, setBulkUploadSortConfig, setBulkUploadUploadedFileCount, storeBatchDetails, updateBulkUploadProgress, updateMissingReceiptUploadState as updateExpenseAutomationMissingReceiptUploadState, updateMissingReceiptsUIState as updateExpenseAutomationMissingReceiptsUIState, uploadMissingReceiptSuccess as uploadExpenseAutomationMissingReceiptSuccess, } from './view/expenseAutomationView/reducers/missingReceiptsViewReducer';
195
195
  import { clearStatementDateConflict, confirmStatementMapping, deleteAccountStatement, deleteCombinedStatement, excludeAccountFromReconciliation, fetchReconciliation as fetchReconciliationView, includeAccountInReconciliation, parseCombinedStatement, parseStatement, parseStatementFailure, parseStatementSuccess, reparseStatement, reparseStatementFailure, reparseStatementSuccess, resetReparseStatementStatus, saveReconciliationDetail as saveExpenseAutomationReconciliationDetail, saveReconciliationReview as saveExpenseAutomationReconciliationReview, setConnectionInProgressForAccount as setConnectionInProgressForAccountReconciliation, setStatementParseInProgress, setStatementProcessingDismissedToBackground, submitCombinedStatementUpdate, submitStatementUpdate, updateAccountReconciliationLocalData as updateExpenseAutomationAccountReconciliationLocalData, updateSelectedAccountId as updateExpenseAutomationAccountReconciliationSelectedAccountId, updateSelectedTab as updateExpenseAutomationAccountReconciliationSelectedTab, updateReconListScrollPosition as updateExpenseAutomationReconListScrollPosition, updateReviewTabSortState as updateExpenseAutomationReconReviewTabListSortState, updateReviewTabLocalData as updateExpenseAutomationReconReviewTabLocalData, updateReconcileTabListScrollState as updateExpenseAutomationReconcileTabListScrollState, updateReconcileTabListSortState as updateExpenseAutomationReconcileTabListSortState, updateReconcileTabLocalData as updateExpenseAutomationReconcileTabLocalData, updateSelectedDrawerAccountId as updateExpenseAutomationSelectedDrawerAccountId, updateNodeCollapseState, updateParsedStatementData, updateStatementProcessingBackgroundCompletedSteps, updateStatementProcessingFailed, updateStatementUpdateLocalData, updateStatementUploadChosen, uploadAccountStatement, } from './view/expenseAutomationView/reducers/reconciliationViewReducer';
196
196
  import { backgroundRefetchReviewTab, clearExpenseAutomationTransactionsView, fetchTransactionCategorization, fetchTransactionCategorizationFailure, fetchTransactionCategorizationView, initializeTransactionCategorizationViewLocalData, markCategoryClassRecommendationsFailureForCategorization, markTransactionAsNotMiscategorized, removeTransactionFromAllTabs, saveTransactionCategorization, saveTransactionCategorizationLocalData, setAllItemsToCategoryClassInLocalDataForCategorization, setEntityRecommendationForLineIdsForCategorization, syncTransactionCategorizationFromDetailSave, updateCurrentSelectedTransactionCategorizationTab, updateSelectedCheckboxTransactionIds, updateSelectedCustomerForTransaction, updateSelectedTransactionId, updateSelectedVendorForTransaction, updateTransactionCategorization, updateTransactionCategorizationCompletedSubTab, updateTransactionCategorizationSaveStatus, updateTransactionCategorizationUIState, updateTransactionCategorizationUploadReceiptState, updateTransactionFilters, updateTransactionGroup, uploadTransactionCategorizationReceiptSuccess, } from './view/expenseAutomationView/reducers/transactionsViewReducer';
@@ -236,7 +236,7 @@ import { toAverageMonthsCount } from './view/netBurnOrIncomeStoryCard/epic/updat
236
236
  import { fetchNetBurnOrIncomeStoryCard, updateNetBurnOrIncomeStoryCardSettings, } from './view/netBurnOrIncomeStoryCard/netBurnOrIncomeStoryCardReducer';
237
237
  import { getNetBurnOrIncomeStoryCardReport } from './view/netBurnOrIncomeStoryCard/netBurnOrIncomeStoryCardSelector';
238
238
  import { clearAllNotificationPreferencesView, clearNotificationPreferencesLocalOverrides, saveNotificationPreferences, setGroupChannelMaster, setGroupFrequency, toggleEventChannel, } from './view/notificationPreferencesView/notificationPreferencesViewReducer';
239
- import { getEffectiveNotificationPreferences, getEffectiveNotificationPreferencesForDomain, getNotificationLocalOverrides, getNotificationLocalOverridesForDomain, getNotificationPreferencesSaveState, hasUnsavedNotificationPreferences, hasUnsavedNotificationPreferencesForDomain, } from './view/notificationPreferencesView/notificationPreferencesViewSelector';
239
+ import { getEffectiveNotificationPreferences, getNotificationLocalOverrides, getNotificationPreferencesSaveState, hasUnsavedNotificationPreferences, } from './view/notificationPreferencesView/notificationPreferencesViewSelector';
240
240
  import { fetchNotificationUnreadCount, fetchNotificationUnreadCountSuccess, fetchNotificationView, updateNotificationViewAllNotificationsStatus, updateNotificationViewCurrentTabAndSubTab, updateNotificationViewNotificationStatus, updateNotificationViewSubTab, updateNotificationViewTabState, updateNotificationViewUIState, } from './view/notificationView/notificationViewReducer';
241
241
  import { getExternalNotificationsForSelectedSubTab, getNotificationView, getNotificationsForSelectedSubTab, } from './view/notificationView/notificationViewSelector';
242
242
  import { toNotificationSubTabTypeStrict, toNotificationTabTypeStrict, } from './view/notificationView/notificationViewState';
@@ -491,7 +491,7 @@ export { stringToUnion, stringToUnionStrict };
491
491
  export { fetchMonthEndCloseChecks, fetchMonthClosePerformanceTrend, getMonthEndCloseChecksViewByTenantId, ALL_MONTH_END_CLOSE_CHECKS_FREQUENCY, };
492
492
  export {
493
493
  // Bulk Upload Types
494
- BATCH_FILE_STATUSES, isUnmatchedTabFileStatus, DEFAULT_COMPLETED_SUB_TAB, DEFAULT_TRANSACTION_GROUP, TRANSACTION_GROUPS, toTransactionGroup, toBatchFileStatus, toBatchStatusValue, toBulkUploadPhase, toBulkUploadResultsTab, toBulkUploadSortKey, toCompletedSubTab, toMatchSource, toMissingReceiptsTab, actualMatchingTransactionLineKey, ALL_JE_PAGE_TABS, MATCH_ACCRUAL_SEARCH_LIMIT, MATCH_SEARCH_DEBOUNCE_MS, MATCH_TRANSACTION_SEARCH_PAGE_SIZE, toExpenseAutomationJEScheduleSortKey, toExpenseAutomationActualMatchingSortKey, toJEPageTab, toMatchAndReverseResultStatus, toUndoReversalResultStatus, toggleJECreatedGroupCollapsed, toggleJEPendingGroupCollapsed, updateJEScheduleTypeFilter, getExpenseAutomationView, toExpenseAutomationMissingReceiptsSortKey, toExpenseAutomationTransactionsTabKey, toExpenseAutomationViewType, toExpenseAutomationViewTypeStrict, uploadExpenseAutomationMissingReceiptSuccess, markExpenseAutomationMissingReceiptAsDone, fetchAllExpenseAutomationTabs, refreshExpenseAutomationCurrentTab, updateCurrentSelectedTransactionCategorizationTab, updateTransactionCategorizationCompletedSubTab, updateTransactionGroup, fetchExpenseAutomationMissingReceipts,
494
+ BATCH_FILE_STATUSES, isUnmatchedTabFileStatus, DEFAULT_COMPLETED_SUB_TAB, DEFAULT_TRANSACTION_GROUP, TRANSACTION_GROUPS, toTransactionGroup, toBatchFileStatus, toBatchStatusValue, toBulkUploadPhase, toBulkUploadResultsTab, toBulkUploadSortKey, toCompletedSubTab, toMatchSource, toMissingReceiptsTab, actualMatchingTransactionLineKey, ALL_JE_PAGE_TABS, MATCH_ACCRUAL_SEARCH_LIMIT, MATCH_SEARCH_DEBOUNCE_MS, MATCH_TRANSACTION_SEARCH_PAGE_SIZE, toExpenseAutomationJEScheduleSortKey, toExpenseAutomationActualMatchingSortKey, toJEPageTab, toMatchAndReverseResultStatus, toUndoReversalResultStatus, toggleJECreatedGroupCollapsed, toggleJEFailedGroupCollapsed, toggleJEPendingGroupCollapsed, updateJEScheduleTypeFilter, getExpenseAutomationView, toExpenseAutomationMissingReceiptsSortKey, toExpenseAutomationTransactionsTabKey, toExpenseAutomationViewType, toExpenseAutomationViewTypeStrict, uploadExpenseAutomationMissingReceiptSuccess, markExpenseAutomationMissingReceiptAsDone, fetchAllExpenseAutomationTabs, refreshExpenseAutomationCurrentTab, updateCurrentSelectedTransactionCategorizationTab, updateTransactionCategorizationCompletedSubTab, updateTransactionGroup, fetchExpenseAutomationMissingReceipts,
495
495
  // Bulk Upload Actions
496
496
  bulkUploadReceipts, bulkUploadAutomatchingTimedOut, bulkUploadReceiptsSuccess, bulkUploadReceiptsFailure, restoreBulkUploadAutomatchingOnMount, restoreBulkUploadMatchingState, updateBulkUploadProgress, pusherBatchStatusUpdate, requestMissingReceiptsTabNavigation, clearMissingReceiptsTabNavigation, fetchBulkUploadBatchDetails, fetchBulkUploadBatchDetailsSuccess, fetchBulkUploadBatchDetailsFailure, storeBatchDetails, fetchMoreBatchDetails, fetchMoreBatchDetailsComplete, fetchMoreBatchDetailsFailure, fetchBulkUploadBatches, fetchBulkUploadBatchesSuccess, fetchBulkUploadBatchesFailure, clearBulkUploadBatchDetailsForScopeChange, markBatchDetailRefreshAttempted, refreshBatchDetailsForBatchId, confirmBulkUploadMatch, confirmBulkUploadMatchSuccess, confirmBulkUploadMatchFailure, setBulkUploadResultsTab, setBulkUploadCompletedSubTab, setBulkUploadSortConfig, setBulkUploadUploadedFileCount, clearBulkUpload, searchTransactionsForManualMatch, searchTransactionsForManualMatchSuccess, searchTransactionsForManualMatchFailure, clearManualSearchResults, acknowledgeBulkUploadConfirmMatchComplete, fetchCompletedTransactions, fetchCompletedTransactionsSuccess, fetchCompletedTransactionsFailure, fetchFluxAnalysisView, clearExpenseAutomationFluxAnalysisView, updateOperatingExpensesIdsForReview as updateFluxOperatingExpensesIdsForReview, updateSelectedSectionIdsForReview as updateFluxAnalysisSelectedSectionIdsForReview, reviewFluxAnalysisView, updateExpenseAutomationMissingReceiptUploadState, updateExpenseAutomationMissingReceiptsUIState, updateTransactionCategorizationUploadReceiptState, uploadTransactionCategorizationReceiptSuccess, getExpenseAutomationFluxAnalysisView, updateCurrentSelectedView, updateCurrentSelectedPeriod, getExpenseAutomationTransactionView, getLastTransferEntryReplacement, updateFluxAnalysisViewUIState, updateFluxAnalysisViewPageMetaData, MAX_SELECTION_LIMIT, checkIfAllLineItemsAreCategoryClassFilled, getLineItemsByTransactionIdsFromLocalData, isAnyItemWithUncategorizedExpenseAccount, excludeAccountFromReconciliation, includeAccountInReconciliation, saveExpenseAutomationReconciliationDetail, updateExpenseAutomationReconcileTabListScrollState, updateExpenseAutomationReconReviewTabListSortState, updateExpenseAutomationReconcileTabListSortState, updateExpenseAutomationReconcileTabLocalData, updateExpenseAutomationAccountReconciliationSelectedTab, updateExpenseAutomationAccountReconciliationSelectedAccountId, getExpenseAutomationReconciliationView, getLedgerAccountIdsWithStatementOverrideWarning, getLedgerAccountsForCombinedStatementMapping, getReparseStatementStatusByAccountId, getUnavailableLedgerAccountIds, fetchReconciliationView, uploadAccountStatementIntoDocumentAI, updateExpenseAutomationReconListScrollPosition, setConnectionInProgressForAccountReconciliation, getAccountReconByAccountIdAndSelectedPeriod, toReconciliationTabsType, isAccountReconReport, updateExpenseAutomationReconReviewTabLocalData, updateExpenseAutomationSelectedDrawerAccountId, updateStatementProcessingFailed, saveExpenseAutomationReconciliationReview, updateExpenseAutomationAccountReconciliationLocalData, toReconciliationAccountSource, deleteAccountStatement, deleteCombinedStatement, uploadAccountStatement, parseCombinedStatement, parseStatement, parseStatementSuccess, parseStatementFailure, reparseStatement, reparseStatementSuccess, reparseStatementFailure, resetReparseStatementStatus, updateParsedStatementData, updateNodeCollapseState, updateStatementUploadChosen, submitCombinedStatementUpdate, submitStatementUpdate, clearStatementDateConflict, confirmStatementMapping, updateStatementUpdateLocalData, isReviewTransactionBankTransferType, isReviewTransactionBillPaymentType, isReviewTransactionCreditCardPaymentType, isReviewTransactionDepositType, isReviewTransactionExpenseType, isReviewTransactionCreditCardCreditType, setStatementParseInProgress, setStatementProcessingDismissedToBackground, updateStatementProcessingBackgroundCompletedSteps, };
497
497
  export { computeNewScheduleJeDetails, createOneTimeAccrual, createOneTimeAccrualFailure, createOneTimeAccrualSuccess, fetchOneTimeAccrual, getJeNewAccrualAccountsView, ignoreOneTimeAccrual, promoteOneTimeAccrual, revertJeSchedule, revertOneTimeAccrual, getJeNewScheduleSearchTransactionsView, getJeNewScheduleView, };
@@ -680,7 +680,7 @@ export { toNotificationModeStrict, updateCommentsNotifications, updateCommentsNo
680
680
  export { toNotificationSubTabTypeStrict, toNotificationTabTypeStrict, fetchNotificationView, fetchNotificationUnreadCount, fetchNotificationUnreadCountSuccess, updateNotificationViewAllNotificationsStatus, updateNotificationViewNotificationStatus, updateNotificationViewTabState, updateNotificationViewCurrentTabAndSubTab, updateNotificationViewSubTab, updateNotificationViewUIState, getNotificationView, getExternalNotificationsForSelectedSubTab, getNotificationsForSelectedSubTab, };
681
681
  export { fetchRegisteredInterests, notifyMeForFeature, getFeatureNotificationView, getRegisteredInterests, getRegisteredInterestsByFeature, isFeatureInterestRegistered, };
682
682
  export { pushToastNotification, getLastNotificationTime, getNotifications, };
683
- export { getEffectiveNotificationPreferences, getEffectiveNotificationPreferencesForDomain, getNotificationLocalOverrides, getNotificationLocalOverridesForDomain, getNotificationPreferencesSaveState, getNotificationRegistry, getNotificationRegistryForDomain, hasUnsavedNotificationPreferences, hasUnsavedNotificationPreferencesForDomain, NOTIFICATION_DOMAINS, DEFAULT_NOTIFICATION_DOMAIN, clearAllNotificationPreferencesView, clearNotificationPreferencesLocalOverrides, saveNotificationPreferences, setGroupChannelMaster, setGroupFrequency, toggleEventChannel, toNotificationChannel, toNotificationDomain, toNotificationFrequency, };
683
+ export { getEffectiveNotificationPreferences, getNotificationLocalOverrides, getNotificationPreferencesSaveState, getNotificationRegistry, hasUnsavedNotificationPreferences, clearAllNotificationPreferencesView, clearNotificationPreferencesLocalOverrides, saveNotificationPreferences, setGroupChannelMaster, setGroupFrequency, toggleEventChannel, toNotificationChannel, toNotificationFrequency, };
684
684
  export { getReferralListView, getInviteFormView, toReferralListViewSortKeyType, StatusTypes, AmountStatusTypes, DEFAULT_REFERRER_AMOUNT, fetchReferrals, sendReferralInvite, clearReferrals, saveReferralFormDataInLocalStore, updateReferralListSortUiState, resendReferralInvite, fetchRewardsPlan, getRewardsPlanCard, updateReferViewed, };
685
685
  export { ALL_WEEK_DAYS, SEMI_WEEKLY_REQUIRED_DAYS_COUNT, getMinAllowedEndDate, getRecurringEndDateFromCount, toDayOfWeek, toRecurringFrequency, };
686
686
  export { fetchCockpitContext, fetchCompanyTaskManagerView, fetchTaskManagerMetrics, getCompanyTaskManagerView, createTaskFromTaskGroupTemplate, };
@@ -835,8 +835,7 @@ const aiCfoView = createSlice({
835
835
  // The server has it. Nothing it sends from here on will contain this row,
836
836
  // so the tombstone has done its job and holding it any longer is what
837
837
  // makes a routine recreated under the same id invisible forever.
838
- draft.routines.deletedScheduleIds =
839
- draft.routines.deletedScheduleIds.filter((id) => id !== action.payload.scheduleId);
838
+ draft.routines.deletedScheduleIds = draft.routines.deletedScheduleIds.filter((id) => id !== action.payload.scheduleId);
840
839
  draft.routineMutation = {
841
840
  fetchState: 'Completed',
842
841
  error: undefined,
@@ -848,8 +847,7 @@ const aiCfoView = createSlice({
848
847
  // is what lets the refetch put the row back — leaving it hidden would
849
848
  // tell the user they had stopped something they had not, which is the
850
849
  // worst outcome this list can produce.
851
- draft.routines.deletedScheduleIds =
852
- draft.routines.deletedScheduleIds.filter((id) => id !== action.payload.scheduleId);
850
+ draft.routines.deletedScheduleIds = draft.routines.deletedScheduleIds.filter((id) => id !== action.payload.scheduleId);
853
851
  // Its own slice: the refetch that puts the row back would otherwise wipe
854
852
  // this error, leaving the row silently reappearing with no explanation.
855
853
  draft.routineMutation = {
@@ -27,9 +27,7 @@ export const fetchRoutineRunsEpic = (actions$, _state$, zeniAPI) => actions$.pip
27
27
  // Filtered, not trusted: one malformed row must not take the
28
28
  // whole history down, and a run without an id is not addressable
29
29
  // by anything the UI does with it.
30
- runs: (data.runs ?? [])
31
- .filter(isRoutineRunPayload)
32
- .map(toRoutineRun),
30
+ runs: (data.runs ?? []).filter(isRoutineRunPayload).map(toRoutineRun),
33
31
  scheduleId,
34
32
  sessionId: data.session_id ?? null,
35
33
  });
@@ -0,0 +1,39 @@
1
+ import { from, of } from 'rxjs';
2
+ import { catchError, filter, switchMap, takeUntil } from 'rxjs/operators';
3
+ import { updateJESchedules, updateJESchedulesDetails, } from '../../../../entity/jeSchedules/jeSchedulesReducer';
4
+ import { createZeniAPIStatus, isSuccessResponse, } from '../../../../responsePayload';
5
+ import { clearAll } from '../../../../rootActions';
6
+ import { fetchFailedJePostings, fetchFailedJePostingsFailure, fetchFailedJePostingsSuccess, initializeJeScheduleLocalData, } from '../../reducers/jeSchedulesViewReducer';
7
+ /**
8
+ * Fetches every currently-failing posting for the tenant, on its own endpoint and with no window.
9
+ *
10
+ * Sends no query at all. The endpoint takes an optional `expected_post_start_date` floor and the
11
+ * client deliberately omits it: a failure is outstanding work until someone resolves it, whatever
12
+ * month it belongs to, and windowing this list is exactly what kept older failures off the only
13
+ * screen that can resolve them.
14
+ *
15
+ * `switchMap`, not `mergeMap`: there is one list per tenant, so a second trigger supersedes the
16
+ * first rather than racing it.
17
+ */
18
+ export const fetchFailedJePostingsEpic = (actions$, _state$, zeniAPI) => actions$.pipe(filter(fetchFailedJePostings.match), switchMap(() => zeniAPI
19
+ .getJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/expenses_automation/failed_je_postings`)
20
+ .pipe(switchMap((response) => {
21
+ if (!isSuccessResponse(response) || response.data == null) {
22
+ return of(fetchFailedJePostingsFailure(response.status));
23
+ }
24
+ const { je_schedules: failedJeSchedules, scheduled_journal_entries: failedScheduledJournalEntries, } = response.data.failed_je_postings;
25
+ // Order matters and matches fetchJeSchedulesEpic: updateJESchedules fans out to the
26
+ // vendor / account / class / user entities, updateJESchedulesDetails then attaches the
27
+ // journal entries, and only then can initializeJeScheduleLocalData read them back.
28
+ return from([
29
+ updateJESchedules(failedJeSchedules),
30
+ updateJESchedulesDetails(failedJeSchedules, failedScheduledJournalEntries),
31
+ initializeJeScheduleLocalData(failedJeSchedules),
32
+ fetchFailedJePostingsSuccess(failedJeSchedules, failedScheduledJournalEntries),
33
+ ]);
34
+ }), catchError((error) => of(fetchFailedJePostingsFailure(createZeniAPIStatus('Unexpected Error', 'fetch failed JE postings REST API call errored out' +
35
+ JSON.stringify(error))))),
36
+ // A tenant switch clears the store while this request is still in flight. Without this
37
+ // the old tenant's rows are written back into the freshly cleared store and stay on
38
+ // screen under the new tenant until a manual refresh.
39
+ takeUntil(actions$.pipe(filter(clearAll.match))))));
@@ -3,7 +3,7 @@ import { filter, mergeMap } from 'rxjs/operators';
3
3
  import { fetchAccountList } from '../../../accountList/accountListReducer';
4
4
  import { getAccountsTypesForScheduleEpics } from '../../../scheduleView/scheduleListView/scheduleListHelper';
5
5
  import { fetchActualMatchingPage } from '../../reducers/actualMatchingViewReducer';
6
- import { fetchJeSchedules, fetchJeSchedulesPage, initializeAccountSettingsView, } from '../../reducers/jeSchedulesViewReducer';
6
+ import { fetchFailedJePostings, fetchJeSchedules, fetchJeSchedulesPage, initializeAccountSettingsView, } from '../../reducers/jeSchedulesViewReducer';
7
7
  export const fetchJeSchedulesPageEpic = (actions$, state$) => actions$.pipe(filter(fetchJeSchedulesPage.match), mergeMap((action) => {
8
8
  const jeSchedulePageActions = [];
9
9
  const { period, refreshViewInBackground } = action.payload;
@@ -24,6 +24,19 @@ export const fetchJeSchedulesPageEpic = (actions$, state$) => actions$.pipe(filt
24
24
  else {
25
25
  jeSchedulePageActions.push(fetchJeSchedules(period, refreshViewInBackground));
26
26
  }
27
+ // Failed postings are tenant-wide and carry no period, so a period change or a tab switch
28
+ // cannot invalidate them -- fetch once and let retry keep the list current from then on.
29
+ // Refreshes still refetch, silently, so a failure resolved elsewhere leaves eventually.
30
+ const { fetchState: failedPostingsFetchState } = state.expenseAutomationJESchedulesViewState.failedJePostings.fetchState;
31
+ const isBackgroundRefresh = refreshViewInBackground === true;
32
+ // 'Error' is retried, not just 'Not-Started'. A transient failure on first load would
33
+ // otherwise leave the bucket in Error, and a later period change -- which is not a
34
+ // background refresh -- would never ask again, so the tab stayed empty for the session.
35
+ if (failedPostingsFetchState === 'Not-Started' ||
36
+ failedPostingsFetchState === 'Error' ||
37
+ isBackgroundRefresh) {
38
+ jeSchedulePageActions.push(fetchFailedJePostings(isBackgroundRefresh));
39
+ }
27
40
  // Only on the first page load. Account settings cannot change from a tab switch or a
28
41
  // refresh, and re-initializing puts accountSettingsView back to 'In-Progress' -- which the
29
42
  // page reads as "still loading" and answers with a full skeleton over rows it already has.
@@ -2,13 +2,13 @@ import { from, of } from 'rxjs';
2
2
  import { catchError, filter, mergeMap, takeUntil } from 'rxjs/operators';
3
3
  import { DEFAULT_DATE_FORMAT } from '../../../../commonStateTypes/timePeriod';
4
4
  import { toAbsoluteDay, toString } from '../../../../commonStateTypes/timePeriod';
5
- import { updateAccruedJESchedules, updateAccruedJESchedulesDetails, updateJEOneTimeAccruals, updateJESchedules, updateJESchedulesDetails, } from '../../../../entity/jeSchedules/jeSchedulesReducer';
5
+ import { updateAccruedJESchedules, updateAccruedJESchedulesDetails, updateJEOneTimeAccruals, updateJESchedules, } from '../../../../entity/jeSchedules/jeSchedulesReducer';
6
6
  import { getCurrentTenant } from '../../../../entity/tenant/tenantSelector';
7
7
  import { createZeniAPIStatus, isSuccessResponse, } from '../../../../responsePayload';
8
8
  import { clearAll } from '../../../../rootActions';
9
9
  import { date } from '../../../../zeniDayJS';
10
10
  import { SERVICE_MONTH_FORMAT, } from '../../payload/jeSchedulesPayload';
11
- import { fetchJeSchedules, fetchJeSchedulesFailure, fetchJeSchedulesSuccess, initializeJeScheduleLocalData, } from '../../reducers/jeSchedulesViewReducer';
11
+ import { fetchJeSchedules, fetchJeSchedulesFailure, fetchJeSchedulesSuccess, } from '../../reducers/jeSchedulesViewReducer';
12
12
  /**
13
13
  * How far back to look for accrued schedules, matching the Vendors page
14
14
  * (`getDefaultSelectedTimeframeForScheduleType`, 'accrued_expenses'), which queries the same
@@ -81,8 +81,9 @@ export const fetchJeSchedulesEpic = (actions$, state$, zeniAPI) => actions$.pipe
81
81
  one_time_accrual_service_month_end: parsedEndDate.format(SERVICE_MONTH_FORMAT),
82
82
  // Existing lists what actually reached the books.
83
83
  one_time_accrual_statuses: ['posted'],
84
- // A failed posting from an earlier month still needs to surface here, so this list
85
- // is deliberately not windowed.
84
+ // Kept only so this tab's response shape is unchanged. Nothing reads the failed
85
+ // postings it returns any more -- they have their own endpoint and their own group
86
+ // on Review. Dropping the key from the response is a server-side follow-up.
86
87
  filter_failed_je_postings_by_date: false,
87
88
  }),
88
89
  };
@@ -93,12 +94,10 @@ export const fetchJeSchedulesEpic = (actions$, state$, zeniAPI) => actions$.pipe
93
94
  const updateActions = [];
94
95
  const accruedJeSchedules = response.data.accrued_je_schedules?.je_schedules ?? [];
95
96
  const oneTimeAccruals = response.data.one_time_accruals ?? [];
96
- updateActions.push(updateJESchedules([
97
- ...response.data.je_schedules,
98
- ...response.data.failed_je_postings.je_schedules,
99
- ]), updateJESchedulesDetails([...response.data.failed_je_postings.je_schedules], response.data.failed_je_postings.scheduled_journal_entries), initializeJeScheduleLocalData([
100
- ...response.data.failed_je_postings.je_schedules,
101
- ]));
97
+ // failed_je_postings is deliberately ignored. This endpoint windows it to the close
98
+ // month, which is what hid older failures; fetchFailedJePostingsEpic owns that list
99
+ // now and fetches it unwindowed.
100
+ updateActions.push(updateJESchedules([...response.data.je_schedules]));
102
101
  if (accruedJeSchedules.length > 0) {
103
102
  updateActions.push(updateAccruedJESchedules(accruedJeSchedules), updateAccruedJESchedulesDetails(accruedJeSchedules, response.data.accrued_je_schedules
104
103
  ?.scheduled_journal_entries));
@@ -111,9 +110,7 @@ export const fetchJeSchedulesEpic = (actions$, state$, zeniAPI) => actions$.pipe
111
110
  }
112
111
  updateActions.push(fetchJeSchedulesSuccess({
113
112
  jeSchedules: [...response.data.je_schedules],
114
- failedJeSchedules: [
115
- ...response.data.failed_je_postings.je_schedules,
116
- ],
113
+ failedJeSchedules: [],
117
114
  accruedJeSchedules: accruedJeSchedules,
118
115
  oneTimeAccruals: oneTimeAccruals,
119
116
  selectedPeriod: selectedPeriod,
@@ -1,28 +1,49 @@
1
1
  import { from } from 'rxjs';
2
2
  import { filter, mergeMap } from 'rxjs/operators';
3
- import { getJEScheduledTransactionByJEScheduleTransactionKey } from '../../../../entity/jeSchedules/jeSchedulesSelector';
4
3
  import { initializeJeScheduleLocalData, updateJeScheduleLocalDataById, } from '../../reducers/jeSchedulesViewReducer';
5
4
  export const initializeJeScheduleLocalDataEpic = (actions$, state$) => actions$.pipe(filter(initializeJeScheduleLocalData.match), mergeMap((action) => {
6
5
  const state = state$.value;
6
+ const { jeScheduleLocalDataById } = state.expenseAutomationJESchedulesViewState;
7
7
  const actions = [];
8
8
  const { jeScheduleTransactionKeys } = action.payload;
9
9
  jeScheduleTransactionKeys.forEach((jeScheduleTransactionKey) => {
10
- const jeScheduledTransaction = getJEScheduledTransactionByJEScheduleTransactionKey(jeScheduleTransactionKey, state);
11
- const initLocalData = {
12
- jeScheduleType: jeScheduledTransaction.jeScheduleType,
13
- jeScheduleID: jeScheduledTransaction.jeScheduleId,
14
- scheduledJournalEntryID: jeScheduledTransaction.scheduledJournalEntry[0]
15
- .scheduledJournalEntryID,
16
- updatedVendor: undefined,
17
- updatedCategoryId: undefined,
18
- updatedAccumulatedDepreciationCategoryID: undefined,
19
- updatedClassId: undefined,
20
- };
21
- actions.push(updateJeScheduleLocalDataById({
22
- localData: initLocalData,
23
- scheduledJournalEntryID: jeScheduledTransaction.scheduledJournalEntry[0]
24
- .scheduledJournalEntryID,
25
- }));
10
+ // Read straight off the entity rather than through
11
+ // getJEScheduledTransactionByJEScheduleTransactionKey. That selector resolves the vendor,
12
+ // the base transaction and the accounts, and THROWS when any of them is not in the store
13
+ // yet -- a missing-schedule guard does not cover it. This epic is a mergeMap with no
14
+ // catchError, so one throw takes its subscription down for the rest of the session and
15
+ // every later row silently renders without a Retry button. The three fields below are all
16
+ // it has ever needed.
17
+ const jeSchedule = state.jeSchedulesState.schedulesByTransactionKey[jeScheduleTransactionKey];
18
+ if (jeSchedule == null) {
19
+ return;
20
+ }
21
+ // Filtered on `error` because the entry array is shared state: a schedule whose detail
22
+ // page or Quick View has been opened holds every month it has, posted ones included.
23
+ jeSchedule.scheduledJournalEntry
24
+ .filter((journalEntry) => journalEntry.error.length > 0)
25
+ .forEach((journalEntry) => {
26
+ const { scheduledJournalEntryID } = journalEntry;
27
+ // Seeded once and never re-seeded. updateJeScheduleLocalDataById merges what it is
28
+ // given over what is there, and the seed carries explicit undefined edits -- so
29
+ // re-running it on a background refresh wiped a category the user had already picked
30
+ // and Retry went on to post the original broken one.
31
+ if (jeScheduleLocalDataById[scheduledJournalEntryID] != null) {
32
+ return;
33
+ }
34
+ actions.push(updateJeScheduleLocalDataById({
35
+ localData: {
36
+ jeScheduleType: jeSchedule.jeScheduleType,
37
+ jeScheduleID: jeSchedule.jeScheduleId,
38
+ scheduledJournalEntryID,
39
+ updatedVendor: undefined,
40
+ updatedCategoryId: undefined,
41
+ updatedAccumulatedDepreciationCategoryID: undefined,
42
+ updatedClassId: undefined,
43
+ },
44
+ scheduledJournalEntryID,
45
+ }));
46
+ });
26
47
  });
27
48
  return from(actions);
28
49
  }));
@@ -1,5 +1,6 @@
1
1
  import { from } from 'rxjs';
2
2
  import { catchError, filter, mergeMap, switchMap } from 'rxjs/operators';
3
+ import { removeScheduledJournalEntryFromJESchedule, } from '../../../../entity/jeSchedules/jeSchedulesReducer';
3
4
  import { openSnackbar } from '../../../../entity/snackbar/snackbarReducer';
4
5
  import { getCurrentTenant } from '../../../../entity/tenant/tenantSelector';
5
6
  import { createZeniAPIStatus, isSuccessStatus, } from '../../../../responsePayload';
@@ -22,9 +23,21 @@ export const retryJeScheduleEpic = (actions$, state$, zeniAPI) => actions$.pipe(
22
23
  .pipe(mergeMap((response) => {
23
24
  if (isSuccessStatus(response)) {
24
25
  const updateActions = [];
26
+ // Retire this entry, and the schedule itself only when this was its last failed
27
+ // one. A schedule that failed in several months is several rows sharing one
28
+ // schedule key, so dropping the key outright took the still-failing months off the
29
+ // list with it and nothing would have surfaced them again.
30
+ // Counts only entries that actually carry an error, for the same reason the selector
31
+ // and the local-data seed do: opening a schedule's detail or Quick View replaces
32
+ // this array with every month it has, posted ones included. Counting those left the
33
+ // schedule key in the bucket after its last real failure was resolved, so a later
34
+ // details write could surface a resolved row again with nothing to retry.
35
+ const stillFailingEntriesForSchedule = state.jeSchedulesState.schedulesByTransactionKey[jeScheduleTransactionKey]?.scheduledJournalEntry.filter((journalEntry) => journalEntry.error.length > 0) ?? [];
36
+ const wasLastFailedEntryForSchedule = stillFailingEntriesForSchedule.filter((journalEntry) => journalEntry.scheduledJournalEntryID !==
37
+ scheduledJournalEntryID).length === 0;
25
38
  updateActions.push(retryJeScheduleSuccess({
26
39
  scheduledJournalEntryID,
27
- }), removeFailedJeScheduleTransactionKey(jeScheduleTransactionKey, selectedPeriod), removeJeScheduleLocalDataById({ scheduledJournalEntryID }), // Important to remove localdata after success.
40
+ }), removeScheduledJournalEntryFromJESchedule(jeScheduleTransactionKey, scheduledJournalEntryID), removeJeScheduleLocalDataById({ scheduledJournalEntryID }), // Important to remove localdata after success.
28
41
  fetchMonthEndCloseChecks({
29
42
  tenantId: currentTenant.tenantId,
30
43
  period: selectedPeriod,
@@ -34,6 +47,9 @@ export const retryJeScheduleEpic = (actions$, state$, zeniAPI) => actions$.pipe(
34
47
  messageText: 'success',
35
48
  type: 'success',
36
49
  }));
50
+ if (wasLastFailedEntryForSchedule) {
51
+ updateActions.push(removeFailedJeScheduleTransactionKey(jeScheduleTransactionKey, selectedPeriod));
52
+ }
37
53
  return from(updateActions);
38
54
  }
39
55
  else {
@@ -62,6 +62,11 @@ export const initialState = {
62
62
  jeScheduleAccruedKeysByPeriodAndTab: {},
63
63
  jeScheduleOneTimeAccrualKeysByPeriodAndTab: {},
64
64
  failedJeScheduleTransactionKeysByPeriodAndTab: {},
65
+ failedJePostings: {
66
+ fetchState: { fetchState: 'Not-Started', error: undefined },
67
+ jeScheduleTransactionKeys: [],
68
+ scheduledJournalEntryIDs: [],
69
+ },
65
70
  postStatusById: {},
66
71
  ignoreStatusById: {},
67
72
  revertStatusById: {},
@@ -71,6 +76,9 @@ export const initialState = {
71
76
  oneTimeAccrualFetchStatusById: {},
72
77
  uiState: {
73
78
  createdGroupCollapsed: false,
79
+ // Expanded, like the other two. A failed posting is the only thing on this page that is
80
+ // actively wrong, so folding it away by default would hide the reason to open the tab.
81
+ failedGroupCollapsed: false,
74
82
  pendingGroupCollapsed: false,
75
83
  scrollPosition: { scrollTop: 0, scrollLeft: undefined },
76
84
  searchString: '',
@@ -142,6 +150,59 @@ const expenseAutomationJESchedulesView = createSlice({
142
150
  };
143
151
  },
144
152
  },
153
+ /**
154
+ * The Failed Postings list, fetched separately from the schedules it belongs to.
155
+ *
156
+ * No period and no tab in any of these three: the endpoint applies no date window, so there is
157
+ * one list per tenant and one slot to hold it. `refreshInBackground` keeps a silent refetch
158
+ * from dropping a skeleton over rows already on screen, the same way refreshStatus does for
159
+ * the schedules list.
160
+ */
161
+ fetchFailedJePostings: {
162
+ reducer(draft, action) {
163
+ if (!action.payload.refreshInBackground) {
164
+ draft.failedJePostings.fetchState = {
165
+ fetchState: 'In-Progress',
166
+ error: undefined,
167
+ };
168
+ }
169
+ },
170
+ prepare(refreshInBackground = false) {
171
+ return { payload: { refreshInBackground } };
172
+ },
173
+ },
174
+ fetchFailedJePostingsSuccess: {
175
+ reducer(draft, action) {
176
+ // Both lists are replaced, never merged: this response is the whole current answer to
177
+ // "what is failing right now", so an entry it no longer names has stopped failing --
178
+ // resolved by someone else, or posted since -- and must drop out of the group.
179
+ draft.failedJePostings = {
180
+ fetchState: { fetchState: 'Completed', error: undefined },
181
+ jeScheduleTransactionKeys: action.payload.failedJeSchedules.map((schedule) => getJEScheduleTransactionDetailKeyPayload(schedule.base_transaction)),
182
+ // `?? ''` mirrors toScheduledJournalEntryState, so an entry the server sent without an
183
+ // id lands on the same value on both sides and still matches itself.
184
+ scheduledJournalEntryIDs: action.payload.failedScheduledJournalEntries.map((journalEntry) => journalEntry.scheduled_journal_entry_id ?? ''),
185
+ };
186
+ },
187
+ prepare(failedJeSchedules, failedScheduledJournalEntries) {
188
+ return { payload: { failedJeSchedules, failedScheduledJournalEntries } };
189
+ },
190
+ },
191
+ fetchFailedJePostingsFailure: {
192
+ reducer(draft, action) {
193
+ // Keys are deliberately left alone. The schedules list clears its buckets on failure so an
194
+ // errored tab cannot read as "these are all the schedules there are", but this list is a
195
+ // set of outstanding problems -- showing the last known ones beside an error beats
196
+ // implying there are none.
197
+ draft.failedJePostings.fetchState = {
198
+ fetchState: 'Error',
199
+ error: action.payload.status,
200
+ };
201
+ },
202
+ prepare(status) {
203
+ return { payload: { status } };
204
+ },
205
+ },
145
206
  fetchJeSchedulesSuccess(draft, action) {
146
207
  const { jeSchedules, selectedPeriod, selectedPageTab, failedJeSchedules, accruedJeSchedules, oneTimeAccruals, refreshViewInBackground, } = action.payload;
147
208
  const periodTabKey = getJESchedulePeriodTabKey(selectedPageTab, toMonthYearPeriodId(selectedPeriod));
@@ -204,6 +265,13 @@ const expenseAutomationJESchedulesView = createSlice({
204
265
  error: undefined,
205
266
  },
206
267
  };
268
+ // This posting has just succeeded, so it is no longer part of the failing set. Removing the
269
+ // entry from the schedule entity is not enough on its own: a later detail or Quick View
270
+ // fetch re-adds that month from the server, and because is_posting_failed is never cleared
271
+ // it can still arrive carrying its old error array. With the id left in place the selector
272
+ // would match it again and put a Retry button back on a posting that already went through.
273
+ draft.failedJePostings.scheduledJournalEntryIDs =
274
+ draft.failedJePostings.scheduledJournalEntryIDs.filter((failedEntryID) => failedEntryID !== scheduledJournalEntryID);
207
275
  },
208
276
  retryJeScheduleFailure(draft, action) {
209
277
  const { status, scheduledJournalEntryID } = action.payload;
@@ -358,6 +426,8 @@ const expenseAutomationJESchedulesView = createSlice({
358
426
  reducer(draft, action) {
359
427
  const { failedJeScheduleKey } = action.payload;
360
428
  removeKeyFromEveryTabSlot(draft.failedJeScheduleTransactionKeysByPeriodAndTab, failedJeScheduleKey);
429
+ draft.failedJePostings.jeScheduleTransactionKeys =
430
+ draft.failedJePostings.jeScheduleTransactionKeys.filter((jeScheduleKey) => jeScheduleKey !== failedJeScheduleKey);
361
431
  },
362
432
  },
363
433
  initializeJeScheduleLocalData: {
@@ -700,6 +770,9 @@ const expenseAutomationJESchedulesView = createSlice({
700
770
  draft.uiState.createdGroupCollapsed =
701
771
  !draft.uiState.createdGroupCollapsed;
702
772
  },
773
+ toggleJEFailedGroupCollapsed(draft) {
774
+ draft.uiState.failedGroupCollapsed = !draft.uiState.failedGroupCollapsed;
775
+ },
703
776
  clearExpenseAutomationJESchedulesView(draft) {
704
777
  Object.assign(draft, initialState);
705
778
  },
@@ -710,7 +783,7 @@ const expenseAutomationJESchedulesView = createSlice({
710
783
  });
711
784
  },
712
785
  });
713
- export const { clearExpenseAutomationJESchedulesView, clearJeAccountSettingsLocalData, clearJeScheduleLocalData, clearSearchTransactionsForNewSchedule, createOneTimeAccrual, createOneTimeAccrualFailure, createOneTimeAccrualSuccess, ignoreOneTimeAccrual, oneTimeAccrualActionFailure, oneTimeAccrualActionSuccess, promoteOneTimeAccrual, revertJeSchedule, revertJeScheduleFailure, revertJeScheduleSuccess, revertOneTimeAccrual, fetchAccountSettingsListForAccountTypes, fetchJeSchedules, fetchJeSchedulesFailure, fetchJeSchedulesPage, fetchJeSchedulesSuccess, fetchOneTimeAccrual, fetchOneTimeAccrualFailure, fetchOneTimeAccrualSuccess, fetchRecommendationForAccountSettings, ignoreRecommendedJeSchedule, ignoreRecommendedJeScheduleFailure, ignoreRecommendedJeScheduleSuccess, initializeAccountSettingsView, initializeJeScheduleLocalData, initializeNewSchedule, removeFailedJeScheduleTransactionKey, removeJeOneTimeAccrualLocalData, removeJeScheduleLocalDataById, removeJeAccruedScheduleKey, removeJeScheduleTransactionKey, resetNewScheduleLocalData, retryJeSchedule, retryJeScheduleFailure, retryJeScheduleSuccess, saveAccountSettings, saveAccountSettingsFailure, saveAccountSettingsLocalData, saveAccountSettingsSuccess, saveNewSchedule, saveNewScheduleFailure, saveNewScheduleSuccess, searchTransactionsForNewSchedule, searchTransactionsForNewScheduleFailure, searchTransactionsForNewScheduleSuccess, toggleJECreatedGroupCollapsed, toggleJEPendingGroupCollapsed, updateAccountSettingsListForAccountTypes, updateAccountSettingsListForAccountTypesFailure, updateJESchedulesUIState, updateJEScheduleTypeFilter, updateJeOneTimeAccrualLocalData, updateJeScheduleLocalDataById, updateJeScheduleTransactionKeys, updateNewScheduleLocalData, updateRecommendationForAccountSettings, updateRecommendationForAccountSettingsFailure, } = expenseAutomationJESchedulesView.actions;
786
+ export const { clearExpenseAutomationJESchedulesView, clearJeAccountSettingsLocalData, clearJeScheduleLocalData, clearSearchTransactionsForNewSchedule, createOneTimeAccrual, createOneTimeAccrualFailure, createOneTimeAccrualSuccess, ignoreOneTimeAccrual, oneTimeAccrualActionFailure, oneTimeAccrualActionSuccess, promoteOneTimeAccrual, revertJeSchedule, revertJeScheduleFailure, revertJeScheduleSuccess, revertOneTimeAccrual, fetchAccountSettingsListForAccountTypes, fetchJeSchedules, fetchFailedJePostings, fetchFailedJePostingsFailure, fetchFailedJePostingsSuccess, fetchJeSchedulesFailure, fetchJeSchedulesPage, fetchJeSchedulesSuccess, fetchOneTimeAccrual, fetchOneTimeAccrualFailure, fetchOneTimeAccrualSuccess, fetchRecommendationForAccountSettings, ignoreRecommendedJeSchedule, ignoreRecommendedJeScheduleFailure, ignoreRecommendedJeScheduleSuccess, initializeAccountSettingsView, initializeJeScheduleLocalData, initializeNewSchedule, removeFailedJeScheduleTransactionKey, removeJeOneTimeAccrualLocalData, removeJeScheduleLocalDataById, removeJeAccruedScheduleKey, removeJeScheduleTransactionKey, resetNewScheduleLocalData, retryJeSchedule, retryJeScheduleFailure, retryJeScheduleSuccess, saveAccountSettings, saveAccountSettingsFailure, saveAccountSettingsLocalData, saveAccountSettingsSuccess, saveNewSchedule, saveNewScheduleFailure, saveNewScheduleSuccess, searchTransactionsForNewSchedule, searchTransactionsForNewScheduleFailure, searchTransactionsForNewScheduleSuccess, toggleJECreatedGroupCollapsed, toggleJEFailedGroupCollapsed, toggleJEPendingGroupCollapsed, updateAccountSettingsListForAccountTypes, updateAccountSettingsListForAccountTypesFailure, updateJESchedulesUIState, updateJEScheduleTypeFilter, updateJeOneTimeAccrualLocalData, updateJeScheduleLocalDataById, updateJeScheduleTransactionKeys, updateNewScheduleLocalData, updateRecommendationForAccountSettings, updateRecommendationForAccountSettingsFailure, } = expenseAutomationJESchedulesView.actions;
714
787
  export default expenseAutomationJESchedulesView.reducer;
715
788
  const doUpdateRecommendationForAccountSettings = (draft, payload) => {
716
789
  const { prepaidExpensesRecommendations, fixedAssetsRecommendations, accruedExpensesRecommendations, } = mapAccountTypeRecommendationPayloadToAccountRecommendationByType(payload);