@zeniai/client-epic-state 5.2.52 → 5.2.53-beta0ND

package/lib/entity/notificationRegistry/notificationRegistryReducer.d.ts

@@ -1,9 +1,10 @@
 import { NotificationRegistryPayload } from './notificationRegistryPayload';
-import { NotificationRegistryState } from './notificationRegistryState';
+import { NotificationDomain, NotificationRegistryState } from './notificationRegistryState';
 export declare const initialState: NotificationRegistryState;
 export interface UpdateNotificationRegistryPayload {
     registry: NotificationRegistryPayload | undefined;
     registryEpochAtDispatch: number;
+    registriesByDomain?: Partial<Record<NotificationDomain, NotificationRegistryPayload | undefined>>;
 }
 export declare const updateNotificationRegistry: import("@reduxjs/toolkit").ActionCreatorWithPayload<UpdateNotificationRegistryPayload, "notificationRegistry/updateNotificationRegistry">;
 declare const _default: import("redux").Reducer<NotificationRegistryState>;

package/lib/entity/notificationRegistry/notificationRegistryReducer.js

@@ -4,6 +4,7 @@ exports.updateNotificationRegistry = exports.initialState = void 0;
 const toolkit_1 = require("@reduxjs/toolkit");
 const rootActions_1 = require("../../rootActions");
 const notificationRegistryPayload_1 = require("./notificationRegistryPayload");
+const notificationRegistryState_1 = require("./notificationRegistryState");
 exports.initialState = { registryEpoch: 0 };
 const notificationRegistry = (0, toolkit_1.createSlice)({
     name: 'notificationRegistry',
@@ -22,16 +23,24 @@ const notificationRegistry = (0, toolkit_1.createSlice)({
             // `task_checklist_registry` CLEARS so tenant B doesn't inherit A's
             // Task Checklist section. Guarded by the epoch check above so a stale
             // absent-response can't wipe a fresh registry.
-            if (action.payload.registry == null) {
-                draft.registry = undefined;
-                return;
+            const { registriesByDomain } = action.payload;
+            // Absent `registriesByDomain` means a pre-domain caller: treat `registry`
+            // as the task_checklist snapshot so their behaviour is unchanged.
+            const snapshots = registriesByDomain ?? { task_checklist: action.payload.registry };
+            draft.registryByDomain = {};
+            for (const domain of notificationRegistryState_1.NOTIFICATION_DOMAINS) {
+                const payload = snapshots[domain];
+                // Full-replace per domain, and an absent snapshot CLEARS that domain so
+                // tenant B never inherits A's section. The gates are independent
+                // server-side, so one domain clearing must not touch the other.
+                if (payload != null) {
+                    draft.registryByDomain[domain] =
+                        (0, notificationRegistryPayload_1.mapNotificationRegistryPayloadToRegistry)(payload);
+                }
             }
-            // Full-replace contract: the registry payload is atomic — every fetch
-            // returns the complete group/event tree. If the backend ever ships a
-            // partial registry response, this write MUST switch to a merge (mirror
-            // the preferences slice's `mergePreferences`). Do not assume the
-            // current payload is partial without also updating this reducer.
-            draft.registry = (0, notificationRegistryPayload_1.mapNotificationRegistryPayloadToRegistry)(action.payload.registry);
+            // Mirrored for consumers that predate the domain-keyed map.
+            draft.registry = draft.registryByDomain.task_checklist;
+            return;
         },
     },
     extraReducers: (builder) => {
@@ -44,6 +53,8 @@ const notificationRegistry = (0, toolkit_1.createSlice)({
             // — Cursor Bugbot 67d6918e. Returning `initialState` verbatim would
             // rewind the counter and let a stale in-flight GET restore A's
             // registry over B's.
+            // Drops `registry` and `registryByDomain` together: a tenant switch must
+            // not leave one domain's section behind.
             return { registryEpoch: draft.registryEpoch + 1 };
         });
     },

package/lib/entity/notificationRegistry/notificationRegistrySelector.d.ts

@@ -1,2 +1,3 @@
-import { NotificationRegistry, NotificationRegistryState } from './notificationRegistryState';
+import { NotificationDomain, NotificationRegistry, NotificationRegistryState } from './notificationRegistryState';
 export declare const getNotificationRegistry: (slice: NotificationRegistryState) => NotificationRegistry | undefined;
+export declare const getNotificationRegistryForDomain: (slice: NotificationRegistryState, domain: NotificationDomain) => NotificationRegistry | undefined;

package/lib/entity/notificationRegistry/notificationRegistrySelector.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.getNotificationRegistry = void 0;
+exports.getNotificationRegistryForDomain = exports.getNotificationRegistry = void 0;
 // Current behavior: a null / undefined registry means the whole notification
 // section is hidden by consumers. This conflates two distinct states —
 // "user has no saved preferences yet" vs "the Task Checklist feature gate is
@@ -8,3 +8,9 @@ exports.getNotificationRegistry = void 0;
 // them (e.g. an explicit `gate_off` signal from the server) is a follow-up.
 const getNotificationRegistry = (slice) => slice.registry;
 exports.getNotificationRegistry = getNotificationRegistry;
+// `undefined` conflates gate-off with no-preferences-yet; consumers hide the
+// section either way. Falls back to `registry` for task_checklist so state built
+// in the pre-domain shape (consumer mocks, older callers) still resolves.
+const getNotificationRegistryForDomain = (slice, domain) => slice.registryByDomain?.[domain] ??
+    (domain === 'task_checklist' ? slice.registry : undefined);
+exports.getNotificationRegistryForDomain = getNotificationRegistryForDomain;

package/lib/entity/notificationRegistry/notificationRegistryState.d.ts

@@ -1,3 +1,7 @@
+export declare const NOTIFICATION_DOMAINS: readonly ["task_checklist", "commenting"];
+export type NotificationDomain = (typeof NOTIFICATION_DOMAINS)[number];
+export declare const DEFAULT_NOTIFICATION_DOMAIN: NotificationDomain;
+export declare const toNotificationDomain: (raw: string) => NotificationDomain;
 export declare const NOTIFICATION_CHANNELS: readonly ["email", "slack", "in_app"];
 export type NotificationChannel = (typeof NOTIFICATION_CHANNELS)[number];
 export declare const toNotificationChannel: (raw: string) => NotificationChannel;
@@ -30,4 +34,5 @@ export interface NotificationRegistry {
 export interface NotificationRegistryState {
     registryEpoch: number;
     registry?: NotificationRegistry;
+    registryByDomain?: Partial<Record<NotificationDomain, NotificationRegistry>>;
 }

package/lib/entity/notificationRegistry/notificationRegistryState.js

@@ -1,7 +1,13 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.toNotificationFrequency = exports.NOTIFICATION_FREQUENCIES = exports.toNotificationChannel = exports.NOTIFICATION_CHANNELS = void 0;
+exports.toNotificationFrequency = exports.NOTIFICATION_FREQUENCIES = exports.toNotificationChannel = exports.NOTIFICATION_CHANNELS = exports.toNotificationDomain = exports.DEFAULT_NOTIFICATION_DOMAIN = exports.NOTIFICATION_DOMAINS = void 0;
 const stringToUnion_1 = require("../../commonStateTypes/stringToUnion");
+// Wire vocabulary owned by the notifications service, not by this slice.
+exports.NOTIFICATION_DOMAINS = ['task_checklist', 'commenting'];
+// Callers that predate the domain split mean Task Checklist.
+exports.DEFAULT_NOTIFICATION_DOMAIN = 'task_checklist';
+const toNotificationDomain = (raw) => (0, stringToUnion_1.stringToUnion)(raw, exports.NOTIFICATION_DOMAINS);
+exports.toNotificationDomain = toNotificationDomain;
 exports.NOTIFICATION_CHANNELS = ['email', 'slack', 'in_app'];
 const toNotificationChannel = (raw) => (0, stringToUnion_1.stringToUnion)(raw, exports.NOTIFICATION_CHANNELS);
 exports.toNotificationChannel = toNotificationChannel;

package/lib/entity/sectionProjectView/sectionProjectViewReducer.js

@@ -35,7 +35,9 @@ const sectionProjectView = (0, toolkit_1.createSlice)({
                     Object.keys(sectionPayload.projects).forEach((projectId) => {
                         const projectPayload = sectionPayload.projects[projectId];
                         // A calculated section is grouped by project with no accounts under it.
-                        const projectAccounts = 'accounts' in projectPayload ? projectPayload.accounts : undefined;
+                        const projectAccounts = 'accounts' in projectPayload
+                            ? projectPayload.accounts
+                            : undefined;
                         const nestedAccountIds = projectAccounts != null
                             ? (0, getNestedAccountIDHierarchyForSection_1.getNestedAccountIDHierarchyForAccounts)(Object.keys(projectAccounts), accountsMetadata)
                             : [];

package/lib/epic.js

@@ -53,21 +53,21 @@ const acceptMasterTOSEpic_1 = require("./view/aiCfoView/epics/acceptMasterTOSEpi
 const createSessionAndSubmitEpic_1 = require("./view/aiCfoView/epics/createSessionAndSubmitEpic");
 const createSessionEpic_1 = require("./view/aiCfoView/epics/createSessionEpic");
 const deleteChatSessionEpic_1 = require("./view/aiCfoView/epics/deleteChatSessionEpic");
+const deleteRoutineEpic_1 = require("./view/aiCfoView/epics/deleteRoutineEpic");
 const deleteSkillEpic_1 = require("./view/aiCfoView/epics/deleteSkillEpic");
 const fetchChatHistoryEpic_1 = require("./view/aiCfoView/epics/fetchChatHistoryEpic");
 const fetchChatSessionsForUserEpic_1 = require("./view/aiCfoView/epics/fetchChatSessionsForUserEpic");
+const fetchRoutineRunsEpic_1 = require("./view/aiCfoView/epics/fetchRoutineRunsEpic");
+const fetchRoutinesEpic_1 = require("./view/aiCfoView/epics/fetchRoutinesEpic");
 const fetchSkillDetailEpic_1 = require("./view/aiCfoView/epics/fetchSkillDetailEpic");
 const fetchSkillVersionBodyEpic_1 = require("./view/aiCfoView/epics/fetchSkillVersionBodyEpic");
 const fetchSkillVersionsEpic_1 = require("./view/aiCfoView/epics/fetchSkillVersionsEpic");
 const fetchSkillsEpic_1 = require("./view/aiCfoView/epics/fetchSkillsEpic");
 const fetchSuggestedQuestionsEpic_1 = require("./view/aiCfoView/epics/fetchSuggestedQuestionsEpic");
-const deleteRoutineEpic_1 = require("./view/aiCfoView/epics/deleteRoutineEpic");
-const fetchRoutineRunsEpic_1 = require("./view/aiCfoView/epics/fetchRoutineRunsEpic");
-const fetchRoutinesEpic_1 = require("./view/aiCfoView/epics/fetchRoutinesEpic");
 const runRoutineEpic_1 = require("./view/aiCfoView/epics/runRoutineEpic");
 const saveRoutineEpic_1 = require("./view/aiCfoView/epics/saveRoutineEpic");
-const setRoutineEnabledEpic_1 = require("./view/aiCfoView/epics/setRoutineEnabledEpic");
 const saveSkillEpic_1 = require("./view/aiCfoView/epics/saveSkillEpic");
+const setRoutineEnabledEpic_1 = require("./view/aiCfoView/epics/setRoutineEnabledEpic");
 const setSkillVisibilityEpic_1 = require("./view/aiCfoView/epics/setSkillVisibilityEpic");
 const stopSubmitEpic_1 = require("./view/aiCfoView/epics/stopSubmitEpic");
 const stopSubmitQuestionEpic_1 = require("./view/aiCfoView/epics/stopSubmitQuestionEpic");

package/lib/esm/entity/notificationRegistry/notificationRegistryReducer.js

@@ -1,6 +1,7 @@
 import { createSlice } from '@reduxjs/toolkit';
 import { clearAll } from '../../rootActions';
 import { mapNotificationRegistryPayloadToRegistry, } from './notificationRegistryPayload';
+import { NOTIFICATION_DOMAINS, } from './notificationRegistryState';
 export const initialState = { registryEpoch: 0 };
 const notificationRegistry = createSlice({
     name: 'notificationRegistry',
@@ -19,16 +20,24 @@ const notificationRegistry = createSlice({
             // `task_checklist_registry` CLEARS so tenant B doesn't inherit A's
             // Task Checklist section. Guarded by the epoch check above so a stale
             // absent-response can't wipe a fresh registry.
-            if (action.payload.registry == null) {
-                draft.registry = undefined;
-                return;
+            const { registriesByDomain } = action.payload;
+            // Absent `registriesByDomain` means a pre-domain caller: treat `registry`
+            // as the task_checklist snapshot so their behaviour is unchanged.
+            const snapshots = registriesByDomain ?? { task_checklist: action.payload.registry };
+            draft.registryByDomain = {};
+            for (const domain of NOTIFICATION_DOMAINS) {
+                const payload = snapshots[domain];
+                // Full-replace per domain, and an absent snapshot CLEARS that domain so
+                // tenant B never inherits A's section. The gates are independent
+                // server-side, so one domain clearing must not touch the other.
+                if (payload != null) {
+                    draft.registryByDomain[domain] =
+                        mapNotificationRegistryPayloadToRegistry(payload);
+                }
             }
-            // Full-replace contract: the registry payload is atomic — every fetch
-            // returns the complete group/event tree. If the backend ever ships a
-            // partial registry response, this write MUST switch to a merge (mirror
-            // the preferences slice's `mergePreferences`). Do not assume the
-            // current payload is partial without also updating this reducer.
-            draft.registry = mapNotificationRegistryPayloadToRegistry(action.payload.registry);
+            // Mirrored for consumers that predate the domain-keyed map.
+            draft.registry = draft.registryByDomain.task_checklist;
+            return;
         },
     },
     extraReducers: (builder) => {
@@ -41,6 +50,8 @@ const notificationRegistry = createSlice({
             // — Cursor Bugbot 67d6918e. Returning `initialState` verbatim would
             // rewind the counter and let a stale in-flight GET restore A's
             // registry over B's.
+            // Drops `registry` and `registryByDomain` together: a tenant switch must
+            // not leave one domain's section behind.
             return { registryEpoch: draft.registryEpoch + 1 };
         });
     },

package/lib/esm/entity/notificationRegistry/notificationRegistrySelector.js

@@ -4,3 +4,8 @@
 // off for this tenant". Both currently surface as `undefined`. Distinguishing
 // them (e.g. an explicit `gate_off` signal from the server) is a follow-up.
 export const getNotificationRegistry = (slice) => slice.registry;
+// `undefined` conflates gate-off with no-preferences-yet; consumers hide the
+// section either way. Falls back to `registry` for task_checklist so state built
+// in the pre-domain shape (consumer mocks, older callers) still resolves.
+export const getNotificationRegistryForDomain = (slice, domain) => slice.registryByDomain?.[domain] ??
+    (domain === 'task_checklist' ? slice.registry : undefined);

package/lib/esm/entity/notificationRegistry/notificationRegistryState.js

@@ -1,4 +1,9 @@
 import { stringToUnion } from '../../commonStateTypes/stringToUnion';
+// Wire vocabulary owned by the notifications service, not by this slice.
+export const NOTIFICATION_DOMAINS = ['task_checklist', 'commenting'];
+// Callers that predate the domain split mean Task Checklist.
+export const DEFAULT_NOTIFICATION_DOMAIN = 'task_checklist';
+export const toNotificationDomain = (raw) => stringToUnion(raw, NOTIFICATION_DOMAINS);
 export const NOTIFICATION_CHANNELS = ['email', 'slack', 'in_app'];
 export const toNotificationChannel = (raw) => stringToUnion(raw, NOTIFICATION_CHANNELS);
 export const NOTIFICATION_FREQUENCIES = ['instant', 'daily'];

package/lib/esm/entity/sectionProjectView/sectionProjectViewReducer.js

@@ -32,7 +32,9 @@ const sectionProjectView = createSlice({
                     Object.keys(sectionPayload.projects).forEach((projectId) => {
                         const projectPayload = sectionPayload.projects[projectId];
                         // A calculated section is grouped by project with no accounts under it.
-                        const projectAccounts = 'accounts' in projectPayload ? projectPayload.accounts : undefined;
+                        const projectAccounts = 'accounts' in projectPayload
+                            ? projectPayload.accounts
+                            : undefined;
                         const nestedAccountIds = projectAccounts != null
                             ? getNestedAccountIDHierarchyForAccounts(Object.keys(projectAccounts), accountsMetadata)
                             : [];

package/lib/esm/epic.js

@@ -50,21 +50,21 @@ import { acceptMasterTOSEpic, } from './view/aiCfoView/epics/acceptMasterTOSEpic
 import { createSessionAndSubmitEpic, } from './view/aiCfoView/epics/createSessionAndSubmitEpic';
 import { createSessionEpic, } from './view/aiCfoView/epics/createSessionEpic';
 import { deleteChatSessionEpic, } from './view/aiCfoView/epics/deleteChatSessionEpic';
+import { deleteRoutineEpic } from './view/aiCfoView/epics/deleteRoutineEpic';
 import { deleteSkillEpic } from './view/aiCfoView/epics/deleteSkillEpic';
 import { fetchChatHistoryEpic, } from './view/aiCfoView/epics/fetchChatHistoryEpic';
 import { fetchChatSessionsForUserEpic, } from './view/aiCfoView/epics/fetchChatSessionsForUserEpic';
+import { fetchRoutineRunsEpic } from './view/aiCfoView/epics/fetchRoutineRunsEpic';
+import { fetchRoutinesEpic } from './view/aiCfoView/epics/fetchRoutinesEpic';
 import { fetchSkillDetailEpic } from './view/aiCfoView/epics/fetchSkillDetailEpic';
 import { fetchSkillVersionBodyEpic } from './view/aiCfoView/epics/fetchSkillVersionBodyEpic';
 import { fetchSkillVersionsEpic } from './view/aiCfoView/epics/fetchSkillVersionsEpic';
 import { fetchSkillsEpic, } from './view/aiCfoView/epics/fetchSkillsEpic';
 import { fetchSuggestedQuestionsEpic, } from './view/aiCfoView/epics/fetchSuggestedQuestionsEpic';
-import { deleteRoutineEpic } from './view/aiCfoView/epics/deleteRoutineEpic';
-import { fetchRoutineRunsEpic } from './view/aiCfoView/epics/fetchRoutineRunsEpic';
-import { fetchRoutinesEpic } from './view/aiCfoView/epics/fetchRoutinesEpic';
 import { runRoutineEpic } from './view/aiCfoView/epics/runRoutineEpic';
 import { saveRoutineEpic } from './view/aiCfoView/epics/saveRoutineEpic';
-import { setRoutineEnabledEpic } from './view/aiCfoView/epics/setRoutineEnabledEpic';
 import { saveSkillEpic } from './view/aiCfoView/epics/saveSkillEpic';
+import { setRoutineEnabledEpic } from './view/aiCfoView/epics/setRoutineEnabledEpic';
 import { setSkillVisibilityEpic } from './view/aiCfoView/epics/setSkillVisibilityEpic';
 import { stopSubmitEpic, } from './view/aiCfoView/epics/stopSubmitEpic';
 import { stopSubmitQuestionEpic, } from './view/aiCfoView/epics/stopSubmitQuestionEpic';

package/lib/esm/index.js

@@ -64,8 +64,8 @@ import { ALL_JE_SCHEDULE_IGNORE_REASONS, ALL_JE_SCHEDULE_REVERT_REASONS, ALL_ONE
 import { ALL_MONTH_END_CLOSE_CHECKS_FREQUENCY, } from './entity/monthEndCloseChecks/monthEndCloseChecksState';
 import { updateCommentsNotifications, updateCommentsNotificationsStatuses, } from './entity/notification/notificationReducer';
 import { toNotificationModeStrict, } from './entity/notification/types/notificationTypes';
-import { getNotificationRegistry } from './entity/notificationRegistry/notificationRegistrySelector';
-import { toNotificationChannel, toNotificationFrequency, } from './entity/notificationRegistry/notificationRegistryState';
+import { getNotificationRegistry, getNotificationRegistryForDomain, } from './entity/notificationRegistry/notificationRegistrySelector';
+import { DEFAULT_NOTIFICATION_DOMAIN, NOTIFICATION_DOMAINS, toNotificationChannel, toNotificationDomain, toNotificationFrequency, } from './entity/notificationRegistry/notificationRegistryState';
 import { getPlaidPaymentAccounts } from './entity/paymentAccount/paymentAccountSelector';
 import { VERIFIED_PAYMENT_ACCOUNT_PROVIDER_VERIFICATION_STATUS, } from './entity/paymentAccount/paymentAccountState';
 import { closeSnackbar, openSnackbar } from './entity/snackbar/snackbarReducer';
@@ -236,7 +236,7 @@ import { toAverageMonthsCount } from './view/netBurnOrIncomeStoryCard/epic/updat
 import { fetchNetBurnOrIncomeStoryCard, updateNetBurnOrIncomeStoryCardSettings, } from './view/netBurnOrIncomeStoryCard/netBurnOrIncomeStoryCardReducer';
 import { getNetBurnOrIncomeStoryCardReport } from './view/netBurnOrIncomeStoryCard/netBurnOrIncomeStoryCardSelector';
 import { clearAllNotificationPreferencesView, clearNotificationPreferencesLocalOverrides, saveNotificationPreferences, setGroupChannelMaster, setGroupFrequency, toggleEventChannel, } from './view/notificationPreferencesView/notificationPreferencesViewReducer';
-import { getEffectiveNotificationPreferences, getNotificationLocalOverrides, getNotificationPreferencesSaveState, hasUnsavedNotificationPreferences, } from './view/notificationPreferencesView/notificationPreferencesViewSelector';
+import { getEffectiveNotificationPreferences, getEffectiveNotificationPreferencesForDomain, getNotificationLocalOverrides, getNotificationLocalOverridesForDomain, getNotificationPreferencesSaveState, hasUnsavedNotificationPreferences, hasUnsavedNotificationPreferencesForDomain, } from './view/notificationPreferencesView/notificationPreferencesViewSelector';
 import { fetchNotificationUnreadCount, fetchNotificationUnreadCountSuccess, fetchNotificationView, updateNotificationViewAllNotificationsStatus, updateNotificationViewCurrentTabAndSubTab, updateNotificationViewNotificationStatus, updateNotificationViewSubTab, updateNotificationViewTabState, updateNotificationViewUIState, } from './view/notificationView/notificationViewReducer';
 import { getExternalNotificationsForSelectedSubTab, getNotificationView, getNotificationsForSelectedSubTab, } from './view/notificationView/notificationViewSelector';
 import { toNotificationSubTabTypeStrict, toNotificationTabTypeStrict, } from './view/notificationView/notificationViewState';
@@ -680,7 +680,7 @@ export { toNotificationModeStrict, updateCommentsNotifications, updateCommentsNo
 export { toNotificationSubTabTypeStrict, toNotificationTabTypeStrict, fetchNotificationView, fetchNotificationUnreadCount, fetchNotificationUnreadCountSuccess, updateNotificationViewAllNotificationsStatus, updateNotificationViewNotificationStatus, updateNotificationViewTabState, updateNotificationViewCurrentTabAndSubTab, updateNotificationViewSubTab, updateNotificationViewUIState, getNotificationView, getExternalNotificationsForSelectedSubTab, getNotificationsForSelectedSubTab, };
 export { fetchRegisteredInterests, notifyMeForFeature, getFeatureNotificationView, getRegisteredInterests, getRegisteredInterestsByFeature, isFeatureInterestRegistered, };
 export { pushToastNotification, getLastNotificationTime, getNotifications, };
-export { getEffectiveNotificationPreferences, getNotificationLocalOverrides, getNotificationPreferencesSaveState, getNotificationRegistry, hasUnsavedNotificationPreferences, clearAllNotificationPreferencesView, clearNotificationPreferencesLocalOverrides, saveNotificationPreferences, setGroupChannelMaster, setGroupFrequency, toggleEventChannel, toNotificationChannel, toNotificationFrequency, };
+export { getEffectiveNotificationPreferences, getEffectiveNotificationPreferencesForDomain, getNotificationLocalOverrides, getNotificationLocalOverridesForDomain, getNotificationPreferencesSaveState, getNotificationRegistry, getNotificationRegistryForDomain, hasUnsavedNotificationPreferences, hasUnsavedNotificationPreferencesForDomain, NOTIFICATION_DOMAINS, DEFAULT_NOTIFICATION_DOMAIN, clearAllNotificationPreferencesView, clearNotificationPreferencesLocalOverrides, saveNotificationPreferences, setGroupChannelMaster, setGroupFrequency, toggleEventChannel, toNotificationChannel, toNotificationDomain, toNotificationFrequency, };
 export { getReferralListView, getInviteFormView, toReferralListViewSortKeyType, StatusTypes, AmountStatusTypes, DEFAULT_REFERRER_AMOUNT, fetchReferrals, sendReferralInvite, clearReferrals, saveReferralFormDataInLocalStore, updateReferralListSortUiState, resendReferralInvite, fetchRewardsPlan, getRewardsPlanCard, updateReferViewed, };
 export { ALL_WEEK_DAYS, SEMI_WEEKLY_REQUIRED_DAYS_COUNT, getMinAllowedEndDate, getRecurringEndDateFromCount, toDayOfWeek, toRecurringFrequency, };
 export { fetchCockpitContext, fetchCompanyTaskManagerView, fetchTaskManagerMetrics, getCompanyTaskManagerView, createTaskFromTaskGroupTemplate, };

package/lib/esm/view/aiCfoView/aiCfoViewReducer.js

@@ -835,7 +835,8 @@ const aiCfoView = createSlice({
             // The server has it. Nothing it sends from here on will contain this row,
             // so the tombstone has done its job and holding it any longer is what
             // makes a routine recreated under the same id invisible forever.
-            draft.routines.deletedScheduleIds = draft.routines.deletedScheduleIds.filter((id) => id !== action.payload.scheduleId);
+            draft.routines.deletedScheduleIds =
+                draft.routines.deletedScheduleIds.filter((id) => id !== action.payload.scheduleId);
             draft.routineMutation = {
                 fetchState: 'Completed',
                 error: undefined,
@@ -847,7 +848,8 @@ const aiCfoView = createSlice({
             // is what lets the refetch put the row back — leaving it hidden would
             // tell the user they had stopped something they had not, which is the
             // worst outcome this list can produce.
-            draft.routines.deletedScheduleIds = draft.routines.deletedScheduleIds.filter((id) => id !== action.payload.scheduleId);
+            draft.routines.deletedScheduleIds =
+                draft.routines.deletedScheduleIds.filter((id) => id !== action.payload.scheduleId);
             // Its own slice: the refetch that puts the row back would otherwise wipe
             // this error, leaving the row silently reappearing with no explanation.
             draft.routineMutation = {

package/lib/esm/view/aiCfoView/epics/fetchRoutineRunsEpic.js

@@ -27,7 +27,9 @@ export const fetchRoutineRunsEpic = (actions$, _state$, zeniAPI) => actions$.pip
             // Filtered, not trusted: one malformed row must not take the
             // whole history down, and a run without an id is not addressable
             // by anything the UI does with it.
-            runs: (data.runs ?? []).filter(isRoutineRunPayload).map(toRoutineRun),
+            runs: (data.runs ?? [])
+                .filter(isRoutineRunPayload)
+                .map(toRoutineRun),
             scheduleId,
             sessionId: data.session_id ?? null,
         });

package/lib/esm/view/expenseAutomationView/epics/transactionCategorization/fetchTransactionCategorizationEpic.js

@@ -6,7 +6,6 @@ import { updateTransactions } from '../../../../entity/transaction/transactionRe
 import { createZeniAPIStatus, isSuccessResponse, } from '../../../../responsePayload';
 import { getLineItemsByTransactionsIdsFromResponse } from '../../helpers/transactionCategorizationLocalDataHelper';
 import { fetchTransactionCategorization, fetchTransactionCategorizationFailure, fetchTransactionCategorizationSuccess, initializeTransactionCategorizationViewLocalData, resetOtherTabsFetchState, updateParentTotalCountForTab, updateTotalCountForTransactionCategorization, updateTransactionCategorizationUIState, } from '../../reducers/transactionsViewReducer';
-import { DEFAULT_COMPLETED_SUB_TAB } from '../../types/completedSubTab';
 import { TRANSACTIONS_TABS, toTransactionsSortKey, } from '../../types/transactionsViewState';
 export const fetchTransactionCategorizationEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(fetchTransactionCategorization.match), 
 // Per-tab switchMap: cancels in-flight requests for the same tab on a new
@@ -33,9 +32,10 @@ groupBy((action) => action.payload.selectedTab), mergeMap((group$) => group$.pip
         // cross-status search (omit or true) is reserved for Receipts
         // manual-match.
         search_all_statuses: false,
-        sub_tab: selectedTab === 'autoCategorized'
-            ? expenseAutomationTransactionsViewState.selectedTransactionCategorizationCompletedSubTab
-            : DEFAULT_COMPLETED_SUB_TAB,
+        // Sent on both tabs: the backend ignores it for Review's own rows but uses
+        // it to scope the Completed badge it returns alongside them.
+        sub_tab: expenseAutomationTransactionsViewState
+            .selectedTransactionCategorizationCompletedSubTab,
         transaction_group: expenseAutomationTransactionsViewState.selectedTransactionGroup,
     };
     return zeniAPI
@@ -87,6 +87,17 @@ groupBy((action) => action.payload.selectedTab), mergeMap((group$) => group$.pip
                 parentTotalCount: response.data.parent_tab_total_count ??
                     response.data.total_count,
             }));
+            // The inactive tab's badge, counted under the same filters. Absent on
+            // pages after the first and on the cross-tab search path, where the
+            // last known value stays correct.
+            const otherTabTotalCount = response.data.other_tab_total_count;
+            if (otherTabTotalCount != null) {
+                updateActions.push(updateParentTotalCountForTab({
+                    selectedPeriod,
+                    selectedTab: selectedTab === 'review' ? 'autoCategorized' : 'review',
+                    parentTotalCount: otherTabTotalCount,
+                }));
+            }
             updateActions.push(resetOtherTabsFetchState({
                 refreshViewInBackground,
                 tabs: TRANSACTIONS_TABS.filter((tab) => selectedTab !== tab),

package/lib/esm/view/expenseAutomationView/reducers/transactionsViewReducer.js

@@ -373,6 +373,16 @@ const expenseAutomationTransactionsView = createSlice({
                 if (cached != null) {
                     autoCat.uiState.pageToken = cached.pageToken;
                     autoCat.uiState.totalCount = { ...cached.totalCount };
+                    // Keep the stored badge in step with the restored sub-tab: the selector
+                    // falls back to it for any period this sub-tab has not loaded. Merged,
+                    // not replaced -- the snapshot only holds periods this sub-tab actually
+                    // loaded, while the badge map also carries periods filled from a Review
+                    // response's `other_tab_total_count`. Overwriting would drop those and
+                    // leave the badge at 0 for any period this sub-tab never visited.
+                    draft.parentTotalCountByTab.autoCategorized = {
+                        ...draft.parentTotalCountByTab.autoCategorized,
+                        ...cached.totalCount,
+                    };
                     autoCat.uiState.scrollPosition = cached.scrollPosition;
                     autoCat.transactionIdsBySelectedPeriod = {
                         ...cached.transactionIdsBySelectedPeriod,

package/lib/esm/view/expenseAutomationView/selectors/transactionCategorizationSelector.js

@@ -1,6 +1,6 @@
 import { createSelector } from '@reduxjs/toolkit';
 import omit from 'lodash/omit';
-import { toMonthYearPeriodId } from '../../../commonStateTypes/timePeriod';
+import { toMonthYearPeriodId, } from '../../../commonStateTypes/timePeriod';
 import { getCurrentTenant, getIsAccountingProjectsEnabled, } from '../../../entity/tenant/tenantSelector';
 import { getTransactionWithCOT } from '../../../entity/transaction/transactionHelper';
 import { getSupportedTransactionsByIds } from '../../../entity/transaction/transactionSelector';
@@ -172,18 +172,35 @@ export function getExpenseAutomationTransactionView(state) {
         review: monthYearPeriodId != null ? totalCountByReview[monthYearPeriodId] : 0,
         autoCategorized: monthYearPeriodId != null ? totalCountByAutoCat[monthYearPeriodId] : 0,
     };
-    // Parent-tab badge counts. Sourced from `parent_tab_total_count` in the
-    // listing response and used exclusively by the navbar / tab strip badges.
-    // Independent of which Completed sub-tab is active so the badge stays
-    // stable across sub-tab switches.
+    // Tab badge counts, used exclusively by the navbar / tab strip badges. Both
+    // tabs are counted under the filters applied to the list, so a badge always
+    // equals the number of rows that tab shows.
+    //
+    // The ACTIVE tab prefers its own list count: the two are the same number (the
+    // backend's parent_tab_total_count mirrors total_count), but `uiState.totalCount`
+    // is restored by every cache path that skips a fetch -- switching back to an
+    // already-loaded period, or to a cached Completed sub-tab -- whereas the stored
+    // badge is only written when a response lands, so on those paths it would keep
+    // showing whatever was fetched last.
+    //
+    // The `in` check is load-bearing, not defensive: `totalCount` is a per-period
+    // map typed as `Record<MonthYearPeriodId, number>`, so indexing it is typed
+    // `number` but is `undefined` for any period the active (sub-)tab has not
+    // loaded -- the window between switching to a fresh sub-tab and its response
+    // landing. Falling back to the stored badge there keeps a real number in the
+    // label instead of blanking it.
     const parentTotalCountByTab = expenseAutomationTransactionsViewState.parentTotalCountByTab;
+    const storedBadgeByTab = (tab) => monthYearPeriodId != null
+        ? (parentTotalCountByTab[tab][monthYearPeriodId] ?? 0)
+        : 0;
+    const badgeForTab = (tab, listCountByPeriod) => selectedTransactionCategorizationTab === tab &&
+        monthYearPeriodId != null &&
+        monthYearPeriodId in listCountByPeriod
+        ? listCountByPeriod[monthYearPeriodId]
+        : storedBadgeByTab(tab);
     const parentTabTotalCountByTab = {
-        review: monthYearPeriodId != null
-            ? (parentTotalCountByTab.review[monthYearPeriodId] ?? 0)
-            : 0,
-        autoCategorized: monthYearPeriodId != null
-            ? (parentTotalCountByTab.autoCategorized[monthYearPeriodId] ?? 0)
-            : 0,
+        review: badgeForTab('review', totalCountByReview),
+        autoCategorized: badgeForTab('autoCategorized', totalCountByAutoCat),
     };
     const fetchStateByTab = {
         review: {

package/lib/esm/view/invoicing/editInvoicingCatalogItemDetailView/editInvoicingCatalogItemDetailViewSelector.js

@@ -3,7 +3,7 @@ import { reduceAllFetchState } from '../../../commonStateTypes/reduceFetchState'
 import { getInvoicingPlanById, getInvoicingPlansByIds, } from '../../../entity/invoicing/plan/planSelector';
 import { getInvoicingConfigView, invoicingFieldHelpForGroup, } from '../invoicingConfigView/invoicingConfigViewSelector';
 import { getInvoicingFormDraftLocalData, isInvoicingFormDraftPending, } from '../invoicingFormDraft';
-import { getInvoicingQboView, isInvoicingAccountingPickerDataLoading, isInvoicingQboConnected, } from '../invoicingQboView/invoicingQboViewSelector';
+import { INVOICING_DEFAULT_INCOME_ACCOUNT_TYPES, INVOICING_INCOME_ACCOUNT_MAPPING_SLOT, NO_INVOICING_ACCOUNT_HIERARCHY, NO_INVOICING_ACCOUNT_IDS, NO_INVOICING_CLASS_HIERARCHY, getInvoicingQboAccountOptions, getInvoicingQboView, invoicingQboAccountIdsForMappingSlot, isInvoicingAccountingPickerDataLoading, isInvoicingQboConnected, } from '../invoicingQboView/invoicingQboViewSelector';
 import { INVOICING_CATALOG_APPLICABILITY_VALUES, INVOICING_CATALOG_PRICING_MODEL_VALUES, INVOICING_CATALOG_PRORATION_VALUES, INVOICING_CATALOG_TIER_TYPE_VALUES, initialInvoicingCatalogItemFormLocalData, } from './invoicingCatalogItemFormHelper';
 export const getEditInvoicingCatalogItemDetailViewState = (state) => ({
     fetchState: state.editInvoicingCatalogItemDetailViewState.fetchState,
@@ -44,6 +44,21 @@ const NOT_STARTED = {
     error: undefined,
     fetchState: 'Not-Started',
 };
+/**
+ * The QuickBooks ids a price point's income account may be picked from.
+ *
+ * Memoized, and collapsing to one shared empty array while QBO is disconnected:
+ * the pages turn this into their picker options and re-seed their form defaults
+ * when those change, so a fresh array on every store change would reset the form
+ * under the user — including mid-save.
+ */
+const getInvoicingCatalogIncomeAccountIds = createSelector([
+    getInvoicingQboAccountOptions,
+    (state) => getInvoicingConfigView(state).qboAccountMappingKindOptions,
+    isInvoicingQboConnected,
+], (accounts, qboAccountMappingKindOptions, isQboConnected) => isQboConnected
+    ? invoicingQboAccountIdsForMappingSlot(accounts, qboAccountMappingKindOptions, INVOICING_INCOME_ACCOUNT_MAPPING_SLOT, INVOICING_DEFAULT_INCOME_ACCOUNT_TYPES)
+    : NO_INVOICING_ACCOUNT_IDS);
 export const getInvoicingCatalogItemFormView = (state, id) => {
     const { editDraftById, error, fetchState, newItemDraft, savedItemId, savedKind, } = state.editInvoicingCatalogItemDetailViewState;
     const plan = id != null ? getInvoicingPlanById(state.invoicingPlanState, id) : undefined;
@@ -94,8 +109,9 @@ export const getInvoicingCatalogItemFormView = (state, id) => {
         isFormLoading: isInvoicingAccountingPickerDataLoading(state) ||
             isInvoicingFormDraftPending(editDraftById, id),
         isQboPickerDataLoading: isInvoicingAccountingPickerDataLoading(state),
-        qboAccountHierarchy: qboView?.nestedAccountHierarchy ?? [],
-        qboClassHierarchy: qboView?.nestedClassHierarchy ?? [],
+        qboAccountHierarchy: qboView?.nestedAccountHierarchy ?? NO_INVOICING_ACCOUNT_HIERARCHY,
+        qboClassHierarchy: qboView?.nestedClassHierarchy ?? NO_INVOICING_CLASS_HIERARCHY,
+        qboIncomeAccountIds: getInvoicingCatalogIncomeAccountIds(state),
         applicabilityValues: INVOICING_CATALOG_APPLICABILITY_VALUES,
         applicableItemOptions,
         localData,

package/lib/esm/view/invoicing/editInvoicingCouponDetailView/editInvoicingCouponDetailViewSelector.js

@@ -1,9 +1,10 @@
+import { createSelector } from '@reduxjs/toolkit';
 import { reduceAllFetchState } from '../../../commonStateTypes/reduceFetchState';
 import { getInvoicingCouponById } from '../../../entity/invoicing/coupon/couponSelector';
-import { toInvoicingFormOption, toInvoicingQboAccountMappingSlot, } from '../../../entity/invoicing/invoicingCommonPayload';
+import { toInvoicingFormOption, } from '../../../entity/invoicing/invoicingCommonPayload';
 import { getInvoicingConfigView, invoicingFieldHelpForGroup, } from '../invoicingConfigView/invoicingConfigViewSelector';
 import { getInvoicingFormDraftLocalData, isInvoicingFormDraftPending, } from '../invoicingFormDraft';
-import { getInvoicingQboView, invoicingAccountsForQboAccountTypes, invoicingQboAccountByQboId, isInvoicingAccountingPickerDataLoading, isInvoicingQboConnected, } from '../invoicingQboView/invoicingQboViewSelector';
+import { INVOICING_DEFAULT_INCOME_ACCOUNT_TYPES, INVOICING_DISCOUNTS_ACCOUNT_MAPPING_SLOT, NO_INVOICING_ACCOUNT_HIERARCHY, NO_INVOICING_ACCOUNT_IDS, getInvoicingQboAccountOptions, getInvoicingQboView, invoicingQboAccountByQboId, invoicingQboAccountIdsForMappingSlot, isInvoicingAccountingPickerDataLoading, isInvoicingQboConnected, } from '../invoicingQboView/invoicingQboViewSelector';
 import { getInvoicingSettings, getInvoicingSettingsFetchState, } from '../settingsView/settingsViewSelector';
 import { initialInvoicingCouponFormLocalData, invoicingCouponDiscountsAccountIdForCreate, } from './editInvoicingCouponDetailViewState';
 /**
@@ -11,6 +12,21 @@ import { initialInvoicingCouponFormLocalData, invoicingCouponDiscountsAccountIdF
  * the id of the coupon last saved, and — when a `couponId` is passed (edit
  * mode) — the existing coupon entity to prefill the form.
  */
+/**
+ * The QuickBooks ids the discounts account may be picked from.
+ *
+ * Memoized, and collapsing to one shared empty array while QBO is disconnected:
+ * the form turns this into its picker options and re-seeds its defaults when
+ * those change, so a fresh array on every store change would reset the form
+ * under the user until their first edit.
+ */
+const getInvoicingCouponDiscountsAccountIds = createSelector([
+    getInvoicingQboAccountOptions,
+    (state) => getInvoicingConfigView(state).qboAccountMappingKindOptions,
+    isInvoicingQboConnected,
+], (accounts, qboAccountMappingKindOptions, isQboConnected) => isQboConnected
+    ? invoicingQboAccountIdsForMappingSlot(accounts, qboAccountMappingKindOptions, INVOICING_DISCOUNTS_ACCOUNT_MAPPING_SLOT, INVOICING_DEFAULT_INCOME_ACCOUNT_TYPES)
+    : NO_INVOICING_ACCOUNT_IDS);
 const NOT_STARTED = {
     error: undefined,
     fetchState: 'Not-Started',
@@ -51,14 +67,6 @@ export const getEditInvoicingCouponDetailViewState = (state, couponId) => {
         version: 1.0,
     };
 };
-/**
- * The account types the discounts slot falls back to when the config has no
- * `discounts_account` kind. A QuickBooks discount line posts to an income
- * account; offering every account instead would let a save be rejected.
- */
-const DEFAULT_DISCOUNTS_ACCOUNT_TYPES = 'Income';
-/** The account-mapping slot a coupon's discounts account shares with settings. */
-const DISCOUNTS_ACCOUNT_MAPPING_SLOT = 'discounts_account';
 /**
  * Bundled view for the discount form screen: the edit view (save state + the
  * coupon to prefill in edit mode), the draft `localData` (seeded from the
@@ -74,7 +82,7 @@ export const getInvoicingCouponFormView = (state, couponId) => {
     const localData = couponId != null
         ? getInvoicingFormDraftLocalData(editDraftById, couponId, initialInvoicingCouponFormLocalData)
         : newCouponDraft;
-    const { billingPeriodUnitOptions, discountApplyOnOptions, discountDurationTypeOptions, discountTypeOptions, qboAccountMappingKindOptions, } = getInvoicingConfigView(state);
+    const { billingPeriodUnitOptions, discountApplyOnOptions, discountDurationTypeOptions, discountTypeOptions, } = getInvoicingConfigView(state);
     const isQboConnected = isInvoicingQboConnected(state);
     const qboView = isQboConnected ? getInvoicingQboView(state) : undefined;
     const isQboPickerDataLoading = isInvoicingAccountingPickerDataLoading(state);
@@ -84,14 +92,6 @@ export const getInvoicingCouponFormView = (state, couponId) => {
     const isCreateSeedPending = couponId == null &&
         (settingsFetchState === 'Not-Started' ||
             settingsFetchState === 'In-Progress');
-    // The account types the discounts slot accepts come from the same config the
-    // QBO settings page reads, so the two pickers offer the same accounts and
-    // widening the slot stays a config change. Matched on the slot rather than
-    // the code as written: a config that names the kind `discounts_account_id`
-    // is the same slot, and missing it here would quietly fall back to the
-    // default and offer a different set than the settings page does.
-    const discountsAccountTypes = qboAccountMappingKindOptions.find((kindOption) => toInvoicingQboAccountMappingSlot(kindOption.code) ===
-        DISCOUNTS_ACCOUNT_MAPPING_SLOT)?.accountTypes ?? DEFAULT_DISCOUNTS_ACCOUNT_TYPES;
     return {
         ...base,
         applyOnOptions: discountApplyOnOptions.map(toInvoicingFormOption),
@@ -130,7 +130,7 @@ export const getInvoicingCouponFormView = (state, couponId) => {
             },
         mode: couponId != null ? 'edit' : 'create',
         periodUnitOptions: billingPeriodUnitOptions.map(toInvoicingFormOption),
-        qboAccountHierarchy: qboView?.nestedAccountHierarchy ?? [],
-        qboIncomeAccountIds: invoicingAccountsForQboAccountTypes(qboView?.accounts ?? [], discountsAccountTypes).map((account) => account.id),
+        qboAccountHierarchy: qboView?.nestedAccountHierarchy ?? NO_INVOICING_ACCOUNT_HIERARCHY,
+        qboIncomeAccountIds: getInvoicingCouponDiscountsAccountIds(state),
     };
 };