@zeniai/client-epic-state 5.2.52-betaRD1 → 5.2.53

package/lib/esm/view/expenseAutomationView/epics/jeSchedule/initializeJeScheduleLocalDataEpic.js

@@ -7,41 +7,22 @@ export const initializeJeScheduleLocalDataEpic = (actions$, state$) => actions$.
     const actions = [];
     const { jeScheduleTransactionKeys } = action.payload;
     jeScheduleTransactionKeys.forEach((jeScheduleTransactionKey) => {
-        // Checked before the selector runs, not after: the selector destructures the record it
-        // looks up, so a key that is not in the store throws a TypeError rather than returning
-        // undefined. This epic is a mergeMap with no catchError, so that throw would take its
-        // subscription down for the rest of the session and silently stop local-data
-        // initialisation everywhere -- not just for this row.
-        if (state.jeSchedulesState.schedulesByTransactionKey[jeScheduleTransactionKey] == null) {
-            return;
-        }
         const jeScheduledTransaction = getJEScheduledTransactionByJEScheduleTransactionKey(jeScheduleTransactionKey, state);
-        // One record per journal entry, not per schedule. A schedule that failed in two months is
-        // two rows and each needs its own vendor / category edits -- keying only the first left
-        // every later row without local data, which the list renders read-only and without a
-        // Retry button. An empty array is possible when details have not landed yet; it must not
-        // throw, because this runs in a mergeMap with no catchError and the throw would take the
-        // epic's subscription down for the rest of the session.
-        // Filtered on `error` for the same reason the selector is: this array is shared state, and
-        // a schedule whose detail page has been opened holds every month it has, posted ones
-        // included. The seeding and the rows must agree on which entries are failed postings.
-        jeScheduledTransaction.scheduledJournalEntry
-            .filter((journalEntry) => journalEntry.error.length > 0)
-            .forEach((journalEntry) => {
-            const { scheduledJournalEntryID } = journalEntry;
-            actions.push(updateJeScheduleLocalDataById({
-                localData: {
-                    jeScheduleType: jeScheduledTransaction.jeScheduleType,
-                    jeScheduleID: jeScheduledTransaction.jeScheduleId,
-                    scheduledJournalEntryID,
-                    updatedVendor: undefined,
-                    updatedCategoryId: undefined,
-                    updatedAccumulatedDepreciationCategoryID: undefined,
-                    updatedClassId: undefined,
-                },
-                scheduledJournalEntryID,
-            }));
-        });
+        const initLocalData = {
+            jeScheduleType: jeScheduledTransaction.jeScheduleType,
+            jeScheduleID: jeScheduledTransaction.jeScheduleId,
+            scheduledJournalEntryID: jeScheduledTransaction.scheduledJournalEntry[0]
+                .scheduledJournalEntryID,
+            updatedVendor: undefined,
+            updatedCategoryId: undefined,
+            updatedAccumulatedDepreciationCategoryID: undefined,
+            updatedClassId: undefined,
+        };
+        actions.push(updateJeScheduleLocalDataById({
+            localData: initLocalData,
+            scheduledJournalEntryID: jeScheduledTransaction.scheduledJournalEntry[0]
+                .scheduledJournalEntryID,
+        }));
     });
     return from(actions);
 }));

package/lib/esm/view/expenseAutomationView/epics/jeSchedule/retryJeSchedulesEpic.js

@@ -1,6 +1,5 @@
 import { from } from 'rxjs';
 import { catchError, filter, mergeMap, switchMap } from 'rxjs/operators';
-import { removeScheduledJournalEntryFromJESchedule, } from '../../../../entity/jeSchedules/jeSchedulesReducer';
 import { openSnackbar } from '../../../../entity/snackbar/snackbarReducer';
 import { getCurrentTenant } from '../../../../entity/tenant/tenantSelector';
 import { createZeniAPIStatus, isSuccessStatus, } from '../../../../responsePayload';
@@ -23,16 +22,9 @@ export const retryJeScheduleEpic = (actions$, state$, zeniAPI) => actions$.pipe(
         .pipe(mergeMap((response) => {
         if (isSuccessStatus(response)) {
             const updateActions = [];
-            // Retire this entry, and the schedule itself only when this was its last failed
-            // one. A schedule that failed in several months is several rows sharing one
-            // schedule key, so dropping the key outright took the still-failing months off the
-            // list with it and nothing would have surfaced them again.
-            const failedEntriesForSchedule = state.jeSchedulesState.schedulesByTransactionKey[jeScheduleTransactionKey]?.scheduledJournalEntry ?? [];
-            const wasLastFailedEntryForSchedule = failedEntriesForSchedule.filter((journalEntry) => journalEntry.scheduledJournalEntryID !==
-                scheduledJournalEntryID).length === 0;
             updateActions.push(retryJeScheduleSuccess({
                 scheduledJournalEntryID,
-            }), removeScheduledJournalEntryFromJESchedule(jeScheduleTransactionKey, scheduledJournalEntryID), removeJeScheduleLocalDataById({ scheduledJournalEntryID }), // Important to remove localdata after success.
+            }), removeFailedJeScheduleTransactionKey(jeScheduleTransactionKey, selectedPeriod), removeJeScheduleLocalDataById({ scheduledJournalEntryID }), // Important to remove localdata after success.
             fetchMonthEndCloseChecks({
                 tenantId: currentTenant.tenantId,
                 period: selectedPeriod,
@@ -42,9 +34,6 @@ export const retryJeScheduleEpic = (actions$, state$, zeniAPI) => actions$.pipe(
                 messageText: 'success',
                 type: 'success',
             }));
-            if (wasLastFailedEntryForSchedule) {
-                updateActions.push(removeFailedJeScheduleTransactionKey(jeScheduleTransactionKey, selectedPeriod));
-            }
             return from(updateActions);
         }
         else {

package/lib/esm/view/expenseAutomationView/epics/transactionCategorization/fetchTransactionCategorizationEpic.js

@@ -6,7 +6,6 @@ import { updateTransactions } from '../../../../entity/transaction/transactionRe
 import { createZeniAPIStatus, isSuccessResponse, } from '../../../../responsePayload';
 import { getLineItemsByTransactionsIdsFromResponse } from '../../helpers/transactionCategorizationLocalDataHelper';
 import { fetchTransactionCategorization, fetchTransactionCategorizationFailure, fetchTransactionCategorizationSuccess, initializeTransactionCategorizationViewLocalData, resetOtherTabsFetchState, updateParentTotalCountForTab, updateTotalCountForTransactionCategorization, updateTransactionCategorizationUIState, } from '../../reducers/transactionsViewReducer';
-import { DEFAULT_COMPLETED_SUB_TAB } from '../../types/completedSubTab';
 import { TRANSACTIONS_TABS, toTransactionsSortKey, } from '../../types/transactionsViewState';
 export const fetchTransactionCategorizationEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(fetchTransactionCategorization.match), 
 // Per-tab switchMap: cancels in-flight requests for the same tab on a new
@@ -33,9 +32,10 @@ groupBy((action) => action.payload.selectedTab), mergeMap((group$) => group$.pip
         // cross-status search (omit or true) is reserved for Receipts
         // manual-match.
         search_all_statuses: false,
-        sub_tab: selectedTab === 'autoCategorized'
-            ? expenseAutomationTransactionsViewState.selectedTransactionCategorizationCompletedSubTab
-            : DEFAULT_COMPLETED_SUB_TAB,
+        // Sent on both tabs: the backend ignores it for Review's own rows but uses
+        // it to scope the Completed badge it returns alongside them.
+        sub_tab: expenseAutomationTransactionsViewState
+            .selectedTransactionCategorizationCompletedSubTab,
         transaction_group: expenseAutomationTransactionsViewState.selectedTransactionGroup,
     };
     return zeniAPI
@@ -87,6 +87,17 @@ groupBy((action) => action.payload.selectedTab), mergeMap((group$) => group$.pip
                 parentTotalCount: response.data.parent_tab_total_count ??
                     response.data.total_count,
             }));
+            // The inactive tab's badge, counted under the same filters. Absent on
+            // pages after the first and on the cross-tab search path, where the
+            // last known value stays correct.
+            const otherTabTotalCount = response.data.other_tab_total_count;
+            if (otherTabTotalCount != null) {
+                updateActions.push(updateParentTotalCountForTab({
+                    selectedPeriod,
+                    selectedTab: selectedTab === 'review' ? 'autoCategorized' : 'review',
+                    parentTotalCount: otherTabTotalCount,
+                }));
+            }
             updateActions.push(resetOtherTabsFetchState({
                 refreshViewInBackground,
                 tabs: TRANSACTIONS_TABS.filter((tab) => selectedTab !== tab),

package/lib/esm/view/expenseAutomationView/reducers/jeSchedulesViewReducer.js

@@ -62,10 +62,6 @@ export const initialState = {
     jeScheduleAccruedKeysByPeriodAndTab: {},
     jeScheduleOneTimeAccrualKeysByPeriodAndTab: {},
     failedJeScheduleTransactionKeysByPeriodAndTab: {},
-    failedJePostings: {
-        fetchState: { fetchState: 'Not-Started', error: undefined },
-        jeScheduleTransactionKeys: [],
-    },
     postStatusById: {},
     ignoreStatusById: {},
     revertStatusById: {},
@@ -75,9 +71,6 @@ export const initialState = {
     oneTimeAccrualFetchStatusById: {},
     uiState: {
         createdGroupCollapsed: false,
-        // Expanded, like the other two. A failed posting is the only thing on this page that is
-        // actively wrong, so folding it away by default would hide the reason to open the tab.
-        failedGroupCollapsed: false,
         pendingGroupCollapsed: false,
         scrollPosition: { scrollTop: 0, scrollLeft: undefined },
         searchString: '',
@@ -149,53 +142,6 @@ const expenseAutomationJESchedulesView = createSlice({
                 };
             },
         },
-        /**
-         * The Failed Postings list, fetched separately from the schedules it belongs to.
-         *
-         * No period and no tab in any of these three: the endpoint applies no date window, so there is
-         * one list per tenant and one slot to hold it. `refreshInBackground` keeps a silent refetch
-         * from dropping a skeleton over rows already on screen, the same way refreshStatus does for
-         * the schedules list.
-         */
-        fetchFailedJePostings: {
-            reducer(draft, action) {
-                if (!action.payload.refreshInBackground) {
-                    draft.failedJePostings.fetchState = {
-                        fetchState: 'In-Progress',
-                        error: undefined,
-                    };
-                }
-            },
-            prepare(refreshInBackground = false) {
-                return { payload: { refreshInBackground } };
-            },
-        },
-        fetchFailedJePostingsSuccess: {
-            reducer(draft, action) {
-                draft.failedJePostings = {
-                    fetchState: { fetchState: 'Completed', error: undefined },
-                    jeScheduleTransactionKeys: action.payload.failedJeSchedules.map((schedule) => getJEScheduleTransactionDetailKeyPayload(schedule.base_transaction)),
-                };
-            },
-            prepare(failedJeSchedules) {
-                return { payload: { failedJeSchedules } };
-            },
-        },
-        fetchFailedJePostingsFailure: {
-            reducer(draft, action) {
-                // Keys are deliberately left alone. The schedules list clears its buckets on failure so an
-                // errored tab cannot read as "these are all the schedules there are", but this list is a
-                // set of outstanding problems -- showing the last known ones beside an error beats
-                // implying there are none.
-                draft.failedJePostings.fetchState = {
-                    fetchState: 'Error',
-                    error: action.payload.status,
-                };
-            },
-            prepare(status) {
-                return { payload: { status } };
-            },
-        },
         fetchJeSchedulesSuccess(draft, action) {
             const { jeSchedules, selectedPeriod, selectedPageTab, failedJeSchedules, accruedJeSchedules, oneTimeAccruals, refreshViewInBackground, } = action.payload;
             const periodTabKey = getJESchedulePeriodTabKey(selectedPageTab, toMonthYearPeriodId(selectedPeriod));
@@ -412,8 +358,6 @@ const expenseAutomationJESchedulesView = createSlice({
             reducer(draft, action) {
                 const { failedJeScheduleKey } = action.payload;
                 removeKeyFromEveryTabSlot(draft.failedJeScheduleTransactionKeysByPeriodAndTab, failedJeScheduleKey);
-                draft.failedJePostings.jeScheduleTransactionKeys =
-                    draft.failedJePostings.jeScheduleTransactionKeys.filter((jeScheduleKey) => jeScheduleKey !== failedJeScheduleKey);
             },
         },
         initializeJeScheduleLocalData: {
@@ -756,9 +700,6 @@ const expenseAutomationJESchedulesView = createSlice({
             draft.uiState.createdGroupCollapsed =
                 !draft.uiState.createdGroupCollapsed;
         },
-        toggleJEFailedGroupCollapsed(draft) {
-            draft.uiState.failedGroupCollapsed = !draft.uiState.failedGroupCollapsed;
-        },
         clearExpenseAutomationJESchedulesView(draft) {
             Object.assign(draft, initialState);
         },
@@ -769,7 +710,7 @@ const expenseAutomationJESchedulesView = createSlice({
         });
     },
 });
-export const { clearExpenseAutomationJESchedulesView, clearJeAccountSettingsLocalData, clearJeScheduleLocalData, clearSearchTransactionsForNewSchedule, createOneTimeAccrual, createOneTimeAccrualFailure, createOneTimeAccrualSuccess, ignoreOneTimeAccrual, oneTimeAccrualActionFailure, oneTimeAccrualActionSuccess, promoteOneTimeAccrual, revertJeSchedule, revertJeScheduleFailure, revertJeScheduleSuccess, revertOneTimeAccrual, fetchAccountSettingsListForAccountTypes, fetchJeSchedules, fetchFailedJePostings, fetchFailedJePostingsFailure, fetchFailedJePostingsSuccess, fetchJeSchedulesFailure, fetchJeSchedulesPage, fetchJeSchedulesSuccess, fetchOneTimeAccrual, fetchOneTimeAccrualFailure, fetchOneTimeAccrualSuccess, fetchRecommendationForAccountSettings, ignoreRecommendedJeSchedule, ignoreRecommendedJeScheduleFailure, ignoreRecommendedJeScheduleSuccess, initializeAccountSettingsView, initializeJeScheduleLocalData, initializeNewSchedule, removeFailedJeScheduleTransactionKey, removeJeOneTimeAccrualLocalData, removeJeScheduleLocalDataById, removeJeAccruedScheduleKey, removeJeScheduleTransactionKey, resetNewScheduleLocalData, retryJeSchedule, retryJeScheduleFailure, retryJeScheduleSuccess, saveAccountSettings, saveAccountSettingsFailure, saveAccountSettingsLocalData, saveAccountSettingsSuccess, saveNewSchedule, saveNewScheduleFailure, saveNewScheduleSuccess, searchTransactionsForNewSchedule, searchTransactionsForNewScheduleFailure, searchTransactionsForNewScheduleSuccess, toggleJECreatedGroupCollapsed, toggleJEFailedGroupCollapsed, toggleJEPendingGroupCollapsed, updateAccountSettingsListForAccountTypes, updateAccountSettingsListForAccountTypesFailure, updateJESchedulesUIState, updateJEScheduleTypeFilter, updateJeOneTimeAccrualLocalData, updateJeScheduleLocalDataById, updateJeScheduleTransactionKeys, updateNewScheduleLocalData, updateRecommendationForAccountSettings, updateRecommendationForAccountSettingsFailure, } = expenseAutomationJESchedulesView.actions;
+export const { clearExpenseAutomationJESchedulesView, clearJeAccountSettingsLocalData, clearJeScheduleLocalData, clearSearchTransactionsForNewSchedule, createOneTimeAccrual, createOneTimeAccrualFailure, createOneTimeAccrualSuccess, ignoreOneTimeAccrual, oneTimeAccrualActionFailure, oneTimeAccrualActionSuccess, promoteOneTimeAccrual, revertJeSchedule, revertJeScheduleFailure, revertJeScheduleSuccess, revertOneTimeAccrual, fetchAccountSettingsListForAccountTypes, fetchJeSchedules, fetchJeSchedulesFailure, fetchJeSchedulesPage, fetchJeSchedulesSuccess, fetchOneTimeAccrual, fetchOneTimeAccrualFailure, fetchOneTimeAccrualSuccess, fetchRecommendationForAccountSettings, ignoreRecommendedJeSchedule, ignoreRecommendedJeScheduleFailure, ignoreRecommendedJeScheduleSuccess, initializeAccountSettingsView, initializeJeScheduleLocalData, initializeNewSchedule, removeFailedJeScheduleTransactionKey, removeJeOneTimeAccrualLocalData, removeJeScheduleLocalDataById, removeJeAccruedScheduleKey, removeJeScheduleTransactionKey, resetNewScheduleLocalData, retryJeSchedule, retryJeScheduleFailure, retryJeScheduleSuccess, saveAccountSettings, saveAccountSettingsFailure, saveAccountSettingsLocalData, saveAccountSettingsSuccess, saveNewSchedule, saveNewScheduleFailure, saveNewScheduleSuccess, searchTransactionsForNewSchedule, searchTransactionsForNewScheduleFailure, searchTransactionsForNewScheduleSuccess, toggleJECreatedGroupCollapsed, toggleJEPendingGroupCollapsed, updateAccountSettingsListForAccountTypes, updateAccountSettingsListForAccountTypesFailure, updateJESchedulesUIState, updateJEScheduleTypeFilter, updateJeOneTimeAccrualLocalData, updateJeScheduleLocalDataById, updateJeScheduleTransactionKeys, updateNewScheduleLocalData, updateRecommendationForAccountSettings, updateRecommendationForAccountSettingsFailure, } = expenseAutomationJESchedulesView.actions;
 export default expenseAutomationJESchedulesView.reducer;
 const doUpdateRecommendationForAccountSettings = (draft, payload) => {
     const { prepaidExpensesRecommendations, fixedAssetsRecommendations, accruedExpensesRecommendations, } = mapAccountTypeRecommendationPayloadToAccountRecommendationByType(payload);

package/lib/esm/view/expenseAutomationView/reducers/transactionsViewReducer.js

@@ -373,6 +373,16 @@ const expenseAutomationTransactionsView = createSlice({
                 if (cached != null) {
                     autoCat.uiState.pageToken = cached.pageToken;
                     autoCat.uiState.totalCount = { ...cached.totalCount };
+                    // Keep the stored badge in step with the restored sub-tab: the selector
+                    // falls back to it for any period this sub-tab has not loaded. Merged,
+                    // not replaced -- the snapshot only holds periods this sub-tab actually
+                    // loaded, while the badge map also carries periods filled from a Review
+                    // response's `other_tab_total_count`. Overwriting would drop those and
+                    // leave the badge at 0 for any period this sub-tab never visited.
+                    draft.parentTotalCountByTab.autoCategorized = {
+                        ...draft.parentTotalCountByTab.autoCategorized,
+                        ...cached.totalCount,
+                    };
                     autoCat.uiState.scrollPosition = cached.scrollPosition;
                     autoCat.transactionIdsBySelectedPeriod = {
                         ...cached.transactionIdsBySelectedPeriod,

package/lib/esm/view/expenseAutomationView/selectors/jeSchedulesViewSelector.js

@@ -210,7 +210,7 @@ export function getExpenseAutomationJESchedulesView(state) {
     const accruedSchedules = [];
     const oneTimeAccruals = [];
     const { accountState, accountListState, classState, classListState, expenseAutomationJESchedulesViewState, expenseAutomationViewState, monthEndCloseChecksState, } = state;
-    const { jeScheduleTransactionKeysByPeriodAndTab, jeScheduleAccruedKeysByPeriodAndTab, jeScheduleOneTimeAccrualKeysByPeriodAndTab, failedJePostings, jeScheduleLocalDataById, postStatusById, ignoreStatusById, revertStatusById, oneTimeAccrualActionStatusById, uiState, error, fetchState, refreshStatus, newSchedule, } = expenseAutomationJESchedulesViewState;
+    const { jeScheduleTransactionKeysByPeriodAndTab, jeScheduleAccruedKeysByPeriodAndTab, jeScheduleOneTimeAccrualKeysByPeriodAndTab, failedJeScheduleTransactionKeysByPeriodAndTab, jeScheduleLocalDataById, postStatusById, ignoreStatusById, revertStatusById, oneTimeAccrualActionStatusById, uiState, error, fetchState, refreshStatus, newSchedule, } = expenseAutomationJESchedulesViewState;
     const accountSettingsView = getJEAccountSettingsView(state);
     const newScheduleView = newSchedule.selectedDetailScheduleType === 'fixed_assets' ||
         newSchedule.selectedDetailScheduleType === 'prepaid_expenses'
@@ -249,11 +249,15 @@ export function getExpenseAutomationJESchedulesView(state) {
     const jeScheduleTransactionKeysForSelectedTab = selectedPeriodTabKey != null
         ? jeScheduleTransactionKeysByPeriodAndTab[selectedPeriodTabKey]
         : undefined;
+    const failedJeScheduleTransactionKeysForSelectedTab = selectedPeriodTabKey != null
+        ? failedJeScheduleTransactionKeysByPeriodAndTab[selectedPeriodTabKey]
+        : undefined;
     // Distinguishes "this tab has never been fetched for this period" from "fetched and genuinely
     // empty". Without it the page cannot tell a first visit from a real empty state, and renders an
     // empty table where it should render a skeleton.
     const hasLoadedForSelectedTab = jeScheduleTransactionKeysForSelectedTab != null;
     const jeScheduleTransactionKeys = jeScheduleTransactionKeysForSelectedTab ?? [];
+    const failedJeScheduleTransactionKeys = failedJeScheduleTransactionKeysForSelectedTab ?? [];
     const jeScheduleAccruedKeys = (selectedPeriodTabKey != null
         ? jeScheduleAccruedKeysByPeriodAndTab[selectedPeriodTabKey]
         : undefined) ?? [];
@@ -276,34 +280,24 @@ export function getExpenseAutomationJESchedulesView(state) {
             accruedSchedules.push(accruedScheduleDetails);
         }
     });
-    // Sourced from the tenant-wide bucket, not the per-period one: a failed posting belongs to no
-    // close month, and windowing it is what kept older failures off the only tab that can resolve
-    // them.
-    failedJePostings.jeScheduleTransactionKeys.forEach((jeScheduleKey) => {
+    failedJeScheduleTransactionKeys.forEach((jeScheduleKey) => {
         const jeScheduleDetails = getJEScheduledTransactionByJEScheduleTransactionKey(jeScheduleKey, state);
         failedJeScheduledTransaction.push(jeScheduleDetails);
     });
     const { sortKey, sortOrder, selectedJETypeFilter } = uiState;
-    const matchesTypeFilter = (schedule) => selectedJETypeFilter == null ||
-        getJEScheduleRowType(schedule) === selectedJETypeFilter;
     const unsortedResolveSchedules = [];
     failedJeScheduledTransaction.forEach((schedule) => {
-        // Only the entries that actually carry an error. The schedule's entry array is shared state:
-        // opening a schedule's detail page or Quick View replaces it with every month the schedule
-        // has, posted ones included, so fanning out over all of them turned one failed posting into a
-        // row per month -- and a month that never failed has nothing to resolve, so it rendered with
-        // an empty action column. Keying on `error` also makes the list self-correcting: an entry the
-        // server no longer reports as failing drops out on the next fetch.
-        schedule.scheduledJournalEntry
-            .filter((journalEntry) => journalEntry.error.length > 0)
-            .forEach((journalEntry) => {
+        schedule.scheduledJournalEntry.forEach((journalEntry) => {
             unsortedResolveSchedules.push({
                 ...schedule,
                 scheduledJournalEntry: journalEntry,
             });
         });
     });
-    const resolveSchedules = sortJEScheduledTransactions(unsortedResolveSchedules.filter(matchesTypeFilter), sortKey, sortOrder);
+    const resolveSchedules = sortJEScheduledTransactions(unsortedResolveSchedules, sortKey, sortOrder);
+    const validResolveForPending = unsortedResolveSchedules.filter((r) => jeScheduleLocalDataById[r.scheduledJournalEntry.scheduledJournalEntryID] != null);
+    const matchesTypeFilter = (schedule) => selectedJETypeFilter == null ||
+        getJEScheduleRowType(schedule) === selectedJETypeFilter;
     const isCreatedStatus = (schedule) => {
         // An accrual is "created" once it is not review work: posted, reversing, reversed, or in a
         // transient posting claim.
@@ -321,6 +315,7 @@ export function getExpenseAutomationJESchedulesView(state) {
     ];
     const pendingReviewSchedules = sortJEScheduledTransactions([
         ...allScheduleRows.filter((schedule) => isPendingReviewRow(schedule) && matchesTypeFilter(schedule)),
+        ...validResolveForPending,
     ], sortKey, sortOrder);
     const createdSchedules = sortJEScheduledTransactions(allScheduleRows.filter((schedule) => isCreatedStatus(schedule) && matchesTypeFilter(schedule)), sortKey, sortOrder);
     // KPI summary — derived from unfiltered schedules so counts are always accurate
@@ -439,9 +434,6 @@ export function getExpenseAutomationJESchedulesView(state) {
         kpiSummary,
         pendingReviewSchedules,
         pendingReviewTotal,
-        failedPostings: resolveSchedules,
-        // Deprecated alias of failedPostings. Still read by the section's footer-form effect and by
-        // app-ui analytics; remove once both are repointed.
         resolveSchedules: resolveSchedules,
         accountSettingsView,
         newScheduleView,

package/lib/esm/view/expenseAutomationView/selectors/transactionCategorizationSelector.js

@@ -1,6 +1,6 @@
 import { createSelector } from '@reduxjs/toolkit';
 import omit from 'lodash/omit';
-import { toMonthYearPeriodId } from '../../../commonStateTypes/timePeriod';
+import { toMonthYearPeriodId, } from '../../../commonStateTypes/timePeriod';
 import { getCurrentTenant, getIsAccountingProjectsEnabled, } from '../../../entity/tenant/tenantSelector';
 import { getTransactionWithCOT } from '../../../entity/transaction/transactionHelper';
 import { getSupportedTransactionsByIds } from '../../../entity/transaction/transactionSelector';
@@ -172,18 +172,35 @@ export function getExpenseAutomationTransactionView(state) {
         review: monthYearPeriodId != null ? totalCountByReview[monthYearPeriodId] : 0,
         autoCategorized: monthYearPeriodId != null ? totalCountByAutoCat[monthYearPeriodId] : 0,
     };
-    // Parent-tab badge counts. Sourced from `parent_tab_total_count` in the
-    // listing response and used exclusively by the navbar / tab strip badges.
-    // Independent of which Completed sub-tab is active so the badge stays
-    // stable across sub-tab switches.
+    // Tab badge counts, used exclusively by the navbar / tab strip badges. Both
+    // tabs are counted under the filters applied to the list, so a badge always
+    // equals the number of rows that tab shows.
+    //
+    // The ACTIVE tab prefers its own list count: the two are the same number (the
+    // backend's parent_tab_total_count mirrors total_count), but `uiState.totalCount`
+    // is restored by every cache path that skips a fetch -- switching back to an
+    // already-loaded period, or to a cached Completed sub-tab -- whereas the stored
+    // badge is only written when a response lands, so on those paths it would keep
+    // showing whatever was fetched last.
+    //
+    // The `in` check is load-bearing, not defensive: `totalCount` is a per-period
+    // map typed as `Record<MonthYearPeriodId, number>`, so indexing it is typed
+    // `number` but is `undefined` for any period the active (sub-)tab has not
+    // loaded -- the window between switching to a fresh sub-tab and its response
+    // landing. Falling back to the stored badge there keeps a real number in the
+    // label instead of blanking it.
     const parentTotalCountByTab = expenseAutomationTransactionsViewState.parentTotalCountByTab;
+    const storedBadgeByTab = (tab) => monthYearPeriodId != null
+        ? (parentTotalCountByTab[tab][monthYearPeriodId] ?? 0)
+        : 0;
+    const badgeForTab = (tab, listCountByPeriod) => selectedTransactionCategorizationTab === tab &&
+        monthYearPeriodId != null &&
+        monthYearPeriodId in listCountByPeriod
+        ? listCountByPeriod[monthYearPeriodId]
+        : storedBadgeByTab(tab);
     const parentTabTotalCountByTab = {
-        review: monthYearPeriodId != null
-            ? (parentTotalCountByTab.review[monthYearPeriodId] ?? 0)
-            : 0,
-        autoCategorized: monthYearPeriodId != null
-            ? (parentTotalCountByTab.autoCategorized[monthYearPeriodId] ?? 0)
-            : 0,
+        review: badgeForTab('review', totalCountByReview),
+        autoCategorized: badgeForTab('autoCategorized', totalCountByAutoCat),
     };
     const fetchStateByTab = {
         review: {

package/lib/esm/view/invoicing/editInvoicingCatalogItemDetailView/editInvoicingCatalogItemDetailViewPayload.js

@@ -130,26 +130,50 @@ export const localDataToSaveInvoicingCatalogItemPayload = (localData, isCreate,
     const subFamilies = localData.subFamilies.length > 0
         ? localData.subFamilies
         : [blankInvoicingCatalogSubFamily()];
-    itemPayload.sub_families = isCreate
-        ? subFamilies.map((subFamily) => buildSubFamilyPayload(localData, subFamily, false, lookup))
-        : subFamilies.map((subFamily) => {
-            // Edits send the same body a create does. The narrower hand-built one
-            // this replaces had to be kept in step by hand and was not: it dropped
-            // `accounting_detail` once, and `billing_cycles`, `price`,
-            // `pricing_model`, `period`, the trial fields, `proration_type`,
-            // `free_quantity`, `is_taxable` and `tiers` were never added at all, so
-            // editing any of them looked saved and changed nothing.
-            const detail = buildSubFamilyPayload(localData, subFamily, true, lookup);
-            // `null` rather than omitted when empty: an absent key on an update
-            // reads as "leave it alone", which would make a cleared mapping
-            // impossible to save — the same reason `description` and
-            // `invoice_notes` are cleared rather than dropped above.
-            detail.accounting_detail = detail.accounting_detail ?? null;
-            // A price point added on this form has no id yet, and travels with a
-            // blank one. The update endpoint reads that as "create this one", so it
-            // lands in the same request as the edits around it rather than a second
-            // call that could fail on its own.
-            return { ...detail, id: subFamily.id.trim() };
-        });
+    if (isCreate) {
+        itemPayload.sub_families = subFamilies.map((subFamily) => buildSubFamilyPayload(localData, subFamily, false, lookup));
+        return itemPayload;
+    }
+    // Only price points the service has already stored travel in an update: it
+    // addresses them by id, and a blank one has nothing to address. A price point
+    // added on the form is created by its own request once the item is saved,
+    // rather than riding along as a row the update cannot place.
+    itemPayload.sub_families = subFamilies
+        .filter((subFamily) => subFamily.id !== '')
+        .map((subFamily) => {
+        // Edits send the same body a create does. The narrower hand-built one
+        // this replaces had to be kept in step by hand and was not: it dropped
+        // `accounting_detail` once, and `billing_cycles`, `price`,
+        // `pricing_model`, `period`, the trial fields, `proration_type`,
+        // `free_quantity`, `is_taxable` and `tiers` were never added at all, so
+        // editing any of them looked saved and changed nothing.
+        const detail = buildSubFamilyPayload(localData, subFamily, true, lookup);
+        // `null` rather than omitted when empty: an absent key on an update
+        // reads as "leave it alone", which would make a cleared mapping
+        // impossible to save — the same reason `description` and
+        // `invoice_notes` are cleared rather than dropped above.
+        detail.accounting_detail = detail.accounting_detail ?? null;
+        // Never blank: the filter above leaves only price points the service has
+        // already stored, which is the only kind an update can address.
+        return { ...detail, id: subFamily.id };
+    });
     return itemPayload;
 };
+/**
+ * The bodies that create the price points added on an edit form, one per
+ * request to `/catalog/products`.
+ *
+ * An update cannot carry them: it addresses price points by id, and these have
+ * none until the service assigns one. They are bound to their item by
+ * `item_id`, so this needs the saved item's id and runs after the item itself
+ * is saved.
+ *
+ * Empty values are left off rather than sent as `null`: there is nothing on a
+ * price point that does not exist yet to clear.
+ */
+export const localDataToCreateInvoicingCatalogProductPayloads = (localData, itemId, lookup) => localData.subFamilies
+    .filter((subFamily) => subFamily.id === '')
+    .map((subFamily) => ({
+    ...buildSubFamilyPayload(localData, subFamily, false, lookup),
+    item_id: itemId,
+}));

package/lib/esm/view/invoicing/editInvoicingCatalogItemDetailView/editInvoicingCatalogItemDetailViewReducer.js

@@ -1,6 +1,6 @@
 import { createSlice } from '@reduxjs/toolkit';
 import { clearAll } from '../../../rootActions';
-import { applyInvoicingFormDraftEdit, applyInvoicingFormDraftFailure, applyInvoicingFormDraftSeed, } from '../invoicingFormDraft';
+import { applyInvoicingFormDraftEdit, applyInvoicingFormDraftFailure, applyInvoicingFormDraftSaved, applyInvoicingFormDraftSeed, } from '../invoicingFormDraft';
 import { initialInvoicingCatalogItemFormLocalData } from './invoicingCatalogItemFormHelper';
 export const initialState = {
     fetchState: 'Not-Started',
@@ -43,6 +43,9 @@ const editInvoicingCatalogItemDetailView = createSlice({
             draft.error = undefined;
             draft.savedItemId = action.payload.itemId;
             draft.savedKind = action.payload.kind;
+            // An edit is refetched on success; keep the saved values on screen until
+            // that lands, and let it replace them.
+            applyInvoicingFormDraftSaved(draft.editDraftById, action.payload.itemId);
         },
         submitInvoicingCatalogItemFormFailure(draft, action) {
             draft.fetchState = 'Error';

package/lib/esm/view/invoicing/editInvoicingCatalogItemDetailView/editInvoicingCatalogItemDetailViewSelector.js

@@ -3,7 +3,7 @@ import { reduceAllFetchState } from '../../../commonStateTypes/reduceFetchState'
 import { getInvoicingPlanById, getInvoicingPlansByIds, } from '../../../entity/invoicing/plan/planSelector';
 import { getInvoicingConfigView, invoicingFieldHelpForGroup, } from '../invoicingConfigView/invoicingConfigViewSelector';
 import { getInvoicingFormDraftLocalData, isInvoicingFormDraftPending, } from '../invoicingFormDraft';
-import { getInvoicingQboView, isInvoicingAccountingPickerDataLoading, isInvoicingQboConnected, } from '../invoicingQboView/invoicingQboViewSelector';
+import { INVOICING_DEFAULT_INCOME_ACCOUNT_TYPES, INVOICING_INCOME_ACCOUNT_MAPPING_SLOT, NO_INVOICING_ACCOUNT_HIERARCHY, NO_INVOICING_ACCOUNT_IDS, NO_INVOICING_CLASS_HIERARCHY, getInvoicingQboAccountOptions, getInvoicingQboView, invoicingQboAccountIdsForMappingSlot, isInvoicingAccountingPickerDataLoading, isInvoicingQboConnected, } from '../invoicingQboView/invoicingQboViewSelector';
 import { INVOICING_CATALOG_APPLICABILITY_VALUES, INVOICING_CATALOG_PRICING_MODEL_VALUES, INVOICING_CATALOG_PRORATION_VALUES, INVOICING_CATALOG_TIER_TYPE_VALUES, initialInvoicingCatalogItemFormLocalData, } from './invoicingCatalogItemFormHelper';
 export const getEditInvoicingCatalogItemDetailViewState = (state) => ({
     fetchState: state.editInvoicingCatalogItemDetailViewState.fetchState,
@@ -44,6 +44,21 @@ const NOT_STARTED = {
     error: undefined,
     fetchState: 'Not-Started',
 };
+/**
+ * The QuickBooks ids a price point's income account may be picked from.
+ *
+ * Memoized, and collapsing to one shared empty array while QBO is disconnected:
+ * the pages turn this into their picker options and re-seed their form defaults
+ * when those change, so a fresh array on every store change would reset the form
+ * under the user — including mid-save.
+ */
+const getInvoicingCatalogIncomeAccountIds = createSelector([
+    getInvoicingQboAccountOptions,
+    (state) => getInvoicingConfigView(state).qboAccountMappingKindOptions,
+    isInvoicingQboConnected,
+], (accounts, qboAccountMappingKindOptions, isQboConnected) => isQboConnected
+    ? invoicingQboAccountIdsForMappingSlot(accounts, qboAccountMappingKindOptions, INVOICING_INCOME_ACCOUNT_MAPPING_SLOT, INVOICING_DEFAULT_INCOME_ACCOUNT_TYPES)
+    : NO_INVOICING_ACCOUNT_IDS);
 export const getInvoicingCatalogItemFormView = (state, id) => {
     const { editDraftById, error, fetchState, newItemDraft, savedItemId, savedKind, } = state.editInvoicingCatalogItemDetailViewState;
     const plan = id != null ? getInvoicingPlanById(state.invoicingPlanState, id) : undefined;
@@ -94,8 +109,9 @@ export const getInvoicingCatalogItemFormView = (state, id) => {
         isFormLoading: isInvoicingAccountingPickerDataLoading(state) ||
             isInvoicingFormDraftPending(editDraftById, id),
         isQboPickerDataLoading: isInvoicingAccountingPickerDataLoading(state),
-        qboAccountHierarchy: qboView?.nestedAccountHierarchy ?? [],
-        qboClassHierarchy: qboView?.nestedClassHierarchy ?? [],
+        qboAccountHierarchy: qboView?.nestedAccountHierarchy ?? NO_INVOICING_ACCOUNT_HIERARCHY,
+        qboClassHierarchy: qboView?.nestedClassHierarchy ?? NO_INVOICING_CLASS_HIERARCHY,
+        qboIncomeAccountIds: getInvoicingCatalogIncomeAccountIds(state),
         applicabilityValues: INVOICING_CATALOG_APPLICABILITY_VALUES,
         applicableItemOptions,
         localData,

package/lib/esm/view/invoicing/editInvoicingCatalogItemDetailView/saveInvoicingCatalogItemEpic.js

@@ -1,4 +1,4 @@
-import { from } from 'rxjs';
+import { forkJoin, from } from 'rxjs';
 import { catchError, filter, mergeMap } from 'rxjs/operators';
 import { mergeInvoicingPlanSubFamily, updateInvoicingPlans, } from '../../../entity/invoicing/plan/planReducer';
 import { updateInvoicingProducts } from '../../../entity/invoicing/product/productReducer';
@@ -7,7 +7,7 @@ import { openSnackbar } from '../../../entity/snackbar/snackbarReducer';
 import { createZeniAPIStatus, isSuccessResponse } from '../../../responsePayload';
 import { addInvoicingCatalogItem } from '../invoicingCatalogListView/invoicingCatalogListViewReducer';
 import { getInvoicingCatalogAccountingLookup } from '../invoicingQboView/invoicingQboViewSelector';
-import { localDataToSaveInvoicingCatalogItemPayload, } from './editInvoicingCatalogItemDetailViewPayload';
+import { localDataToCreateInvoicingCatalogProductPayloads, localDataToSaveInvoicingCatalogItemPayload, } from './editInvoicingCatalogItemDetailViewPayload';
 import { submitInvoicingCatalogItemForm, submitInvoicingCatalogItemFormFailure, submitInvoicingCatalogItemFormSuccess, } from './editInvoicingCatalogItemDetailViewReducer';
 export const saveInvoicingCatalogItemEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter((action) => submitInvoicingCatalogItemForm.match(action)), mergeMap((action) => {
     const { id } = action.payload;
@@ -81,7 +81,20 @@ export const saveInvoicingCatalogItemEpic = (actions$, state$, zeniAPI) => actio
                 }));
                 return resultActions;
             };
-            return completeSave([]);
+            // Price points added on an edit form cannot ride in the update:
+            // it addresses them by id and they have none yet. They are created
+            // against the item that was just saved, and their responses join
+            // the same success — one of them failing is the whole save
+            // failing, since the item on screen would otherwise claim price
+            // points the service never stored. A create needs none of this:
+            // its price points are nested in the item body.
+            const newProductPayloads = id != null
+                ? localDataToCreateInvoicingCatalogProductPayloads(localData, savedItem.id, accountingLookup)
+                : [];
+            if (newProductPayloads.length === 0) {
+                return completeSave([]);
+            }
+            return forkJoin(newProductPayloads.map((productPayload) => zeniAPI.postAndGetJSON(`${baseUrl}/catalog/products`, productPayload))).pipe(mergeMap((productResponses) => completeSave(productResponses)));
         }
         return from([
             submitInvoicingCatalogItemFormFailure(response.status),

package/lib/esm/view/invoicing/editInvoicingCatalogItemDetailView/seedInvoicingCatalogItemFormDraftEpic.js

@@ -23,9 +23,13 @@ export const seedInvoicingCatalogItemFormDraftEpic = (actions$, state$) => actio
     // endpoints merge their own list-shaped rows into the same store. Only a
     // completed detail load does, which is also exactly when the page's
     // cache-guarded fetch issues no request and this is the sole seed.
+    // A forced refetch is the caller asking for fresh data: the response will
+    // seed, and seeding first from the entity as it stands would mark the
+    // draft loaded and lock that response out.
     if (fetchInvoicingCatalogItemDetailPage.match(action) &&
-        state.editInvoicingCatalogItemDetailViewState.recordStateById[id]
-            ?.fetchState !== 'Completed') {
+        (action.payload.cacheOverride === true ||
+            state.editInvoicingCatalogItemDetailViewState.recordStateById[id]
+                ?.fetchState !== 'Completed')) {
         return EMPTY;
     }
     // Nothing to seed from on a cold open; the detail response triggers this

package/lib/esm/view/invoicing/editInvoicingCouponDetailView/editInvoicingCouponDetailViewReducer.js

@@ -1,6 +1,6 @@
 import { createSlice } from '@reduxjs/toolkit';
 import { clearAll } from '../../../rootActions';
-import { applyInvoicingFormDraftEdit, applyInvoicingFormDraftFailure, applyInvoicingFormDraftSeed, } from '../invoicingFormDraft';
+import { applyInvoicingFormDraftEdit, applyInvoicingFormDraftFailure, applyInvoicingFormDraftSaved, applyInvoicingFormDraftSeed, } from '../invoicingFormDraft';
 import { initialInvoicingCouponFormLocalData, } from './editInvoicingCouponDetailViewState';
 export const initialState = {
     fetchState: 'Not-Started',
@@ -51,6 +51,9 @@ const editInvoicingCouponDetailView = createSlice({
             draft.fetchState = 'Completed';
             draft.error = undefined;
             draft.savedCouponId = action.payload.couponId;
+            // An edit is refetched on success; keep the saved values on screen until
+            // that lands, and let it replace them.
+            applyInvoicingFormDraftSaved(draft.editDraftById, action.payload.couponId);
         },
         submitInvoicingCouponFormFailure(draft, action) {
             draft.fetchState = 'Error';