@zeniai/client-epic-state 5.2.51-betaRD1 → 5.2.52-betaRD1

package/lib/esm/view/expenseAutomationView/epics/jeSchedule/initializeJeScheduleLocalDataEpic.js

@@ -22,7 +22,12 @@ export const initializeJeScheduleLocalDataEpic = (actions$, state$) => actions$.
         // Retry button. An empty array is possible when details have not landed yet; it must not
         // throw, because this runs in a mergeMap with no catchError and the throw would take the
         // epic's subscription down for the rest of the session.
-        jeScheduledTransaction.scheduledJournalEntry.forEach((journalEntry) => {
+        // Filtered on `error` for the same reason the selector is: this array is shared state, and
+        // a schedule whose detail page has been opened holds every month it has, posted ones
+        // included. The seeding and the rows must agree on which entries are failed postings.
+        jeScheduledTransaction.scheduledJournalEntry
+            .filter((journalEntry) => journalEntry.error.length > 0)
+            .forEach((journalEntry) => {
             const { scheduledJournalEntryID } = journalEntry;
             actions.push(updateJeScheduleLocalDataById({
                 localData: {

package/lib/esm/view/expenseAutomationView/selectors/jeSchedulesViewSelector.js

@@ -288,7 +288,15 @@ export function getExpenseAutomationJESchedulesView(state) {
         getJEScheduleRowType(schedule) === selectedJETypeFilter;
     const unsortedResolveSchedules = [];
     failedJeScheduledTransaction.forEach((schedule) => {
-        schedule.scheduledJournalEntry.forEach((journalEntry) => {
+        // Only the entries that actually carry an error. The schedule's entry array is shared state:
+        // opening a schedule's detail page or Quick View replaces it with every month the schedule
+        // has, posted ones included, so fanning out over all of them turned one failed posting into a
+        // row per month -- and a month that never failed has nothing to resolve, so it rendered with
+        // an empty action column. Keying on `error` also makes the list self-correcting: an entry the
+        // server no longer reports as failing drops out on the next fetch.
+        schedule.scheduledJournalEntry
+            .filter((journalEntry) => journalEntry.error.length > 0)
+            .forEach((journalEntry) => {
             unsortedResolveSchedules.push({
                 ...schedule,
                 scheduledJournalEntry: journalEntry,

package/lib/view/expenseAutomationView/epics/jeSchedule/initializeJeScheduleLocalDataEpic.js

@@ -25,7 +25,12 @@ const initializeJeScheduleLocalDataEpic = (actions$, state$) => actions$.pipe((0
         // Retry button. An empty array is possible when details have not landed yet; it must not
         // throw, because this runs in a mergeMap with no catchError and the throw would take the
         // epic's subscription down for the rest of the session.
-        jeScheduledTransaction.scheduledJournalEntry.forEach((journalEntry) => {
+        // Filtered on `error` for the same reason the selector is: this array is shared state, and
+        // a schedule whose detail page has been opened holds every month it has, posted ones
+        // included. The seeding and the rows must agree on which entries are failed postings.
+        jeScheduledTransaction.scheduledJournalEntry
+            .filter((journalEntry) => journalEntry.error.length > 0)
+            .forEach((journalEntry) => {
             const { scheduledJournalEntryID } = journalEntry;
             actions.push((0, jeSchedulesViewReducer_1.updateJeScheduleLocalDataById)({
                 localData: {

package/lib/view/expenseAutomationView/selectors/jeSchedulesViewSelector.js

@@ -303,7 +303,15 @@ function getExpenseAutomationJESchedulesView(state) {
         getJEScheduleRowType(schedule) === selectedJETypeFilter;
     const unsortedResolveSchedules = [];
     failedJeScheduledTransaction.forEach((schedule) => {
-        schedule.scheduledJournalEntry.forEach((journalEntry) => {
+        // Only the entries that actually carry an error. The schedule's entry array is shared state:
+        // opening a schedule's detail page or Quick View replaces it with every month the schedule
+        // has, posted ones included, so fanning out over all of them turned one failed posting into a
+        // row per month -- and a month that never failed has nothing to resolve, so it rendered with
+        // an empty action column. Keying on `error` also makes the list self-correcting: an entry the
+        // server no longer reports as failing drops out on the next fetch.
+        schedule.scheduledJournalEntry
+            .filter((journalEntry) => journalEntry.error.length > 0)
+            .forEach((journalEntry) => {
             unsortedResolveSchedules.push({
                 ...schedule,
                 scheduledJournalEntry: journalEntry,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.2.51-betaRD1",
+  "version": "5.2.52-betaRD1",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",