@zeniai/client-epic-state 5.2.5 → 5.2.7-betaAK0

package/lib/view/invoicing/invoicingQboView/epics/fetchInvoicingAccountingPickersEpic.js

@@ -0,0 +1,33 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.fetchInvoicingAccountingPickersEpic = void 0;
+const rxjs_1 = require("rxjs");
+const operators_1 = require("rxjs/operators");
+const accountListReducer_1 = require("../../../accountList/accountListReducer");
+const classListReducer_1 = require("../../../classList/classListReducer");
+const invoicingQboViewReducer_1 = require("../invoicingQboViewReducer");
+const invoicingQboViewSelector_1 = require("../invoicingQboViewSelector");
+// Tops up the shared account and class lists, skipping either when the store
+// already holds it or has it in flight.
+const fetchInvoicingAccountingPickersEpic = (actions$, state$) => actions$.pipe((0, operators_1.filter)(invoicingQboViewReducer_1.fetchInvoicingAccountingPickers.match), (0, operators_1.withLatestFrom)(state$), (0, operators_1.mergeMap)(([, state]) => {
+    const actions = [];
+    const accountList = state.accountListState.byReportId[invoicingQboViewSelector_1.INVOICING_ACCOUNT_LIST_KEY];
+    if (accountList.hasValidState() === false &&
+        accountList.fetchState !== 'In-Progress') {
+        // AP/AR accounts cannot back an invoicing mapping, so they are excluded
+        // here — which is why this uses invoicing's own bucket rather than the
+        // general `accountList` other screens fill without those exclusions.
+        actions.push((0, accountListReducer_1.fetchAccountList)(invoicingQboViewSelector_1.INVOICING_ACCOUNT_LIST_KEY, true, true, true));
+    }
+    const classList = state.classListState;
+    if (classList.hasValidState() === false &&
+        classList.fetchState !== 'In-Progress') {
+        // Without deleted classes, matching almost every other caller of this
+        // single global slice. Asking for deleted rows here would have handed
+        // them to the vendor and transaction screens too — and the picker
+        // filters deleted classes out anyway, so there is nothing to gain.
+        actions.push((0, classListReducer_1.fetchClassList)());
+    }
+    return actions.length > 0 ? (0, rxjs_1.from)(actions) : rxjs_1.EMPTY;
+}));
+exports.fetchInvoicingAccountingPickersEpic = fetchInvoicingAccountingPickersEpic;

package/lib/view/invoicing/invoicingQboView/epics/invoicingQboViewActionType.d.ts

@@ -1,3 +1,5 @@
 import { openSnackbar } from '../../../../entity/snackbar/snackbarReducer';
-import { fetchInvoicingQboAccounts, fetchInvoicingQboClasses, fetchInvoicingQboConnection, fetchInvoicingQboSyncHealth, retryInvoicingQboSyncTask, retryInvoicingQboSyncTaskFailure, retryInvoicingQboSyncTaskSuccess, startInvoicingQboBackfill, startInvoicingQboBackfillFailure, startInvoicingQboBackfillSuccess, updateInvoicingQboAccounts, updateInvoicingQboAccountsFailure, updateInvoicingQboClasses, updateInvoicingQboClassesFailure, updateInvoicingQboConnection, updateInvoicingQboConnectionFailure, updateInvoicingQboSyncHealth, updateInvoicingQboSyncHealthFailure } from '../invoicingQboViewReducer';
-export type InvoicingQboViewActionType = ReturnType<typeof openSnackbar> | ReturnType<typeof fetchInvoicingQboConnection> | ReturnType<typeof updateInvoicingQboConnection> | ReturnType<typeof updateInvoicingQboConnectionFailure> | ReturnType<typeof fetchInvoicingQboAccounts> | ReturnType<typeof updateInvoicingQboAccounts> | ReturnType<typeof updateInvoicingQboAccountsFailure> | ReturnType<typeof fetchInvoicingQboClasses> | ReturnType<typeof updateInvoicingQboClasses> | ReturnType<typeof updateInvoicingQboClassesFailure> | ReturnType<typeof fetchInvoicingQboSyncHealth> | ReturnType<typeof updateInvoicingQboSyncHealth> | ReturnType<typeof updateInvoicingQboSyncHealthFailure> | ReturnType<typeof retryInvoicingQboSyncTask> | ReturnType<typeof retryInvoicingQboSyncTaskSuccess> | ReturnType<typeof retryInvoicingQboSyncTaskFailure> | ReturnType<typeof startInvoicingQboBackfill> | ReturnType<typeof startInvoicingQboBackfillSuccess> | ReturnType<typeof startInvoicingQboBackfillFailure>;
+import { fetchAccountList } from '../../../accountList/accountListReducer';
+import { fetchClassList } from '../../../classList/classListReducer';
+import { fetchInvoicingAccountingPickers, fetchInvoicingQboConnection, fetchInvoicingQboSyncHealth, retryInvoicingQboSyncTask, retryInvoicingQboSyncTaskFailure, retryInvoicingQboSyncTaskSuccess, startInvoicingQboBackfill, startInvoicingQboBackfillFailure, startInvoicingQboBackfillSuccess, updateInvoicingQboConnection, updateInvoicingQboConnectionFailure, updateInvoicingQboSyncHealth, updateInvoicingQboSyncHealthFailure } from '../invoicingQboViewReducer';
+export type InvoicingQboViewActionType = ReturnType<typeof openSnackbar> | ReturnType<typeof fetchInvoicingQboConnection> | ReturnType<typeof updateInvoicingQboConnection> | ReturnType<typeof updateInvoicingQboConnectionFailure> | ReturnType<typeof fetchInvoicingAccountingPickers> | ReturnType<typeof fetchAccountList> | ReturnType<typeof fetchClassList> | ReturnType<typeof fetchInvoicingQboSyncHealth> | ReturnType<typeof updateInvoicingQboSyncHealth> | ReturnType<typeof updateInvoicingQboSyncHealthFailure> | ReturnType<typeof retryInvoicingQboSyncTask> | ReturnType<typeof retryInvoicingQboSyncTaskSuccess> | ReturnType<typeof retryInvoicingQboSyncTaskFailure> | ReturnType<typeof startInvoicingQboBackfill> | ReturnType<typeof startInvoicingQboBackfillSuccess> | ReturnType<typeof startInvoicingQboBackfillFailure>;

package/lib/view/invoicing/invoicingQboView/invoicingQboViewPayload.d.ts

@@ -12,31 +12,6 @@ export interface InvoicingQboConnection {
     realmId?: string;
 }
 export declare function mapInvoicingQboConnection(payload: InvoicingQboConnectionPayload): InvoicingQboConnection;
-/**
- * A single row from the QBO accounts / classes endpoints. The rows carry the
- * QBO id plus one or more name fields depending on the entity — inspect
- * loosely, render the name, submit the id.
- */
-export interface InvoicingQboAccountRowPayload {
-    account_id?: string | null;
-    account_name?: string | null;
-    account_type?: string | null;
-    accounting_class_name?: string | null;
-    fully_qualified_name?: string | null;
-    id?: string | null;
-    name?: string | null;
-    qbo_accounting_class_name?: string | null;
-    qbo_id?: string | null;
-}
-export interface InvoicingQboAccountOption {
-    id: string;
-    name: string;
-    accountType?: string;
-}
-export declare function mapInvoicingQboAccountOptions(rows: InvoicingQboAccountRowPayload[]): InvoicingQboAccountOption[];
-export interface InvoicingQboAccountsPayload {
-    accounts: InvoicingQboAccountRowPayload[];
-}
 export interface InvoicingQboFailedTaskPayload {
     attempts: number;
     entity_id: string;
@@ -73,7 +48,6 @@ export interface InvoicingQboBackfillPayload {
     start_date?: string | null;
 }
 export type InvoicingQboConnectionResponse = ZeniAPIResponse<InvoicingQboConnectionPayload>;
-export type InvoicingQboAccountsResponse = ZeniAPIResponse<InvoicingQboAccountsPayload>;
 export type InvoicingQboSyncHealthResponse = ZeniAPIResponse<InvoicingQboSyncHealthPayload>;
 export type InvoicingQboRetryTaskResponse = ZeniAPIResponse<InvoicingQboRetryTaskPayload>;
 export type InvoicingQboBackfillResponse = ZeniAPIResponse<InvoicingQboBackfillPayload>;

package/lib/view/invoicing/invoicingQboView/invoicingQboViewPayload.js

@@ -1,7 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.mapInvoicingQboConnection = mapInvoicingQboConnection;
-exports.mapInvoicingQboAccountOptions = mapInvoicingQboAccountOptions;
 exports.mapInvoicingQboSyncHealth = mapInvoicingQboSyncHealth;
 function mapInvoicingQboConnection(payload) {
     return {
@@ -11,29 +10,6 @@ function mapInvoicingQboConnection(payload) {
         realmId: payload.realm_id ?? undefined,
     };
 }
-function mapInvoicingQboAccountOptions(rows) {
-    return rows.flatMap((row) => {
-        // Only qbo_id is a valid QBO AccountRef/ClassRef value — platform-internal
-        // ids (account_id / id) are display metadata and must never be submitted.
-        const accountId = row.qbo_id ?? row.id ?? row.account_id ?? '';
-        if (accountId === '') {
-            return [];
-        }
-        const accountName = row.name ??
-            row.account_name ??
-            row.accounting_class_name ??
-            row.qbo_accounting_class_name ??
-            row.fully_qualified_name ??
-            accountId;
-        return [
-            {
-                id: accountId,
-                name: accountName,
-                accountType: row.account_type ?? undefined,
-            },
-        ];
-    });
-}
 function mapInvoicingQboSyncHealth(payload) {
     return {
         connection: payload.connection != null

package/lib/view/invoicing/invoicingQboView/invoicingQboViewReducer.d.ts

@@ -1,16 +1,8 @@
 import { ZeniAPIStatus } from '../../../responsePayload';
-import { InvoicingQboAccountOption, InvoicingQboConnection, InvoicingQboSyncHealth } from './invoicingQboViewPayload';
+import { InvoicingQboConnection, InvoicingQboSyncHealth } from './invoicingQboViewPayload';
 import { InvoicingQboViewState } from './invoicingQboViewState';
 export declare const initialState: InvoicingQboViewState;
-export declare const fetchInvoicingQboConnection: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"invoicingQboView/fetchInvoicingQboConnection">, updateInvoicingQboConnection: import("@reduxjs/toolkit").ActionCreatorWithPayload<InvoicingQboConnection, "invoicingQboView/updateInvoicingQboConnection">, updateInvoicingQboConnectionFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<ZeniAPIStatus<Record<string, unknown>>, "invoicingQboView/updateInvoicingQboConnectionFailure">, fetchInvoicingQboAccounts: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[accountTypes: string], {
-    accountTypes: string;
-}, "invoicingQboView/fetchInvoicingQboAccounts", never, never>, updateInvoicingQboAccounts: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
-    accounts: InvoicingQboAccountOption[];
-    accountTypes: string;
-}, "invoicingQboView/updateInvoicingQboAccounts">, updateInvoicingQboAccountsFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
-    accountTypes: string;
-    status: ZeniAPIStatus;
-}, "invoicingQboView/updateInvoicingQboAccountsFailure">, fetchInvoicingQboClasses: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"invoicingQboView/fetchInvoicingQboClasses">, updateInvoicingQboClasses: import("@reduxjs/toolkit").ActionCreatorWithPayload<InvoicingQboAccountOption[], "invoicingQboView/updateInvoicingQboClasses">, updateInvoicingQboClassesFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<ZeniAPIStatus<Record<string, unknown>>, "invoicingQboView/updateInvoicingQboClassesFailure">, fetchInvoicingQboSyncHealth: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"invoicingQboView/fetchInvoicingQboSyncHealth">, updateInvoicingQboSyncHealth: import("@reduxjs/toolkit").ActionCreatorWithPayload<InvoicingQboSyncHealth, "invoicingQboView/updateInvoicingQboSyncHealth">, updateInvoicingQboSyncHealthFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<ZeniAPIStatus<Record<string, unknown>>, "invoicingQboView/updateInvoicingQboSyncHealthFailure">, retryInvoicingQboSyncTask: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[taskId: string], {
+export declare const fetchInvoicingQboConnection: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"invoicingQboView/fetchInvoicingQboConnection">, updateInvoicingQboConnection: import("@reduxjs/toolkit").ActionCreatorWithPayload<InvoicingQboConnection, "invoicingQboView/updateInvoicingQboConnection">, updateInvoicingQboConnectionFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<ZeniAPIStatus<Record<string, unknown>>, "invoicingQboView/updateInvoicingQboConnectionFailure">, fetchInvoicingAccountingPickers: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"invoicingQboView/fetchInvoicingAccountingPickers">, fetchInvoicingQboSyncHealth: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"invoicingQboView/fetchInvoicingQboSyncHealth">, updateInvoicingQboSyncHealth: import("@reduxjs/toolkit").ActionCreatorWithPayload<InvoicingQboSyncHealth, "invoicingQboView/updateInvoicingQboSyncHealth">, updateInvoicingQboSyncHealthFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<ZeniAPIStatus<Record<string, unknown>>, "invoicingQboView/updateInvoicingQboSyncHealthFailure">, retryInvoicingQboSyncTask: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[taskId: string], {
     taskId: string;
 }, "invoicingQboView/retryInvoicingQboSyncTask", never, never>, retryInvoicingQboSyncTaskSuccess: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
     status: string;

package/lib/view/invoicing/invoicingQboView/invoicingQboViewReducer.js

@@ -1,15 +1,11 @@
 "use strict";
 var _a;
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.startInvoicingQboBackfillFailure = exports.startInvoicingQboBackfillSuccess = exports.startInvoicingQboBackfill = exports.retryInvoicingQboSyncTaskFailure = exports.retryInvoicingQboSyncTaskSuccess = exports.retryInvoicingQboSyncTask = exports.updateInvoicingQboSyncHealthFailure = exports.updateInvoicingQboSyncHealth = exports.fetchInvoicingQboSyncHealth = exports.updateInvoicingQboClassesFailure = exports.updateInvoicingQboClasses = exports.fetchInvoicingQboClasses = exports.updateInvoicingQboAccountsFailure = exports.updateInvoicingQboAccounts = exports.fetchInvoicingQboAccounts = exports.updateInvoicingQboConnectionFailure = exports.updateInvoicingQboConnection = exports.fetchInvoicingQboConnection = exports.initialState = void 0;
+exports.startInvoicingQboBackfillFailure = exports.startInvoicingQboBackfillSuccess = exports.startInvoicingQboBackfill = exports.retryInvoicingQboSyncTaskFailure = exports.retryInvoicingQboSyncTaskSuccess = exports.retryInvoicingQboSyncTask = exports.updateInvoicingQboSyncHealthFailure = exports.updateInvoicingQboSyncHealth = exports.fetchInvoicingQboSyncHealth = exports.fetchInvoicingAccountingPickers = exports.updateInvoicingQboConnectionFailure = exports.updateInvoicingQboConnection = exports.fetchInvoicingQboConnection = exports.initialState = void 0;
 const toolkit_1 = require("@reduxjs/toolkit");
 const rootActions_1 = require("../../../rootActions");
 exports.initialState = {
-    accountsByAccountTypes: {},
-    accountsFetchStateByAccountTypes: {},
     backfillFetchState: { fetchState: 'Not-Started', error: undefined },
-    classes: [],
-    classesFetchState: { fetchState: 'Not-Started', error: undefined },
     connection: undefined,
     connectionFetchState: { fetchState: 'Not-Started', error: undefined },
     retryFetchStateByTaskId: {},
@@ -33,41 +29,8 @@ const invoicingQboView = (0, toolkit_1.createSlice)({
         updateInvoicingQboConnectionFailure(draft, action) {
             draft.connectionFetchState = { fetchState: 'Error', error: action.payload };
         },
-        fetchInvoicingQboAccounts: {
-            reducer(draft, action) {
-                draft.accountsFetchStateByAccountTypes[action.payload.accountTypes] = {
-                    fetchState: 'In-Progress',
-                    error: undefined,
-                };
-            },
-            prepare(accountTypes) {
-                return { payload: { accountTypes } };
-            },
-        },
-        updateInvoicingQboAccounts(draft, action) {
-            draft.accountsByAccountTypes[action.payload.accountTypes] =
-                action.payload.accounts;
-            draft.accountsFetchStateByAccountTypes[action.payload.accountTypes] = {
-                fetchState: 'Completed',
-                error: undefined,
-            };
-        },
-        updateInvoicingQboAccountsFailure(draft, action) {
-            draft.accountsFetchStateByAccountTypes[action.payload.accountTypes] = {
-                fetchState: 'Error',
-                error: action.payload.status,
-            };
-        },
-        fetchInvoicingQboClasses(draft) {
-            draft.classesFetchState = { fetchState: 'In-Progress', error: undefined };
-        },
-        updateInvoicingQboClasses(draft, action) {
-            draft.classes = action.payload;
-            draft.classesFetchState = { fetchState: 'Completed', error: undefined };
-        },
-        updateInvoicingQboClassesFailure(draft, action) {
-            draft.classesFetchState = { fetchState: 'Error', error: action.payload };
-        },
+        // No state of its own: the epic decides which shared lists to load.
+        fetchInvoicingAccountingPickers() { },
         fetchInvoicingQboSyncHealth(draft) {
             draft.syncHealthFetchState = {
                 fetchState: 'In-Progress',
@@ -131,5 +94,5 @@ const invoicingQboView = (0, toolkit_1.createSlice)({
         });
     },
 });
-_a = invoicingQboView.actions, exports.fetchInvoicingQboConnection = _a.fetchInvoicingQboConnection, exports.updateInvoicingQboConnection = _a.updateInvoicingQboConnection, exports.updateInvoicingQboConnectionFailure = _a.updateInvoicingQboConnectionFailure, exports.fetchInvoicingQboAccounts = _a.fetchInvoicingQboAccounts, exports.updateInvoicingQboAccounts = _a.updateInvoicingQboAccounts, exports.updateInvoicingQboAccountsFailure = _a.updateInvoicingQboAccountsFailure, exports.fetchInvoicingQboClasses = _a.fetchInvoicingQboClasses, exports.updateInvoicingQboClasses = _a.updateInvoicingQboClasses, exports.updateInvoicingQboClassesFailure = _a.updateInvoicingQboClassesFailure, exports.fetchInvoicingQboSyncHealth = _a.fetchInvoicingQboSyncHealth, exports.updateInvoicingQboSyncHealth = _a.updateInvoicingQboSyncHealth, exports.updateInvoicingQboSyncHealthFailure = _a.updateInvoicingQboSyncHealthFailure, exports.retryInvoicingQboSyncTask = _a.retryInvoicingQboSyncTask, exports.retryInvoicingQboSyncTaskSuccess = _a.retryInvoicingQboSyncTaskSuccess, exports.retryInvoicingQboSyncTaskFailure = _a.retryInvoicingQboSyncTaskFailure, exports.startInvoicingQboBackfill = _a.startInvoicingQboBackfill, exports.startInvoicingQboBackfillSuccess = _a.startInvoicingQboBackfillSuccess, exports.startInvoicingQboBackfillFailure = _a.startInvoicingQboBackfillFailure;
+_a = invoicingQboView.actions, exports.fetchInvoicingQboConnection = _a.fetchInvoicingQboConnection, exports.updateInvoicingQboConnection = _a.updateInvoicingQboConnection, exports.updateInvoicingQboConnectionFailure = _a.updateInvoicingQboConnectionFailure, exports.fetchInvoicingAccountingPickers = _a.fetchInvoicingAccountingPickers, exports.fetchInvoicingQboSyncHealth = _a.fetchInvoicingQboSyncHealth, exports.updateInvoicingQboSyncHealth = _a.updateInvoicingQboSyncHealth, exports.updateInvoicingQboSyncHealthFailure = _a.updateInvoicingQboSyncHealthFailure, exports.retryInvoicingQboSyncTask = _a.retryInvoicingQboSyncTask, exports.retryInvoicingQboSyncTaskSuccess = _a.retryInvoicingQboSyncTaskSuccess, exports.retryInvoicingQboSyncTaskFailure = _a.retryInvoicingQboSyncTaskFailure, exports.startInvoicingQboBackfill = _a.startInvoicingQboBackfill, exports.startInvoicingQboBackfillSuccess = _a.startInvoicingQboBackfillSuccess, exports.startInvoicingQboBackfillFailure = _a.startInvoicingQboBackfillFailure;
 exports.default = invoicingQboView.reducer;

package/lib/view/invoicing/invoicingQboView/invoicingQboViewSelector.d.ts

@@ -1,21 +1,58 @@
+import { NestedAccountHierarchyForReport } from '../../../commonStateTypes/accountView/nestedAccountID';
+import { NestedClassHierarchyForReport } from '../../../commonStateTypes/classesView/nestedClassID';
 import { FetchStateAndError } from '../../../commonStateTypes/common';
+import { AccountType } from '../../../entity/account/accountState';
 import { RootState } from '../../../rootStateTypes';
-import { InvoicingQboAccountOption, InvoicingQboConnection, InvoicingQboSyncHealth } from './invoicingQboViewPayload';
+import { InvoicingQboConnection, InvoicingQboSyncHealth } from './invoicingQboViewPayload';
+export declare const INVOICING_ACCOUNT_LIST_KEY: "invoicingAccountList";
+/** Whether QBO is connected, without building the option lists to find out. */
+export declare const isInvoicingQboConnected: (state: RootState) => boolean;
+/**
+ * Account types that can back invoicing revenue. Named here so screens ask for
+ * "income accounts" rather than repeating the accounting service's vocabulary.
+ */
+export declare const INVOICING_INCOME_ACCOUNT_TYPES: readonly AccountType[];
+/** An account or class as the invoicing pickers render and submit it. */
+export interface InvoicingAccountingOption {
+    id: string;
+    name: string;
+    accountType?: string;
+}
 export interface InvoicingQboView {
-    accountsByAccountTypes: Record<string, InvoicingQboAccountOption[]>;
-    accountsFetchStateByAccountTypes: Record<string, FetchStateAndError>;
+    accounts: InvoicingAccountingOption[];
+    accountsFetchState: FetchStateAndError;
     backfillState: FetchStateAndError;
-    classes: InvoicingQboAccountOption[];
+    classes: InvoicingAccountingOption[];
     classesFetchState: FetchStateAndError;
     connectionFetchState: FetchStateAndError;
+    /**
+     * The account and class trees the grouped pickers render. The flat option
+     * lists above stay for callers that only need id and name.
+     */
+    nestedAccountHierarchy: NestedAccountHierarchyForReport[];
+    nestedClassHierarchy: NestedClassHierarchyForReport[];
     retryFetchStateByTaskId: Record<string, FetchStateAndError>;
     syncHealthFetchState: FetchStateAndError;
     connection?: InvoicingQboConnection;
     syncHealth?: InvoicingQboSyncHealth;
 }
+/**
+ * The accounts valid for one QBO mapping kind, whose `accountTypes` is a
+ * comma-separated list of QuickBooks type names. An unrecognised list yields no
+ * accounts rather than every account: offering a bank account where income is
+ * required would post a mapping QuickBooks rejects.
+ */
+export declare const invoicingAccountsForQboAccountTypes: (accounts: InvoicingAccountingOption[], accountTypes: string) => InvoicingAccountingOption[];
+/**
+ * The account tree narrowed to the given account types. The tree itself carries
+ * no account type, so the flat account list supplies that and the matching
+ * `qboId`s are kept — which is why callers that only need "income accounts, as a
+ * tree" do not have to hold a second flat list to filter with.
+ */
+export declare const invoicingAccountHierarchyForTypes: (state: RootState, accountTypes: readonly AccountType[]) => NestedAccountHierarchyForReport[];
 /**
  * Single bundled view for the QBO integration settings screen — the
- * connection, per-account-types account options, classes, sync health, and the
- * fetch/action states for each of them.
+ * connection, the account and class options, sync health, and the fetch/action
+ * states for each of them.
  */
 export declare const getInvoicingQboView: (state: RootState) => InvoicingQboView;

package/lib/view/invoicing/invoicingQboView/invoicingQboViewSelector.js

@@ -1,19 +1,140 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.getInvoicingQboView = void 0;
+exports.getInvoicingQboView = exports.invoicingAccountHierarchyForTypes = exports.invoicingAccountsForQboAccountTypes = exports.INVOICING_INCOME_ACCOUNT_TYPES = exports.isInvoicingQboConnected = exports.INVOICING_ACCOUNT_LIST_KEY = void 0;
+const accountListSelector_1 = require("../../accountList/accountListSelector");
+const classListSelector_1 = require("../../classList/classListSelector");
+// Its own bucket: invoicing needs the AP/AR exclusions that the vendor and
+// transaction screens sharing `accountList` do not pass.
+exports.INVOICING_ACCOUNT_LIST_KEY = 'invoicingAccountList';
+/** Whether QBO is connected, without building the option lists to find out. */
+const isInvoicingQboConnected = (state) => state.invoicingQboViewState.connection?.connected === true;
+exports.isInvoicingQboConnected = isInvoicingQboConnected;
+/**
+ * Account types that can back invoicing revenue. Named here so screens ask for
+ * "income accounts" rather than repeating the accounting service's vocabulary.
+ */
+exports.INVOICING_INCOME_ACCOUNT_TYPES = [
+    'income',
+    'other_income',
+];
+/**
+ * Accounts and classes as the invoicing pickers need them. Both come from the
+ * shared accounting-service lists, so whatever another screen already loaded
+ * is reused. `qboId` is the submitted value because that is what the invoicing
+ * API stores; an account without one cannot be posted, so it is dropped rather
+ * than offered.
+ */
+const invoicingAccountingOptions = (state, accountTypes) => {
+    const { accounts } = (0, accountListSelector_1.getAccountList)(state.accountState, state.accountListState, exports.INVOICING_ACCOUNT_LIST_KEY);
+    return accounts.flatMap((account) => {
+        if (account.qboId == null || account.isDeleted === true) {
+            return [];
+        }
+        if (accountTypes != null &&
+            (account.accountType == null ||
+                !accountTypes.includes(account.accountType))) {
+            return [];
+        }
+        return [
+            {
+                id: String(account.qboId),
+                name: account.accountName,
+                accountType: account.accountType,
+            },
+        ];
+    });
+};
+/**
+ * Normalises an account-type name for comparison. The config's mapping kinds
+ * name QuickBooks types the way QuickBooks displays them ("Other Current
+ * Asset", "Expense"), while the accounting service uses snake_case and
+ * sometimes pluralises ("other_current_assets", "expenses"). Comparing the
+ * normalised, de-pluralised forms keeps a picker from silently emptying because
+ * of a trailing "s".
+ */
+const normalizeAccountTypeName = (value) => {
+    const normalized = value
+        .trim()
+        .toLowerCase()
+        .replace(/[^a-z0-9]+/g, '_');
+    // Singularise so "Other Current Liability" meets `other_current_liabilities`
+    // and "Expense" meets `expenses`. `-ies` needs its own case: stripping the
+    // trailing "s" alone would leave "liabilitie", matching nothing.
+    return normalized.replace(/ies$/, 'y').replace(/([^s])s$/, '$1');
+};
+/**
+ * The accounts valid for one QBO mapping kind, whose `accountTypes` is a
+ * comma-separated list of QuickBooks type names. An unrecognised list yields no
+ * accounts rather than every account: offering a bank account where income is
+ * required would post a mapping QuickBooks rejects.
+ */
+const invoicingAccountsForQboAccountTypes = (accounts, accountTypes) => {
+    const wanted = new Set(accountTypes
+        .split(',')
+        .map(normalizeAccountTypeName)
+        .filter((accountType) => accountType !== ''));
+    if (wanted.size === 0) {
+        return accounts;
+    }
+    return accounts.filter((account) => account.accountType != null &&
+        wanted.has(normalizeAccountTypeName(account.accountType)));
+};
+exports.invoicingAccountsForQboAccountTypes = invoicingAccountsForQboAccountTypes;
+/** Classes as the invoicing pickers need them, from the shared class list. */
+const invoicingAccountingClassOptions = (state) => {
+    const { classes } = (0, classListSelector_1.getClassList)(state.classState, state.classListState);
+    return classes.flatMap((accountingClass) => accountingClass.qboId == null || accountingClass.isDeleted === true
+        ? []
+        : [
+            {
+                id: String(accountingClass.qboId),
+                name: accountingClass.className,
+            },
+        ]);
+};
+/**
+ * The account tree narrowed to the given account types. The tree itself carries
+ * no account type, so the flat account list supplies that and the matching
+ * `qboId`s are kept — which is why callers that only need "income accounts, as a
+ * tree" do not have to hold a second flat list to filter with.
+ */
+const invoicingAccountHierarchyForTypes = (state, accountTypes) => {
+    const allowedQboIds = new Set(invoicingAccountingOptions(state, accountTypes).map((account) => account.id));
+    const keepMatching = (nodes) => nodes.flatMap((node) => {
+        const children = keepMatching(node.children);
+        const isMatch = node.qboId != null && allowedQboIds.has(String(node.qboId));
+        // A parent that is not itself a match is still kept when it holds one, so
+        // the tree's shape survives the filter.
+        if (!isMatch && children.length === 0) {
+            return [];
+        }
+        return [{ ...node, children }];
+    });
+    return keepMatching((0, accountListSelector_1.getNestedAccountListHierarchy)(state.accountListState, exports.INVOICING_ACCOUNT_LIST_KEY));
+};
+exports.invoicingAccountHierarchyForTypes = invoicingAccountHierarchyForTypes;
 /**
  * Single bundled view for the QBO integration settings screen — the
- * connection, per-account-types account options, classes, sync health, and the
- * fetch/action states for each of them.
+ * connection, the account and class options, sync health, and the fetch/action
+ * states for each of them.
  */
 const getInvoicingQboView = (state) => {
     const qboState = state.invoicingQboViewState;
+    const accountList = state.accountListState.byReportId[exports.INVOICING_ACCOUNT_LIST_KEY];
     return {
-        accountsByAccountTypes: qboState.accountsByAccountTypes,
-        accountsFetchStateByAccountTypes: qboState.accountsFetchStateByAccountTypes,
+        accounts: invoicingAccountingOptions(state),
+        accountsFetchState: {
+            fetchState: accountList.fetchState,
+            error: accountList.error,
+        },
+        nestedAccountHierarchy: (0, accountListSelector_1.getNestedAccountListHierarchy)(state.accountListState, exports.INVOICING_ACCOUNT_LIST_KEY),
+        nestedClassHierarchy: (0, classListSelector_1.getNestedClassListHierarchy)(state.classListState),
         backfillState: qboState.backfillFetchState,
-        classes: qboState.classes,
-        classesFetchState: qboState.classesFetchState,
+        classes: invoicingAccountingClassOptions(state),
+        classesFetchState: {
+            fetchState: state.classListState.fetchState,
+            error: state.classListState.error,
+        },
         connection: qboState.connection,
         connectionFetchState: qboState.connectionFetchState,
         retryFetchStateByTaskId: qboState.retryFetchStateByTaskId,

package/lib/view/invoicing/invoicingQboView/invoicingQboViewState.d.ts

@@ -1,11 +1,7 @@
 import { FetchStateAndError } from '../../../commonStateTypes/common';
-import { InvoicingQboAccountOption, InvoicingQboConnection, InvoicingQboSyncHealth } from './invoicingQboViewPayload';
+import { InvoicingQboConnection, InvoicingQboSyncHealth } from './invoicingQboViewPayload';
 export interface InvoicingQboViewState {
-    accountsByAccountTypes: Record<string, InvoicingQboAccountOption[]>;
-    accountsFetchStateByAccountTypes: Record<string, FetchStateAndError>;
     backfillFetchState: FetchStateAndError;
-    classes: InvoicingQboAccountOption[];
-    classesFetchState: FetchStateAndError;
     connectionFetchState: FetchStateAndError;
     retryFetchStateByTaskId: Record<string, FetchStateAndError>;
     syncHealthFetchState: FetchStateAndError;

package/lib/view/invoicing/settingsView/settingsViewSelector.d.ts

@@ -1,7 +1,7 @@
 import { FetchState, FetchStateAndError } from '../../../commonStateTypes/common';
 import { InvoicingDunningActionOption, InvoicingNamedOption, InvoicingQboAccountMappingKindOption, InvoicingSettingsPayload } from '../../../entity/invoicing/invoicingCommonPayload';
-import { RootState } from '../../../rootStateTypes';
 import { ZeniAPIStatus } from '../../../responsePayload';
+import { RootState } from '../../../rootStateTypes';
 import { InvoicingBrandingFormLocalData } from './invoicingBrandingFormConfig';
 /**
  * Shared primitive: the raw invoicing settings. Consumed internally by other
@@ -53,6 +53,12 @@ export interface InvoicingSettingsHubView {
     configFetchState: FetchState;
     dunningScheduleActionOptions: InvoicingDunningActionOption[];
     isEnablingInvoicing: boolean;
+    /**
+     * Whether the tenant has already enabled invoicing. The enable footer is for
+     * tenants that have not, so this — not `canEnableInvoicing` — decides whether
+     * it renders at all.
+     */
+    isInvoicingEnabled: boolean;
     isQboConfigured: boolean;
     isStripeConnected: boolean;
     qboAccountMappingKindOptions: InvoicingQboAccountMappingKindOption[];
@@ -67,9 +73,10 @@ export interface InvoicingSettingsHubView {
  * two integration prerequisites kept separate so the hub can name the step still
  * outstanding instead of showing a dead button.
  *
- * `canEnableInvoicing` folds in the onboarding step, so the screen does not need
- * to re-check it: the footer is only offered mid-onboarding and only once both
- * integrations are ready.
+ * `isInvoicingEnabled` decides whether the footer renders; `canEnableInvoicing`
+ * whether its button is live, and it still requires the onboarding step so the
+ * terms cannot be skipped. A tenant partway through therefore sees the footer,
+ * disabled and naming what is left, rather than nothing at all.
  *
  * Deliberately not folded into `getInvoicingConfigView`: that selector gates
  * every invoicing route and stays a pure read of the config slice. The settings

package/lib/view/invoicing/settingsView/settingsViewSelector.js

@@ -70,9 +70,10 @@ function deriveInvoicingEnablePrerequisites(settings, isQboConnected, qboAccount
  * two integration prerequisites kept separate so the hub can name the step still
  * outstanding instead of showing a dead button.
  *
- * `canEnableInvoicing` folds in the onboarding step, so the screen does not need
- * to re-check it: the footer is only offered mid-onboarding and only once both
- * integrations are ready.
+ * `isInvoicingEnabled` decides whether the footer renders; `canEnableInvoicing`
+ * whether its button is live, and it still requires the onboarding step so the
+ * terms cannot be skipped. A tenant partway through therefore sees the footer,
+ * disabled and naming what is left, rather than nothing at all.
  *
  * Deliberately not folded into `getInvoicingConfigView`: that selector gates
  * every invoicing route and stays a pure read of the config slice. The settings
@@ -82,7 +83,10 @@ const getInvoicingSettingsHubView = (state) => {
     const { dunningScheduleActionOptions, enableState, error: configError, fetchState: configFetchState, qboAccountMappingKindOptions, qboCustomerMatchingOptions, qboSyncStatusOptions, status, } = (0, invoicingConfigViewSelector_1.getInvoicingConfigView)(state);
     const { canEnable, isQboConfigured, isStripeConnected } = deriveInvoicingEnablePrerequisites(state.invoicingSettingsViewState.settings, state.invoicingQboViewState.connection?.connected === true, qboAccountMappingKindOptions);
     return {
+        // Keeps the onboarding step in the gate: a tenant that has not accepted the
+        // terms cannot enable invoicing, whatever the integrations say.
         canEnableInvoicing: status === 'settings' && canEnable,
+        isInvoicingEnabled: state.invoicingConfigViewState.isInvoicingEnabled === true,
         configError,
         configFetchState,
         dunningScheduleActionOptions,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.2.5",
+  "version": "5.2.7-betaAK0",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",

package/lib/esm/view/invoicing/invoicingQboView/epics/fetchInvoicingQboAccountsEpic.js

@@ -1,25 +0,0 @@
-import { of } from 'rxjs';
-import { catchError, filter, map, mergeMap } from 'rxjs/operators';
-import { createZeniAPIStatus, isSuccessResponse, } from '../../../../responsePayload';
-import { mapInvoicingQboAccountOptions, } from '../invoicingQboViewPayload';
-import { fetchInvoicingQboAccounts, updateInvoicingQboAccounts, updateInvoicingQboAccountsFailure, } from '../invoicingQboViewReducer';
-export const fetchInvoicingQboAccountsEpic = (actions$, _state$, zeniAPI) => actions$.pipe(filter(fetchInvoicingQboAccounts.match), mergeMap((action) => {
-    const { accountTypes } = action.payload;
-    const apiUrl = `${zeniAPI.apiEndPoints.invoicingMicroServiceBaseUrl}/1.0/qbo/accounts?account_types=${encodeURIComponent(accountTypes)}`;
-    return zeniAPI.getJSON(apiUrl).pipe(map((response) => {
-        if (isSuccessResponse(response)) {
-            return updateInvoicingQboAccounts({
-                accountTypes,
-                accounts: mapInvoicingQboAccountOptions(response.data?.accounts ?? []),
-            });
-        }
-        return updateInvoicingQboAccountsFailure({
-            accountTypes,
-            status: response.status,
-        });
-    }), catchError((error) => of(updateInvoicingQboAccountsFailure({
-        accountTypes,
-        status: createZeniAPIStatus('Unexpected Error', 'Fetch QBO accounts REST API call errored out ' +
-            JSON.stringify(error)),
-    }))));
-}));

package/lib/esm/view/invoicing/invoicingQboView/epics/fetchInvoicingQboClassesEpic.js

@@ -1,15 +0,0 @@
-import { of } from 'rxjs';
-import { catchError, filter, map, switchMap } from 'rxjs/operators';
-import { createZeniAPIStatus, isSuccessResponse, } from '../../../../responsePayload';
-import { mapInvoicingQboAccountOptions, } from '../invoicingQboViewPayload';
-import { fetchInvoicingQboClasses, updateInvoicingQboClasses, updateInvoicingQboClassesFailure, } from '../invoicingQboViewReducer';
-export const fetchInvoicingQboClassesEpic = (actions$, _state$, zeniAPI) => actions$.pipe(filter(fetchInvoicingQboClasses.match), switchMap(() => {
-    const apiUrl = `${zeniAPI.apiEndPoints.invoicingMicroServiceBaseUrl}/1.0/qbo/classes`;
-    return zeniAPI.getJSON(apiUrl).pipe(map((response) => {
-        if (isSuccessResponse(response)) {
-            return updateInvoicingQboClasses(mapInvoicingQboAccountOptions(response.data?.accounts ?? []));
-        }
-        return updateInvoicingQboClassesFailure(response.status);
-    }), catchError((error) => of(updateInvoicingQboClassesFailure(createZeniAPIStatus('Unexpected Error', 'Fetch QBO classes REST API call errored out ' +
-        JSON.stringify(error))))));
-}));

package/lib/view/invoicing/invoicingQboView/epics/fetchInvoicingQboAccountsEpic.d.ts

@@ -1,6 +0,0 @@
-import { ActionsObservable, StateObservable } from 'redux-observable';
-import { Observable } from 'rxjs';
-import { RootState } from '../../../../rootStateTypes';
-import { ZeniAPI } from '../../../../zeniAPI';
-import { InvoicingQboViewActionType } from './invoicingQboViewActionType';
-export declare const fetchInvoicingQboAccountsEpic: (actions$: ActionsObservable<InvoicingQboViewActionType>, _state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => Observable<InvoicingQboViewActionType>;

package/lib/view/invoicing/invoicingQboView/epics/fetchInvoicingQboAccountsEpic.js

@@ -1,29 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.fetchInvoicingQboAccountsEpic = void 0;
-const rxjs_1 = require("rxjs");
-const operators_1 = require("rxjs/operators");
-const responsePayload_1 = require("../../../../responsePayload");
-const invoicingQboViewPayload_1 = require("../invoicingQboViewPayload");
-const invoicingQboViewReducer_1 = require("../invoicingQboViewReducer");
-const fetchInvoicingQboAccountsEpic = (actions$, _state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(invoicingQboViewReducer_1.fetchInvoicingQboAccounts.match), (0, operators_1.mergeMap)((action) => {
-    const { accountTypes } = action.payload;
-    const apiUrl = `${zeniAPI.apiEndPoints.invoicingMicroServiceBaseUrl}/1.0/qbo/accounts?account_types=${encodeURIComponent(accountTypes)}`;
-    return zeniAPI.getJSON(apiUrl).pipe((0, operators_1.map)((response) => {
-        if ((0, responsePayload_1.isSuccessResponse)(response)) {
-            return (0, invoicingQboViewReducer_1.updateInvoicingQboAccounts)({
-                accountTypes,
-                accounts: (0, invoicingQboViewPayload_1.mapInvoicingQboAccountOptions)(response.data?.accounts ?? []),
-            });
-        }
-        return (0, invoicingQboViewReducer_1.updateInvoicingQboAccountsFailure)({
-            accountTypes,
-            status: response.status,
-        });
-    }), (0, operators_1.catchError)((error) => (0, rxjs_1.of)((0, invoicingQboViewReducer_1.updateInvoicingQboAccountsFailure)({
-        accountTypes,
-        status: (0, responsePayload_1.createZeniAPIStatus)('Unexpected Error', 'Fetch QBO accounts REST API call errored out ' +
-            JSON.stringify(error)),
-    }))));
-}));
-exports.fetchInvoicingQboAccountsEpic = fetchInvoicingQboAccountsEpic;

package/lib/view/invoicing/invoicingQboView/epics/fetchInvoicingQboClassesEpic.d.ts

@@ -1,6 +0,0 @@
-import { ActionsObservable, StateObservable } from 'redux-observable';
-import { Observable } from 'rxjs';
-import { RootState } from '../../../../rootStateTypes';
-import { ZeniAPI } from '../../../../zeniAPI';
-import { InvoicingQboViewActionType } from './invoicingQboViewActionType';
-export declare const fetchInvoicingQboClassesEpic: (actions$: ActionsObservable<InvoicingQboViewActionType>, _state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => Observable<InvoicingQboViewActionType>;

package/lib/view/invoicing/invoicingQboView/epics/fetchInvoicingQboClassesEpic.js

@@ -1,19 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.fetchInvoicingQboClassesEpic = void 0;
-const rxjs_1 = require("rxjs");
-const operators_1 = require("rxjs/operators");
-const responsePayload_1 = require("../../../../responsePayload");
-const invoicingQboViewPayload_1 = require("../invoicingQboViewPayload");
-const invoicingQboViewReducer_1 = require("../invoicingQboViewReducer");
-const fetchInvoicingQboClassesEpic = (actions$, _state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(invoicingQboViewReducer_1.fetchInvoicingQboClasses.match), (0, operators_1.switchMap)(() => {
-    const apiUrl = `${zeniAPI.apiEndPoints.invoicingMicroServiceBaseUrl}/1.0/qbo/classes`;
-    return zeniAPI.getJSON(apiUrl).pipe((0, operators_1.map)((response) => {
-        if ((0, responsePayload_1.isSuccessResponse)(response)) {
-            return (0, invoicingQboViewReducer_1.updateInvoicingQboClasses)((0, invoicingQboViewPayload_1.mapInvoicingQboAccountOptions)(response.data?.accounts ?? []));
-        }
-        return (0, invoicingQboViewReducer_1.updateInvoicingQboClassesFailure)(response.status);
-    }), (0, operators_1.catchError)((error) => (0, rxjs_1.of)((0, invoicingQboViewReducer_1.updateInvoicingQboClassesFailure)((0, responsePayload_1.createZeniAPIStatus)('Unexpected Error', 'Fetch QBO classes REST API call errored out ' +
-        JSON.stringify(error))))));
-}));
-exports.fetchInvoicingQboClassesEpic = fetchInvoicingQboClassesEpic;