@zeniai/client-epic-state 5.2.49 → 5.2.50-betaRD1

package/lib/view/expenseAutomationView/epics/jeSchedule/fetchFailedJePostingsEpic.d.ts

@@ -0,0 +1,20 @@
+import { ActionsObservable, StateObservable } from 'redux-observable';
+import { Observable } from 'rxjs';
+import { updateJESchedules, updateJESchedulesDetails } from '../../../../entity/jeSchedules/jeSchedulesReducer';
+import { clearAll } from '../../../../rootActions';
+import { RootState } from '../../../../rootStateTypes';
+import { ZeniAPI } from '../../../../zeniAPI';
+import { fetchFailedJePostings, fetchFailedJePostingsFailure, fetchFailedJePostingsSuccess, initializeJeScheduleLocalData } from '../../reducers/jeSchedulesViewReducer';
+export type ActionType = ReturnType<typeof clearAll> | ReturnType<typeof fetchFailedJePostings> | ReturnType<typeof fetchFailedJePostingsFailure> | ReturnType<typeof fetchFailedJePostingsSuccess> | ReturnType<typeof initializeJeScheduleLocalData> | ReturnType<typeof updateJESchedules> | ReturnType<typeof updateJESchedulesDetails>;
+/**
+ * Fetches every currently-failing posting for the tenant, on its own endpoint and with no window.
+ *
+ * Sends no query at all. The endpoint takes an optional `expected_post_start_date` floor and the
+ * client deliberately omits it: a failure is outstanding work until someone resolves it, whatever
+ * month it belongs to, and windowing this list is exactly what kept older failures off the only
+ * screen that can resolve them.
+ *
+ * `switchMap`, not `mergeMap`: there is one list per tenant, so a second trigger supersedes the
+ * first rather than racing it.
+ */
+export declare const fetchFailedJePostingsEpic: (actions$: ActionsObservable<ActionType>, _state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => Observable<ActionType>;

package/lib/view/expenseAutomationView/epics/jeSchedule/fetchFailedJePostingsEpic.js

@@ -0,0 +1,44 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.fetchFailedJePostingsEpic = void 0;
+const rxjs_1 = require("rxjs");
+const operators_1 = require("rxjs/operators");
+const jeSchedulesReducer_1 = require("../../../../entity/jeSchedules/jeSchedulesReducer");
+const responsePayload_1 = require("../../../../responsePayload");
+const rootActions_1 = require("../../../../rootActions");
+const jeSchedulesViewReducer_1 = require("../../reducers/jeSchedulesViewReducer");
+/**
+ * Fetches every currently-failing posting for the tenant, on its own endpoint and with no window.
+ *
+ * Sends no query at all. The endpoint takes an optional `expected_post_start_date` floor and the
+ * client deliberately omits it: a failure is outstanding work until someone resolves it, whatever
+ * month it belongs to, and windowing this list is exactly what kept older failures off the only
+ * screen that can resolve them.
+ *
+ * `switchMap`, not `mergeMap`: there is one list per tenant, so a second trigger supersedes the
+ * first rather than racing it.
+ */
+const fetchFailedJePostingsEpic = (actions$, _state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(jeSchedulesViewReducer_1.fetchFailedJePostings.match), (0, operators_1.switchMap)(() => zeniAPI
+    .getJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/expenses_automation/failed_je_postings`)
+    .pipe((0, operators_1.switchMap)((response) => {
+    if (!(0, responsePayload_1.isSuccessResponse)(response) || response.data == null) {
+        return (0, rxjs_1.of)((0, jeSchedulesViewReducer_1.fetchFailedJePostingsFailure)(response.status));
+    }
+    const failedJeSchedules = response.data.failed_je_postings?.je_schedules ?? [];
+    const failedScheduledJournalEntries = response.data.failed_je_postings?.scheduled_journal_entries ?? [];
+    // Order matters and matches fetchJeSchedulesEpic: updateJESchedules fans out to the
+    // vendor / account / class / user entities, updateJESchedulesDetails then attaches the
+    // journal entries, and only then can initializeJeScheduleLocalData read them back.
+    return (0, rxjs_1.from)([
+        (0, jeSchedulesReducer_1.updateJESchedules)(failedJeSchedules),
+        (0, jeSchedulesReducer_1.updateJESchedulesDetails)(failedJeSchedules, failedScheduledJournalEntries),
+        (0, jeSchedulesViewReducer_1.initializeJeScheduleLocalData)(failedJeSchedules),
+        (0, jeSchedulesViewReducer_1.fetchFailedJePostingsSuccess)(failedJeSchedules),
+    ]);
+}), (0, operators_1.catchError)((error) => (0, rxjs_1.of)((0, jeSchedulesViewReducer_1.fetchFailedJePostingsFailure)((0, responsePayload_1.createZeniAPIStatus)('Unexpected Error', 'fetch failed JE postings REST API call errored out' +
+    JSON.stringify(error))))), 
+// A tenant switch clears the store while this request is still in flight. Without this
+// the old tenant's rows are written back into the freshly cleared store and stay on
+// screen under the new tenant until a manual refresh.
+(0, operators_1.takeUntil)(actions$.pipe((0, operators_1.filter)(rootActions_1.clearAll.match))))));
+exports.fetchFailedJePostingsEpic = fetchFailedJePostingsEpic;

package/lib/view/expenseAutomationView/epics/jeSchedule/fetchJeSchedulePageEpic.d.ts

@@ -3,6 +3,6 @@ import { Observable } from 'rxjs';
 import { RootState } from '../../../../rootStateTypes';
 import { fetchAccountList } from '../../../accountList/accountListReducer';
 import { fetchActualMatchingPage } from '../../reducers/actualMatchingViewReducer';
-import { fetchJeSchedules, fetchJeSchedulesPage, initializeAccountSettingsView } from '../../reducers/jeSchedulesViewReducer';
-export type ActionType = ReturnType<typeof fetchAccountList> | ReturnType<typeof fetchActualMatchingPage> | ReturnType<typeof fetchJeSchedules> | ReturnType<typeof fetchJeSchedulesPage> | ReturnType<typeof initializeAccountSettingsView>;
+import { fetchFailedJePostings, fetchJeSchedules, fetchJeSchedulesPage, initializeAccountSettingsView } from '../../reducers/jeSchedulesViewReducer';
+export type ActionType = ReturnType<typeof fetchAccountList> | ReturnType<typeof fetchActualMatchingPage> | ReturnType<typeof fetchFailedJePostings> | ReturnType<typeof fetchJeSchedules> | ReturnType<typeof fetchJeSchedulesPage> | ReturnType<typeof initializeAccountSettingsView>;
 export declare const fetchJeSchedulesPageEpic: (actions$: ActionsObservable<ActionType>, state$: StateObservable<RootState>) => Observable<ActionType>;

package/lib/view/expenseAutomationView/epics/jeSchedule/fetchJeSchedulePageEpic.js

@@ -27,6 +27,14 @@ const fetchJeSchedulesPageEpic = (actions$, state$) => actions$.pipe((0, operato
     else {
         jeSchedulePageActions.push((0, jeSchedulesViewReducer_1.fetchJeSchedules)(period, refreshViewInBackground));
     }
+    // Failed postings are tenant-wide and carry no period, so a period change or a tab switch
+    // cannot invalidate them -- fetch once and let retry keep the list current from then on.
+    // Refreshes still refetch, silently, so a failure resolved elsewhere leaves eventually.
+    const { fetchState: failedPostingsFetchState } = state.expenseAutomationJESchedulesViewState.failedJePostings.fetchState;
+    const isBackgroundRefresh = refreshViewInBackground === true;
+    if (failedPostingsFetchState === 'Not-Started' || isBackgroundRefresh) {
+        jeSchedulePageActions.push((0, jeSchedulesViewReducer_1.fetchFailedJePostings)(isBackgroundRefresh));
+    }
     // Only on the first page load. Account settings cannot change from a tab switch or a
     // refresh, and re-initializing puts accountSettingsView back to 'In-Progress' -- which the
     // page reads as "still loading" and answers with a full skeleton over rows it already has.

package/lib/view/expenseAutomationView/epics/jeSchedule/fetchJeSchedulesEpic.js

@@ -84,8 +84,9 @@ const fetchJeSchedulesEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, op
                 one_time_accrual_service_month_end: parsedEndDate.format(jeSchedulesPayload_1.SERVICE_MONTH_FORMAT),
                 // Existing lists what actually reached the books.
                 one_time_accrual_statuses: ['posted'],
-                // A failed posting from an earlier month still needs to surface here, so this list
-                // is deliberately not windowed.
+                // Kept only so this tab's response shape is unchanged. Nothing reads the failed
+                // postings it returns any more -- they have their own endpoint and their own group
+                // on Review. Dropping the key from the response is a server-side follow-up.
                 filter_failed_je_postings_by_date: false,
             }),
     };
@@ -96,12 +97,10 @@ const fetchJeSchedulesEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, op
             const updateActions = [];
             const accruedJeSchedules = response.data.accrued_je_schedules?.je_schedules ?? [];
             const oneTimeAccruals = response.data.one_time_accruals ?? [];
-            updateActions.push((0, jeSchedulesReducer_1.updateJESchedules)([
-                ...response.data.je_schedules,
-                ...response.data.failed_je_postings.je_schedules,
-            ]), (0, jeSchedulesReducer_1.updateJESchedulesDetails)([...response.data.failed_je_postings.je_schedules], response.data.failed_je_postings.scheduled_journal_entries), (0, jeSchedulesViewReducer_1.initializeJeScheduleLocalData)([
-                ...response.data.failed_je_postings.je_schedules,
-            ]));
+            // failed_je_postings is deliberately ignored. This endpoint windows it to the close
+            // month, which is what hid older failures; fetchFailedJePostingsEpic owns that list
+            // now and fetches it unwindowed.
+            updateActions.push((0, jeSchedulesReducer_1.updateJESchedules)([...response.data.je_schedules]));
             if (accruedJeSchedules.length > 0) {
                 updateActions.push((0, jeSchedulesReducer_1.updateAccruedJESchedules)(accruedJeSchedules), (0, jeSchedulesReducer_1.updateAccruedJESchedulesDetails)(accruedJeSchedules, response.data.accrued_je_schedules
                     ?.scheduled_journal_entries));
@@ -114,9 +113,7 @@ const fetchJeSchedulesEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, op
             }
             updateActions.push((0, jeSchedulesViewReducer_1.fetchJeSchedulesSuccess)({
                 jeSchedules: [...response.data.je_schedules],
-                failedJeSchedules: [
-                    ...response.data.failed_je_postings.je_schedules,
-                ],
+                failedJeSchedules: [],
                 accruedJeSchedules: accruedJeSchedules,
                 oneTimeAccruals: oneTimeAccruals,
                 selectedPeriod: selectedPeriod,

package/lib/view/expenseAutomationView/epics/jeSchedule/initializeJeScheduleLocalDataEpic.js

@@ -10,22 +10,36 @@ const initializeJeScheduleLocalDataEpic = (actions$, state$) => actions$.pipe((0
     const actions = [];
     const { jeScheduleTransactionKeys } = action.payload;
     jeScheduleTransactionKeys.forEach((jeScheduleTransactionKey) => {
+        // Checked before the selector runs, not after: the selector destructures the record it
+        // looks up, so a key that is not in the store throws a TypeError rather than returning
+        // undefined. This epic is a mergeMap with no catchError, so that throw would take its
+        // subscription down for the rest of the session and silently stop local-data
+        // initialisation everywhere -- not just for this row.
+        if (state.jeSchedulesState.schedulesByTransactionKey[jeScheduleTransactionKey] == null) {
+            return;
+        }
         const jeScheduledTransaction = (0, jeSchedulesSelector_1.getJEScheduledTransactionByJEScheduleTransactionKey)(jeScheduleTransactionKey, state);
-        const initLocalData = {
-            jeScheduleType: jeScheduledTransaction.jeScheduleType,
-            jeScheduleID: jeScheduledTransaction.jeScheduleId,
-            scheduledJournalEntryID: jeScheduledTransaction.scheduledJournalEntry[0]
-                .scheduledJournalEntryID,
-            updatedVendor: undefined,
-            updatedCategoryId: undefined,
-            updatedAccumulatedDepreciationCategoryID: undefined,
-            updatedClassId: undefined,
-        };
-        actions.push((0, jeSchedulesViewReducer_1.updateJeScheduleLocalDataById)({
-            localData: initLocalData,
-            scheduledJournalEntryID: jeScheduledTransaction.scheduledJournalEntry[0]
-                .scheduledJournalEntryID,
-        }));
+        // One record per journal entry, not per schedule. A schedule that failed in two months is
+        // two rows and each needs its own vendor / category edits -- keying only the first left
+        // every later row without local data, which the list renders read-only and without a
+        // Retry button. An empty array is possible when details have not landed yet; it must not
+        // throw, because this runs in a mergeMap with no catchError and the throw would take the
+        // epic's subscription down for the rest of the session.
+        jeScheduledTransaction.scheduledJournalEntry.forEach((journalEntry) => {
+            const { scheduledJournalEntryID } = journalEntry;
+            actions.push((0, jeSchedulesViewReducer_1.updateJeScheduleLocalDataById)({
+                localData: {
+                    jeScheduleType: jeScheduledTransaction.jeScheduleType,
+                    jeScheduleID: jeScheduledTransaction.jeScheduleId,
+                    scheduledJournalEntryID,
+                    updatedVendor: undefined,
+                    updatedCategoryId: undefined,
+                    updatedAccumulatedDepreciationCategoryID: undefined,
+                    updatedClassId: undefined,
+                },
+                scheduledJournalEntryID,
+            }));
+        });
     });
     return (0, rxjs_1.from)(actions);
 }));

package/lib/view/expenseAutomationView/epics/jeSchedule/retryJeSchedulesEpic.d.ts

@@ -1,10 +1,10 @@
 import { ActionsObservable, StateObservable } from 'redux-observable';
 import { Observable } from 'rxjs';
-import { updateJESchedules, updateJESchedulesDetails } from '../../../../entity/jeSchedules/jeSchedulesReducer';
+import { removeScheduledJournalEntryFromJESchedule, updateJESchedules, updateJESchedulesDetails } from '../../../../entity/jeSchedules/jeSchedulesReducer';
 import { openSnackbar } from '../../../../entity/snackbar/snackbarReducer';
 import { RootState } from '../../../../rootStateTypes';
 import { ZeniAPI } from '../../../../zeniAPI';
 import { fetchMonthEndCloseChecks } from '../../../monthEndCloseChecksView/monthEndCloseChecksViewReducer';
 import { removeFailedJeScheduleTransactionKey, removeJeScheduleLocalDataById, retryJeSchedule, retryJeScheduleFailure, retryJeScheduleSuccess, updateJeScheduleTransactionKeys } from '../../reducers/jeSchedulesViewReducer';
-export type ActionType = ReturnType<typeof fetchMonthEndCloseChecks> | ReturnType<typeof openSnackbar> | ReturnType<typeof removeFailedJeScheduleTransactionKey> | ReturnType<typeof removeJeScheduleLocalDataById> | ReturnType<typeof retryJeSchedule> | ReturnType<typeof retryJeScheduleFailure> | ReturnType<typeof retryJeScheduleSuccess> | ReturnType<typeof updateJESchedules> | ReturnType<typeof updateJESchedulesDetails> | ReturnType<typeof updateJeScheduleTransactionKeys>;
+export type ActionType = ReturnType<typeof fetchMonthEndCloseChecks> | ReturnType<typeof openSnackbar> | ReturnType<typeof removeFailedJeScheduleTransactionKey> | ReturnType<typeof removeJeScheduleLocalDataById> | ReturnType<typeof removeScheduledJournalEntryFromJESchedule> | ReturnType<typeof retryJeSchedule> | ReturnType<typeof retryJeScheduleFailure> | ReturnType<typeof retryJeScheduleSuccess> | ReturnType<typeof updateJESchedules> | ReturnType<typeof updateJESchedulesDetails> | ReturnType<typeof updateJeScheduleTransactionKeys>;
 export declare const retryJeScheduleEpic: (actions$: ActionsObservable<ActionType>, state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => Observable<ActionType>;

package/lib/view/expenseAutomationView/epics/jeSchedule/retryJeSchedulesEpic.js

@@ -3,6 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.retryJeScheduleEpic = void 0;
 const rxjs_1 = require("rxjs");
 const operators_1 = require("rxjs/operators");
+const jeSchedulesReducer_1 = require("../../../../entity/jeSchedules/jeSchedulesReducer");
 const snackbarReducer_1 = require("../../../../entity/snackbar/snackbarReducer");
 const tenantSelector_1 = require("../../../../entity/tenant/tenantSelector");
 const responsePayload_1 = require("../../../../responsePayload");
@@ -25,9 +26,16 @@ const retryJeScheduleEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, ope
         .pipe((0, operators_1.mergeMap)((response) => {
         if ((0, responsePayload_1.isSuccessStatus)(response)) {
             const updateActions = [];
+            // Retire this entry, and the schedule itself only when this was its last failed
+            // one. A schedule that failed in several months is several rows sharing one
+            // schedule key, so dropping the key outright took the still-failing months off the
+            // list with it and nothing would have surfaced them again.
+            const failedEntriesForSchedule = state.jeSchedulesState.schedulesByTransactionKey[jeScheduleTransactionKey]?.scheduledJournalEntry ?? [];
+            const wasLastFailedEntryForSchedule = failedEntriesForSchedule.filter((journalEntry) => journalEntry.scheduledJournalEntryID !==
+                scheduledJournalEntryID).length === 0;
             updateActions.push((0, jeSchedulesViewReducer_1.retryJeScheduleSuccess)({
                 scheduledJournalEntryID,
-            }), (0, jeSchedulesViewReducer_1.removeFailedJeScheduleTransactionKey)(jeScheduleTransactionKey, selectedPeriod), (0, jeSchedulesViewReducer_1.removeJeScheduleLocalDataById)({ scheduledJournalEntryID }), // Important to remove localdata after success.
+            }), (0, jeSchedulesReducer_1.removeScheduledJournalEntryFromJESchedule)(jeScheduleTransactionKey, scheduledJournalEntryID), (0, jeSchedulesViewReducer_1.removeJeScheduleLocalDataById)({ scheduledJournalEntryID }), // Important to remove localdata after success.
             (0, monthEndCloseChecksViewReducer_1.fetchMonthEndCloseChecks)({
                 tenantId: currentTenant.tenantId,
                 period: selectedPeriod,
@@ -37,6 +45,9 @@ const retryJeScheduleEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, ope
                 messageText: 'success',
                 type: 'success',
             }));
+            if (wasLastFailedEntryForSchedule) {
+                updateActions.push((0, jeSchedulesViewReducer_1.removeFailedJeScheduleTransactionKey)(jeScheduleTransactionKey, selectedPeriod));
+            }
             return (0, rxjs_1.from)(updateActions);
         }
         else {

package/lib/view/expenseAutomationView/payload/jeSchedulesPayload.d.ts

@@ -78,6 +78,24 @@ interface ExpenseAutomationJESchedulesPayload {
     };
 }
 export type ExpenseAutomationJESchedulesResponse = ZeniAPIResponse<ExpenseAutomationJESchedulesPayload>;
+/**
+ * `GET /1.0/expenses_automation/failed_je_postings`.
+ *
+ * Deliberately the same `failed_je_postings` shape the schedules endpoint sends under that key, so
+ * both responses feed the same mappers. The difference is what the server does before answering:
+ * this endpoint applies no date window, so a posting that failed months ago still comes back.
+ */
+export interface FailedJePostingsPayload {
+    je_schedules: JEScheduledTransactionPayload[];
+    scheduled_journal_entries: ScheduledJournalEntryPayload[];
+}
+interface ExpenseAutomationFailedJePostingsPayload {
+    failed_je_postings: FailedJePostingsPayload;
+    query?: {
+        expected_post_start_date: string | null;
+    };
+}
+export type ExpenseAutomationFailedJePostingsResponse = ZeniAPIResponse<ExpenseAutomationFailedJePostingsPayload>;
 export declare const SERVICE_MONTH_FORMAT = "YYYY-MM";
 export interface CreateOneTimeAccrualPayload {
     amount: number;

package/lib/view/expenseAutomationView/reducers/jeSchedulesViewReducer.d.ts

@@ -47,7 +47,13 @@ export declare const clearExpenseAutomationJESchedulesView: import("@reduxjs/too
     period: TimePeriod;
     refreshViewInBackground: any;
     selectedPageTab: "schedules" | "actual_matching" | "existing_schedules" | undefined;
-}, "expenseAutomationJESchedulesView/fetchJeSchedules", never, never>, fetchJeSchedulesFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
+}, "expenseAutomationJESchedulesView/fetchJeSchedules", never, never>, fetchFailedJePostings: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[refreshInBackground?: any], {
+    refreshInBackground: any;
+}, "expenseAutomationJESchedulesView/fetchFailedJePostings", never, never>, fetchFailedJePostingsFailure: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[status: ZeniAPIStatus<Record<string, unknown>>], {
+    status: ZeniAPIStatus<Record<string, unknown>>;
+}, "expenseAutomationJESchedulesView/fetchFailedJePostingsFailure", never, never>, fetchFailedJePostingsSuccess: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[failedJeSchedules: JEScheduledTransactionPayload[]], {
+    failedJeSchedules: JEScheduledTransactionPayload[];
+}, "expenseAutomationJESchedulesView/fetchFailedJePostingsSuccess", never, never>, fetchJeSchedulesFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
     selectedPageTab: JEPageTab;
     selectedPeriod: MonthYearPeriod;
     status: ZeniAPIStatus;
@@ -132,7 +138,7 @@ export declare const clearExpenseAutomationJESchedulesView: import("@reduxjs/too
     status: ZeniAPIStatus;
 }, "expenseAutomationJESchedulesView/searchTransactionsForNewScheduleFailure">, searchTransactionsForNewScheduleSuccess: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
     searchResults: JEScheduleTransactionKey[];
-}, "expenseAutomationJESchedulesView/searchTransactionsForNewScheduleSuccess">, toggleJECreatedGroupCollapsed: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"expenseAutomationJESchedulesView/toggleJECreatedGroupCollapsed">, toggleJEPendingGroupCollapsed: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"expenseAutomationJESchedulesView/toggleJEPendingGroupCollapsed">, updateAccountSettingsListForAccountTypes: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
+}, "expenseAutomationJESchedulesView/searchTransactionsForNewScheduleSuccess">, toggleJECreatedGroupCollapsed: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"expenseAutomationJESchedulesView/toggleJECreatedGroupCollapsed">, toggleJEFailedGroupCollapsed: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"expenseAutomationJESchedulesView/toggleJEFailedGroupCollapsed">, toggleJEPendingGroupCollapsed: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"expenseAutomationJESchedulesView/toggleJEPendingGroupCollapsed">, updateAccountSettingsListForAccountTypes: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
     accountPayload: AccountMetadataPayload[];
 }, "expenseAutomationJESchedulesView/updateAccountSettingsListForAccountTypes">, updateAccountSettingsListForAccountTypesFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
     status: ZeniAPIStatus;

package/lib/view/expenseAutomationView/reducers/jeSchedulesViewReducer.js

@@ -1,8 +1,8 @@
 "use strict";
 var _a;
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.saveNewScheduleFailure = exports.saveNewSchedule = exports.saveAccountSettingsSuccess = exports.saveAccountSettingsLocalData = exports.saveAccountSettingsFailure = exports.saveAccountSettings = exports.retryJeScheduleSuccess = exports.retryJeScheduleFailure = exports.retryJeSchedule = exports.resetNewScheduleLocalData = exports.removeJeScheduleTransactionKey = exports.removeJeAccruedScheduleKey = exports.removeJeScheduleLocalDataById = exports.removeJeOneTimeAccrualLocalData = exports.removeFailedJeScheduleTransactionKey = exports.initializeNewSchedule = exports.initializeJeScheduleLocalData = exports.initializeAccountSettingsView = exports.ignoreRecommendedJeScheduleSuccess = exports.ignoreRecommendedJeScheduleFailure = exports.ignoreRecommendedJeSchedule = exports.fetchRecommendationForAccountSettings = exports.fetchOneTimeAccrualSuccess = exports.fetchOneTimeAccrualFailure = exports.fetchOneTimeAccrual = exports.fetchJeSchedulesSuccess = exports.fetchJeSchedulesPage = exports.fetchJeSchedulesFailure = exports.fetchJeSchedules = exports.fetchAccountSettingsListForAccountTypes = exports.revertOneTimeAccrual = exports.revertJeScheduleSuccess = exports.revertJeScheduleFailure = exports.revertJeSchedule = exports.promoteOneTimeAccrual = exports.oneTimeAccrualActionSuccess = exports.oneTimeAccrualActionFailure = exports.ignoreOneTimeAccrual = exports.createOneTimeAccrualSuccess = exports.createOneTimeAccrualFailure = exports.createOneTimeAccrual = exports.clearSearchTransactionsForNewSchedule = exports.clearJeScheduleLocalData = exports.clearJeAccountSettingsLocalData = exports.clearExpenseAutomationJESchedulesView = exports.initialState = exports.searchTransactionsInitialState = exports.newScheduleInitialState = exports.getBaseNewScheduleLocalData = exports.accountSettingsInitialState = void 0;
-exports.updateRecommendationForAccountSettingsFailure = exports.updateRecommendationForAccountSettings = exports.updateNewScheduleLocalData = exports.updateJeScheduleTransactionKeys = exports.updateJeScheduleLocalDataById = exports.updateJeOneTimeAccrualLocalData = exports.updateJEScheduleTypeFilter = exports.updateJESchedulesUIState = exports.updateAccountSettingsListForAccountTypesFailure = exports.updateAccountSettingsListForAccountTypes = exports.toggleJEPendingGroupCollapsed = exports.toggleJECreatedGroupCollapsed = exports.searchTransactionsForNewScheduleSuccess = exports.searchTransactionsForNewScheduleFailure = exports.searchTransactionsForNewSchedule = exports.saveNewScheduleSuccess = void 0;
+exports.saveAccountSettingsLocalData = exports.saveAccountSettingsFailure = exports.saveAccountSettings = exports.retryJeScheduleSuccess = exports.retryJeScheduleFailure = exports.retryJeSchedule = exports.resetNewScheduleLocalData = exports.removeJeScheduleTransactionKey = exports.removeJeAccruedScheduleKey = exports.removeJeScheduleLocalDataById = exports.removeJeOneTimeAccrualLocalData = exports.removeFailedJeScheduleTransactionKey = exports.initializeNewSchedule = exports.initializeJeScheduleLocalData = exports.initializeAccountSettingsView = exports.ignoreRecommendedJeScheduleSuccess = exports.ignoreRecommendedJeScheduleFailure = exports.ignoreRecommendedJeSchedule = exports.fetchRecommendationForAccountSettings = exports.fetchOneTimeAccrualSuccess = exports.fetchOneTimeAccrualFailure = exports.fetchOneTimeAccrual = exports.fetchJeSchedulesSuccess = exports.fetchJeSchedulesPage = exports.fetchJeSchedulesFailure = exports.fetchFailedJePostingsSuccess = exports.fetchFailedJePostingsFailure = exports.fetchFailedJePostings = exports.fetchJeSchedules = exports.fetchAccountSettingsListForAccountTypes = exports.revertOneTimeAccrual = exports.revertJeScheduleSuccess = exports.revertJeScheduleFailure = exports.revertJeSchedule = exports.promoteOneTimeAccrual = exports.oneTimeAccrualActionSuccess = exports.oneTimeAccrualActionFailure = exports.ignoreOneTimeAccrual = exports.createOneTimeAccrualSuccess = exports.createOneTimeAccrualFailure = exports.createOneTimeAccrual = exports.clearSearchTransactionsForNewSchedule = exports.clearJeScheduleLocalData = exports.clearJeAccountSettingsLocalData = exports.clearExpenseAutomationJESchedulesView = exports.initialState = exports.searchTransactionsInitialState = exports.newScheduleInitialState = exports.getBaseNewScheduleLocalData = exports.accountSettingsInitialState = void 0;
+exports.updateRecommendationForAccountSettingsFailure = exports.updateRecommendationForAccountSettings = exports.updateNewScheduleLocalData = exports.updateJeScheduleTransactionKeys = exports.updateJeScheduleLocalDataById = exports.updateJeOneTimeAccrualLocalData = exports.updateJEScheduleTypeFilter = exports.updateJESchedulesUIState = exports.updateAccountSettingsListForAccountTypesFailure = exports.updateAccountSettingsListForAccountTypes = exports.toggleJEPendingGroupCollapsed = exports.toggleJEFailedGroupCollapsed = exports.toggleJECreatedGroupCollapsed = exports.searchTransactionsForNewScheduleSuccess = exports.searchTransactionsForNewScheduleFailure = exports.searchTransactionsForNewSchedule = exports.saveNewScheduleSuccess = exports.saveNewScheduleFailure = exports.saveNewSchedule = exports.saveAccountSettingsSuccess = void 0;
 const toolkit_1 = require("@reduxjs/toolkit");
 const getNestedAccountIDHierarchyForReport_1 = require("../../../commonStateTypes/accountView/getNestedAccountIDHierarchyForReport");
 const timePeriod_1 = require("../../../commonStateTypes/timePeriod");
@@ -68,6 +68,10 @@ exports.initialState = {
     jeScheduleAccruedKeysByPeriodAndTab: {},
     jeScheduleOneTimeAccrualKeysByPeriodAndTab: {},
     failedJeScheduleTransactionKeysByPeriodAndTab: {},
+    failedJePostings: {
+        fetchState: { fetchState: 'Not-Started', error: undefined },
+        jeScheduleTransactionKeys: [],
+    },
     postStatusById: {},
     ignoreStatusById: {},
     revertStatusById: {},
@@ -77,6 +81,9 @@ exports.initialState = {
     oneTimeAccrualFetchStatusById: {},
     uiState: {
         createdGroupCollapsed: false,
+        // Expanded, like the other two. A failed posting is the only thing on this page that is
+        // actively wrong, so folding it away by default would hide the reason to open the tab.
+        failedGroupCollapsed: false,
         pendingGroupCollapsed: false,
         scrollPosition: { scrollTop: 0, scrollLeft: undefined },
         searchString: '',
@@ -148,6 +155,53 @@ const expenseAutomationJESchedulesView = (0, toolkit_1.createSlice)({
                 };
             },
         },
+        /**
+         * The Failed Postings list, fetched separately from the schedules it belongs to.
+         *
+         * No period and no tab in any of these three: the endpoint applies no date window, so there is
+         * one list per tenant and one slot to hold it. `refreshInBackground` keeps a silent refetch
+         * from dropping a skeleton over rows already on screen, the same way refreshStatus does for
+         * the schedules list.
+         */
+        fetchFailedJePostings: {
+            reducer(draft, action) {
+                if (!action.payload.refreshInBackground) {
+                    draft.failedJePostings.fetchState = {
+                        fetchState: 'In-Progress',
+                        error: undefined,
+                    };
+                }
+            },
+            prepare(refreshInBackground = false) {
+                return { payload: { refreshInBackground } };
+            },
+        },
+        fetchFailedJePostingsSuccess: {
+            reducer(draft, action) {
+                draft.failedJePostings = {
+                    fetchState: { fetchState: 'Completed', error: undefined },
+                    jeScheduleTransactionKeys: action.payload.failedJeSchedules.map((schedule) => (0, jeSchedulesPayload_1.getJEScheduleTransactionDetailKeyPayload)(schedule.base_transaction)),
+                };
+            },
+            prepare(failedJeSchedules) {
+                return { payload: { failedJeSchedules } };
+            },
+        },
+        fetchFailedJePostingsFailure: {
+            reducer(draft, action) {
+                // Keys are deliberately left alone. The schedules list clears its buckets on failure so an
+                // errored tab cannot read as "these are all the schedules there are", but this list is a
+                // set of outstanding problems -- showing the last known ones beside an error beats
+                // implying there are none.
+                draft.failedJePostings.fetchState = {
+                    fetchState: 'Error',
+                    error: action.payload.status,
+                };
+            },
+            prepare(status) {
+                return { payload: { status } };
+            },
+        },
         fetchJeSchedulesSuccess(draft, action) {
             const { jeSchedules, selectedPeriod, selectedPageTab, failedJeSchedules, accruedJeSchedules, oneTimeAccruals, refreshViewInBackground, } = action.payload;
             const periodTabKey = (0, jeSchedulesViewState_1.getJESchedulePeriodTabKey)(selectedPageTab, (0, timePeriod_1.toMonthYearPeriodId)(selectedPeriod));
@@ -364,6 +418,8 @@ const expenseAutomationJESchedulesView = (0, toolkit_1.createSlice)({
             reducer(draft, action) {
                 const { failedJeScheduleKey } = action.payload;
                 removeKeyFromEveryTabSlot(draft.failedJeScheduleTransactionKeysByPeriodAndTab, failedJeScheduleKey);
+                draft.failedJePostings.jeScheduleTransactionKeys =
+                    draft.failedJePostings.jeScheduleTransactionKeys.filter((jeScheduleKey) => jeScheduleKey !== failedJeScheduleKey);
             },
         },
         initializeJeScheduleLocalData: {
@@ -706,6 +762,9 @@ const expenseAutomationJESchedulesView = (0, toolkit_1.createSlice)({
             draft.uiState.createdGroupCollapsed =
                 !draft.uiState.createdGroupCollapsed;
         },
+        toggleJEFailedGroupCollapsed(draft) {
+            draft.uiState.failedGroupCollapsed = !draft.uiState.failedGroupCollapsed;
+        },
         clearExpenseAutomationJESchedulesView(draft) {
             Object.assign(draft, exports.initialState);
         },
@@ -716,7 +775,7 @@ const expenseAutomationJESchedulesView = (0, toolkit_1.createSlice)({
         });
     },
 });
-_a = expenseAutomationJESchedulesView.actions, exports.clearExpenseAutomationJESchedulesView = _a.clearExpenseAutomationJESchedulesView, exports.clearJeAccountSettingsLocalData = _a.clearJeAccountSettingsLocalData, exports.clearJeScheduleLocalData = _a.clearJeScheduleLocalData, exports.clearSearchTransactionsForNewSchedule = _a.clearSearchTransactionsForNewSchedule, exports.createOneTimeAccrual = _a.createOneTimeAccrual, exports.createOneTimeAccrualFailure = _a.createOneTimeAccrualFailure, exports.createOneTimeAccrualSuccess = _a.createOneTimeAccrualSuccess, exports.ignoreOneTimeAccrual = _a.ignoreOneTimeAccrual, exports.oneTimeAccrualActionFailure = _a.oneTimeAccrualActionFailure, exports.oneTimeAccrualActionSuccess = _a.oneTimeAccrualActionSuccess, exports.promoteOneTimeAccrual = _a.promoteOneTimeAccrual, exports.revertJeSchedule = _a.revertJeSchedule, exports.revertJeScheduleFailure = _a.revertJeScheduleFailure, exports.revertJeScheduleSuccess = _a.revertJeScheduleSuccess, exports.revertOneTimeAccrual = _a.revertOneTimeAccrual, exports.fetchAccountSettingsListForAccountTypes = _a.fetchAccountSettingsListForAccountTypes, exports.fetchJeSchedules = _a.fetchJeSchedules, exports.fetchJeSchedulesFailure = _a.fetchJeSchedulesFailure, exports.fetchJeSchedulesPage = _a.fetchJeSchedulesPage, exports.fetchJeSchedulesSuccess = _a.fetchJeSchedulesSuccess, exports.fetchOneTimeAccrual = _a.fetchOneTimeAccrual, exports.fetchOneTimeAccrualFailure = _a.fetchOneTimeAccrualFailure, exports.fetchOneTimeAccrualSuccess = _a.fetchOneTimeAccrualSuccess, exports.fetchRecommendationForAccountSettings = _a.fetchRecommendationForAccountSettings, exports.ignoreRecommendedJeSchedule = _a.ignoreRecommendedJeSchedule, exports.ignoreRecommendedJeScheduleFailure = _a.ignoreRecommendedJeScheduleFailure, exports.ignoreRecommendedJeScheduleSuccess = _a.ignoreRecommendedJeScheduleSuccess, exports.initializeAccountSettingsView = _a.initializeAccountSettingsView, exports.initializeJeScheduleLocalData = _a.initializeJeScheduleLocalData, exports.initializeNewSchedule = _a.initializeNewSchedule, exports.removeFailedJeScheduleTransactionKey = _a.removeFailedJeScheduleTransactionKey, exports.removeJeOneTimeAccrualLocalData = _a.removeJeOneTimeAccrualLocalData, exports.removeJeScheduleLocalDataById = _a.removeJeScheduleLocalDataById, exports.removeJeAccruedScheduleKey = _a.removeJeAccruedScheduleKey, exports.removeJeScheduleTransactionKey = _a.removeJeScheduleTransactionKey, exports.resetNewScheduleLocalData = _a.resetNewScheduleLocalData, exports.retryJeSchedule = _a.retryJeSchedule, exports.retryJeScheduleFailure = _a.retryJeScheduleFailure, exports.retryJeScheduleSuccess = _a.retryJeScheduleSuccess, exports.saveAccountSettings = _a.saveAccountSettings, exports.saveAccountSettingsFailure = _a.saveAccountSettingsFailure, exports.saveAccountSettingsLocalData = _a.saveAccountSettingsLocalData, exports.saveAccountSettingsSuccess = _a.saveAccountSettingsSuccess, exports.saveNewSchedule = _a.saveNewSchedule, exports.saveNewScheduleFailure = _a.saveNewScheduleFailure, exports.saveNewScheduleSuccess = _a.saveNewScheduleSuccess, exports.searchTransactionsForNewSchedule = _a.searchTransactionsForNewSchedule, exports.searchTransactionsForNewScheduleFailure = _a.searchTransactionsForNewScheduleFailure, exports.searchTransactionsForNewScheduleSuccess = _a.searchTransactionsForNewScheduleSuccess, exports.toggleJECreatedGroupCollapsed = _a.toggleJECreatedGroupCollapsed, exports.toggleJEPendingGroupCollapsed = _a.toggleJEPendingGroupCollapsed, exports.updateAccountSettingsListForAccountTypes = _a.updateAccountSettingsListForAccountTypes, exports.updateAccountSettingsListForAccountTypesFailure = _a.updateAccountSettingsListForAccountTypesFailure, exports.updateJESchedulesUIState = _a.updateJESchedulesUIState, exports.updateJEScheduleTypeFilter = _a.updateJEScheduleTypeFilter, exports.updateJeOneTimeAccrualLocalData = _a.updateJeOneTimeAccrualLocalData, exports.updateJeScheduleLocalDataById = _a.updateJeScheduleLocalDataById, exports.updateJeScheduleTransactionKeys = _a.updateJeScheduleTransactionKeys, exports.updateNewScheduleLocalData = _a.updateNewScheduleLocalData, exports.updateRecommendationForAccountSettings = _a.updateRecommendationForAccountSettings, exports.updateRecommendationForAccountSettingsFailure = _a.updateRecommendationForAccountSettingsFailure;
+_a = expenseAutomationJESchedulesView.actions, exports.clearExpenseAutomationJESchedulesView = _a.clearExpenseAutomationJESchedulesView, exports.clearJeAccountSettingsLocalData = _a.clearJeAccountSettingsLocalData, exports.clearJeScheduleLocalData = _a.clearJeScheduleLocalData, exports.clearSearchTransactionsForNewSchedule = _a.clearSearchTransactionsForNewSchedule, exports.createOneTimeAccrual = _a.createOneTimeAccrual, exports.createOneTimeAccrualFailure = _a.createOneTimeAccrualFailure, exports.createOneTimeAccrualSuccess = _a.createOneTimeAccrualSuccess, exports.ignoreOneTimeAccrual = _a.ignoreOneTimeAccrual, exports.oneTimeAccrualActionFailure = _a.oneTimeAccrualActionFailure, exports.oneTimeAccrualActionSuccess = _a.oneTimeAccrualActionSuccess, exports.promoteOneTimeAccrual = _a.promoteOneTimeAccrual, exports.revertJeSchedule = _a.revertJeSchedule, exports.revertJeScheduleFailure = _a.revertJeScheduleFailure, exports.revertJeScheduleSuccess = _a.revertJeScheduleSuccess, exports.revertOneTimeAccrual = _a.revertOneTimeAccrual, exports.fetchAccountSettingsListForAccountTypes = _a.fetchAccountSettingsListForAccountTypes, exports.fetchJeSchedules = _a.fetchJeSchedules, exports.fetchFailedJePostings = _a.fetchFailedJePostings, exports.fetchFailedJePostingsFailure = _a.fetchFailedJePostingsFailure, exports.fetchFailedJePostingsSuccess = _a.fetchFailedJePostingsSuccess, exports.fetchJeSchedulesFailure = _a.fetchJeSchedulesFailure, exports.fetchJeSchedulesPage = _a.fetchJeSchedulesPage, exports.fetchJeSchedulesSuccess = _a.fetchJeSchedulesSuccess, exports.fetchOneTimeAccrual = _a.fetchOneTimeAccrual, exports.fetchOneTimeAccrualFailure = _a.fetchOneTimeAccrualFailure, exports.fetchOneTimeAccrualSuccess = _a.fetchOneTimeAccrualSuccess, exports.fetchRecommendationForAccountSettings = _a.fetchRecommendationForAccountSettings, exports.ignoreRecommendedJeSchedule = _a.ignoreRecommendedJeSchedule, exports.ignoreRecommendedJeScheduleFailure = _a.ignoreRecommendedJeScheduleFailure, exports.ignoreRecommendedJeScheduleSuccess = _a.ignoreRecommendedJeScheduleSuccess, exports.initializeAccountSettingsView = _a.initializeAccountSettingsView, exports.initializeJeScheduleLocalData = _a.initializeJeScheduleLocalData, exports.initializeNewSchedule = _a.initializeNewSchedule, exports.removeFailedJeScheduleTransactionKey = _a.removeFailedJeScheduleTransactionKey, exports.removeJeOneTimeAccrualLocalData = _a.removeJeOneTimeAccrualLocalData, exports.removeJeScheduleLocalDataById = _a.removeJeScheduleLocalDataById, exports.removeJeAccruedScheduleKey = _a.removeJeAccruedScheduleKey, exports.removeJeScheduleTransactionKey = _a.removeJeScheduleTransactionKey, exports.resetNewScheduleLocalData = _a.resetNewScheduleLocalData, exports.retryJeSchedule = _a.retryJeSchedule, exports.retryJeScheduleFailure = _a.retryJeScheduleFailure, exports.retryJeScheduleSuccess = _a.retryJeScheduleSuccess, exports.saveAccountSettings = _a.saveAccountSettings, exports.saveAccountSettingsFailure = _a.saveAccountSettingsFailure, exports.saveAccountSettingsLocalData = _a.saveAccountSettingsLocalData, exports.saveAccountSettingsSuccess = _a.saveAccountSettingsSuccess, exports.saveNewSchedule = _a.saveNewSchedule, exports.saveNewScheduleFailure = _a.saveNewScheduleFailure, exports.saveNewScheduleSuccess = _a.saveNewScheduleSuccess, exports.searchTransactionsForNewSchedule = _a.searchTransactionsForNewSchedule, exports.searchTransactionsForNewScheduleFailure = _a.searchTransactionsForNewScheduleFailure, exports.searchTransactionsForNewScheduleSuccess = _a.searchTransactionsForNewScheduleSuccess, exports.toggleJECreatedGroupCollapsed = _a.toggleJECreatedGroupCollapsed, exports.toggleJEFailedGroupCollapsed = _a.toggleJEFailedGroupCollapsed, exports.toggleJEPendingGroupCollapsed = _a.toggleJEPendingGroupCollapsed, exports.updateAccountSettingsListForAccountTypes = _a.updateAccountSettingsListForAccountTypes, exports.updateAccountSettingsListForAccountTypesFailure = _a.updateAccountSettingsListForAccountTypesFailure, exports.updateJESchedulesUIState = _a.updateJESchedulesUIState, exports.updateJEScheduleTypeFilter = _a.updateJEScheduleTypeFilter, exports.updateJeOneTimeAccrualLocalData = _a.updateJeOneTimeAccrualLocalData, exports.updateJeScheduleLocalDataById = _a.updateJeScheduleLocalDataById, exports.updateJeScheduleTransactionKeys = _a.updateJeScheduleTransactionKeys, exports.updateNewScheduleLocalData = _a.updateNewScheduleLocalData, exports.updateRecommendationForAccountSettings = _a.updateRecommendationForAccountSettings, exports.updateRecommendationForAccountSettingsFailure = _a.updateRecommendationForAccountSettingsFailure;
 exports.default = expenseAutomationJESchedulesView.reducer;
 const doUpdateRecommendationForAccountSettings = (draft, payload) => {
     const { prepaidExpensesRecommendations, fixedAssetsRecommendations, accruedExpensesRecommendations, } = (0, accountTypeRecommendationPayload_1.mapAccountTypeRecommendationPayloadToAccountRecommendationByType)(payload);

package/lib/view/expenseAutomationView/selectorTypes/jeSchedulesSelectorTypes.d.ts

@@ -47,6 +47,7 @@ export interface ExpenseAutomationJESchedulesViewSelector extends SelectorView {
     completionStatus: CompletionStatusType;
     createdSchedules: JEScheduleRow[];
     createdTotal: number;
+    failedPostings: JEScheduledTransactionWithFailedEntries[];
     hasLoadedForSelectedTab: boolean;
     ignoreStatusById: Record<JEScheduleTransactionKey, FetchStateAndError>;
     jeScheduleLocalDataById: Record<ID, JEScheduleLocalData>;
@@ -61,6 +62,7 @@ export interface ExpenseAutomationJESchedulesViewSelector extends SelectorView {
     pendingReviewTotal: number;
     postStatusById: Record<ID, FetchStateAndError>;
     refreshStatus: FetchStateAndError;
+    /** @deprecated Alias of `failedPostings`. Remove once webc and app-ui are repointed. */
     resolveSchedules: JEScheduledTransactionWithFailedEntries[];
     revertStatusById: Record<JEScheduleKey | JEScheduleTransactionKey, FetchStateAndError>;
     scheduleCountsByTab: Partial<Record<JEPageTab, number>>;

package/lib/view/expenseAutomationView/selectors/jeSchedulesViewSelector.js

@@ -225,7 +225,7 @@ function getExpenseAutomationJESchedulesView(state) {
     const accruedSchedules = [];
     const oneTimeAccruals = [];
     const { accountState, accountListState, classState, classListState, expenseAutomationJESchedulesViewState, expenseAutomationViewState, monthEndCloseChecksState, } = state;
-    const { jeScheduleTransactionKeysByPeriodAndTab, jeScheduleAccruedKeysByPeriodAndTab, jeScheduleOneTimeAccrualKeysByPeriodAndTab, failedJeScheduleTransactionKeysByPeriodAndTab, jeScheduleLocalDataById, postStatusById, ignoreStatusById, revertStatusById, oneTimeAccrualActionStatusById, uiState, error, fetchState, refreshStatus, newSchedule, } = expenseAutomationJESchedulesViewState;
+    const { jeScheduleTransactionKeysByPeriodAndTab, jeScheduleAccruedKeysByPeriodAndTab, jeScheduleOneTimeAccrualKeysByPeriodAndTab, failedJePostings, jeScheduleLocalDataById, postStatusById, ignoreStatusById, revertStatusById, oneTimeAccrualActionStatusById, uiState, error, fetchState, refreshStatus, newSchedule, } = expenseAutomationJESchedulesViewState;
     const accountSettingsView = (0, jeAccountSettingsViewSelector_1.getJEAccountSettingsView)(state);
     const newScheduleView = newSchedule.selectedDetailScheduleType === 'fixed_assets' ||
         newSchedule.selectedDetailScheduleType === 'prepaid_expenses'
@@ -264,15 +264,11 @@ function getExpenseAutomationJESchedulesView(state) {
     const jeScheduleTransactionKeysForSelectedTab = selectedPeriodTabKey != null
         ? jeScheduleTransactionKeysByPeriodAndTab[selectedPeriodTabKey]
         : undefined;
-    const failedJeScheduleTransactionKeysForSelectedTab = selectedPeriodTabKey != null
-        ? failedJeScheduleTransactionKeysByPeriodAndTab[selectedPeriodTabKey]
-        : undefined;
     // Distinguishes "this tab has never been fetched for this period" from "fetched and genuinely
     // empty". Without it the page cannot tell a first visit from a real empty state, and renders an
     // empty table where it should render a skeleton.
     const hasLoadedForSelectedTab = jeScheduleTransactionKeysForSelectedTab != null;
     const jeScheduleTransactionKeys = jeScheduleTransactionKeysForSelectedTab ?? [];
-    const failedJeScheduleTransactionKeys = failedJeScheduleTransactionKeysForSelectedTab ?? [];
     const jeScheduleAccruedKeys = (selectedPeriodTabKey != null
         ? jeScheduleAccruedKeysByPeriodAndTab[selectedPeriodTabKey]
         : undefined) ?? [];
@@ -295,11 +291,16 @@ function getExpenseAutomationJESchedulesView(state) {
             accruedSchedules.push(accruedScheduleDetails);
         }
     });
-    failedJeScheduleTransactionKeys.forEach((jeScheduleKey) => {
+    // Sourced from the tenant-wide bucket, not the per-period one: a failed posting belongs to no
+    // close month, and windowing it is what kept older failures off the only tab that can resolve
+    // them.
+    failedJePostings.jeScheduleTransactionKeys.forEach((jeScheduleKey) => {
         const jeScheduleDetails = (0, jeSchedulesSelector_1.getJEScheduledTransactionByJEScheduleTransactionKey)(jeScheduleKey, state);
         failedJeScheduledTransaction.push(jeScheduleDetails);
     });
     const { sortKey, sortOrder, selectedJETypeFilter } = uiState;
+    const matchesTypeFilter = (schedule) => selectedJETypeFilter == null ||
+        getJEScheduleRowType(schedule) === selectedJETypeFilter;
     const unsortedResolveSchedules = [];
     failedJeScheduledTransaction.forEach((schedule) => {
         schedule.scheduledJournalEntry.forEach((journalEntry) => {
@@ -309,10 +310,7 @@ function getExpenseAutomationJESchedulesView(state) {
             });
         });
     });
-    const resolveSchedules = sortJEScheduledTransactions(unsortedResolveSchedules, sortKey, sortOrder);
-    const validResolveForPending = unsortedResolveSchedules.filter((r) => jeScheduleLocalDataById[r.scheduledJournalEntry.scheduledJournalEntryID] != null);
-    const matchesTypeFilter = (schedule) => selectedJETypeFilter == null ||
-        getJEScheduleRowType(schedule) === selectedJETypeFilter;
+    const resolveSchedules = sortJEScheduledTransactions(unsortedResolveSchedules.filter(matchesTypeFilter), sortKey, sortOrder);
     const isCreatedStatus = (schedule) => {
         // An accrual is "created" once it is not review work: posted, reversing, reversed, or in a
         // transient posting claim.
@@ -330,7 +328,6 @@ function getExpenseAutomationJESchedulesView(state) {
     ];
     const pendingReviewSchedules = sortJEScheduledTransactions([
         ...allScheduleRows.filter((schedule) => isPendingReviewRow(schedule) && matchesTypeFilter(schedule)),
-        ...validResolveForPending,
     ], sortKey, sortOrder);
     const createdSchedules = sortJEScheduledTransactions(allScheduleRows.filter((schedule) => isCreatedStatus(schedule) && matchesTypeFilter(schedule)), sortKey, sortOrder);
     // KPI summary — derived from unfiltered schedules so counts are always accurate
@@ -449,6 +446,9 @@ function getExpenseAutomationJESchedulesView(state) {
         kpiSummary,
         pendingReviewSchedules,
         pendingReviewTotal,
+        failedPostings: resolveSchedules,
+        // Deprecated alias of failedPostings. Still read by the section's footer-form effect and by
+        // app-ui analytics; remove once both are repointed.
         resolveSchedules: resolveSchedules,
         accountSettingsView,
         newScheduleView,

package/lib/view/expenseAutomationView/types/jeSchedulesViewState.d.ts

@@ -19,6 +19,7 @@ export type JESchedulePeriodTabKey = `${JEPageTab}_${MonthYearPeriodId}`;
 export declare const getJESchedulePeriodTabKey: (selectedPageTab: JEPageTab, monthYearPeriodId: MonthYearPeriodId) => JESchedulePeriodTabKey;
 export interface JESchedulesViewUIState {
     createdGroupCollapsed: boolean;
+    failedGroupCollapsed: boolean;
     pendingGroupCollapsed: boolean;
     scrollPosition: {
         scrollTop: number;
@@ -41,8 +42,22 @@ export interface JEScheduleLocalData {
     updatedClassId?: ID;
     updatedVendor?: VendorBase;
 }
+/**
+ * The Failed Postings bucket, and the only list on this page that is not scoped to a period.
+ *
+ * A failed posting is broken until someone resolves it, whatever month it belongs to, so windowing
+ * it the way the schedule lists are windowed is what hid a March failure from the September close.
+ * It therefore has no period-tab key, and its own fetch state rather than the slice's: the list is
+ * fetched separately from `/1.0/expenses_automation/failed_je_postings`, so a slow or failing
+ * lookup here must not blank the schedules table, or vice versa.
+ */
+export interface FailedJePostingsState {
+    fetchState: FetchStateAndError;
+    jeScheduleTransactionKeys: JEScheduleTransactionKey[];
+}
 export interface JESchedulesViewState extends FetchedState {
     accountSettings: AccountSettingsState;
+    failedJePostings: FailedJePostingsState;
     failedJeScheduleTransactionKeysByPeriodAndTab: Record<JESchedulePeriodTabKey, JEScheduleTransactionKey[]>;
     ignoreStatusById: Record<JEScheduleTransactionKey, FetchStateAndError>;
     jeScheduleAccruedKeysByPeriodAndTab: Record<JESchedulePeriodTabKey, JEScheduleKey[]>;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.2.49",
+  "version": "5.2.50-betaRD1",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",