@zeniai/client-epic-state 5.2.4 → 5.2.6

package/lib/view/aiCfoView/epics/toSkillDetail.d.ts

@@ -0,0 +1,88 @@
+import { SkillDetailDataPayload, SkillSummaryPayload } from '../aiCfoViewPayload';
+import { Skill, SkillDetail, SkillVisibility } from '../aiCfoViewState';
+/**
+ * A wire string narrowed to {@link SkillVisibility}, or null.
+ *
+ * A converter rather than passing the raw string through, because `Skill.visibility` is a
+ * union on the state type and this is the boundary where an unvalidated payload becomes
+ * it — the repo's rule about explicit converters at scalar boundaries instead of a bare
+ * cast.
+ *
+ * Unrecognised maps to NULL, not to `'private'`. Null already means "does not apply" for a
+ * Zeni default, and consumers show no audience badge for it — so an unknown tier renders
+ * as no badge. Defaulting to `'private'` would instead label a skill the whole tenant can
+ * run as author-only, which is a confident lie rather than a visible gap.
+ */
+export declare const toSkillVisibility: (raw: string | null | undefined) => SkillVisibility | null;
+/**
+ * What the version-body read needs, and nothing more.
+ *
+ * A `Pick` of the payload rather than a type of its own: `SkillDetailDataPayload` now
+ * marks the three unchecked fields optional itself, the same way `SkillSummaryPayload`
+ * does, so there is one idiom for "this endpoint is not schema-validated" instead of two.
+ */
+type PromptBody = Pick<SkillDetailDataPayload, 'instructions'>;
+/**
+ * Everything about a skill summary EXCEPT `exampleHints`, which no shared mapper can
+ * honestly supply.
+ *
+ * Only the LIST route returns `parameter_hints`; the detail and write routes do not. A
+ * shared mapper hardcoding `exampleHints: []` would put a "try: …" line under a skill
+ * that has hints, or drop them from the menu — so the field is `Omit`ted and each caller
+ * spreads in what its own route actually knows.
+ *
+ * Returning `Omit<Skill, 'exampleHints'>` rather than duplicating the mapper is what
+ * makes a new `Skill` field land in one place: this function stops compiling until the
+ * field is mapped, and both callers inherit it. The previous shape — two full copies —
+ * is how `isMine` was nearly added to only one of them, which would have silently
+ * withheld the edit and delete controls on whichever surface was missed.
+ */
+export declare const toBaseSkill: (payload: SkillSummaryPayload) => Omit<Skill, "exampleHints">;
+/**
+ * Whether a 2xx body carries a prompt.
+ *
+ * Narrows to {@link PromptBody} and NOT to the whole payload, because the only consumer —
+ * the version-body read — dereferences `instructions` and nothing else. Asserting the
+ * whole shape here would claim `skill` was checked when it was not, and tying the read to
+ * it would fail a response whose prompt was fine and whose `skill` block was malformed,
+ * which is exactly what happened when this was one predicate instead of two.
+ *
+ * Takes `unknown`: the input is an unvalidated network body, and typing the parameter as
+ * the payload interface would assume the very thing being checked.
+ */
+export declare const hasPromptBody: (data: unknown) => data is PromptBody;
+/**
+ * Whether a 2xx body can build a whole {@link SkillDetail}.
+ *
+ * Narrows to the payload type itself, which is now truthful: the two fields this checks
+ * are the two the interface still declares required, and the other three are optional
+ * there. Stricter than {@link hasPromptBody} by exactly one field. Four epics read this shape
+ * and each used to guard it differently — `data != null`, `data?.skill != null`, and a
+ * real `instructions` check — so one malformed response became a failure in one place, an
+ * empty prompt in another, and `undefined` in a third.
+ */
+export declare const isSkillDetailPayload: (data: unknown) => data is SkillDetailDataPayload;
+/**
+ * The detail payload every write route answers with.
+ *
+ * Shared because three epics need it — save, visibility, and the detail read — and a
+ * fourth copy is how one of them quietly stops carrying a field the others do.
+ *
+ * The coercions are not defensive habit; the payload type makes them mandatory — the
+ * three optional fields cannot be assigned to a non-optional `SkillDetail` without one.
+ * Which fields get coerced and which do not is the deliberate part:
+ *
+ * - `instructions` is load-bearing and already proven, so it passes through. Defaulting a
+ *   missing prompt to `''` is the one thing this module exists to prevent: the user
+ *   cannot tell an empty prompt from a skill that has one, and may save over the real
+ *   thing.
+ * - `instructionsCharCount` falls back to the prompt's own length, NOT to 0. A 12,000
+ *   character prompt displayed as "0 characters" is a lie the user can see, and the
+ *   prompt is right here to measure. Approximate only for astral-plane characters, where
+ *   UTF-16 units and the server's count differ — a rounding error, against a guaranteed
+ *   wrong answer.
+ * - `artifact` and `artifactTitle` degrade to empty. They render a preview card, so
+ *   losing them costs a card; failing the whole read would cost the user the skill.
+ */
+export declare const toSkillDetail: (payload: SkillDetailDataPayload) => SkillDetail;
+export {};

package/lib/view/aiCfoView/epics/toSkillDetail.js

@@ -0,0 +1,110 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.toSkillDetail = exports.isSkillDetailPayload = exports.hasPromptBody = exports.toBaseSkill = exports.toSkillVisibility = void 0;
+/**
+ * Every value `SkillVisibility` admits, as data so the converter below cannot drift from
+ * the type. Adding a tier to the union without adding it here is a compile error.
+ */
+const SKILL_VISIBILITIES = ['private', 'tenant'];
+/**
+ * A wire string narrowed to {@link SkillVisibility}, or null.
+ *
+ * A converter rather than passing the raw string through, because `Skill.visibility` is a
+ * union on the state type and this is the boundary where an unvalidated payload becomes
+ * it — the repo's rule about explicit converters at scalar boundaries instead of a bare
+ * cast.
+ *
+ * Unrecognised maps to NULL, not to `'private'`. Null already means "does not apply" for a
+ * Zeni default, and consumers show no audience badge for it — so an unknown tier renders
+ * as no badge. Defaulting to `'private'` would instead label a skill the whole tenant can
+ * run as author-only, which is a confident lie rather than a visible gap.
+ */
+const toSkillVisibility = (raw) => SKILL_VISIBILITIES.find((known) => known === raw) ?? null;
+exports.toSkillVisibility = toSkillVisibility;
+/**
+ * Everything about a skill summary EXCEPT `exampleHints`, which no shared mapper can
+ * honestly supply.
+ *
+ * Only the LIST route returns `parameter_hints`; the detail and write routes do not. A
+ * shared mapper hardcoding `exampleHints: []` would put a "try: …" line under a skill
+ * that has hints, or drop them from the menu — so the field is `Omit`ted and each caller
+ * spreads in what its own route actually knows.
+ *
+ * Returning `Omit<Skill, 'exampleHints'>` rather than duplicating the mapper is what
+ * makes a new `Skill` field land in one place: this function stops compiling until the
+ * field is mapped, and both callers inherit it. The previous shape — two full copies —
+ * is how `isMine` was nearly added to only one of them, which would have silently
+ * withheld the edit and delete controls on whichever surface was missed.
+ */
+const toBaseSkill = (payload) => ({
+    macroId: payload.macro_id,
+    name: payload.name,
+    displayName: payload.display_name,
+    description: payload.description,
+    semver: payload.semver,
+    hasScripts: payload.has_scripts === true,
+    // === true, so an absent field withholds the write controls rather than offering ones
+    // the API refuses.
+    isMine: payload.is_mine === true,
+    isOwnedByTenant: payload.is_owned_by_tenant === true,
+    updatedAt: payload.updated_at ?? null,
+    visibility: (0, exports.toSkillVisibility)(payload.visibility),
+});
+exports.toBaseSkill = toBaseSkill;
+/**
+ * Whether a 2xx body carries a prompt.
+ *
+ * Narrows to {@link PromptBody} and NOT to the whole payload, because the only consumer —
+ * the version-body read — dereferences `instructions` and nothing else. Asserting the
+ * whole shape here would claim `skill` was checked when it was not, and tying the read to
+ * it would fail a response whose prompt was fine and whose `skill` block was malformed,
+ * which is exactly what happened when this was one predicate instead of two.
+ *
+ * Takes `unknown`: the input is an unvalidated network body, and typing the parameter as
+ * the payload interface would assume the very thing being checked.
+ */
+const hasPromptBody = (data) => typeof data?.instructions ===
+    'string';
+exports.hasPromptBody = hasPromptBody;
+/**
+ * Whether a 2xx body can build a whole {@link SkillDetail}.
+ *
+ * Narrows to the payload type itself, which is now truthful: the two fields this checks
+ * are the two the interface still declares required, and the other three are optional
+ * there. Stricter than {@link hasPromptBody} by exactly one field. Four epics read this shape
+ * and each used to guard it differently — `data != null`, `data?.skill != null`, and a
+ * real `instructions` check — so one malformed response became a failure in one place, an
+ * empty prompt in another, and `undefined` in a third.
+ */
+const isSkillDetailPayload = (data) => (0, exports.hasPromptBody)(data) && data.skill != null;
+exports.isSkillDetailPayload = isSkillDetailPayload;
+/**
+ * The detail payload every write route answers with.
+ *
+ * Shared because three epics need it — save, visibility, and the detail read — and a
+ * fourth copy is how one of them quietly stops carrying a field the others do.
+ *
+ * The coercions are not defensive habit; the payload type makes them mandatory — the
+ * three optional fields cannot be assigned to a non-optional `SkillDetail` without one.
+ * Which fields get coerced and which do not is the deliberate part:
+ *
+ * - `instructions` is load-bearing and already proven, so it passes through. Defaulting a
+ *   missing prompt to `''` is the one thing this module exists to prevent: the user
+ *   cannot tell an empty prompt from a skill that has one, and may save over the real
+ *   thing.
+ * - `instructionsCharCount` falls back to the prompt's own length, NOT to 0. A 12,000
+ *   character prompt displayed as "0 characters" is a lie the user can see, and the
+ *   prompt is right here to measure. Approximate only for astral-plane characters, where
+ *   UTF-16 units and the server's count differ — a rounding error, against a guaranteed
+ *   wrong answer.
+ * - `artifact` and `artifactTitle` degrade to empty. They render a preview card, so
+ *   losing them costs a card; failing the whole read would cost the user the skill.
+ */
+const toSkillDetail = (payload) => ({
+    skill: { ...(0, exports.toBaseSkill)(payload.skill), exampleHints: [] },
+    instructions: payload.instructions,
+    instructionsCharCount: payload.instructions_char_count ?? payload.instructions.length,
+    artifact: payload.artifact ?? '',
+    artifactTitle: payload.artifact_title ?? '',
+});
+exports.toSkillDetail = toSkillDetail;

package/lib/view/invoicing/editInvoicingCatalogItemDetailView/editInvoicingCatalogItemDetailViewSelector.d.ts

@@ -1,3 +1,5 @@
+import { NestedAccountHierarchyForReport } from '../../../commonStateTypes/accountView/nestedAccountID';
+import { NestedClassHierarchyForReport } from '../../../commonStateTypes/classesView/nestedClassID';
 import { FetchStateAndError, ID } from '../../../commonStateTypes/common';
 import { SelectorView } from '../../../commonStateTypes/viewAndReport/viewAndReport';
 import { InvoicingFieldHelpByCode, InvoicingNamedOption, InvoicingNamedOptionsByKey } from '../../../entity/invoicing/invoicingCommonPayload';
@@ -40,6 +42,13 @@ export interface InvoicingCatalogItemFormView extends SelectorView {
     periodUnitOptions: InvoicingNamedOption[];
     pricingModelValues: readonly string[];
     prorationValues: readonly string[];
+    /**
+     * Account and class trees for the price-point pickers, already narrowed to the
+     * income accounts a price may post to. Empty until QBO is connected — the form
+     * must not offer a mapping that cannot be pushed.
+     */
+    qboClassHierarchy: NestedClassHierarchyForReport[];
+    qboIncomeAccountHierarchy: NestedAccountHierarchyForReport[];
     tierTypeValues: readonly string[];
     trialEndActionOptions: InvoicingNamedOption[];
     trialUnitOptions: InvoicingNamedOption[];

package/lib/view/invoicing/editInvoicingCatalogItemDetailView/editInvoicingCatalogItemDetailViewSelector.js

@@ -4,6 +4,7 @@ exports.getInvoicingCatalogItemFormView = exports.getInvoicingApplicableCatalogI
 const toolkit_1 = require("@reduxjs/toolkit");
 const planSelector_1 = require("../../../entity/invoicing/plan/planSelector");
 const invoicingConfigViewSelector_1 = require("../invoicingConfigView/invoicingConfigViewSelector");
+const invoicingQboViewSelector_1 = require("../invoicingQboView/invoicingQboViewSelector");
 const invoicingCatalogItemFormConfig_1 = require("./invoicingCatalogItemFormConfig");
 const getEditInvoicingCatalogItemDetailViewState = (state) => ({
     fetchState: state.editInvoicingCatalogItemDetailViewState.fetchState,
@@ -54,9 +55,16 @@ const getInvoicingCatalogItemFormView = (state, id) => {
     const applicableItemOptions = id != null
         ? allApplicableItemOptions.filter((option) => option.id !== id)
         : allApplicableItemOptions;
+    const isQboConnected = (0, invoicingQboViewSelector_1.isInvoicingQboConnected)(state);
     const { billingPeriodUnitOptions, catalogItemTypeOptions, catalogTierTypeOptionsByPricingModel, catalogTrialEndActionOptions, catalogTrialUnitOptions, } = (0, invoicingConfigViewSelector_1.getInvoicingConfigView)(state);
     return {
         fieldHelp: (0, invoicingConfigViewSelector_1.invoicingFieldHelpForGroup)(state, 'catalog'),
+        qboClassHierarchy: isQboConnected
+            ? (0, invoicingQboViewSelector_1.getInvoicingQboView)(state).nestedClassHierarchy
+            : [],
+        qboIncomeAccountHierarchy: isQboConnected
+            ? (0, invoicingQboViewSelector_1.invoicingAccountHierarchyForTypes)(state, invoicingQboViewSelector_1.INVOICING_INCOME_ACCOUNT_TYPES)
+            : [],
         applicabilityValues: invoicingCatalogItemFormConfig_1.INVOICING_CATALOG_APPLICABILITY_VALUES,
         applicableItemOptions,
         localData,

package/lib/view/invoicing/invoicingQboView/epics/fetchInvoicingAccountingPickersEpic.d.ts

@@ -0,0 +1,5 @@
+import { ActionsObservable, StateObservable } from 'redux-observable';
+import { Observable } from 'rxjs';
+import { RootState } from '../../../../rootStateTypes';
+import { InvoicingQboViewActionType } from './invoicingQboViewActionType';
+export declare const fetchInvoicingAccountingPickersEpic: (actions$: ActionsObservable<InvoicingQboViewActionType>, state$: StateObservable<RootState>) => Observable<InvoicingQboViewActionType>;

package/lib/view/invoicing/invoicingQboView/epics/fetchInvoicingAccountingPickersEpic.js

@@ -0,0 +1,33 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.fetchInvoicingAccountingPickersEpic = void 0;
+const rxjs_1 = require("rxjs");
+const operators_1 = require("rxjs/operators");
+const accountListReducer_1 = require("../../../accountList/accountListReducer");
+const classListReducer_1 = require("../../../classList/classListReducer");
+const invoicingQboViewReducer_1 = require("../invoicingQboViewReducer");
+const invoicingQboViewSelector_1 = require("../invoicingQboViewSelector");
+// Tops up the shared account and class lists, skipping either when the store
+// already holds it or has it in flight.
+const fetchInvoicingAccountingPickersEpic = (actions$, state$) => actions$.pipe((0, operators_1.filter)(invoicingQboViewReducer_1.fetchInvoicingAccountingPickers.match), (0, operators_1.withLatestFrom)(state$), (0, operators_1.mergeMap)(([, state]) => {
+    const actions = [];
+    const accountList = state.accountListState.byReportId[invoicingQboViewSelector_1.INVOICING_ACCOUNT_LIST_KEY];
+    if (accountList.hasValidState() === false &&
+        accountList.fetchState !== 'In-Progress') {
+        // AP/AR accounts cannot back an invoicing mapping, so they are excluded
+        // here — which is why this uses invoicing's own bucket rather than the
+        // general `accountList` other screens fill without those exclusions.
+        actions.push((0, accountListReducer_1.fetchAccountList)(invoicingQboViewSelector_1.INVOICING_ACCOUNT_LIST_KEY, true, true, true));
+    }
+    const classList = state.classListState;
+    if (classList.hasValidState() === false &&
+        classList.fetchState !== 'In-Progress') {
+        // Without deleted classes, matching almost every other caller of this
+        // single global slice. Asking for deleted rows here would have handed
+        // them to the vendor and transaction screens too — and the picker
+        // filters deleted classes out anyway, so there is nothing to gain.
+        actions.push((0, classListReducer_1.fetchClassList)());
+    }
+    return actions.length > 0 ? (0, rxjs_1.from)(actions) : rxjs_1.EMPTY;
+}));
+exports.fetchInvoicingAccountingPickersEpic = fetchInvoicingAccountingPickersEpic;

package/lib/view/invoicing/invoicingQboView/epics/invoicingQboViewActionType.d.ts

@@ -1,3 +1,5 @@
 import { openSnackbar } from '../../../../entity/snackbar/snackbarReducer';
-import { fetchInvoicingQboAccounts, fetchInvoicingQboClasses, fetchInvoicingQboConnection, fetchInvoicingQboSyncHealth, retryInvoicingQboSyncTask, retryInvoicingQboSyncTaskFailure, retryInvoicingQboSyncTaskSuccess, startInvoicingQboBackfill, startInvoicingQboBackfillFailure, startInvoicingQboBackfillSuccess, updateInvoicingQboAccounts, updateInvoicingQboAccountsFailure, updateInvoicingQboClasses, updateInvoicingQboClassesFailure, updateInvoicingQboConnection, updateInvoicingQboConnectionFailure, updateInvoicingQboSyncHealth, updateInvoicingQboSyncHealthFailure } from '../invoicingQboViewReducer';
-export type InvoicingQboViewActionType = ReturnType<typeof openSnackbar> | ReturnType<typeof fetchInvoicingQboConnection> | ReturnType<typeof updateInvoicingQboConnection> | ReturnType<typeof updateInvoicingQboConnectionFailure> | ReturnType<typeof fetchInvoicingQboAccounts> | ReturnType<typeof updateInvoicingQboAccounts> | ReturnType<typeof updateInvoicingQboAccountsFailure> | ReturnType<typeof fetchInvoicingQboClasses> | ReturnType<typeof updateInvoicingQboClasses> | ReturnType<typeof updateInvoicingQboClassesFailure> | ReturnType<typeof fetchInvoicingQboSyncHealth> | ReturnType<typeof updateInvoicingQboSyncHealth> | ReturnType<typeof updateInvoicingQboSyncHealthFailure> | ReturnType<typeof retryInvoicingQboSyncTask> | ReturnType<typeof retryInvoicingQboSyncTaskSuccess> | ReturnType<typeof retryInvoicingQboSyncTaskFailure> | ReturnType<typeof startInvoicingQboBackfill> | ReturnType<typeof startInvoicingQboBackfillSuccess> | ReturnType<typeof startInvoicingQboBackfillFailure>;
+import { fetchAccountList } from '../../../accountList/accountListReducer';
+import { fetchClassList } from '../../../classList/classListReducer';
+import { fetchInvoicingAccountingPickers, fetchInvoicingQboConnection, fetchInvoicingQboSyncHealth, retryInvoicingQboSyncTask, retryInvoicingQboSyncTaskFailure, retryInvoicingQboSyncTaskSuccess, startInvoicingQboBackfill, startInvoicingQboBackfillFailure, startInvoicingQboBackfillSuccess, updateInvoicingQboConnection, updateInvoicingQboConnectionFailure, updateInvoicingQboSyncHealth, updateInvoicingQboSyncHealthFailure } from '../invoicingQboViewReducer';
+export type InvoicingQboViewActionType = ReturnType<typeof openSnackbar> | ReturnType<typeof fetchInvoicingQboConnection> | ReturnType<typeof updateInvoicingQboConnection> | ReturnType<typeof updateInvoicingQboConnectionFailure> | ReturnType<typeof fetchInvoicingAccountingPickers> | ReturnType<typeof fetchAccountList> | ReturnType<typeof fetchClassList> | ReturnType<typeof fetchInvoicingQboSyncHealth> | ReturnType<typeof updateInvoicingQboSyncHealth> | ReturnType<typeof updateInvoicingQboSyncHealthFailure> | ReturnType<typeof retryInvoicingQboSyncTask> | ReturnType<typeof retryInvoicingQboSyncTaskSuccess> | ReturnType<typeof retryInvoicingQboSyncTaskFailure> | ReturnType<typeof startInvoicingQboBackfill> | ReturnType<typeof startInvoicingQboBackfillSuccess> | ReturnType<typeof startInvoicingQboBackfillFailure>;

package/lib/view/invoicing/invoicingQboView/invoicingQboViewPayload.d.ts

@@ -12,31 +12,6 @@ export interface InvoicingQboConnection {
     realmId?: string;
 }
 export declare function mapInvoicingQboConnection(payload: InvoicingQboConnectionPayload): InvoicingQboConnection;
-/**
- * A single row from the QBO accounts / classes endpoints. The rows carry the
- * QBO id plus one or more name fields depending on the entity — inspect
- * loosely, render the name, submit the id.
- */
-export interface InvoicingQboAccountRowPayload {
-    account_id?: string | null;
-    account_name?: string | null;
-    account_type?: string | null;
-    accounting_class_name?: string | null;
-    fully_qualified_name?: string | null;
-    id?: string | null;
-    name?: string | null;
-    qbo_accounting_class_name?: string | null;
-    qbo_id?: string | null;
-}
-export interface InvoicingQboAccountOption {
-    id: string;
-    name: string;
-    accountType?: string;
-}
-export declare function mapInvoicingQboAccountOptions(rows: InvoicingQboAccountRowPayload[]): InvoicingQboAccountOption[];
-export interface InvoicingQboAccountsPayload {
-    accounts: InvoicingQboAccountRowPayload[];
-}
 export interface InvoicingQboFailedTaskPayload {
     attempts: number;
     entity_id: string;
@@ -73,7 +48,6 @@ export interface InvoicingQboBackfillPayload {
     start_date?: string | null;
 }
 export type InvoicingQboConnectionResponse = ZeniAPIResponse<InvoicingQboConnectionPayload>;
-export type InvoicingQboAccountsResponse = ZeniAPIResponse<InvoicingQboAccountsPayload>;
 export type InvoicingQboSyncHealthResponse = ZeniAPIResponse<InvoicingQboSyncHealthPayload>;
 export type InvoicingQboRetryTaskResponse = ZeniAPIResponse<InvoicingQboRetryTaskPayload>;
 export type InvoicingQboBackfillResponse = ZeniAPIResponse<InvoicingQboBackfillPayload>;

package/lib/view/invoicing/invoicingQboView/invoicingQboViewPayload.js

@@ -1,7 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.mapInvoicingQboConnection = mapInvoicingQboConnection;
-exports.mapInvoicingQboAccountOptions = mapInvoicingQboAccountOptions;
 exports.mapInvoicingQboSyncHealth = mapInvoicingQboSyncHealth;
 function mapInvoicingQboConnection(payload) {
     return {
@@ -11,29 +10,6 @@ function mapInvoicingQboConnection(payload) {
         realmId: payload.realm_id ?? undefined,
     };
 }
-function mapInvoicingQboAccountOptions(rows) {
-    return rows.flatMap((row) => {
-        // Only qbo_id is a valid QBO AccountRef/ClassRef value — platform-internal
-        // ids (account_id / id) are display metadata and must never be submitted.
-        const accountId = row.qbo_id ?? row.id ?? row.account_id ?? '';
-        if (accountId === '') {
-            return [];
-        }
-        const accountName = row.name ??
-            row.account_name ??
-            row.accounting_class_name ??
-            row.qbo_accounting_class_name ??
-            row.fully_qualified_name ??
-            accountId;
-        return [
-            {
-                id: accountId,
-                name: accountName,
-                accountType: row.account_type ?? undefined,
-            },
-        ];
-    });
-}
 function mapInvoicingQboSyncHealth(payload) {
     return {
         connection: payload.connection != null

package/lib/view/invoicing/invoicingQboView/invoicingQboViewReducer.d.ts

@@ -1,16 +1,8 @@
 import { ZeniAPIStatus } from '../../../responsePayload';
-import { InvoicingQboAccountOption, InvoicingQboConnection, InvoicingQboSyncHealth } from './invoicingQboViewPayload';
+import { InvoicingQboConnection, InvoicingQboSyncHealth } from './invoicingQboViewPayload';
 import { InvoicingQboViewState } from './invoicingQboViewState';
 export declare const initialState: InvoicingQboViewState;
-export declare const fetchInvoicingQboConnection: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"invoicingQboView/fetchInvoicingQboConnection">, updateInvoicingQboConnection: import("@reduxjs/toolkit").ActionCreatorWithPayload<InvoicingQboConnection, "invoicingQboView/updateInvoicingQboConnection">, updateInvoicingQboConnectionFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<ZeniAPIStatus<Record<string, unknown>>, "invoicingQboView/updateInvoicingQboConnectionFailure">, fetchInvoicingQboAccounts: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[accountTypes: string], {
-    accountTypes: string;
-}, "invoicingQboView/fetchInvoicingQboAccounts", never, never>, updateInvoicingQboAccounts: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
-    accounts: InvoicingQboAccountOption[];
-    accountTypes: string;
-}, "invoicingQboView/updateInvoicingQboAccounts">, updateInvoicingQboAccountsFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
-    accountTypes: string;
-    status: ZeniAPIStatus;
-}, "invoicingQboView/updateInvoicingQboAccountsFailure">, fetchInvoicingQboClasses: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"invoicingQboView/fetchInvoicingQboClasses">, updateInvoicingQboClasses: import("@reduxjs/toolkit").ActionCreatorWithPayload<InvoicingQboAccountOption[], "invoicingQboView/updateInvoicingQboClasses">, updateInvoicingQboClassesFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<ZeniAPIStatus<Record<string, unknown>>, "invoicingQboView/updateInvoicingQboClassesFailure">, fetchInvoicingQboSyncHealth: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"invoicingQboView/fetchInvoicingQboSyncHealth">, updateInvoicingQboSyncHealth: import("@reduxjs/toolkit").ActionCreatorWithPayload<InvoicingQboSyncHealth, "invoicingQboView/updateInvoicingQboSyncHealth">, updateInvoicingQboSyncHealthFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<ZeniAPIStatus<Record<string, unknown>>, "invoicingQboView/updateInvoicingQboSyncHealthFailure">, retryInvoicingQboSyncTask: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[taskId: string], {
+export declare const fetchInvoicingQboConnection: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"invoicingQboView/fetchInvoicingQboConnection">, updateInvoicingQboConnection: import("@reduxjs/toolkit").ActionCreatorWithPayload<InvoicingQboConnection, "invoicingQboView/updateInvoicingQboConnection">, updateInvoicingQboConnectionFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<ZeniAPIStatus<Record<string, unknown>>, "invoicingQboView/updateInvoicingQboConnectionFailure">, fetchInvoicingAccountingPickers: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"invoicingQboView/fetchInvoicingAccountingPickers">, fetchInvoicingQboSyncHealth: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"invoicingQboView/fetchInvoicingQboSyncHealth">, updateInvoicingQboSyncHealth: import("@reduxjs/toolkit").ActionCreatorWithPayload<InvoicingQboSyncHealth, "invoicingQboView/updateInvoicingQboSyncHealth">, updateInvoicingQboSyncHealthFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<ZeniAPIStatus<Record<string, unknown>>, "invoicingQboView/updateInvoicingQboSyncHealthFailure">, retryInvoicingQboSyncTask: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[taskId: string], {
     taskId: string;
 }, "invoicingQboView/retryInvoicingQboSyncTask", never, never>, retryInvoicingQboSyncTaskSuccess: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
     status: string;

package/lib/view/invoicing/invoicingQboView/invoicingQboViewReducer.js

@@ -1,15 +1,11 @@
 "use strict";
 var _a;
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.startInvoicingQboBackfillFailure = exports.startInvoicingQboBackfillSuccess = exports.startInvoicingQboBackfill = exports.retryInvoicingQboSyncTaskFailure = exports.retryInvoicingQboSyncTaskSuccess = exports.retryInvoicingQboSyncTask = exports.updateInvoicingQboSyncHealthFailure = exports.updateInvoicingQboSyncHealth = exports.fetchInvoicingQboSyncHealth = exports.updateInvoicingQboClassesFailure = exports.updateInvoicingQboClasses = exports.fetchInvoicingQboClasses = exports.updateInvoicingQboAccountsFailure = exports.updateInvoicingQboAccounts = exports.fetchInvoicingQboAccounts = exports.updateInvoicingQboConnectionFailure = exports.updateInvoicingQboConnection = exports.fetchInvoicingQboConnection = exports.initialState = void 0;
+exports.startInvoicingQboBackfillFailure = exports.startInvoicingQboBackfillSuccess = exports.startInvoicingQboBackfill = exports.retryInvoicingQboSyncTaskFailure = exports.retryInvoicingQboSyncTaskSuccess = exports.retryInvoicingQboSyncTask = exports.updateInvoicingQboSyncHealthFailure = exports.updateInvoicingQboSyncHealth = exports.fetchInvoicingQboSyncHealth = exports.fetchInvoicingAccountingPickers = exports.updateInvoicingQboConnectionFailure = exports.updateInvoicingQboConnection = exports.fetchInvoicingQboConnection = exports.initialState = void 0;
 const toolkit_1 = require("@reduxjs/toolkit");
 const rootActions_1 = require("../../../rootActions");
 exports.initialState = {
-    accountsByAccountTypes: {},
-    accountsFetchStateByAccountTypes: {},
     backfillFetchState: { fetchState: 'Not-Started', error: undefined },
-    classes: [],
-    classesFetchState: { fetchState: 'Not-Started', error: undefined },
     connection: undefined,
     connectionFetchState: { fetchState: 'Not-Started', error: undefined },
     retryFetchStateByTaskId: {},
@@ -33,41 +29,8 @@ const invoicingQboView = (0, toolkit_1.createSlice)({
         updateInvoicingQboConnectionFailure(draft, action) {
             draft.connectionFetchState = { fetchState: 'Error', error: action.payload };
         },
-        fetchInvoicingQboAccounts: {
-            reducer(draft, action) {
-                draft.accountsFetchStateByAccountTypes[action.payload.accountTypes] = {
-                    fetchState: 'In-Progress',
-                    error: undefined,
-                };
-            },
-            prepare(accountTypes) {
-                return { payload: { accountTypes } };
-            },
-        },
-        updateInvoicingQboAccounts(draft, action) {
-            draft.accountsByAccountTypes[action.payload.accountTypes] =
-                action.payload.accounts;
-            draft.accountsFetchStateByAccountTypes[action.payload.accountTypes] = {
-                fetchState: 'Completed',
-                error: undefined,
-            };
-        },
-        updateInvoicingQboAccountsFailure(draft, action) {
-            draft.accountsFetchStateByAccountTypes[action.payload.accountTypes] = {
-                fetchState: 'Error',
-                error: action.payload.status,
-            };
-        },
-        fetchInvoicingQboClasses(draft) {
-            draft.classesFetchState = { fetchState: 'In-Progress', error: undefined };
-        },
-        updateInvoicingQboClasses(draft, action) {
-            draft.classes = action.payload;
-            draft.classesFetchState = { fetchState: 'Completed', error: undefined };
-        },
-        updateInvoicingQboClassesFailure(draft, action) {
-            draft.classesFetchState = { fetchState: 'Error', error: action.payload };
-        },
+        // No state of its own: the epic decides which shared lists to load.
+        fetchInvoicingAccountingPickers() { },
         fetchInvoicingQboSyncHealth(draft) {
             draft.syncHealthFetchState = {
                 fetchState: 'In-Progress',
@@ -131,5 +94,5 @@ const invoicingQboView = (0, toolkit_1.createSlice)({
         });
     },
 });
-_a = invoicingQboView.actions, exports.fetchInvoicingQboConnection = _a.fetchInvoicingQboConnection, exports.updateInvoicingQboConnection = _a.updateInvoicingQboConnection, exports.updateInvoicingQboConnectionFailure = _a.updateInvoicingQboConnectionFailure, exports.fetchInvoicingQboAccounts = _a.fetchInvoicingQboAccounts, exports.updateInvoicingQboAccounts = _a.updateInvoicingQboAccounts, exports.updateInvoicingQboAccountsFailure = _a.updateInvoicingQboAccountsFailure, exports.fetchInvoicingQboClasses = _a.fetchInvoicingQboClasses, exports.updateInvoicingQboClasses = _a.updateInvoicingQboClasses, exports.updateInvoicingQboClassesFailure = _a.updateInvoicingQboClassesFailure, exports.fetchInvoicingQboSyncHealth = _a.fetchInvoicingQboSyncHealth, exports.updateInvoicingQboSyncHealth = _a.updateInvoicingQboSyncHealth, exports.updateInvoicingQboSyncHealthFailure = _a.updateInvoicingQboSyncHealthFailure, exports.retryInvoicingQboSyncTask = _a.retryInvoicingQboSyncTask, exports.retryInvoicingQboSyncTaskSuccess = _a.retryInvoicingQboSyncTaskSuccess, exports.retryInvoicingQboSyncTaskFailure = _a.retryInvoicingQboSyncTaskFailure, exports.startInvoicingQboBackfill = _a.startInvoicingQboBackfill, exports.startInvoicingQboBackfillSuccess = _a.startInvoicingQboBackfillSuccess, exports.startInvoicingQboBackfillFailure = _a.startInvoicingQboBackfillFailure;
+_a = invoicingQboView.actions, exports.fetchInvoicingQboConnection = _a.fetchInvoicingQboConnection, exports.updateInvoicingQboConnection = _a.updateInvoicingQboConnection, exports.updateInvoicingQboConnectionFailure = _a.updateInvoicingQboConnectionFailure, exports.fetchInvoicingAccountingPickers = _a.fetchInvoicingAccountingPickers, exports.fetchInvoicingQboSyncHealth = _a.fetchInvoicingQboSyncHealth, exports.updateInvoicingQboSyncHealth = _a.updateInvoicingQboSyncHealth, exports.updateInvoicingQboSyncHealthFailure = _a.updateInvoicingQboSyncHealthFailure, exports.retryInvoicingQboSyncTask = _a.retryInvoicingQboSyncTask, exports.retryInvoicingQboSyncTaskSuccess = _a.retryInvoicingQboSyncTaskSuccess, exports.retryInvoicingQboSyncTaskFailure = _a.retryInvoicingQboSyncTaskFailure, exports.startInvoicingQboBackfill = _a.startInvoicingQboBackfill, exports.startInvoicingQboBackfillSuccess = _a.startInvoicingQboBackfillSuccess, exports.startInvoicingQboBackfillFailure = _a.startInvoicingQboBackfillFailure;
 exports.default = invoicingQboView.reducer;

package/lib/view/invoicing/invoicingQboView/invoicingQboViewSelector.d.ts

@@ -1,21 +1,58 @@
+import { NestedAccountHierarchyForReport } from '../../../commonStateTypes/accountView/nestedAccountID';
+import { NestedClassHierarchyForReport } from '../../../commonStateTypes/classesView/nestedClassID';
 import { FetchStateAndError } from '../../../commonStateTypes/common';
+import { AccountType } from '../../../entity/account/accountState';
 import { RootState } from '../../../rootStateTypes';
-import { InvoicingQboAccountOption, InvoicingQboConnection, InvoicingQboSyncHealth } from './invoicingQboViewPayload';
+import { InvoicingQboConnection, InvoicingQboSyncHealth } from './invoicingQboViewPayload';
+export declare const INVOICING_ACCOUNT_LIST_KEY: "invoicingAccountList";
+/** Whether QBO is connected, without building the option lists to find out. */
+export declare const isInvoicingQboConnected: (state: RootState) => boolean;
+/**
+ * Account types that can back invoicing revenue. Named here so screens ask for
+ * "income accounts" rather than repeating the accounting service's vocabulary.
+ */
+export declare const INVOICING_INCOME_ACCOUNT_TYPES: readonly AccountType[];
+/** An account or class as the invoicing pickers render and submit it. */
+export interface InvoicingAccountingOption {
+    id: string;
+    name: string;
+    accountType?: string;
+}
 export interface InvoicingQboView {
-    accountsByAccountTypes: Record<string, InvoicingQboAccountOption[]>;
-    accountsFetchStateByAccountTypes: Record<string, FetchStateAndError>;
+    accounts: InvoicingAccountingOption[];
+    accountsFetchState: FetchStateAndError;
     backfillState: FetchStateAndError;
-    classes: InvoicingQboAccountOption[];
+    classes: InvoicingAccountingOption[];
     classesFetchState: FetchStateAndError;
     connectionFetchState: FetchStateAndError;
+    /**
+     * The account and class trees the grouped pickers render. The flat option
+     * lists above stay for callers that only need id and name.
+     */
+    nestedAccountHierarchy: NestedAccountHierarchyForReport[];
+    nestedClassHierarchy: NestedClassHierarchyForReport[];
     retryFetchStateByTaskId: Record<string, FetchStateAndError>;
     syncHealthFetchState: FetchStateAndError;
     connection?: InvoicingQboConnection;
     syncHealth?: InvoicingQboSyncHealth;
 }
+/**
+ * The accounts valid for one QBO mapping kind, whose `accountTypes` is a
+ * comma-separated list of QuickBooks type names. An unrecognised list yields no
+ * accounts rather than every account: offering a bank account where income is
+ * required would post a mapping QuickBooks rejects.
+ */
+export declare const invoicingAccountsForQboAccountTypes: (accounts: InvoicingAccountingOption[], accountTypes: string) => InvoicingAccountingOption[];
+/**
+ * The account tree narrowed to the given account types. The tree itself carries
+ * no account type, so the flat account list supplies that and the matching
+ * `qboId`s are kept — which is why callers that only need "income accounts, as a
+ * tree" do not have to hold a second flat list to filter with.
+ */
+export declare const invoicingAccountHierarchyForTypes: (state: RootState, accountTypes: readonly AccountType[]) => NestedAccountHierarchyForReport[];
 /**
  * Single bundled view for the QBO integration settings screen — the
- * connection, per-account-types account options, classes, sync health, and the
- * fetch/action states for each of them.
+ * connection, the account and class options, sync health, and the fetch/action
+ * states for each of them.
  */
 export declare const getInvoicingQboView: (state: RootState) => InvoicingQboView;