@zeniai/client-epic-state 5.2.39-betaRD0 → 5.2.39-betaRD1

package/lib/esm/view/financeStatement/financeStatementReducer.js

@@ -17,7 +17,6 @@ export const initialFinanceStatementState = {
     displayOrder: 'ascending_date',
     reportFormat: 'more_detailed',
     lastFetchRequestTime: undefined,
-    isPeriodSelectionExplicit: false,
 };
 const financeStatement = createSlice({
     name: 'financeStatement',
@@ -34,26 +33,23 @@ const financeStatement = createSlice({
             },
         },
         updateFinanceStatementTimeframe(draft, action) {
-            // A month anchor is meaningless once the timeframe becomes quarter/year, so
-            // a real timeframe change has to drop it. Callers also re-dispatch the
-            // *current* timeframe as a side effect of unrelated UI (report format, view
-            // switches); dropping the anchor there silently resets the user's period to
-            // the latest one, so leave the selection alone when nothing changed.
+            // Unrelated UI re-dispatches the *current* timeframe as a side effect (the
+            // reports page hangs its table scroll reset off that callback); dropping the
+            // anchor there would silently reset the user's period to the latest one.
             if (draft.timeframe === action.payload) {
                 return;
             }
             draft.timeframe = action.payload;
+            // A month anchor is meaningless once the timeframe becomes quarter/year, so
+            // a real change drops it and returns the width to the default — 12 months
+            // must not become 12 quarters. Order is the user's, so it survives.
             draft.selectedCOABalancesRange = {
-                numberOfPeriods: draft.selectedCOABalancesRange.numberOfPeriods,
+                numberOfPeriods: initialFinanceStatementState.selectedCOABalancesRange.numberOfPeriods,
                 orderBy: draft.selectedCOABalancesRange.orderBy,
             };
-            draft.isPeriodSelectionExplicit = false;
         },
         updateCOABalancesRange(draft, action) {
             draft.selectedCOABalancesRange = Object.assign({}, action.payload);
-            // A range without an anchor is a programmatic reset to the default, not a
-            // user pick (e.g. leaving the horizontal by-class layout).
-            draft.isPeriodSelectionExplicit = action.payload.thisPeriod != null;
         },
         updateFinanceStatementThisPeriod(draft, action) {
             const { firstMonthOfFY, coaBalances, maxNumOfPeriodsToHighlight } = action.payload;
@@ -68,7 +64,6 @@ const financeStatement = createSlice({
                     };
                     const newThisPeriod = getMatchingThisPeriod(action.payload.firstMonthOfFY, timeframe, action.payload.thisPeriod, safeCoaBalances);
                     if (newThisPeriod != null) {
-                        draft.isPeriodSelectionExplicit = true;
                         const selectionRanges = getSelectedAndHighlightedRangesForThisPeriod({
                             firstMonthOfFY,
                             thisPeriod: newThisPeriod,
@@ -91,8 +86,7 @@ const financeStatement = createSlice({
             draft.selectedReportId = action.payload;
         },
         updateFinanceStatementAdditionalBalancesSelection(draft, action) {
-            const { firstMonthOfFY, additionalBalances: additionalBalancesPayload, coaBalances, maxNumOfPeriodsToHighlight, } = action.payload;
-            const safeCoaBalances = coaBalances != null ? coaBalances : [];
+            const { additionalBalances: additionalBalancesPayload, maxNumOfPeriodsToHighlight, } = action.payload;
             const additionalBalances = additionalBalancesPayload ?? [];
             let tempAdditionalBalances = [...additionalBalances];
             if (additionalBalances.includes('this_period_vs_last_period') ||
@@ -108,38 +102,12 @@ const financeStatement = createSlice({
             draft.maxNumOfPeriodsToHighlight = maxNumOfPeriodsToHighlight;
             draft.isAdditionalBalancesShown =
                 additionalBalances.length != 0 ? true : false;
-            const { timeframe, selectedCOABalancesRange } = draft;
-            // The reports page fires this on load, on window resize and on every
-            // fetch-state transition (so also on report switch and on remount after a
-            // drill-down), carrying a viewport-derived period count. Re-deriving the
-            // range from that count silently discards a range the user chose, so only
-            // the column metadata above is applied once the selection is theirs.
-            if (draft.isPeriodSelectionExplicit) {
-                return;
-            }
-            if (safeCoaBalances.length > 0) {
-                const thisPeriod = extractThisPeriod(action.payload.firstMonthOfFY, timeframe, selectedCOABalancesRange, safeCoaBalances);
-                if (thisPeriod != null) {
-                    const selectedCoaBalancesRangeWithThisPeriod = {
-                        ...selectedCOABalancesRange,
-                        thisPeriod,
-                    };
-                    const selectionRanges = getSelectedAndHighlightedRangesForThisPeriod({
-                        firstMonthOfFY,
-                        thisPeriod: thisPeriod,
-                        coaBalances: safeCoaBalances,
-                        timeframe,
-                        maxNumOfPeriodsToHighlight: maxNumOfPeriodsToHighlight,
-                        currentSelection: {
-                            selectedCOABalancesRange: selectedCoaBalancesRangeWithThisPeriod,
-                        },
-                        orderBy: 'ascending_date',
-                        maxNumOfPeriodsToSelect: maxNumOfPeriodsToHighlight,
-                    });
-                    draft.selectedCOABalancesRange =
-                        selectionRanges.selectedCOABalancesRange;
-                }
-            }
+            // Column metadata only — must not touch selectedCOABalancesRange. The
+            // reports page fires this on load, on resize and on every fetch-state
+            // transition (so also on report switch and on remount after a drill-down)
+            // with a viewport-derived period count that knows nothing about the range
+            // the user picked. The width default comes from initial state, and from
+            // updateFinanceStatementTimeframe on a real timeframe change.
         },
         updateDownloadState(draft, action) {
             draft.downloadState = action.payload;