@zeniai/client-epic-state 5.2.29 → 5.2.30-betaRD0

package/lib/view/recommendation/recommendationReducer.d.ts

@@ -5,6 +5,7 @@ import { TransactionID } from '../../entity/transaction/stateTypes/transactionID
 import { SupportedTransaction } from '../../entity/transaction/transactionState';
 import { ZeniAPIStatus } from '../../responsePayload';
 import { TransactionsTab } from '../expenseAutomationView/types/transactionsViewState';
+import { SubmitRecommendationFeedbackPayload } from './recommendationPayload';
 import { EntityRecommendationState } from './recommendationState';
 export type RecommendationLineUpdateFlowType = 'categorization' | 'detail';
 type FetchEntityRecommendationsForLineUpdateCommonPayload = {
@@ -57,6 +58,6 @@ export declare const fetchEntityRecommendationsByTransactionId: import("@reduxjs
 }, "recommendation/updateRecommendationForEntityFailure">, indicateReadyToInitializeRecommendation: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[entityIdOrName: string, entityType: EntityType], {
     entityIdOrName: string;
     entityType: EntityType;
-}, "recommendation/indicateReadyToInitializeRecommendation", never, never>;
+}, "recommendation/indicateReadyToInitializeRecommendation", never, never>, submitRecommendationFeedback: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[args: SubmitRecommendationFeedbackPayload], SubmitRecommendationFeedbackPayload, "recommendation/submitRecommendationFeedback", never, never>;
 declare const _default: import("redux").Reducer<EntityRecommendationState>;
 export default _default;

package/lib/view/recommendation/recommendationReducer.js

@@ -1,7 +1,7 @@
 "use strict";
 var _a;
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.indicateReadyToInitializeRecommendation = exports.updateRecommendationForEntityFailure = exports.updateRecommendationForEntity = exports.fetchRecommendationByEntityId = exports.fetchRecommendationByEntityName = exports.fetchEntityRecommendationsForLineUpdate = exports.fetchEntityRecommendationsByTransactionId = exports.initialState = void 0;
+exports.submitRecommendationFeedback = exports.indicateReadyToInitializeRecommendation = exports.updateRecommendationForEntityFailure = exports.updateRecommendationForEntity = exports.fetchRecommendationByEntityId = exports.fetchRecommendationByEntityName = exports.fetchEntityRecommendationsForLineUpdate = exports.fetchEntityRecommendationsByTransactionId = exports.initialState = void 0;
 const toolkit_1 = require("@reduxjs/toolkit");
 const rootActions_1 = require("../../rootActions");
 const recommendationState_1 = require("./recommendationState");
@@ -135,6 +135,18 @@ const recommendation = (0, toolkit_1.createSlice)({
                 };
             },
         },
+        // Fire-and-forget human feedback on a recommendation (accept, ranked
+        // override or outside override). Handled by submitRecommendationFeedbackEpic
+        // which POSTs to the accounting recommendation-feedback endpoint. No state
+        // mutation: the categorization UX must not depend on the feedback round-trip.
+        submitRecommendationFeedback: {
+            reducer() {
+                // Fire-and-forget: no state mutation; the epic performs the POST.
+            },
+            prepare(args) {
+                return { payload: args };
+            },
+        },
     },
     extraReducers: (builder) => {
         builder.addCase(rootActions_1.clearAll, (draft) => {
@@ -142,7 +154,7 @@ const recommendation = (0, toolkit_1.createSlice)({
         });
     },
 });
-_a = recommendation.actions, exports.fetchEntityRecommendationsByTransactionId = _a.fetchEntityRecommendationsByTransactionId, exports.fetchEntityRecommendationsForLineUpdate = _a.fetchEntityRecommendationsForLineUpdate, exports.fetchRecommendationByEntityName = _a.fetchRecommendationByEntityName, exports.fetchRecommendationByEntityId = _a.fetchRecommendationByEntityId, exports.updateRecommendationForEntity = _a.updateRecommendationForEntity, exports.updateRecommendationForEntityFailure = _a.updateRecommendationForEntityFailure, exports.indicateReadyToInitializeRecommendation = _a.indicateReadyToInitializeRecommendation;
+_a = recommendation.actions, exports.fetchEntityRecommendationsByTransactionId = _a.fetchEntityRecommendationsByTransactionId, exports.fetchEntityRecommendationsForLineUpdate = _a.fetchEntityRecommendationsForLineUpdate, exports.fetchRecommendationByEntityName = _a.fetchRecommendationByEntityName, exports.fetchRecommendationByEntityId = _a.fetchRecommendationByEntityId, exports.updateRecommendationForEntity = _a.updateRecommendationForEntity, exports.updateRecommendationForEntityFailure = _a.updateRecommendationForEntityFailure, exports.indicateReadyToInitializeRecommendation = _a.indicateReadyToInitializeRecommendation, exports.submitRecommendationFeedback = _a.submitRecommendationFeedback;
 exports.default = recommendation.reducer;
 const doUpdateRecommendationForEntity = (draft, entityId, entityType, payload) => {
     const key = (0, recommendationState_1.getEntityRecommendationKey)(entityType, entityId);

package/lib/view/recommendation/submitRecommendationFeedbackEpic.d.ts

@@ -0,0 +1,7 @@
+import { ActionsObservable, StateObservable } from 'redux-observable';
+import { Observable } from 'rxjs';
+import { RootState } from '../../reducer';
+import { ZeniAPI } from '../../zeniAPI';
+import { submitRecommendationFeedback } from './recommendationReducer';
+export type ActionType = ReturnType<typeof submitRecommendationFeedback>;
+export declare const submitRecommendationFeedbackEpic: (actions$: ActionsObservable<ActionType>, _state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => Observable<ActionType>;

package/lib/view/recommendation/submitRecommendationFeedbackEpic.js

@@ -0,0 +1,56 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.submitRecommendationFeedbackEpic = void 0;
+const rxjs_1 = require("rxjs");
+const operators_1 = require("rxjs/operators");
+const responsePayload_1 = require("../../responsePayload");
+const recommendationReducer_1 = require("./recommendationReducer");
+const toRequestBody = (payload) => ({
+    line_id: payload.lineId ?? null,
+    dimension: payload.dimension,
+    recommendation_set_id: payload.recommendationSetId ?? null,
+    top_pick_source: payload.topPickSource ?? null,
+    shown_recommendations: (payload.shownRecommendations ?? []).map((recommendation) => ({
+        source: recommendation.source,
+        rank: recommendation.rank,
+        value: {
+            name: recommendation.value.name,
+            id: recommendation.value.id ?? null,
+            integration_id: recommendation.value.integrationId ?? null,
+        },
+        confidence: recommendation.confidence ?? null,
+        reasoning: recommendation.reasoning ?? null,
+        cot: recommendation.cot ?? [],
+    })),
+    selected: {
+        name: payload.selected.name,
+        id: payload.selected.id ?? null,
+        integration_id: payload.selected.integrationId ?? null,
+        is_new_entity: payload.selected.isNewEntity ?? false,
+    },
+    matched_source: payload.matchedSource ?? null,
+    matched_rank: payload.matchedRank ?? null,
+    outcome: payload.outcome,
+    reason_text: payload.reasonText ?? null,
+    skipped: payload.skipped ?? false,
+    retracts_feedback_id: payload.retractsFeedbackId ?? null,
+    features: payload.features ?? null,
+});
+// Fire-and-forget: the epic never re-emits an action. Feedback delivery is a
+// side-effect that must not disrupt the categorization UX, so both the
+// success and error paths complete silently (errors are logged for debugging).
+const submitRecommendationFeedbackEpic = (actions$, _state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(recommendationReducer_1.submitRecommendationFeedback.match), (0, operators_1.mergeMap)((action) => {
+    const { transactionId } = action.payload;
+    return zeniAPI
+        .postAndGetJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/transactions/${transactionId}/recommendation-feedback`, toRequestBody(action.payload))
+        .pipe((0, operators_1.mergeMap)((response) => {
+        if (!(0, responsePayload_1.isSuccessStatus)(response)) {
+            console.error('submitRecommendationFeedbackEpic: recommendation feedback was not recorded', response.status);
+        }
+        return rxjs_1.EMPTY;
+    }), (0, operators_1.catchError)((error) => {
+        console.error('submitRecommendationFeedbackEpic: failed to submit recommendation feedback', error);
+        return rxjs_1.EMPTY;
+    }));
+}));
+exports.submitRecommendationFeedbackEpic = submitRecommendationFeedbackEpic;

package/lib/view/spendManagement/billPay/billPaySetupApproverView/epic/fetchBillPaySetupApproverViewEpic.d.ts

@@ -4,6 +4,7 @@ import { updateApprovalRules } from '../../../../../entity/approvalRule/approval
 import { updateAllUsers } from '../../../../../entity/user/userReducer';
 import { RootState } from '../../../../../rootStateTypes';
 import { ZeniAPI } from '../../../../../zeniAPI';
+import { fetchClassList } from '../../../../classList/classListReducer';
 import { fetchBillPaySetupApproverView, fetchBillPaySetupApproverViewFailure, fetchBillPaySetupApproverViewSuccess } from '../billPaySetupApproverViewReducer';
-export type ActionType = ReturnType<typeof fetchBillPaySetupApproverView> | ReturnType<typeof updateAllUsers> | ReturnType<typeof updateApprovalRules> | ReturnType<typeof fetchBillPaySetupApproverViewSuccess> | ReturnType<typeof fetchBillPaySetupApproverViewFailure>;
+export type ActionType = ReturnType<typeof fetchBillPaySetupApproverView> | ReturnType<typeof fetchClassList> | ReturnType<typeof updateAllUsers> | ReturnType<typeof updateApprovalRules> | ReturnType<typeof fetchBillPaySetupApproverViewSuccess> | ReturnType<typeof fetchBillPaySetupApproverViewFailure>;
 export declare const fetchBillPaySetupApproverViewEpic: (actions$: ActionsObservable<ActionType>, state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => Observable<ActionType>;

package/lib/view/spendManagement/billPay/billPaySetupApproverView/epic/fetchBillPaySetupApproverViewEpic.js

@@ -5,13 +5,20 @@ const rxjs_1 = require("rxjs");
 const operators_1 = require("rxjs/operators");
 const approvalRuleReducer_1 = require("../../../../../entity/approvalRule/approvalRuleReducer");
 const approvalRuleSelector_1 = require("../../../../../entity/approvalRule/approvalRuleSelector");
+const tenantSelector_1 = require("../../../../../entity/tenant/tenantSelector");
 const userReducer_1 = require("../../../../../entity/user/userReducer");
 const responsePayload_1 = require("../../../../../responsePayload");
+const classListReducer_1 = require("../../../../classList/classListReducer");
 const billPaySetupApproverViewReducer_1 = require("../billPaySetupApproverViewReducer");
 const fetchBillPaySetupApproverViewEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(billPaySetupApproverViewReducer_1.fetchBillPaySetupApproverView.match), (0, operators_1.switchMap)((action) => {
     const { cacheOverride, useV3 } = action.payload;
-    const { billPaySetupApproverViewState, approvalRuleState } = state$.value;
+    const { billPaySetupApproverViewState, approvalRuleState, classListState } = state$.value;
+    const isAccountingClassesEnabled = (0, tenantSelector_1.getIsAccountingClassesEnabled)(state$.value);
     const approvalRules = (0, approvalRuleSelector_1.getApprovalRulesByIds)(approvalRuleState, billPaySetupApproverViewState.approvalRuleIds);
+    const shouldFetchClassList = isAccountingClassesEnabled &&
+        (cacheOverride === true ||
+            (classListState.hasValidState() === false &&
+                classListState.fetchState !== 'In-Progress'));
     if (cacheOverride === true ||
         approvalRules.length !==
             billPaySetupApproverViewState.approvalRuleIds.length ||
@@ -31,6 +38,9 @@ const fetchBillPaySetupApproverViewEpic = (actions$, state$, zeniAPI) => actions
                     (0, approvalRuleReducer_1.updateApprovalRules)(response.data.approval_rules),
                     (0, billPaySetupApproverViewReducer_1.fetchBillPaySetupApproverViewSuccess)(approvalRuleIds),
                 ];
+                if (shouldFetchClassList) {
+                    actions.push((0, classListReducer_1.fetchClassList)());
+                }
                 return (0, rxjs_1.from)(actions);
             }
             else {
@@ -40,7 +50,13 @@ const fetchBillPaySetupApproverViewEpic = (actions$, state$, zeniAPI) => actions
     }
     else {
         const { approvalRuleIds } = billPaySetupApproverViewState;
-        return (0, rxjs_1.of)((0, billPaySetupApproverViewReducer_1.fetchBillPaySetupApproverViewSuccess)(approvalRuleIds));
+        const actions = [
+            (0, billPaySetupApproverViewReducer_1.fetchBillPaySetupApproverViewSuccess)(approvalRuleIds),
+        ];
+        if (shouldFetchClassList) {
+            actions.push((0, classListReducer_1.fetchClassList)());
+        }
+        return (0, rxjs_1.from)(actions);
     }
 }));
 exports.fetchBillPaySetupApproverViewEpic = fetchBillPaySetupApproverViewEpic;

package/lib/view/spendManagement/billPay/billPaySetupApproverView/epic/initializeBillPaySetupApproverViewUpdateDataEpic.js

@@ -24,7 +24,6 @@ const initializeBillPaySetupApproverViewUpdateDataEpic = (actions$, state$) => a
                 name: approvalRule.name,
                 description: approvalRule.description,
                 separationOfDuties: approvalRule.separationOfDuties,
-                isFallback: approvalRule.isFallback,
             };
             fetchActions.push((0, billPaySetupApproverViewReducer_1.clearBillPaySetupApproverViewUpdateData)(), (0, billPaySetupApproverViewReducer_1.saveBillPaySetupApproverViewUpdateData)(billPaySetupApproverViewUpdateData));
         }

package/lib/view/spendManagement/billPay/billPaySetupApproverView/types/commonPayload.d.ts

@@ -18,7 +18,6 @@ interface ApprovalUpdatableInfoPayload {
     is_applicable_on_pending_approval_entity: boolean;
     steps: ApproverViewStepPayload[];
     description?: string;
-    is_fallback?: boolean;
     is_separation_of_duty_enabled?: boolean;
     /**
      * Approval Rules 3.0 — rule-level wire fields. The backend accepts these

package/lib/view/spendManagement/billPay/billPaySetupApproverView/types/commonPayload.js

@@ -89,9 +89,6 @@ const toApprovalChangableInfoPayload = (approverViewUpdateData) => {
         payload.is_separation_of_duty_enabled =
             approverViewUpdateData.separationOfDuties;
     }
-    if (approverViewUpdateData.isFallback != null) {
-        payload.is_fallback = approverViewUpdateData.isFallback;
-    }
     if (isUpdate) {
         payload.approval_rule_id = approverViewUpdateData.approvalRuleId;
     }

package/lib/view/spendManagement/billPay/billPaySetupApproverView/types/commonState.d.ts

@@ -28,7 +28,6 @@ export interface ApprovalRuleFormCriteria {
  */
 export interface ApprovalRuleFormBase {
     description?: string;
-    isFallback?: boolean;
     name?: string;
     separationOfDuties?: boolean;
 }

package/lib/view/spendManagement/commonHistoryView/commonHistory.d.ts

@@ -25,6 +25,6 @@ export interface CommonHistoryState {
 }
 export declare const toHistoricEventUpdateType: (v: string) => "deleted" | "created" | "updated";
 type HistoricEventUpdateType = ReturnType<typeof toHistoricEventUpdateType>;
-export declare const toHistoricEventUpdateDisplayType: (v: string) => "list" | "sentence" | "inline";
+export declare const toHistoricEventUpdateDisplayType: (v: string) => "inline" | "list" | "sentence";
 type HistoricEventUpdateDisplayType = ReturnType<typeof toHistoricEventUpdateDisplayType>;
 export {};

package/lib/view/spendManagement/reimbursement/remiSetupApproverView/epic/fetchRemiSetupApproverViewEpic.d.ts

@@ -4,6 +4,7 @@ import { updateApprovalRules } from '../../../../../entity/approvalRule/approval
 import { updateAllUsers } from '../../../../../entity/user/userReducer';
 import { RootState } from '../../../../../rootStateTypes';
 import { ZeniAPI } from '../../../../../zeniAPI';
+import { fetchClassList } from '../../../../classList/classListReducer';
 import { fetchRemiSetupApproverView, fetchRemiSetupApproverViewFailure, fetchRemiSetupApproverViewSuccess } from '../remiSetupApproverViewReducer';
-export type ActionType = ReturnType<typeof fetchRemiSetupApproverView> | ReturnType<typeof updateAllUsers> | ReturnType<typeof updateApprovalRules> | ReturnType<typeof fetchRemiSetupApproverViewSuccess> | ReturnType<typeof fetchRemiSetupApproverViewFailure>;
+export type ActionType = ReturnType<typeof fetchRemiSetupApproverView> | ReturnType<typeof fetchClassList> | ReturnType<typeof updateAllUsers> | ReturnType<typeof updateApprovalRules> | ReturnType<typeof fetchRemiSetupApproverViewSuccess> | ReturnType<typeof fetchRemiSetupApproverViewFailure>;
 export declare const fetchRemiSetupApproverViewEpic: (actions$: ActionsObservable<ActionType>, state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => Observable<ActionType>;

package/lib/view/spendManagement/reimbursement/remiSetupApproverView/epic/fetchRemiSetupApproverViewEpic.js

@@ -5,13 +5,20 @@ const rxjs_1 = require("rxjs");
 const operators_1 = require("rxjs/operators");
 const approvalRuleReducer_1 = require("../../../../../entity/approvalRule/approvalRuleReducer");
 const approvalRuleSelector_1 = require("../../../../../entity/approvalRule/approvalRuleSelector");
+const tenantSelector_1 = require("../../../../../entity/tenant/tenantSelector");
 const userReducer_1 = require("../../../../../entity/user/userReducer");
 const responsePayload_1 = require("../../../../../responsePayload");
+const classListReducer_1 = require("../../../../classList/classListReducer");
 const remiSetupApproverViewReducer_1 = require("../remiSetupApproverViewReducer");
 const fetchRemiSetupApproverViewEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(remiSetupApproverViewReducer_1.fetchRemiSetupApproverView.match), (0, operators_1.switchMap)((action) => {
     const { cacheOverride, resolveAttributeToUser, includeImplicitActors, useV3, } = action.payload;
-    const { remiSetupApproverViewState, approvalRuleState } = state$.value;
+    const { remiSetupApproverViewState, approvalRuleState, classListState } = state$.value;
+    const isAccountingClassesEnabled = (0, tenantSelector_1.getIsAccountingClassesEnabled)(state$.value);
     const approvalRules = (0, approvalRuleSelector_1.getApprovalRulesByIds)(approvalRuleState, remiSetupApproverViewState.approvalRuleIds);
+    const shouldFetchClassList = isAccountingClassesEnabled &&
+        (cacheOverride === true ||
+            (classListState.hasValidState() === false &&
+                classListState.fetchState !== 'In-Progress'));
     if (cacheOverride === true ||
         approvalRules.length !==
             remiSetupApproverViewState.approvalRuleIds.length ||
@@ -33,6 +40,9 @@ const fetchRemiSetupApproverViewEpic = (actions$, state$, zeniAPI) => actions$.p
                     (0, approvalRuleReducer_1.updateApprovalRules)(response.data.approval_rules),
                     (0, remiSetupApproverViewReducer_1.fetchRemiSetupApproverViewSuccess)(approvalRuleIds),
                 ];
+                if (shouldFetchClassList) {
+                    actions.push((0, classListReducer_1.fetchClassList)());
+                }
                 return (0, rxjs_1.from)(actions);
             }
             else {
@@ -42,7 +52,13 @@ const fetchRemiSetupApproverViewEpic = (actions$, state$, zeniAPI) => actions$.p
     }
     else {
         const { approvalRuleIds } = remiSetupApproverViewState;
-        return (0, rxjs_1.of)((0, remiSetupApproverViewReducer_1.fetchRemiSetupApproverViewSuccess)(approvalRuleIds));
+        const actions = [
+            (0, remiSetupApproverViewReducer_1.fetchRemiSetupApproverViewSuccess)(approvalRuleIds),
+        ];
+        if (shouldFetchClassList) {
+            actions.push((0, classListReducer_1.fetchClassList)());
+        }
+        return (0, rxjs_1.from)(actions);
     }
 }));
 exports.fetchRemiSetupApproverViewEpic = fetchRemiSetupApproverViewEpic;

package/lib/view/spendManagement/reimbursement/remiSetupApproverView/epic/initializeRemiSetupApproverViewUpdateDataEpic.js

@@ -24,7 +24,6 @@ const initializeRemiSetupApproverViewUpdateDataEpic = (actions$, state$) => acti
                 name: approvalRule.name,
                 description: approvalRule.description,
                 separationOfDuties: approvalRule.separationOfDuties,
-                isFallback: approvalRule.isFallback,
             };
             fetchActions.push((0, remiSetupApproverViewReducer_1.clearRemiSetupApproverViewUpdateData)(), (0, remiSetupApproverViewReducer_1.saveRemiSetupApproverViewUpdateData)(remiSetupApproverViewUpdateData));
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.2.29",
+  "version": "5.2.30-betaRD0",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",