@zeniai/client-epic-state 5.2.11-betaRD1 → 5.2.11-betaRD3

package/lib/entity/jeSchedules/jeSchedulesPayload.js

@@ -329,6 +329,9 @@ function toJEAccruedScheduledTransaction(payload) {
         endDate: payload.end_date != null ? (0, zeniDayJS_1.date)(payload.end_date) : undefined,
         period: payload.period != null ? Number(payload.period) : undefined,
         updatedByUserID: payload.updated_by.user_id,
+        // The accrued joiner resolves createdByUserID into the "Created by" cell. Without this the
+        // payload's created_by was dropped here and every accrued row rendered a hyphen.
+        createdByUserID: payload.created_by?.user_id ?? undefined,
         balanceAsOfToday: payload.balance ?? undefined,
         updatedAt: payload.updated_at != null ? (0, zeniDayJS_1.date)(payload.updated_at) : undefined,
         jeCredit: {

package/lib/esm/entity/jeSchedules/jeSchedulesPayload.js

@@ -318,6 +318,9 @@ export function toJEAccruedScheduledTransaction(payload) {
         endDate: payload.end_date != null ? date(payload.end_date) : undefined,
         period: payload.period != null ? Number(payload.period) : undefined,
         updatedByUserID: payload.updated_by.user_id,
+        // The accrued joiner resolves createdByUserID into the "Created by" cell. Without this the
+        // payload's created_by was dropped here and every accrued row rendered a hyphen.
+        createdByUserID: payload.created_by?.user_id ?? undefined,
         balanceAsOfToday: payload.balance ?? undefined,
         updatedAt: payload.updated_at != null ? date(payload.updated_at) : undefined,
         jeCredit: {

package/lib/esm/view/expenseAutomationView/epics/jeSchedule/fetchJeSchedulePageEpic.js

@@ -14,6 +14,14 @@ export const fetchJeSchedulesPageEpic = (actions$, state$) => actions$.pipe(filt
         jeSchedulePageActions.push(fetchAccountList(accountType.accountListKey, true, false, false, false, accountType.allowedAccountList));
     }
     jeSchedulePageActions.push(fetchJeSchedules(period, refreshViewInBackground));
-    jeSchedulePageActions.push(initializeAccountSettingsView());
+    // Only on the first page load. Account settings cannot change from a tab switch or a
+    // refresh, and re-initializing puts accountSettingsView back to 'In-Progress' -- which the
+    // page reads as "still loading" and answers with a full skeleton over rows it already has.
+    // The action also resets localData, so re-dispatching it blindly would empty the settings
+    // form until the refetch lands. Saving account settings still re-initializes explicitly.
+    if (!state$.value.expenseAutomationJESchedulesViewState.accountSettings
+        .hasLoadedAccountSettings) {
+        jeSchedulePageActions.push(initializeAccountSettingsView());
+    }
     return concat(from(jeSchedulePageActions));
 }));

package/lib/esm/view/expenseAutomationView/epics/jeSchedule/newSchedule/createOneTimeAccrualEpic.js

@@ -1,9 +1,10 @@
 import { from } from 'rxjs';
-import { catchError, filter, mergeMap } from 'rxjs/operators';
+import { catchError, filter, mergeMap, takeUntil } from 'rxjs/operators';
 import { convertToPeriod, toAbsoluteDay, } from '../../../../../commonStateTypes/timePeriod';
 import { updateJEOneTimeAccruals } from '../../../../../entity/jeSchedules/jeSchedulesReducer';
 import { openSnackbar } from '../../../../../entity/snackbar/snackbarReducer';
 import { getCurrentTenant } from '../../../../../entity/tenant/tenantSelector';
+import { clearAll } from '../../../../../rootActions';
 import { createZeniAPIStatus, isSuccessResponse, } from '../../../../../responsePayload';
 import { prepareCreateOneTimeAccrualPayload, } from '../../../payload/jeSchedulesPayload';
 import { createOneTimeAccrual, createOneTimeAccrualFailure, createOneTimeAccrualSuccess, fetchJeSchedules, } from '../../../reducers/jeSchedulesViewReducer';
@@ -95,5 +96,9 @@ export const createOneTimeAccrualEpic = (actions$, state$, zeniAPI) => actions$.
         createOneTimeAccrualFailure({
             status: createZeniAPIStatus('Unexpected Error', `Create One Time Accrual REST API call errored out ${JSON.stringify(error)}`),
         }),
-    ])));
+    ])), 
+    // A tenant switch clears the store while this request is still in flight.
+    // Without this the old tenant's response is written back into the freshly
+    // cleared store and stays on screen under the new tenant.
+    takeUntil(actions$.pipe(filter(clearAll.match))));
 }));

package/lib/esm/view/expenseAutomationView/epics/jeSchedule/newSchedule/saveNewScheduleEpic.js

@@ -1,12 +1,15 @@
 import { from } from 'rxjs';
-import { catchError, filter, mergeMap } from 'rxjs/operators';
+import { catchError, filter, mergeMap, takeUntil } from 'rxjs/operators';
+import { convertToPeriod, toAbsoluteDay, } from '../../../../../commonStateTypes/timePeriod';
+import { getCurrentTenant } from '../../../../../entity/tenant/tenantSelector';
+import { clearAll } from '../../../../../rootActions';
 import { updateJESchedules, updateJESchedulesDetails, } from '../../../../../entity/jeSchedules/jeSchedulesReducer';
 import { getJEScheduleTransactionKey } from '../../../../../entity/jeSchedules/jeSchedulesTypes';
 import { openSnackbar } from '../../../../../entity/snackbar/snackbarReducer';
 import { getScheduleTransactionById } from '../../../../../entity/transaction/transactionSelector';
 import { createZeniAPIStatus, isSuccessResponse, } from '../../../../../responsePayload';
 import { prepareNewSchedulePayload, } from '../../../helpers/newScheduleLocalDataHelper';
-import { resetNewScheduleLocalData, saveNewSchedule, saveNewScheduleFailure, saveNewScheduleSuccess, } from '../../../reducers/jeSchedulesViewReducer';
+import { fetchJeSchedules, resetNewScheduleLocalData, saveNewSchedule, saveNewScheduleFailure, saveNewScheduleSuccess, } from '../../../reducers/jeSchedulesViewReducer';
 const FAILURE_REASON_MESSAGES = {
     missing_third_party_id: 'This transaction is missing a QuickBooks reference and cannot be scheduled.',
     missing_vendor: 'Select a vendor before saving this schedule.',
@@ -58,11 +61,21 @@ export const saveNewScheduleEpic = (actions$, state$, zeniAPI) => actions$.pipe(
         je_schedule_type: scheduleType,
     };
     const payload = { ...result.payload };
+    // convertToPeriod destructures, so an unset period would throw here and take the epic
+    // subscription down for the whole session -- a missed refresh is the cheaper failure.
+    const selectedMonthYear = state.expenseAutomationViewState.selectedPeriodByTenantId[getCurrentTenant(state).tenantId];
+    const selectedPeriod = selectedMonthYear != null
+        ? convertToPeriod(selectedMonthYear)
+        : undefined;
+    const periodStart = selectedPeriod != null
+        ? toAbsoluteDay(selectedPeriod.start)
+        : undefined;
+    const periodEnd = selectedPeriod != null ? toAbsoluteDay(selectedPeriod.end) : undefined;
     return zeniAPI
         .postAndGetJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/schedules?query=${encodeURIComponent(JSON.stringify(queryParam))}`, payload)
         .pipe(mergeMap((response) => {
         if (isSuccessResponse(response) && response.data != null) {
-            return from([
+            const successActions = [
                 updateJESchedules(response.data.je_schedules),
                 updateJESchedulesDetails(response.data.je_schedules, response.data.scheduled_journal_entries),
                 resetNewScheduleLocalData({ scheduleType }),
@@ -75,7 +88,16 @@ export const saveNewScheduleEpic = (actions$, state$, zeniAPI) => actions$.pipe(
                         { variableName: '_vendor_name_', variableValue: vendorName },
                     ],
                 }),
-            ]);
+            ];
+            // Writing the entity is not enough: the list reads
+            // jeScheduleTransactionKeysByPeriodAndTab, which is rebuilt wholesale per fetch, so
+            // without this the new schedule stays invisible until some later fetch. The page
+            // only refetches when the save also changes tab, so saving from the tab the row
+            // lands on showed nothing. Same reasoning as createOneTimeAccrualEpic.
+            if (periodStart != null && periodEnd != null) {
+                successActions.push(fetchJeSchedules({ start: periodStart, end: periodEnd }, true));
+            }
+            return from(successActions);
         }
         return from([
             saveNewScheduleFailure({ status: response.status }),
@@ -106,5 +128,9 @@ export const saveNewScheduleEpic = (actions$, state$, zeniAPI) => actions$.pipe(
         saveNewScheduleFailure({
             status: createZeniAPIStatus('Unexpected Error', `Save New Schedule REST API call errored out ${JSON.stringify(error)}`),
         }),
-    ])));
+    ])), 
+    // A tenant switch clears the store while this request is still in flight.
+    // Without this the old tenant's response is written back into the freshly
+    // cleared store and stays on screen under the new tenant.
+    takeUntil(actions$.pipe(filter(clearAll.match))));
 }));

package/lib/esm/view/expenseAutomationView/epics/jeSchedule/oneTimeAccrualActionsEpic.js

@@ -1,17 +1,22 @@
 import { from, merge } from 'rxjs';
-import { catchError, filter, mergeMap } from 'rxjs/operators';
+import { catchError, filter, mergeMap, takeUntil } from 'rxjs/operators';
 import { convertToPeriod, toAbsoluteDay, } from '../../../../commonStateTypes/timePeriod';
 import { generateJEOneTimeAccrualKey } from '../../../../entity/jeSchedules/jeScheduleHelper';
 import { updateJEOneTimeAccruals } from '../../../../entity/jeSchedules/jeSchedulesReducer';
 import { getJEOneTimeAccrualByKey } from '../../../../entity/jeSchedules/jeSchedulesSelector';
 import { openSnackbar } from '../../../../entity/snackbar/snackbarReducer';
 import { getCurrentTenant } from '../../../../entity/tenant/tenantSelector';
+import { clearAll } from '../../../../rootActions';
 import { createZeniAPIStatus, isSuccessResponse, } from '../../../../responsePayload';
 import { fetchJeSchedules, ignoreOneTimeAccrual, oneTimeAccrualActionFailure, oneTimeAccrualActionSuccess, promoteOneTimeAccrual, revertOneTimeAccrual, } from '../../reducers/jeSchedulesViewReducer';
 /**
  * The page the accrual came from, so a promoted or ignored row lands in the right bucket. Guarded
  * because convertToPeriod destructures: an unset period would throw and take the epic subscription
  * down for the session, and a missed refresh is the cheaper failure.
+ *
+ * Read state$.value at response time rather than the snapshot taken when the action was dispatched:
+ * if the user changes month while the request is in flight, the snapshot refreshes the month they
+ * have left and the month they are now looking at stays stale.
  */
 function refreshCurrentPage(state) {
     const selectedMonthYear = state.expenseAutomationViewState.selectedPeriodByTenantId[getCurrentTenant(state).tenantId];
@@ -26,14 +31,17 @@ function refreshCurrentPage(state) {
     }
     return [fetchJeSchedules({ start, end }, true)];
 }
-function failureActions(accrualId, message, status) {
+function failureActions(
+// Per action, not fixed: every failure used to read "Save schedule failed", so skipping or
+// reverting an accrual reported an operation the user had not performed.
+messageSection, accrualId, message, status) {
     return [
         oneTimeAccrualActionFailure({
             accrualId,
             status: status ?? createZeniAPIStatus('Unexpected Error', message),
         }),
         openSnackbar({
-            messageSection: 'save_schedule',
+            messageSection,
             messageText: 'failed',
             type: 'error',
             variables: [{ variableName: '_api-error_', variableValue: message }],
@@ -47,7 +55,7 @@ export const promoteOneTimeAccrualEpic = (actions$, state$, zeniAPI) => actions$
     if (accrual?.jeDebitAccountId == null ||
         accrual.jeCreditAccountId == null) {
         // Promote posts a journal entry, so it cannot proceed without both sides of it.
-        return from(failureActions(accrualId, 'This accrual is missing an expense or liability account.'));
+        return from(failureActions('save_schedule', accrualId, 'This accrual is missing an expense or liability account.'));
     }
     // vendor_id, vendor_name and service_month are deliberately absent: promote takes them from
     // the stored draft and ignores them in the body, so sending them would imply a reassignment
@@ -76,14 +84,17 @@ export const promoteOneTimeAccrualEpic = (actions$, state$, zeniAPI) => actions$
                         },
                     ],
                 }),
-                ...refreshCurrentPage(state),
+                ...refreshCurrentPage(state$.value),
             ]);
         }
-        return from(failureActions(accrualId, response.status.message, response.status));
-    }), catchError((error) => from(failureActions(accrualId, `Promote accrual REST API call errored out ${JSON.stringify(error)}`))));
+        return from(failureActions('save_schedule', accrualId, response.status.message, response.status));
+    }), catchError((error) => from(failureActions('save_schedule', accrualId, `Promote accrual REST API call errored out ${JSON.stringify(error)}`))), 
+    // A tenant switch clears the store while this request is still in flight.
+    // Without this the old tenant's response is written back into the freshly
+    // cleared store and stays on screen under the new tenant.
+    takeUntil(actions$.pipe(filter(clearAll.match))));
 }));
 export const ignoreOneTimeAccrualEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(ignoreOneTimeAccrual.match), mergeMap((action) => {
-    const state = state$.value;
     const { accrualId, reason, note } = action.payload;
     // `scope` is deliberately never sent: the API returns 400 on it, which is why the design's
     // "Apply to" selector cannot be built yet.
@@ -103,14 +114,17 @@ export const ignoreOneTimeAccrualEpic = (actions$, state$, zeniAPI) => actions$.
                     messageText: 'success',
                     type: 'success',
                 }),
-                ...refreshCurrentPage(state),
+                ...refreshCurrentPage(state$.value),
             ]);
         }
-        return from(failureActions(accrualId, response.status.message, response.status));
-    }), catchError((error) => from(failureActions(accrualId, `Ignore accrual REST API call errored out ${JSON.stringify(error)}`))));
+        return from(failureActions('ignore_accrual', accrualId, response.status.message, response.status));
+    }), catchError((error) => from(failureActions('ignore_accrual', accrualId, `Ignore accrual REST API call errored out ${JSON.stringify(error)}`))), 
+    // A tenant switch clears the store while this request is still in flight.
+    // Without this the old tenant's response is written back into the freshly
+    // cleared store and stays on screen under the new tenant.
+    takeUntil(actions$.pipe(filter(clearAll.match))));
 }));
 export const revertOneTimeAccrualEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(revertOneTimeAccrual.match), mergeMap((action) => {
-    const state = state$.value;
     const { accrualId, reason, note } = action.payload;
     // Deletes the accrual's journal entry in QBO and soft-deletes the row. `scope` is never sent:
     // the endpoint 400s on it, exactly as ignore does.
@@ -130,10 +144,14 @@ export const revertOneTimeAccrualEpic = (actions$, state$, zeniAPI) => actions$.
                     messageText: 'success',
                     type: 'success',
                 }),
-                ...refreshCurrentPage(state),
+                ...refreshCurrentPage(state$.value),
             ]);
         }
-        return from(failureActions(accrualId, response.status.message, response.status));
-    }), catchError((error) => from(failureActions(accrualId, `Revert accrual REST API call errored out ${JSON.stringify(error)}`))));
+        return from(failureActions('revert_accrual', accrualId, response.status.message, response.status));
+    }), catchError((error) => from(failureActions('revert_accrual', accrualId, `Revert accrual REST API call errored out ${JSON.stringify(error)}`))), 
+    // A tenant switch clears the store while this request is still in flight.
+    // Without this the old tenant's response is written back into the freshly
+    // cleared store and stays on screen under the new tenant.
+    takeUntil(actions$.pipe(filter(clearAll.match))));
 }));
 export const oneTimeAccrualActionsEpic = (actions$, state$, zeniAPI) => merge(promoteOneTimeAccrualEpic(actions$, state$, zeniAPI), ignoreOneTimeAccrualEpic(actions$, state$, zeniAPI), revertOneTimeAccrualEpic(actions$, state$, zeniAPI));

package/lib/esm/view/expenseAutomationView/epics/jeSchedule/revertJeScheduleEpic.js

@@ -1,7 +1,8 @@
 import { from } from 'rxjs';
-import { catchError, filter, mergeMap } from 'rxjs/operators';
+import { catchError, filter, mergeMap, takeUntil } from 'rxjs/operators';
 import { openSnackbar } from '../../../../entity/snackbar/snackbarReducer';
 import { getCurrentTenant } from '../../../../entity/tenant/tenantSelector';
+import { clearAll } from '../../../../rootActions';
 import { createZeniAPIStatus, isSuccessResponse, } from '../../../../responsePayload';
 import { fetchMonthEndCloseChecks } from '../../../monthEndCloseChecksView/monthEndCloseChecksViewReducer';
 import { removeJeAccruedScheduleKey, removeJeScheduleTransactionKey, revertJeSchedule, revertJeScheduleFailure, revertJeScheduleSuccess, } from '../../reducers/jeSchedulesViewReducer';
@@ -102,5 +103,9 @@ export const revertJeScheduleEpic = (actions$, state$, zeniAPI) => actions$.pipe
             messageText: 'failed',
             type: 'error',
         }),
-    ])));
+    ])), 
+    // A tenant switch clears the store while this request is still in flight.
+    // Without this the old tenant's response is written back into the freshly
+    // cleared store and stays on screen under the new tenant.
+    takeUntil(actions$.pipe(filter(clearAll.match))));
 }));

package/lib/esm/view/expenseAutomationView/epics/jeSchedule/switchJESchedulesTabEpic.js

@@ -12,6 +12,12 @@ export const switchJESchedulesTabEpic = (actions$, state$) => actions$.pipe(filt
     }
     const currentTenant = getCurrentTenant(state);
     const selectedPeriod = state.expenseAutomationViewState.selectedPeriodByTenantId[currentTenant.tenantId];
+    // convertToPeriod destructures, so an unset period throws and takes this epic's subscription
+    // down for the rest of the session -- every later tab switch would then stop refreshing. A
+    // skipped refresh is the cheaper failure, as in refreshCurrentPage.
+    if (selectedPeriod == null) {
+        return EMPTY;
+    }
     const period = convertToPeriod(selectedPeriod);
     const timePeriodStart = toAbsoluteDay(period.start);
     const timePeriodEnd = toAbsoluteDay(period.end);

package/lib/esm/view/expenseAutomationView/reducers/jeSchedulesViewReducer.js

@@ -25,6 +25,7 @@ export const accountSettingsInitialState = {
         error: undefined,
         fetchState: 'Not-Started',
     },
+    hasLoadedAccountSettings: false,
     recommendationFetchState: {
         error: undefined,
         fetchState: 'Not-Started',
@@ -171,6 +172,9 @@ const expenseAutomationJESchedulesView = createSlice({
                 draft.jeScheduleTransactionKeysByPeriodAndTab[periodTabKey] = [];
                 draft.jeScheduleAccruedKeysByPeriodAndTab[periodTabKey] = [];
                 draft.jeScheduleOneTimeAccrualKeysByPeriodAndTab[periodTabKey] = [];
+                // Cleared with the rest: leaving it behind kept the previous fetch's resolve rows on an
+                // otherwise empty errored tab, which reads as "these are all the schedules there are".
+                draft.failedJeScheduleTransactionKeysByPeriodAndTab[periodTabKey] = [];
             }
         },
         retryJeSchedule(draft, action) {
@@ -426,6 +430,9 @@ const expenseAutomationJESchedulesView = createSlice({
                 error: status,
                 fetchState: 'Error',
             };
+            // Set on failure too: a tenant whose account list errors must still reach the page rather
+            // than sit under a skeleton forever.
+            draft.accountSettings.hasLoadedAccountSettings = true;
         },
         updateAccountSettingsListForAccountTypes(draft, action) {
             doUpdateAccountSettingsListForAccountTypes(draft.accountSettings, action.payload.accountPayload);
@@ -741,4 +748,5 @@ const doUpdateAccountSettingsListForAccountTypes = (draft, accountPayloadList) =
         error: undefined,
         fetchState: 'Completed',
     };
+    draft.hasLoadedAccountSettings = true;
 };

package/lib/esm/view/expenseAutomationView/selectors/jeAccountSettingsViewSelector.js

@@ -22,6 +22,7 @@ export const getJEAccountSettingsView = createSelector((state) => state.expenseA
         fixedAssetsAccountHierarchy: jeAccountMappingState.fixedAssetsNestedAccountListHierarchy,
         accruedExpensesAccountHierarchy: jeAccountMappingState.accruedExpensesNestedAccountListHierarchy,
         fetchState: fetchState.fetchState,
+        hasLoaded: jeAccountMappingState.hasLoadedAccountSettings,
         saveState,
     };
 });

package/lib/view/expenseAutomationView/epics/jeSchedule/fetchJeSchedulePageEpic.js

@@ -17,7 +17,15 @@ const fetchJeSchedulesPageEpic = (actions$, state$) => actions$.pipe((0, operato
         jeSchedulePageActions.push((0, accountListReducer_1.fetchAccountList)(accountType.accountListKey, true, false, false, false, accountType.allowedAccountList));
     }
     jeSchedulePageActions.push((0, jeSchedulesViewReducer_1.fetchJeSchedules)(period, refreshViewInBackground));
-    jeSchedulePageActions.push((0, jeSchedulesViewReducer_1.initializeAccountSettingsView)());
+    // Only on the first page load. Account settings cannot change from a tab switch or a
+    // refresh, and re-initializing puts accountSettingsView back to 'In-Progress' -- which the
+    // page reads as "still loading" and answers with a full skeleton over rows it already has.
+    // The action also resets localData, so re-dispatching it blindly would empty the settings
+    // form until the refetch lands. Saving account settings still re-initializes explicitly.
+    if (!state$.value.expenseAutomationJESchedulesViewState.accountSettings
+        .hasLoadedAccountSettings) {
+        jeSchedulePageActions.push((0, jeSchedulesViewReducer_1.initializeAccountSettingsView)());
+    }
     return (0, rxjs_1.concat)((0, rxjs_1.from)(jeSchedulePageActions));
 }));
 exports.fetchJeSchedulesPageEpic = fetchJeSchedulesPageEpic;

package/lib/view/expenseAutomationView/epics/jeSchedule/newSchedule/createOneTimeAccrualEpic.d.ts

@@ -2,7 +2,8 @@ import { ActionsObservable, StateObservable } from 'redux-observable';
 import { updateJEOneTimeAccruals } from '../../../../../entity/jeSchedules/jeSchedulesReducer';
 import { openSnackbar } from '../../../../../entity/snackbar/snackbarReducer';
 import { RootState } from '../../../../../reducer';
+import { clearAll } from '../../../../../rootActions';
 import { ZeniAPI } from '../../../../../zeniAPI';
 import { createOneTimeAccrual, createOneTimeAccrualFailure, createOneTimeAccrualSuccess, fetchJeSchedules } from '../../../reducers/jeSchedulesViewReducer';
-export type ActionType = ReturnType<typeof createOneTimeAccrual> | ReturnType<typeof createOneTimeAccrualSuccess> | ReturnType<typeof createOneTimeAccrualFailure> | ReturnType<typeof updateJEOneTimeAccruals> | ReturnType<typeof fetchJeSchedules> | ReturnType<typeof openSnackbar>;
+export type ActionType = ReturnType<typeof clearAll> | ReturnType<typeof createOneTimeAccrual> | ReturnType<typeof createOneTimeAccrualSuccess> | ReturnType<typeof createOneTimeAccrualFailure> | ReturnType<typeof updateJEOneTimeAccruals> | ReturnType<typeof fetchJeSchedules> | ReturnType<typeof openSnackbar>;
 export declare const createOneTimeAccrualEpic: (actions$: ActionsObservable<ActionType>, state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => import("rxjs").Observable<ActionType>;

package/lib/view/expenseAutomationView/epics/jeSchedule/newSchedule/createOneTimeAccrualEpic.js

@@ -7,6 +7,7 @@ const timePeriod_1 = require("../../../../../commonStateTypes/timePeriod");
 const jeSchedulesReducer_1 = require("../../../../../entity/jeSchedules/jeSchedulesReducer");
 const snackbarReducer_1 = require("../../../../../entity/snackbar/snackbarReducer");
 const tenantSelector_1 = require("../../../../../entity/tenant/tenantSelector");
+const rootActions_1 = require("../../../../../rootActions");
 const responsePayload_1 = require("../../../../../responsePayload");
 const jeSchedulesPayload_1 = require("../../../payload/jeSchedulesPayload");
 const jeSchedulesViewReducer_1 = require("../../../reducers/jeSchedulesViewReducer");
@@ -98,6 +99,10 @@ const createOneTimeAccrualEpic = (actions$, state$, zeniAPI) => actions$.pipe((0
         (0, jeSchedulesViewReducer_1.createOneTimeAccrualFailure)({
             status: (0, responsePayload_1.createZeniAPIStatus)('Unexpected Error', `Create One Time Accrual REST API call errored out ${JSON.stringify(error)}`),
         }),
-    ])));
+    ])), 
+    // A tenant switch clears the store while this request is still in flight.
+    // Without this the old tenant's response is written back into the freshly
+    // cleared store and stays on screen under the new tenant.
+    (0, operators_1.takeUntil)(actions$.pipe((0, operators_1.filter)(rootActions_1.clearAll.match))));
 }));
 exports.createOneTimeAccrualEpic = createOneTimeAccrualEpic;

package/lib/view/expenseAutomationView/epics/jeSchedule/newSchedule/saveNewScheduleEpic.d.ts

@@ -1,45 +1,9 @@
 import { ActionsObservable, StateObservable } from 'redux-observable';
+import { clearAll } from '../../../../../rootActions';
 import { updateJESchedules, updateJESchedulesDetails } from '../../../../../entity/jeSchedules/jeSchedulesReducer';
 import { openSnackbar } from '../../../../../entity/snackbar/snackbarReducer';
 import { RootState } from '../../../../../reducer';
 import { ZeniAPI } from '../../../../../zeniAPI';
-import { resetNewScheduleLocalData, saveNewSchedule, saveNewScheduleFailure, saveNewScheduleSuccess } from '../../../reducers/jeSchedulesViewReducer';
-export type ActionType = ReturnType<typeof saveNewSchedule> | ReturnType<typeof saveNewScheduleSuccess> | ReturnType<typeof saveNewScheduleFailure> | ReturnType<typeof updateJESchedules> | ReturnType<typeof updateJESchedulesDetails> | ReturnType<typeof resetNewScheduleLocalData> | ReturnType<typeof openSnackbar>;
-export declare const saveNewScheduleEpic: (actions$: ActionsObservable<ActionType>, state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => import("rxjs").Observable<{
-    payload: {
-        messageSection: import("../../../../..").SnackbarMessageSections;
-        messageText: import("../../../../..").SnackbarMessageSectionTexts;
-        type: import("../../../../..").SnackbarMessageType;
-        showStatusIcon?: boolean;
-        variables?: {
-            variableName: string;
-            variableValue: string;
-        }[];
-    };
-    type: "snackbar/openSnackbar";
-} | {
-    payload: {
-        jeSchedulesTransactionsPayload: import("../../../../../entity/jeSchedules/jeSchedulesPayload").JEScheduledTransactionPayload[];
-    };
-    type: "jeSchedules/updateJESchedules";
-} | {
-    payload: {
-        jeSchedulesPayload: import("../../../../../entity/jeSchedules/jeSchedulesPayload").JEScheduledTransactionPayload[];
-        scheduledJEntriesPayload: import("../../../../../entity/jeSchedules/jeSchedulesPayload").ScheduledJournalEntryPayload[] | undefined;
-        updateType: import("../../../../..").UpdateType;
-    };
-    type: "jeSchedules/updateJESchedulesDetails";
-} | {
-    payload: {
-        scheduleType: "prepaid_expenses" | "fixed_assets";
-    };
-    type: "expenseAutomationJESchedulesView/resetNewScheduleLocalData";
-} | {
-    payload: undefined;
-    type: "expenseAutomationJESchedulesView/saveNewScheduleSuccess";
-} | {
-    payload: {
-        status: import("../../../../../zeniAPIStatus").ZeniAPIStatus;
-    };
-    type: "expenseAutomationJESchedulesView/saveNewScheduleFailure";
-}>;
+import { fetchJeSchedules, resetNewScheduleLocalData, saveNewSchedule, saveNewScheduleFailure, saveNewScheduleSuccess } from '../../../reducers/jeSchedulesViewReducer';
+export type ActionType = ReturnType<typeof saveNewSchedule> | ReturnType<typeof saveNewScheduleSuccess> | ReturnType<typeof saveNewScheduleFailure> | ReturnType<typeof updateJESchedules> | ReturnType<typeof updateJESchedulesDetails> | ReturnType<typeof resetNewScheduleLocalData> | ReturnType<typeof fetchJeSchedules> | ReturnType<typeof clearAll> | ReturnType<typeof openSnackbar>;
+export declare const saveNewScheduleEpic: (actions$: ActionsObservable<ActionType>, state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => import("rxjs").Observable<ActionType>;

package/lib/view/expenseAutomationView/epics/jeSchedule/newSchedule/saveNewScheduleEpic.js

@@ -3,6 +3,9 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.saveNewScheduleEpic = void 0;
 const rxjs_1 = require("rxjs");
 const operators_1 = require("rxjs/operators");
+const timePeriod_1 = require("../../../../../commonStateTypes/timePeriod");
+const tenantSelector_1 = require("../../../../../entity/tenant/tenantSelector");
+const rootActions_1 = require("../../../../../rootActions");
 const jeSchedulesReducer_1 = require("../../../../../entity/jeSchedules/jeSchedulesReducer");
 const jeSchedulesTypes_1 = require("../../../../../entity/jeSchedules/jeSchedulesTypes");
 const snackbarReducer_1 = require("../../../../../entity/snackbar/snackbarReducer");
@@ -61,11 +64,21 @@ const saveNewScheduleEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, ope
         je_schedule_type: scheduleType,
     };
     const payload = { ...result.payload };
+    // convertToPeriod destructures, so an unset period would throw here and take the epic
+    // subscription down for the whole session -- a missed refresh is the cheaper failure.
+    const selectedMonthYear = state.expenseAutomationViewState.selectedPeriodByTenantId[(0, tenantSelector_1.getCurrentTenant)(state).tenantId];
+    const selectedPeriod = selectedMonthYear != null
+        ? (0, timePeriod_1.convertToPeriod)(selectedMonthYear)
+        : undefined;
+    const periodStart = selectedPeriod != null
+        ? (0, timePeriod_1.toAbsoluteDay)(selectedPeriod.start)
+        : undefined;
+    const periodEnd = selectedPeriod != null ? (0, timePeriod_1.toAbsoluteDay)(selectedPeriod.end) : undefined;
     return zeniAPI
         .postAndGetJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/schedules?query=${encodeURIComponent(JSON.stringify(queryParam))}`, payload)
         .pipe((0, operators_1.mergeMap)((response) => {
         if ((0, responsePayload_1.isSuccessResponse)(response) && response.data != null) {
-            return (0, rxjs_1.from)([
+            const successActions = [
                 (0, jeSchedulesReducer_1.updateJESchedules)(response.data.je_schedules),
                 (0, jeSchedulesReducer_1.updateJESchedulesDetails)(response.data.je_schedules, response.data.scheduled_journal_entries),
                 (0, jeSchedulesViewReducer_1.resetNewScheduleLocalData)({ scheduleType }),
@@ -78,7 +91,16 @@ const saveNewScheduleEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, ope
                         { variableName: '_vendor_name_', variableValue: vendorName },
                     ],
                 }),
-            ]);
+            ];
+            // Writing the entity is not enough: the list reads
+            // jeScheduleTransactionKeysByPeriodAndTab, which is rebuilt wholesale per fetch, so
+            // without this the new schedule stays invisible until some later fetch. The page
+            // only refetches when the save also changes tab, so saving from the tab the row
+            // lands on showed nothing. Same reasoning as createOneTimeAccrualEpic.
+            if (periodStart != null && periodEnd != null) {
+                successActions.push((0, jeSchedulesViewReducer_1.fetchJeSchedules)({ start: periodStart, end: periodEnd }, true));
+            }
+            return (0, rxjs_1.from)(successActions);
         }
         return (0, rxjs_1.from)([
             (0, jeSchedulesViewReducer_1.saveNewScheduleFailure)({ status: response.status }),
@@ -109,6 +131,10 @@ const saveNewScheduleEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, ope
         (0, jeSchedulesViewReducer_1.saveNewScheduleFailure)({
             status: (0, responsePayload_1.createZeniAPIStatus)('Unexpected Error', `Save New Schedule REST API call errored out ${JSON.stringify(error)}`),
         }),
-    ])));
+    ])), 
+    // A tenant switch clears the store while this request is still in flight.
+    // Without this the old tenant's response is written back into the freshly
+    // cleared store and stays on screen under the new tenant.
+    (0, operators_1.takeUntil)(actions$.pipe((0, operators_1.filter)(rootActions_1.clearAll.match))));
 }));
 exports.saveNewScheduleEpic = saveNewScheduleEpic;

package/lib/view/expenseAutomationView/epics/jeSchedule/oneTimeAccrualActionsEpic.d.ts

@@ -3,9 +3,10 @@ import { Observable } from 'rxjs';
 import { updateJEOneTimeAccruals } from '../../../../entity/jeSchedules/jeSchedulesReducer';
 import { openSnackbar } from '../../../../entity/snackbar/snackbarReducer';
 import { RootState } from '../../../../reducer';
+import { clearAll } from '../../../../rootActions';
 import { ZeniAPI } from '../../../../zeniAPI';
 import { fetchJeSchedules, ignoreOneTimeAccrual, oneTimeAccrualActionFailure, oneTimeAccrualActionSuccess, promoteOneTimeAccrual, revertOneTimeAccrual } from '../../reducers/jeSchedulesViewReducer';
-export type ActionType = ReturnType<typeof promoteOneTimeAccrual> | ReturnType<typeof revertOneTimeAccrual> | ReturnType<typeof ignoreOneTimeAccrual> | ReturnType<typeof oneTimeAccrualActionSuccess> | ReturnType<typeof oneTimeAccrualActionFailure> | ReturnType<typeof updateJEOneTimeAccruals> | ReturnType<typeof fetchJeSchedules> | ReturnType<typeof openSnackbar>;
+export type ActionType = ReturnType<typeof clearAll> | ReturnType<typeof promoteOneTimeAccrual> | ReturnType<typeof revertOneTimeAccrual> | ReturnType<typeof ignoreOneTimeAccrual> | ReturnType<typeof oneTimeAccrualActionSuccess> | ReturnType<typeof oneTimeAccrualActionFailure> | ReturnType<typeof updateJEOneTimeAccruals> | ReturnType<typeof fetchJeSchedules> | ReturnType<typeof openSnackbar>;
 export declare const promoteOneTimeAccrualEpic: (actions$: ActionsObservable<ActionType>, state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => Observable<ActionType>;
 export declare const ignoreOneTimeAccrualEpic: (actions$: ActionsObservable<ActionType>, state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => Observable<ActionType>;
 export declare const revertOneTimeAccrualEpic: (actions$: ActionsObservable<ActionType>, state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => Observable<ActionType>;

package/lib/view/expenseAutomationView/epics/jeSchedule/oneTimeAccrualActionsEpic.js

@@ -9,12 +9,17 @@ const jeSchedulesReducer_1 = require("../../../../entity/jeSchedules/jeSchedules
 const jeSchedulesSelector_1 = require("../../../../entity/jeSchedules/jeSchedulesSelector");
 const snackbarReducer_1 = require("../../../../entity/snackbar/snackbarReducer");
 const tenantSelector_1 = require("../../../../entity/tenant/tenantSelector");
+const rootActions_1 = require("../../../../rootActions");
 const responsePayload_1 = require("../../../../responsePayload");
 const jeSchedulesViewReducer_1 = require("../../reducers/jeSchedulesViewReducer");
 /**
  * The page the accrual came from, so a promoted or ignored row lands in the right bucket. Guarded
  * because convertToPeriod destructures: an unset period would throw and take the epic subscription
  * down for the session, and a missed refresh is the cheaper failure.
+ *
+ * Read state$.value at response time rather than the snapshot taken when the action was dispatched:
+ * if the user changes month while the request is in flight, the snapshot refreshes the month they
+ * have left and the month they are now looking at stays stale.
  */
 function refreshCurrentPage(state) {
     const selectedMonthYear = state.expenseAutomationViewState.selectedPeriodByTenantId[(0, tenantSelector_1.getCurrentTenant)(state).tenantId];
@@ -29,14 +34,17 @@ function refreshCurrentPage(state) {
     }
     return [(0, jeSchedulesViewReducer_1.fetchJeSchedules)({ start, end }, true)];
 }
-function failureActions(accrualId, message, status) {
+function failureActions(
+// Per action, not fixed: every failure used to read "Save schedule failed", so skipping or
+// reverting an accrual reported an operation the user had not performed.
+messageSection, accrualId, message, status) {
     return [
         (0, jeSchedulesViewReducer_1.oneTimeAccrualActionFailure)({
             accrualId,
             status: status ?? (0, responsePayload_1.createZeniAPIStatus)('Unexpected Error', message),
         }),
         (0, snackbarReducer_1.openSnackbar)({
-            messageSection: 'save_schedule',
+            messageSection,
             messageText: 'failed',
             type: 'error',
             variables: [{ variableName: '_api-error_', variableValue: message }],
@@ -50,7 +58,7 @@ const promoteOneTimeAccrualEpic = (actions$, state$, zeniAPI) => actions$.pipe((
     if (accrual?.jeDebitAccountId == null ||
         accrual.jeCreditAccountId == null) {
         // Promote posts a journal entry, so it cannot proceed without both sides of it.
-        return (0, rxjs_1.from)(failureActions(accrualId, 'This accrual is missing an expense or liability account.'));
+        return (0, rxjs_1.from)(failureActions('save_schedule', accrualId, 'This accrual is missing an expense or liability account.'));
     }
     // vendor_id, vendor_name and service_month are deliberately absent: promote takes them from
     // the stored draft and ignores them in the body, so sending them would imply a reassignment
@@ -79,15 +87,18 @@ const promoteOneTimeAccrualEpic = (actions$, state$, zeniAPI) => actions$.pipe((
                         },
                     ],
                 }),
-                ...refreshCurrentPage(state),
+                ...refreshCurrentPage(state$.value),
             ]);
         }
-        return (0, rxjs_1.from)(failureActions(accrualId, response.status.message, response.status));
-    }), (0, operators_1.catchError)((error) => (0, rxjs_1.from)(failureActions(accrualId, `Promote accrual REST API call errored out ${JSON.stringify(error)}`))));
+        return (0, rxjs_1.from)(failureActions('save_schedule', accrualId, response.status.message, response.status));
+    }), (0, operators_1.catchError)((error) => (0, rxjs_1.from)(failureActions('save_schedule', accrualId, `Promote accrual REST API call errored out ${JSON.stringify(error)}`))), 
+    // A tenant switch clears the store while this request is still in flight.
+    // Without this the old tenant's response is written back into the freshly
+    // cleared store and stays on screen under the new tenant.
+    (0, operators_1.takeUntil)(actions$.pipe((0, operators_1.filter)(rootActions_1.clearAll.match))));
 }));
 exports.promoteOneTimeAccrualEpic = promoteOneTimeAccrualEpic;
 const ignoreOneTimeAccrualEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(jeSchedulesViewReducer_1.ignoreOneTimeAccrual.match), (0, operators_1.mergeMap)((action) => {
-    const state = state$.value;
     const { accrualId, reason, note } = action.payload;
     // `scope` is deliberately never sent: the API returns 400 on it, which is why the design's
     // "Apply to" selector cannot be built yet.
@@ -107,15 +118,18 @@ const ignoreOneTimeAccrualEpic = (actions$, state$, zeniAPI) => actions$.pipe((0
                     messageText: 'success',
                     type: 'success',
                 }),
-                ...refreshCurrentPage(state),
+                ...refreshCurrentPage(state$.value),
             ]);
         }
-        return (0, rxjs_1.from)(failureActions(accrualId, response.status.message, response.status));
-    }), (0, operators_1.catchError)((error) => (0, rxjs_1.from)(failureActions(accrualId, `Ignore accrual REST API call errored out ${JSON.stringify(error)}`))));
+        return (0, rxjs_1.from)(failureActions('ignore_accrual', accrualId, response.status.message, response.status));
+    }), (0, operators_1.catchError)((error) => (0, rxjs_1.from)(failureActions('ignore_accrual', accrualId, `Ignore accrual REST API call errored out ${JSON.stringify(error)}`))), 
+    // A tenant switch clears the store while this request is still in flight.
+    // Without this the old tenant's response is written back into the freshly
+    // cleared store and stays on screen under the new tenant.
+    (0, operators_1.takeUntil)(actions$.pipe((0, operators_1.filter)(rootActions_1.clearAll.match))));
 }));
 exports.ignoreOneTimeAccrualEpic = ignoreOneTimeAccrualEpic;
 const revertOneTimeAccrualEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(jeSchedulesViewReducer_1.revertOneTimeAccrual.match), (0, operators_1.mergeMap)((action) => {
-    const state = state$.value;
     const { accrualId, reason, note } = action.payload;
     // Deletes the accrual's journal entry in QBO and soft-deletes the row. `scope` is never sent:
     // the endpoint 400s on it, exactly as ignore does.
@@ -135,11 +149,15 @@ const revertOneTimeAccrualEpic = (actions$, state$, zeniAPI) => actions$.pipe((0
                     messageText: 'success',
                     type: 'success',
                 }),
-                ...refreshCurrentPage(state),
+                ...refreshCurrentPage(state$.value),
             ]);
         }
-        return (0, rxjs_1.from)(failureActions(accrualId, response.status.message, response.status));
-    }), (0, operators_1.catchError)((error) => (0, rxjs_1.from)(failureActions(accrualId, `Revert accrual REST API call errored out ${JSON.stringify(error)}`))));
+        return (0, rxjs_1.from)(failureActions('revert_accrual', accrualId, response.status.message, response.status));
+    }), (0, operators_1.catchError)((error) => (0, rxjs_1.from)(failureActions('revert_accrual', accrualId, `Revert accrual REST API call errored out ${JSON.stringify(error)}`))), 
+    // A tenant switch clears the store while this request is still in flight.
+    // Without this the old tenant's response is written back into the freshly
+    // cleared store and stays on screen under the new tenant.
+    (0, operators_1.takeUntil)(actions$.pipe((0, operators_1.filter)(rootActions_1.clearAll.match))));
 }));
 exports.revertOneTimeAccrualEpic = revertOneTimeAccrualEpic;
 const oneTimeAccrualActionsEpic = (actions$, state$, zeniAPI) => (0, rxjs_1.merge)((0, exports.promoteOneTimeAccrualEpic)(actions$, state$, zeniAPI), (0, exports.ignoreOneTimeAccrualEpic)(actions$, state$, zeniAPI), (0, exports.revertOneTimeAccrualEpic)(actions$, state$, zeniAPI));