@zeniai/client-epic-state 5.2.11-beta0ND → 5.2.11-betaRD2

package/lib/esm/view/expenseAutomationView/selectors/jeSchedulesViewSelector.js

@@ -3,7 +3,9 @@ import orderBy from 'lodash/orderBy';
 import { reduceAnyFetchState } from '../../../commonStateTypes/reduceFetchState';
 import { LAST_SCHEDULE_DAY_OF_MONTH, toMonthYearPeriodId, } from '../../../commonStateTypes/timePeriod';
 import { getAccountIdsForTypes } from '../../../entity/account/accountSelector';
-import { getJEScheduledTransactionByJEScheduleTransactionKey, } from '../../../entity/jeSchedules/jeSchedulesSelector';
+import { generateJEOneTimeAccrualKey } from '../../../entity/jeSchedules/jeScheduleHelper';
+import { getJEAccruedScheduleByJEScheduleKey, getJEOneTimeAccrualByKey, getJEScheduledTransactionByJEScheduleTransactionKey, } from '../../../entity/jeSchedules/jeSchedulesSelector';
+import { ALL_SCHEDULES_TYPES, } from '../../../entity/jeSchedules/jeSchedulesTypes';
 import { getCurrentTenant } from '../../../entity/tenant/tenantSelector';
 import { getAccountIdsForLabel, getAccountList, getNestedAccountListHierarchy, getUncategorizedAccounts, } from '../../accountList/accountListSelector';
 import { getClassList, getNestedClassListHierarchy, } from '../../classList/classListSelector';
@@ -11,8 +13,126 @@ import { getAccountsTypesForScheduleDetails } from '../../scheduleView/scheduleD
 import { filterNestedAccountHierarchyById } from '../../scheduleView/scheduleDetailView/scheduleDetailSelector';
 import { getAccountLabelForScheduleType, getAccountsTypesForScheduleList, } from '../../scheduleView/scheduleListView/scheduleListHelper';
 import { getAllSteps } from './getAllStepsHelper';
+import { ALL_JE_PAGE_TABS, getJESchedulePeriodTabKey, } from '../types/jeSchedulesViewState';
 import { getJEAccountSettingsView } from './jeAccountSettingsViewSelector';
+import { getNewScheduleView } from './jeNewScheduleViewSelector';
+// Matches the AI-automation user addresses webc's schedule list row already
+// checks (JEScheduleReadOnlyListRow/JEScheduleDraftListRow "Method" column,
+// strings.ts aiBotEmail/botEmail) to determine whether a schedule was
+// created by the AI accountant vs. a human.
+const AI_BOT_EMAIL = 'ai@zeni.ai';
+const BOT_EMAIL = 'bot@zeni.ai';
+// A one-time accrual has no jeScheduleType of its own — it is not a JE schedule. It is still an
+// accrued expense, so it counts and filters under that type on the page's type tabs.
+const ONE_TIME_ACCRUAL_SCHEDULE_TYPE = 'accrued_expenses';
+// Which of the two list buckets an accrual belongs in. `draft` still needs a human to post it;
+// everything else is already on the books or in a transient claim.
+const ONE_TIME_ACCRUAL_REVIEW_STATUSES = [
+    'draft',
+];
+/**
+ * `posting_blocked` is written by the posting Cron when a JE fails to post. It is an internal
+ * failure state with no human action attached, so it is dropped here rather than hidden at render
+ * time — filtering in the view would leave the group counts and KPI totals counting rows nobody
+ * can see. The expense-automation endpoint applies no status filter on the close-period path, so
+ * these rows do arrive.
+ */
+export function isRenderableOneTimeAccrual(accrual) {
+    return accrual.accrualStatus !== 'posting_blocked';
+}
+export function getJEScheduleRowType(schedule) {
+    return isOneTimeAccrualRow(schedule)
+        ? ONE_TIME_ACCRUAL_SCHEDULE_TYPE
+        : schedule.jeScheduleType;
+}
+export function isPendingReviewRow(schedule) {
+    return isOneTimeAccrualRow(schedule)
+        ? ONE_TIME_ACCRUAL_REVIEW_STATUSES.includes(schedule.accrualStatus)
+        : schedule.status.code === 'draft';
+}
+// Belongs on the Existing Schedules tab. For an accrual the endpoint has already filtered to
+// posted, so this only has to agree with that rather than re-derive it.
+export function isExistingTabRow(schedule) {
+    return isOneTimeAccrualRow(schedule)
+        ? schedule.accrualStatus === 'posted'
+        : schedule.status.code === 'ongoing';
+}
+// Exported (rather than kept as a closure inside the selector) so it can be
+// unit-tested directly — confidenceScore is a separate, more narrowly
+// populated field that can be null on a schedule the bot user created,
+// which previously caused these schedules to display as "AI Accountant" in
+// the list but count under "Manual" in the KPI summary.
+export const isAiAccountantSchedule = (schedule) => {
+    // A one-time accrual records who made it as `origin`, which is authoritative — no email
+    // sniffing needed, and the JE bot is often absent from the user entity entirely.
+    if (isOneTimeAccrualRow(schedule)) {
+        return schedule.origin === 'agent';
+    }
+    return (schedule.createdByUser?.email === AI_BOT_EMAIL ||
+        schedule.createdByUser?.email === BOT_EMAIL);
+};
+// Accrued schedules are structurally distinct — no baseTransaction, carrying recurringAmount and
+// memo in its place — so anything reading baseTransaction has to branch on this first.
+//
+// Discriminates on jeAccruedScheduleKey, which only JEAccruedSchedule carries. jeScheduleType
+// cannot be used: it is a data field present on BOTH row shapes, so an accrued-typed row that
+// arrived through the prepaid/fixed DTO (failed_je_postings, legacy fetches) would be
+// misclassified and then crash on recurringAmount / jeAccruedScheduleKey.
+export function isAccruedScheduleRow(schedule) {
+    return 'jeAccruedScheduleKey' in schedule;
+}
+// Same structural approach as isAccruedScheduleRow, and for the same reason: jeOneTimeAccrualKey
+// exists only on this shape. Note the two guards are NOT interchangeable — a one-time accrual is
+// not an accrued *schedule*, and routing it into the accrued branch would read recurringAmount,
+// render postedCount/lifecycleTotal as a lifecycle and startDate–endDate as a period, none of
+// which it has.
+export function isOneTimeAccrualRow(schedule) {
+    return 'jeOneTimeAccrualKey' in schedule;
+}
+function getScheduleAmount(schedule) {
+    if (isOneTimeAccrualRow(schedule)) {
+        return schedule.estimatedAmount.amount;
+    }
+    if (isAccruedScheduleRow(schedule)) {
+        return schedule.recurringAmount.amount;
+    }
+    return schedule.baseTransaction.amount.amount;
+}
+// A one-time accrual shares almost no sortable field with a schedule, so it gets its own accessor
+// rather than a guard on each of the dozen cases below. Keys with no meaning for a single-month
+// accrual -- amortizationPeriod, remainingMonths, runningBalance, jePostingDate, scheduleCategory --
+// deliberately fall through to undefined, which sorts them together at one end.
+function getOneTimeAccrualSortValue(accrual, sortKey) {
+    switch (sortKey) {
+        case 'vendor':
+            return accrual.vendorName.toLowerCase();
+        case 'category':
+            return accrual.jeDebitAccountName?.toLowerCase();
+        case 'class':
+            return accrual.jeDebitAccountingClassName?.toLowerCase();
+        case 'depCategory':
+            return accrual.jeCreditAccountName?.toLowerCase();
+        case 'type':
+            return ONE_TIME_ACCRUAL_SCHEDULE_TYPE;
+        case 'totalAmount':
+            return accrual.estimatedAmount.amount;
+        case 'transactionDate':
+            return accrual.postingDate?.valueOf();
+        case 'memo':
+            return accrual.memo.toLowerCase();
+        case 'startMonth':
+            return accrual.serviceMonth;
+        default:
+            return undefined;
+    }
+}
 function getJEScheduleSortAccessor(sortKey) {
+    const scheduleAccessor = getScheduleRowSortAccessor(sortKey);
+    return (schedule) => isOneTimeAccrualRow(schedule)
+        ? getOneTimeAccrualSortValue(schedule, sortKey)
+        : scheduleAccessor(schedule);
+}
+function getScheduleRowSortAccessor(sortKey) {
     switch (sortKey) {
         case 'vendor':
             return (s) => s.vendor.name?.toLowerCase();
@@ -23,7 +143,9 @@ function getJEScheduleSortAccessor(sortKey) {
         case 'depCategory':
             return (s) => s.jeCredit.account?.accountName?.toLowerCase();
         case 'scheduleCategory':
-            return (s) => s.baseTransaction.account?.accountName?.toLowerCase();
+            return (s) => isAccruedScheduleRow(s)
+                ? undefined
+                : s.baseTransaction.account?.accountName?.toLowerCase();
         case 'startMonth':
             return (s) => s.startDate?.valueOf();
         case 'type':
@@ -51,11 +173,13 @@ function getJEScheduleSortAccessor(sortKey) {
                 return s.balanceAsOfToday?.amount ?? null;
             };
         case 'totalAmount':
-            return (s) => s.baseTransaction.amount.amount;
+            return (s) => getScheduleAmount(s);
         case 'transactionDate':
-            return (s) => s.baseTransaction.date.valueOf();
+            return (s) => s.createTime?.valueOf();
         case 'memo':
-            return (s) => s.baseTransaction.memo?.toLowerCase();
+            return (s) => isAccruedScheduleRow(s)
+                ? s.memo.toLowerCase()
+                : s.baseTransaction.memo?.toLowerCase();
         default:
             return (s) => s.startDate?.valueOf();
     }
@@ -67,9 +191,15 @@ function sortJEScheduledTransactions(transactions, sortKey, sortOrder) {
 export function getExpenseAutomationJESchedulesView(state) {
     const jeScheduledTransaction = [];
     const failedJeScheduledTransaction = [];
+    const accruedSchedules = [];
+    const oneTimeAccruals = [];
     const { accountState, accountListState, classState, classListState, expenseAutomationJESchedulesViewState, expenseAutomationViewState, monthEndCloseChecksState, monthEndCloseChecksViewState, } = state;
-    const { jeScheduleTransactionKeysByPeriod, failedJeScheduleTransactionKeysByPeriod, jeScheduleLocalDataById, postStatusById, ignoreStatusById, uiState, error, fetchState, refreshStatus, } = expenseAutomationJESchedulesViewState;
+    const { jeScheduleTransactionKeysByPeriodAndTab, jeScheduleAccruedKeysByPeriodAndTab, jeScheduleOneTimeAccrualKeysByPeriodAndTab, failedJeScheduleTransactionKeysByPeriodAndTab, jeScheduleLocalDataById, postStatusById, ignoreStatusById, revertStatusById, oneTimeAccrualActionStatusById, uiState, error, fetchState, refreshStatus, newSchedule, } = expenseAutomationJESchedulesViewState;
     const accountSettingsView = getJEAccountSettingsView(state);
+    const newScheduleView = newSchedule.selectedDetailScheduleType === 'fixed_assets' ||
+        newSchedule.selectedDetailScheduleType === 'prepaid_expenses'
+        ? getNewScheduleView(state, newSchedule.selectedDetailScheduleType)
+        : undefined;
     const currentTenant = getCurrentTenant(state);
     const { selectedPeriodByTenantId } = expenseAutomationViewState;
     const selectedPeriod = selectedPeriodByTenantId[currentTenant.tenantId];
@@ -97,27 +227,48 @@ export function getExpenseAutomationJESchedulesView(state) {
     const filteredDepAccountListNestedAccountHierarchy = filterNestedAccountHierarchyById(depAccountListNestedAccountHierarchy, filteredDepAccounts.map((account) => account.accountId));
     const classListNestedAccountHierarchy = getNestedClassListHierarchy(classListState);
     const monthYearPeriodId = selectedPeriod != null ? toMonthYearPeriodId(selectedPeriod) : null;
-    const jeScheduleTransactionKeysForSelectedPeriod = monthYearPeriodId != null
-        ? jeScheduleTransactionKeysByPeriod[monthYearPeriodId]
-        : null;
-    const failedJeScheduleTransactionKeysForSelectedPeriod = monthYearPeriodId != null
-        ? failedJeScheduleTransactionKeysByPeriod[monthYearPeriodId]
+    const selectedPeriodTabKey = monthYearPeriodId != null
+        ? getJESchedulePeriodTabKey(uiState.selectedPageTab, monthYearPeriodId)
         : null;
-    const jeScheduleTransactionKeys = jeScheduleTransactionKeysForSelectedPeriod ?? [];
-    const failedJeScheduleTransactionKeys = failedJeScheduleTransactionKeysForSelectedPeriod ?? [];
+    const jeScheduleTransactionKeysForSelectedTab = selectedPeriodTabKey != null
+        ? jeScheduleTransactionKeysByPeriodAndTab[selectedPeriodTabKey]
+        : undefined;
+    const failedJeScheduleTransactionKeysForSelectedTab = selectedPeriodTabKey != null
+        ? failedJeScheduleTransactionKeysByPeriodAndTab[selectedPeriodTabKey]
+        : undefined;
+    // Distinguishes "this tab has never been fetched for this period" from "fetched and genuinely
+    // empty". Without it the page cannot tell a first visit from a real empty state, and renders an
+    // empty table where it should render a skeleton.
+    const hasLoadedForSelectedTab = jeScheduleTransactionKeysForSelectedTab != null;
+    const jeScheduleTransactionKeys = jeScheduleTransactionKeysForSelectedTab ?? [];
+    const failedJeScheduleTransactionKeys = failedJeScheduleTransactionKeysForSelectedTab ?? [];
+    const jeScheduleAccruedKeys = (selectedPeriodTabKey != null
+        ? jeScheduleAccruedKeysByPeriodAndTab[selectedPeriodTabKey]
+        : undefined) ?? [];
+    const jeScheduleOneTimeAccrualKeys = (selectedPeriodTabKey != null
+        ? jeScheduleOneTimeAccrualKeysByPeriodAndTab[selectedPeriodTabKey]
+        : undefined) ?? [];
+    jeScheduleOneTimeAccrualKeys.forEach((jeOneTimeAccrualKey) => {
+        const accrual = getJEOneTimeAccrualByKey(jeOneTimeAccrualKey, state.jeSchedulesState);
+        if (accrual != null && isRenderableOneTimeAccrual(accrual)) {
+            oneTimeAccruals.push(accrual);
+        }
+    });
     jeScheduleTransactionKeys.forEach((jeScheduleKey) => {
         const jeScheduleDetails = getJEScheduledTransactionByJEScheduleTransactionKey(jeScheduleKey, state);
         jeScheduledTransaction.push(jeScheduleDetails);
     });
+    jeScheduleAccruedKeys.forEach((jeAccruedScheduleKey) => {
+        const accruedScheduleDetails = getJEAccruedScheduleByJEScheduleKey(jeAccruedScheduleKey, state);
+        if (accruedScheduleDetails != null) {
+            accruedSchedules.push(accruedScheduleDetails);
+        }
+    });
     failedJeScheduleTransactionKeys.forEach((jeScheduleKey) => {
         const jeScheduleDetails = getJEScheduledTransactionByJEScheduleTransactionKey(jeScheduleKey, state);
         failedJeScheduledTransaction.push(jeScheduleDetails);
     });
-    const { sortKey, sortOrder } = uiState;
-    const draftSchedules = sortJEScheduledTransactions(jeScheduledTransaction.filter((schedule) => schedule.status.code === 'draft'), sortKey, sortOrder);
-    const ongoingSchedules = sortJEScheduledTransactions(jeScheduledTransaction.filter((schedule) => schedule.status.code === 'ongoing'), sortKey, sortOrder);
-    const completedSchedules = sortJEScheduledTransactions(jeScheduledTransaction.filter((schedule) => schedule.status.code === 'completed' ||
-        schedule.status.code === 'marked_as_completed'), sortKey, sortOrder);
+    const { sortKey, sortOrder, selectedJETypeFilter } = uiState;
     const unsortedResolveSchedules = [];
     failedJeScheduledTransaction.forEach((schedule) => {
         schedule.scheduledJournalEntry.forEach((journalEntry) => {
@@ -129,10 +280,87 @@ export function getExpenseAutomationJESchedulesView(state) {
     });
     const resolveSchedules = sortJEScheduledTransactions(unsortedResolveSchedules, sortKey, sortOrder);
     const validResolveForPending = unsortedResolveSchedules.filter((r) => jeScheduleLocalDataById[r.scheduledJournalEntry.scheduledJournalEntryID] != null);
+    const matchesTypeFilter = (schedule) => selectedJETypeFilter == null ||
+        getJEScheduleRowType(schedule) === selectedJETypeFilter;
+    const isCreatedStatus = (schedule) => {
+        // An accrual is "created" once it is not review work: posted, reversing, reversed, or in a
+        // transient posting claim.
+        if (isOneTimeAccrualRow(schedule)) {
+            return !isPendingReviewRow(schedule);
+        }
+        return (schedule.status.code === 'ongoing' ||
+            schedule.status.code === 'completed' ||
+            schedule.status.code === 'marked_as_completed');
+    };
+    const allScheduleRows = [
+        ...jeScheduledTransaction,
+        ...accruedSchedules,
+        ...oneTimeAccruals,
+    ];
     const pendingReviewSchedules = sortJEScheduledTransactions([
-        ...jeScheduledTransaction.filter((schedule) => schedule.status.code === 'draft'),
+        ...allScheduleRows.filter((schedule) => isPendingReviewRow(schedule) && matchesTypeFilter(schedule)),
         ...validResolveForPending,
     ], sortKey, sortOrder);
+    const createdSchedules = sortJEScheduledTransactions(allScheduleRows.filter((schedule) => isCreatedStatus(schedule) && matchesTypeFilter(schedule)), sortKey, sortOrder);
+    // KPI summary — derived from unfiltered schedules so counts are always accurate
+    const allSchedules = allScheduleRows;
+    const sumAmount = (schedules) => schedules.reduce((total, schedule) => total + (getScheduleAmount(schedule) ?? 0), 0);
+    const pendingReviewTotal = sumAmount(pendingReviewSchedules);
+    const createdTotal = sumAmount(createdSchedules);
+    const aiAccountantSchedules = allSchedules.filter(isAiAccountantSchedule);
+    const manualSchedules = allSchedules.filter((schedule) => !isAiAccountantSchedule(schedule));
+    const pendingUnfiltered = allSchedules.filter((schedule) => isPendingReviewRow(schedule));
+    const kpiSummary = {
+        aiAccountant: {
+            count: aiAccountantSchedules.length,
+            amount: sumAmount(aiAccountantSchedules),
+        },
+        manual: {
+            count: manualSchedules.length,
+            amount: sumAmount(manualSchedules),
+        },
+        needsReview: {
+            count: pendingUnfiltered.length,
+            amount: sumAmount(pendingUnfiltered),
+        },
+        total: {
+            count: allSchedules.length,
+            amount: sumAmount(allSchedules),
+        },
+    };
+    // Each tab's badge counts from that tab's own bucket. A tab that has not been fetched yet
+    // reports undefined rather than 0, so the UI can hide the badge instead of asserting "none".
+    const scheduleCountsByTab = {};
+    ALL_JE_PAGE_TABS.forEach((pageTab) => {
+        const periodTabKey = monthYearPeriodId != null
+            ? getJESchedulePeriodTabKey(pageTab, monthYearPeriodId)
+            : null;
+        const transactionKeys = periodTabKey != null
+            ? jeScheduleTransactionKeysByPeriodAndTab[periodTabKey]
+            : undefined;
+        if (transactionKeys == null) {
+            return;
+        }
+        const accruedKeys = (periodTabKey != null
+            ? jeScheduleAccruedKeysByPeriodAndTab[periodTabKey]
+            : undefined) ?? [];
+        const oneTimeAccrualKeys = (periodTabKey != null
+            ? jeScheduleOneTimeAccrualKeysByPeriodAndTab[periodTabKey]
+            : undefined) ?? [];
+        const rowsForTab = [
+            ...transactionKeys.map((transactionKey) => getJEScheduledTransactionByJEScheduleTransactionKey(transactionKey, state)),
+            ...accruedKeys
+                .map((accruedKey) => getJEAccruedScheduleByJEScheduleKey(accruedKey, state))
+                .filter((accruedRow) => accruedRow != null),
+            ...oneTimeAccrualKeys
+                .map((accrualKey) => getJEOneTimeAccrualByKey(accrualKey, state.jeSchedulesState))
+                .filter((accrualRow) => accrualRow != null && isRenderableOneTimeAccrual(accrualRow)),
+        ];
+        scheduleCountsByTab[pageTab] =
+            pageTab === 'existing_schedules'
+                ? rowsForTab.filter((row) => isExistingTabRow(row)).length
+                : rowsForTab.filter((row) => isPendingReviewRow(row) || isCreatedStatus(row)).length;
+    });
     const allSteps = monthYearPeriodId != null
         ? getAllSteps(monthEndCloseChecksState, monthYearPeriodId, currentTenant.tenantId)
         : [];
@@ -145,6 +373,20 @@ export function getExpenseAutomationJESchedulesView(state) {
         { fetchState, error },
         monthEndFetchState,
     ]);
+    const countByType = (schedules) => {
+        const counts = ALL_SCHEDULES_TYPES.reduce((acc, type) => ({ ...acc, [type]: 0 }), {});
+        schedules.forEach((schedule) => {
+            const scheduleType = getJEScheduleRowType(schedule);
+            if (scheduleType != null) {
+                counts[scheduleType] += 1;
+            }
+        });
+        return counts;
+    };
+    const jeScheduleTypeCounts = {
+        active: countByType(allSchedules.filter((schedule) => isPendingReviewRow(schedule) || isCreatedStatus(schedule))),
+        ongoing: countByType(allSchedules.filter((schedule) => isExistingTabRow(schedule))),
+    };
     return {
         uncategorizedAccounts,
         allDepreciationAccountList: filteredDepAccounts,
@@ -153,14 +395,21 @@ export function getExpenseAutomationJESchedulesView(state) {
         allAccountList: filteredAccounts,
         accountListNestedAccountHierarchy,
         allClassList: allClasses,
-        completedSchedules,
-        draftSchedules,
-        ongoingSchedules,
+        createdSchedules,
+        createdTotal,
+        hasLoadedForSelectedTab,
+        jeScheduleTypeCounts,
+        scheduleCountsByTab,
+        kpiSummary,
         pendingReviewSchedules,
+        pendingReviewTotal,
         resolveSchedules: resolveSchedules,
         accountSettingsView,
+        newScheduleView,
         postStatusById: postStatusById,
         ignoreStatusById: ignoreStatusById,
+        revertStatusById: revertStatusById,
+        oneTimeAccrualActionStatusById: oneTimeAccrualActionStatusById,
         fetchState: reducedFetchStatus.fetchState,
         jeScheduleLocalDataById: jeScheduleLocalDataById,
         uiState: uiState,
@@ -169,3 +418,26 @@ export function getExpenseAutomationJESchedulesView(state) {
         completionStatus,
     };
 }
+/**
+ * One accrual plus the status of its promote / ignore request, for the detail screen.
+ *
+ * `accrual` is undefined on a cold load — a refresh or a shared link, where the list has never run
+ * — so the screen dispatches `fetchOneTimeAccrual` and waits on `detailFetchState`. The two states
+ * are separate on purpose: `actionFetchState` drives the row spinner and the post-revert navigation,
+ * and a page load must not look like an action that just finished.
+ */
+export function getExpenseAutomationJEOneTimeAccrualDetailView(state, accrualId) {
+    return {
+        accrual: getJEOneTimeAccrualByKey(generateJEOneTimeAccrualKey(accrualId), state.jeSchedulesState),
+        actionFetchState: state.expenseAutomationJESchedulesViewState
+            .oneTimeAccrualActionStatusById[accrualId] ?? {
+            fetchState: 'Not-Started',
+            error: undefined,
+        },
+        detailFetchState: state.expenseAutomationJESchedulesViewState
+            .oneTimeAccrualFetchStatusById[accrualId] ?? {
+            fetchState: 'Not-Started',
+            error: undefined,
+        },
+    };
+}

package/lib/esm/view/expenseAutomationView/types/jeSchedulesViewState.js

@@ -16,9 +16,8 @@ const JE_SCHEDULE_SORT_KEYS = [
     'memo',
 ];
 export const toJEScheduleSortKey = (v) => stringToUnion(v, JE_SCHEDULE_SORT_KEYS);
-const JE_SCHEDULE_MAIN_TABS = [
-    'pending_review',
-    'ongoing',
-    'completed',
-];
-export const toJEScheduleMainTab = (v) => stringToUnion(v, JE_SCHEDULE_MAIN_TABS);
+const JE_PAGE_TABS = ['schedules', 'existing_schedules'];
+export const toJEPageTab = (v) => stringToUnion(v, JE_PAGE_TABS);
+export const ALL_JE_PAGE_TABS = JE_PAGE_TABS;
+export const getJESchedulePeriodTabKey = (selectedPageTab, monthYearPeriodId) => `${selectedPageTab}_${monthYearPeriodId}`;
+export const MIN_NEW_SCHEDULE_SEARCH_LENGTH = 2;

package/lib/esm/view/invoicing/editInvoicingCatalogItemDetailView/editInvoicingCatalogItemDetailViewPayload.js

@@ -1,5 +1,3 @@
-import { toAccountPayload } from '../../../entity/account/accountPayload';
-import { toClassBasePayload } from '../../../entity/class/classPayload';
 import { blankInvoicingCatalogSubFamily, isTieredCatalogPricingModel, } from './invoicingCatalogItemFormConfig';
 const CURRENCY_CODE = 'USD';
 const trimOrUndefined = (value) => value.trim() !== '' ? value.trim() : undefined;
@@ -9,26 +7,20 @@ const toProductCode = (value) => value
     .toLowerCase()
     .replace(/[^a-z0-9]+/g, '-')
     .replace(/^-|-$/g, '');
-const buildAccountingDetail = (subFamily, lookup) => {
+const buildAccountingDetail = (subFamily) => {
     const detail = {};
     if (subFamily.sku.trim() !== '') {
         detail.sku = subFamily.sku.trim();
     }
-    // The account and class travel as whole objects rather than bare codes, built
-    // by the same helpers the transaction and vendor payloads use. An id that no
-    // longer resolves is dropped: sending a code the service cannot expand is how
-    // a mapping silently lands on the wrong account.
-    const account = lookup.accountByQboId(subFamily.accountingCode.trim());
-    if (account != null) {
-        detail.account = toAccountPayload(account);
+    if (subFamily.accountingCode.trim() !== '') {
+        detail.accounting_code = subFamily.accountingCode.trim();
     }
-    const accountingClass = lookup.classByQboId(subFamily.accountingCategory.trim());
-    if (accountingClass != null) {
-        detail.accounting_class = toClassBasePayload(accountingClass);
+    if (subFamily.accountingCategory.trim() !== '') {
+        detail.accounting_category_1 = subFamily.accountingCategory.trim();
     }
     return Object.keys(detail).length > 0 ? detail : undefined;
 };
-const buildSubFamilyPayload = (localData, subFamily, clearEmptyValues, lookup) => {
+const buildSubFamilyPayload = (localData, subFamily, clearEmptyValues) => {
     const isAddon = localData.catalogType === 'addon';
     const tiered = isTieredCatalogPricingModel(subFamily.pricingModel);
     const name = subFamily.name.trim();
@@ -82,7 +74,7 @@ const buildSubFamilyPayload = (localData, subFamily, clearEmptyValues, lookup) =
             starting_unit: Number(tier.startingUnit) || 1,
         }));
     }
-    const accountingDetail = buildAccountingDetail(subFamily, lookup);
+    const accountingDetail = buildAccountingDetail(subFamily);
     if (accountingDetail != null) {
         payload.accounting_detail = accountingDetail;
     }
@@ -94,7 +86,7 @@ const DEFAULT_CATALOG_ITEM_UNIT = 'USD';
  * Build the parent catalog-item request body from the form draft. Creates omit
  * both parent and sub-family IDs; edits retain returned sub-family IDs.
  */
-export const localDataToSaveInvoicingCatalogItemPayload = (localData, isCreate, lookup) => {
+export const localDataToSaveInvoicingCatalogItemPayload = (localData, isCreate) => {
     const description = trimOrUndefined(localData.description);
     const productCode = trimOrUndefined(localData.productCode) ?? toProductCode(localData.name);
     const itemPayload = {
@@ -122,7 +114,7 @@ export const localDataToSaveInvoicingCatalogItemPayload = (localData, isCreate,
         ? localData.subFamilies
         : [blankInvoicingCatalogSubFamily()];
     itemPayload.sub_family_details = isCreate
-        ? subFamilies.map((subFamily) => buildSubFamilyPayload(localData, subFamily, false, lookup))
+        ? subFamilies.map((subFamily) => buildSubFamilyPayload(localData, subFamily, false))
         : subFamilies.map((subFamily) => {
             const priceCode = trimOrUndefined(subFamily.priceCode) ?? toProductCode(subFamily.name);
             const detail = {
@@ -132,14 +124,6 @@ export const localDataToSaveInvoicingCatalogItemPayload = (localData, isCreate,
                 price_code: priceCode,
                 show_description_in_invoices: subFamily.showDescriptionInInvoices,
             };
-            // Edits send a narrower body than creates, but the accounting mapping
-            // is editable on this form, so leaving it out dropped the account and
-            // class the user had just picked. `null` rather than omitted when it is
-            // empty: an absent key on an update reads as "leave it alone", which
-            // would make a cleared mapping impossible to save — the same reason
-            // `description` and `invoice_notes` go through `trimOrNull`.
-            detail.accounting_detail =
-                buildAccountingDetail(subFamily, lookup) ?? null;
             const id = trimOrUndefined(subFamily.id);
             return id != null ? { ...detail, id } : detail;
         });

package/lib/esm/view/invoicing/editInvoicingCatalogItemDetailView/saveInvoicingCatalogItemEpic.js

@@ -6,7 +6,6 @@ import { apiErrorSnackbarVariables } from '../../../entity/snackbar/snackbarApiE
 import { openSnackbar } from '../../../entity/snackbar/snackbarReducer';
 import { createZeniAPIStatus, isSuccessResponse } from '../../../responsePayload';
 import { addInvoicingCatalogItem } from '../invoicingCatalogListView/invoicingCatalogListViewReducer';
-import { invoicingQboAccountByQboId, invoicingQboClassByQboId, } from '../invoicingQboView/invoicingQboViewSelector';
 import { localDataToSaveInvoicingCatalogItemPayload, } from './editInvoicingCatalogItemDetailViewPayload';
 import { saveInvoicingCatalogItem, submitInvoicingCatalogItemForm, submitInvoicingCatalogItemFormFailure, submitInvoicingCatalogItemFormSuccess, } from './editInvoicingCatalogItemDetailViewReducer';
 export const saveInvoicingCatalogItemEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter((action) => submitInvoicingCatalogItemForm.match(action) ||
@@ -21,11 +20,7 @@ export const saveInvoicingCatalogItemEpic = (actions$, state$, zeniAPI) => actio
         const viewState = state$.value.editInvoicingCatalogItemDetailViewState;
         const localData = (id != null ? viewState.editDraftById[id] : viewState.newItemDraft) ??
             viewState.newItemDraft;
-        const state = state$.value;
-        data = localDataToSaveInvoicingCatalogItemPayload(localData, id == null, {
-            accountByQboId: (qboId) => invoicingQboAccountByQboId(state, qboId),
-            classByQboId: (qboId) => invoicingQboClassByQboId(state, qboId),
-        });
+        data = localDataToSaveInvoicingCatalogItemPayload(localData, id == null);
     }
     const baseUrl = `${zeniAPI.apiEndPoints.invoicingMicroServiceBaseUrl}/1.0`;
     const path = id != null

package/lib/esm/view/invoicing/invoicingQboView/invoicingQboViewSelector.js

@@ -37,46 +37,6 @@ export const INVOICING_INCOME_ACCOUNT_TYPES = [
     'income',
     'other_income',
 ];
-/**
- * The account behind a picker value. The pickers submit the QuickBooks id, so
- * that is what callers hold; the payload builders need the whole entity to send
- * `toAccountPayload`, which is why the lookup lives here next to the options.
- */
-export const invoicingQboAccountByQboId = (state, qboId) => {
-    if (qboId == null || qboId === '') {
-        return undefined;
-    }
-    // `getAccountList` throws when a listed id is missing from the entity slice.
-    // That is survivable when looking one account up — the caller falls back to
-    // the id it already had — but not when it happens inside an epic, where the
-    // throw would take the whole request with it.
-    try {
-        const { accounts } = getAccountList(state.accountState, state.accountListState, INVOICING_ACCOUNT_LIST_KEY);
-        // Matched on any id the account is known by. The pickers submit `qboId`,
-        // but a mapping that arrived from the service can name the account by its
-        // platform id instead, and an account we cannot resolve is a mapping that
-        // cannot be sent as a record.
-        return accounts.find((account) => account.qboId === qboId ||
-            account.accountId === qboId ||
-            account.coaId === qboId);
-    }
-    catch {
-        return undefined;
-    }
-};
-/** The class behind a picker value, for the same reason as the account above. */
-export const invoicingQboClassByQboId = (state, qboId) => {
-    if (qboId == null || qboId === '') {
-        return undefined;
-    }
-    try {
-        const { classes } = getClassList(state.classState, state.classListState);
-        return classes.find((accountingClass) => accountingClass.qboId === qboId);
-    }
-    catch {
-        return undefined;
-    }
-};
 /**
  * Accounts and classes as the invoicing pickers need them. Both come from the
  * shared accounting-service lists, so whatever another screen already loaded