@zeniai/client-epic-state 5.1.92-betaRD5 → 5.1.92-betaRD7

package/lib/esm/view/expenseAutomationView/epics/jeSchedule/revertJeScheduleEpic.js

@@ -1,6 +1,5 @@
 import { from } from 'rxjs';
 import { catchError, filter, mergeMap } from 'rxjs/operators';
-import { updateJESchedules, updateJESchedulesDetails, } from '../../../../entity/jeSchedules/jeSchedulesReducer';
 import { openSnackbar } from '../../../../entity/snackbar/snackbarReducer';
 import { getCurrentTenant } from '../../../../entity/tenant/tenantSelector';
 import { createZeniAPIStatus, isSuccessResponse, } from '../../../../responsePayload';
@@ -32,9 +31,14 @@ export const revertJeScheduleEpic = (actions$, state$, zeniAPI) => actions$.pipe
         .putAndGetJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/schedules/${jeScheduleId}/revert`, payload)
         .pipe(mergeMap((response) => {
         if (isSuccessResponse(response) && response.data != null) {
+            // Deliberately not written to the entity store. A reverted schedule is soft-deleted,
+            // so the endpoint returns its flat entity json -- `vendor_id` as a bare field, no
+            // nested `vendor` or `base_transaction` -- rather than the list DTO those mappers
+            // expect. Feeding it to updateJESchedules threw inside doUpdateVendors on
+            // `payload.vendor.vendor_id`, and because that happens mid-dispatch it killed the
+            // rest of this array: the row kept spinning and no snackbar appeared. The row is
+            // removed from the list below regardless, so there is nothing worth storing.
             return from([
-                updateJESchedules(response.data.je_schedules),
-                updateJESchedulesDetails(response.data.je_schedules, response.data.scheduled_journal_entries),
                 revertJeScheduleSuccess({ jeScheduleTransactionKey }),
                 removeJeScheduleTransactionKey(jeScheduleTransactionKey, selectedPeriod),
                 fetchMonthEndCloseChecks({

package/lib/esm/view/expenseAutomationView/selectors/jeSchedulesViewSelector.js

@@ -194,7 +194,7 @@ export function getExpenseAutomationJESchedulesView(state) {
     const accruedSchedules = [];
     const oneTimeAccruals = [];
     const { accountState, accountListState, classState, classListState, expenseAutomationJESchedulesViewState, expenseAutomationViewState, monthEndCloseChecksState, monthEndCloseChecksViewState, } = state;
-    const { jeScheduleTransactionKeysByPeriodAndTab, jeScheduleAccruedKeysByPeriodAndTab, jeScheduleOneTimeAccrualKeysByPeriodAndTab, failedJeScheduleTransactionKeysByPeriodAndTab, jeScheduleLocalDataById, postStatusById, ignoreStatusById, uiState, error, fetchState, refreshStatus, newSchedule, } = expenseAutomationJESchedulesViewState;
+    const { jeScheduleTransactionKeysByPeriodAndTab, jeScheduleAccruedKeysByPeriodAndTab, jeScheduleOneTimeAccrualKeysByPeriodAndTab, failedJeScheduleTransactionKeysByPeriodAndTab, jeScheduleLocalDataById, postStatusById, ignoreStatusById, revertStatusById, uiState, error, fetchState, refreshStatus, newSchedule, } = expenseAutomationJESchedulesViewState;
     const accountSettingsView = getJEAccountSettingsView(state);
     const newScheduleView = newSchedule.selectedDetailScheduleType === 'fixed_assets' ||
         newSchedule.selectedDetailScheduleType === 'prepaid_expenses'
@@ -408,6 +408,7 @@ export function getExpenseAutomationJESchedulesView(state) {
         newScheduleView,
         postStatusById: postStatusById,
         ignoreStatusById: ignoreStatusById,
+        revertStatusById: revertStatusById,
         fetchState: reducedFetchStatus.fetchState,
         jeScheduleLocalDataById: jeScheduleLocalDataById,
         uiState: uiState,

package/lib/view/expenseAutomationView/epics/jeSchedule/revertJeScheduleEpic.d.ts

@@ -26,11 +26,6 @@ export declare const revertJeScheduleEpic: (actions$: ActionsObservable<ActionTy
         }[];
     };
     type: "snackbar/openSnackbar";
-} | {
-    payload: {
-        jeSchedulesTransactionsPayload: import("../../../../entity/jeSchedules/jeSchedulesPayload").JEScheduledTransactionPayload[];
-    };
-    type: "jeSchedules/updateJESchedules";
 } | {
     payload: {
         period: import("../../../..").MonthYearPeriod;
@@ -38,13 +33,6 @@ export declare const revertJeScheduleEpic: (actions$: ActionsObservable<ActionTy
         tenantId: import("../../../..").ID;
     };
     type: "monthEndCloseChecksView/fetchMonthEndCloseChecks";
-} | {
-    payload: {
-        jeSchedulesPayload: import("../../../../entity/jeSchedules/jeSchedulesPayload").JEScheduledTransactionPayload[];
-        scheduledJEntriesPayload: import("../../../../entity/jeSchedules/jeSchedulesPayload").ScheduledJournalEntryPayload[] | undefined;
-        updateType: import("../../../..").UpdateType;
-    };
-    type: "jeSchedules/updateJESchedulesDetails";
 } | {
     payload: {
         jeScheduleKey: `${string}_expense_${string}` | `${string}_check_${string}` | `${string}_refund_${string}` | `${string}_invoice_${string}` | `${string}_payment_${string}` | `${string}_credit_memo_${string}` | `${string}_sales_receipt_${string}` | `${string}_delayed_credit_${string}` | `${string}_delayed_charge_${string}` | `${string}_bill_${string}` | `${string}_bill_payment_${string}` | `${string}_bill_payment_check_${string}` | `${string}_bill_payment_credit_card_${string}` | `${string}_vendor_credit_${string}` | `${string}_credit_card_credit_${string}` | `${string}_transfer_${string}` | `${string}_credit_card_payment_${string}` | `${string}_deposit_${string}` | `${string}_journal_entry_${string}`;

package/lib/view/expenseAutomationView/epics/jeSchedule/revertJeScheduleEpic.js

@@ -3,7 +3,6 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.revertJeScheduleEpic = void 0;
 const rxjs_1 = require("rxjs");
 const operators_1 = require("rxjs/operators");
-const jeSchedulesReducer_1 = require("../../../../entity/jeSchedules/jeSchedulesReducer");
 const snackbarReducer_1 = require("../../../../entity/snackbar/snackbarReducer");
 const tenantSelector_1 = require("../../../../entity/tenant/tenantSelector");
 const responsePayload_1 = require("../../../../responsePayload");
@@ -35,9 +34,14 @@ const revertJeScheduleEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, op
         .putAndGetJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/schedules/${jeScheduleId}/revert`, payload)
         .pipe((0, operators_1.mergeMap)((response) => {
         if ((0, responsePayload_1.isSuccessResponse)(response) && response.data != null) {
+            // Deliberately not written to the entity store. A reverted schedule is soft-deleted,
+            // so the endpoint returns its flat entity json -- `vendor_id` as a bare field, no
+            // nested `vendor` or `base_transaction` -- rather than the list DTO those mappers
+            // expect. Feeding it to updateJESchedules threw inside doUpdateVendors on
+            // `payload.vendor.vendor_id`, and because that happens mid-dispatch it killed the
+            // rest of this array: the row kept spinning and no snackbar appeared. The row is
+            // removed from the list below regardless, so there is nothing worth storing.
             return (0, rxjs_1.from)([
-                (0, jeSchedulesReducer_1.updateJESchedules)(response.data.je_schedules),
-                (0, jeSchedulesReducer_1.updateJESchedulesDetails)(response.data.je_schedules, response.data.scheduled_journal_entries),
                 (0, jeSchedulesViewReducer_1.revertJeScheduleSuccess)({ jeScheduleTransactionKey }),
                 (0, jeSchedulesViewReducer_1.removeJeScheduleTransactionKey)(jeScheduleTransactionKey, selectedPeriod),
                 (0, monthEndCloseChecksViewReducer_1.fetchMonthEndCloseChecks)({

package/lib/view/expenseAutomationView/selectorTypes/jeSchedulesSelectorTypes.d.ts

@@ -53,6 +53,7 @@ export interface ExpenseAutomationJESchedulesViewSelector extends SelectorView {
     postStatusById: Record<ID, FetchStateAndError>;
     refreshStatus: FetchStateAndError;
     resolveSchedules: JEScheduledTransactionWithFailedEntries[];
+    revertStatusById: Record<JEScheduleTransactionKey, FetchStateAndError>;
     scheduleCountsByTab: Partial<Record<JEPageTab, number>>;
     uiState: JESchedulesViewUIState;
     uncategorizedAccounts: UncategorizedAccounts;

package/lib/view/expenseAutomationView/selectors/jeSchedulesViewSelector.js

@@ -209,7 +209,7 @@ function getExpenseAutomationJESchedulesView(state) {
     const accruedSchedules = [];
     const oneTimeAccruals = [];
     const { accountState, accountListState, classState, classListState, expenseAutomationJESchedulesViewState, expenseAutomationViewState, monthEndCloseChecksState, monthEndCloseChecksViewState, } = state;
-    const { jeScheduleTransactionKeysByPeriodAndTab, jeScheduleAccruedKeysByPeriodAndTab, jeScheduleOneTimeAccrualKeysByPeriodAndTab, failedJeScheduleTransactionKeysByPeriodAndTab, jeScheduleLocalDataById, postStatusById, ignoreStatusById, uiState, error, fetchState, refreshStatus, newSchedule, } = expenseAutomationJESchedulesViewState;
+    const { jeScheduleTransactionKeysByPeriodAndTab, jeScheduleAccruedKeysByPeriodAndTab, jeScheduleOneTimeAccrualKeysByPeriodAndTab, failedJeScheduleTransactionKeysByPeriodAndTab, jeScheduleLocalDataById, postStatusById, ignoreStatusById, revertStatusById, uiState, error, fetchState, refreshStatus, newSchedule, } = expenseAutomationJESchedulesViewState;
     const accountSettingsView = (0, jeAccountSettingsViewSelector_1.getJEAccountSettingsView)(state);
     const newScheduleView = newSchedule.selectedDetailScheduleType === 'fixed_assets' ||
         newSchedule.selectedDetailScheduleType === 'prepaid_expenses'
@@ -423,6 +423,7 @@ function getExpenseAutomationJESchedulesView(state) {
         newScheduleView,
         postStatusById: postStatusById,
         ignoreStatusById: ignoreStatusById,
+        revertStatusById: revertStatusById,
         fetchState: reducedFetchStatus.fetchState,
         jeScheduleLocalDataById: jeScheduleLocalDataById,
         uiState: uiState,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.1.92-betaRD5",
+  "version": "5.1.92-betaRD7",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",