@zeniai/client-epic-state 5.1.88-betaRD5 → 5.1.88-betaRD7

package/lib/esm/index.js

@@ -853,4 +853,4 @@ export { acceptInvoicingTerms, clearInvoicingConfig, enableInvoicing, fetchInvoi
 export { getInvoicingConfigView } from './view/invoicing/invoicingConfigView/invoicingConfigViewSelector';
 // Accrued JE schedules are not a discriminated union member, so consumers need this guard to
 // narrow a JEScheduleRow before reading baseTransaction / recurringAmount.
-export { getExpenseAutomationJEOneTimeAccrualDetailView, getJEScheduleRowType, isAccruedScheduleRow, isAiAccountantSchedule, isExistingTabRow, isOneTimeAccrualRow, isPendingReviewRow, } from './view/expenseAutomationView/selectors/jeSchedulesViewSelector';
+export { getExpenseAutomationJEOneTimeAccrualDetailView, getJEScheduleRowType, isAccruedScheduleRow, isAiAccountantSchedule, isExistingTabRow, isOneTimeAccrualRow, isRenderableOneTimeAccrual, isPendingReviewRow, } from './view/expenseAutomationView/selectors/jeSchedulesViewSelector';

package/lib/esm/view/expenseAutomationView/epics/jeSchedule/fetchJeSchedulesEpic.js

@@ -1,10 +1,11 @@
 import { from, of } from 'rxjs';
-import { catchError, filter, mergeMap } from 'rxjs/operators';
+import { catchError, filter, mergeMap, takeUntil } from 'rxjs/operators';
 import { DEFAULT_DATE_FORMAT } from '../../../../commonStateTypes/fiscalYearHelpers/formatZeniDateFY';
 import { toAbsoluteDay, toString } from '../../../../commonStateTypes/timePeriod';
 import { updateAccruedJESchedules, updateAccruedJESchedulesDetails, updateJEOneTimeAccruals, updateJESchedules, updateJESchedulesDetails, } from '../../../../entity/jeSchedules/jeSchedulesReducer';
 import { getCurrentTenant } from '../../../../entity/tenant/tenantSelector';
 import { createZeniAPIStatus, isSuccessResponse, } from '../../../../responsePayload';
+import { clearAll } from '../../../../rootActions';
 import { date } from '../../../../zeniDayJS';
 import { fetchJeSchedules, fetchJeSchedulesFailure, fetchJeSchedulesSuccess, initializeJeScheduleLocalData, } from '../../reducers/jeSchedulesViewReducer';
 export const fetchJeSchedulesEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(fetchJeSchedules.match), mergeMap((action) => {
@@ -77,5 +78,9 @@ export const fetchJeSchedulesEpic = (actions$, state$, zeniAPI) => actions$.pipe
             JSON.stringify(error)),
         selectedPeriod,
         selectedPageTab,
-    }))));
+    }))), 
+    // A tenant switch clears the store while this request is still in flight. Without this
+    // the old tenant's rows are written back into the freshly cleared store and stay on
+    // screen under the new tenant until a manual refresh.
+    takeUntil(actions$.pipe(filter(clearAll.match))));
 }));

package/lib/esm/view/expenseAutomationView/selectors/jeSchedulesViewSelector.js

@@ -25,13 +25,21 @@ const BOT_EMAIL = 'bot@zeni.ai';
 // A one-time accrual has no jeScheduleType of its own — it is not a JE schedule. It is still an
 // accrued expense, so it counts and filters under that type on the page's type tabs.
 const ONE_TIME_ACCRUAL_SCHEDULE_TYPE = 'accrued_expenses';
-// Which of the two list buckets an accrual belongs in. `draft` still needs a human to post it and
-// `posting_blocked` needs attention, so both are review work; everything else is already on the
-// books or in a transient claim.
+// Which of the two list buckets an accrual belongs in. `draft` still needs a human to post it;
+// everything else is already on the books or in a transient claim.
 const ONE_TIME_ACCRUAL_REVIEW_STATUSES = [
     'draft',
-    'posting_blocked',
 ];
+/**
+ * `posting_blocked` is written by the posting Cron when a JE fails to post. It is an internal
+ * failure state with no human action attached, so it is dropped here rather than hidden at render
+ * time — filtering in the view would leave the group counts and KPI totals counting rows nobody
+ * can see. The expense-automation endpoint applies no status filter on the close-period path, so
+ * these rows do arrive.
+ */
+export function isRenderableOneTimeAccrual(accrual) {
+    return accrual.accrualStatus !== 'posting_blocked';
+}
 export function getJEScheduleRowType(schedule) {
     return isOneTimeAccrualRow(schedule)
         ? ONE_TIME_ACCRUAL_SCHEDULE_TYPE
@@ -242,7 +250,7 @@ export function getExpenseAutomationJESchedulesView(state) {
         : undefined) ?? [];
     jeScheduleOneTimeAccrualKeys.forEach((jeOneTimeAccrualKey) => {
         const accrual = getJEOneTimeAccrualByKey(jeOneTimeAccrualKey, state.jeSchedulesState);
-        if (accrual != null) {
+        if (accrual != null && isRenderableOneTimeAccrual(accrual)) {
             oneTimeAccruals.push(accrual);
         }
     });
@@ -346,7 +354,7 @@ export function getExpenseAutomationJESchedulesView(state) {
                 .filter((accruedRow) => accruedRow != null),
             ...oneTimeAccrualKeys
                 .map((accrualKey) => getJEOneTimeAccrualByKey(accrualKey, state.jeSchedulesState))
-                .filter((accrualRow) => accrualRow != null),
+                .filter((accrualRow) => accrualRow != null && isRenderableOneTimeAccrual(accrualRow)),
         ];
         scheduleCountsByTab[pageTab] =
             pageTab === 'existing_schedules'

package/lib/index.d.ts

@@ -1227,4 +1227,4 @@ export { acceptInvoicingTerms, clearInvoicingConfig, enableInvoicing, fetchInvoi
 export { getInvoicingConfigView } from './view/invoicing/invoicingConfigView/invoicingConfigViewSelector';
 export type { InvoicingConfigView } from './view/invoicing/invoicingConfigView/invoicingConfigViewSelector';
 export type { InvoicingOnboardingStatus } from './view/invoicing/invoicingConfigView/invoicingConfigViewPayload';
-export { getExpenseAutomationJEOneTimeAccrualDetailView, getJEScheduleRowType, isAccruedScheduleRow, isAiAccountantSchedule, isExistingTabRow, isOneTimeAccrualRow, isPendingReviewRow, } from './view/expenseAutomationView/selectors/jeSchedulesViewSelector';
+export { getExpenseAutomationJEOneTimeAccrualDetailView, getJEScheduleRowType, isAccruedScheduleRow, isAiAccountantSchedule, isExistingTabRow, isOneTimeAccrualRow, isRenderableOneTimeAccrual, isPendingReviewRow, } from './view/expenseAutomationView/selectors/jeSchedulesViewSelector';

package/lib/index.js

@@ -85,7 +85,7 @@ exports.ALL_INVOICING_SUBSCRIPTION_SORT_KEYS = exports.updateInvoicingSubscripti
 exports.fetchInvoicingCouponListPage = exports.fetchInvoicingCouponList = exports.fetchInvoicingCouponCounts = exports.clearInvoicingCouponView = exports.updateInvoicingCoupons = exports.removeInvoicingCoupon = exports.clearAllInvoicingCoupons = exports.getInvoicingCreditNoteDetail = exports.getInvoicingCreditNoteById = exports.fetchInvoicingCreditNoteDetail = exports.clearInvoicingCreditNoteDetailView = exports.getInvoicingCreditNoteListView = exports.INVOICING_CREDIT_NOTE_TABS = exports.INVOICING_CREDIT_NOTE_COLUMNS = exports.ALL_INVOICING_CREDIT_NOTE_TAB_IDS = exports.ALL_INVOICING_CREDIT_NOTE_SORT_KEYS = exports.updateInvoicingCreditNoteFilters = exports.setInvoicingCreditNoteActiveTab = exports.fetchInvoicingCreditNoteListPage = exports.fetchInvoicingCreditNoteList = exports.fetchInvoicingCreditNoteCounts = exports.clearInvoicingCreditNoteListView = exports.updateInvoicingCreditNotes = exports.removeInvoicingCreditNote = exports.clearAllInvoicingCreditNotes = exports.getInvoicingTransactionDetail = exports.getInvoicingTransactionById = exports.fetchInvoicingTransactionDetail = exports.clearInvoicingTransactionDetailView = exports.getInvoicingTransactionListView = exports.INVOICING_TRANSACTION_TABS = exports.INVOICING_TRANSACTION_COLUMNS = exports.ALL_INVOICING_TRANSACTION_TAB_IDS = exports.ALL_INVOICING_TRANSACTION_SORT_KEYS = exports.updateInvoicingTransactionFilters = exports.setInvoicingTransactionActiveTab = exports.fetchInvoicingTransactionListPage = exports.fetchInvoicingTransactionList = exports.clearInvoicingTransactionListView = exports.updateInvoicingTransactions = exports.removeInvoicingTransaction = exports.clearAllInvoicingTransactions = exports.getInvoicingSubscriptionDetail = exports.getInvoicingSubscriptionById = exports.fetchInvoicingSubscriptionDetail = exports.clearInvoicingSubscriptionDetailView = exports.getInvoicingSubscriptionListView = exports.INVOICING_SUBSCRIPTION_TABS = exports.INVOICING_SUBSCRIPTION_COLUMNS = exports.ALL_INVOICING_SUBSCRIPTION_TAB_IDS = void 0;
 exports.fetchInvoicingCatalogProductList = exports.fetchInvoicingCatalogPlanList = exports.fetchInvoicingCatalogListPage = exports.fetchInvoicingCatalogCounts = exports.clearInvoicingCatalogListView = exports.updateInvoicingProducts = exports.removeInvoicingProduct = exports.clearAllInvoicingProducts = exports.updateInvoicingPlans = exports.removeInvoicingPlan = exports.mergeInvoicingPlanSubFamily = exports.clearAllInvoicingPlans = exports.getInvoicingDunningEmailPreview = exports.getInvoicingDunningCaseDetail = exports.getInvoicingDunningCaseById = exports.invalidateInvoicingDunningEmailPreview = exports.fetchInvoicingDunningEmailPreviewPage = exports.fetchInvoicingDunningCaseDetail = exports.clearInvoicingDunningCaseDetailView = exports.getInvoicingDunningCaseListView = exports.INVOICING_DUNNING_CASE_TABS = exports.INVOICING_DUNNING_CASE_COLUMNS = exports.ALL_INVOICING_DUNNING_CASE_TAB_IDS = exports.ALL_INVOICING_DUNNING_CASE_SORT_KEYS = exports.updateInvoicingDunningCaseFilters = exports.setInvoicingDunningCaseActiveTab = exports.fetchInvoicingDunningCaseListPage = exports.fetchInvoicingDunningCaseList = exports.fetchInvoicingDunningCaseCounts = exports.clearInvoicingDunningCaseListView = exports.updateInvoicingDunningCases = exports.removeInvoicingDunningCase = exports.clearAllInvoicingDunningCases = exports.getInvoicingCouponDetail = exports.fetchInvoicingCouponDetail = exports.clearInvoicingCouponDetailView = exports.getInvoicingCouponById = exports.getInvoicingCouponListView = exports.getInvoicingCouponListNextCursor = exports.getInvoicingCouponListItems = exports.getInvoicingCouponListHasMore = exports.getInvoicingCouponListFilters = exports.getInvoicingCouponListFetchState = exports.getInvoicingCouponCounts = exports.INVOICING_COUPON_TABS = exports.INVOICING_COUPON_COLUMNS = exports.ALL_INVOICING_COUPON_TAB_IDS = exports.ALL_INVOICING_COUPON_SORT_KEYS = exports.updateInvoicingCouponFilters = exports.setInvoicingCouponActiveTab = void 0;
 exports.isAccruedScheduleRow = exports.getJEScheduleRowType = exports.getExpenseAutomationJEOneTimeAccrualDetailView = exports.getInvoicingConfigView = exports.updateInvoicingConfig = exports.resetInvoicingConfigActionStates = exports.fetchInvoicingConfig = exports.enableInvoicing = exports.clearInvoicingConfig = exports.acceptInvoicingTerms = exports.withInvoicingQboAccountMappingId = exports.toInvoicingQboCustomerMatchingMode = exports.getInvoicingQboAccountMappingId = exports.INVOICING_QBO_CUSTOMER_MATCHING_MODES = exports.getInvoicingQboView = exports.startInvoicingQboBackfill = exports.retryInvoicingQboSyncTask = exports.fetchInvoicingQboSyncHealth = exports.fetchInvoicingQboConnection = exports.fetchInvoicingQboClasses = exports.fetchInvoicingQboAccounts = exports.clearInvoicingQboView = exports.isStripeConnectedFromSettings = exports.initialInvoicingBrandingFormLocalData = exports.entityToInvoicingBrandingFormLocalData = exports.INVOICING_BUSINESS_ADDRESS_TYPE = exports.getInvoicingSettingsView = exports.getInvoicingSettingsFetchState = exports.getInvoicingSettings = exports.getInvoicingBrandingFormView = exports.updateInvoicingSettings = exports.updateInvoicingBrandingFormDraft = exports.submitInvoicingBrandingForm = exports.saveInvoicingSettings = exports.resetSaveInvoicingSettings = exports.resetInvoicingBrandingFormDraft = exports.fetchInvoicingSettings = exports.disconnectInvoicingStripe = exports.connectInvoicingStripe = exports.clearInvoicingSettings = exports.getInvoicingProductById = exports.getInvoicingPlanById = exports.getInvoicingCatalogItemDetail = exports.fetchInvoicingCatalogItemDetail = exports.clearInvoicingCatalogItemDetailView = exports.getInvoicingCatalogListView = exports.INVOICING_PRODUCT_COLUMNS = exports.ALL_INVOICING_PRODUCT_SORT_KEYS = exports.updateInvoicingCatalogProductFilters = exports.updateInvoicingCatalogPlanFilters = void 0;
-exports.isPendingReviewRow = exports.isOneTimeAccrualRow = exports.isExistingTabRow = exports.isAiAccountantSchedule = void 0;
+exports.isPendingReviewRow = exports.isRenderableOneTimeAccrual = exports.isOneTimeAccrualRow = exports.isExistingTabRow = exports.isAiAccountantSchedule = void 0;
 const allowedValue_1 = require("./commonStateTypes/allowedValue");
 Object.defineProperty(exports, "isAllowedValueWithCode", { enumerable: true, get: function () { return allowedValue_1.isAllowedValueWithCode; } });
 Object.defineProperty(exports, "isAllowedValueWithID", { enumerable: true, get: function () { return allowedValue_1.isAllowedValueWithID; } });
@@ -3197,4 +3197,5 @@ Object.defineProperty(exports, "isAccruedScheduleRow", { enumerable: true, get:
 Object.defineProperty(exports, "isAiAccountantSchedule", { enumerable: true, get: function () { return jeSchedulesViewSelector_1.isAiAccountantSchedule; } });
 Object.defineProperty(exports, "isExistingTabRow", { enumerable: true, get: function () { return jeSchedulesViewSelector_1.isExistingTabRow; } });
 Object.defineProperty(exports, "isOneTimeAccrualRow", { enumerable: true, get: function () { return jeSchedulesViewSelector_1.isOneTimeAccrualRow; } });
+Object.defineProperty(exports, "isRenderableOneTimeAccrual", { enumerable: true, get: function () { return jeSchedulesViewSelector_1.isRenderableOneTimeAccrual; } });
 Object.defineProperty(exports, "isPendingReviewRow", { enumerable: true, get: function () { return jeSchedulesViewSelector_1.isPendingReviewRow; } });

package/lib/view/expenseAutomationView/epics/jeSchedule/fetchJeSchedulesEpic.d.ts

@@ -2,7 +2,8 @@ import { ActionsObservable, StateObservable } from 'redux-observable';
 import { Observable } from 'rxjs';
 import { updateAccruedJESchedules, updateAccruedJESchedulesDetails, updateJEOneTimeAccruals, updateJESchedules, updateJESchedulesDetails } from '../../../../entity/jeSchedules/jeSchedulesReducer';
 import { RootState } from '../../../../reducer';
+import { clearAll } from '../../../../rootActions';
 import { ZeniAPI } from '../../../../zeniAPI';
 import { fetchJeSchedules, fetchJeSchedulesFailure, fetchJeSchedulesSuccess, initializeJeScheduleLocalData } from '../../reducers/jeSchedulesViewReducer';
-export type ActionType = ReturnType<typeof fetchJeSchedules> | ReturnType<typeof fetchJeSchedulesFailure> | ReturnType<typeof fetchJeSchedulesSuccess> | ReturnType<typeof initializeJeScheduleLocalData> | ReturnType<typeof updateAccruedJESchedules> | ReturnType<typeof updateAccruedJESchedulesDetails> | ReturnType<typeof updateJEOneTimeAccruals> | ReturnType<typeof updateJESchedules> | ReturnType<typeof updateJESchedulesDetails>;
+export type ActionType = ReturnType<typeof clearAll> | ReturnType<typeof fetchJeSchedules> | ReturnType<typeof fetchJeSchedulesFailure> | ReturnType<typeof fetchJeSchedulesSuccess> | ReturnType<typeof initializeJeScheduleLocalData> | ReturnType<typeof updateAccruedJESchedules> | ReturnType<typeof updateAccruedJESchedulesDetails> | ReturnType<typeof updateJEOneTimeAccruals> | ReturnType<typeof updateJESchedules> | ReturnType<typeof updateJESchedulesDetails>;
 export declare const fetchJeSchedulesEpic: (actions$: ActionsObservable<ActionType>, state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => Observable<ActionType>;

package/lib/view/expenseAutomationView/epics/jeSchedule/fetchJeSchedulesEpic.js

@@ -8,6 +8,7 @@ const timePeriod_1 = require("../../../../commonStateTypes/timePeriod");
 const jeSchedulesReducer_1 = require("../../../../entity/jeSchedules/jeSchedulesReducer");
 const tenantSelector_1 = require("../../../../entity/tenant/tenantSelector");
 const responsePayload_1 = require("../../../../responsePayload");
+const rootActions_1 = require("../../../../rootActions");
 const zeniDayJS_1 = require("../../../../zeniDayJS");
 const jeSchedulesViewReducer_1 = require("../../reducers/jeSchedulesViewReducer");
 const fetchJeSchedulesEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(jeSchedulesViewReducer_1.fetchJeSchedules.match), (0, operators_1.mergeMap)((action) => {
@@ -80,6 +81,10 @@ const fetchJeSchedulesEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, op
             JSON.stringify(error)),
         selectedPeriod,
         selectedPageTab,
-    }))));
+    }))), 
+    // A tenant switch clears the store while this request is still in flight. Without this
+    // the old tenant's rows are written back into the freshly cleared store and stay on
+    // screen under the new tenant until a manual refresh.
+    (0, operators_1.takeUntil)(actions$.pipe((0, operators_1.filter)(rootActions_1.clearAll.match))));
 }));
 exports.fetchJeSchedulesEpic = fetchJeSchedulesEpic;

package/lib/view/expenseAutomationView/selectors/jeSchedulesViewSelector.d.ts

@@ -3,6 +3,14 @@ import { JEAccruedSchedule, JEOneTimeAccrual, JEScheduledTransaction, ScheduledJ
 import { ScheduleTypes } from '../../../entity/jeSchedules/jeSchedulesTypes';
 import { RootState } from '../../../reducer';
 import { ExpenseAutomationJESchedulesViewSelector } from '../selectorTypes/jeSchedulesSelectorTypes';
+/**
+ * `posting_blocked` is written by the posting Cron when a JE fails to post. It is an internal
+ * failure state with no human action attached, so it is dropped here rather than hidden at render
+ * time — filtering in the view would leave the group counts and KPI totals counting rows nobody
+ * can see. The expense-automation endpoint applies no status filter on the close-period path, so
+ * these rows do arrive.
+ */
+export declare function isRenderableOneTimeAccrual(accrual: JEOneTimeAccrual): boolean;
 export declare function getJEScheduleRowType(schedule: JEScheduleRow): ScheduleTypes | undefined;
 export declare function isPendingReviewRow(schedule: JEScheduleRow): boolean;
 export declare function isExistingTabRow(schedule: JEScheduleRow): boolean;

package/lib/view/expenseAutomationView/selectors/jeSchedulesViewSelector.js

@@ -4,6 +4,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.isAiAccountantSchedule = void 0;
+exports.isRenderableOneTimeAccrual = isRenderableOneTimeAccrual;
 exports.getJEScheduleRowType = getJEScheduleRowType;
 exports.isPendingReviewRow = isPendingReviewRow;
 exports.isExistingTabRow = isExistingTabRow;
@@ -38,13 +39,21 @@ const BOT_EMAIL = 'bot@zeni.ai';
 // A one-time accrual has no jeScheduleType of its own — it is not a JE schedule. It is still an
 // accrued expense, so it counts and filters under that type on the page's type tabs.
 const ONE_TIME_ACCRUAL_SCHEDULE_TYPE = 'accrued_expenses';
-// Which of the two list buckets an accrual belongs in. `draft` still needs a human to post it and
-// `posting_blocked` needs attention, so both are review work; everything else is already on the
-// books or in a transient claim.
+// Which of the two list buckets an accrual belongs in. `draft` still needs a human to post it;
+// everything else is already on the books or in a transient claim.
 const ONE_TIME_ACCRUAL_REVIEW_STATUSES = [
     'draft',
-    'posting_blocked',
 ];
+/**
+ * `posting_blocked` is written by the posting Cron when a JE fails to post. It is an internal
+ * failure state with no human action attached, so it is dropped here rather than hidden at render
+ * time — filtering in the view would leave the group counts and KPI totals counting rows nobody
+ * can see. The expense-automation endpoint applies no status filter on the close-period path, so
+ * these rows do arrive.
+ */
+function isRenderableOneTimeAccrual(accrual) {
+    return accrual.accrualStatus !== 'posting_blocked';
+}
 function getJEScheduleRowType(schedule) {
     return isOneTimeAccrualRow(schedule)
         ? ONE_TIME_ACCRUAL_SCHEDULE_TYPE
@@ -256,7 +265,7 @@ function getExpenseAutomationJESchedulesView(state) {
         : undefined) ?? [];
     jeScheduleOneTimeAccrualKeys.forEach((jeOneTimeAccrualKey) => {
         const accrual = (0, jeSchedulesSelector_1.getJEOneTimeAccrualByKey)(jeOneTimeAccrualKey, state.jeSchedulesState);
-        if (accrual != null) {
+        if (accrual != null && isRenderableOneTimeAccrual(accrual)) {
             oneTimeAccruals.push(accrual);
         }
     });
@@ -360,7 +369,7 @@ function getExpenseAutomationJESchedulesView(state) {
                 .filter((accruedRow) => accruedRow != null),
             ...oneTimeAccrualKeys
                 .map((accrualKey) => (0, jeSchedulesSelector_1.getJEOneTimeAccrualByKey)(accrualKey, state.jeSchedulesState))
-                .filter((accrualRow) => accrualRow != null),
+                .filter((accrualRow) => accrualRow != null && isRenderableOneTimeAccrual(accrualRow)),
         ];
         scheduleCountsByTab[pageTab] =
             pageTab === 'existing_schedules'

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.1.88-betaRD5",
+  "version": "5.1.88-betaRD7",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",