@zeniai/client-epic-state 5.1.83 → 5.1.84-beta1ND

package/lib/esm/view/expenseAutomationView/reducers/transactionsViewReducer.js

@@ -165,7 +165,8 @@ const expenseAutomationTransactionsView = createSlice({
                 // Only overwrite when explicitly set; undefined means a non-search fetch
                 // (tab switch, period change) should preserve the existing search string.
                 if (searchString !== undefined) {
-                    draft.transactionCategorizationView[selectedTab].uiState.searchString = searchString;
+                    draft.transactionCategorizationView[selectedTab].uiState.searchString =
+                        searchString;
                     // When search is cleared, drop all sub-tab snapshots. A snapshot
                     // captured while search was active holds filtered row IDs — restoring
                     // it after the clear would show stale search results instead of the
@@ -1001,7 +1002,7 @@ const expenseAutomationTransactionsView = createSlice({
                 };
             },
             reducer(draft, action) {
-                const { transactionId, updatedTransaction, pendingReviewLineIds } = action.payload;
+                const { transactionId, updatedTransaction, pendingReviewLineIds, } = action.payload;
                 const txnId = transactionId.id;
                 const reviewTabView = draft.transactionCategorizationView.review;
                 const autoTabView = draft.transactionCategorizationView.autoCategorized;

package/lib/esm/view/expenseAutomationView/selectors/reconciliationViewSelector.js

@@ -13,8 +13,8 @@ import { date } from '../../../zeniDayJS';
 import { getAccountList, getNestedAccountListHierarchy, } from '../../accountList/accountListSelector';
 import { getClassList, getNestedClassListHierarchy, } from '../../classList/classListSelector';
 import { initialActionFetchState, initialReconciliationTabsState, initialState, } from '../reducers/reconciliationViewReducer';
-import { getAllSteps } from '../selectorTypes/expenseAutomationViewSelectorTypes';
 import { getParsedStatementDataForView, getStatementTransactionPeriodById, } from './statementParseViewSelector';
+import { getAllSteps } from '../selectorTypes/expenseAutomationViewSelectorTypes';
 export const getExpenseAutomationReconciliationView = createSelector((state) => state, (state) => getCurrentTenant(state), (state) => state.expenseAutomationReconciliationViewState, (state) => state.expenseAutomationViewState, (state) => state.plaidAccountViewState, (state) => state.accountListState, (state) => state.accountState, (state) => state.classListState, (state) => state.classState, (state) => state.monthEndCloseChecksState, (state) => state.vendorState, (state) => state.monthEndCloseChecksViewState, (state, currentTenant, reconciliationViewState, expenseAutomationViewState, plaidAccountViewState, accountListState, accountState, classListState, classState, monthEndCloseChecksState, vendorState, monthEndCloseChecksViewState) => {
     const { selectedPeriodByTenantId } = expenseAutomationViewState;
     const reconcileTabUiState = reconciliationViewState.reconTabsState.reconcile.uiState;
@@ -455,8 +455,7 @@ export const getExpenseAutomationReconciliationView = createSelector((state) =>
         summary: summaryWithTimeSaved,
     };
 });
-export const getReparseStatementStatusByAccountId = (state, accountId) => getExpenseAutomationReconciliationView(state)
-    .accountReconciliationsByAccountID[accountId]?.reparseStatementStatus;
+export const getReparseStatementStatusByAccountId = (state, accountId) => getExpenseAutomationReconciliationView(state).accountReconciliationsByAccountID[accountId]?.reparseStatementStatus;
 export const isAccountReconReport = (reportId) => {
     return reportId.endsWith('reconciliation');
 };

package/lib/esm/view/expenseAutomationView/selectors/transactionCategorizationSelector.js

@@ -1,7 +1,8 @@
 import { createSelector } from '@reduxjs/toolkit';
 import omit from 'lodash/omit';
+import { reduceAllFetchState, reduceAnyFetchState, } from '../../../commonStateTypes/reduceFetchState';
 import { toMonthYearPeriodId } from '../../../commonStateTypes/timePeriod';
-import { getCurrentTenant, getIsAccountingProjectsEnabled, } from '../../../entity/tenant/tenantSelector';
+import { getCurrentTenant, getIsAccountingClassesEnabled, getIsAccountingProjectsEnabled, } from '../../../entity/tenant/tenantSelector';
 import { getTransactionWithCOT } from '../../../entity/transaction/transactionHelper';
 import { getSupportedTransactionsByIds } from '../../../entity/transaction/transactionSelector';
 import { getAccountList, getNestedAccountListHierarchy, getUncategorizedAccounts, } from '../../accountList/accountListSelector';
@@ -85,7 +86,7 @@ export const toTransactionView = (transaction, transactionLocalData) => {
 // `view/createTransferEntry/createTransferEntrySelector`.
 export { getLastTransferEntryReplacement } from '../../createTransferEntry/createTransferEntrySelector';
 export function getExpenseAutomationTransactionView(state) {
-    const { accountState, classState, classListState, accountListState, createTransferEntryState, expenseAutomationTransactionsViewState, expenseAutomationViewState, projectState, projectListState, transactionState, monthEndCloseChecksState, } = state;
+    const { accountState, classState, classListState, accountListState, createTransferEntryState, expenseAutomationTransactionsViewState, expenseAutomationViewState, projectState, projectListState, transactionState, monthEndCloseChecksState, monthEndCloseChecksViewState, } = state;
     const { selectedTransactionCategorizationCompletedSubTab, selectedTransactionCategorizationTab, } = expenseAutomationTransactionsViewState;
     const { uiState, refreshStatus, saveStatus, markAsNotMiscategorizedStatus, transactionIdsBySelectedPeriod, transactionReviewLocalDataById, selectedCheckBoxTransactionIds, transactionIdsWithUnsavedData, uploadReceiptStatusById, selectedTransactionId, selectedTransactionLineId, filters, } = expenseAutomationTransactionsViewState.transactionCategorizationView[selectedTransactionCategorizationTab];
     const uncategorizedIncomeExpense = getUncategorizedAccounts(accountState, accountListState, 'accountList');
@@ -158,8 +159,21 @@ export function getExpenseAutomationTransactionView(state) {
         }
         return [];
     });
-    const { fetchState, error } = expenseAutomationTransactionsViewState.transactionCategorizationView[selectedTransactionCategorizationTab];
-    const fetchStatus = { fetchState, error };
+    const monthEndFetchState = monthYearPeriodId != null
+        ? (monthEndCloseChecksViewState.monthEndCloseChecksViewByTenantId[currentTenant.tenantId]?.[monthYearPeriodId] ?? { fetchState: 'Not-Started', error: undefined })
+        : { fetchState: 'Not-Started', error: undefined };
+    const isAccountingClassesEnabled = getIsAccountingClassesEnabled(state);
+    const allFetchStateList = [
+        accountList,
+        expenseAutomationTransactionsViewState.transactionCategorizationView[selectedTransactionCategorizationTab],
+    ];
+    if (isAccountingClassesEnabled) {
+        allFetchStateList.push(classList);
+    }
+    const fetchStatus = reduceAnyFetchState([
+        reduceAllFetchState(allFetchStateList),
+        monthEndFetchState,
+    ]);
     const totalCountByReview = expenseAutomationTransactionsViewState.transactionCategorizationView.review
         .uiState.totalCount;
     const totalCountByAutoCat = expenseAutomationTransactionsViewState.transactionCategorizationView

package/lib/esm/view/fileView/fileUploadHelpers.js

@@ -70,7 +70,8 @@ export async function uploadFiles(fileBlobs, metadataPayload, filesEndPoint, aut
             return undefined;
         }
         const responseBody = await httpResponse.json();
-        if (responseBody?.status?.code >= 200 && responseBody?.status?.code < 300) {
+        if (responseBody?.status?.code >= 200 &&
+            responseBody?.status?.code < 300) {
             return responseBody.data?.files;
         }
         console.error(`Upload files failed with ${responseBody?.status?.message ?? 'unknown API error'}`);

package/lib/esm/view/onboardingView/cockpitView/epic/initializeOnboardingCustomerViewUpdateDataEpic.js

@@ -122,7 +122,11 @@ const getSelectedProducts = (isDebitCardFlagEnabled, tenant) => {
         return [];
     }
     else if (isBookkeepingEnabled) {
-        return ['bookkeeping', 'zeni_bill_pay', 'zeni_reimbursements'];
+        return [
+            'bookkeeping',
+            'zeni_bill_pay',
+            'zeni_reimbursements',
+        ];
     }
     else if (isOtherProductsEnabled) {
         const selectedProducts = [];

package/lib/esm/view/onboardingView/customerView/epic/customerDetails/updateOnboardingCustomerViewLocalStoreDataEpic.js

@@ -78,8 +78,9 @@ export const updateOnboardingCustomerViewLocalStoreDataEpic = (actions$, state$)
                 companyView?.company.company.companyOnboardingInfo
                     .subscriptionBillingAddressId != null) {
                 updatedCurrentStep = 'connect_ledger';
-                const isOnboardingAiActivationViewed = companyOnboardingInfo?.onboardingInfo?.onboardingAiActivationInfo
-                    ?.isOnboardingAiActivationViewed ?? false;
+                const isOnboardingAiActivationViewed = companyOnboardingInfo?.onboardingInfo
+                    ?.onboardingAiActivationInfo?.isOnboardingAiActivationViewed ??
+                    false;
                 // Past the ledger step we always sit on connect_data_source —
                 // it has many integrations, so we treat it as never auto-complete
                 // and only advance to verification on an explicit user dispatch.
@@ -113,9 +114,7 @@ export const updateOnboardingCustomerViewLocalStoreDataEpic = (actions$, state$)
             // stale subStep (e.g. 'default' carried over from another step)
             // leaves verification rendering an empty form.
             if (updatedCurrentStep !== onboardingCustomerViewState.currentStep) {
-                const targetSubStep = updatedCurrentStep === 'verification'
-                    ? 'unlock-stack'
-                    : 'default';
+                const targetSubStep = updatedCurrentStep === 'verification' ? 'unlock-stack' : 'default';
                 fetchActions.push(updateCurrentSubStep({ subStep: targetSubStep }));
             }
         }

package/lib/esm/view/recommendation/fetchEntityRecommendationsForLineUpdateEpic.js

@@ -37,7 +37,7 @@ const toGroupKey = (flowType, transactionId, lineIds) => `${flowType}${SEPARATOR
 export const fetchEntityRecommendationsForLineUpdateEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(fetchEntityRecommendationsForLineUpdate.match), groupBy((action) => toGroupKey(action.payload.flowType, action.payload.transactionDetails.transactionId.id, action.payload.transactionDetails.lineIds), undefined, (group$) => group$.pipe(debounce(() => timer(GROUP_INACTIVITY_TIMEOUT_MS)))), mergeMap((group$) => group$.pipe(switchMap((action) => {
     const payload = action.payload;
     const { transactionId, transaction, lineIds } = payload.transactionDetails;
-    const { entity, amount, isFetchCOT } = payload;
+    const { entity, amount, isFetchCOT, } = payload;
     // The vendor "Update all lines" popup on the detail page watches
     // its own transaction-level fetch status, separate from the
     // per-line statuses below — surface completion/failure there too

package/lib/esm/view/recommendation/recommendationReducer.js

@@ -133,9 +133,25 @@ const recommendation = createSlice({
         clearRecommendation(draft) {
             Object.assign(draft, initialState);
         },
+        // Fire-and-forget human feedback on a recommendation (accept, ranked
+        // override or outside override). Handled by submitRecommendationFeedbackEpic
+        // which POSTs to the accounting recommendation-feedback endpoint. No state
+        // mutation: the categorization UX must not depend on the feedback round-trip.
+        submitRecommendationFeedback: {
+            reducer(
+            // eslint-disable-next-line @typescript-eslint/no-unused-vars
+            _draft, 
+            // eslint-disable-next-line @typescript-eslint/no-unused-vars
+            _action) {
+                // do nothing
+            },
+            prepare(args) {
+                return { payload: args };
+            },
+        },
     },
 });
-export const { fetchEntityRecommendationsByTransactionId, fetchEntityRecommendationsForLineUpdate, fetchRecommendationByEntityName, fetchRecommendationByEntityId, updateRecommendationForEntity, updateRecommendationForEntityFailure, indicateReadyToInitializeRecommendation, clearRecommendation, } = recommendation.actions;
+export const { fetchEntityRecommendationsByTransactionId, fetchEntityRecommendationsForLineUpdate, fetchRecommendationByEntityName, fetchRecommendationByEntityId, updateRecommendationForEntity, updateRecommendationForEntityFailure, indicateReadyToInitializeRecommendation, clearRecommendation, submitRecommendationFeedback, } = recommendation.actions;
 export default recommendation.reducer;
 const doUpdateRecommendationForEntity = (draft, entityId, entityType, payload) => {
     const key = getEntityRecommendationKey(entityType, entityId);

package/lib/esm/view/recommendation/submitRecommendationFeedbackEpic.js

@@ -0,0 +1,52 @@
+import { EMPTY } from 'rxjs';
+import { catchError, filter, mergeMap } from 'rxjs/operators';
+import { isSuccessStatus } from '../../responsePayload';
+import { submitRecommendationFeedback } from './recommendationReducer';
+const toRequestBody = (payload) => ({
+    line_id: payload.lineId ?? null,
+    dimension: payload.dimension,
+    recommendation_set_id: payload.recommendationSetId ?? null,
+    top_pick_source: payload.topPickSource ?? null,
+    shown_recommendations: (payload.shownRecommendations ?? []).map((recommendation) => ({
+        source: recommendation.source,
+        rank: recommendation.rank,
+        value: {
+            name: recommendation.value.name,
+            id: recommendation.value.id ?? null,
+            integration_id: recommendation.value.integrationId ?? null,
+        },
+        confidence: recommendation.confidence ?? null,
+        reasoning: recommendation.reasoning ?? null,
+        cot: recommendation.cot ?? [],
+    })),
+    selected: {
+        name: payload.selected.name,
+        id: payload.selected.id ?? null,
+        integration_id: payload.selected.integrationId ?? null,
+        is_new_entity: payload.selected.isNewEntity ?? false,
+    },
+    matched_source: payload.matchedSource ?? null,
+    matched_rank: payload.matchedRank ?? null,
+    outcome: payload.outcome,
+    reason_text: payload.reasonText ?? null,
+    skipped: payload.skipped ?? false,
+    retracts_feedback_id: payload.retractsFeedbackId ?? null,
+    features: payload.features ?? null,
+});
+// Fire-and-forget: the epic never re-emits an action. Feedback delivery is a
+// side-effect that must not disrupt the categorization UX, so both the
+// success and error paths complete silently (errors are logged for debugging).
+export const submitRecommendationFeedbackEpic = (actions$, _state$, zeniAPI) => actions$.pipe(filter(submitRecommendationFeedback.match), mergeMap((action) => {
+    const { transactionId } = action.payload;
+    return zeniAPI
+        .postAndGetJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/transactions/${transactionId}/recommendation-feedback`, toRequestBody(action.payload))
+        .pipe(mergeMap((response) => {
+        if (!isSuccessStatus(response)) {
+            console.error('submitRecommendationFeedbackEpic: recommendation feedback was not recorded', response.status);
+        }
+        return EMPTY;
+    }), catchError((error) => {
+        console.error('submitRecommendationFeedbackEpic: failed to submit recommendation feedback', error);
+        return EMPTY;
+    }));
+}));

package/lib/esm/view/reportsResync/reportsClassViewRefetchingEpic.js

@@ -3,6 +3,7 @@ import { filter, switchMap } from 'rxjs/operators';
 import { fetchNetBurnOrIncomeClassesView } from '../netBurnOrIncomeClassesView/netBurnOrIncomeClassesViewReducer';
 import { fetchOpExClassesView } from '../opExClassesView/opExClassesViewReducer';
 import { fetchProfitAndLossClassesView } from '../profitAndLossClassesView/profitAndLossClassesViewReducer';
+import { fetchProfitAndLossProjectView } from '../profitAndLossProjectView/profitAndLossProjectViewReducer';
 import { fetchRevenueClassesView } from '../revenueClassesView/revenueClassesViewReducer';
 import { initiateReportsClassViewRefetching } from './reportsResyncReducer';
 export const initiateReportsClassViewRefetchingEpic = (actions$, 
@@ -23,6 +24,9 @@ _) => actions$.pipe(filter(initiateReportsClassViewRefetching.match), switchMap(
         case 'net_burn_or_income_by_classes':
             actions.push(fetchNetBurnOrIncomeClassesView(true));
             break;
+        case 'profit_and_loss_by_projects':
+            actions.push(fetchProfitAndLossProjectView(true));
+            break;
         default:
             break;
     }

package/lib/esm/view/reportsResync/reportsResyncEpic.js

@@ -1,28 +1,20 @@
 import { from } from 'rxjs';
 import { catchError, filter, mergeMap, switchMap } from 'rxjs/operators';
-import { isDashboardProjectViewReport, isPAndLProjectViewReport, } from '../../commonStateTypes/viewAndReport/reportIDHelper';
 import { openSnackbar } from '../../entity/snackbar/snackbarReducer';
 import { createZeniAPIStatus, isSuccessResponse, } from '../../responsePayload';
-import { initiateReportsClassViewRefetching, initiateReportsProjectViewRefetching, initiateReportsResync, reportsResyncFailure, reportsResyncSuccess, } from './reportsResyncReducer';
+import { initiateReportsClassViewRefetching, initiateReportsResync, reportsResyncFailure, reportsResyncSuccess, } from './reportsResyncReducer';
 export const reportsResyncEpic = (actions$, _, zeniAPI) => actions$.pipe(filter(initiateReportsResync.match), mergeMap((action) => {
     const { reportIdToResync } = action.payload;
     const payload = {
         is_hard_refresh: true,
     };
-    const isProjectViewResync = isPAndLProjectViewReport(reportIdToResync) ||
-        isDashboardProjectViewReport(reportIdToResync);
-    const resyncTaskName = isProjectViewResync
-        ? 'generate-group-by-project-reports'
-        : 'generate-group-by-class-reports';
     return zeniAPI
-        .postAndGetJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/2.0/tasks/${resyncTaskName}`, payload)
+        .postAndGetJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/2.0/tasks/generate-group-by-class-reports`, payload)
         .pipe(switchMap((response) => {
         if (isSuccessResponse(response)) {
             // 200 means new data is available, 204 means no new data
             const actions = [
-                isProjectViewResync
-                    ? initiateReportsProjectViewRefetching({ reportIdToResync })
-                    : initiateReportsClassViewRefetching({ reportIdToResync }),
+                initiateReportsClassViewRefetching({ reportIdToResync }),
                 reportsResyncSuccess({
                     hasNewData: response.status.code === 200,
                 }),

package/lib/esm/view/reportsResync/reportsResyncReducer.js

@@ -30,14 +30,6 @@ const reportsResync = createSlice({
             // This action is handled by initiateReportsClassViewRefetchingEpic
             // which dispatches the appropriate fetch actions
         },
-        initiateReportsProjectViewRefetching(
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
-        _draft, 
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
-        _action) {
-            // This action is handled by initiateReportsProjectViewRefetchingEpic
-            // which dispatches the appropriate fetch actions
-        },
         reportsResyncSuccess(draft, action) {
             draft.reportsResyncFetchState.fetchState = 'Completed';
             draft.reportsResyncFetchState.error = undefined;
@@ -53,5 +45,5 @@ const reportsResync = createSlice({
         },
     },
 });
-export const { initiateReportsResync, initiateReportsClassViewRefetching, initiateReportsProjectViewRefetching, reportsResyncSuccess, reportsResyncFailure, clearReportsResync, } = reportsResync.actions;
+export const { initiateReportsResync, initiateReportsClassViewRefetching, reportsResyncSuccess, reportsResyncFailure, clearReportsResync, } = reportsResync.actions;
 export default reportsResync.reducer;

package/lib/esm/view/settingsView/epic/fetchNotificationSettingsEpic.js

@@ -1,51 +1,19 @@
 import { from, of } from 'rxjs';
 import { catchError, filter, mergeMap, switchMap } from 'rxjs/operators';
-import { updateNotificationRegistry } from '../../../entity/notificationRegistry/notificationRegistryReducer';
 import { createZeniAPIStatus, isSuccessResponse } from '../../../responsePayload';
-import { notificationPreferencesUrl } from '../../notificationPreferencesView/notificationPreferencesEndpoint';
-import { fetchNotificationPreferencesSuccess } from '../../notificationPreferencesView/notificationPreferencesViewReducer';
 import { fetchNotificationSettings, updateNotificationSettingsOnFailure, updateNotificationSettingsOnSuccess, } from '../settingsViewReducer';
 export const fetchNotificationSettingsEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(fetchNotificationSettings.match), switchMap(() => {
     const state = state$.value;
+    const URL = `${zeniAPI.apiEndPoints.notificationMicroServiceBaseUrl}/1.0/notification-preferences`;
     const userEmail = state.tenantState.loggedInUser?.userEmail;
     if (userEmail == null) {
         return from([]);
     }
-    // Snapshot the save epoch at GET-dispatch time. The reducer compares
-    // the captured value against the current `saveEpoch` on response and
-    // skips the `preferences` replace when a save has landed in the
-    // meantime — the GET is carrying the pre-PUT snapshot and would
-    // otherwise clobber the fresh save. Cursor Bugbot 3632510237.
-    const saveEpochAtDispatch = state.notificationPreferencesViewState.saveEpoch;
-    // Snapshot the registry clear epoch at GET-dispatch time (same idiom as
-    // `saveEpochAtDispatch` above). The registry reducer compares it against
-    // the current `registryEpoch` and skips its write when a
-    // `clearAllNotificationRegistry` (tenant switch) has landed since — the
-    // GET is carrying the prior tenant's snapshot. Cursor Bugbot 67d6918e.
-    const registryEpochAtDispatch = state.notificationRegistryState.registryEpoch;
-    return zeniAPI
-        .getJSON(notificationPreferencesUrl(zeniAPI))
-        .pipe(mergeMap((response) => {
+    return zeniAPI.getJSON(URL).pipe(mergeMap((response) => {
         if (isSuccessResponse(response) && response.data != null) {
             const updateActions = [
                 updateNotificationSettingsOnSuccess(response.data, userEmail),
             ];
-            // Always dispatch — an absent `task_checklist_registry` (gate
-            // off) must CLEAR the prior tenant's registry, not leave it in
-            // place. The reducer clears on `undefined` and full-replaces
-            // otherwise, both guarded by the registry epoch so a stale GET
-            // that lands after a tenant switch is skipped. Cursor Bugbot
-            // 67d6918e.
-            updateActions.push(updateNotificationRegistry({
-                registry: response.data.task_checklist_registry ?? undefined,
-                registryEpochAtDispatch,
-            }));
-            if (response.data.task_checklist_preferences != null) {
-                updateActions.push(fetchNotificationPreferencesSuccess({
-                    preferences: response.data.task_checklist_preferences,
-                    saveEpochAtDispatch,
-                }));
-            }
             return of(...updateActions);
         }
         else {

package/lib/esm/view/settingsView/epic/saveNotificationSettingsEpic.js

@@ -2,10 +2,9 @@ import { of } from 'rxjs';
 import { catchError, filter, mergeMap, switchMap } from 'rxjs/operators';
 import { openSnackbar } from '../../../entity/snackbar/snackbarReducer';
 import { createZeniAPIStatus, isSuccessResponse } from '../../../responsePayload';
-import { notificationPreferencesUrl } from '../../notificationPreferencesView/notificationPreferencesEndpoint';
 import { saveNotificationSettings, updateNotificationSettingsOnSaveFailure, updateNotificationSettingsOnSaveSuccess, } from '../settingsViewReducer';
 export const saveNotificationSettingsEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(saveNotificationSettings.match), switchMap(() => {
-    const URL = notificationPreferencesUrl(zeniAPI);
+    const URL = `${zeniAPI.apiEndPoints.notificationMicroServiceBaseUrl}/1.0/notification-preferences`;
     const { notificationSettings, notificationSettingsLocalData } = state$.value.settingsViewState.notification;
     const payload = toSaveNotificationSettingsPayload(notificationSettingsLocalData, notificationSettings);
     return zeniAPI

package/lib/esm/view/settingsView/settingsViewHelpers.js

@@ -145,14 +145,13 @@ export const isMonthEndNotificationsSectionVisibleOnSettingsPage = (monthEndInsi
     return (monthEndInsightsNotificationSettings.enabled != null ||
         monthEndInsightsNotificationSettings.recipientEmailIds.includes(signedInUseEmail));
 };
-export const isNotificationsTabVisible = (notificationSettings, signedInUseEmail, isDebitCardFlagEnabled, currentTenant, hasTaskChecklistAccess) => {
+export const isNotificationsTabVisible = (notificationSettings, signedInUseEmail, isDebitCardFlagEnabled, currentTenant) => {
     if (currentTenant == null) {
         return false;
     }
     const { reminderNotificationSettings, monthEndInsightsNotificationSettings } = notificationSettings;
     return ((isRemindersSectionVisibleOnSettingsPage(reminderNotificationSettings) ||
-        isMonthEndNotificationsSectionVisibleOnSettingsPage(monthEndInsightsNotificationSettings, signedInUseEmail) ||
-        hasTaskChecklistAccess) &&
+        isMonthEndNotificationsSectionVisibleOnSettingsPage(monthEndInsightsNotificationSettings, signedInUseEmail)) &&
         (isTenantAccountingServicesEnabled(currentTenant) ||
             (isTenantBankingOnly(isDebitCardFlagEnabled, currentTenant) === false &&
                 isTenantCardsOnly(currentTenant) === false)));

package/lib/esm/view/spendManagement/billPay/billDetailView/billDetailViewSelector.js

@@ -13,7 +13,7 @@ import { getUserByUserId } from '../../../../entity/user/userSelector';
 import { getUserRoleByUserId } from '../../../../entity/userRole/userRoleSelector';
 import { getActivityHistory, } from '../../commonHistoryView/commonHistorySelector';
 import { getAllFundingAccounts, } from '../../commonSetup/setupViewSelector';
-import { getLatestApprovalDate, isAwaitingMarkAsPaid, isSodAdminFallbackEligibleForStep, isSodExcludedViewerBlocked, shouldShowSodAdminLabel, } from '../../helpers';
+import { getLatestApprovalDate, isAwaitingMarkAsPaid } from '../../helpers';
 import { getActivityRealTimeApproval, } from '../../realTimeApprovalView/realTimeApprovalSelector';
 import { getEntityRealTimeApprovalDetailKey } from '../../realTimeApprovalView/realTimeApprovalState';
 import { getBillPaymentSubConfigCodeKey, getInternationalSubConfigCodeKey, getInternationalWireMethodCodeKey, } from '../billPayConfig/billPayConfigPayload';
@@ -22,12 +22,7 @@ import { getBillPayConfigMethodKey, toBillPaymentSubConfigCodeKeyType, } from '.
 import { getPreviousBills, } from '../previousBills/previousBillsSelector';
 import { getBillTransactionDetailKey, initialBillDetailView, } from './billDetailViewState';
 export const getBillActivities = (state, billId, billStageCode) => {
-    const { billDetailViewState, approvalRuleState, entityApprovalStatusState, userState, billTransactionState, } = state;
-    // Note: createdBy is undefined until billTransactionState is populated.
-    // getBillActivities is called from getBillDetailView which runs after the
-    // bill entity epic completes — this assumption must hold for showSodAdminLabel
-    // to render on first paint.
-    const createdBy = billTransactionState.transactionById[billId]?.createdBy;
+    const { billDetailViewState, approvalRuleState, entityApprovalStatusState, userState, } = state;
     const key = getBillTransactionDetailKey(billId);
     const billDetail = recordGet(billDetailViewState.billDetailById, key, undefined);
     let billActivities = [];
@@ -62,7 +57,7 @@ export const getBillActivities = (state, billId, billStageCode) => {
             const approvalRules = getApprovalRulesByIds(approvalRuleState, billDetail.approvalRuleIds);
             const entityApprovalStatusByIds = getEntityApprovalStatusByIds(entityApprovalStatusState, billDetail.entityApprovalIds);
             billActivities = entityApprovalStatusByIds.map((entityApprovalStatus) => {
-                const { approvalRuleId, entityType, createTime, updateTime, stepsApprovalStatus, areApprovalsSerialized, isAdminFallbackApprover, isRealTimeApprovalEnabled, currentPendingStepIndex, sodExcludedApproverUserId, } = entityApprovalStatus;
+                const { approvalRuleId, entityType, createTime, updateTime, stepsApprovalStatus, areApprovalsSerialized, isAdminFallbackApprover, isRealTimeApprovalEnabled, currentPendingStepIndex, } = entityApprovalStatus;
                 const approvalRule = approvalRules.find((rule) => rule.approvalRuleId === approvalRuleId);
                 return {
                     approvalRuleId,
@@ -74,23 +69,21 @@ export const getBillActivities = (state, billId, billStageCode) => {
                     isAdminFallbackApprover,
                     isRealTimeApprovalEnabled,
                     currentPendingStepIndex,
-                    sodExcludedApproverUserId,
                     entityApprovalId: entityApprovalStatus.entityApprovalId,
                     stepsWithStatus: stepsApprovalStatus.map((step) => {
-                        const actorsActivity = step.actorsActivity.map((activity) => ({
-                            ...activity,
-                            actor: getUserByUserId(userState, activity.userId),
-                        }));
                         return {
                             ...step,
                             actors: step.actors
                                 .map((actor) => getUserByUserId(userState, actor.userId))
                                 .filter((user) => user != null),
                             nonUserActors: step.actors.filter((actor) => actor.userId == null && actor.type !== 'user'),
-                            actorsActivity,
+                            actorsActivity: step.actorsActivity.map((activity) => {
+                                return {
+                                    ...activity,
+                                    actor: getUserByUserId(userState, activity.userId),
+                                };
+                            }),
                             isOriginalApprovalStep: step.isOriginalApprovalStep,
-                            displayPendingApproverAsAdmin: isSodAdminFallbackEligibleForStep(sodExcludedApproverUserId, isAdminFallbackApprover, actorsActivity),
-                            showSodAdminLabel: shouldShowSodAdminLabel(sodExcludedApproverUserId, actorsActivity, createdBy),
                         };
                     }),
                 };
@@ -255,7 +248,7 @@ export const checkApproveRejectBtnShow = (billActivities, isUserAdmin, signedInU
     let isMarkAsPaidBtnVisible = false;
     let rejectedId = -1;
     const stepsWithStatusData = billActivities[0].stepsWithStatus;
-    const { areApprovalsSerialized, isAdminFallbackApprover, currentPendingStepIndex, sodExcludedApproverUserId, } = billActivities[0];
+    const { areApprovalsSerialized, isAdminFallbackApprover, currentPendingStepIndex, } = billActivities[0];
     for (const [index, stepWithStatus] of stepsWithStatusData.entries()) {
         if (stepWithStatus.action === 'require_approval') {
             for (const actorActivity of stepWithStatus.actorsActivity) {
@@ -296,42 +289,23 @@ export const checkApproveRejectBtnShow = (billActivities, isUserAdmin, signedInU
                         break;
                     }
                 }
-                const sodBlocked = isSodExcludedViewerBlocked(sodExcludedApproverUserId, signedInUser?.userId, pendingStep.actorsActivity);
-                if (isAllActivitiesPending) {
-                    for (const actorActivity of pendingStep.actorsActivity) {
-                        if (!sodBlocked &&
-                            actorActivity.actor?.userId === signedInUser?.userId) {
-                            isApprovalorRejectBtnVisible = true;
-                            isMarkAsPaidBtnVisible = isLastApprovalStep;
-                            break;
-                        }
+                for (const actorActivity of pendingStep.actorsActivity) {
+                    if (actorActivity.actor?.userId === signedInUser?.userId &&
+                        isAllActivitiesPending) {
+                        isApprovalorRejectBtnVisible = true;
+                        isMarkAsPaidBtnVisible = isLastApprovalStep;
                     }
-                }
-                if (!isApprovalorRejectBtnVisible) {
-                    for (const actorActivity of pendingStep.actorsActivity) {
-                        // admin will be fallback approver if vendor-owner/manager are not assigned any user id
-                        if (actorActivity.type === 'attribute' &&
-                            (actorActivity.subType === 'manager' ||
-                                actorActivity.subType === 'vendor_owner') &&
-                            actorActivity.userId === null &&
-                            isAdminFallbackApprover === true &&
-                            isUserAdmin &&
-                            signedInUser?.userId != null &&
-                            signedInUser.userId !== sodExcludedApproverUserId) {
-                            isApprovalorRejectBtnVisible = true;
-                            isMarkAsPaidBtnVisible = isLastApprovalStep;
-                            break;
-                        }
+                    // admin will be fallback approver if vendor-owner/manager are not assigned any user id
+                    if (actorActivity.type === 'attribute' &&
+                        (actorActivity.subType === 'manager' ||
+                            actorActivity.subType === 'vendor_owner') &&
+                        actorActivity.userId === null &&
+                        isAdminFallbackApprover === true &&
+                        isUserAdmin === true) {
+                        isApprovalorRejectBtnVisible = true;
+                        isMarkAsPaidBtnVisible = isLastApprovalStep;
                     }
                 }
-                if (!isApprovalorRejectBtnVisible &&
-                    isUserAdmin &&
-                    signedInUser?.userId != null &&
-                    signedInUser.userId !== sodExcludedApproverUserId &&
-                    pendingStep.displayPendingApproverAsAdmin === true) {
-                    isApprovalorRejectBtnVisible = true;
-                    isMarkAsPaidBtnVisible = isLastApprovalStep;
-                }
             }
         }
     }
@@ -345,42 +319,23 @@ export const checkApproveRejectBtnShow = (billActivities, isUserAdmin, signedInU
                         break;
                     }
                 }
-                const sodBlocked = isSodExcludedViewerBlocked(sodExcludedApproverUserId, signedInUser?.userId, stepWithStatus.actorsActivity);
-                if (isAllActivitiesPending) {
-                    for (const actorActivity of stepWithStatus.actorsActivity) {
-                        if (!sodBlocked &&
-                            actorActivity.actor?.userId === signedInUser?.userId) {
-                            isApprovalorRejectBtnVisible = true;
-                            isMarkAsPaidBtnVisible = true;
-                            break;
-                        }
+                for (const actorActivity of stepWithStatus.actorsActivity) {
+                    if (actorActivity.actor?.userId === signedInUser?.userId &&
+                        isAllActivitiesPending) {
+                        isApprovalorRejectBtnVisible = true;
+                        isMarkAsPaidBtnVisible = true;
                     }
-                }
-                if (!isApprovalorRejectBtnVisible) {
-                    for (const actorActivity of stepWithStatus.actorsActivity) {
-                        // admin will be fallback approver if vendor-owner/manager are not assigned any user id
-                        if (actorActivity.type === 'attribute' &&
-                            (actorActivity.subType === 'manager' ||
-                                actorActivity.subType === 'vendor_owner') &&
-                            actorActivity.userId === null &&
-                            isAdminFallbackApprover === true &&
-                            isUserAdmin &&
-                            signedInUser?.userId != null &&
-                            signedInUser.userId !== sodExcludedApproverUserId) {
-                            isApprovalorRejectBtnVisible = true;
-                            isMarkAsPaidBtnVisible = true;
-                            break;
-                        }
+                    // admin will be fallback approver if vendor-owner/manager are not assigned any user id
+                    else if (actorActivity.type === 'attribute' &&
+                        (actorActivity.subType === 'manager' ||
+                            actorActivity.subType === 'vendor_owner') &&
+                        actorActivity.userId === null &&
+                        isAdminFallbackApprover === true &&
+                        isUserAdmin === true) {
+                        isApprovalorRejectBtnVisible = true;
+                        isMarkAsPaidBtnVisible = true;
                     }
                 }
-                if (!isApprovalorRejectBtnVisible &&
-                    isUserAdmin &&
-                    signedInUser?.userId != null &&
-                    signedInUser.userId !== sodExcludedApproverUserId &&
-                    stepWithStatus.displayPendingApproverAsAdmin === true) {
-                    isApprovalorRejectBtnVisible = true;
-                    isMarkAsPaidBtnVisible = true;
-                }
             }
             if (isApprovalorRejectBtnVisible) {
                 break;