@zeniai/client-epic-state 5.1.60-beta0ND → 5.1.60-betaDI0

package/lib/view/notificationPreferencesView/notificationPreferencesViewReducer.js

@@ -0,0 +1,226 @@
+"use strict";
+var _a;
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.toggleEventChannel = exports.setGroupFrequency = exports.saveNotificationPreferencesSuccess = exports.saveNotificationPreferencesFailure = exports.saveNotificationPreferences = exports.fetchNotificationPreferencesSuccess = exports.clearNotificationPreferencesLocalOverrides = exports.clearAllNotificationPreferencesView = exports.initialState = void 0;
+const toolkit_1 = require("@reduxjs/toolkit");
+const notificationPreferencesViewPayload_1 = require("./notificationPreferencesViewPayload");
+const notificationPreferencesViewState_1 = require("./notificationPreferencesViewState");
+exports.initialState = {
+    cancelEpoch: 0,
+    localOverrides: (0, notificationPreferencesViewState_1.emptyNotificationPreferences)(),
+    preferences: (0, notificationPreferencesViewState_1.emptyNotificationPreferences)(),
+    saveEpoch: 0,
+    savePreferencesState: { fetchState: 'Not-Started' },
+};
+const mergePreferences = (base, patch) => {
+    const eventEnabledByChannel = {
+        ...base.eventEnabledByChannel,
+    };
+    Object.entries(patch.eventEnabledByChannel).forEach(([eventId, channels]) => {
+        eventEnabledByChannel[eventId] = {
+            ...(base.eventEnabledByChannel[eventId] ?? {}),
+            ...channels,
+        };
+    });
+    return {
+        eventEnabledByChannel,
+        groupFrequencyByGroupId: {
+            ...base.groupFrequencyByGroupId,
+            ...patch.groupFrequencyByGroupId,
+        },
+    };
+};
+// Remove only the (eventId, channel) and groupId keys that were actually saved
+// to the server from `localOverrides` — AND whose current value still equals
+// what was saved. Any new edits the user added while the PUT was in flight
+// (either new keys not present in `saved`, OR same keys the user flipped back
+// to a different value) are preserved so the next debounce cycle picks them up.
+//
+// Presence-only subtraction (the prior implementation) silently dropped a
+// same-key re-edit that landed AFTER debounce fired but BEFORE the response
+// returned. Concrete case:
+//   1. toggle evt1.email = false → localOverrides = {evt1:{email:false}}
+//   2. debounce PUT #1 fires with savedOverrides = {evt1:{email:false}}
+//   3. user re-toggles evt1.email = true → localOverrides = {evt1:{email:true}}
+//   4. PUT #1 success → subtract dropped `email` on presence, so the true
+//      re-edit disappeared and next-debounce found nothing to send.
+const subtractSavedOverrides = (current, saved) => {
+    const eventEnabledByChannel = {};
+    Object.entries(current.eventEnabledByChannel).forEach(([eventId, channels]) => {
+        const savedChannels = saved.eventEnabledByChannel[eventId];
+        if (savedChannels == null) {
+            eventEnabledByChannel[eventId] = channels;
+            return;
+        }
+        const remainingChannels = {};
+        Object.keys(channels).forEach((channel) => {
+            // Preserve the key when it's a new channel OR when the user's
+            // current value differs from what was saved (same-key re-edit).
+            if (!(channel in savedChannels) ||
+                channels[channel] !== savedChannels[channel]) {
+                remainingChannels[channel] = channels[channel];
+            }
+        });
+        if (Object.keys(remainingChannels).length > 0) {
+            eventEnabledByChannel[eventId] = remainingChannels;
+        }
+    });
+    const groupFrequencyByGroupId = {};
+    Object.entries(current.groupFrequencyByGroupId).forEach(([groupId, frequency]) => {
+        if (saved.groupFrequencyByGroupId[groupId] !== frequency) {
+            groupFrequencyByGroupId[groupId] = frequency;
+        }
+    });
+    return { eventEnabledByChannel, groupFrequencyByGroupId };
+};
+const notificationPreferencesView = (0, toolkit_1.createSlice)({
+    name: 'notificationPreferencesView',
+    initialState: exports.initialState,
+    reducers: {
+        clearAllNotificationPreferencesView(draft) {
+            // Reset everything EXCEPT `cancelEpoch`, which must stay monotonic
+            // across the lifetime of the app instance. `initialState.cancelEpoch`
+            // is `0`; returning `initialState` verbatim would rewind the counter
+            // to zero, and any in-flight save whose `cancelEpochAtDispatch` was
+            // captured pre-clearAll (>0) would then satisfy the "captured >=
+            // current" epoch guard and merge stale edits into fresh preferences.
+            // Bumping instead of resetting also invalidates the abandoned save
+            // for free — Cursor Bugbot bc7876f1 followup.
+            const nextCancelEpoch = draft.cancelEpoch + 1;
+            // saveEpoch must also stay monotonic across clearAll for the same
+            // reason (Cursor Bugbot 3632510237). Rewinding to 0 would let a
+            // stale-in-flight GET whose `saveEpochAtDispatch` was captured >0
+            // satisfy the "captured >= current" epoch guard and clobber fresh
+            // preferences on any subsequent save.
+            const nextSaveEpoch = draft.saveEpoch + 1;
+            return {
+                ...exports.initialState,
+                cancelEpoch: nextCancelEpoch,
+                saveEpoch: nextSaveEpoch,
+            };
+        },
+        clearNotificationPreferencesLocalOverrides(draft) {
+            // Discards in-flight per-event/per-group edits held in `localOverrides`
+            // without touching the fetched `preferences` snapshot. Used by the
+            // settings-page Cancel affordance so the effective preferences revert
+            // to the last server-known state without triggering a refetch race.
+            //
+            // Cancel/in-flight-save race: every Cancel bumps `cancelEpoch`
+            // monotonically. Any save that captured a lower epoch value at
+            // dispatch time is treated as stale by the Success/Failure reducer
+            // — its merge is skipped. Unconditional bump (vs the earlier
+            // counter model) survives switchMap abandonment and double-Cancel
+            // (Cursor Bugbot 4aa021f7): even if the abandoned save's
+            // Success/Failure never dispatches, subsequent legitimate saves
+            // still work because their captured epoch matches the current one.
+            draft.cancelEpoch += 1;
+            draft.localOverrides = (0, notificationPreferencesViewState_1.emptyNotificationPreferences)();
+            // Also drop `savePreferencesState` back to Not-Started so any
+            // "Saving…" affordance bound to `getNotificationPreferencesSaveState`
+            // clears on Cancel. Without this, a Cancel-during-save whose stale
+            // Success/Failure never fires (switchMap abandonment) leaves the
+            // selector reporting In-Progress forever — Cursor Bugbot bc7876f1.
+            draft.savePreferencesState = { fetchState: 'Not-Started' };
+        },
+        fetchNotificationPreferencesSuccess(draft, action) {
+            // Piggybacks on the settings-envelope fetch. The GET response is a full
+            // snapshot of the server-known preferences (empty maps included), so
+            // REPLACE `preferences` rather than merging — merging would leak keys
+            // the server has since removed. DO NOT touch `localOverrides`: a refetch
+            // that fires while the user has in-flight edits (pre-debounce) must not
+            // silently drop them; the save-success path is the only clearer.
+            // A `null`/`undefined` payload isn't a snapshot at all (e.g. the
+            // envelope key was omitted); no-op instead of wiping preferences.
+            if (action.payload.preferences == null) {
+                return;
+            }
+            // Stale-GET guard (Cursor Bugbot 3632510237): if the fetch epic
+            // captured a `saveEpoch` lower than the current one, a save has
+            // succeeded since this GET dispatched — the response is carrying
+            // the pre-PUT snapshot and would clobber the just-saved server
+            // truth back to the pre-edit state until the next refetch. Skip
+            // the replace; the store already reflects the fresher save.
+            if (action.payload.saveEpochAtDispatch < draft.saveEpoch) {
+                return;
+            }
+            draft.preferences = (0, notificationPreferencesViewPayload_1.mapPayloadToPreferences)(action.payload.preferences);
+        },
+        saveNotificationPreferences(draft) {
+            draft.savePreferencesState = { fetchState: 'In-Progress' };
+        },
+        saveNotificationPreferencesFailure(draft, action) {
+            // Stale failure from a cancelled-since save — swallow silently so
+            // the UI doesn't surface an error banner for a save the user
+            // already abandoned.
+            if (action.payload.cancelEpochAtDispatch < draft.cancelEpoch) {
+                return;
+            }
+            // Preserve `localOverrides` so the user's in-flight edits survive a
+            // transient network blip. UI should surface an error affordance and
+            // allow retry.
+            draft.savePreferencesState = {
+                fetchState: 'Error',
+                error: action.payload.error,
+            };
+        },
+        saveNotificationPreferencesSuccess(draft, action) {
+            // Preserve-on-partial: PUT /preferences is patch-semantic. The response
+            // echoes only the fields that changed, so merge into `preferences`
+            // instead of replacing — otherwise a single-channel toggle would wipe
+            // every other stored preference.
+            //
+            // Rollback invariant (F5): `serverEcho` may be `undefined` if the server
+            // rolls back to an older shape that omits the echo entirely. In that
+            // case fall back to merging `savedOverrides` into `preferences` — the
+            // PUT succeeded (2xx), so the values we sent are now server truth. If
+            // we merged an empty patch instead, `subtractSavedOverrides` would
+            // still strip the just-saved keys from `localOverrides`, leaving the
+            // effective preferences (preferences ∪ localOverrides) reverted to the
+            // pre-edit server snapshot until the next refetch.
+            //
+            // In-flight-edit invariant: `savedOverrides` is the exact snapshot the
+            // epic PUT to the server. Subtracting those keys from `localOverrides`
+            // (instead of clearing it wholesale) preserves any edits the user
+            // added AFTER the debounce fired but BEFORE the response landed. The
+            // next debounce cycle will pick them up. Clearing wholesale drops
+            // in-flight edits from both UI (once server echo lands) and server.
+            // Cancel/in-flight-save race: `cancelEpoch` monotonically increases
+            // on every Cancel. If the save captured a lower epoch at dispatch,
+            // the user has pressed Cancel since — skip the `preferences` merge
+            // and the `localOverrides` subtract (Cancel already emptied it).
+            // Do NOT flip fetchState so a subsequent legit save can still show
+            // its own In-Progress → Completed lifecycle. The server itself has
+            // accepted the write — reverting server-side is out of FE scope; UI
+            // reflects the cancelled intention until the next refetch merges
+            // whatever the server persisted.
+            if (action.payload.cancelEpochAtDispatch < draft.cancelEpoch) {
+                return;
+            }
+            // Bump `saveEpoch` so any settings-envelope GET that was in flight
+            // BEFORE this PUT resolved is treated as stale. Its captured epoch
+            // will be lower than the new value, so its reducer branch will
+            // skip the `preferences` replace. Cursor Bugbot 3632510237.
+            draft.saveEpoch += 1;
+            draft.savePreferencesState = { fetchState: 'Completed' };
+            const patch = action.payload.serverEcho == null
+                ? action.payload.savedOverrides
+                : (0, notificationPreferencesViewPayload_1.mapPayloadToPreferences)(action.payload.serverEcho);
+            draft.preferences = mergePreferences(draft.preferences, patch);
+            draft.localOverrides = subtractSavedOverrides(draft.localOverrides, action.payload.savedOverrides);
+        },
+        setGroupFrequency(draft, action) {
+            draft.localOverrides.groupFrequencyByGroupId[action.payload.groupId] =
+                action.payload.frequency;
+        },
+        toggleEventChannel(draft, action) {
+            const { channel, enabled, eventId } = action.payload;
+            const eventMap = {
+                ...(draft.localOverrides.eventEnabledByChannel[eventId] ?? {}),
+            };
+            eventMap[channel] = enabled;
+            draft.localOverrides.eventEnabledByChannel[eventId] = eventMap;
+        },
+    },
+});
+_a = notificationPreferencesView.actions, exports.clearAllNotificationPreferencesView = _a.clearAllNotificationPreferencesView, exports.clearNotificationPreferencesLocalOverrides = _a.clearNotificationPreferencesLocalOverrides, exports.fetchNotificationPreferencesSuccess = _a.fetchNotificationPreferencesSuccess, exports.saveNotificationPreferences = _a.saveNotificationPreferences, exports.saveNotificationPreferencesFailure = _a.saveNotificationPreferencesFailure, exports.saveNotificationPreferencesSuccess = _a.saveNotificationPreferencesSuccess, exports.setGroupFrequency = _a.setGroupFrequency, exports.toggleEventChannel = _a.toggleEventChannel;
+exports.default = notificationPreferencesView.reducer;

package/lib/view/notificationPreferencesView/notificationPreferencesViewSelector.d.ts

@@ -0,0 +1,7 @@
+import { FetchStateAndError } from '../../commonStateTypes/common';
+import { RootState } from '../../reducer';
+import { NotificationPreferences } from './notificationPreferencesViewState';
+export declare const getNotificationPreferencesSaveState: (state: RootState) => FetchStateAndError;
+export declare const getEffectiveNotificationPreferences: (state: RootState) => NotificationPreferences;
+export declare const getNotificationLocalOverrides: (state: RootState) => NotificationPreferences;
+export declare const hasUnsavedNotificationPreferences: (state: RootState) => boolean;

package/lib/view/notificationPreferencesView/notificationPreferencesViewSelector.js

@@ -0,0 +1,32 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.hasUnsavedNotificationPreferences = exports.getNotificationLocalOverrides = exports.getEffectiveNotificationPreferences = exports.getNotificationPreferencesSaveState = void 0;
+const getView = (state) => state.notificationPreferencesViewState;
+const getNotificationPreferencesSaveState = (state) => getView(state).savePreferencesState;
+exports.getNotificationPreferencesSaveState = getNotificationPreferencesSaveState;
+const getEffectiveNotificationPreferences = (state) => {
+    const view = getView(state);
+    const mergedEventEnabledByChannel = { ...view.preferences.eventEnabledByChannel };
+    Object.entries(view.localOverrides.eventEnabledByChannel).forEach(([eventId, channels]) => {
+        mergedEventEnabledByChannel[eventId] = {
+            ...(view.preferences.eventEnabledByChannel[eventId] ?? {}),
+            ...channels,
+        };
+    });
+    return {
+        eventEnabledByChannel: mergedEventEnabledByChannel,
+        groupFrequencyByGroupId: {
+            ...view.preferences.groupFrequencyByGroupId,
+            ...view.localOverrides.groupFrequencyByGroupId,
+        },
+    };
+};
+exports.getEffectiveNotificationPreferences = getEffectiveNotificationPreferences;
+const getNotificationLocalOverrides = (state) => getView(state).localOverrides;
+exports.getNotificationLocalOverrides = getNotificationLocalOverrides;
+const hasUnsavedNotificationPreferences = (state) => {
+    const overrides = getView(state).localOverrides;
+    return (Object.keys(overrides.eventEnabledByChannel).length > 0 ||
+        Object.keys(overrides.groupFrequencyByGroupId).length > 0);
+};
+exports.hasUnsavedNotificationPreferences = hasUnsavedNotificationPreferences;

package/lib/view/notificationPreferencesView/notificationPreferencesViewState.d.ts

@@ -0,0 +1,14 @@
+import { FetchStateAndError } from '../../commonStateTypes/common';
+import { NotificationChannel, NotificationFrequency } from '../../entity/notificationRegistry/notificationRegistryState';
+export interface NotificationPreferences {
+    eventEnabledByChannel: Record<string, Partial<Record<NotificationChannel, boolean>>>;
+    groupFrequencyByGroupId: Record<string, NotificationFrequency>;
+}
+export interface NotificationPreferencesViewState {
+    cancelEpoch: number;
+    localOverrides: NotificationPreferences;
+    preferences: NotificationPreferences;
+    saveEpoch: number;
+    savePreferencesState: FetchStateAndError;
+}
+export declare const emptyNotificationPreferences: () => NotificationPreferences;

package/lib/view/notificationPreferencesView/notificationPreferencesViewState.js

@@ -0,0 +1,8 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.emptyNotificationPreferences = void 0;
+const emptyNotificationPreferences = () => ({
+    eventEnabledByChannel: {},
+    groupFrequencyByGroupId: {},
+});
+exports.emptyNotificationPreferences = emptyNotificationPreferences;

package/lib/view/recommendation/recommendationPayload.d.ts

@@ -12,37 +12,4 @@ interface FetchRecommendationPayloadWithCOT {
     recommendations: RecommendationPayloadWithCOT[];
 }
 export type FetchRecommendationResponseWithCOT = ZeniAPIResponse<FetchRecommendationPayloadWithCOT>;
-export type RecommendationFeedbackDimension = 'vendor' | 'category' | 'class';
-export type RecommendationFeedbackSource = 'primary' | 'alternate' | 'shadow' | 'qbo';
-export type RecommendationFeedbackOutcome = 'accepted' | 'override_ranked' | 'override_outside';
-export interface RecommendationFeedbackValue {
-    name: string;
-    id?: string | null;
-    integrationId?: string | null;
-}
-export interface ShownRecommendationForFeedback {
-    rank: number;
-    source: RecommendationFeedbackSource;
-    value: RecommendationFeedbackValue;
-    confidence?: number | null;
-    cot?: string[];
-    reasoning?: string | null;
-}
-export interface SubmitRecommendationFeedbackPayload {
-    dimension: RecommendationFeedbackDimension;
-    outcome: RecommendationFeedbackOutcome;
-    selected: RecommendationFeedbackValue & {
-        isNewEntity?: boolean;
-    };
-    transactionId: string;
-    features?: Record<string, unknown> | null;
-    lineId?: string | null;
-    matchedRank?: number | null;
-    matchedSource?: RecommendationFeedbackSource | null;
-    reasonText?: string | null;
-    recommendationSetId?: string | null;
-    shownRecommendations?: ShownRecommendationForFeedback[];
-    skipped?: boolean;
-    topPickSource?: RecommendationFeedbackSource | null;
-}
 export {};

package/lib/view/recommendation/recommendationReducer.d.ts

@@ -5,7 +5,6 @@ import { TransactionID } from '../../entity/transaction/stateTypes/transaction';
 import { SupportedTransaction } from '../../entity/transaction/transactionState';
 import { ZeniAPIStatus } from '../../responsePayload';
 import { TransactionsTab } from '../expenseAutomationView/types/transactionsViewState';
-import { SubmitRecommendationFeedbackPayload } from './recommendationPayload';
 import { EntityRecommendationState } from './recommendationState';
 export type RecommendationLineUpdateFlowType = 'categorization' | 'detail';
 type FetchEntityRecommendationsForLineUpdateCommonPayload = {
@@ -58,6 +57,6 @@ export declare const fetchEntityRecommendationsByTransactionId: import("@reduxjs
 }, "recommendation/updateRecommendationForEntityFailure">, indicateReadyToInitializeRecommendation: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[entityIdOrName: string, entityType: EntityType], {
     entityIdOrName: string;
     entityType: EntityType;
-}, "recommendation/indicateReadyToInitializeRecommendation", never, never>, clearRecommendation: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"recommendation/clearRecommendation">, submitRecommendationFeedback: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[args: SubmitRecommendationFeedbackPayload], SubmitRecommendationFeedbackPayload, "recommendation/submitRecommendationFeedback", never, never>;
+}, "recommendation/indicateReadyToInitializeRecommendation", never, never>, clearRecommendation: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"recommendation/clearRecommendation">;
 declare const _default: import("redux").Reducer<EntityRecommendationState>;
 export default _default;

package/lib/view/recommendation/recommendationReducer.js

@@ -1,7 +1,7 @@
 "use strict";
 var _a;
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.submitRecommendationFeedback = exports.clearRecommendation = exports.indicateReadyToInitializeRecommendation = exports.updateRecommendationForEntityFailure = exports.updateRecommendationForEntity = exports.fetchRecommendationByEntityId = exports.fetchRecommendationByEntityName = exports.fetchEntityRecommendationsForLineUpdate = exports.fetchEntityRecommendationsByTransactionId = exports.initialState = void 0;
+exports.clearRecommendation = exports.indicateReadyToInitializeRecommendation = exports.updateRecommendationForEntityFailure = exports.updateRecommendationForEntity = exports.fetchRecommendationByEntityId = exports.fetchRecommendationByEntityName = exports.fetchEntityRecommendationsForLineUpdate = exports.fetchEntityRecommendationsByTransactionId = exports.initialState = void 0;
 const toolkit_1 = require("@reduxjs/toolkit");
 const recommendationState_1 = require("./recommendationState");
 exports.initialState = {
@@ -137,25 +137,9 @@ const recommendation = (0, toolkit_1.createSlice)({
         clearRecommendation(draft) {
             Object.assign(draft, exports.initialState);
         },
-        // Fire-and-forget human feedback on a recommendation (accept, ranked
-        // override or outside override). Handled by submitRecommendationFeedbackEpic
-        // which POSTs to the accounting recommendation-feedback endpoint. No state
-        // mutation: the categorization UX must not depend on the feedback round-trip.
-        submitRecommendationFeedback: {
-            reducer(
-            // eslint-disable-next-line @typescript-eslint/no-unused-vars
-            _draft, 
-            // eslint-disable-next-line @typescript-eslint/no-unused-vars
-            _action) {
-                // do nothing
-            },
-            prepare(args) {
-                return { payload: args };
-            },
-        },
     },
 });
-_a = recommendation.actions, exports.fetchEntityRecommendationsByTransactionId = _a.fetchEntityRecommendationsByTransactionId, exports.fetchEntityRecommendationsForLineUpdate = _a.fetchEntityRecommendationsForLineUpdate, exports.fetchRecommendationByEntityName = _a.fetchRecommendationByEntityName, exports.fetchRecommendationByEntityId = _a.fetchRecommendationByEntityId, exports.updateRecommendationForEntity = _a.updateRecommendationForEntity, exports.updateRecommendationForEntityFailure = _a.updateRecommendationForEntityFailure, exports.indicateReadyToInitializeRecommendation = _a.indicateReadyToInitializeRecommendation, exports.clearRecommendation = _a.clearRecommendation, exports.submitRecommendationFeedback = _a.submitRecommendationFeedback;
+_a = recommendation.actions, exports.fetchEntityRecommendationsByTransactionId = _a.fetchEntityRecommendationsByTransactionId, exports.fetchEntityRecommendationsForLineUpdate = _a.fetchEntityRecommendationsForLineUpdate, exports.fetchRecommendationByEntityName = _a.fetchRecommendationByEntityName, exports.fetchRecommendationByEntityId = _a.fetchRecommendationByEntityId, exports.updateRecommendationForEntity = _a.updateRecommendationForEntity, exports.updateRecommendationForEntityFailure = _a.updateRecommendationForEntityFailure, exports.indicateReadyToInitializeRecommendation = _a.indicateReadyToInitializeRecommendation, exports.clearRecommendation = _a.clearRecommendation;
 exports.default = recommendation.reducer;
 const doUpdateRecommendationForEntity = (draft, entityId, entityType, payload) => {
     const key = (0, recommendationState_1.getEntityRecommendationKey)(entityType, entityId);

package/lib/view/settingsView/epic/fetchNotificationSettingsEpic.d.ts

@@ -1,8 +1,10 @@
 import { ActionsObservable, StateObservable } from 'redux-observable';
+import { updateNotificationRegistry } from '../../../entity/notificationRegistry/notificationRegistryReducer';
 import { RootState } from '../../../reducer';
 import { ZeniAPI } from '../../../zeniAPI';
+import { fetchNotificationPreferencesSuccess } from '../../notificationPreferencesView/notificationPreferencesViewReducer';
 import { fetchNotificationSettings, updateNotificationSettingsOnFailure, updateNotificationSettingsOnSuccess } from '../settingsViewReducer';
-export type ActionType = ReturnType<typeof fetchNotificationSettings> | ReturnType<typeof updateNotificationSettingsOnSuccess> | ReturnType<typeof updateNotificationSettingsOnFailure>;
+export type ActionType = ReturnType<typeof fetchNotificationSettings> | ReturnType<typeof updateNotificationSettingsOnSuccess> | ReturnType<typeof updateNotificationSettingsOnFailure> | ReturnType<typeof updateNotificationRegistry> | ReturnType<typeof fetchNotificationPreferencesSuccess>;
 export declare const fetchNotificationSettingsEpic: (actions$: ActionsObservable<ActionType>, state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => import("rxjs").Observable<{
     payload: undefined;
     type: "settings/fetchNotificationSettings";
@@ -15,4 +17,10 @@ export declare const fetchNotificationSettingsEpic: (actions$: ActionsObservable
 } | {
     payload: import("../../../responsePayload").ZeniAPIStatus<Record<string, unknown>>;
     type: "settings/updateNotificationSettingsOnFailure";
+} | {
+    payload: import("../../../entity/notificationRegistry/notificationRegistryPayload").NotificationRegistryPayload;
+    type: "notificationRegistry/updateNotificationRegistry";
+} | {
+    payload: import("../../notificationPreferencesView/notificationPreferencesViewReducer").FetchNotificationPreferencesSuccessPayload;
+    type: "notificationPreferencesView/fetchNotificationPreferencesSuccess";
 }>;

package/lib/view/settingsView/epic/fetchNotificationSettingsEpic.js

@@ -3,20 +3,39 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.fetchNotificationSettingsEpic = void 0;
 const rxjs_1 = require("rxjs");
 const operators_1 = require("rxjs/operators");
+const notificationRegistryReducer_1 = require("../../../entity/notificationRegistry/notificationRegistryReducer");
 const responsePayload_1 = require("../../../responsePayload");
+const notificationPreferencesEndpoint_1 = require("../../notificationPreferencesView/notificationPreferencesEndpoint");
+const notificationPreferencesViewReducer_1 = require("../../notificationPreferencesView/notificationPreferencesViewReducer");
 const settingsViewReducer_1 = require("../settingsViewReducer");
 const fetchNotificationSettingsEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(settingsViewReducer_1.fetchNotificationSettings.match), (0, operators_1.switchMap)(() => {
     const state = state$.value;
-    const URL = `${zeniAPI.apiEndPoints.notificationMicroServiceBaseUrl}/1.0/notification-preferences`;
     const userEmail = state.tenantState.loggedInUser?.userEmail;
     if (userEmail == null) {
         return (0, rxjs_1.from)([]);
     }
-    return zeniAPI.getJSON(URL).pipe((0, operators_1.mergeMap)((response) => {
+    // Snapshot the save epoch at GET-dispatch time. The reducer compares
+    // the captured value against the current `saveEpoch` on response and
+    // skips the `preferences` replace when a save has landed in the
+    // meantime — the GET is carrying the pre-PUT snapshot and would
+    // otherwise clobber the fresh save. Cursor Bugbot 3632510237.
+    const saveEpochAtDispatch = state.notificationPreferencesViewState.saveEpoch;
+    return zeniAPI
+        .getJSON((0, notificationPreferencesEndpoint_1.notificationPreferencesUrl)(zeniAPI))
+        .pipe((0, operators_1.mergeMap)((response) => {
         if ((0, responsePayload_1.isSuccessResponse)(response) && response.data != null) {
             const updateActions = [
                 (0, settingsViewReducer_1.updateNotificationSettingsOnSuccess)(response.data, userEmail),
             ];
+            if (response.data.task_checklist_registry != null) {
+                updateActions.push((0, notificationRegistryReducer_1.updateNotificationRegistry)(response.data.task_checklist_registry));
+            }
+            if (response.data.task_checklist_preferences != null) {
+                updateActions.push((0, notificationPreferencesViewReducer_1.fetchNotificationPreferencesSuccess)({
+                    preferences: response.data.task_checklist_preferences,
+                    saveEpochAtDispatch,
+                }));
+            }
             return (0, rxjs_1.of)(...updateActions);
         }
         else {

package/lib/view/settingsView/epic/saveNotificationSettingsEpic.js

@@ -5,9 +5,10 @@ const rxjs_1 = require("rxjs");
 const operators_1 = require("rxjs/operators");
 const snackbarReducer_1 = require("../../../entity/snackbar/snackbarReducer");
 const responsePayload_1 = require("../../../responsePayload");
+const notificationPreferencesEndpoint_1 = require("../../notificationPreferencesView/notificationPreferencesEndpoint");
 const settingsViewReducer_1 = require("../settingsViewReducer");
 const saveNotificationSettingsEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(settingsViewReducer_1.saveNotificationSettings.match), (0, operators_1.switchMap)(() => {
-    const URL = `${zeniAPI.apiEndPoints.notificationMicroServiceBaseUrl}/1.0/notification-preferences`;
+    const URL = (0, notificationPreferencesEndpoint_1.notificationPreferencesUrl)(zeniAPI);
     const { notificationSettings, notificationSettingsLocalData } = state$.value.settingsViewState.notification;
     const payload = toSaveNotificationSettingsPayload(notificationSettingsLocalData, notificationSettings);
     return zeniAPI

package/lib/view/settingsView/settingsViewHelpers.d.ts

@@ -14,4 +14,4 @@ export declare const isMyBankConnectionsTabVisible: (currentTenant: CurrentTenan
 export declare const isPerformanceTabVisible: (userRole: UserRoleType[], loggedInUser?: LoggedInUser) => boolean;
 export declare const isRemindersSectionVisibleOnSettingsPage: (reminderNotificationSettings: ReminderNotificationSettingsData) => boolean;
 export declare const isMonthEndNotificationsSectionVisibleOnSettingsPage: (monthEndInsightsNotificationSettings: MonthEndInsightsNotificationSettingsData, signedInUseEmail: string) => boolean;
-export declare const isNotificationsTabVisible: (notificationSettings: NotificationSettingsData, signedInUseEmail: string, isDebitCardFlagEnabled: boolean, currentTenant: CurrentTenant | undefined) => boolean;
+export declare const isNotificationsTabVisible: (notificationSettings: NotificationSettingsData, signedInUseEmail: string, isDebitCardFlagEnabled: boolean, currentTenant: CurrentTenant | undefined, hasTaskChecklistAccess: boolean) => boolean;

package/lib/view/settingsView/settingsViewHelpers.js

@@ -160,13 +160,14 @@ const isMonthEndNotificationsSectionVisibleOnSettingsPage = (monthEndInsightsNot
         monthEndInsightsNotificationSettings.recipientEmailIds.includes(signedInUseEmail));
 };
 exports.isMonthEndNotificationsSectionVisibleOnSettingsPage = isMonthEndNotificationsSectionVisibleOnSettingsPage;
-const isNotificationsTabVisible = (notificationSettings, signedInUseEmail, isDebitCardFlagEnabled, currentTenant) => {
+const isNotificationsTabVisible = (notificationSettings, signedInUseEmail, isDebitCardFlagEnabled, currentTenant, hasTaskChecklistAccess) => {
     if (currentTenant == null) {
         return false;
     }
     const { reminderNotificationSettings, monthEndInsightsNotificationSettings } = notificationSettings;
     return (((0, exports.isRemindersSectionVisibleOnSettingsPage)(reminderNotificationSettings) ||
-        (0, exports.isMonthEndNotificationsSectionVisibleOnSettingsPage)(monthEndInsightsNotificationSettings, signedInUseEmail)) &&
+        (0, exports.isMonthEndNotificationsSectionVisibleOnSettingsPage)(monthEndInsightsNotificationSettings, signedInUseEmail) ||
+        hasTaskChecklistAccess) &&
         ((0, tenantSelector_1.isTenantAccountingServicesEnabled)(currentTenant) ||
             ((0, tenantSelector_1.isTenantBankingOnly)(isDebitCardFlagEnabled, currentTenant) === false &&
                 (0, tenantSelector_1.isTenantCardsOnly)(currentTenant) === false)));

package/lib/view/settingsView/settingsViewPayload.d.ts

@@ -1,9 +1,11 @@
 import { AddressPayload } from '../../entity/address/addressPayload';
 import { CompanyPayload } from '../../entity/company/companyPayload';
+import { NotificationRegistryPayload } from '../../entity/notificationRegistry/notificationRegistryPayload';
 import { UserPayload } from '../../entity/user/userPayload';
 import { UserRolePayload } from '../../entity/userRole/userRolePayload';
 import { ZeniAPIResponse } from '../../responsePayload';
 import { AddressUpdatableInfoPayload } from '../addressView/addressViewPayload';
+import { NotificationPreferencesPayload } from '../notificationPreferencesView/notificationPreferencesViewPayload';
 interface MyProfilePeoplePayload {
     user_roles: UserRolePayload[];
     users: UserPayload[];
@@ -36,6 +38,8 @@ export interface NotificationSettingsPayload {
     pending_reimbursement_approval_notification: RemindersPayload | null;
     uncategorized_transaction_notification: RemindersPayload | null;
     month_end_email_recipient_email_ids?: string[];
+    task_checklist_preferences?: NotificationPreferencesPayload;
+    task_checklist_registry?: NotificationRegistryPayload;
 }
 export type NotificationSettingsResponse = ZeniAPIResponse<NotificationSettingsPayload>;
 interface RefreshQBOPayload {

package/lib/view/settingsView/settingsViewState.d.ts

@@ -12,7 +12,7 @@ export interface IntegrationsSettings {
 export declare const REMINDER_NOTIFICATION_TYPES: readonly ["missingReceiptNotification", "uncategorizedTransactionNotification", "pendingBillApprovalNotification", "pendingReimbursementApprovalNotification"];
 declare const toReminderTypeKey: (v: string) => "missingReceiptNotification" | "uncategorizedTransactionNotification" | "pendingBillApprovalNotification" | "pendingReimbursementApprovalNotification";
 export type ReminderTypeKey = ReturnType<typeof toReminderTypeKey>;
-export declare const toRemindersFrequencyType: (v: string) => "weekly" | "monthly" | "daily" | "bi-weekly";
+export declare const toRemindersFrequencyType: (v: string) => "daily" | "weekly" | "monthly" | "bi-weekly";
 export type FrequencyTypeKey = ReturnType<typeof toRemindersFrequencyType>;
 export declare const NOTIFICATION_MODES: readonly ["email", "dashboard"];
 export declare const toNotificationMode: (v: string) => "dashboard" | "email";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.1.60-beta0ND",
+  "version": "5.1.60-betaDI0",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",

package/lib/esm/view/recommendation/submitRecommendationFeedbackEpic.js

@@ -1,51 +0,0 @@
-import { EMPTY } from 'rxjs';
-import { catchError, filter, mergeMap } from 'rxjs/operators';
-import { isSuccessStatus } from '../../responsePayload';
-import { submitRecommendationFeedback } from './recommendationReducer';
-const toRequestBody = (payload) => ({
-    line_id: payload.lineId ?? null,
-    dimension: payload.dimension,
-    recommendation_set_id: payload.recommendationSetId ?? null,
-    top_pick_source: payload.topPickSource ?? null,
-    shown_recommendations: (payload.shownRecommendations ?? []).map((recommendation) => ({
-        source: recommendation.source,
-        rank: recommendation.rank,
-        value: {
-            name: recommendation.value.name,
-            id: recommendation.value.id ?? null,
-            integration_id: recommendation.value.integrationId ?? null,
-        },
-        confidence: recommendation.confidence ?? null,
-        reasoning: recommendation.reasoning ?? null,
-        cot: recommendation.cot ?? [],
-    })),
-    selected: {
-        name: payload.selected.name,
-        id: payload.selected.id ?? null,
-        integration_id: payload.selected.integrationId ?? null,
-        is_new_entity: payload.selected.isNewEntity ?? false,
-    },
-    matched_source: payload.matchedSource ?? null,
-    matched_rank: payload.matchedRank ?? null,
-    outcome: payload.outcome,
-    reason_text: payload.reasonText ?? null,
-    skipped: payload.skipped ?? false,
-    features: payload.features ?? null,
-});
-// Fire-and-forget: the epic never re-emits an action. Feedback delivery is a
-// side-effect that must not disrupt the categorization UX, so both the
-// success and error paths complete silently (errors are logged for debugging).
-export const submitRecommendationFeedbackEpic = (actions$, _state$, zeniAPI) => actions$.pipe(filter(submitRecommendationFeedback.match), mergeMap((action) => {
-    const { transactionId } = action.payload;
-    return zeniAPI
-        .postAndGetJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/transactions/${transactionId}/recommendation-feedback`, toRequestBody(action.payload))
-        .pipe(mergeMap((response) => {
-        if (!isSuccessStatus(response)) {
-            console.error('submitRecommendationFeedbackEpic: recommendation feedback was not recorded', response.status);
-        }
-        return EMPTY;
-    }), catchError((error) => {
-        console.error('submitRecommendationFeedbackEpic: failed to submit recommendation feedback', error);
-        return EMPTY;
-    }));
-}));

package/lib/view/recommendation/submitRecommendationFeedbackEpic.d.ts

@@ -1,7 +0,0 @@
-import { ActionsObservable, StateObservable } from 'redux-observable';
-import { Observable } from 'rxjs';
-import { RootState } from '../../reducer';
-import { ZeniAPI } from '../../zeniAPI';
-import { submitRecommendationFeedback } from './recommendationReducer';
-export type ActionType = ReturnType<typeof submitRecommendationFeedback>;
-export declare const submitRecommendationFeedbackEpic: (actions$: ActionsObservable<ActionType>, _state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => Observable<ActionType>;