@zeniai/client-epic-state 5.1.59 → 5.1.60-betaAK0

package/lib/esm/view/expenseAutomationView/epics/common/fetchAllExpenseAutomationTabsEpic.js

@@ -9,7 +9,7 @@ import { fetchMissingReceipts } from '../../reducers/missingReceiptsViewReducer'
 import { fetchReconciliation } from '../../reducers/reconciliationViewReducer';
 import { fetchTransactionCategorizationView } from '../../reducers/transactionsViewReducer';
 export const fetchAllExpenseAutomationTabsEpic = (actions$, state$) => actions$.pipe(filter(fetchAllExpenseAutomationTabs.match), switchMap((action) => {
-    const { cacheOverride, refreshViewInBackground, isUncategorizedExpenseCategoryEnabled, } = action.payload;
+    const { cacheOverride, refreshViewInBackground, } = action.payload;
     const state = state$.value;
     const { monthEndCloseChecksState } = state;
     const { monthEndCloseChecksByTenantId } = monthEndCloseChecksState;
@@ -30,7 +30,7 @@ export const fetchAllExpenseAutomationTabsEpic = (actions$, state$) => actions$.
     }
     if (cacheOverride === true) {
         const actions = [];
-        actions.push(fetchTransactionCategorizationView(selectedTransactionCategorizationTab, { start: timePeriodStart, end: timePeriodEnd }, cacheOverride, false, undefined, undefined, refreshViewInBackground, false, isUncategorizedExpenseCategoryEnabled), fetchMissingReceipts({ start: timePeriodStart, end: timePeriodEnd }, {
+        actions.push(fetchTransactionCategorizationView(selectedTransactionCategorizationTab, { start: timePeriodStart, end: timePeriodEnd }, cacheOverride, false, undefined, undefined, refreshViewInBackground, false), fetchMissingReceipts({ start: timePeriodStart, end: timePeriodEnd }, {
             amount: 75.0,
             currencyCode: 'USD',
             currencySymbol: '$',
@@ -83,7 +83,7 @@ export const fetchAllExpenseAutomationTabsEpic = (actions$, state$) => actions$.
             (state.expenseAutomationTransactionsViewState.transactionCategorizationView[selectedTransactionCategorizationTab].hasValidState() === false ||
                 state.expenseAutomationTransactionsViewState
                     .transactionCategorizationView[selectedTransactionCategorizationTab].transactionIdsBySelectedPeriod[monthYearPeriodId] == null)) {
-            fetchActions.push(fetchTransactionCategorizationView(selectedTransactionCategorizationTab, { start: timePeriodStart, end: timePeriodEnd }, cacheOverride, false, undefined, undefined, refreshViewInBackground, false, isUncategorizedExpenseCategoryEnabled));
+            fetchActions.push(fetchTransactionCategorizationView(selectedTransactionCategorizationTab, { start: timePeriodStart, end: timePeriodEnd }, cacheOverride, false, undefined, undefined, refreshViewInBackground, false));
         }
         return from(fetchActions);
     }

package/lib/esm/view/expenseAutomationView/epics/common/refreshExpenseAutomationCurrentTabEpic.js

@@ -9,8 +9,7 @@ import { fetchJeSchedulesPage } from '../../reducers/jeSchedulesViewReducer';
 import { fetchMissingReceipts } from '../../reducers/missingReceiptsViewReducer';
 import { fetchReconciliation } from '../../reducers/reconciliationViewReducer';
 import { fetchTransactionCategorizationView } from '../../reducers/transactionsViewReducer';
-export const refreshExpenseAutomationCurrentTabEpic = (actions$, state$) => actions$.pipe(filter(refreshExpenseAutomationCurrentTab.match), switchMap((action) => {
-    const { isUncategorizedExpenseCategoryEnabled } = action.payload;
+export const refreshExpenseAutomationCurrentTabEpic = (actions$, state$) => actions$.pipe(filter(refreshExpenseAutomationCurrentTab.match), switchMap(() => {
     const state = state$.value;
     const currentTenant = getCurrentTenant(state);
     const companyId = currentTenant.companyId;
@@ -63,7 +62,7 @@ export const refreshExpenseAutomationCurrentTabEpic = (actions$, state$) => acti
         case 'transaction_categorization':
         default:
             return from([
-                fetchTransactionCategorizationView(selectedTransactionCategorizationTab, { start: timePeriodStart, end: timePeriodEnd }, true, false, undefined, undefined, true, undefined, isUncategorizedExpenseCategoryEnabled),
+                fetchTransactionCategorizationView(selectedTransactionCategorizationTab, { start: timePeriodStart, end: timePeriodEnd }, true, false, undefined, undefined, true, undefined),
             ]);
     }
 }));

package/lib/esm/view/expenseAutomationView/epics/transactionCategorization/backgroundRefetchReviewTabEpic.js

@@ -10,7 +10,7 @@ import { toTransactionsSortKey } from '../../types/transactionsViewState';
 const SELECTED_TAB = 'review';
 const PAGE_SIZE = 25;
 export const backgroundRefetchReviewTabEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(backgroundRefetchReviewTab.match), switchMap((action) => {
-    const { period, isUncategorizedExpenseCategoryEnabled } = action.payload;
+    const { period } = action.payload;
     const state = state$.value;
     const currentTenant = getCurrentTenant(state);
     const selectedPeriod = state.expenseAutomationViewState.selectedPeriodByTenantId[currentTenant.tenantId];
@@ -80,7 +80,7 @@ export const backgroundRefetchReviewTabEpic = (actions$, state$, zeniAPI) => act
                     pageToken: accumulated.finalPageToken,
                 },
             }),
-            initializeTransactionCategorizationViewLocalData(SELECTED_TAB, transactionIds, selectedPeriod, false, accumulated.finalPageToken, accumulated.totalCount, lineItemsByTransactionIds, true, isUncategorizedExpenseCategoryEnabled),
+            initializeTransactionCategorizationViewLocalData(SELECTED_TAB, transactionIds, selectedPeriod, false, accumulated.finalPageToken, accumulated.totalCount, lineItemsByTransactionIds, true),
             updateTotalCountForTransactionCategorization({
                 selectedPeriod,
                 selectedTab: SELECTED_TAB,

package/lib/esm/view/expenseAutomationView/epics/transactionCategorization/fetchTransactionCategorizationEpic.js

@@ -14,7 +14,8 @@ export const fetchTransactionCategorizationEpic = (actions$, state$, zeniAPI) =>
 groupBy((action) => action.payload.selectedTab), mergeMap((group$) => group$.pipe(switchMap((action) => {
     const { expenseAutomationViewState: { selectedPeriodByTenantId }, expenseAutomationTransactionsViewState, } = state$.value;
     const { period, keepExistingListItems, selectedTab, refreshViewInBackground, } = action.payload;
-    const uiState = expenseAutomationTransactionsViewState.transactionCategorizationView[selectedTab].uiState;
+    const uiState = expenseAutomationTransactionsViewState
+        .transactionCategorizationView[selectedTab].uiState;
     const { pageToken, sortOrder, sortKey } = uiState;
     const requestSearchString = uiState.searchString;
     const currentTenant = getCurrentTenant(state$.value);
@@ -73,7 +74,7 @@ groupBy((action) => action.payload.selectedTab), mergeMap((group$) => group$.pip
                     pageToken: response.data.next_page_token ?? null,
                 },
             }));
-            updateActions.push(initializeTransactionCategorizationViewLocalData(selectedTab, transactionIds, selectedPeriod, keepExistingListItems, response.data.next_page_token ?? null, response.data.total_count, lineItemsByTransactionIds, refreshViewInBackground, action.payload.isUncategorizedExpenseCategoryEnabled));
+            updateActions.push(initializeTransactionCategorizationViewLocalData(selectedTab, transactionIds, selectedPeriod, keepExistingListItems, response.data.next_page_token ?? null, response.data.total_count, lineItemsByTransactionIds, refreshViewInBackground));
             updateActions.push(updateTotalCountForTransactionCategorization({
                 selectedPeriod,
                 selectedTab,

package/lib/esm/view/expenseAutomationView/epics/transactionCategorization/fetchTransactionCategorizationViewEpic.js

@@ -9,7 +9,7 @@ import { fetchProjectList } from '../../../projectList/projectListReducer';
 import { fetchTransactionCategorization, fetchTransactionCategorizationView, } from '../../reducers/transactionsViewReducer';
 import { TRANSACTIONS_TABS } from '../../types/transactionsViewState';
 export const fetchTransactionCategorizationViewEpic = (actions$, state$) => actions$.pipe(filter(fetchTransactionCategorizationView.match), mergeMap((action) => {
-    const { selectedTab, cacheOverride, keepExistingListItems, pageToken, period, refreshViewInBackground, searchString, resetListItems, isUncategorizedExpenseCategoryEnabled, } = action.payload;
+    const { selectedTab, cacheOverride, keepExistingListItems, pageToken, period, refreshViewInBackground, searchString, resetListItems, } = action.payload;
     const updateActions = [];
     const { expenseAutomationTransactionsViewState } = state$.value;
     const { fetchState, transactionIdsBySelectedPeriod, uiState } = expenseAutomationTransactionsViewState.transactionCategorizationView[selectedTab];
@@ -45,7 +45,7 @@ export const fetchTransactionCategorizationViewEpic = (actions$, state$) => acti
         fetchState === 'Not-Started' ||
         transactionIds.length === 0 ||
         uiState.searchString !== '') {
-        updateActions.push(fetchTransactionCategorization(selectedTab, period, cacheOverride, keepExistingListItems, searchString, pageToken, refreshViewInBackground, resetListItems, isUncategorizedExpenseCategoryEnabled));
+        updateActions.push(fetchTransactionCategorization(selectedTab, period, cacheOverride, keepExistingListItems, searchString, pageToken, refreshViewInBackground, resetListItems));
     }
     // On the initial load of a tab (searchString undefined = non-search fetch),
     // preload every other tab that hasn't been fetched yet for this period.
@@ -53,9 +53,10 @@ export const fetchTransactionCategorizationViewEpic = (actions$, state$) => acti
     // fresh fetch on click. refreshViewInBackground=true keeps it silent.
     if (searchString === undefined) {
         TRANSACTIONS_TABS.filter((tab) => tab !== selectedTab).forEach((otherTab) => {
-            const otherTabFetchState = expenseAutomationTransactionsViewState.transactionCategorizationView[otherTab].fetchState;
+            const otherTabFetchState = expenseAutomationTransactionsViewState
+                .transactionCategorizationView[otherTab].fetchState;
             if (otherTabFetchState === 'Not-Started') {
-                updateActions.push(fetchTransactionCategorization(otherTab, period, false, false, undefined, undefined, true, undefined, isUncategorizedExpenseCategoryEnabled));
+                updateActions.push(fetchTransactionCategorization(otherTab, period, false, false, undefined, undefined, true, undefined));
             }
         });
     }
@@ -66,9 +67,10 @@ export const fetchTransactionCategorizationViewEpic = (actions$, state$) => acti
     // if available; otherwise issue a background fetch.
     if (searchString !== undefined) {
         TRANSACTIONS_TABS.filter((tab) => tab !== selectedTab).forEach((otherTab) => {
-            const otherTabSearchString = expenseAutomationTransactionsViewState.transactionCategorizationView[otherTab].uiState.searchString;
+            const otherTabSearchString = expenseAutomationTransactionsViewState
+                .transactionCategorizationView[otherTab].uiState.searchString;
             if (searchString !== otherTabSearchString) {
-                updateActions.push(fetchTransactionCategorization(otherTab, period, true, keepExistingListItems, searchString, undefined, true, true, isUncategorizedExpenseCategoryEnabled));
+                updateActions.push(fetchTransactionCategorization(otherTab, period, true, keepExistingListItems, searchString, undefined, true, true));
             }
         });
     }

package/lib/esm/view/expenseAutomationView/epics/transactionCategorization/initializeTransactionCategorizationLocalDataEpic.js

@@ -2,12 +2,11 @@ import { from } from 'rxjs';
 import { filter, mergeMap } from 'rxjs/operators';
 import { getTransactionWithCOT } from '../../../../entity/transaction/transactionHelper';
 import { getSupportedTransactionsByIds } from '../../../../entity/transaction/transactionSelector';
-import { getUncategorizedAccounts } from '../../../accountList/accountListSelector';
 import { mergeTabSpecificLineItems, toTransactionDetailLocalData, } from '../../helpers/transactionCategorizationLocalDataHelper';
 import { initializeTransactionCategorizationViewLocalData, saveTransactionCategorizationLocalData, } from '../../reducers/transactionsViewReducer';
 import { initialSupportedTransactionCategorization, } from '../../types/transactionsViewState';
 export const initializeTransactionCategorizationViewLocalDataEpic = (actions$, state$) => actions$.pipe(filter(initializeTransactionCategorizationViewLocalData.match), mergeMap((action) => {
-    const { transactionIds, selectedPeriod, keepExistingListItems, selectedTab, pageToken, totalCount, lineItemsByTransactionIds, refreshViewInBackground, isUncategorizedExpenseCategoryEnabled, } = action.payload;
+    const { transactionIds, selectedPeriod, keepExistingListItems, selectedTab, pageToken, totalCount, lineItemsByTransactionIds, refreshViewInBackground, } = action.payload;
     const fetchActions = [];
     const { transactionState, expenseAutomationTransactionsViewState } = state$.value;
     const { transactionReviewLocalDataById } = expenseAutomationTransactionsViewState.transactionCategorizationView[selectedTab];
@@ -15,10 +14,9 @@ export const initializeTransactionCategorizationViewLocalDataEpic = (actions$, s
         ? { ...transactionReviewLocalDataById }
         : {};
     const transactions = getSupportedTransactionsByIds(transactionState, transactionIds);
-    const uncategorizedIncomeExpense = getUncategorizedAccounts(state$.value.accountState, state$.value.accountListState, 'accountList');
     transactions.forEach((transaction) => {
         const transactionWithCOT = getTransactionWithCOT(transaction);
-        const newTransactionsLocalData = toTransactionDetailLocalData(transactionWithCOT, selectedTab, lineItemsByTransactionIds[transaction.id], uncategorizedIncomeExpense, isUncategorizedExpenseCategoryEnabled);
+        const newTransactionsLocalData = toTransactionDetailLocalData(transactionWithCOT, selectedTab, lineItemsByTransactionIds[transaction.id]);
         if (transactionLocalData[transaction.id] == null) {
             transactionLocalData[transaction.id] = {
                 ...initialSupportedTransactionCategorization,

package/lib/esm/view/expenseAutomationView/epics/transactionCategorization/markTransactionAsNotMiscategorizedEpic.js

@@ -10,7 +10,7 @@ import { getSnackbarMessageForTransactionReview } from '../../helpers/transactio
 import { fetchTransactionCategorizationView, markTransactionAsNotMiscategorized, updateStatusForTransactionNotMiscategorizedUpdateForCategorization, updateTotalCountForTransactionCategorization, } from '../../reducers/transactionsViewReducer';
 export const markTransactionAsNotMiscategorizedEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(markTransactionAsNotMiscategorized.match), mergeMap((action) => {
     const { expenseAutomationViewState, expenseAutomationTransactionsViewState, } = state$.value;
-    const { transactionsInReview, selectedTab, isUncategorizedExpenseCategoryEnabled, } = action.payload;
+    const { transactionsInReview, selectedTab, } = action.payload;
     const transactionsSuccess = transactionsInReview.transactions_update_success;
     const transactionsFailed = transactionsInReview.transactions_update_failed;
     const currentTenant = getCurrentTenant(state$.value);
@@ -107,7 +107,7 @@ export const markTransactionAsNotMiscategorizedEpic = (actions$, state$, zeniAPI
                     if (timePeriodStart != null && timePeriodEnd != null) {
                         actions.push(fetchTransactionCategorizationView('review', { start: timePeriodStart, end: timePeriodEnd }, true, // cacheOverride = true to force refresh
                         false, undefined, undefined, true, // refreshViewInBackground
-                        false, isUncategorizedExpenseCategoryEnabled));
+                        false));
                     }
                 }
                 actions.push(updateTotalCountForTransactionCategorization({

package/lib/esm/view/expenseAutomationView/epics/transactionCategorization/saveTransactionCategorizationEpic.js

@@ -6,7 +6,7 @@ import { getUncategorizedAccounts } from '../../../accountList/accountListSelect
 import { toTransactionUpdatesFromTransactionCategorizationLocalData } from '../../helpers/saveTransactionHelper';
 import { saveTransactionCategorization, updateTransactionCategorization, } from '../../reducers/transactionsViewReducer';
 export const saveTransactionCategorizationEpic = (actions$, state$) => actions$.pipe(filter(saveTransactionCategorization.match), mergeMap((action) => {
-    const { transactionIds, cotTrackingByTransactionId, selectedTab, isUncategorizedExpenseCategoryEnabled, } = action.payload;
+    const { transactionIds, cotTrackingByTransactionId, selectedTab, } = action.payload;
     const fetchActions = [];
     const { transactionState, expenseAutomationTransactionsViewState } = state$.value;
     const transactionSaveUpdates = [];
@@ -19,6 +19,6 @@ export const saveTransactionCategorizationEpic = (actions$, state$) => actions$.
             transactionSaveUpdates.push(toTransactionUpdatesFromTransactionCategorizationLocalData(localData, transaction, uncategorizedIncomeExpense));
         }
     });
-    fetchActions.push(updateTransactionCategorization(selectedTab, transactionIds, transactionSaveUpdates, cotTrackingByTransactionId, isUncategorizedExpenseCategoryEnabled));
+    fetchActions.push(updateTransactionCategorization(selectedTab, transactionIds, transactionSaveUpdates, cotTrackingByTransactionId));
     return from(fetchActions);
 }));

package/lib/esm/view/expenseAutomationView/epics/transactionCategorization/triggerReviewTabRefetchEpic.js

@@ -4,7 +4,7 @@ import { convertToPeriod, toAbsoluteDay, } from '../../../../commonStateTypes/ti
 import { getCurrentTenant } from '../../../../entity/tenant/tenantSelector';
 import { backgroundRefetchReviewTab, syncTransactionCategorizationFromDetailSave, } from '../../reducers/transactionsViewReducer';
 export const triggerReviewTabRefetchEpic = (actions$, state$) => actions$.pipe(filter(syncTransactionCategorizationFromDetailSave.match), mergeMap((action) => {
-    const { pendingReviewLineIds, transactionId, isUncategorizedExpenseCategoryEnabled, } = action.payload;
+    const { pendingReviewLineIds, transactionId, } = action.payload;
     if (pendingReviewLineIds.length === 0) {
         return EMPTY;
     }
@@ -23,5 +23,5 @@ export const triggerReviewTabRefetchEpic = (actions$, state$) => actions$.pipe(f
     if (timePeriodStart == null || timePeriodEnd == null) {
         return EMPTY;
     }
-    return of(backgroundRefetchReviewTab({ start: timePeriodStart, end: timePeriodEnd }, isUncategorizedExpenseCategoryEnabled));
+    return of(backgroundRefetchReviewTab({ start: timePeriodStart, end: timePeriodEnd }));
 }));

package/lib/esm/view/expenseAutomationView/epics/transactionCategorization/updateTransactionCategorizationEpic.js

@@ -15,7 +15,7 @@ import { getVendorByVendorId } from '../../../../entity/vendor/vendorSelector';
 import { createZeniAPIStatus, isSuccessResponse, } from '../../../../responsePayload';
 import { markTransactionAsNotMiscategorized, updateTransactionCategorization, updateTransactionCategorizationSaveStatus, } from '../../reducers/transactionsViewReducer';
 export const updateTransactionCategorizationEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(updateTransactionCategorization.match), mergeMap((action) => {
-    const { selectedTab, transactionIds, transactionSaveUpdates, cotTrackingByTransactionId, isUncategorizedExpenseCategoryEnabled, } = action.payload;
+    const { selectedTab, transactionIds, transactionSaveUpdates, cotTrackingByTransactionId, } = action.payload;
     const { transactionState, vendorState, expenseAutomationTransactionsViewState, } = state$.value;
     const payloadArray = preparePayload(selectedTab, transactionState, vendorState, expenseAutomationTransactionsViewState, transactionIds, transactionSaveUpdates, cotTrackingByTransactionId).filter((payload) => payload != null);
     return zeniAPI
@@ -24,7 +24,7 @@ export const updateTransactionCategorizationEpic = (actions$, state$, zeniAPI) =
         if (isSuccessResponse(response) && response.data != null) {
             const transactionsInReview = response.data;
             const actions = [];
-            actions.push(markTransactionAsNotMiscategorized(selectedTab, transactionsInReview, isUncategorizedExpenseCategoryEnabled), updateTransactionCategorizationSaveStatus(selectedTab, 'Completed', createZeniAPIStatus('Completed', 'Transaction categorization updated successfully')));
+            actions.push(markTransactionAsNotMiscategorized(selectedTab, transactionsInReview), updateTransactionCategorizationSaveStatus(selectedTab, 'Completed', createZeniAPIStatus('Completed', 'Transaction categorization updated successfully')));
             return from(actions);
         }
         else {

package/lib/esm/view/expenseAutomationView/expenseAutomationViewReducer.js

@@ -18,20 +18,19 @@ const expenseAutomationView = createSlice({
             reducer() {
                 //do nothing
             },
-            prepare(cacheOverride = false, refreshViewInBackground = false, isUncategorizedExpenseCategoryEnabled = false) {
+            prepare(cacheOverride = false, refreshViewInBackground = false) {
                 return {
                     payload: {
                         cacheOverride,
                         refreshViewInBackground,
-                        isUncategorizedExpenseCategoryEnabled,
                     },
                 };
             },
         },
         refreshExpenseAutomationCurrentTab: {
-            prepare(isUncategorizedExpenseCategoryEnabled) {
+            prepare() {
                 return {
-                    payload: { isUncategorizedExpenseCategoryEnabled },
+                    payload: {},
                 };
             },
             reducer() {

package/lib/esm/view/expenseAutomationView/helpers/transactionCategorizationLocalDataHelper.js

@@ -66,16 +66,16 @@ export const MAX_SELECTION_LIMIT = 5;
 // triplet that was inlined at four sites (updateSelectedCustomer/Vendor,
 // setAllItemsToCategoryClassInLocalDataForCategorization, and
 // setEntityRecommendationForLineIdInLocalData below).
-export const shouldAutoSelectAndAdd = (transaction, localData, selectedCheckBoxTransactionIds, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled) => {
+export const shouldAutoSelectAndAdd = (transaction, localData, selectedCheckBoxTransactionIds, isAccountingClassesEnabled) => {
     if (selectedCheckBoxTransactionIds.includes(transaction.id)) {
         return false;
     }
     if (selectedCheckBoxTransactionIds.length >= MAX_SELECTION_LIMIT) {
         return false;
     }
-    return checkIfAllLineItemsAreCategoryClassFilled(transaction, localData, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled);
+    return checkIfAllLineItemsAreCategoryClassFilled(transaction, localData, isAccountingClassesEnabled);
 };
-export const toTransactionDetailLocalData = (transaction, selectedTab, lineItemsByTransactionIds, uncategorizedIncomeExpense, isUncategorizedExpenseCategoryEnabled) => {
+export const toTransactionDetailLocalData = (transaction, selectedTab, lineItemsByTransactionIds) => {
     const transactionLocal = {
         ...initialSupportedTransactionCategorization.transactionReviewLocalData,
     };
@@ -162,7 +162,7 @@ export const toTransactionDetailLocalData = (transaction, selectedTab, lineItems
     }
     transactionLocal.lineItemById =
         transaction.lines != null && transaction.lines.length > 0
-            ? buildLineItemById(transaction, uncategorizedIncomeExpense, transaction.recommendationsWithCOT, isUncategorizedExpenseCategoryEnabled)
+            ? buildLineItemById(transaction, transaction.recommendationsWithCOT)
             : {};
     transactionLocal.sortedLineItems =
         transaction.lines != null && transaction.lines.length > 0
@@ -177,7 +177,7 @@ export const toTransactionDetailLocalData = (transaction, selectedTab, lineItems
     };
     return transactionLocal;
 };
-const buildLineItemById = (transaction, uncategorizedIncomeExpense, recommendations, isUncategorizedExpenseCategoryEnabled) => {
+const buildLineItemById = (transaction, recommendations) => {
     const lineItemData = {};
     const { lines } = transaction;
     lines?.forEach((line) => {
@@ -241,10 +241,7 @@ const buildLineItemById = (transaction, uncategorizedIncomeExpense, recommendati
             if (recommendations != null) {
                 record.recommendationsWithCOT = recommendations[lineId];
                 const higherPreferenceRecommendation = recommendations[lineId]?.[0];
-                if ((Boolean(accountLine.account.accountId) === false ||
-                    isAccountUncategorized(uncategorizedIncomeExpense, accountLine.account.qboId, isUncategorizedExpenseCategoryEnabled === true
-                        ? ['income']
-                        : undefined)) &&
+                if (Boolean(accountLine.account.accountId) === false &&
                     higherPreferenceRecommendation?.account != null) {
                     record.account = {
                         ...higherPreferenceRecommendation.account,
@@ -322,7 +319,7 @@ const buildLineItemById = (transaction, uncategorizedIncomeExpense, recommendati
     });
     return lineItemData;
 };
-export const toSetAllLineItemsToCategoryClass = (draft, transaction, transactionId, transactionLineId, transactionDetailLocalData, updatedItem, uncategorizedAccounts, selectedTab, vendorId, customerId, selectedAccount, selectedClassBase, selectedProjectBase, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled) => {
+export const toSetAllLineItemsToCategoryClass = (draft, transaction, transactionId, transactionLineId, transactionDetailLocalData, updatedItem, selectedTab, vendorId, customerId, selectedAccount, selectedClassBase, selectedProjectBase, isAccountingClassesEnabled) => {
     let newLineItems = {};
     let selectedCheckBoxTransactionIds = draft.selectedCheckBoxTransactionIds;
     let similarTransactionUpdated = false;
@@ -379,10 +376,7 @@ export const toSetAllLineItemsToCategoryClass = (draft, transaction, transaction
                             // if the vendor is same, then set the account and class with the selected ones and add the transaction to the selected list
                             if (selectedAccount != null &&
                                 updatedItem === 'category' &&
-                                (record.account?.qboId == null ||
-                                    isAccountUncategorized(uncategorizedAccounts, record.account?.qboId, isUncategorizedExpenseCategoryEnabled === true
-                                        ? ['income']
-                                        : undefined) === true)) {
+                                record.account?.qboId == null) {
                                 record.account = selectedAccount;
                                 similarTransactionUpdated = true;
                                 if ((isAccountingClassesEnabled === false ||
@@ -451,13 +445,13 @@ export const toSetAllLineItemsToCategoryClass = (draft, transaction, transaction
         selectedEntity: transactionDetailLocalData.selectedEntity,
         tabSpecificLineItems: transactionDetailLocalData.tabSpecificLineItems,
     };
-    if (!checkIfAllLineItemsAreCategoryClassFilled(transaction, newLocalData, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled)) {
+    if (!checkIfAllLineItemsAreCategoryClassFilled(transaction, newLocalData, isAccountingClassesEnabled)) {
         selectedCheckBoxTransactionIds = selectedCheckBoxTransactionIds.filter((id) => id !== transaction.id);
     }
     draft.selectedCheckBoxTransactionIds = selectedCheckBoxTransactionIds;
     return { localData: newLocalData, similarTransactionUpdated };
 };
-export const setEntityRecommendationForLineIdInLocalData = (draft, transaction, transactionDetailLocalData, entity, recommendationLineIds, uncategorizedAccounts, recommendationWithCOTByLineId, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled) => {
+export const setEntityRecommendationForLineIdInLocalData = (draft, transaction, transactionDetailLocalData, entity, recommendationLineIds, recommendationWithCOTByLineId, isAccountingClassesEnabled) => {
     const newLineItems = {};
     let matchingEntityLineId = undefined;
     const checkIfNotJEAndDeposit = !isVendorTransaction(transaction);
@@ -477,11 +471,8 @@ export const setEntityRecommendationForLineIdInLocalData = (draft, transaction,
                     };
                     const recommendations = mergeTransactionAndEntityRecommendationsWithCOT(oldRecord.recommendationsWithCOT, recommendationWithCOTByLineId?.[lineId]);
                     const accountLine = line;
-                    const isUncategorizedAccount = isAccountUncategorized(uncategorizedAccounts, accountLine.account.qboId, isUncategorizedExpenseCategoryEnabled === true
-                        ? ['income']
-                        : undefined);
                     record.account =
-                        isUncategorizedAccount === false && accountLine.account.qboId !== ''
+                        accountLine.account.qboId !== ''
                             ? accountLine.account
                             : recommendations?.[0]?.account
                                 ? {
@@ -564,23 +555,21 @@ export const setEntityRecommendationForLineIdInLocalData = (draft, transaction,
     // category/class became stale after the entity update). Otherwise
     // route through shouldAutoSelectAndAdd so the MAX_SELECTION_LIMIT
     // gate is consistently applied across all auto-add sites.
-    if (!checkIfAllLineItemsAreCategoryClassFilled(transaction, newLocalData, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled)) {
+    if (!checkIfAllLineItemsAreCategoryClassFilled(transaction, newLocalData, isAccountingClassesEnabled)) {
         selectedCheckBoxTransactionIds = selectedCheckBoxTransactionIds.filter((id) => id !== transaction.id);
     }
-    else if (shouldAutoSelectAndAdd(transaction, newLocalData, selectedCheckBoxTransactionIds, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled)) {
+    else if (shouldAutoSelectAndAdd(transaction, newLocalData, selectedCheckBoxTransactionIds, isAccountingClassesEnabled)) {
         selectedCheckBoxTransactionIds.push(transaction.id);
     }
     draft.selectedCheckBoxTransactionIds = selectedCheckBoxTransactionIds;
     return newLocalData;
 };
-export const checkIfAllLineItemsAreCategoryClassFilled = (transaction, transactionDetailLocalData, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled) => {
+export const checkIfAllLineItemsAreCategoryClassFilled = (transaction, transactionDetailLocalData, isAccountingClassesEnabled) => {
     const lineItems = Object.values(transactionDetailLocalData.lineItemById);
     const isVendorTransactionAvailable = isVendorTransaction(transaction);
-    const uncategorizedAccountTypes = isUncategorizedExpenseCategoryEnabled === true ? ['income'] : undefined;
     return lineItems.every((lineItem) => Boolean(lineItem?.account?.qboId) &&
         (isAccountingClassesEnabled === false ||
             Boolean(lineItem?.class?.qboId)) &&
-        isAccountUncategorized(uncategorizedAccounts, lineItem?.account?.qboId, uncategorizedAccountTypes) === false &&
         ((isVendorTransactionAvailable
             ? Boolean(transactionDetailLocalData?.vendor?.id)
             : Boolean(lineItem?.vendor?.id)) ||

package/lib/esm/view/expenseAutomationView/reducers/transactionsViewReducer.js

@@ -121,7 +121,7 @@ const expenseAutomationTransactionsView = createSlice({
     reducers: {
         fetchTransactionCategorizationView: {
             prepare(selectedTab, period, cacheOverride = false, keepExistingListItems = false, searchString, // when this is defined the output should go to search result IDs
-            pageToken, refreshViewInBackground = false, resetListItems = false, isUncategorizedExpenseCategoryEnabled) {
+            pageToken, refreshViewInBackground = false, resetListItems = false) {
                 return {
                     payload: {
                         selectedTab,
@@ -132,7 +132,6 @@ const expenseAutomationTransactionsView = createSlice({
                         cacheOverride,
                         refreshViewInBackground,
                         resetListItems,
-                        isUncategorizedExpenseCategoryEnabled,
                     },
                 };
             },
@@ -200,7 +199,7 @@ const expenseAutomationTransactionsView = createSlice({
                 }
             },
             prepare(selectedTab, period, cacheOverride = false, keepExistingListItems = false, searchString, // when this is defined the output should go to search result IDs
-            pageToken, refreshViewInBackground = false, resetListItems, isUncategorizedExpenseCategoryEnabled) {
+            pageToken, refreshViewInBackground = false, resetListItems) {
                 return {
                     payload: {
                         selectedTab,
@@ -211,13 +210,12 @@ const expenseAutomationTransactionsView = createSlice({
                         cacheOverride,
                         refreshViewInBackground,
                         resetListItems,
-                        isUncategorizedExpenseCategoryEnabled,
                     },
                 };
             },
         },
         initializeTransactionCategorizationViewLocalData: {
-            prepare(selectedTab, transactionIds, selectedPeriod, keepExistingListItems = false, pageToken, totalCount, lineItemsByTransactionIds, refreshViewInBackground = false, isUncategorizedExpenseCategoryEnabled) {
+            prepare(selectedTab, transactionIds, selectedPeriod, keepExistingListItems = false, pageToken, totalCount, lineItemsByTransactionIds, refreshViewInBackground = false) {
                 return {
                     payload: {
                         selectedTab,
@@ -228,7 +226,6 @@ const expenseAutomationTransactionsView = createSlice({
                         totalCount,
                         lineItemsByTransactionIds,
                         refreshViewInBackground,
-                        isUncategorizedExpenseCategoryEnabled,
                     },
                 };
             },
@@ -332,13 +329,12 @@ const expenseAutomationTransactionsView = createSlice({
             });
         },
         saveTransactionCategorization: {
-            prepare(selectedTab, transactionIds, cotTrackingByTransactionId, isUncategorizedExpenseCategoryEnabled) {
+            prepare(selectedTab, transactionIds, cotTrackingByTransactionId) {
                 return {
                     payload: {
                         selectedTab,
                         transactionIds,
                         cotTrackingByTransactionId,
-                        isUncategorizedExpenseCategoryEnabled,
                     },
                 };
             },
@@ -412,21 +408,20 @@ const expenseAutomationTransactionsView = createSlice({
                     fetchState: 'In-Progress',
                 };
             },
-            prepare(selectedTab, transactionIds, transactionSaveUpdates, cotTrackingByTransactionId, isUncategorizedExpenseCategoryEnabled) {
+            prepare(selectedTab, transactionIds, transactionSaveUpdates, cotTrackingByTransactionId) {
                 return {
                     payload: {
                         selectedTab,
                         transactionIds,
                         transactionSaveUpdates,
                         cotTrackingByTransactionId,
-                        isUncategorizedExpenseCategoryEnabled,
                     },
                 };
             },
         },
         setAllItemsToCategoryClassInLocalDataForCategorization: {
             reducer(draft, action) {
-                const { vendorId, customerId, selectedAccount, selectedClassBase, selectedProjectBase, transactions, transactionId, lineId, selectedTab, uncategorizedAccounts, isAccountingClassesEnabled, isUncategorizedExpenseCategoryEnabled, } = action.payload;
+                const { vendorId, customerId, selectedAccount, selectedClassBase, selectedProjectBase, transactions, transactionId, lineId, selectedTab, isAccountingClassesEnabled, } = action.payload;
                 const transactionLocalData = recordGet(draft.transactionCategorizationView[selectedTab]
                     .transactionReviewLocalDataById, transactionId, undefined);
                 const existingAccount = transactionLocalData?.transactionReviewLocalData.lineItemById[lineId]
@@ -452,7 +447,7 @@ const expenseAutomationTransactionsView = createSlice({
                     const selectedCheckBoxTransactionIds = draft.transactionCategorizationView[selectedTab]
                         .selectedCheckBoxTransactionIds;
                     if (selectedTransaction != null &&
-                        shouldAutoSelectAndAdd(selectedTransaction, newTransactionLocalData, selectedCheckBoxTransactionIds, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled)) {
+                        shouldAutoSelectAndAdd(selectedTransaction, newTransactionLocalData, selectedCheckBoxTransactionIds, isAccountingClassesEnabled)) {
                         draft.transactionCategorizationView[selectedTab].selectedCheckBoxTransactionIds = [
                             ...selectedCheckBoxTransactionIds,
                             transactionId,
@@ -475,7 +470,7 @@ const expenseAutomationTransactionsView = createSlice({
                                     : existingProjectId !== selectedProjectBase?.projectId
                                         ? 'project'
                                         : 'class';
-                            const { localData, similarTransactionUpdated } = toSetAllLineItemsToCategoryClass(draft.transactionCategorizationView[selectedTab], transaction, transactionId, lineId, transactionLocalData.transactionReviewLocalData, updatedItem, uncategorizedAccounts, selectedTab, vendorId, customerId, selectedAccount, selectedClassBase, selectedProjectBase, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled);
+                            const { localData, similarTransactionUpdated } = toSetAllLineItemsToCategoryClass(draft.transactionCategorizationView[selectedTab], transaction, transactionId, lineId, transactionLocalData.transactionReviewLocalData, updatedItem, selectedTab, vendorId, customerId, selectedAccount, selectedClassBase, selectedProjectBase, isAccountingClassesEnabled);
                             draft.transactionCategorizationView[selectedTab].transactionReviewLocalDataById[transaction.id] = {
                                 transactionId: transaction.id,
                                 transactionReviewLocalData: localData,
@@ -494,7 +489,7 @@ const expenseAutomationTransactionsView = createSlice({
                     ...dirtyIds,
                 ]);
             },
-            prepare(selectedTab, transactionId, lineId, transactions, uncategorizedAccounts, vendorId, customerId, selectedAccount, selectedClassBase, lineEntity, recommendations, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled, selectedProjectBase) {
+            prepare(selectedTab, transactionId, lineId, transactions, uncategorizedAccounts, vendorId, customerId, selectedAccount, selectedClassBase, lineEntity, recommendations, isAccountingClassesEnabled, selectedProjectBase) {
                 return {
                     payload: {
                         selectedTab,
@@ -510,13 +505,12 @@ const expenseAutomationTransactionsView = createSlice({
                         recommendations,
                         uncategorizedAccounts,
                         isAccountingClassesEnabled,
-                        isUncategorizedExpenseCategoryEnabled,
                     },
                 };
             },
         },
         setEntityRecommendationForLineIdsForCategorization: {
-            prepare(selectedTab, transactionId, transaction, lineIds, entity, amount, recommendationWithCOTByLineId, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled) {
+            prepare(selectedTab, transactionId, transaction, lineIds, entity, amount, recommendationWithCOTByLineId, uncategorizedAccounts, isAccountingClassesEnabled) {
                 return {
                     payload: {
                         selectedTab,
@@ -528,16 +522,15 @@ const expenseAutomationTransactionsView = createSlice({
                         recommendationWithCOTByLineId,
                         uncategorizedAccounts,
                         isAccountingClassesEnabled,
-                        isUncategorizedExpenseCategoryEnabled,
                     },
                 };
             },
             reducer(draft, action) {
-                const { entity, transaction, transactionId, selectedTab, lineIds, uncategorizedAccounts, isAccountingClassesEnabled, isUncategorizedExpenseCategoryEnabled, } = action.payload;
+                const { entity, transaction, transactionId, selectedTab, lineIds, isAccountingClassesEnabled, } = action.payload;
                 const transactionLocalData = recordGet(draft.transactionCategorizationView[selectedTab]
                     .transactionReviewLocalDataById, transactionId.id, undefined);
                 if (transactionLocalData != null) {
-                    const newLocalData = setEntityRecommendationForLineIdInLocalData(draft.transactionCategorizationView[selectedTab], transaction, transactionLocalData.transactionReviewLocalData, entity, lineIds, uncategorizedAccounts, action.payload.recommendationWithCOTByLineId, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled);
+                    const newLocalData = setEntityRecommendationForLineIdInLocalData(draft.transactionCategorizationView[selectedTab], transaction, transactionLocalData.transactionReviewLocalData, entity, lineIds, action.payload.recommendationWithCOTByLineId, isAccountingClassesEnabled);
                     // Release the per-line fetch flag for every line this fetch
                     // covered. Done in-place on the freshly returned local data
                     // (the helper produces a new mutable object), before we write
@@ -710,7 +703,7 @@ const expenseAutomationTransactionsView = createSlice({
                 action.payload.status;
         },
         updateSelectedCustomerForTransaction(draft, action) {
-            const { transactionId, lineId, updatedCustomer, selectedTransaction, selectedTab, uncategorizedAccounts, isAccountingClassesEnabled, isUncategorizedExpenseCategoryEnabled, } = action.payload;
+            const { transactionId, lineId, updatedCustomer, selectedTransaction, selectedTab, isAccountingClassesEnabled, } = action.payload;
             const transactionLocalData = recordGet(draft.transactionCategorizationView[selectedTab]
                 .transactionReviewLocalDataById, transactionId, undefined);
             if (transactionLocalData != null) {
@@ -763,7 +756,7 @@ const expenseAutomationTransactionsView = createSlice({
                     .selectedCheckBoxTransactionIds;
                 if (newTransactionLocalData.customer != null &&
                     newTransactionLocalData.customer.id != null &&
-                    shouldAutoSelectAndAdd(selectedTransaction, newTransactionLocalData, selectedCheckBoxTransactionIds, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled)) {
+                    shouldAutoSelectAndAdd(selectedTransaction, newTransactionLocalData, selectedCheckBoxTransactionIds, isAccountingClassesEnabled)) {
                     draft.transactionCategorizationView[selectedTab].selectedCheckBoxTransactionIds = [
                         ...selectedCheckBoxTransactionIds,
                         transactionId,
@@ -780,7 +773,7 @@ const expenseAutomationTransactionsView = createSlice({
             }
         },
         updateSelectedVendorForTransaction(draft, action) {
-            const { transactionId, lineId, updatedVendor, selectedTransaction, selectedTab, uncategorizedAccounts, isAccountingClassesEnabled, isUncategorizedExpenseCategoryEnabled, } = action.payload;
+            const { transactionId, lineId, updatedVendor, selectedTransaction, selectedTab, isAccountingClassesEnabled, } = action.payload;
             const transactionLocalData = recordGet(draft.transactionCategorizationView[selectedTab]
                 .transactionReviewLocalDataById, transactionId, undefined);
             if (transactionLocalData != null) {
@@ -837,7 +830,7 @@ const expenseAutomationTransactionsView = createSlice({
                     .selectedCheckBoxTransactionIds;
                 if (newTransactionLocalData.vendor != null &&
                     newTransactionLocalData.vendor.id != null &&
-                    shouldAutoSelectAndAdd(selectedTransaction, newTransactionLocalData, selectedCheckBoxTransactionIds, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled)) {
+                    shouldAutoSelectAndAdd(selectedTransaction, newTransactionLocalData, selectedCheckBoxTransactionIds, isAccountingClassesEnabled)) {
                     draft.transactionCategorizationView[selectedTab].selectedCheckBoxTransactionIds = [
                         ...selectedCheckBoxTransactionIds,
                         transactionId,
@@ -885,12 +878,11 @@ const expenseAutomationTransactionsView = createSlice({
                     error: undefined,
                 };
             },
-            prepare(selectedTab, transactionsInReview, isUncategorizedExpenseCategoryEnabled) {
+            prepare(selectedTab, transactionsInReview) {
                 return {
                     payload: {
                         selectedTab,
                         transactionsInReview,
-                        isUncategorizedExpenseCategoryEnabled,
                     },
                 };
             },
@@ -1000,19 +992,17 @@ const expenseAutomationTransactionsView = createSlice({
             },
         },
         syncTransactionCategorizationFromDetailSave: {
-            prepare(transactionId, updatedTransaction, pendingReviewLineIds, uncategorizedIncomeExpense, isUncategorizedExpenseCategoryEnabled) {
+            prepare(transactionId, updatedTransaction, pendingReviewLineIds) {
                 return {
                     payload: {
                         transactionId,
                         updatedTransaction,
                         pendingReviewLineIds,
-                        uncategorizedIncomeExpense,
-                        isUncategorizedExpenseCategoryEnabled,
                     },
                 };
             },
             reducer(draft, action) {
-                const { transactionId, updatedTransaction, pendingReviewLineIds, uncategorizedIncomeExpense, isUncategorizedExpenseCategoryEnabled, } = action.payload;
+                const { transactionId, updatedTransaction, pendingReviewLineIds, } = action.payload;
                 const txnId = transactionId.id;
                 const reviewTabView = draft.transactionCategorizationView.review;
                 const autoTabView = draft.transactionCategorizationView.autoCategorized;
@@ -1034,7 +1024,7 @@ const expenseAutomationTransactionsView = createSlice({
                 }
                 // Partially reviewed: rebuild review tab local data with pending review lines
                 if (existsInReview) {
-                    const newLocalData = toTransactionDetailLocalData(updatedTransaction, 'review', pendingReviewLineIds, uncategorizedIncomeExpense, isUncategorizedExpenseCategoryEnabled);
+                    const newLocalData = toTransactionDetailLocalData(updatedTransaction, 'review', pendingReviewLineIds);
                     reviewTabView.transactionReviewLocalDataById[txnId] = {
                         transactionId: txnId,
                         transactionReviewLocalData: {
@@ -1053,11 +1043,10 @@ const expenseAutomationTransactionsView = createSlice({
             },
         },
         backgroundRefetchReviewTab: {
-            prepare(period, isUncategorizedExpenseCategoryEnabled) {
+            prepare(period) {
                 return {
                     payload: {
                         period,
-                        isUncategorizedExpenseCategoryEnabled,
                     },
                 };
             },