@zeniai/client-epic-state 5.1.58 → 5.1.60-beta0ND

package/lib/view/expenseAutomationView/epics/transactionCategorization/initializeTransactionCategorizationLocalDataEpic.js

@@ -5,12 +5,11 @@ const rxjs_1 = require("rxjs");
 const operators_1 = require("rxjs/operators");
 const transactionHelper_1 = require("../../../../entity/transaction/transactionHelper");
 const transactionSelector_1 = require("../../../../entity/transaction/transactionSelector");
-const accountListSelector_1 = require("../../../accountList/accountListSelector");
 const transactionCategorizationLocalDataHelper_1 = require("../../helpers/transactionCategorizationLocalDataHelper");
 const transactionsViewReducer_1 = require("../../reducers/transactionsViewReducer");
 const transactionsViewState_1 = require("../../types/transactionsViewState");
 const initializeTransactionCategorizationViewLocalDataEpic = (actions$, state$) => actions$.pipe((0, operators_1.filter)(transactionsViewReducer_1.initializeTransactionCategorizationViewLocalData.match), (0, operators_1.mergeMap)((action) => {
-    const { transactionIds, selectedPeriod, keepExistingListItems, selectedTab, pageToken, totalCount, lineItemsByTransactionIds, refreshViewInBackground, isUncategorizedExpenseCategoryEnabled, } = action.payload;
+    const { transactionIds, selectedPeriod, keepExistingListItems, selectedTab, pageToken, totalCount, lineItemsByTransactionIds, refreshViewInBackground, } = action.payload;
     const fetchActions = [];
     const { transactionState, expenseAutomationTransactionsViewState } = state$.value;
     const { transactionReviewLocalDataById } = expenseAutomationTransactionsViewState.transactionCategorizationView[selectedTab];
@@ -18,10 +17,9 @@ const initializeTransactionCategorizationViewLocalDataEpic = (actions$, state$)
         ? { ...transactionReviewLocalDataById }
         : {};
     const transactions = (0, transactionSelector_1.getSupportedTransactionsByIds)(transactionState, transactionIds);
-    const uncategorizedIncomeExpense = (0, accountListSelector_1.getUncategorizedAccounts)(state$.value.accountState, state$.value.accountListState, 'accountList');
     transactions.forEach((transaction) => {
         const transactionWithCOT = (0, transactionHelper_1.getTransactionWithCOT)(transaction);
-        const newTransactionsLocalData = (0, transactionCategorizationLocalDataHelper_1.toTransactionDetailLocalData)(transactionWithCOT, selectedTab, lineItemsByTransactionIds[transaction.id], uncategorizedIncomeExpense, isUncategorizedExpenseCategoryEnabled);
+        const newTransactionsLocalData = (0, transactionCategorizationLocalDataHelper_1.toTransactionDetailLocalData)(transactionWithCOT, selectedTab, lineItemsByTransactionIds[transaction.id]);
         if (transactionLocalData[transaction.id] == null) {
             transactionLocalData[transaction.id] = {
                 ...transactionsViewState_1.initialSupportedTransactionCategorization,

package/lib/view/expenseAutomationView/epics/transactionCategorization/markTransactionAsNotMiscategorizedEpic.js

@@ -13,7 +13,7 @@ const transactionCategorizationLocalDataHelper_1 = require("../../helpers/transa
 const transactionsViewReducer_1 = require("../../reducers/transactionsViewReducer");
 const markTransactionAsNotMiscategorizedEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(transactionsViewReducer_1.markTransactionAsNotMiscategorized.match), (0, operators_1.mergeMap)((action) => {
     const { expenseAutomationViewState, expenseAutomationTransactionsViewState, } = state$.value;
-    const { transactionsInReview, selectedTab, isUncategorizedExpenseCategoryEnabled, } = action.payload;
+    const { transactionsInReview, selectedTab, } = action.payload;
     const transactionsSuccess = transactionsInReview.transactions_update_success;
     const transactionsFailed = transactionsInReview.transactions_update_failed;
     const currentTenant = (0, tenantSelector_1.getCurrentTenant)(state$.value);
@@ -110,7 +110,7 @@ const markTransactionAsNotMiscategorizedEpic = (actions$, state$, zeniAPI) => ac
                     if (timePeriodStart != null && timePeriodEnd != null) {
                         actions.push((0, transactionsViewReducer_1.fetchTransactionCategorizationView)('review', { start: timePeriodStart, end: timePeriodEnd }, true, // cacheOverride = true to force refresh
                         false, undefined, undefined, true, // refreshViewInBackground
-                        false, isUncategorizedExpenseCategoryEnabled));
+                        false));
                     }
                 }
                 actions.push((0, transactionsViewReducer_1.updateTotalCountForTransactionCategorization)({

package/lib/view/expenseAutomationView/epics/transactionCategorization/saveTransactionCategorizationEpic.js

@@ -12,7 +12,7 @@ const accountListSelector_1 = require("../../../accountList/accountListSelector"
 const saveTransactionHelper_1 = require("../../helpers/saveTransactionHelper");
 const transactionsViewReducer_1 = require("../../reducers/transactionsViewReducer");
 const saveTransactionCategorizationEpic = (actions$, state$) => actions$.pipe((0, operators_1.filter)(transactionsViewReducer_1.saveTransactionCategorization.match), (0, operators_1.mergeMap)((action) => {
-    const { transactionIds, cotTrackingByTransactionId, selectedTab, isUncategorizedExpenseCategoryEnabled, } = action.payload;
+    const { transactionIds, cotTrackingByTransactionId, selectedTab, } = action.payload;
     const fetchActions = [];
     const { transactionState, expenseAutomationTransactionsViewState } = state$.value;
     const transactionSaveUpdates = [];
@@ -25,7 +25,7 @@ const saveTransactionCategorizationEpic = (actions$, state$) => actions$.pipe((0
             transactionSaveUpdates.push((0, saveTransactionHelper_1.toTransactionUpdatesFromTransactionCategorizationLocalData)(localData, transaction, uncategorizedIncomeExpense));
         }
     });
-    fetchActions.push((0, transactionsViewReducer_1.updateTransactionCategorization)(selectedTab, transactionIds, transactionSaveUpdates, cotTrackingByTransactionId, isUncategorizedExpenseCategoryEnabled));
+    fetchActions.push((0, transactionsViewReducer_1.updateTransactionCategorization)(selectedTab, transactionIds, transactionSaveUpdates, cotTrackingByTransactionId));
     return (0, rxjs_1.from)(fetchActions);
 }));
 exports.saveTransactionCategorizationEpic = saveTransactionCategorizationEpic;

package/lib/view/expenseAutomationView/epics/transactionCategorization/triggerReviewTabRefetchEpic.js

@@ -7,7 +7,7 @@ const timePeriod_1 = require("../../../../commonStateTypes/timePeriod");
 const tenantSelector_1 = require("../../../../entity/tenant/tenantSelector");
 const transactionsViewReducer_1 = require("../../reducers/transactionsViewReducer");
 const triggerReviewTabRefetchEpic = (actions$, state$) => actions$.pipe((0, operators_1.filter)(transactionsViewReducer_1.syncTransactionCategorizationFromDetailSave.match), (0, operators_1.mergeMap)((action) => {
-    const { pendingReviewLineIds, transactionId, isUncategorizedExpenseCategoryEnabled, } = action.payload;
+    const { pendingReviewLineIds, transactionId, } = action.payload;
     if (pendingReviewLineIds.length === 0) {
         return rxjs_1.EMPTY;
     }
@@ -26,6 +26,6 @@ const triggerReviewTabRefetchEpic = (actions$, state$) => actions$.pipe((0, oper
     if (timePeriodStart == null || timePeriodEnd == null) {
         return rxjs_1.EMPTY;
     }
-    return (0, rxjs_1.of)((0, transactionsViewReducer_1.backgroundRefetchReviewTab)({ start: timePeriodStart, end: timePeriodEnd }, isUncategorizedExpenseCategoryEnabled));
+    return (0, rxjs_1.of)((0, transactionsViewReducer_1.backgroundRefetchReviewTab)({ start: timePeriodStart, end: timePeriodEnd }));
 }));
 exports.triggerReviewTabRefetchEpic = triggerReviewTabRefetchEpic;

package/lib/view/expenseAutomationView/epics/transactionCategorization/updateTransactionCategorizationEpic.js

@@ -21,7 +21,7 @@ const vendorSelector_1 = require("../../../../entity/vendor/vendorSelector");
 const responsePayload_1 = require("../../../../responsePayload");
 const transactionsViewReducer_1 = require("../../reducers/transactionsViewReducer");
 const updateTransactionCategorizationEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(transactionsViewReducer_1.updateTransactionCategorization.match), (0, operators_1.mergeMap)((action) => {
-    const { selectedTab, transactionIds, transactionSaveUpdates, cotTrackingByTransactionId, isUncategorizedExpenseCategoryEnabled, } = action.payload;
+    const { selectedTab, transactionIds, transactionSaveUpdates, cotTrackingByTransactionId, } = action.payload;
     const { transactionState, vendorState, expenseAutomationTransactionsViewState, } = state$.value;
     const payloadArray = preparePayload(selectedTab, transactionState, vendorState, expenseAutomationTransactionsViewState, transactionIds, transactionSaveUpdates, cotTrackingByTransactionId).filter((payload) => payload != null);
     return zeniAPI
@@ -30,7 +30,7 @@ const updateTransactionCategorizationEpic = (actions$, state$, zeniAPI) => actio
         if ((0, responsePayload_1.isSuccessResponse)(response) && response.data != null) {
             const transactionsInReview = response.data;
             const actions = [];
-            actions.push((0, transactionsViewReducer_1.markTransactionAsNotMiscategorized)(selectedTab, transactionsInReview, isUncategorizedExpenseCategoryEnabled), (0, transactionsViewReducer_1.updateTransactionCategorizationSaveStatus)(selectedTab, 'Completed', (0, responsePayload_1.createZeniAPIStatus)('Completed', 'Transaction categorization updated successfully')));
+            actions.push((0, transactionsViewReducer_1.markTransactionAsNotMiscategorized)(selectedTab, transactionsInReview), (0, transactionsViewReducer_1.updateTransactionCategorizationSaveStatus)(selectedTab, 'Completed', (0, responsePayload_1.createZeniAPIStatus)('Completed', 'Transaction categorization updated successfully')));
             return (0, rxjs_1.from)(actions);
         }
         else {

package/lib/view/expenseAutomationView/expenseAutomationViewReducer.d.ts

@@ -2,10 +2,9 @@ import { ID } from '../../commonStateTypes/common';
 import { MonthYearPeriod } from '../../commonStateTypes/timePeriod';
 import { ExpenseAutomationViewState } from './expenseAutomationViewState';
 export declare const initialState: ExpenseAutomationViewState;
-export declare const fetchAllExpenseAutomationTabs: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[cacheOverride?: boolean | undefined, refreshViewInBackground?: boolean | undefined, isUncategorizedExpenseCategoryEnabled?: boolean | undefined], {
+export declare const fetchAllExpenseAutomationTabs: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[cacheOverride?: boolean | undefined, refreshViewInBackground?: boolean | undefined], {
     cacheOverride: boolean;
     refreshViewInBackground: boolean;
-    isUncategorizedExpenseCategoryEnabled: boolean;
 }, "expenseAutomationView/fetchAllExpenseAutomationTabs", never, never>, updateCurrentSelectedPeriod: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[tenantId: string, newSelectedPeriod: MonthYearPeriod], {
     newSelectedPeriod: MonthYearPeriod;
     tenantId: string;
@@ -13,8 +12,6 @@ export declare const fetchAllExpenseAutomationTabs: import("@reduxjs/toolkit").A
     newSelectedView: "transaction_categorization" | "je_schedules" | "reconciliation" | "missing_receipts" | "flux_analysis" | "month_end_insights";
 }, "expenseAutomationView/updateCurrentSelectedView", never, never>, clearExpenseAutomationView: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"expenseAutomationView/clearExpenseAutomationView">, initializeSelectedPeriodForTenants: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
     selectedPeriodByTenantId: Record<ID, MonthYearPeriod>;
-}, "expenseAutomationView/initializeSelectedPeriodForTenants">, refreshExpenseAutomationCurrentTab: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[isUncategorizedExpenseCategoryEnabled?: boolean | undefined], {
-    isUncategorizedExpenseCategoryEnabled: boolean | undefined;
-}, "expenseAutomationView/refreshExpenseAutomationCurrentTab", never, never>;
+}, "expenseAutomationView/initializeSelectedPeriodForTenants">, refreshExpenseAutomationCurrentTab: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[], {}, "expenseAutomationView/refreshExpenseAutomationCurrentTab", never, never>;
 declare const _default: import("redux").Reducer<ExpenseAutomationViewState>;
 export default _default;

package/lib/view/expenseAutomationView/expenseAutomationViewReducer.js

@@ -22,20 +22,19 @@ const expenseAutomationView = (0, toolkit_1.createSlice)({
             reducer() {
                 //do nothing
             },
-            prepare(cacheOverride = false, refreshViewInBackground = false, isUncategorizedExpenseCategoryEnabled = false) {
+            prepare(cacheOverride = false, refreshViewInBackground = false) {
                 return {
                     payload: {
                         cacheOverride,
                         refreshViewInBackground,
-                        isUncategorizedExpenseCategoryEnabled,
                     },
                 };
             },
         },
         refreshExpenseAutomationCurrentTab: {
-            prepare(isUncategorizedExpenseCategoryEnabled) {
+            prepare() {
                 return {
-                    payload: { isUncategorizedExpenseCategoryEnabled },
+                    payload: {},
                 };
             },
             reducer() {

package/lib/view/expenseAutomationView/helpers/transactionCategorizationLocalDataHelper.d.ts

@@ -27,14 +27,14 @@ export declare const removeTransactionFromTabView: (tabView: TransactionsTabView
  */
 export declare const filterAutoTabLineItems: (tabView: TransactionsTabViewState, transactionId: ID, updatedTransaction: SupportedTransactionWithCOT) => void;
 export declare const MAX_SELECTION_LIMIT = 5;
-export declare const shouldAutoSelectAndAdd: (transaction: SupportedTransactionWithCOT, localData: TransactionReviewLocalData, selectedCheckBoxTransactionIds: ID[], uncategorizedAccounts: UncategorizedAccounts, isUncategorizedExpenseCategoryEnabled?: boolean, isAccountingClassesEnabled?: boolean) => boolean;
-export declare const toTransactionDetailLocalData: (transaction: SupportedTransactionWithCOT, selectedTab: TransactionsTab, lineItemsByTransactionIds: string[], uncategorizedIncomeExpense: UncategorizedAccounts, isUncategorizedExpenseCategoryEnabled?: boolean) => TransactionReviewLocalData;
-export declare const toSetAllLineItemsToCategoryClass: (draft: TransactionsTabViewState, transaction: SupportedTransactionWithCOT, transactionId: ID, transactionLineId: ID, transactionDetailLocalData: TransactionReviewLocalData, updatedItem: "category" | "class" | "project", uncategorizedAccounts: UncategorizedAccounts, selectedTab: TransactionsTab, vendorId?: ID, customerId?: ID, selectedAccount?: AccountBase, selectedClassBase?: ClassBase, selectedProjectBase?: ProjectBase, isUncategorizedExpenseCategoryEnabled?: boolean, isAccountingClassesEnabled?: boolean) => {
+export declare const shouldAutoSelectAndAdd: (transaction: SupportedTransactionWithCOT, localData: TransactionReviewLocalData, selectedCheckBoxTransactionIds: ID[], isAccountingClassesEnabled?: boolean) => boolean;
+export declare const toTransactionDetailLocalData: (transaction: SupportedTransactionWithCOT, selectedTab: TransactionsTab, lineItemsByTransactionIds: string[]) => TransactionReviewLocalData;
+export declare const toSetAllLineItemsToCategoryClass: (draft: TransactionsTabViewState, transaction: SupportedTransactionWithCOT, transactionId: ID, transactionLineId: ID, transactionDetailLocalData: TransactionReviewLocalData, updatedItem: "category" | "class" | "project", selectedTab: TransactionsTab, vendorId?: ID, customerId?: ID, selectedAccount?: AccountBase, selectedClassBase?: ClassBase, selectedProjectBase?: ProjectBase, isAccountingClassesEnabled?: boolean) => {
     localData: TransactionReviewLocalData;
     similarTransactionUpdated: boolean;
 };
-export declare const setEntityRecommendationForLineIdInLocalData: (draft: TransactionsTabViewState, transaction: SupportedTransactionWithCOT, transactionDetailLocalData: TransactionReviewLocalData, entity: Entity, recommendationLineIds: ID[], uncategorizedAccounts: UncategorizedAccounts, recommendationWithCOTByLineId?: RecommendationWithCOTByLineId, isUncategorizedExpenseCategoryEnabled?: boolean, isAccountingClassesEnabled?: boolean) => TransactionReviewLocalData;
-export declare const checkIfAllLineItemsAreCategoryClassFilled: (transaction: SupportedTransactionWithCOT, transactionDetailLocalData: TransactionReviewLocalData, uncategorizedAccounts: UncategorizedAccounts, isUncategorizedExpenseCategoryEnabled?: boolean, isAccountingClassesEnabled?: boolean) => boolean;
+export declare const setEntityRecommendationForLineIdInLocalData: (draft: TransactionsTabViewState, transaction: SupportedTransactionWithCOT, transactionDetailLocalData: TransactionReviewLocalData, entity: Entity, recommendationLineIds: ID[], recommendationWithCOTByLineId?: RecommendationWithCOTByLineId, isAccountingClassesEnabled?: boolean) => TransactionReviewLocalData;
+export declare const checkIfAllLineItemsAreCategoryClassFilled: (transaction: SupportedTransactionWithCOT, transactionDetailLocalData: TransactionReviewLocalData, isAccountingClassesEnabled?: boolean) => boolean;
 export declare const getLineItemsByTransactionsIdsFromResponse: (transactions: SupportedTransactionPayload[]) => Record<string, string[]>;
 export declare const getLineItemsByTransactionIdsFromLocalData: (transactionLocalData: TransactionReviewLocalDataSelectorView[], selectedTab: TransactionsTab) => Record<ID, string[]>;
 export declare const mergeTabSpecificLineItems: (currentTabSpecificLineItems: TabSpecificLineItems, selectedTab: TransactionsTab, newLineItems: TabSpecificLineItems) => TabSpecificLineItems;

package/lib/view/expenseAutomationView/helpers/transactionCategorizationLocalDataHelper.js

@@ -72,17 +72,17 @@ exports.MAX_SELECTION_LIMIT = 5;
 // triplet that was inlined at four sites (updateSelectedCustomer/Vendor,
 // setAllItemsToCategoryClassInLocalDataForCategorization, and
 // setEntityRecommendationForLineIdInLocalData below).
-const shouldAutoSelectAndAdd = (transaction, localData, selectedCheckBoxTransactionIds, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled) => {
+const shouldAutoSelectAndAdd = (transaction, localData, selectedCheckBoxTransactionIds, isAccountingClassesEnabled) => {
     if (selectedCheckBoxTransactionIds.includes(transaction.id)) {
         return false;
     }
     if (selectedCheckBoxTransactionIds.length >= exports.MAX_SELECTION_LIMIT) {
         return false;
     }
-    return (0, exports.checkIfAllLineItemsAreCategoryClassFilled)(transaction, localData, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled);
+    return (0, exports.checkIfAllLineItemsAreCategoryClassFilled)(transaction, localData, isAccountingClassesEnabled);
 };
 exports.shouldAutoSelectAndAdd = shouldAutoSelectAndAdd;
-const toTransactionDetailLocalData = (transaction, selectedTab, lineItemsByTransactionIds, uncategorizedIncomeExpense, isUncategorizedExpenseCategoryEnabled) => {
+const toTransactionDetailLocalData = (transaction, selectedTab, lineItemsByTransactionIds) => {
     const transactionLocal = {
         ...transactionsViewState_1.initialSupportedTransactionCategorization.transactionReviewLocalData,
     };
@@ -169,7 +169,7 @@ const toTransactionDetailLocalData = (transaction, selectedTab, lineItemsByTrans
     }
     transactionLocal.lineItemById =
         transaction.lines != null && transaction.lines.length > 0
-            ? buildLineItemById(transaction, uncategorizedIncomeExpense, transaction.recommendationsWithCOT, isUncategorizedExpenseCategoryEnabled)
+            ? buildLineItemById(transaction, transaction.recommendationsWithCOT)
             : {};
     transactionLocal.sortedLineItems =
         transaction.lines != null && transaction.lines.length > 0
@@ -185,7 +185,7 @@ const toTransactionDetailLocalData = (transaction, selectedTab, lineItemsByTrans
     return transactionLocal;
 };
 exports.toTransactionDetailLocalData = toTransactionDetailLocalData;
-const buildLineItemById = (transaction, uncategorizedIncomeExpense, recommendations, isUncategorizedExpenseCategoryEnabled) => {
+const buildLineItemById = (transaction, recommendations) => {
     const lineItemData = {};
     const { lines } = transaction;
     lines?.forEach((line) => {
@@ -249,10 +249,7 @@ const buildLineItemById = (transaction, uncategorizedIncomeExpense, recommendati
             if (recommendations != null) {
                 record.recommendationsWithCOT = recommendations[lineId];
                 const higherPreferenceRecommendation = recommendations[lineId]?.[0];
-                if ((Boolean(accountLine.account.accountId) === false ||
-                    (0, transactionDetailLocalDataHelper_2.isAccountUncategorized)(uncategorizedIncomeExpense, accountLine.account.qboId, isUncategorizedExpenseCategoryEnabled === true
-                        ? ['income']
-                        : undefined)) &&
+                if (Boolean(accountLine.account.accountId) === false &&
                     higherPreferenceRecommendation?.account != null) {
                     record.account = {
                         ...higherPreferenceRecommendation.account,
@@ -330,7 +327,7 @@ const buildLineItemById = (transaction, uncategorizedIncomeExpense, recommendati
     });
     return lineItemData;
 };
-const toSetAllLineItemsToCategoryClass = (draft, transaction, transactionId, transactionLineId, transactionDetailLocalData, updatedItem, uncategorizedAccounts, selectedTab, vendorId, customerId, selectedAccount, selectedClassBase, selectedProjectBase, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled) => {
+const toSetAllLineItemsToCategoryClass = (draft, transaction, transactionId, transactionLineId, transactionDetailLocalData, updatedItem, selectedTab, vendorId, customerId, selectedAccount, selectedClassBase, selectedProjectBase, isAccountingClassesEnabled) => {
     let newLineItems = {};
     let selectedCheckBoxTransactionIds = draft.selectedCheckBoxTransactionIds;
     let similarTransactionUpdated = false;
@@ -387,10 +384,7 @@ const toSetAllLineItemsToCategoryClass = (draft, transaction, transactionId, tra
                             // if the vendor is same, then set the account and class with the selected ones and add the transaction to the selected list
                             if (selectedAccount != null &&
                                 updatedItem === 'category' &&
-                                (record.account?.qboId == null ||
-                                    (0, transactionDetailLocalDataHelper_2.isAccountUncategorized)(uncategorizedAccounts, record.account?.qboId, isUncategorizedExpenseCategoryEnabled === true
-                                        ? ['income']
-                                        : undefined) === true)) {
+                                record.account?.qboId == null) {
                                 record.account = selectedAccount;
                                 similarTransactionUpdated = true;
                                 if ((isAccountingClassesEnabled === false ||
@@ -459,14 +453,14 @@ const toSetAllLineItemsToCategoryClass = (draft, transaction, transactionId, tra
         selectedEntity: transactionDetailLocalData.selectedEntity,
         tabSpecificLineItems: transactionDetailLocalData.tabSpecificLineItems,
     };
-    if (!(0, exports.checkIfAllLineItemsAreCategoryClassFilled)(transaction, newLocalData, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled)) {
+    if (!(0, exports.checkIfAllLineItemsAreCategoryClassFilled)(transaction, newLocalData, isAccountingClassesEnabled)) {
         selectedCheckBoxTransactionIds = selectedCheckBoxTransactionIds.filter((id) => id !== transaction.id);
     }
     draft.selectedCheckBoxTransactionIds = selectedCheckBoxTransactionIds;
     return { localData: newLocalData, similarTransactionUpdated };
 };
 exports.toSetAllLineItemsToCategoryClass = toSetAllLineItemsToCategoryClass;
-const setEntityRecommendationForLineIdInLocalData = (draft, transaction, transactionDetailLocalData, entity, recommendationLineIds, uncategorizedAccounts, recommendationWithCOTByLineId, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled) => {
+const setEntityRecommendationForLineIdInLocalData = (draft, transaction, transactionDetailLocalData, entity, recommendationLineIds, recommendationWithCOTByLineId, isAccountingClassesEnabled) => {
     const newLineItems = {};
     let matchingEntityLineId = undefined;
     const checkIfNotJEAndDeposit = !(0, vendorTransaction_1.isVendorTransaction)(transaction);
@@ -486,11 +480,8 @@ const setEntityRecommendationForLineIdInLocalData = (draft, transaction, transac
                     };
                     const recommendations = (0, transactionDetailLocalDataHelper_1.mergeTransactionAndEntityRecommendationsWithCOT)(oldRecord.recommendationsWithCOT, recommendationWithCOTByLineId?.[lineId]);
                     const accountLine = line;
-                    const isUncategorizedAccount = (0, transactionDetailLocalDataHelper_2.isAccountUncategorized)(uncategorizedAccounts, accountLine.account.qboId, isUncategorizedExpenseCategoryEnabled === true
-                        ? ['income']
-                        : undefined);
                     record.account =
-                        isUncategorizedAccount === false && accountLine.account.qboId !== ''
+                        accountLine.account.qboId !== ''
                             ? accountLine.account
                             : recommendations?.[0]?.account
                                 ? {
@@ -573,24 +564,22 @@ const setEntityRecommendationForLineIdInLocalData = (draft, transaction, transac
     // category/class became stale after the entity update). Otherwise
     // route through shouldAutoSelectAndAdd so the MAX_SELECTION_LIMIT
     // gate is consistently applied across all auto-add sites.
-    if (!(0, exports.checkIfAllLineItemsAreCategoryClassFilled)(transaction, newLocalData, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled)) {
+    if (!(0, exports.checkIfAllLineItemsAreCategoryClassFilled)(transaction, newLocalData, isAccountingClassesEnabled)) {
         selectedCheckBoxTransactionIds = selectedCheckBoxTransactionIds.filter((id) => id !== transaction.id);
     }
-    else if ((0, exports.shouldAutoSelectAndAdd)(transaction, newLocalData, selectedCheckBoxTransactionIds, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled)) {
+    else if ((0, exports.shouldAutoSelectAndAdd)(transaction, newLocalData, selectedCheckBoxTransactionIds, isAccountingClassesEnabled)) {
         selectedCheckBoxTransactionIds.push(transaction.id);
     }
     draft.selectedCheckBoxTransactionIds = selectedCheckBoxTransactionIds;
     return newLocalData;
 };
 exports.setEntityRecommendationForLineIdInLocalData = setEntityRecommendationForLineIdInLocalData;
-const checkIfAllLineItemsAreCategoryClassFilled = (transaction, transactionDetailLocalData, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled) => {
+const checkIfAllLineItemsAreCategoryClassFilled = (transaction, transactionDetailLocalData, isAccountingClassesEnabled) => {
     const lineItems = Object.values(transactionDetailLocalData.lineItemById);
     const isVendorTransactionAvailable = (0, vendorTransaction_1.isVendorTransaction)(transaction);
-    const uncategorizedAccountTypes = isUncategorizedExpenseCategoryEnabled === true ? ['income'] : undefined;
     return lineItems.every((lineItem) => Boolean(lineItem?.account?.qboId) &&
         (isAccountingClassesEnabled === false ||
             Boolean(lineItem?.class?.qboId)) &&
-        (0, transactionDetailLocalDataHelper_2.isAccountUncategorized)(uncategorizedAccounts, lineItem?.account?.qboId, uncategorizedAccountTypes) === false &&
         ((isVendorTransactionAvailable
             ? Boolean(transactionDetailLocalData?.vendor?.id)
             : Boolean(lineItem?.vendor?.id)) ||

package/lib/view/expenseAutomationView/reducers/transactionsViewReducer.d.ts

@@ -17,7 +17,7 @@ import { TransactionFilters } from '../transactionFilterHelpers';
 import { SupportedTransactionCategorization, TransactionSaveUpdates, TransactionsTab, TransactionsTabViewState, TransactionsViewState, TransactionsViewUIState } from '../types/transactionsViewState';
 export declare const initialTransactionTabViewState: TransactionsTabViewState;
 export declare const initialState: TransactionsViewState;
-export declare const fetchTransactionCategorization: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[selectedTab: "review" | "autoCategorized", period: TimePeriod, cacheOverride?: any, keepExistingListItems?: any, searchString?: string | undefined, pageToken?: PageToken | undefined, refreshViewInBackground?: any, resetListItems?: boolean | undefined, isUncategorizedExpenseCategoryEnabled?: boolean | undefined], {
+export declare const fetchTransactionCategorization: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[selectedTab: "review" | "autoCategorized", period: TimePeriod, cacheOverride?: any, keepExistingListItems?: any, searchString?: string | undefined, pageToken?: PageToken | undefined, refreshViewInBackground?: any, resetListItems?: boolean | undefined], {
     selectedTab: "review" | "autoCategorized";
     period: TimePeriod;
     searchString: string | undefined;
@@ -26,14 +26,13 @@ export declare const fetchTransactionCategorization: import("@reduxjs/toolkit").
     cacheOverride: any;
     refreshViewInBackground: any;
     resetListItems: boolean | undefined;
-    isUncategorizedExpenseCategoryEnabled: boolean | undefined;
 }, "expenseAutomationTransactionsView/fetchTransactionCategorization", never, never>, updateTransactionCategorizationUIState: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
     selectedTab: TransactionsTab;
     uiState: Partial<TransactionsViewUIState>;
 }, "expenseAutomationTransactionsView/updateTransactionCategorizationUIState">, updateTransactionFilters: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
     filters: TransactionFilters;
     selectedTab: TransactionsTab;
-}, "expenseAutomationTransactionsView/updateTransactionFilters">, initializeTransactionCategorizationViewLocalData: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[selectedTab: "review" | "autoCategorized", transactionIds: string[], selectedPeriod: MonthYearPeriod, keepExistingListItems: any, pageToken: PageToken, totalCount: number, lineItemsByTransactionIds: Record<string, string[]>, refreshViewInBackground?: any, isUncategorizedExpenseCategoryEnabled?: boolean | undefined], {
+}, "expenseAutomationTransactionsView/updateTransactionFilters">, initializeTransactionCategorizationViewLocalData: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[selectedTab: "review" | "autoCategorized", transactionIds: string[], selectedPeriod: MonthYearPeriod, keepExistingListItems: any, pageToken: PageToken, totalCount: number, lineItemsByTransactionIds: Record<string, string[]>, refreshViewInBackground?: any], {
     selectedTab: "review" | "autoCategorized";
     transactionIds: string[];
     selectedPeriod: MonthYearPeriod;
@@ -42,7 +41,6 @@ export declare const fetchTransactionCategorization: import("@reduxjs/toolkit").
     totalCount: number;
     lineItemsByTransactionIds: Record<string, string[]>;
     refreshViewInBackground: any;
-    isUncategorizedExpenseCategoryEnabled: boolean | undefined;
 }, "expenseAutomationTransactionsView/initializeTransactionCategorizationViewLocalData", never, never>, saveTransactionCategorizationLocalData: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
     keepExistingListItems: boolean;
     pageToken: PageToken;
@@ -56,17 +54,15 @@ export declare const fetchTransactionCategorization: import("@reduxjs/toolkit").
     selectedPeriod: MonthYearPeriod;
     selectedTab: TransactionsTab;
     status: ZeniAPIStatus;
-}, "expenseAutomationTransactionsView/fetchTransactionCategorizationFailure">, saveTransactionCategorization: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[selectedTab: "review" | "autoCategorized", transactionIds: string[], cotTrackingByTransactionId: COTTransactionTrackingByTransactionId, isUncategorizedExpenseCategoryEnabled?: boolean | undefined], {
+}, "expenseAutomationTransactionsView/fetchTransactionCategorizationFailure">, saveTransactionCategorization: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[selectedTab: "review" | "autoCategorized", transactionIds: string[], cotTrackingByTransactionId: COTTransactionTrackingByTransactionId], {
     selectedTab: "review" | "autoCategorized";
     transactionIds: string[];
     cotTrackingByTransactionId: COTTransactionTrackingByTransactionId;
-    isUncategorizedExpenseCategoryEnabled: boolean | undefined;
-}, "expenseAutomationTransactionsView/saveTransactionCategorization", never, never>, updateTransactionCategorization: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[selectedTab: "review" | "autoCategorized", transactionIds: string[], transactionSaveUpdates: TransactionSaveUpdates[], cotTrackingByTransactionId: COTTransactionTrackingByTransactionId, isUncategorizedExpenseCategoryEnabled?: boolean | undefined], {
+}, "expenseAutomationTransactionsView/saveTransactionCategorization", never, never>, updateTransactionCategorization: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[selectedTab: "review" | "autoCategorized", transactionIds: string[], transactionSaveUpdates: TransactionSaveUpdates[], cotTrackingByTransactionId: COTTransactionTrackingByTransactionId], {
     selectedTab: "review" | "autoCategorized";
     transactionIds: string[];
     transactionSaveUpdates: TransactionSaveUpdates[];
     cotTrackingByTransactionId: COTTransactionTrackingByTransactionId;
-    isUncategorizedExpenseCategoryEnabled: boolean | undefined;
 }, "expenseAutomationTransactionsView/updateTransactionCategorization", never, never>, updateCurrentSelectedTransactionCategorizationTab: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[newSelectedTab: "review" | "autoCategorized"], {
     newSelectedTab: "review" | "autoCategorized";
 }, "expenseAutomationTransactionsView/updateCurrentSelectedTransactionCategorizationTab", never, never>, updateTransactionCategorizationCompletedSubTab: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[newSubTab: "all" | "manual" | "ai_accountant"], {
@@ -75,10 +71,9 @@ export declare const fetchTransactionCategorization: import("@reduxjs/toolkit").
     selectedTab: "review" | "autoCategorized";
     fetchState: FetchState;
     error: ZeniAPIStatus<Record<string, unknown>> | undefined;
-}, "expenseAutomationTransactionsView/updateTransactionCategorizationSaveStatus", never, never>, markTransactionAsNotMiscategorized: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[selectedTab: "review" | "autoCategorized", transactionsInReview: UpdateTransactionCategorizationResponsePayload, isUncategorizedExpenseCategoryEnabled?: boolean | undefined], {
+}, "expenseAutomationTransactionsView/updateTransactionCategorizationSaveStatus", never, never>, markTransactionAsNotMiscategorized: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[selectedTab: "review" | "autoCategorized", transactionsInReview: UpdateTransactionCategorizationResponsePayload], {
     selectedTab: "review" | "autoCategorized";
     transactionsInReview: UpdateTransactionCategorizationResponsePayload;
-    isUncategorizedExpenseCategoryEnabled: boolean | undefined;
 }, "expenseAutomationTransactionsView/markTransactionAsNotMiscategorized", never, never>, updateStatusForTransactionNotMiscategorizedUpdateForCategorization: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[selectedTab: "review" | "autoCategorized", uncheckTransactionIds: string[], removeTransactionIdsFromSelectedPeriod: string[], selectedPeriod: MonthYearPeriod, fetchState: FetchState, error?: ZeniAPIStatus<Record<string, unknown>> | undefined, updateLineItemsByTransactionId?: Record<string, string[]> | undefined], {
     removeTransactionIdsFromSelectedPeriod: string[];
     selectedPeriod: MonthYearPeriod;
@@ -94,7 +89,6 @@ export declare const fetchTransactionCategorization: import("@reduxjs/toolkit").
     transactionId: ID;
     uncategorizedAccounts: UncategorizedAccounts;
     isAccountingClassesEnabled?: boolean;
-    isUncategorizedExpenseCategoryEnabled?: boolean;
     selectedEntity?: Entity;
     updatedVendor?: VendorBase;
 }, "expenseAutomationTransactionsView/updateSelectedVendorForTransaction">, updateSelectedCustomerForTransaction: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
@@ -104,10 +98,9 @@ export declare const fetchTransactionCategorization: import("@reduxjs/toolkit").
     transactionId: ID;
     uncategorizedAccounts: UncategorizedAccounts;
     isAccountingClassesEnabled?: boolean;
-    isUncategorizedExpenseCategoryEnabled?: boolean;
     selectedEntity?: Entity;
     updatedCustomer?: CustomerBase;
-}, "expenseAutomationTransactionsView/updateSelectedCustomerForTransaction">, setAllItemsToCategoryClassInLocalDataForCategorization: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[selectedTab: "review" | "autoCategorized", transactionId: string, lineId: string, transactions: SupportedTransactionWithCOT[], uncategorizedAccounts: UncategorizedAccounts, vendorId?: string | undefined, customerId?: string | undefined, selectedAccount?: AccountBase | undefined, selectedClassBase?: ClassBase | undefined, lineEntity?: Entity | undefined, recommendations?: RecommendationWithCOT[] | undefined, isUncategorizedExpenseCategoryEnabled?: boolean | undefined, isAccountingClassesEnabled?: boolean | undefined, selectedProjectBase?: ProjectBase | undefined], {
+}, "expenseAutomationTransactionsView/updateSelectedCustomerForTransaction">, setAllItemsToCategoryClassInLocalDataForCategorization: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[selectedTab: "review" | "autoCategorized", transactionId: string, lineId: string, transactions: SupportedTransactionWithCOT[], uncategorizedAccounts: UncategorizedAccounts, vendorId?: string | undefined, customerId?: string | undefined, selectedAccount?: AccountBase | undefined, selectedClassBase?: ClassBase | undefined, lineEntity?: Entity | undefined, recommendations?: RecommendationWithCOT[] | undefined, isAccountingClassesEnabled?: boolean | undefined, selectedProjectBase?: ProjectBase | undefined], {
     selectedTab: "review" | "autoCategorized";
     transactionId: string;
     lineId: string;
@@ -121,7 +114,6 @@ export declare const fetchTransactionCategorization: import("@reduxjs/toolkit").
     recommendations: RecommendationWithCOT[] | undefined;
     uncategorizedAccounts: UncategorizedAccounts;
     isAccountingClassesEnabled: boolean | undefined;
-    isUncategorizedExpenseCategoryEnabled: boolean | undefined;
 }, "expenseAutomationTransactionsView/setAllItemsToCategoryClassInLocalDataForCategorization", never, never>, updateTotalCountForTransactionCategorization: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
     selectedPeriod: MonthYearPeriod;
     selectedTab: TransactionsTab;
@@ -137,7 +129,7 @@ export declare const fetchTransactionCategorization: import("@reduxjs/toolkit").
 }, "expenseAutomationTransactionsView/fetchTransactionCategorizationSuccess">, resetOtherTabsFetchState: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
     tabs: TransactionsTab[];
     refreshViewInBackground?: boolean;
-}, "expenseAutomationTransactionsView/resetOtherTabsFetchState">, fetchTransactionCategorizationView: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[selectedTab: "review" | "autoCategorized", period: TimePeriod, cacheOverride?: any, keepExistingListItems?: any, searchString?: string | undefined, pageToken?: PageToken | undefined, refreshViewInBackground?: any, resetListItems?: any, isUncategorizedExpenseCategoryEnabled?: boolean | undefined], {
+}, "expenseAutomationTransactionsView/resetOtherTabsFetchState">, fetchTransactionCategorizationView: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[selectedTab: "review" | "autoCategorized", period: TimePeriod, cacheOverride?: any, keepExistingListItems?: any, searchString?: string | undefined, pageToken?: PageToken | undefined, refreshViewInBackground?: any, resetListItems?: any], {
     selectedTab: "review" | "autoCategorized";
     period: TimePeriod;
     searchString: string | undefined;
@@ -146,11 +138,10 @@ export declare const fetchTransactionCategorization: import("@reduxjs/toolkit").
     cacheOverride: any;
     refreshViewInBackground: any;
     resetListItems: any;
-    isUncategorizedExpenseCategoryEnabled: boolean | undefined;
 }, "expenseAutomationTransactionsView/fetchTransactionCategorizationView", never, never>, updateSelectedCheckboxTransactionIds: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
     selectedTab: TransactionsTab;
     transactionIds: ID[];
-}, "expenseAutomationTransactionsView/updateSelectedCheckboxTransactionIds">, clearExpenseAutomationTransactionsViewPerTabView: import("@reduxjs/toolkit").ActionCreatorWithPayload<"review" | "autoCategorized", "expenseAutomationTransactionsView/clearExpenseAutomationTransactionsViewPerTabView">, clearExpenseAutomationTransactionsView: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"expenseAutomationTransactionsView/clearExpenseAutomationTransactionsView">, setEntityRecommendationForLineIdsForCategorization: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[selectedTab: "review" | "autoCategorized", transactionId: TransactionID, transaction: SupportedTransactionWithCOT, lineIds: string[], entity: Entity, amount: number, recommendationWithCOTByLineId: RecommendationWithCOTByLineId, uncategorizedAccounts: UncategorizedAccounts, isUncategorizedExpenseCategoryEnabled?: boolean | undefined, isAccountingClassesEnabled?: boolean | undefined], {
+}, "expenseAutomationTransactionsView/updateSelectedCheckboxTransactionIds">, clearExpenseAutomationTransactionsViewPerTabView: import("@reduxjs/toolkit").ActionCreatorWithPayload<"review" | "autoCategorized", "expenseAutomationTransactionsView/clearExpenseAutomationTransactionsViewPerTabView">, clearExpenseAutomationTransactionsView: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"expenseAutomationTransactionsView/clearExpenseAutomationTransactionsView">, setEntityRecommendationForLineIdsForCategorization: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[selectedTab: "review" | "autoCategorized", transactionId: TransactionID, transaction: SupportedTransactionWithCOT, lineIds: string[], entity: Entity, amount: number, recommendationWithCOTByLineId: RecommendationWithCOTByLineId, uncategorizedAccounts: UncategorizedAccounts, isAccountingClassesEnabled?: boolean | undefined], {
     selectedTab: "review" | "autoCategorized";
     transactionId: TransactionID;
     transaction: SupportedTransactionWithCOT;
@@ -160,7 +151,6 @@ export declare const fetchTransactionCategorization: import("@reduxjs/toolkit").
     recommendationWithCOTByLineId: RecommendationWithCOTByLineId;
     uncategorizedAccounts: UncategorizedAccounts;
     isAccountingClassesEnabled: boolean | undefined;
-    isUncategorizedExpenseCategoryEnabled: boolean | undefined;
 }, "expenseAutomationTransactionsView/setEntityRecommendationForLineIdsForCategorization", never, never>, markCategoryClassRecommendationsInProgressForCategorization: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[selectedTab: "review" | "autoCategorized", transactionId: TransactionID, lineIds: string[]], {
     selectedTab: "review" | "autoCategorized";
     transactionId: TransactionID;
@@ -178,15 +168,12 @@ export declare const fetchTransactionCategorization: import("@reduxjs/toolkit").
     lineId: ID;
     selectedTab: TransactionsTab;
     transactionId: ID;
-}, "expenseAutomationTransactionsView/updateSelectedTransactionId">, syncTransactionCategorizationFromDetailSave: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[transactionId: TransactionID, updatedTransaction: SupportedTransactionWithCOT, pendingReviewLineIds: string[], uncategorizedIncomeExpense: UncategorizedAccounts, isUncategorizedExpenseCategoryEnabled?: boolean | undefined], {
+}, "expenseAutomationTransactionsView/updateSelectedTransactionId">, syncTransactionCategorizationFromDetailSave: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[transactionId: TransactionID, updatedTransaction: SupportedTransactionWithCOT, pendingReviewLineIds: string[]], {
     transactionId: TransactionID;
     updatedTransaction: SupportedTransactionWithCOT;
     pendingReviewLineIds: string[];
-    uncategorizedIncomeExpense: UncategorizedAccounts;
-    isUncategorizedExpenseCategoryEnabled: boolean | undefined;
-}, "expenseAutomationTransactionsView/syncTransactionCategorizationFromDetailSave", never, never>, backgroundRefetchReviewTab: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[period: TimePeriod, isUncategorizedExpenseCategoryEnabled?: boolean | undefined], {
+}, "expenseAutomationTransactionsView/syncTransactionCategorizationFromDetailSave", never, never>, backgroundRefetchReviewTab: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[period: TimePeriod], {
     period: TimePeriod;
-    isUncategorizedExpenseCategoryEnabled: boolean | undefined;
 }, "expenseAutomationTransactionsView/backgroundRefetchReviewTab", never, never>, removeTransactionFromAllTabs: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[transactionId: string], {
     transactionId: string;
 }, "expenseAutomationTransactionsView/removeTransactionFromAllTabs", never, never>, updateTransactionCategorizationUploadReceiptState: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[selectedTab: "review" | "autoCategorized", transactionId: string, fetchStatus: FetchStateAndError], {