@zeniai/client-epic-state 5.1.53-betaRD2 → 5.1.54-betaRD1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (3) hide show
  1. package/lib/esm/view/transactionDetail/transactionDetailLocalDataHelper.js +11 -14
  2. package/lib/view/transactionDetail/transactionDetailLocalDataHelper.js +11 -14
  3. package/package.json +1 -1
package/lib/esm/view/transactionDetail/transactionDetailLocalDataHelper.js CHANGED
@@ -256,7 +256,7 @@ export const getRecommendedCategoryClass = (isCategoryMiscategorized, isClassMis
256
256
  recommendedAccount = accountWithoutCOT;
257
257
  }
258
258
  if (rec.class != null &&
259
- rec.class.classId !== classObj?.classId &&
259
+ rec.class.qboId !== classObj?.qboId &&
260
260
  recommendedClass == undefined) {
261
261
  const { cot, reasoning, ...classWithoutCOT } = rec.class;
262
262
  void cot;
@@ -269,7 +269,7 @@ export const getRecommendedCategoryClass = (isCategoryMiscategorized, isClassMis
269
269
  isAccountUncategorized(uncategorizedIncomeExpense, account?.qboId);
270
270
  if ((isClassMiscategorized === false || isUncategorizedAccount) &&
271
271
  rec.class != null &&
272
- rec.class.classId === classObj?.classId) {
272
+ rec.class.qboId === classObj?.qboId) {
273
273
  isLineItemClassCorrectlyCategorized = true;
274
274
  }
275
275
  // Note: In case of uncat transactions, if category is correctly categorized,
@@ -639,11 +639,8 @@ export const setEntityRecommendationForLineIdInLocalData = (transaction, transac
639
639
  record.billable = accountLine.billable;
640
640
  record.recommendationsWithCOT = recommendationsWithCOT;
641
641
  const { recommendedAccount, recommendedClass } = getRecommendedCategoryClass(accountLine.isCategoryMiscategorized ?? false, accountLine.isClassMiscategorized ?? false, recommendationsWithCOT, accountLine.account, accountLine.class);
642
- // Account comparisons use qboId (backend guarantees every account
643
- // recommendation carries one). Class comparisons below use classId
644
- // instead: ClassBase.qboId is optional and frequently absent even
645
- // when a real class recommendation exists, so qboId-based
646
- // comparison silently dropped valid class recommendations.
642
+ // TODO: comparing with qboId because backend temporarily required us to compare
643
+ // class and account based on qbo id. This should ideally be based on accountId/ClassId
647
644
  if (recommendedAccount?.qboId !== accountLine.account.qboId &&
648
645
  Boolean(recommendedAccount?.qboId)) {
649
646
  record.isRecommendedCategorySelected = false;
@@ -671,13 +668,13 @@ export const setEntityRecommendationForLineIdInLocalData = (transaction, transac
671
668
  record.isRetainedCategorySelected = false;
672
669
  }
673
670
  }
674
- if (recommendedClass?.classId !== accountLine.class?.classId &&
675
- Boolean(recommendedClass?.classId)) {
671
+ if (recommendedClass?.qboId !== accountLine.class?.qboId &&
672
+ Boolean(recommendedClass?.qboId)) {
676
673
  record.isRecommendedClassSelected = false;
677
674
  record.recommendedClass = recommendedClass;
678
675
  record.isClassUpdateSelected = false;
679
676
  if (accountLine.isClassMiscategorized &&
680
- Boolean(accountLine.class?.classId)) {
677
+ Boolean(accountLine.class?.qboId)) {
681
678
  record.retainedClass = accountLine.class;
682
679
  record.isRetainedClassSelected = false;
683
680
  }
@@ -685,12 +682,12 @@ export const setEntityRecommendationForLineIdInLocalData = (transaction, transac
685
682
  else {
686
683
  record.isRecommendedClassSelected = false;
687
684
  record.recommendedClass = recommendedClass;
688
- if (recommendedClass?.classId === accountLine.class?.classId) {
685
+ if (recommendedClass?.qboId === accountLine.class?.qboId) {
689
686
  record.recommendedClass = undefined;
690
687
  }
691
688
  record.isClassUpdateSelected = false;
692
689
  if (accountLine.isClassMiscategorized &&
693
- Boolean(accountLine.class?.classId)) {
690
+ Boolean(accountLine.class?.qboId)) {
694
691
  record.retainedClass = recommendedClass;
695
692
  record.isRetainedClassSelected = false;
696
693
  }
@@ -706,8 +703,8 @@ export const setEntityRecommendationForLineIdInLocalData = (transaction, transac
706
703
  Boolean(recommendedAccount?.qboId) !== false) {
707
704
  record.account = recommendedAccount;
708
705
  }
709
- if (Boolean(record.class?.classId) === false &&
710
- Boolean(recommendedClass?.classId) !== false) {
706
+ if (Boolean(record.class?.qboId) === false &&
707
+ Boolean(recommendedClass?.qboId) !== false) {
711
708
  record.class = recommendedClass;
712
709
  }
713
710
  newLineItems[line.id] = record;
package/lib/view/transactionDetail/transactionDetailLocalDataHelper.js CHANGED
@@ -261,7 +261,7 @@ const getRecommendedCategoryClass = (isCategoryMiscategorized, isClassMiscategor
261
261
  recommendedAccount = accountWithoutCOT;
262
262
  }
263
263
  if (rec.class != null &&
264
- rec.class.classId !== classObj?.classId &&
264
+ rec.class.qboId !== classObj?.qboId &&
265
265
  recommendedClass == undefined) {
266
266
  const { cot, reasoning, ...classWithoutCOT } = rec.class;
267
267
  void cot;
@@ -274,7 +274,7 @@ const getRecommendedCategoryClass = (isCategoryMiscategorized, isClassMiscategor
274
274
  (0, exports.isAccountUncategorized)(uncategorizedIncomeExpense, account?.qboId);
275
275
  if ((isClassMiscategorized === false || isUncategorizedAccount) &&
276
276
  rec.class != null &&
277
- rec.class.classId === classObj?.classId) {
277
+ rec.class.qboId === classObj?.qboId) {
278
278
  isLineItemClassCorrectlyCategorized = true;
279
279
  }
280
280
  // Note: In case of uncat transactions, if category is correctly categorized,
@@ -648,11 +648,8 @@ const setEntityRecommendationForLineIdInLocalData = (transaction, transactionDet
648
648
  record.billable = accountLine.billable;
649
649
  record.recommendationsWithCOT = recommendationsWithCOT;
650
650
  const { recommendedAccount, recommendedClass } = (0, exports.getRecommendedCategoryClass)(accountLine.isCategoryMiscategorized ?? false, accountLine.isClassMiscategorized ?? false, recommendationsWithCOT, accountLine.account, accountLine.class);
651
- // Account comparisons use qboId (backend guarantees every account
652
- // recommendation carries one). Class comparisons below use classId
653
- // instead: ClassBase.qboId is optional and frequently absent even
654
- // when a real class recommendation exists, so qboId-based
655
- // comparison silently dropped valid class recommendations.
651
+ // TODO: comparing with qboId because backend temporarily required us to compare
652
+ // class and account based on qbo id. This should ideally be based on accountId/ClassId
656
653
  if (recommendedAccount?.qboId !== accountLine.account.qboId &&
657
654
  Boolean(recommendedAccount?.qboId)) {
658
655
  record.isRecommendedCategorySelected = false;
@@ -680,13 +677,13 @@ const setEntityRecommendationForLineIdInLocalData = (transaction, transactionDet
680
677
  record.isRetainedCategorySelected = false;
681
678
  }
682
679
  }
683
- if (recommendedClass?.classId !== accountLine.class?.classId &&
684
- Boolean(recommendedClass?.classId)) {
680
+ if (recommendedClass?.qboId !== accountLine.class?.qboId &&
681
+ Boolean(recommendedClass?.qboId)) {
685
682
  record.isRecommendedClassSelected = false;
686
683
  record.recommendedClass = recommendedClass;
687
684
  record.isClassUpdateSelected = false;
688
685
  if (accountLine.isClassMiscategorized &&
689
- Boolean(accountLine.class?.classId)) {
686
+ Boolean(accountLine.class?.qboId)) {
690
687
  record.retainedClass = accountLine.class;
691
688
  record.isRetainedClassSelected = false;
692
689
  }
@@ -694,12 +691,12 @@ const setEntityRecommendationForLineIdInLocalData = (transaction, transactionDet
694
691
  else {
695
692
  record.isRecommendedClassSelected = false;
696
693
  record.recommendedClass = recommendedClass;
697
- if (recommendedClass?.classId === accountLine.class?.classId) {
694
+ if (recommendedClass?.qboId === accountLine.class?.qboId) {
698
695
  record.recommendedClass = undefined;
699
696
  }
700
697
  record.isClassUpdateSelected = false;
701
698
  if (accountLine.isClassMiscategorized &&
702
- Boolean(accountLine.class?.classId)) {
699
+ Boolean(accountLine.class?.qboId)) {
703
700
  record.retainedClass = recommendedClass;
704
701
  record.isRetainedClassSelected = false;
705
702
  }
@@ -715,8 +712,8 @@ const setEntityRecommendationForLineIdInLocalData = (transaction, transactionDet
715
712
  Boolean(recommendedAccount?.qboId) !== false) {
716
713
  record.account = recommendedAccount;
717
714
  }
718
- if (Boolean(record.class?.classId) === false &&
719
- Boolean(recommendedClass?.classId) !== false) {
715
+ if (Boolean(record.class?.qboId) === false &&
716
+ Boolean(recommendedClass?.qboId) !== false) {
720
717
  record.class = recommendedClass;
721
718
  }
722
719
  newLineItems[line.id] = record;
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@zeniai/client-epic-state",
3
- "version": "5.1.53-betaRD2",
3
+ "version": "5.1.54-betaRD1",
4
4
  "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
5
5
  "main": "lib/index.js",
6
6
  "module": "lib/esm/index.js",