@zeniai/client-epic-state 5.1.52-beta0RD → 5.1.53-betaRD1

package/lib/esm/view/transactionDetail/epics/markTransactionAsNotMiscategorizedEpic.js

@@ -4,11 +4,99 @@ import { toMonthYearPeriodId } from '../../../commonStateTypes/timePeriod';
 import { openSnackbar } from '../../../entity/snackbar/snackbarReducer';
 import { getCurrentTenant } from '../../../entity/tenant/tenantSelector';
 import { removeTransactionCategorization, updateTransactionIsMiscategorized, } from '../../../entity/transaction/transactionReducer';
-import { createZeniAPIStatus, isSuccessStatus, } from '../../../responsePayload';
+import { getSupportedTransactionById } from '../../../entity/transaction/transactionSelector';
+import { createZeniAPIStatus, isSuccessResponse, isSuccessStatus, } from '../../../responsePayload';
 import { updateStatusForTransactionNotMiscategorizedUpdateForCategorization, updateTotalCountForTransactionCategorization, } from '../../expenseAutomationView/reducers/transactionsViewReducer';
 import { markTransactionAsNotMiscategorized, updateStatusConsolidatedSaveTransactionDetail, updateStatusForTransactionNotMiscategorizedUpdate, } from '../transactionDetailReducer';
 import { getTransactionDetailKey } from '../transactionDetailState';
 export const markTransactionAsNotMiscategorizedEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(markTransactionAsNotMiscategorized.match), mergeMap((action) => {
+    if (action.payload.isExpenseAutomationEnabled === true) {
+        const transactionKey = getTransactionDetailKey(action.payload.transactionId);
+        const transaction = getSupportedTransactionById(state$.value.transactionState, transactionKey);
+        const lineIds = (action.payload.lineIds?.length ?? 0) > 0
+            ? action.payload.lineIds
+            : (transaction?.lines ?? []).map((line) => line.id);
+        return zeniAPI
+            .putAndGetJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/expense-automation/mark-as-reviewed`, {
+            transactions_reviewed: [
+                {
+                    transaction_id: action.payload.transactionId.id,
+                    line_ids: lineIds,
+                },
+            ],
+        })
+            .pipe(mergeMap((response) => {
+            if (isSuccessResponse(response)) {
+                const actions = [];
+                actions.push(updateStatusForTransactionNotMiscategorizedUpdate(action.payload.transactionId, 'Completed', undefined));
+                const txnId = action.payload.transactionId.id;
+                const reviewedFailed = response.data?.transactions_reviewed_failed ?? [];
+                const isTransactionFailed = reviewedFailed.some((t) => t.transaction_id === txnId);
+                if (!isTransactionFailed) {
+                    actions.push(updateTransactionIsMiscategorized(transactionKey, false));
+                    const { expenseAutomationViewState, expenseAutomationTransactionsViewState, } = state$.value;
+                    const { transactionCategorizationView, selectedTransactionCategorizationTab, } = expenseAutomationTransactionsViewState;
+                    const currentTenantId = getCurrentTenant(state$.value)?.tenantId;
+                    const { selectedPeriodByTenantId } = expenseAutomationViewState;
+                    const selectedPeriod = currentTenantId != null
+                        ? selectedPeriodByTenantId[currentTenantId]
+                        : undefined;
+                    const autoTabLineItems = transactionCategorizationView.autoCategorized
+                        .transactionReviewLocalDataById[txnId]
+                        ?.transactionReviewLocalData.tabSpecificLineItems
+                        ?.autoCategorized ?? [];
+                    const hasAutoLines = autoTabLineItems.length > 0;
+                    const { uiState } = transactionCategorizationView[selectedTransactionCategorizationTab];
+                    const removeIdsFromPeriod = selectedTransactionCategorizationTab === 'review'
+                        ? [txnId]
+                        : hasAutoLines
+                            ? []
+                            : [txnId];
+                    if (selectedPeriod != null) {
+                        actions.push(updateStatusForTransactionNotMiscategorizedUpdateForCategorization(selectedTransactionCategorizationTab, [txnId], removeIdsFromPeriod, selectedPeriod, 'Completed'));
+                    }
+                    if (!hasAutoLines) {
+                        actions.push(removeTransactionCategorization({
+                            transactionIds: [txnId],
+                        }));
+                    }
+                    if (removeIdsFromPeriod.length > 0 &&
+                        selectedPeriod != null) {
+                        const totalCountByPeriod = uiState.totalCount[toMonthYearPeriodId(selectedPeriod)];
+                        const safeTotalCount = totalCountByPeriod ?? 0;
+                        const updatedTotalCount = Math.max(0, safeTotalCount - 1);
+                        actions.push(updateTotalCountForTransactionCategorization({
+                            selectedPeriod,
+                            selectedTab: selectedTransactionCategorizationTab,
+                            totalCount: updatedTotalCount,
+                        }));
+                    }
+                }
+                actions.push(updateStatusConsolidatedSaveTransactionDetail({
+                    transactionId: action.payload.transactionId,
+                    fetchState: 'Completed',
+                }));
+                if (action.payload.transactionSaveUpdates.anyBulkUpdates === true) {
+                    actions.push(openSnackbar({
+                        messageSection: 'transactionDetails_updatingPastTransactions',
+                        messageText: 'success',
+                        type: 'success',
+                    }));
+                }
+                else {
+                    actions.push(openSnackbar({
+                        messageSection: 'transactionDetails_transactionUpdated',
+                        messageText: 'success',
+                        type: 'success',
+                    }));
+                }
+                return from(actions);
+            }
+            else {
+                return of(updateStatusForTransactionNotMiscategorizedUpdate(action.payload.transactionId, 'Error', response.status));
+            }
+        }), catchError((error) => of(updateStatusForTransactionNotMiscategorizedUpdate(action.payload.transactionId, 'Error', createZeniAPIStatus('Unexpected Error', `Transaction mark as reviewed REST API call errored out ${error}`)))));
+    }
     return zeniAPI
         .putAndGetJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/transactions/${action.payload.transactionId.id}/mark-miscategorized-as-correct`, preparePayload(action.payload.transactionId))
         .pipe(mergeMap((response) => {
@@ -16,44 +104,7 @@ export const markTransactionAsNotMiscategorizedEpic = (actions$, state$, zeniAPI
             const actions = [];
             actions.push(updateStatusForTransactionNotMiscategorizedUpdate(action.payload.transactionId, 'Completed', undefined));
             const transactionKey = getTransactionDetailKey(action.payload.transactionId);
-            // Mark this transaction as not miscategorized anymore
             actions.push(updateTransactionIsMiscategorized(transactionKey, false));
-            if (action.payload.isExpenseAutomationEnabled === true) {
-                const { expenseAutomationViewState, expenseAutomationTransactionsViewState, } = state$.value;
-                const { transactionCategorizationView, selectedTransactionCategorizationTab, } = expenseAutomationTransactionsViewState;
-                const currentTenant = getCurrentTenant(state$.value);
-                const { selectedPeriodByTenantId } = expenseAutomationViewState;
-                const selectedPeriod = selectedPeriodByTenantId[currentTenant.tenantId];
-                const txnId = action.payload.transactionId.id;
-                const autoTabLineItems = transactionCategorizationView.autoCategorized
-                    .transactionReviewLocalDataById[txnId]
-                    ?.transactionReviewLocalData.tabSpecificLineItems
-                    .autoCategorized ?? [];
-                const hasAutoLines = autoTabLineItems.length > 0;
-                const { uiState } = transactionCategorizationView[selectedTransactionCategorizationTab];
-                const removeIdsFromPeriod = selectedTransactionCategorizationTab === 'review'
-                    ? [txnId]
-                    : hasAutoLines
-                        ? []
-                        : [txnId];
-                actions.push(updateStatusForTransactionNotMiscategorizedUpdateForCategorization(selectedTransactionCategorizationTab, [txnId], removeIdsFromPeriod, selectedPeriod, 'Completed'));
-                if (!hasAutoLines) {
-                    actions.push(removeTransactionCategorization({
-                        transactionIds: [txnId],
-                    }));
-                }
-                if (removeIdsFromPeriod.length > 0) {
-                    const totalCountByPeriod = uiState.totalCount[toMonthYearPeriodId(selectedPeriod)];
-                    const updatedTotalCount = totalCountByPeriod === 0
-                        ? totalCountByPeriod
-                        : totalCountByPeriod - 1;
-                    actions.push(updateTotalCountForTransactionCategorization({
-                        selectedPeriod,
-                        selectedTab: selectedTransactionCategorizationTab,
-                        totalCount: updatedTotalCount,
-                    }));
-                }
-            }
             actions.push(updateStatusConsolidatedSaveTransactionDetail({
                 transactionId: action.payload.transactionId,
                 fetchState: 'Completed',
@@ -66,7 +117,6 @@ export const markTransactionAsNotMiscategorizedEpic = (actions$, state$, zeniAPI
                 }));
             }
             else {
-                //Finally everything done for this transaction
                 actions.push(openSnackbar({
                     messageSection: 'transactionDetails_transactionUpdated',
                     messageText: 'success',

package/lib/esm/view/transactionDetail/epics/updateTransactionDetailEpic.js

@@ -3,6 +3,7 @@ import { from, of } from 'rxjs';
 import { catchError, filter, mergeMap } from 'rxjs/operators';
 import { toRecommendationPayload } from '../../../commonPayloadTypes/recommendationPayload';
 import { openSnackbar } from '../../../entity/snackbar/snackbarReducer';
+import { getIsAccountingClassesEnabled, getIsAccountingProjectsEnabled, } from '../../../entity/tenant/tenantSelector';
 import { toCustomerTransactionPayload } from '../../../entity/transaction/payloadTypes/customerTransactionPayload';
 import { toTransferTransactionPayload } from '../../../entity/transaction/payloadTypes/otherTransactionPayload';
 import { toTransactionID } from '../../../entity/transaction/payloadTypes/transactionIDPayload';
@@ -10,7 +11,7 @@ import { injectCOTFlagsIntoTransactionPayload, toTransactionPayload, } from '../
 import { toVendorTransactionPayload, toVendorTransactionWithCustomerPayload, } from '../../../entity/transaction/payloadTypes/vendorTransactionPayload';
 import { isCustomerTransaction, } from '../../../entity/transaction/stateTypes/customerTransaction';
 import { isTransferTransaction, } from '../../../entity/transaction/stateTypes/otherTransaction';
-import { toJEAndDepositTransactionTypeStrict, toVendorTransactionTypeStrict, } from '../../../entity/transaction/stateTypes/transactionType';
+import { toJEAndDepositTransactionTypeStrict } from '../../../entity/transaction/stateTypes/transactionType';
 import { isVendorTransaction, } from '../../../entity/transaction/stateTypes/vendorTransaction';
 import toSupportedTransaction from '../../../entity/transaction/toSupportedTransaction';
 import { getTransactionWithCOT } from '../../../entity/transaction/transactionHelper';
@@ -19,13 +20,12 @@ import { getSupportedTransactionById } from '../../../entity/transaction/transac
 import { updateVendors } from '../../../entity/vendor/vendorReducer';
 import { getVendorByVendorId } from '../../../entity/vendor/vendorSelector';
 import { createZeniAPIStatus, isActionNotAllowed, isSuccessResponse, } from '../../../responsePayload';
-import { getIsAccountingClassesEnabled, getIsAccountingProjectsEnabled, } from '../../../entity/tenant/tenantSelector';
-import { getUncategorizedAccounts } from '../../accountList/accountListSelector';
+import { getUncategorizedAccounts, } from '../../accountList/accountListSelector';
 import { getPendingReviewLineIdsFromTransaction } from '../../expenseAutomationView/helpers/transactionCategorizationLocalDataHelper';
 import { syncTransactionCategorizationFromDetailSave } from '../../expenseAutomationView/reducers/transactionsViewReducer';
+import { isAccountUncategorized } from '../transactionDetailLocalDataHelper';
 import { initializeTransactionDetailLocalData, markTransactionAsNotMiscategorized, updateStatusConsolidatedSaveTransactionDetail, updateTransactionDetail, updateTransactionDetailSaveStatus, updateTransactionStateIfUpdateActionNotAllowed, } from '../transactionDetailReducer';
 import { getTransactionDetailKey, } from '../transactionDetailState';
-import { isTransactionUncategorized } from './saveTransactionHelper';
 export const updateTransactionDetailEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(updateTransactionDetail.match), mergeMap((action) => {
     const { transactionState, vendorState, transactionDetailState } = state$.value;
     const isAccountingProjectsEnabled = getIsAccountingProjectsEnabled(state$.value);
@@ -36,24 +36,6 @@ export const updateTransactionDetailEpic = (actions$, state$, zeniAPI) => action
         if (isSuccessResponse(response) && response.data != null) {
             const transactionIdResp = toTransactionID(response.data.transaction);
             const transactionDetailKeyForResponse = getTransactionDetailKey(transactionIdResp);
-            const tranDetail = recordGet(transactionDetailState.transactionDetailById, transactionDetailKeyForResponse, undefined);
-            const tranVendorUpdates = tranDetail?.transactionDetailLocalData.vendorUpdates;
-            let vendorUpdates = undefined;
-            if (tranVendorUpdates?.qboId != null) {
-                const vendor = getVendorByVendorId(vendorState, tranVendorUpdates.qboId);
-                if (vendor != null) {
-                    vendorUpdates = {
-                        id: vendor?.qboId,
-                        name: vendor?.name,
-                    };
-                }
-                else if (tranVendorUpdates.name != null) {
-                    vendorUpdates = {
-                        id: tranVendorUpdates.qboId,
-                        name: tranVendorUpdates.name,
-                    };
-                }
-            }
             const actions = [];
             if (response.data.vendors != null) {
                 actions.push(updateVendors(response.data.vendors, 'merge'));
@@ -66,30 +48,14 @@ export const updateTransactionDetailEpic = (actions$, state$, zeniAPI) => action
                 vendorId: response.data.vendors?.[0]?.vendor_id,
             }));
             actions.push(updateTransactionDetailSaveStatus(transactionIdResp, 'Completed'));
-            let callMarkTransactionAsNotMiscategorized = true;
-            // NOTE: If tran is vendorType OR JE OR Deposit transaction and there is no vendor chosen on this tranaction while saving,
-            // then we need to skip mark-miscategorized-as-correct api call
-            if (toVendorTransactionTypeStrict(response.data.transaction.transaction_type) != null ||
-                toJEAndDepositTransactionTypeStrict(response.data.transaction.transaction_type) != null) {
-                const isAccountingClassesEnabled = getIsAccountingClassesEnabled(state$.value);
-                const isAnyClassMissing = isAccountingClassesEnabled &&
-                    checkIfClassMissingForAnyLineItem(response.data.transaction);
-                const isVendorOrCustomerMissingInAnyLine = toJEAndDepositTransactionTypeStrict(response.data.transaction.transaction_type) != null &&
-                    checkIfVendorOrCustomerMissingForAnyLineItem(response.data.transaction);
-                if ((vendorUpdates?.id == null &&
-                    isVendorOrCustomerMissingInAnyLine == true) ||
-                    isAnyClassMissing == true) {
-                    callMarkTransactionAsNotMiscategorized = false;
-                }
-            }
             const uncategorizedIncomeExpense = getUncategorizedAccounts(state$.value.accountState, state$.value.accountListState, 'accountList');
             const transaction = toSupportedTransaction(response.data.transaction);
-            const isTransactionUnCategorized = isTransactionUncategorized(transaction, uncategorizedIncomeExpense);
+            const isAccountingClassesEnabled = getIsAccountingClassesEnabled(state$.value);
+            const eligibleLineIds = getLineIdsEligibleForReview(transaction, uncategorizedIncomeExpense, isAccountingClassesEnabled, action.payload.isExpenseAutomationEnabled);
             if (action.payload.transactionSaveUpdates.markAsMiscatUpdates ===
                 true &&
-                callMarkTransactionAsNotMiscategorized === true &&
-                isTransactionUnCategorized === false) {
-                actions.push(markTransactionAsNotMiscategorized(transactionIdResp, action.payload.transactionSaveUpdates, action.payload.isExpenseAutomationEnabled));
+                eligibleLineIds.length > 0) {
+                actions.push(markTransactionAsNotMiscategorized(transactionIdResp, action.payload.transactionSaveUpdates, action.payload.isExpenseAutomationEnabled, eligibleLineIds));
             }
             else {
                 actions.push(updateStatusConsolidatedSaveTransactionDetail({
@@ -299,31 +265,58 @@ export const toTransactionUpdatePayload = (updates, detail, cotTransactionTracki
     // Inject COT flags into the payload
     return injectCOTFlagsIntoTransactionPayload(basePayload, transaction);
 };
-const checkIfClassMissingForAnyLineItem = (transactionPayload) => {
-    let isAnyClassMissing = false;
-    if (transactionPayload.lines != null) {
-        transactionPayload.lines.forEach((line) => {
-            if (line.line_detail?.class
-                ?.accounting_class_id == null) {
-                isAnyClassMissing = true;
+const getLineIdsEligibleForReview = (transaction, uncategorizedIncomeExpense, isAccountingClassesEnabled, isExpenseAutomationEnabled) => {
+    // For non-EA, any line missing a required field (class when enabled, or entity on JE/Deposit)
+    // suppresses the entire call. EA keeps the per-line model, returning only eligible line IDs.
+    if (!isExpenseAutomationEnabled) {
+        const isApplicableType = isVendorTransaction(transaction) ||
+            toJEAndDepositTransactionTypeStrict(transaction.type) != null;
+        if (isApplicableType) {
+            const lines = (transaction.lines ?? []).filter((line) => line.type === 'transaction_with_account_and_class_line' ||
+                line.type === 'journal_entry_transaction_line' ||
+                line.type === 'transaction_with_product_or_service_line');
+            if (isAccountingClassesEnabled) {
+                const anyLineMissingClass = lines.some((line) => (line.class?.classId ??
+                    '') === '');
+                if (anyLineMissingClass) {
+                    return [];
+                }
             }
-        });
-    }
-    return isAnyClassMissing;
-};
-const checkIfVendorOrCustomerMissingForAnyLineItem = (transactionPayload) => {
-    let isAnyVendorOrCustomerMissing = false;
-    if (transactionPayload.lines != null) {
-        transactionPayload.lines.forEach((line) => {
-            if (line.line_detail
-                ?.vendor == null &&
-                line.line_detail
-                    ?.customer == null) {
-                isAnyVendorOrCustomerMissing = true;
+            if (toJEAndDepositTransactionTypeStrict(transaction.type) != null) {
+                const anyLineMissingEntity = lines.some((line) => {
+                    const tl = line;
+                    return tl.vendor == null && tl.customer == null;
+                });
+                if (anyLineMissingEntity) {
+                    return [];
+                }
             }
-        });
+        }
     }
-    return isAnyVendorOrCustomerMissing;
+    return (transaction.lines ?? [])
+        .filter((line) => {
+        if (line.type !== 'transaction_with_account_and_class_line' &&
+            line.type !== 'journal_entry_transaction_line' &&
+            line.type !== 'transaction_with_product_or_service_line') {
+            return false;
+        }
+        const typedLine = line;
+        const hasCategory = !isAccountUncategorized(uncategorizedIncomeExpense, typedLine.account?.qboId);
+        // class is always a ClassBase object (never null) because the payload mapper
+        // calls mapClassBasePayloadToClassBase(payload ?? {}) which returns {} with classId:''.
+        // A real class is indicated by a non-empty classId.
+        const hasClass = !isAccountingClassesEnabled || (typedLine.class?.classId ?? '') !== '';
+        const hasAmount = (typedLine.amount?.amount ?? 0) !== 0;
+        // JE lines and Deposit transactions require vendor or customer before being eligible for review.
+        const isJEOrDepositContext = line.type === 'journal_entry_transaction_line' ||
+            toJEAndDepositTransactionTypeStrict(transaction.type) != null;
+        const hasEntity = !isJEOrDepositContext ||
+            typedLine.vendor != null ||
+            typedLine.customer != null;
+        return hasCategory && hasClass && hasAmount && hasEntity;
+    })
+        .map((line) => line.id)
+        .filter(Boolean);
 };
 // Converts a locally-created line item (from edit mode) into the wire shape
 // expected by the categorize endpoint. Sending id='' signals the backend to

package/lib/esm/view/transactionDetail/transactionDetailLocalDataHelper.js

@@ -755,6 +755,7 @@ export const setEntityRecommendationForLineIdInLocalData = (transaction, transac
         latestUpdatedLineWithEntity: transactionDetailLocalData.latestUpdatedLineWithEntity,
         vendorBulkUpdateCategoryClassRecommendationsFetchStatus: transactionDetailLocalData.vendorBulkUpdateCategoryClassRecommendationsFetchStatus,
         selectedEntity: transactionDetailLocalData.selectedEntity,
+        editMode: transactionDetailLocalData.editMode,
     };
     return newLocalData;
 };
@@ -808,6 +809,7 @@ export const removeEntityRecommendationForLineIdInLocalData = (transaction, tran
         latestSelectedEntityOnLineItem: transactionDetailLocalData.latestSelectedEntityOnLineItem,
         latestUpdatedLineWithEntity: transactionDetailLocalData.latestUpdatedLineWithEntity,
         selectedEntity: transactionDetailLocalData.selectedEntity,
+        editMode: transactionDetailLocalData.editMode,
     };
     return newLocalData;
 };
@@ -827,7 +829,8 @@ export const getChangedLineItemCountFromLocalData = (transaction, transactionLoc
                     const accountLine = line;
                     hasCategoryChanged =
                         accountLineLocal.account?.qboId !== accountLine.account.qboId &&
-                            accountLineLocal.account?.accountId !== accountLine.account.accountId;
+                            accountLineLocal.account?.accountId !==
+                                accountLine.account.accountId;
                     hasClassChanged =
                         (accountLineLocal.class?.qboId != null ||
                             accountLine.class?.qboId != null) &&

package/lib/esm/view/transactionDetail/transactionDetailReducer.js

@@ -190,12 +190,13 @@ const transactionDetail = createSlice({
                     };
                 }
             },
-            prepare(transactionId, transactionSaveUpdates, isExpenseAutomationEnabled) {
+            prepare(transactionId, transactionSaveUpdates, isExpenseAutomationEnabled, lineIds) {
                 return {
                     payload: {
                         transactionId,
                         transactionSaveUpdates,
                         isExpenseAutomationEnabled,
+                        lineIds,
                     },
                 };
             },

package/lib/view/transactionDetail/epics/markTransactionAsNotMiscategorizedEpic.js

@@ -7,11 +7,99 @@ const timePeriod_1 = require("../../../commonStateTypes/timePeriod");
 const snackbarReducer_1 = require("../../../entity/snackbar/snackbarReducer");
 const tenantSelector_1 = require("../../../entity/tenant/tenantSelector");
 const transactionReducer_1 = require("../../../entity/transaction/transactionReducer");
+const transactionSelector_1 = require("../../../entity/transaction/transactionSelector");
 const responsePayload_1 = require("../../../responsePayload");
 const transactionsViewReducer_1 = require("../../expenseAutomationView/reducers/transactionsViewReducer");
 const transactionDetailReducer_1 = require("../transactionDetailReducer");
 const transactionDetailState_1 = require("../transactionDetailState");
 const markTransactionAsNotMiscategorizedEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(transactionDetailReducer_1.markTransactionAsNotMiscategorized.match), (0, operators_1.mergeMap)((action) => {
+    if (action.payload.isExpenseAutomationEnabled === true) {
+        const transactionKey = (0, transactionDetailState_1.getTransactionDetailKey)(action.payload.transactionId);
+        const transaction = (0, transactionSelector_1.getSupportedTransactionById)(state$.value.transactionState, transactionKey);
+        const lineIds = (action.payload.lineIds?.length ?? 0) > 0
+            ? action.payload.lineIds
+            : (transaction?.lines ?? []).map((line) => line.id);
+        return zeniAPI
+            .putAndGetJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/expense-automation/mark-as-reviewed`, {
+            transactions_reviewed: [
+                {
+                    transaction_id: action.payload.transactionId.id,
+                    line_ids: lineIds,
+                },
+            ],
+        })
+            .pipe((0, operators_1.mergeMap)((response) => {
+            if ((0, responsePayload_1.isSuccessResponse)(response)) {
+                const actions = [];
+                actions.push((0, transactionDetailReducer_1.updateStatusForTransactionNotMiscategorizedUpdate)(action.payload.transactionId, 'Completed', undefined));
+                const txnId = action.payload.transactionId.id;
+                const reviewedFailed = response.data?.transactions_reviewed_failed ?? [];
+                const isTransactionFailed = reviewedFailed.some((t) => t.transaction_id === txnId);
+                if (!isTransactionFailed) {
+                    actions.push((0, transactionReducer_1.updateTransactionIsMiscategorized)(transactionKey, false));
+                    const { expenseAutomationViewState, expenseAutomationTransactionsViewState, } = state$.value;
+                    const { transactionCategorizationView, selectedTransactionCategorizationTab, } = expenseAutomationTransactionsViewState;
+                    const currentTenantId = (0, tenantSelector_1.getCurrentTenant)(state$.value)?.tenantId;
+                    const { selectedPeriodByTenantId } = expenseAutomationViewState;
+                    const selectedPeriod = currentTenantId != null
+                        ? selectedPeriodByTenantId[currentTenantId]
+                        : undefined;
+                    const autoTabLineItems = transactionCategorizationView.autoCategorized
+                        .transactionReviewLocalDataById[txnId]
+                        ?.transactionReviewLocalData.tabSpecificLineItems
+                        ?.autoCategorized ?? [];
+                    const hasAutoLines = autoTabLineItems.length > 0;
+                    const { uiState } = transactionCategorizationView[selectedTransactionCategorizationTab];
+                    const removeIdsFromPeriod = selectedTransactionCategorizationTab === 'review'
+                        ? [txnId]
+                        : hasAutoLines
+                            ? []
+                            : [txnId];
+                    if (selectedPeriod != null) {
+                        actions.push((0, transactionsViewReducer_1.updateStatusForTransactionNotMiscategorizedUpdateForCategorization)(selectedTransactionCategorizationTab, [txnId], removeIdsFromPeriod, selectedPeriod, 'Completed'));
+                    }
+                    if (!hasAutoLines) {
+                        actions.push((0, transactionReducer_1.removeTransactionCategorization)({
+                            transactionIds: [txnId],
+                        }));
+                    }
+                    if (removeIdsFromPeriod.length > 0 &&
+                        selectedPeriod != null) {
+                        const totalCountByPeriod = uiState.totalCount[(0, timePeriod_1.toMonthYearPeriodId)(selectedPeriod)];
+                        const safeTotalCount = totalCountByPeriod ?? 0;
+                        const updatedTotalCount = Math.max(0, safeTotalCount - 1);
+                        actions.push((0, transactionsViewReducer_1.updateTotalCountForTransactionCategorization)({
+                            selectedPeriod,
+                            selectedTab: selectedTransactionCategorizationTab,
+                            totalCount: updatedTotalCount,
+                        }));
+                    }
+                }
+                actions.push((0, transactionDetailReducer_1.updateStatusConsolidatedSaveTransactionDetail)({
+                    transactionId: action.payload.transactionId,
+                    fetchState: 'Completed',
+                }));
+                if (action.payload.transactionSaveUpdates.anyBulkUpdates === true) {
+                    actions.push((0, snackbarReducer_1.openSnackbar)({
+                        messageSection: 'transactionDetails_updatingPastTransactions',
+                        messageText: 'success',
+                        type: 'success',
+                    }));
+                }
+                else {
+                    actions.push((0, snackbarReducer_1.openSnackbar)({
+                        messageSection: 'transactionDetails_transactionUpdated',
+                        messageText: 'success',
+                        type: 'success',
+                    }));
+                }
+                return (0, rxjs_1.from)(actions);
+            }
+            else {
+                return (0, rxjs_1.of)((0, transactionDetailReducer_1.updateStatusForTransactionNotMiscategorizedUpdate)(action.payload.transactionId, 'Error', response.status));
+            }
+        }), (0, operators_1.catchError)((error) => (0, rxjs_1.of)((0, transactionDetailReducer_1.updateStatusForTransactionNotMiscategorizedUpdate)(action.payload.transactionId, 'Error', (0, responsePayload_1.createZeniAPIStatus)('Unexpected Error', `Transaction mark as reviewed REST API call errored out ${error}`)))));
+    }
     return zeniAPI
         .putAndGetJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/transactions/${action.payload.transactionId.id}/mark-miscategorized-as-correct`, preparePayload(action.payload.transactionId))
         .pipe((0, operators_1.mergeMap)((response) => {
@@ -19,44 +107,7 @@ const markTransactionAsNotMiscategorizedEpic = (actions$, state$, zeniAPI) => ac
             const actions = [];
             actions.push((0, transactionDetailReducer_1.updateStatusForTransactionNotMiscategorizedUpdate)(action.payload.transactionId, 'Completed', undefined));
             const transactionKey = (0, transactionDetailState_1.getTransactionDetailKey)(action.payload.transactionId);
-            // Mark this transaction as not miscategorized anymore
             actions.push((0, transactionReducer_1.updateTransactionIsMiscategorized)(transactionKey, false));
-            if (action.payload.isExpenseAutomationEnabled === true) {
-                const { expenseAutomationViewState, expenseAutomationTransactionsViewState, } = state$.value;
-                const { transactionCategorizationView, selectedTransactionCategorizationTab, } = expenseAutomationTransactionsViewState;
-                const currentTenant = (0, tenantSelector_1.getCurrentTenant)(state$.value);
-                const { selectedPeriodByTenantId } = expenseAutomationViewState;
-                const selectedPeriod = selectedPeriodByTenantId[currentTenant.tenantId];
-                const txnId = action.payload.transactionId.id;
-                const autoTabLineItems = transactionCategorizationView.autoCategorized
-                    .transactionReviewLocalDataById[txnId]
-                    ?.transactionReviewLocalData.tabSpecificLineItems
-                    .autoCategorized ?? [];
-                const hasAutoLines = autoTabLineItems.length > 0;
-                const { uiState } = transactionCategorizationView[selectedTransactionCategorizationTab];
-                const removeIdsFromPeriod = selectedTransactionCategorizationTab === 'review'
-                    ? [txnId]
-                    : hasAutoLines
-                        ? []
-                        : [txnId];
-                actions.push((0, transactionsViewReducer_1.updateStatusForTransactionNotMiscategorizedUpdateForCategorization)(selectedTransactionCategorizationTab, [txnId], removeIdsFromPeriod, selectedPeriod, 'Completed'));
-                if (!hasAutoLines) {
-                    actions.push((0, transactionReducer_1.removeTransactionCategorization)({
-                        transactionIds: [txnId],
-                    }));
-                }
-                if (removeIdsFromPeriod.length > 0) {
-                    const totalCountByPeriod = uiState.totalCount[(0, timePeriod_1.toMonthYearPeriodId)(selectedPeriod)];
-                    const updatedTotalCount = totalCountByPeriod === 0
-                        ? totalCountByPeriod
-                        : totalCountByPeriod - 1;
-                    actions.push((0, transactionsViewReducer_1.updateTotalCountForTransactionCategorization)({
-                        selectedPeriod,
-                        selectedTab: selectedTransactionCategorizationTab,
-                        totalCount: updatedTotalCount,
-                    }));
-                }
-            }
             actions.push((0, transactionDetailReducer_1.updateStatusConsolidatedSaveTransactionDetail)({
                 transactionId: action.payload.transactionId,
                 fetchState: 'Completed',
@@ -69,7 +120,6 @@ const markTransactionAsNotMiscategorizedEpic = (actions$, state$, zeniAPI) => ac
                 }));
             }
             else {
-                //Finally everything done for this transaction
                 actions.push((0, snackbarReducer_1.openSnackbar)({
                     messageSection: 'transactionDetails_transactionUpdated',
                     messageText: 'success',

package/lib/view/transactionDetail/epics/updateTransactionDetailEpic.js

@@ -9,6 +9,7 @@ const rxjs_1 = require("rxjs");
 const operators_1 = require("rxjs/operators");
 const recommendationPayload_1 = require("../../../commonPayloadTypes/recommendationPayload");
 const snackbarReducer_1 = require("../../../entity/snackbar/snackbarReducer");
+const tenantSelector_1 = require("../../../entity/tenant/tenantSelector");
 const customerTransactionPayload_1 = require("../../../entity/transaction/payloadTypes/customerTransactionPayload");
 const otherTransactionPayload_1 = require("../../../entity/transaction/payloadTypes/otherTransactionPayload");
 const transactionIDPayload_1 = require("../../../entity/transaction/payloadTypes/transactionIDPayload");
@@ -25,13 +26,12 @@ const transactionSelector_1 = require("../../../entity/transaction/transactionSe
 const vendorReducer_1 = require("../../../entity/vendor/vendorReducer");
 const vendorSelector_1 = require("../../../entity/vendor/vendorSelector");
 const responsePayload_1 = require("../../../responsePayload");
-const tenantSelector_1 = require("../../../entity/tenant/tenantSelector");
 const accountListSelector_1 = require("../../accountList/accountListSelector");
 const transactionCategorizationLocalDataHelper_1 = require("../../expenseAutomationView/helpers/transactionCategorizationLocalDataHelper");
 const transactionsViewReducer_1 = require("../../expenseAutomationView/reducers/transactionsViewReducer");
+const transactionDetailLocalDataHelper_1 = require("../transactionDetailLocalDataHelper");
 const transactionDetailReducer_1 = require("../transactionDetailReducer");
 const transactionDetailState_1 = require("../transactionDetailState");
-const saveTransactionHelper_1 = require("./saveTransactionHelper");
 const updateTransactionDetailEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(transactionDetailReducer_1.updateTransactionDetail.match), (0, operators_1.mergeMap)((action) => {
     const { transactionState, vendorState, transactionDetailState } = state$.value;
     const isAccountingProjectsEnabled = (0, tenantSelector_1.getIsAccountingProjectsEnabled)(state$.value);
@@ -42,24 +42,6 @@ const updateTransactionDetailEpic = (actions$, state$, zeniAPI) => actions$.pipe
         if ((0, responsePayload_1.isSuccessResponse)(response) && response.data != null) {
             const transactionIdResp = (0, transactionIDPayload_1.toTransactionID)(response.data.transaction);
             const transactionDetailKeyForResponse = (0, transactionDetailState_1.getTransactionDetailKey)(transactionIdResp);
-            const tranDetail = (0, get_1.default)(transactionDetailState.transactionDetailById, transactionDetailKeyForResponse, undefined);
-            const tranVendorUpdates = tranDetail?.transactionDetailLocalData.vendorUpdates;
-            let vendorUpdates = undefined;
-            if (tranVendorUpdates?.qboId != null) {
-                const vendor = (0, vendorSelector_1.getVendorByVendorId)(vendorState, tranVendorUpdates.qboId);
-                if (vendor != null) {
-                    vendorUpdates = {
-                        id: vendor?.qboId,
-                        name: vendor?.name,
-                    };
-                }
-                else if (tranVendorUpdates.name != null) {
-                    vendorUpdates = {
-                        id: tranVendorUpdates.qboId,
-                        name: tranVendorUpdates.name,
-                    };
-                }
-            }
             const actions = [];
             if (response.data.vendors != null) {
                 actions.push((0, vendorReducer_1.updateVendors)(response.data.vendors, 'merge'));
@@ -72,30 +54,14 @@ const updateTransactionDetailEpic = (actions$, state$, zeniAPI) => actions$.pipe
                 vendorId: response.data.vendors?.[0]?.vendor_id,
             }));
             actions.push((0, transactionDetailReducer_1.updateTransactionDetailSaveStatus)(transactionIdResp, 'Completed'));
-            let callMarkTransactionAsNotMiscategorized = true;
-            // NOTE: If tran is vendorType OR JE OR Deposit transaction and there is no vendor chosen on this tranaction while saving,
-            // then we need to skip mark-miscategorized-as-correct api call
-            if ((0, transactionType_1.toVendorTransactionTypeStrict)(response.data.transaction.transaction_type) != null ||
-                (0, transactionType_1.toJEAndDepositTransactionTypeStrict)(response.data.transaction.transaction_type) != null) {
-                const isAccountingClassesEnabled = (0, tenantSelector_1.getIsAccountingClassesEnabled)(state$.value);
-                const isAnyClassMissing = isAccountingClassesEnabled &&
-                    checkIfClassMissingForAnyLineItem(response.data.transaction);
-                const isVendorOrCustomerMissingInAnyLine = (0, transactionType_1.toJEAndDepositTransactionTypeStrict)(response.data.transaction.transaction_type) != null &&
-                    checkIfVendorOrCustomerMissingForAnyLineItem(response.data.transaction);
-                if ((vendorUpdates?.id == null &&
-                    isVendorOrCustomerMissingInAnyLine == true) ||
-                    isAnyClassMissing == true) {
-                    callMarkTransactionAsNotMiscategorized = false;
-                }
-            }
             const uncategorizedIncomeExpense = (0, accountListSelector_1.getUncategorizedAccounts)(state$.value.accountState, state$.value.accountListState, 'accountList');
             const transaction = (0, toSupportedTransaction_1.default)(response.data.transaction);
-            const isTransactionUnCategorized = (0, saveTransactionHelper_1.isTransactionUncategorized)(transaction, uncategorizedIncomeExpense);
+            const isAccountingClassesEnabled = (0, tenantSelector_1.getIsAccountingClassesEnabled)(state$.value);
+            const eligibleLineIds = getLineIdsEligibleForReview(transaction, uncategorizedIncomeExpense, isAccountingClassesEnabled, action.payload.isExpenseAutomationEnabled);
             if (action.payload.transactionSaveUpdates.markAsMiscatUpdates ===
                 true &&
-                callMarkTransactionAsNotMiscategorized === true &&
-                isTransactionUnCategorized === false) {
-                actions.push((0, transactionDetailReducer_1.markTransactionAsNotMiscategorized)(transactionIdResp, action.payload.transactionSaveUpdates, action.payload.isExpenseAutomationEnabled));
+                eligibleLineIds.length > 0) {
+                actions.push((0, transactionDetailReducer_1.markTransactionAsNotMiscategorized)(transactionIdResp, action.payload.transactionSaveUpdates, action.payload.isExpenseAutomationEnabled, eligibleLineIds));
             }
             else {
                 actions.push((0, transactionDetailReducer_1.updateStatusConsolidatedSaveTransactionDetail)({
@@ -307,31 +273,58 @@ const toTransactionUpdatePayload = (updates, detail, cotTransactionTracking, isA
     return (0, transactionPayload_1.injectCOTFlagsIntoTransactionPayload)(basePayload, transaction);
 };
 exports.toTransactionUpdatePayload = toTransactionUpdatePayload;
-const checkIfClassMissingForAnyLineItem = (transactionPayload) => {
-    let isAnyClassMissing = false;
-    if (transactionPayload.lines != null) {
-        transactionPayload.lines.forEach((line) => {
-            if (line.line_detail?.class
-                ?.accounting_class_id == null) {
-                isAnyClassMissing = true;
+const getLineIdsEligibleForReview = (transaction, uncategorizedIncomeExpense, isAccountingClassesEnabled, isExpenseAutomationEnabled) => {
+    // For non-EA, any line missing a required field (class when enabled, or entity on JE/Deposit)
+    // suppresses the entire call. EA keeps the per-line model, returning only eligible line IDs.
+    if (!isExpenseAutomationEnabled) {
+        const isApplicableType = (0, vendorTransaction_1.isVendorTransaction)(transaction) ||
+            (0, transactionType_1.toJEAndDepositTransactionTypeStrict)(transaction.type) != null;
+        if (isApplicableType) {
+            const lines = (transaction.lines ?? []).filter((line) => line.type === 'transaction_with_account_and_class_line' ||
+                line.type === 'journal_entry_transaction_line' ||
+                line.type === 'transaction_with_product_or_service_line');
+            if (isAccountingClassesEnabled) {
+                const anyLineMissingClass = lines.some((line) => (line.class?.classId ??
+                    '') === '');
+                if (anyLineMissingClass) {
+                    return [];
+                }
             }
-        });
-    }
-    return isAnyClassMissing;
-};
-const checkIfVendorOrCustomerMissingForAnyLineItem = (transactionPayload) => {
-    let isAnyVendorOrCustomerMissing = false;
-    if (transactionPayload.lines != null) {
-        transactionPayload.lines.forEach((line) => {
-            if (line.line_detail
-                ?.vendor == null &&
-                line.line_detail
-                    ?.customer == null) {
-                isAnyVendorOrCustomerMissing = true;
+            if ((0, transactionType_1.toJEAndDepositTransactionTypeStrict)(transaction.type) != null) {
+                const anyLineMissingEntity = lines.some((line) => {
+                    const tl = line;
+                    return tl.vendor == null && tl.customer == null;
+                });
+                if (anyLineMissingEntity) {
+                    return [];
+                }
             }
-        });
+        }
     }
-    return isAnyVendorOrCustomerMissing;
+    return (transaction.lines ?? [])
+        .filter((line) => {
+        if (line.type !== 'transaction_with_account_and_class_line' &&
+            line.type !== 'journal_entry_transaction_line' &&
+            line.type !== 'transaction_with_product_or_service_line') {
+            return false;
+        }
+        const typedLine = line;
+        const hasCategory = !(0, transactionDetailLocalDataHelper_1.isAccountUncategorized)(uncategorizedIncomeExpense, typedLine.account?.qboId);
+        // class is always a ClassBase object (never null) because the payload mapper
+        // calls mapClassBasePayloadToClassBase(payload ?? {}) which returns {} with classId:''.
+        // A real class is indicated by a non-empty classId.
+        const hasClass = !isAccountingClassesEnabled || (typedLine.class?.classId ?? '') !== '';
+        const hasAmount = (typedLine.amount?.amount ?? 0) !== 0;
+        // JE lines and Deposit transactions require vendor or customer before being eligible for review.
+        const isJEOrDepositContext = line.type === 'journal_entry_transaction_line' ||
+            (0, transactionType_1.toJEAndDepositTransactionTypeStrict)(transaction.type) != null;
+        const hasEntity = !isJEOrDepositContext ||
+            typedLine.vendor != null ||
+            typedLine.customer != null;
+        return hasCategory && hasClass && hasAmount && hasEntity;
+    })
+        .map((line) => line.id)
+        .filter(Boolean);
 };
 // Converts a locally-created line item (from edit mode) into the wire shape
 // expected by the categorize endpoint. Sending id='' signals the backend to

package/lib/view/transactionDetail/transactionDetailLocalDataHelper.js

@@ -764,6 +764,7 @@ const setEntityRecommendationForLineIdInLocalData = (transaction, transactionDet
         latestUpdatedLineWithEntity: transactionDetailLocalData.latestUpdatedLineWithEntity,
         vendorBulkUpdateCategoryClassRecommendationsFetchStatus: transactionDetailLocalData.vendorBulkUpdateCategoryClassRecommendationsFetchStatus,
         selectedEntity: transactionDetailLocalData.selectedEntity,
+        editMode: transactionDetailLocalData.editMode,
     };
     return newLocalData;
 };
@@ -818,6 +819,7 @@ const removeEntityRecommendationForLineIdInLocalData = (transaction, transaction
         latestSelectedEntityOnLineItem: transactionDetailLocalData.latestSelectedEntityOnLineItem,
         latestUpdatedLineWithEntity: transactionDetailLocalData.latestUpdatedLineWithEntity,
         selectedEntity: transactionDetailLocalData.selectedEntity,
+        editMode: transactionDetailLocalData.editMode,
     };
     return newLocalData;
 };
@@ -838,7 +840,8 @@ const getChangedLineItemCountFromLocalData = (transaction, transactionLocalData)
                     const accountLine = line;
                     hasCategoryChanged =
                         accountLineLocal.account?.qboId !== accountLine.account.qboId &&
-                            accountLineLocal.account?.accountId !== accountLine.account.accountId;
+                            accountLineLocal.account?.accountId !==
+                                accountLine.account.accountId;
                     hasClassChanged =
                         (accountLineLocal.class?.qboId != null ||
                             accountLine.class?.qboId != null) &&

package/lib/view/transactionDetail/transactionDetailReducer.d.ts

@@ -38,10 +38,11 @@ export declare const downloadAccountingProviderAttachment: import("@reduxjs/tool
     error: ZeniAPIStatus<Record<string, unknown>> | undefined;
 }, "transactionDetail/updateTransactionDetailSaveStatus", never, never>, clearTransactionDetailSaveStatus: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[transactionId: TransactionID], {
     transactionId: TransactionID;
-}, "transactionDetail/clearTransactionDetailSaveStatus", never, never>, markTransactionAsNotMiscategorized: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[transactionId: TransactionID, transactionSaveUpdates: TransactionSaveUpdates, isExpenseAutomationEnabled: boolean], {
+}, "transactionDetail/clearTransactionDetailSaveStatus", never, never>, markTransactionAsNotMiscategorized: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[transactionId: TransactionID, transactionSaveUpdates: TransactionSaveUpdates, isExpenseAutomationEnabled: boolean, lineIds?: string[] | undefined], {
     transactionId: TransactionID;
     transactionSaveUpdates: TransactionSaveUpdates;
     isExpenseAutomationEnabled: boolean;
+    lineIds: string[] | undefined;
 }, "transactionDetail/markTransactionAsNotMiscategorized", never, never>, deleteTransactionAttachment: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[attachmentFileName: string, transactionId: TransactionID], {
     attachmentFileName: string;
     transactionId: TransactionID;

package/lib/view/transactionDetail/transactionDetailReducer.js

@@ -197,12 +197,13 @@ const transactionDetail = (0, toolkit_1.createSlice)({
                     };
                 }
             },
-            prepare(transactionId, transactionSaveUpdates, isExpenseAutomationEnabled) {
+            prepare(transactionId, transactionSaveUpdates, isExpenseAutomationEnabled, lineIds) {
                 return {
                     payload: {
                         transactionId,
                         transactionSaveUpdates,
                         isExpenseAutomationEnabled,
+                        lineIds,
                     },
                 };
             },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.1.52-beta0RD",
+  "version": "5.1.53-betaRD1",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",