@zeniai/client-epic-state 5.1.51-beta0RR → 5.1.51-beta1RR

package/lib/esm/view/transactionDetail/epics/markTransactionAsNotMiscategorizedEpic.js

@@ -36,9 +36,11 @@ export const markTransactionAsNotMiscategorizedEpic = (actions$, state$, zeniAPI
                     actions.push(updateTransactionIsMiscategorized(transactionKey, false));
                     const { expenseAutomationViewState, expenseAutomationTransactionsViewState, } = state$.value;
                     const { transactionCategorizationView, selectedTransactionCategorizationTab, } = expenseAutomationTransactionsViewState;
-                    const currentTenant = getCurrentTenant(state$.value);
+                    const currentTenantId = getCurrentTenant(state$.value)?.tenantId;
                     const { selectedPeriodByTenantId } = expenseAutomationViewState;
-                    const selectedPeriod = selectedPeriodByTenantId[currentTenant?.tenantId ?? ''];
+                    const selectedPeriod = currentTenantId != null
+                        ? selectedPeriodByTenantId[currentTenantId]
+                        : undefined;
                     const autoTabLineItems = transactionCategorizationView.autoCategorized
                         .transactionReviewLocalDataById[txnId]
                         ?.transactionReviewLocalData.tabSpecificLineItems

package/lib/esm/view/transactionDetail/epics/updateTransactionDetailEpic.js

@@ -11,6 +11,7 @@ import { injectCOTFlagsIntoTransactionPayload, toTransactionPayload, } from '../
 import { toVendorTransactionPayload, toVendorTransactionWithCustomerPayload, } from '../../../entity/transaction/payloadTypes/vendorTransactionPayload';
 import { isCustomerTransaction, } from '../../../entity/transaction/stateTypes/customerTransaction';
 import { isTransferTransaction, } from '../../../entity/transaction/stateTypes/otherTransaction';
+import { toJEAndDepositTransactionTypeStrict } from '../../../entity/transaction/stateTypes/transactionType';
 import { isVendorTransaction, } from '../../../entity/transaction/stateTypes/vendorTransaction';
 import toSupportedTransaction from '../../../entity/transaction/toSupportedTransaction';
 import { getTransactionWithCOT } from '../../../entity/transaction/transactionHelper';
@@ -50,7 +51,7 @@ export const updateTransactionDetailEpic = (actions$, state$, zeniAPI) => action
             const uncategorizedIncomeExpense = getUncategorizedAccounts(state$.value.accountState, state$.value.accountListState, 'accountList');
             const transaction = toSupportedTransaction(response.data.transaction);
             const isAccountingClassesEnabled = getIsAccountingClassesEnabled(state$.value);
-            const eligibleLineIds = getLineIdsEligibleForReview(transaction, uncategorizedIncomeExpense, isAccountingClassesEnabled);
+            const eligibleLineIds = getLineIdsEligibleForReview(transaction, uncategorizedIncomeExpense, isAccountingClassesEnabled, action.payload.isExpenseAutomationEnabled);
             if (action.payload.transactionSaveUpdates.markAsMiscatUpdates ===
                 true &&
                 eligibleLineIds.length > 0) {
@@ -264,7 +265,34 @@ export const toTransactionUpdatePayload = (updates, detail, cotTransactionTracki
     // Inject COT flags into the payload
     return injectCOTFlagsIntoTransactionPayload(basePayload, transaction);
 };
-const getLineIdsEligibleForReview = (transaction, uncategorizedIncomeExpense, isAccountingClassesEnabled) => {
+const getLineIdsEligibleForReview = (transaction, uncategorizedIncomeExpense, isAccountingClassesEnabled, isExpenseAutomationEnabled) => {
+    // For non-EA, any line missing a required field (class when enabled, or entity on JE/Deposit)
+    // suppresses the entire call. EA keeps the per-line model, returning only eligible line IDs.
+    if (!isExpenseAutomationEnabled) {
+        const isApplicableType = isVendorTransaction(transaction) ||
+            toJEAndDepositTransactionTypeStrict(transaction.type) != null;
+        if (isApplicableType) {
+            const lines = (transaction.lines ?? []).filter((line) => line.type === 'transaction_with_account_and_class_line' ||
+                line.type === 'journal_entry_transaction_line' ||
+                line.type === 'transaction_with_product_or_service_line');
+            if (isAccountingClassesEnabled) {
+                const anyLineMissingClass = lines.some((line) => (line.class?.classId ??
+                    '') === '');
+                if (anyLineMissingClass) {
+                    return [];
+                }
+            }
+            if (toJEAndDepositTransactionTypeStrict(transaction.type) != null) {
+                const anyLineMissingEntity = lines.some((line) => {
+                    const tl = line;
+                    return tl.vendor == null && tl.customer == null;
+                });
+                if (anyLineMissingEntity) {
+                    return [];
+                }
+            }
+        }
+    }
     return (transaction.lines ?? [])
         .filter((line) => {
         if (line.type !== 'transaction_with_account_and_class_line' &&
@@ -274,9 +302,15 @@ const getLineIdsEligibleForReview = (transaction, uncategorizedIncomeExpense, is
         }
         const typedLine = line;
         const hasCategory = !isAccountUncategorized(uncategorizedIncomeExpense, typedLine.account?.qboId);
-        const hasClass = !isAccountingClassesEnabled || typedLine.class != null;
+        // class is always a ClassBase object (never null) because the payload mapper
+        // calls mapClassBasePayloadToClassBase(payload ?? {}) which returns {} with classId:''.
+        // A real class is indicated by a non-empty classId.
+        const hasClass = !isAccountingClassesEnabled || (typedLine.class?.classId ?? '') !== '';
         const hasAmount = (typedLine.amount?.amount ?? 0) !== 0;
-        const hasEntity = line.type !== 'journal_entry_transaction_line' ||
+        // JE lines and Deposit transactions require vendor or customer before being eligible for review.
+        const isJEOrDepositContext = line.type === 'journal_entry_transaction_line' ||
+            toJEAndDepositTransactionTypeStrict(transaction.type) != null;
+        const hasEntity = !isJEOrDepositContext ||
             typedLine.vendor != null ||
             typedLine.customer != null;
         return hasCategory && hasClass && hasAmount && hasEntity;

package/lib/view/transactionDetail/epics/markTransactionAsNotMiscategorizedEpic.js

@@ -39,9 +39,11 @@ const markTransactionAsNotMiscategorizedEpic = (actions$, state$, zeniAPI) => ac
                     actions.push((0, transactionReducer_1.updateTransactionIsMiscategorized)(transactionKey, false));
                     const { expenseAutomationViewState, expenseAutomationTransactionsViewState, } = state$.value;
                     const { transactionCategorizationView, selectedTransactionCategorizationTab, } = expenseAutomationTransactionsViewState;
-                    const currentTenant = (0, tenantSelector_1.getCurrentTenant)(state$.value);
+                    const currentTenantId = (0, tenantSelector_1.getCurrentTenant)(state$.value)?.tenantId;
                     const { selectedPeriodByTenantId } = expenseAutomationViewState;
-                    const selectedPeriod = selectedPeriodByTenantId[currentTenant?.tenantId ?? ''];
+                    const selectedPeriod = currentTenantId != null
+                        ? selectedPeriodByTenantId[currentTenantId]
+                        : undefined;
                     const autoTabLineItems = transactionCategorizationView.autoCategorized
                         .transactionReviewLocalDataById[txnId]
                         ?.transactionReviewLocalData.tabSpecificLineItems

package/lib/view/transactionDetail/epics/updateTransactionDetailEpic.js

@@ -17,6 +17,7 @@ const transactionPayload_1 = require("../../../entity/transaction/payloadTypes/t
 const vendorTransactionPayload_1 = require("../../../entity/transaction/payloadTypes/vendorTransactionPayload");
 const customerTransaction_1 = require("../../../entity/transaction/stateTypes/customerTransaction");
 const otherTransaction_1 = require("../../../entity/transaction/stateTypes/otherTransaction");
+const transactionType_1 = require("../../../entity/transaction/stateTypes/transactionType");
 const vendorTransaction_1 = require("../../../entity/transaction/stateTypes/vendorTransaction");
 const toSupportedTransaction_1 = __importDefault(require("../../../entity/transaction/toSupportedTransaction"));
 const transactionHelper_1 = require("../../../entity/transaction/transactionHelper");
@@ -56,7 +57,7 @@ const updateTransactionDetailEpic = (actions$, state$, zeniAPI) => actions$.pipe
             const uncategorizedIncomeExpense = (0, accountListSelector_1.getUncategorizedAccounts)(state$.value.accountState, state$.value.accountListState, 'accountList');
             const transaction = (0, toSupportedTransaction_1.default)(response.data.transaction);
             const isAccountingClassesEnabled = (0, tenantSelector_1.getIsAccountingClassesEnabled)(state$.value);
-            const eligibleLineIds = getLineIdsEligibleForReview(transaction, uncategorizedIncomeExpense, isAccountingClassesEnabled);
+            const eligibleLineIds = getLineIdsEligibleForReview(transaction, uncategorizedIncomeExpense, isAccountingClassesEnabled, action.payload.isExpenseAutomationEnabled);
             if (action.payload.transactionSaveUpdates.markAsMiscatUpdates ===
                 true &&
                 eligibleLineIds.length > 0) {
@@ -272,7 +273,34 @@ const toTransactionUpdatePayload = (updates, detail, cotTransactionTracking, isA
     return (0, transactionPayload_1.injectCOTFlagsIntoTransactionPayload)(basePayload, transaction);
 };
 exports.toTransactionUpdatePayload = toTransactionUpdatePayload;
-const getLineIdsEligibleForReview = (transaction, uncategorizedIncomeExpense, isAccountingClassesEnabled) => {
+const getLineIdsEligibleForReview = (transaction, uncategorizedIncomeExpense, isAccountingClassesEnabled, isExpenseAutomationEnabled) => {
+    // For non-EA, any line missing a required field (class when enabled, or entity on JE/Deposit)
+    // suppresses the entire call. EA keeps the per-line model, returning only eligible line IDs.
+    if (!isExpenseAutomationEnabled) {
+        const isApplicableType = (0, vendorTransaction_1.isVendorTransaction)(transaction) ||
+            (0, transactionType_1.toJEAndDepositTransactionTypeStrict)(transaction.type) != null;
+        if (isApplicableType) {
+            const lines = (transaction.lines ?? []).filter((line) => line.type === 'transaction_with_account_and_class_line' ||
+                line.type === 'journal_entry_transaction_line' ||
+                line.type === 'transaction_with_product_or_service_line');
+            if (isAccountingClassesEnabled) {
+                const anyLineMissingClass = lines.some((line) => (line.class?.classId ??
+                    '') === '');
+                if (anyLineMissingClass) {
+                    return [];
+                }
+            }
+            if ((0, transactionType_1.toJEAndDepositTransactionTypeStrict)(transaction.type) != null) {
+                const anyLineMissingEntity = lines.some((line) => {
+                    const tl = line;
+                    return tl.vendor == null && tl.customer == null;
+                });
+                if (anyLineMissingEntity) {
+                    return [];
+                }
+            }
+        }
+    }
     return (transaction.lines ?? [])
         .filter((line) => {
         if (line.type !== 'transaction_with_account_and_class_line' &&
@@ -282,9 +310,15 @@ const getLineIdsEligibleForReview = (transaction, uncategorizedIncomeExpense, is
         }
         const typedLine = line;
         const hasCategory = !(0, transactionDetailLocalDataHelper_1.isAccountUncategorized)(uncategorizedIncomeExpense, typedLine.account?.qboId);
-        const hasClass = !isAccountingClassesEnabled || typedLine.class != null;
+        // class is always a ClassBase object (never null) because the payload mapper
+        // calls mapClassBasePayloadToClassBase(payload ?? {}) which returns {} with classId:''.
+        // A real class is indicated by a non-empty classId.
+        const hasClass = !isAccountingClassesEnabled || (typedLine.class?.classId ?? '') !== '';
         const hasAmount = (typedLine.amount?.amount ?? 0) !== 0;
-        const hasEntity = line.type !== 'journal_entry_transaction_line' ||
+        // JE lines and Deposit transactions require vendor or customer before being eligible for review.
+        const isJEOrDepositContext = line.type === 'journal_entry_transaction_line' ||
+            (0, transactionType_1.toJEAndDepositTransactionTypeStrict)(transaction.type) != null;
+        const hasEntity = !isJEOrDepositContext ||
             typedLine.vendor != null ||
             typedLine.customer != null;
         return hasCategory && hasClass && hasAmount && hasEntity;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.1.51-beta0RR",
+  "version": "5.1.51-beta1RR",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",