@zeniai/client-epic-state 5.1.43 → 5.1.45-betaDI1

package/lib/entity/task/taskPayload.d.ts

@@ -22,6 +22,7 @@ export interface TaskPayload {
     update_time: string | null;
     company_id?: string;
     company_name?: string;
+    depth?: number | null;
     group_assignees?: string[];
     parent_task_id?: string | null;
     recurring_days_of_week?: string[] | null;

package/lib/entity/task/taskPayload.js

@@ -45,6 +45,14 @@ const mapTaskPayloadToTask = (payload, previousTask) => ({
     updateTime: payload.update_time != null ? (0, zeniDayJS_1.date)(payload.update_time) : undefined,
     companyId: payload.company_id,
     companyName: payload.company_name,
+    // `depth` may be absent on partial updates (e.g. pusher-driven task
+    // refreshes that don't include it). Preserve the previously-known depth
+    // there — otherwise the Redux store's depth flips to undefined and any
+    // WC depth-cap gate ("hide Create Subtask at depth 3") re-opens
+    // incorrectly. Explicit `null` from the BE still clears it via `??`.
+    depth: payload.depth !== undefined
+        ? (payload.depth ?? undefined)
+        : previousTask?.depth,
     parentTaskId: payload.parent_task_id ?? undefined,
     recurringSourceTaskId: payload.recurring_source_task_id != null
         ? payload.recurring_source_task_id

package/lib/entity/task/taskState.d.ts

@@ -23,6 +23,7 @@ export interface Task {
     type: TaskType;
     companyId?: ID;
     companyName?: string;
+    depth?: number;
     dueDate?: ZeniDate;
     parentTaskId?: ID | null;
     recurringDaysOfWeek?: DayOfWeek[];

package/lib/esm/entity/task/taskPayload.js

@@ -42,6 +42,14 @@ export const mapTaskPayloadToTask = (payload, previousTask) => ({
     updateTime: payload.update_time != null ? date(payload.update_time) : undefined,
     companyId: payload.company_id,
     companyName: payload.company_name,
+    // `depth` may be absent on partial updates (e.g. pusher-driven task
+    // refreshes that don't include it). Preserve the previously-known depth
+    // there — otherwise the Redux store's depth flips to undefined and any
+    // WC depth-cap gate ("hide Create Subtask at depth 3") re-opens
+    // incorrectly. Explicit `null` from the BE still clears it via `??`.
+    depth: payload.depth !== undefined
+        ? (payload.depth ?? undefined)
+        : previousTask?.depth,
     parentTaskId: payload.parent_task_id ?? undefined,
     recurringSourceTaskId: payload.recurring_source_task_id != null
         ? payload.recurring_source_task_id

package/lib/esm/view/expenseAutomationView/reducers/reconciliationViewReducer.js

@@ -95,12 +95,12 @@ const expenseAutomationReconciliationView = createSlice({
                     }
                 }
                 else {
-                    // reset the selected tab to "review" when visiing detail page and we are  not refreshing in Background
+                    // Visiting an account detail page selects it and opens review; background
+                    // refresh (e.g. statement Pusher) must not change navigation selection.
                     if (action.payload.refreshViewInBackground !== true) {
                         draft.selectedTab = 'review';
+                        draft.selectedAccountId = action.payload.accountId;
                     }
-                    // select the account for which we are fetching
-                    draft.selectedAccountId = action.payload.accountId;
                     const accountReconciliationRecords = draft.accountReconciliationRecordsBySelectedPeriod[toMonthYearPeriodId(action.payload.selectedPeriod)];
                     const { transactionFetchState } = accountReconciliationRecords.reconciliationByAccountID[action.payload.accountId];
                     if (transactionFetchState.fetchState !== 'Completed' ||
@@ -517,21 +517,33 @@ const expenseAutomationReconciliationView = createSlice({
         },
         parseStatementSuccess: (draft, action) => {
             const { accountId, selectedPeriod } = action.payload;
-            draft.accountReconciliationRecordsBySelectedPeriod[toMonthYearPeriodId(selectedPeriod)].reconciliationByAccountID[accountId].statementParseStatus = {
+            const accountRecon = draft.accountReconciliationRecordsBySelectedPeriod[toMonthYearPeriodId(selectedPeriod)]?.reconciliationByAccountID[accountId];
+            if (accountRecon == null) {
+                return;
+            }
+            accountRecon.statementParseStatus = {
                 fetchState: 'Completed',
                 error: undefined,
             };
-            draft.accountReconciliationRecordsBySelectedPeriod[toMonthYearPeriodId(selectedPeriod)].reconciliationByAccountID[accountId].statementParseInProgress = false;
-            draft.accountReconciliationRecordsBySelectedPeriod[toMonthYearPeriodId(selectedPeriod)].reconciliationByAccountID[accountId].statementProcessingFailed = false;
+            accountRecon.statementParseInProgress = false;
+            accountRecon.statementProcessingFailed = false;
+            // Stop elapsed-time step simulation; keep dismissed flag so the
+            // app-level completion snackbar can still fire.
+            accountRecon.statementProcessingStartedAtMs = undefined;
+            accountRecon.statementProcessingTotalDurationSeconds = undefined;
         },
         parseStatementFailure: (draft, action) => {
             const { accountId, selectedPeriod } = action.payload;
-            draft.accountReconciliationRecordsBySelectedPeriod[toMonthYearPeriodId(selectedPeriod)].reconciliationByAccountID[accountId].statementParseStatus = {
+            const accountRecon = draft.accountReconciliationRecordsBySelectedPeriod[toMonthYearPeriodId(selectedPeriod)]?.reconciliationByAccountID[accountId];
+            if (accountRecon == null) {
+                return;
+            }
+            accountRecon.statementParseStatus = {
                 fetchState: 'Error',
                 error: action.payload.error,
             };
-            draft.accountReconciliationRecordsBySelectedPeriod[toMonthYearPeriodId(selectedPeriod)].reconciliationByAccountID[accountId].statementParseInProgress = false;
-            draft.accountReconciliationRecordsBySelectedPeriod[toMonthYearPeriodId(selectedPeriod)].reconciliationByAccountID[accountId].statementProcessingFailed = true;
+            accountRecon.statementParseInProgress = false;
+            accountRecon.statementProcessingFailed = true;
         },
         reparseStatement: (draft, action) => {
             const { accountId, selectedPeriod } = action.payload;

package/lib/esm/view/taskManager/taskDetailView/epics/initializeTaskToLocalStoreEpic.js

@@ -29,6 +29,7 @@ export const initializeTaskToLocalStoreEpic = (actions$, state$) => actions$.pip
             timeSpent: task.timeSpent,
             isPrivate: task.isPrivate,
             taskGroupId: task.taskGroupIds[0],
+            depth: task.depth,
         };
         const actions = [
             saveTaskUpdatesToLocalStore({ taskDetailLocalData, taskId }),

package/lib/esm/view/taskManager/taskListView/taskListReducer.js

@@ -824,13 +824,40 @@ const getGroupedTaskIds = (tasks) => {
         ...initialTaskIdsByDueDate,
     };
     const taskIdsByTags = {};
+    // Which parents are actually present in this payload. A subtask is
+    // only treated as "nested" (and dropped from the count / groupings)
+    // if its parent is in the visible set — otherwise it renders as an
+    // orphan top-level row in the UI (SubtaskDetailTable has no parent to
+    // attach under) and MUST count. Customer callers routinely see this:
+    // the parent is Zeni-internal / private and filtered server-side, but
+    // the subtask itself is public and lands in the payload.
+    const visibleTaskIds = new Set(tasks.map((t) => t.task_id));
     tasks.forEach((task) => {
-        taskIds.push(task.task_id);
+        // A task is a "nested subtask" only when its parent is in the
+        // visible payload — otherwise it's an orphan and renders as a
+        // top-level row in the UI (customer callers routinely see this:
+        // the parent is Zeni-internal / private and filtered server-side,
+        // but the subtask itself is public and lands in the payload).
+        // Datastore string properties default to '' when unset, so treat
+        // empty string as null. Matches the sibling `updateTasks` guard
+        // at L719-722.
+        const isNestedSubtask = task.parent_task_id != null &&
+            task.parent_task_id !== '' &&
+            visibleTaskIds.has(task.parent_task_id);
+        // Subtasks stay in every groupBy array so the UI can render them
+        // nested under their parent (WC's TaskManagementPage builds
+        // `subtasksByParentId` from `group.tasks` and then filters them
+        // out of top-level rows via `filterOutSubtasks`). Only the flat
+        // top-level `taskIds` array — which drives the Active/Completed/…
+        // tab counts — must exclude nested subtasks.
         const priorityKey = toPriorityCodeType(task.priority.code);
         const statusKey = toTaskStatusCodeType(task.status.code);
         const assigneeKey = getAssigneesGroupKey(task.assignees);
         const dueDateKey = getDueDateGroupKey(task.due_date);
         const tagsKey = getTagsGroupKey(task.tags);
+        if (!isNestedSubtask) {
+            taskIds.push(task.task_id);
+        }
         taskIdsGroupedByPriority[priorityKey] = [
             ...taskIdsGroupedByPriority[priorityKey],
             task.task_id,

package/lib/view/expenseAutomationView/reducers/reconciliationViewReducer.js

@@ -100,12 +100,12 @@ const expenseAutomationReconciliationView = (0, toolkit_1.createSlice)({
                     }
                 }
                 else {
-                    // reset the selected tab to "review" when visiing detail page and we are  not refreshing in Background
+                    // Visiting an account detail page selects it and opens review; background
+                    // refresh (e.g. statement Pusher) must not change navigation selection.
                     if (action.payload.refreshViewInBackground !== true) {
                         draft.selectedTab = 'review';
+                        draft.selectedAccountId = action.payload.accountId;
                     }
-                    // select the account for which we are fetching
-                    draft.selectedAccountId = action.payload.accountId;
                     const accountReconciliationRecords = draft.accountReconciliationRecordsBySelectedPeriod[(0, timePeriod_1.toMonthYearPeriodId)(action.payload.selectedPeriod)];
                     const { transactionFetchState } = accountReconciliationRecords.reconciliationByAccountID[action.payload.accountId];
                     if (transactionFetchState.fetchState !== 'Completed' ||
@@ -522,21 +522,33 @@ const expenseAutomationReconciliationView = (0, toolkit_1.createSlice)({
         },
         parseStatementSuccess: (draft, action) => {
             const { accountId, selectedPeriod } = action.payload;
-            draft.accountReconciliationRecordsBySelectedPeriod[(0, timePeriod_1.toMonthYearPeriodId)(selectedPeriod)].reconciliationByAccountID[accountId].statementParseStatus = {
+            const accountRecon = draft.accountReconciliationRecordsBySelectedPeriod[(0, timePeriod_1.toMonthYearPeriodId)(selectedPeriod)]?.reconciliationByAccountID[accountId];
+            if (accountRecon == null) {
+                return;
+            }
+            accountRecon.statementParseStatus = {
                 fetchState: 'Completed',
                 error: undefined,
             };
-            draft.accountReconciliationRecordsBySelectedPeriod[(0, timePeriod_1.toMonthYearPeriodId)(selectedPeriod)].reconciliationByAccountID[accountId].statementParseInProgress = false;
-            draft.accountReconciliationRecordsBySelectedPeriod[(0, timePeriod_1.toMonthYearPeriodId)(selectedPeriod)].reconciliationByAccountID[accountId].statementProcessingFailed = false;
+            accountRecon.statementParseInProgress = false;
+            accountRecon.statementProcessingFailed = false;
+            // Stop elapsed-time step simulation; keep dismissed flag so the
+            // app-level completion snackbar can still fire.
+            accountRecon.statementProcessingStartedAtMs = undefined;
+            accountRecon.statementProcessingTotalDurationSeconds = undefined;
         },
         parseStatementFailure: (draft, action) => {
             const { accountId, selectedPeriod } = action.payload;
-            draft.accountReconciliationRecordsBySelectedPeriod[(0, timePeriod_1.toMonthYearPeriodId)(selectedPeriod)].reconciliationByAccountID[accountId].statementParseStatus = {
+            const accountRecon = draft.accountReconciliationRecordsBySelectedPeriod[(0, timePeriod_1.toMonthYearPeriodId)(selectedPeriod)]?.reconciliationByAccountID[accountId];
+            if (accountRecon == null) {
+                return;
+            }
+            accountRecon.statementParseStatus = {
                 fetchState: 'Error',
                 error: action.payload.error,
             };
-            draft.accountReconciliationRecordsBySelectedPeriod[(0, timePeriod_1.toMonthYearPeriodId)(selectedPeriod)].reconciliationByAccountID[accountId].statementParseInProgress = false;
-            draft.accountReconciliationRecordsBySelectedPeriod[(0, timePeriod_1.toMonthYearPeriodId)(selectedPeriod)].reconciliationByAccountID[accountId].statementProcessingFailed = true;
+            accountRecon.statementParseInProgress = false;
+            accountRecon.statementProcessingFailed = true;
         },
         reparseStatement: (draft, action) => {
             const { accountId, selectedPeriod } = action.payload;

package/lib/view/taskManager/taskDetailView/epics/initializeTaskToLocalStoreEpic.js

@@ -35,6 +35,7 @@ const initializeTaskToLocalStoreEpic = (actions$, state$) => actions$.pipe((0, o
             timeSpent: task.timeSpent,
             isPrivate: task.isPrivate,
             taskGroupId: task.taskGroupIds[0],
+            depth: task.depth,
         };
         const actions = [
             (0, taskDetailReducer_1.saveTaskUpdatesToLocalStore)({ taskDetailLocalData, taskId }),

package/lib/view/taskManager/taskDetailView/taskDetail.d.ts

@@ -47,6 +47,7 @@ export interface EditTaskLocalData {
     tagIds: ID[];
     timeSpent: string;
     type: TaskType;
+    depth?: number;
     dueDate?: ZeniDate;
     isPrivate?: boolean;
     recurringDaysOfWeek?: DayOfWeek[];

package/lib/view/taskManager/taskListView/taskListReducer.js

@@ -828,13 +828,40 @@ const getGroupedTaskIds = (tasks) => {
         ...initialTaskIdsByDueDate,
     };
     const taskIdsByTags = {};
+    // Which parents are actually present in this payload. A subtask is
+    // only treated as "nested" (and dropped from the count / groupings)
+    // if its parent is in the visible set — otherwise it renders as an
+    // orphan top-level row in the UI (SubtaskDetailTable has no parent to
+    // attach under) and MUST count. Customer callers routinely see this:
+    // the parent is Zeni-internal / private and filtered server-side, but
+    // the subtask itself is public and lands in the payload.
+    const visibleTaskIds = new Set(tasks.map((t) => t.task_id));
     tasks.forEach((task) => {
-        taskIds.push(task.task_id);
+        // A task is a "nested subtask" only when its parent is in the
+        // visible payload — otherwise it's an orphan and renders as a
+        // top-level row in the UI (customer callers routinely see this:
+        // the parent is Zeni-internal / private and filtered server-side,
+        // but the subtask itself is public and lands in the payload).
+        // Datastore string properties default to '' when unset, so treat
+        // empty string as null. Matches the sibling `updateTasks` guard
+        // at L719-722.
+        const isNestedSubtask = task.parent_task_id != null &&
+            task.parent_task_id !== '' &&
+            visibleTaskIds.has(task.parent_task_id);
+        // Subtasks stay in every groupBy array so the UI can render them
+        // nested under their parent (WC's TaskManagementPage builds
+        // `subtasksByParentId` from `group.tasks` and then filters them
+        // out of top-level rows via `filterOutSubtasks`). Only the flat
+        // top-level `taskIds` array — which drives the Active/Completed/…
+        // tab counts — must exclude nested subtasks.
         const priorityKey = (0, taskState_1.toPriorityCodeType)(task.priority.code);
         const statusKey = (0, taskState_1.toTaskStatusCodeType)(task.status.code);
         const assigneeKey = getAssigneesGroupKey(task.assignees);
         const dueDateKey = getDueDateGroupKey(task.due_date);
         const tagsKey = getTagsGroupKey(task.tags);
+        if (!isNestedSubtask) {
+            taskIds.push(task.task_id);
+        }
         taskIdsGroupedByPriority[priorityKey] = [
             ...taskIdsGroupedByPriority[priorityKey],
             task.task_id,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.1.43",
+  "version": "5.1.45-betaDI1",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",