@zeniai/client-epic-state 5.1.34-betaAK1 → 5.1.34-betaAK2

package/lib/esm/view/invoicing/invoicingCustomerListView/invoicingCustomerListViewSelector.js

@@ -1,9 +1,16 @@
+import { createSelector } from '@reduxjs/toolkit';
 import { getInvoicingCustomersByIds } from '../../../entity/invoicing/invoicingCustomer/invoicingCustomerSelector';
-export const getInvoicingCustomerListView = (state) => ({
-    customers: getInvoicingCustomersByIds(state.invoicingCustomerState, state.invoicingCustomerListViewState.ids),
-    fetchState: state.invoicingCustomerListViewState.fetchState,
-    error: state.invoicingCustomerListViewState.error,
-    nextCursor: state.invoicingCustomerListViewState.nextCursor,
-    filters: state.invoicingCustomerListViewState.filters,
-    count: state.invoicingCustomerListViewState.counts,
-});
+/**
+ * Memoized so the denormalized `customers` array (and the wrapping view object)
+ * keep referential identity until the customer entity slice or the list-view
+ * slice actually change. Without this, the connected list page re-rendered on
+ * every unrelated redux action because a fresh array was built each call.
+ */
+export const getInvoicingCustomerListView = createSelector((state) => state.invoicingCustomerState, (state) => state.invoicingCustomerListViewState, (customerState, listViewState) => ({
+    customers: getInvoicingCustomersByIds(customerState, listViewState.ids),
+    fetchState: listViewState.fetchState,
+    error: listViewState.error,
+    nextCursor: listViewState.nextCursor,
+    filters: listViewState.filters,
+    count: listViewState.counts,
+}));

package/lib/esm/view/invoicing/invoicingSubscriptionListView/invoicingSubscriptionListViewSelector.js

@@ -1,9 +1,17 @@
+import { createSelector } from '@reduxjs/toolkit';
 import { getInvoicingSubscriptionsByIds } from '../../../entity/invoicing/invoicingSubscription/invoicingSubscriptionSelector';
-export const getInvoicingSubscriptionListView = (state) => ({
-    subscriptions: getInvoicingSubscriptionsByIds(state.invoicingSubscriptionState, state.invoicingSubscriptionListViewState.ids),
-    fetchState: state.invoicingSubscriptionListViewState.fetchState,
-    error: state.invoicingSubscriptionListViewState.error,
-    nextCursor: state.invoicingSubscriptionListViewState.nextCursor,
-    filters: state.invoicingSubscriptionListViewState.filters,
-    count: state.invoicingSubscriptionListViewState.counts,
-});
+/**
+ * Memoized so the denormalized `subscriptions` array (and the wrapping view
+ * object) keep referential identity until the subscription entity slice or the
+ * list-view slice actually change. Without this, the connected list page
+ * re-rendered on every unrelated redux action because a fresh array was built
+ * each call.
+ */
+export const getInvoicingSubscriptionListView = createSelector((state) => state.invoicingSubscriptionState, (state) => state.invoicingSubscriptionListViewState, (subscriptionState, listViewState) => ({
+    subscriptions: getInvoicingSubscriptionsByIds(subscriptionState, listViewState.ids),
+    fetchState: listViewState.fetchState,
+    error: listViewState.error,
+    nextCursor: listViewState.nextCursor,
+    filters: listViewState.filters,
+    count: listViewState.counts,
+}));

package/lib/esm/view/transactionDetail/epics/updateTransactionDetailEpic.js

@@ -3,7 +3,6 @@ import { from, of } from 'rxjs';
 import { catchError, filter, mergeMap } from 'rxjs/operators';
 import { toRecommendationPayload } from '../../../commonPayloadTypes/recommendationPayload';
 import { openSnackbar } from '../../../entity/snackbar/snackbarReducer';
-import { getIsAccountingProjectsEnabled } from '../../../entity/tenant/tenantSelector';
 import { toCustomerTransactionPayload } from '../../../entity/transaction/payloadTypes/customerTransactionPayload';
 import { toTransferTransactionPayload } from '../../../entity/transaction/payloadTypes/otherTransactionPayload';
 import { toTransactionID } from '../../../entity/transaction/payloadTypes/transactionIDPayload';
@@ -20,6 +19,7 @@ import { getSupportedTransactionById } from '../../../entity/transaction/transac
 import { updateVendors } from '../../../entity/vendor/vendorReducer';
 import { getVendorByVendorId } from '../../../entity/vendor/vendorSelector';
 import { createZeniAPIStatus, isActionNotAllowed, isSuccessResponse, } from '../../../responsePayload';
+import { getIsAccountingClassesEnabled, getIsAccountingProjectsEnabled, } from '../../../entity/tenant/tenantSelector';
 import { getUncategorizedAccounts } from '../../accountList/accountListSelector';
 import { getPendingReviewLineIdsFromTransaction } from '../../expenseAutomationView/helpers/transactionCategorizationLocalDataHelper';
 import { syncTransactionCategorizationFromDetailSave } from '../../expenseAutomationView/reducers/transactionsViewReducer';
@@ -69,7 +69,9 @@ export const updateTransactionDetailEpic = (actions$, state$, zeniAPI) => action
             // then we need to skip mark-miscategorized-as-correct api call
             if (toVendorTransactionTypeStrict(response.data.transaction.transaction_type) != null ||
                 toJEAndDepositTransactionTypeStrict(response.data.transaction.transaction_type) != null) {
-                const isAnyClassMissing = checkIfClassMissingForAnyLineItem(response.data.transaction);
+                const isAccountingClassesEnabled = getIsAccountingClassesEnabled(state$.value);
+                const isAnyClassMissing = isAccountingClassesEnabled &&
+                    checkIfClassMissingForAnyLineItem(response.data.transaction);
                 const isVendorOrCustomerMissingInAnyLine = toJEAndDepositTransactionTypeStrict(response.data.transaction.transaction_type) != null &&
                     checkIfVendorOrCustomerMissingForAnyLineItem(response.data.transaction);
                 if ((vendorUpdates?.id == null &&

package/lib/view/invoicing/invoicingCustomerListView/invoicingCustomerListViewSelector.d.ts

@@ -9,4 +9,10 @@ export interface InvoicingCustomerListView extends SelectorView {
     filters: InvoicingCustomerFilters;
     nextCursor: string | null;
 }
+/**
+ * Memoized so the denormalized `customers` array (and the wrapping view object)
+ * keep referential identity until the customer entity slice or the list-view
+ * slice actually change. Without this, the connected list page re-rendered on
+ * every unrelated redux action because a fresh array was built each call.
+ */
 export declare const getInvoicingCustomerListView: (state: RootState) => InvoicingCustomerListView;

package/lib/view/invoicing/invoicingCustomerListView/invoicingCustomerListViewSelector.js

@@ -1,13 +1,19 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.getInvoicingCustomerListView = void 0;
+const toolkit_1 = require("@reduxjs/toolkit");
 const invoicingCustomerSelector_1 = require("../../../entity/invoicing/invoicingCustomer/invoicingCustomerSelector");
-const getInvoicingCustomerListView = (state) => ({
-    customers: (0, invoicingCustomerSelector_1.getInvoicingCustomersByIds)(state.invoicingCustomerState, state.invoicingCustomerListViewState.ids),
-    fetchState: state.invoicingCustomerListViewState.fetchState,
-    error: state.invoicingCustomerListViewState.error,
-    nextCursor: state.invoicingCustomerListViewState.nextCursor,
-    filters: state.invoicingCustomerListViewState.filters,
-    count: state.invoicingCustomerListViewState.counts,
-});
-exports.getInvoicingCustomerListView = getInvoicingCustomerListView;
+/**
+ * Memoized so the denormalized `customers` array (and the wrapping view object)
+ * keep referential identity until the customer entity slice or the list-view
+ * slice actually change. Without this, the connected list page re-rendered on
+ * every unrelated redux action because a fresh array was built each call.
+ */
+exports.getInvoicingCustomerListView = (0, toolkit_1.createSelector)((state) => state.invoicingCustomerState, (state) => state.invoicingCustomerListViewState, (customerState, listViewState) => ({
+    customers: (0, invoicingCustomerSelector_1.getInvoicingCustomersByIds)(customerState, listViewState.ids),
+    fetchState: listViewState.fetchState,
+    error: listViewState.error,
+    nextCursor: listViewState.nextCursor,
+    filters: listViewState.filters,
+    count: listViewState.counts,
+}));

package/lib/view/invoicing/invoicingSubscriptionListView/invoicingSubscriptionListViewSelector.d.ts

@@ -9,4 +9,11 @@ export interface InvoicingSubscriptionListView extends SelectorView {
     nextCursor: string | null;
     subscriptions: InvoicingSubscription[];
 }
+/**
+ * Memoized so the denormalized `subscriptions` array (and the wrapping view
+ * object) keep referential identity until the subscription entity slice or the
+ * list-view slice actually change. Without this, the connected list page
+ * re-rendered on every unrelated redux action because a fresh array was built
+ * each call.
+ */
 export declare const getInvoicingSubscriptionListView: (state: RootState) => InvoicingSubscriptionListView;

package/lib/view/invoicing/invoicingSubscriptionListView/invoicingSubscriptionListViewSelector.js

@@ -1,13 +1,20 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.getInvoicingSubscriptionListView = void 0;
+const toolkit_1 = require("@reduxjs/toolkit");
 const invoicingSubscriptionSelector_1 = require("../../../entity/invoicing/invoicingSubscription/invoicingSubscriptionSelector");
-const getInvoicingSubscriptionListView = (state) => ({
-    subscriptions: (0, invoicingSubscriptionSelector_1.getInvoicingSubscriptionsByIds)(state.invoicingSubscriptionState, state.invoicingSubscriptionListViewState.ids),
-    fetchState: state.invoicingSubscriptionListViewState.fetchState,
-    error: state.invoicingSubscriptionListViewState.error,
-    nextCursor: state.invoicingSubscriptionListViewState.nextCursor,
-    filters: state.invoicingSubscriptionListViewState.filters,
-    count: state.invoicingSubscriptionListViewState.counts,
-});
-exports.getInvoicingSubscriptionListView = getInvoicingSubscriptionListView;
+/**
+ * Memoized so the denormalized `subscriptions` array (and the wrapping view
+ * object) keep referential identity until the subscription entity slice or the
+ * list-view slice actually change. Without this, the connected list page
+ * re-rendered on every unrelated redux action because a fresh array was built
+ * each call.
+ */
+exports.getInvoicingSubscriptionListView = (0, toolkit_1.createSelector)((state) => state.invoicingSubscriptionState, (state) => state.invoicingSubscriptionListViewState, (subscriptionState, listViewState) => ({
+    subscriptions: (0, invoicingSubscriptionSelector_1.getInvoicingSubscriptionsByIds)(subscriptionState, listViewState.ids),
+    fetchState: listViewState.fetchState,
+    error: listViewState.error,
+    nextCursor: listViewState.nextCursor,
+    filters: listViewState.filters,
+    count: listViewState.counts,
+}));

package/lib/view/transactionDetail/epics/updateTransactionDetailEpic.js

@@ -9,7 +9,6 @@ const rxjs_1 = require("rxjs");
 const operators_1 = require("rxjs/operators");
 const recommendationPayload_1 = require("../../../commonPayloadTypes/recommendationPayload");
 const snackbarReducer_1 = require("../../../entity/snackbar/snackbarReducer");
-const tenantSelector_1 = require("../../../entity/tenant/tenantSelector");
 const customerTransactionPayload_1 = require("../../../entity/transaction/payloadTypes/customerTransactionPayload");
 const otherTransactionPayload_1 = require("../../../entity/transaction/payloadTypes/otherTransactionPayload");
 const transactionIDPayload_1 = require("../../../entity/transaction/payloadTypes/transactionIDPayload");
@@ -26,6 +25,7 @@ const transactionSelector_1 = require("../../../entity/transaction/transactionSe
 const vendorReducer_1 = require("../../../entity/vendor/vendorReducer");
 const vendorSelector_1 = require("../../../entity/vendor/vendorSelector");
 const responsePayload_1 = require("../../../responsePayload");
+const tenantSelector_1 = require("../../../entity/tenant/tenantSelector");
 const accountListSelector_1 = require("../../accountList/accountListSelector");
 const transactionCategorizationLocalDataHelper_1 = require("../../expenseAutomationView/helpers/transactionCategorizationLocalDataHelper");
 const transactionsViewReducer_1 = require("../../expenseAutomationView/reducers/transactionsViewReducer");
@@ -75,7 +75,9 @@ const updateTransactionDetailEpic = (actions$, state$, zeniAPI) => actions$.pipe
             // then we need to skip mark-miscategorized-as-correct api call
             if ((0, transactionType_1.toVendorTransactionTypeStrict)(response.data.transaction.transaction_type) != null ||
                 (0, transactionType_1.toJEAndDepositTransactionTypeStrict)(response.data.transaction.transaction_type) != null) {
-                const isAnyClassMissing = checkIfClassMissingForAnyLineItem(response.data.transaction);
+                const isAccountingClassesEnabled = (0, tenantSelector_1.getIsAccountingClassesEnabled)(state$.value);
+                const isAnyClassMissing = isAccountingClassesEnabled &&
+                    checkIfClassMissingForAnyLineItem(response.data.transaction);
                 const isVendorOrCustomerMissingInAnyLine = (0, transactionType_1.toJEAndDepositTransactionTypeStrict)(response.data.transaction.transaction_type) != null &&
                     checkIfVendorOrCustomerMissingForAnyLineItem(response.data.transaction);
                 if ((vendorUpdates?.id == null &&

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.1.34-betaAK1",
+  "version": "5.1.34-betaAK2",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",