@zeniai/client-epic-state 5.1.18-betaAA0 → 5.1.18-betaDI10

package/lib/view/taskManager/taskDetailView/epics/createSubTaskEpic.js

@@ -0,0 +1,84 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.createSubTaskEpic = void 0;
+const rxjs_1 = require("rxjs");
+const operators_1 = require("rxjs/operators");
+const formatMinutesToFromHHMM_1 = require("../../../../commonStateTypes/fiscalYearHelpers/formatMinutesToFromHHMM");
+const snackbarReducer_1 = require("../../../../entity/snackbar/snackbarReducer");
+const taskReducer_1 = require("../../../../entity/task/taskReducer");
+const taskSelector_1 = require("../../../../entity/task/taskSelector");
+const responsePayload_1 = require("../../../../responsePayload");
+const taskListReducer_1 = require("../../taskListView/taskListReducer");
+const taskDetailReducer_1 = require("../taskDetailReducer");
+const createSubTaskEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(taskDetailReducer_1.createSubTask.match), (0, operators_1.mergeMap)((action) => {
+    const state = state$.value;
+    const parentTask = (0, taskSelector_1.getTaskById)(state.taskState, action.payload.parentTaskId);
+    const parentTaskGroupId = parentTask?.taskGroupIds[0];
+    const isTaskListFetched = state.taskListState.fetchState === 'Completed';
+    const payload = prepareSubTaskPayload(action.payload, parentTaskGroupId);
+    return zeniAPI
+        .postAndGetJSON(`${zeniAPI.apiEndPoints.taskMicroServiceBaseUrl}/1.0/task-manager/tasks`, payload)
+        .pipe((0, operators_1.mergeMap)((response) => {
+        if ((0, responsePayload_1.isSuccessResponse)(response) &&
+            response.data != null &&
+            response.data.tasks.length > 0) {
+            const newTaskId = response.data.tasks[0].task_id;
+            const actions = [
+                (0, taskReducer_1.updateTasks)(response.data.tasks),
+                (0, taskReducer_1.appendSubTaskId)({
+                    parentTaskId: action.payload.parentTaskId,
+                    subTaskId: newTaskId,
+                }),
+                (0, taskDetailReducer_1.createSubTaskSuccessOrFailure)({
+                    fetchState: 'Completed',
+                    newTaskId,
+                }),
+                (0, snackbarReducer_1.openSnackbar)({
+                    messageSection: 'create_sub_task',
+                    messageText: 'success',
+                    type: 'success',
+                }),
+            ];
+            if (isTaskListFetched === true && parentTaskGroupId != null) {
+                actions.push((0, taskListReducer_1.updateTaskListOnNewTaskCreationSuccess)({
+                    taskGroupId: parentTaskGroupId,
+                    task: response.data.tasks[0],
+                }));
+            }
+            return (0, rxjs_1.from)(actions);
+        }
+        else {
+            return (0, rxjs_1.of)((0, taskDetailReducer_1.createSubTaskSuccessOrFailure)({
+                fetchState: 'Error',
+                error: response.status,
+            }), (0, snackbarReducer_1.openSnackbar)({
+                messageSection: 'create_sub_task',
+                messageText: 'failed',
+                type: 'error',
+                variables: [
+                    {
+                        variableName: '_api-error_',
+                        variableValue: response.status.message,
+                    },
+                ],
+            }));
+        }
+    }), (0, operators_1.catchError)((error) => (0, rxjs_1.of)((0, taskDetailReducer_1.createSubTaskSuccessOrFailure)({
+        fetchState: 'Error',
+        error: (0, responsePayload_1.createZeniAPIStatus)('Unexpected Error', 'Create Sub Task REST API call errored out' +
+            JSON.stringify(error)),
+    }))));
+}));
+exports.createSubTaskEpic = createSubTaskEpic;
+const prepareSubTaskPayload = (subTask, parentTaskGroupId) => ({
+    name: subTask.name,
+    assignees: subTask.assignee,
+    description: subTask.description,
+    priority: subTask.priority,
+    status: subTask.status,
+    tags: subTask.tagIds,
+    time_spent: (0, formatMinutesToFromHHMM_1.convertHHMMStrToMinutes)(subTask.timeSpent),
+    group_assignees: subTask.groupAssignees,
+    parent_task_id: subTask.parentTaskId,
+    task_group_ids: parentTaskGroupId == null ? [] : [parentTaskGroupId],
+});

package/lib/view/taskManager/taskDetailView/epics/fetchSubTasksEpic.d.ts

@@ -0,0 +1,8 @@
+import { ActionsObservable, StateObservable } from 'redux-observable';
+import { Observable } from 'rxjs';
+import { updateTasks } from '../../../../entity/task/taskReducer';
+import { RootState } from '../../../../reducer';
+import { ZeniAPI } from '../../../../zeniAPI';
+import { fetchSubTasks, updateSubTasks, updateSubTasksFetchStatus } from '../taskDetailReducer';
+export type ActionType = ReturnType<typeof fetchSubTasks> | ReturnType<typeof updateTasks> | ReturnType<typeof updateSubTasks> | ReturnType<typeof updateSubTasksFetchStatus>;
+export declare const fetchSubTasksEpic: (actions$: ActionsObservable<ActionType>, _state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => Observable<ActionType>;

package/lib/view/taskManager/taskDetailView/epics/fetchSubTasksEpic.js

@@ -0,0 +1,40 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.fetchSubTasksEpic = void 0;
+const rxjs_1 = require("rxjs");
+const operators_1 = require("rxjs/operators");
+const taskReducer_1 = require("../../../../entity/task/taskReducer");
+const responsePayload_1 = require("../../../../responsePayload");
+const taskDetailReducer_1 = require("../taskDetailReducer");
+const fetchSubTasksEpic = (actions$, _state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(taskDetailReducer_1.fetchSubTasks.match), (0, operators_1.switchMap)((action) => {
+    const { parentTaskId } = action.payload;
+    const query = JSON.stringify({
+        task_type: 'subtasks',
+        parent_task_id: parentTaskId,
+    });
+    return zeniAPI
+        .getJSON(`${zeniAPI.apiEndPoints.taskMicroServiceBaseUrl}/1.0/task-manager/tasks?query=${encodeURIComponent(query)}`)
+        .pipe((0, operators_1.mergeMap)((response) => {
+        if ((0, responsePayload_1.isSuccessResponse)(response) && response.data != null) {
+            const { tasks } = response.data;
+            return (0, rxjs_1.of)((0, taskReducer_1.updateTasks)(tasks), (0, taskDetailReducer_1.updateSubTasks)({
+                parentTaskId,
+            }));
+        }
+        else {
+            return (0, rxjs_1.of)((0, taskDetailReducer_1.updateSubTasksFetchStatus)({
+                parentTaskId,
+                fetchState: 'Error',
+                error: response.status,
+            }));
+        }
+    }), (0, operators_1.catchError)((error) => {
+        return (0, rxjs_1.of)((0, taskDetailReducer_1.updateSubTasksFetchStatus)({
+            parentTaskId,
+            fetchState: 'Error',
+            error: (0, responsePayload_1.createZeniAPIStatus)('Unexpected Error', 'Fetch Sub Tasks REST API call errored out' +
+                JSON.stringify(error)),
+        }));
+    }));
+}));
+exports.fetchSubTasksEpic = fetchSubTasksEpic;

package/lib/view/taskManager/taskDetailView/epics/fetchTaskDetailEpic.d.ts

@@ -6,6 +6,7 @@ import { updateTasks } from '../../../../entity/task/taskReducer';
 import { RootState } from '../../../../reducer';
 import { ZeniAPI } from '../../../../zeniAPI';
 import { fetchFileList } from '../../../fileView/fileViewReducer';
+import { updateTaskListOnNewTaskCreationSuccess } from '../../taskListView/taskListReducer';
 import { fetchTaskDetail, initializeTaskToLocalStore, removeTaskDetail, updateEditTaskFetchStatus } from '../taskDetailReducer';
-export type ActionType = ReturnType<typeof fetchTaskDetail> | ReturnType<typeof updateTags> | ReturnType<typeof updateEditTaskFetchStatus> | ReturnType<typeof removeTaskDetail> | ReturnType<typeof updateTasks> | ReturnType<typeof initializeTaskToLocalStore> | ReturnType<typeof fetchFileList> | ReturnType<typeof openSnackbar>;
+export type ActionType = ReturnType<typeof fetchTaskDetail> | ReturnType<typeof updateTags> | ReturnType<typeof updateEditTaskFetchStatus> | ReturnType<typeof removeTaskDetail> | ReturnType<typeof updateTasks> | ReturnType<typeof initializeTaskToLocalStore> | ReturnType<typeof fetchFileList> | ReturnType<typeof openSnackbar> | ReturnType<typeof updateTaskListOnNewTaskCreationSuccess>;
 export declare const fetchTaskDetailEpic: (actions$: ActionsObservable<ActionType>, state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => Observable<ActionType>;

package/lib/view/taskManager/taskDetailView/epics/fetchTaskDetailEpic.js

@@ -10,13 +10,16 @@ const operators_1 = require("rxjs/operators");
 const snackbarReducer_1 = require("../../../../entity/snackbar/snackbarReducer");
 const tagReducer_1 = require("../../../../entity/tag/tagReducer");
 const taskReducer_1 = require("../../../../entity/task/taskReducer");
+const taskSelector_1 = require("../../../../entity/task/taskSelector");
 const responsePayload_1 = require("../../../../responsePayload");
 const fileViewReducer_1 = require("../../../fileView/fileViewReducer");
+const taskListReducer_1 = require("../../taskListView/taskListReducer");
 const taskDetailReducer_1 = require("../taskDetailReducer");
 const fetchTaskDetailEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(taskDetailReducer_1.fetchTaskDetail.match), (0, operators_1.mergeMap)((action) => {
     const { taskId, cacheOverride } = action.payload;
     const taskActions = [];
     const state = state$.value;
+    const isTaskListFetched = state.taskListState.fetchState === 'Completed';
     const taskDetail = (0, get_1.default)(state.taskDetailState.editTaskStateById, taskId, undefined);
     if (cacheOverride === true) {
         taskActions.push((0, taskDetailReducer_1.removeTaskDetail)(taskId));
@@ -38,6 +41,16 @@ const fetchTaskDetailEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, ope
                     (0, tagReducer_1.updateTags)(response.data.tasks.map((task) => task.tags).flat()),
                     (0, taskDetailReducer_1.initializeTaskToLocalStore)(taskId),
                 ];
+                if (isTaskListFetched === true) {
+                    const taskGroupId = response.data.tasks[0].task_group_ids?.[0];
+                    if (taskGroupId != null) {
+                        fetchActions.push((0, taskListReducer_1.updateTaskListOnNewTaskCreationSuccess)({
+                            taskGroupId,
+                            task: response.data.tasks[0],
+                            currentTaskState: (0, taskSelector_1.getTaskById)(state.taskState, taskId),
+                        }));
+                    }
+                }
                 const fileIds = response.data.tasks[0].file_ids;
                 if (fileIds.length > 0) {
                     fetchActions.push((0, fileViewReducer_1.fetchFileList)(fileIds));

package/lib/view/taskManager/taskDetailView/epics/initializeTaskToLocalStoreEpic.js

@@ -34,6 +34,7 @@ const initializeTaskToLocalStoreEpic = (actions$, state$) => actions$.pipe((0, o
             recurringStartDate: task.recurringStartDate,
             timeSpent: task.timeSpent,
             isPrivate: task.isPrivate,
+            taskGroupId: task.taskGroupIds[0],
         };
         const actions = [
             (0, taskDetailReducer_1.saveTaskUpdatesToLocalStore)({ taskDetailLocalData, taskId }),

package/lib/view/taskManager/taskDetailView/epics/saveTaskDetailEpic.js

@@ -15,10 +15,26 @@ const saveTaskDetailEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, oper
     const { taskId, taskGroupId } = action.payload;
     const state = state$.value;
     const isTaskListFetched = state.taskListState.fetchState === 'Completed';
+    // For an edit, prefer the locally-edited group (Bug 12). If absent,
+    // fall back to the entity's current group. For a create, use the
+    // taskGroupId from the action payload.
+    const localTaskGroupId = taskId != null
+        ? state.taskDetailState.editTaskStateById[taskId]?.taskDetailLocalData
+            .taskGroupId
+        : undefined;
+    // Distinguish three cases (PR #3101 review):
+    //  - create (taskId == null): use the action payload group.
+    //  - edit, group cleared (localTaskGroupId === null): send [] so
+    //    the backend persists the cleared selection. The `??` fallback
+    //    would resurrect the stale entity value otherwise.
+    //  - edit, group untouched (localTaskGroupId === undefined): use
+    //    the entity's current group.
+    const groupWasCleared = taskId != null && localTaskGroupId === null;
     const updatedTaskGroupId = taskId == null
         ? taskGroupId
-        : (0, taskSelector_1.getTaskById)(state.taskState, taskId)?.taskGroupIds[0];
-    const payload = prepareTaskPayload(state, taskId, updatedTaskGroupId);
+        : (localTaskGroupId ??
+            (0, taskSelector_1.getTaskById)(state.taskState, taskId)?.taskGroupIds[0]);
+    const payload = prepareTaskPayload(state, taskId, updatedTaskGroupId, groupWasCleared);
     const saveTaskApi = taskId != null
         ? zeniAPI.putAndGetJSON(`${zeniAPI.apiEndPoints.taskMicroServiceBaseUrl}/1.0/task-manager/tasks/${taskId}`, payload)
         : zeniAPI.postAndGetJSON(`${zeniAPI.apiEndPoints.taskMicroServiceBaseUrl}/1.0/task-manager/tasks`, payload);
@@ -71,7 +87,7 @@ const saveTaskDetailEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, oper
     }))));
 }));
 exports.saveTaskDetailEpic = saveTaskDetailEpic;
-const prepareTaskPayload = (state, taskId, taskGroupId) => {
+const prepareTaskPayload = (state, taskId, taskGroupId, groupWasCleared = false) => {
     const { taskDetailState, taskState } = state;
     const syncToken = taskId != null ? ((0, taskSelector_1.getTaskById)(taskState, taskId)?.syncToken ?? '') : '';
     const sourceState = taskId != null
@@ -100,7 +116,11 @@ const prepareTaskPayload = (state, taskId, taskGroupId) => {
             ? (localData.recurringDaysOfWeek ?? [])
             : [],
         sync_token: syncToken,
-        task_group_ids: taskGroupId != null ? [taskGroupId] : [],
+        task_group_ids: groupWasCleared
+            ? []
+            : taskGroupId != null
+                ? [taskGroupId]
+                : [],
         time_spent: (0, formatMinutesToFromHHMM_1.convertHHMMStrToMinutes)(localData.timeSpent),
         group_assignees: localData.groupAssignees,
         ...(taskId == null ? { is_private: localData.isPrivate ?? false } : {}),

package/lib/view/taskManager/taskDetailView/epics/sendCommentMentionNotificationEpic.d.ts

@@ -0,0 +1,20 @@
+import { ActionsObservable, StateObservable } from 'redux-observable';
+import { RootState } from '../../../../reducer';
+import { ZeniAPI } from '../../../../zeniAPI';
+/**
+ * Fire-and-forget action — dispatched by the task-comments UI when a comment
+ * is created with @-mentions. The epic POSTs to task-manager's
+ * `/comment-mention-notification` endpoint which fans out Slack DMs to each
+ * mentioned internal user.
+ *
+ * Result is intentionally not captured in redux state: comment creation
+ * itself is owned by Liveblocks, and a network failure on the notification
+ * should not surface in the UI (the comment is still persisted in Liveblocks).
+ */
+export declare const sendCommentMentionNotification: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[taskId: string, mentionedUserIds: string[], performedById: string], {
+    taskId: string;
+    mentionedUserIds: string[];
+    performedById: string;
+}, "taskDetailView/sendCommentMentionNotification", never, never>;
+export type ActionType = ReturnType<typeof sendCommentMentionNotification>;
+export declare const sendCommentMentionNotificationEpic: (actions$: ActionsObservable<ActionType>, _state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => import("rxjs").Observable<unknown>;

package/lib/view/taskManager/taskDetailView/epics/sendCommentMentionNotificationEpic.js

@@ -0,0 +1,41 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.sendCommentMentionNotificationEpic = exports.sendCommentMentionNotification = void 0;
+const toolkit_1 = require("@reduxjs/toolkit");
+const rxjs_1 = require("rxjs");
+const operators_1 = require("rxjs/operators");
+/**
+ * Fire-and-forget action — dispatched by the task-comments UI when a comment
+ * is created with @-mentions. The epic POSTs to task-manager's
+ * `/comment-mention-notification` endpoint which fans out Slack DMs to each
+ * mentioned internal user.
+ *
+ * Result is intentionally not captured in redux state: comment creation
+ * itself is owned by Liveblocks, and a network failure on the notification
+ * should not surface in the UI (the comment is still persisted in Liveblocks).
+ */
+exports.sendCommentMentionNotification = (0, toolkit_1.createAction)('taskDetailView/sendCommentMentionNotification', (taskId, mentionedUserIds, performedById) => ({
+    payload: { taskId, mentionedUserIds, performedById },
+}));
+const sendCommentMentionNotificationEpic = (actions$, _state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(exports.sendCommentMentionNotification.match), (0, operators_1.mergeMap)((action) => handleSendCommentMentionNotification(action.payload, zeniAPI)));
+exports.sendCommentMentionNotificationEpic = sendCommentMentionNotificationEpic;
+const handleSendCommentMentionNotification = ({ taskId, mentionedUserIds, performedById, }, zeniAPI) => {
+    // Short-circuit when there's nothing to send. Avoids a useless round-trip
+    // (server would also short-circuit with a 200/no-op, but we may as well
+    // not enqueue the request at all).
+    if (mentionedUserIds.length === 0) {
+        return rxjs_1.EMPTY;
+    }
+    const url = `${zeniAPI.apiEndPoints.taskMicroServiceBaseUrl}/1.0/task-manager/tasks/${taskId}/comment-mention-notification`;
+    const request$ = zeniAPI.postAndGetJSON(url, {
+        mentioned_user_ids: mentionedUserIds,
+        performed_by_id: performedById,
+    });
+    return request$.pipe((0, operators_1.mergeMap)(() => {
+        // Liveblocks owns the comment itself; the Slack fan-out is
+        // best-effort and intentionally silent. We swallow both
+        // non-success responses and network errors so a Slack outage
+        // does not pollute the dev console for every @-mention.
+        return rxjs_1.EMPTY;
+    }), (0, operators_1.catchError)(() => (0, rxjs_1.of)()));
+};

package/lib/view/taskManager/taskDetailView/taskDetail.d.ts

@@ -3,9 +3,22 @@ import { DayOfWeek, PriorityCodeType, TaskStatusCodeType, TaskType } from '../..
 import { ZeniDate } from '../../../zeniDayJS';
 import { RecurringDatePickerOptions, RecurringFrequencyType } from '../../common/recurringViewHelper';
 import { CommonHistoryView } from '../../spendManagement/commonHistoryView/commonHistory';
+export interface CreateSubTaskPayload {
+    assignee: ID[];
+    description: string;
+    groupAssignees: ID[];
+    name: string;
+    parentTaskId: ID;
+    priority: PriorityCodeType;
+    status: TaskStatusCodeType;
+    tagIds: ID[];
+    timeSpent: string;
+}
 export interface TaskDetailViewState {
     editTaskStateById: Record<ID, EditTaskDetail>;
     newTaskState: EditTaskDetail;
+    subTaskCreateStatus: FetchStateAndError;
+    subTaskListFetchStatusByParentId: Record<ID, FetchStateAndError>;
     taskHistoryById: Record<ID, CommonHistoryView>;
 }
 export interface EditTaskDetail {
@@ -40,6 +53,7 @@ export interface EditTaskLocalData {
     recurringStartDate?: ZeniDate;
     savedRecurringEndDate?: ZeniDate;
     savedRecurringTasksCount?: number;
+    taskGroupId?: ID;
 }
 export declare const initialTaskDetailLocalData: EditTaskLocalData;
 export declare const initialTaskDetail: EditTaskDetail;

package/lib/view/taskManager/taskDetailView/taskDetailReducer.d.ts

@@ -1,7 +1,7 @@
 import { FetchState, ID } from '../../../commonStateTypes/common';
 import { ZeniAPIStatus } from '../../../responsePayload';
 import { HistoricEventPayload } from '../../spendManagement/commonHistoryView/commonHistoryPayload';
-import { EditTaskLocalData, TaskDetailViewState } from './taskDetail';
+import { CreateSubTaskPayload, EditTaskLocalData, TaskDetailViewState } from './taskDetail';
 export declare const initialState: TaskDetailViewState;
 export declare const fetchTaskDetailPage: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[cacheOverride: boolean, taskId?: string | undefined], {
     cacheOverride: boolean;
@@ -34,7 +34,19 @@ export declare const fetchTaskDetailPage: import("@reduxjs/toolkit").ActionCreat
     error?: ZeniAPIStatus;
     newTaskId?: ID;
     taskId?: ID;
-}, "taskDetailView/saveTaskSuccessOrFailure">, deleteTask: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[taskId?: string | undefined], {
+}, "taskDetailView/saveTaskSuccessOrFailure">, createSubTask: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[payload: CreateSubTaskPayload], CreateSubTaskPayload, "taskDetailView/createSubTask", never, never>, createSubTaskSuccessOrFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
+    fetchState: FetchState;
+    error?: ZeniAPIStatus;
+    newTaskId?: ID;
+}, "taskDetailView/createSubTaskSuccessOrFailure">, resetSubTaskCreateStatus: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"taskDetailView/resetSubTaskCreateStatus">, fetchSubTasks: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[parentTaskId: string], {
+    parentTaskId: string;
+}, "taskDetailView/fetchSubTasks", never, never>, updateSubTasks: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
+    parentTaskId: ID;
+}, "taskDetailView/updateSubTasks">, updateSubTasksFetchStatus: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
+    fetchState: FetchState;
+    parentTaskId: ID;
+    error?: ZeniAPIStatus;
+}, "taskDetailView/updateSubTasksFetchStatus">, deleteTask: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[taskId?: string | undefined], {
     taskId: string | undefined;
 }, "taskDetailView/deleteTask", never, never>, removeTaskDetail: import("@reduxjs/toolkit").ActionCreatorWithPayload<string, "taskDetailView/removeTaskDetail">, deleteTaskSuccessOrFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
     fetchState: FetchState;

package/lib/view/taskManager/taskDetailView/taskDetailReducer.js

@@ -4,7 +4,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 };
 var _a;
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.updateDeletedTagToLocalStore = exports.updateCreatedTagToLocalStore = exports.clearTaskDetail = exports.updateTaskHistoryFetchStatus = exports.updateTaskHistory = exports.fetchTaskHistory = exports.unsnoozeTask = exports.snoozeTaskSuccessOrFailure = exports.snoozeTask = exports.deleteTaskSuccessOrFailure = exports.removeTaskDetail = exports.deleteTask = exports.saveTaskSuccessOrFailure = exports.archiveTaskSuccessOrFailure = exports.archiveTask = exports.saveTaskDetail = exports.discardTaskUpdatesInLocalStore = exports.saveTaskUpdatesToLocalStore = exports.updateEditTaskFetchStatus = exports.initializeTaskToLocalStore = exports.fetchTaskDetail = exports.fetchTaskDetailPage = exports.initialState = void 0;
+exports.updateDeletedTagToLocalStore = exports.updateCreatedTagToLocalStore = exports.clearTaskDetail = exports.updateTaskHistoryFetchStatus = exports.updateTaskHistory = exports.fetchTaskHistory = exports.unsnoozeTask = exports.snoozeTaskSuccessOrFailure = exports.snoozeTask = exports.deleteTaskSuccessOrFailure = exports.removeTaskDetail = exports.deleteTask = exports.updateSubTasksFetchStatus = exports.updateSubTasks = exports.fetchSubTasks = exports.resetSubTaskCreateStatus = exports.createSubTaskSuccessOrFailure = exports.createSubTask = exports.saveTaskSuccessOrFailure = exports.archiveTaskSuccessOrFailure = exports.archiveTask = exports.saveTaskDetail = exports.discardTaskUpdatesInLocalStore = exports.saveTaskUpdatesToLocalStore = exports.updateEditTaskFetchStatus = exports.initializeTaskToLocalStore = exports.fetchTaskDetail = exports.fetchTaskDetailPage = exports.initialState = void 0;
 const toolkit_1 = require("@reduxjs/toolkit");
 const get_1 = __importDefault(require("lodash/get"));
 const commonHistory_1 = require("../../spendManagement/commonHistoryView/commonHistory");
@@ -13,6 +13,11 @@ const taskDetail_1 = require("./taskDetail");
 exports.initialState = {
     newTaskState: taskDetail_1.initialTaskDetail,
     editTaskStateById: {},
+    subTaskCreateStatus: {
+        fetchState: 'Not-Started',
+        error: undefined,
+    },
+    subTaskListFetchStatusByParentId: {},
     taskHistoryById: {},
 };
 const taskDetailView = (0, toolkit_1.createSlice)({
@@ -57,7 +62,7 @@ const taskDetailView = (0, toolkit_1.createSlice)({
         updateEditTaskFetchStatus(draft, action) {
             const { taskId, fetchState, error } = action.payload;
             draft.editTaskStateById[taskId] = {
-                ...draft.editTaskStateById[taskId],
+                ...(draft.editTaskStateById[taskId] ?? taskDetail_1.initialTaskDetail),
                 fetchTaskStatus: {
                     fetchState,
                     error: fetchState === 'Error' ? error : undefined,
@@ -325,10 +330,59 @@ const taskDetailView = (0, toolkit_1.createSlice)({
                 error,
             };
         },
+        createSubTask: {
+            reducer(draft) {
+                draft.subTaskCreateStatus = {
+                    fetchState: 'In-Progress',
+                    error: undefined,
+                };
+            },
+            prepare(payload) {
+                return { payload };
+            },
+        },
+        createSubTaskSuccessOrFailure(draft, action) {
+            const { fetchState, error } = action.payload;
+            draft.subTaskCreateStatus = {
+                fetchState,
+                error,
+            };
+        },
+        resetSubTaskCreateStatus(draft) {
+            draft.subTaskCreateStatus = {
+                ...exports.initialState.subTaskCreateStatus,
+            };
+        },
+        fetchSubTasks: {
+            reducer(draft, action) {
+                const { parentTaskId } = action.payload;
+                draft.subTaskListFetchStatusByParentId[parentTaskId] = {
+                    fetchState: 'In-Progress',
+                    error: undefined,
+                };
+            },
+            prepare(parentTaskId) {
+                return { payload: { parentTaskId } };
+            },
+        },
+        updateSubTasks(draft, action) {
+            const { parentTaskId } = action.payload;
+            draft.subTaskListFetchStatusByParentId[parentTaskId] = {
+                fetchState: 'Completed',
+                error: undefined,
+            };
+        },
+        updateSubTasksFetchStatus(draft, action) {
+            const { parentTaskId, fetchState, error } = action.payload;
+            draft.subTaskListFetchStatusByParentId[parentTaskId] = {
+                fetchState,
+                error,
+            };
+        },
         clearTaskDetail(draft) {
             Object.assign(draft, exports.initialState);
         },
     },
 });
-_a = taskDetailView.actions, exports.fetchTaskDetailPage = _a.fetchTaskDetailPage, exports.fetchTaskDetail = _a.fetchTaskDetail, exports.initializeTaskToLocalStore = _a.initializeTaskToLocalStore, exports.updateEditTaskFetchStatus = _a.updateEditTaskFetchStatus, exports.saveTaskUpdatesToLocalStore = _a.saveTaskUpdatesToLocalStore, exports.discardTaskUpdatesInLocalStore = _a.discardTaskUpdatesInLocalStore, exports.saveTaskDetail = _a.saveTaskDetail, exports.archiveTask = _a.archiveTask, exports.archiveTaskSuccessOrFailure = _a.archiveTaskSuccessOrFailure, exports.saveTaskSuccessOrFailure = _a.saveTaskSuccessOrFailure, exports.deleteTask = _a.deleteTask, exports.removeTaskDetail = _a.removeTaskDetail, exports.deleteTaskSuccessOrFailure = _a.deleteTaskSuccessOrFailure, exports.snoozeTask = _a.snoozeTask, exports.snoozeTaskSuccessOrFailure = _a.snoozeTaskSuccessOrFailure, exports.unsnoozeTask = _a.unsnoozeTask, exports.fetchTaskHistory = _a.fetchTaskHistory, exports.updateTaskHistory = _a.updateTaskHistory, exports.updateTaskHistoryFetchStatus = _a.updateTaskHistoryFetchStatus, exports.clearTaskDetail = _a.clearTaskDetail, exports.updateCreatedTagToLocalStore = _a.updateCreatedTagToLocalStore, exports.updateDeletedTagToLocalStore = _a.updateDeletedTagToLocalStore;
+_a = taskDetailView.actions, exports.fetchTaskDetailPage = _a.fetchTaskDetailPage, exports.fetchTaskDetail = _a.fetchTaskDetail, exports.initializeTaskToLocalStore = _a.initializeTaskToLocalStore, exports.updateEditTaskFetchStatus = _a.updateEditTaskFetchStatus, exports.saveTaskUpdatesToLocalStore = _a.saveTaskUpdatesToLocalStore, exports.discardTaskUpdatesInLocalStore = _a.discardTaskUpdatesInLocalStore, exports.saveTaskDetail = _a.saveTaskDetail, exports.archiveTask = _a.archiveTask, exports.archiveTaskSuccessOrFailure = _a.archiveTaskSuccessOrFailure, exports.saveTaskSuccessOrFailure = _a.saveTaskSuccessOrFailure, exports.createSubTask = _a.createSubTask, exports.createSubTaskSuccessOrFailure = _a.createSubTaskSuccessOrFailure, exports.resetSubTaskCreateStatus = _a.resetSubTaskCreateStatus, exports.fetchSubTasks = _a.fetchSubTasks, exports.updateSubTasks = _a.updateSubTasks, exports.updateSubTasksFetchStatus = _a.updateSubTasksFetchStatus, exports.deleteTask = _a.deleteTask, exports.removeTaskDetail = _a.removeTaskDetail, exports.deleteTaskSuccessOrFailure = _a.deleteTaskSuccessOrFailure, exports.snoozeTask = _a.snoozeTask, exports.snoozeTaskSuccessOrFailure = _a.snoozeTaskSuccessOrFailure, exports.unsnoozeTask = _a.unsnoozeTask, exports.fetchTaskHistory = _a.fetchTaskHistory, exports.updateTaskHistory = _a.updateTaskHistory, exports.updateTaskHistoryFetchStatus = _a.updateTaskHistoryFetchStatus, exports.clearTaskDetail = _a.clearTaskDetail, exports.updateCreatedTagToLocalStore = _a.updateCreatedTagToLocalStore, exports.updateDeletedTagToLocalStore = _a.updateDeletedTagToLocalStore;
 exports.default = taskDetailView.reducer;

package/lib/view/taskManager/taskDetailView/taskDetailSelector.d.ts

@@ -2,7 +2,7 @@ import { FetchStateAndError, ID } from '../../../commonStateTypes/common';
 import { SelectorView } from '../../../commonStateTypes/viewAndReport/viewAndReport';
 import { Class } from '../../../entity/class/classState';
 import { File } from '../../../entity/file/fileState';
-import { TaskPriority, TaskStatus } from '../../../entity/task/taskState';
+import { Task, TaskPriority, TaskStatus } from '../../../entity/task/taskState';
 import { RootState } from '../../../reducer';
 import { ZeniDate } from '../../../zeniDayJS';
 import { UserAndRole } from '../../companyView/types/userAndRole';
@@ -14,6 +14,7 @@ export interface TaskDetailSelectorView extends SelectorView {
     deleteFileStatusById: Record<ID, FetchStateAndError | undefined>;
     files: File[];
     showTaskDetailFormFooter: boolean;
+    subtasks: Task[];
     taskDetailView: EditTaskDetail;
     taskHistory: HistoricEvent[];
     updateFileStatusById: Record<ID, FetchStateAndError | undefined>;

package/lib/view/taskManager/taskDetailView/taskDetailSelector.js

@@ -33,8 +33,13 @@ const getTaskDetail = (state, taskId) => {
     let recurringSourceTaskId = undefined;
     let snoozedUntil = undefined;
     let taskGroupId = undefined;
+    let subtasks = [];
     if (taskId != null && sourceTaskDetail != null) {
         const taskEntity = (0, taskSelector_1.getTaskById)(taskState, taskId);
+        subtasks =
+            taskEntity != null
+                ? (0, taskSelector_1.getTasksByIds)(taskState, taskEntity.subTasksIds)
+                : [];
         const fileIdsInEntity = taskEntity?.fileIds ?? [];
         if (taskEntity != null) {
             createdByUser = (0, userAndRole_1.getUserAndUserRole)(userState, userRoleState, addressState, taskEntity.createdBy);
@@ -45,25 +50,27 @@ const getTaskDetail = (state, taskId) => {
             taskGroupId = taskEntity.taskGroupIds[0];
         }
         if (fileIdsInEntity.length > 0) {
-            fetchStatus = (0, reduceFetchState_1.reduceFetchState)([
+            fetchStatus = (0, reduceFetchState_1.reduceAnyFetchState)([
                 fileViewState.fetchFilesStatus,
                 sourceTaskDetail.fetchTaskStatus,
                 userList,
                 classListState,
+                taskDetailState.subTaskListFetchStatusByParentId[taskId] ?? fetchStatus,
             ]);
         }
         else {
-            fetchStatus = (0, reduceFetchState_1.reduceFetchState)([
+            fetchStatus = (0, reduceFetchState_1.reduceAnyFetchState)([
                 sourceTaskDetail.fetchTaskStatus,
                 userList,
                 classListState,
+                taskDetailState.subTaskListFetchStatusByParentId[taskId] ?? fetchStatus,
             ]);
         }
         showTaskDetailFormFooter = showFormFooter(sourceTaskDetail.taskDetailLocalData, taskEntity);
         taskHistory = taskDetailState.taskHistoryById[taskId]?.historicEvents ?? [];
     }
     else if (taskId == null) {
-        fetchStatus = (0, reduceFetchState_1.reduceFetchState)([userList, classListState]);
+        fetchStatus = (0, reduceFetchState_1.reduceAnyFetchState)([userList, classListState]);
     }
     const { classIds } = classListState;
     const allAccountingClasses = (0, classSelector_1.getClassesByIds)(classState, {
@@ -96,6 +103,7 @@ const getTaskDetail = (state, taskId) => {
         showTaskDetailFormFooter,
         snoozedUntil,
         taskGroupId,
+        subtasks,
     };
 };
 exports.getTaskDetail = getTaskDetail;
@@ -144,13 +152,16 @@ exports.allTaskPriority = [
     },
 ];
 const showFormFooter = (taskDetailLocalData, taskDetailInStore) => {
-    if (taskDetailLocalData.name !== taskDetailInStore?.name ||
+    if (taskDetailInStore == null) {
+        return false;
+    }
+    if (taskDetailLocalData.name !== taskDetailInStore.name ||
         taskDetailLocalData.description !== taskDetailInStore.description ||
         taskDetailLocalData.priority !== taskDetailInStore.priority.code ||
         taskDetailLocalData.status !== taskDetailInStore.status.code ||
         !(0, isEqual_1.default)(taskDetailInStore.tagIds, taskDetailLocalData.tagIds) ||
-        !(0, isEqual_1.default)(taskDetailLocalData.assignee, taskDetailInStore?.assignees ?? []) ||
-        !(0, isEqual_1.default)(taskDetailLocalData.groupAssignees, taskDetailInStore?.groupAssignees ?? []) ||
+        !(0, isEqual_1.default)(taskDetailLocalData.assignee, taskDetailInStore.assignees ?? []) ||
+        !(0, isEqual_1.default)(taskDetailLocalData.groupAssignees, taskDetailInStore.groupAssignees ?? []) ||
         !(0, isEqual_1.default)(taskDetailLocalData.fileIds, taskDetailInStore.fileIds ?? []) ||
         !(0, isEqual_1.default)(taskDetailLocalData.dueDate, taskDetailInStore.dueDate) ||
         !(0, isEqual_1.default)(taskDetailLocalData.type, taskDetailInStore.type) ||
@@ -158,7 +169,8 @@ const showFormFooter = (taskDetailLocalData, taskDetailInStore) => {
         !(0, isEqual_1.default)(taskDetailLocalData.recurringFrequency, taskDetailInStore.recurringFrequency) ||
         !(0, isEqual_1.default)(taskDetailLocalData.recurringDaysOfWeek, taskDetailInStore.recurringDaysOfWeek) ||
         !(0, isEqual_1.default)(taskDetailLocalData.recurringStartDate, taskDetailInStore.recurringStartDate) ||
-        !(0, isEqual_1.default)(taskDetailLocalData.timeSpent, taskDetailInStore.timeSpent)) {
+        !(0, isEqual_1.default)(taskDetailLocalData.timeSpent, taskDetailInStore.timeSpent) ||
+        !(0, isEqual_1.default)(taskDetailLocalData.taskGroupId, taskDetailInStore.taskGroupIds[0])) {
         return true;
     }
     return false;

package/lib/view/taskManager/taskListView/epics/fetchTaskListEpic.js

@@ -12,15 +12,17 @@ const fetchTaskListEpic = (actions$, _state$, zeniAPI) => actions$.pipe((0, oper
         .getJSON(`${zeniAPI.apiEndPoints.taskMicroServiceBaseUrl}/1.0/task-manager/tasks?query=${encodeURIComponent(`{"task_type": "all"}`)}`)
         .pipe((0, operators_1.mergeMap)((response) => {
         if ((0, responsePayload_1.isSuccessResponse)(response) && response.data != null) {
-            const { tasks, deleted, archived, snoozed } = response.data;
+            const { tasks, deleted, archived, snoozed, completed } = response.data;
             const allTasks = [
                 ...tasks,
+                ...(completed ?? []),
                 ...(deleted ?? []),
                 ...(archived ?? []),
                 ...(snoozed ?? []),
             ];
             return (0, rxjs_1.of)((0, taskReducer_1.updateTasks)(allTasks), (0, taskListReducer_1.updateTaskList)({
                 data: tasks,
+                completed: completed ?? [],
                 deleted: deleted ?? [],
                 archived: archived ?? [],
                 snoozed: snoozed ?? [],

package/lib/view/taskManager/taskListView/taskList.d.ts

@@ -3,7 +3,7 @@ import { PriorityCodeType, TaskStatusCodeType } from '../../../entity/task/taskS
 import { ZeniDate } from '../../../zeniDayJS';
 import { SpendManagementUIState } from '../../spendManagement/billPay/billList/billListState';
 import { CategoryCombinationOperator, FilterCategoryType } from '../../spendManagement/spendManagementFilterHelpers';
-export declare const ALL_TASK_LIST_TABS: readonly ["live", "archived", "deleted", "snoozed"];
+export declare const ALL_TASK_LIST_TABS: readonly ["live", "completed", "archived", "deleted", "snoozed"];
 export type TaskListTab = (typeof ALL_TASK_LIST_TABS)[number];
 export interface TaskListTabData {
     taskIds: ID[];

package/lib/view/taskManager/taskListView/taskList.js

@@ -4,6 +4,7 @@ exports.TASK_LIST_GROUP_BY_CATEGORIES = exports.TASK_LIST_FILTER_CATEGORIES = ex
 const stringToUnion_1 = require("../../../commonStateTypes/stringToUnion");
 exports.ALL_TASK_LIST_TABS = [
     'live',
+    'completed',
     'archived',
     'deleted',
     'snoozed',

package/lib/view/taskManager/taskListView/taskListPayload.d.ts

@@ -3,6 +3,10 @@ import { ZeniAPIResponse } from '../../../responsePayload';
 interface FetchTaskListPayload {
     tasks: TaskPayload[];
     archived?: TaskPayload[];
+    /** Tasks whose status is "done" or "resolved". Returned as a separate
+     *  bucket so the "Completed" tab can show them without duplicating
+     *  them under Active. */
+    completed?: TaskPayload[];
     deleted?: TaskPayload[];
     snoozed?: TaskPayload[];
 }

package/lib/view/taskManager/taskListView/taskListReducer.d.ts

@@ -12,9 +12,10 @@ export declare const fetchTaskListPage: import("@reduxjs/toolkit").ActionCreator
 }, "taskList/fetchTaskListPage", never, never>, fetchTaskList: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"taskList/fetchTaskList">, updateTaskList: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
     data: TaskPayload[];
     archived?: TaskPayload[];
+    completed?: TaskPayload[];
     deleted?: TaskPayload[];
     snoozed?: TaskPayload[];
-}, "taskList/updateTaskList">, updateTaskListTab: import("@reduxjs/toolkit").ActionCreatorWithPayload<"deleted" | "archived" | "live" | "snoozed", "taskList/updateTaskListTab">, updateTaskListFetchStatus: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
+}, "taskList/updateTaskList">, updateTaskListTab: import("@reduxjs/toolkit").ActionCreatorWithPayload<"completed" | "deleted" | "archived" | "live" | "snoozed", "taskList/updateTaskListTab">, updateTaskListFetchStatus: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
     fetchState: FetchState;
     error?: ZeniAPIStatus;
 }, "taskList/updateTaskListFetchStatus">, updateTaskListSearchText: import("@reduxjs/toolkit").ActionCreatorWithPayload<{