@zeniai/client-epic-state 5.1.16-betaRD1 → 5.1.17

package/lib/esm/view/expenseAutomationView/epics/transactionCategorization/fetchTransactionCategorizationEpic.js

@@ -1,5 +1,5 @@
 import { from, of } from 'rxjs';
-import { catchError, filter, groupBy, mergeMap, switchMap } from 'rxjs/operators';
+import { catchError, filter, mergeMap, switchMap } from 'rxjs/operators';
 import { toString } from '../../../../commonStateTypes/timePeriod';
 import { getCurrentTenant } from '../../../../entity/tenant/tenantSelector';
 import { updateTransactions } from '../../../../entity/transaction/transactionReducer';
@@ -8,10 +8,7 @@ import { getLineItemsByTransactionsIdsFromResponse } from '../../helpers/transac
 import { fetchTransactionCategorization, fetchTransactionCategorizationFailure, fetchTransactionCategorizationSuccess, initializeTransactionCategorizationViewLocalData, resetOtherTabsFetchState, updateParentTotalCountForTab, updateTotalCountForTransactionCategorization, updateTransactionCategorizationUIState, } from '../../reducers/transactionsViewReducer';
 import { DEFAULT_COMPLETED_SUB_TAB } from '../../types/completedSubTab';
 import { TRANSACTIONS_TABS, toTransactionsSortKey, } from '../../types/transactionsViewState';
-export const fetchTransactionCategorizationEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(fetchTransactionCategorization.match), 
-// Per-tab switchMap: cancels in-flight requests for the same tab on a new
-// request, but allows both tabs to fetch concurrently (e.g. dual search).
-groupBy((action) => action.payload.selectedTab), mergeMap((group$) => group$.pipe(switchMap((action) => {
+export const fetchTransactionCategorizationEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(fetchTransactionCategorization.match), switchMap((action) => {
     const { expenseAutomationViewState: { selectedPeriodByTenantId }, expenseAutomationTransactionsViewState, } = state$.value;
     const { period, keepExistingListItems, selectedTab, refreshViewInBackground, } = action.payload;
     const uiState = expenseAutomationTransactionsViewState.transactionCategorizationView[selectedTab].uiState;
@@ -27,10 +24,6 @@ groupBy((action) => action.payload.selectedTab), mergeMap((group$) => group$.pip
         page_token: pageToken,
         page_size: 25,
         search_text: uiState.searchString,
-        // Always scope to the active tab's auto_categorized status;
-        // cross-status search (omit or true) is reserved for Receipts
-        // manual-match.
-        search_all_statuses: false,
         sub_tab: selectedTab === 'autoCategorized'
             ? expenseAutomationTransactionsViewState.selectedTransactionCategorizationCompletedSubTab
             : DEFAULT_COMPLETED_SUB_TAB,
@@ -86,4 +79,4 @@ groupBy((action) => action.payload.selectedTab), mergeMap((group$) => group$.pip
         status: createZeniAPIStatus('Unexpected Error', 'fetch Transaction Categorization REST API call errored out' +
             JSON.stringify(error)),
     }))));
-}))));
+}));

package/lib/esm/view/expenseAutomationView/epics/transactionCategorization/fetchTransactionCategorizationViewEpic.js

@@ -7,7 +7,6 @@ import { fetchClassList } from '../../../classList/classListReducer';
 import { fetchOwnerList } from '../../../ownerList/ownerListReducer';
 import { fetchProjectList } from '../../../projectList/projectListReducer';
 import { fetchTransactionCategorization, fetchTransactionCategorizationView, } from '../../reducers/transactionsViewReducer';
-import { TRANSACTIONS_TABS } from '../../types/transactionsViewState';
 export const fetchTransactionCategorizationViewEpic = (actions$, state$) => actions$.pipe(filter(fetchTransactionCategorizationView.match), mergeMap((action) => {
     const { selectedTab, cacheOverride, keepExistingListItems, pageToken, period, refreshViewInBackground, searchString, resetListItems, isUncategorizedExpenseCategoryEnabled, } = action.payload;
     const updateActions = [];
@@ -45,20 +44,5 @@ export const fetchTransactionCategorizationViewEpic = (actions$, state$) => acti
         transactionIds.length === 0) {
         updateActions.push(fetchTransactionCategorization(selectedTab, period, cacheOverride, keepExistingListItems, searchString, pageToken, refreshViewInBackground, resetListItems, isUncategorizedExpenseCategoryEnabled));
     }
-    // When search changes (searchString defined, including empty string to
-    // clear), also fetch every other tab so all tabs always reflect the same
-    // search query. Skip if the other tab already has this search string to
-    // avoid redundant requests on noop updates. cacheOverride=true bypasses
-    // the cache check; pageToken reset to undefined so the other tab starts
-    // from page 1; refreshViewInBackground=true because the user isn't
-    // looking at the other tab, so a silent background fetch is correct.
-    if (searchString !== undefined) {
-        TRANSACTIONS_TABS.filter((tab) => tab !== selectedTab).forEach((otherTab) => {
-            const otherTabSearchString = expenseAutomationTransactionsViewState.transactionCategorizationView[otherTab].uiState.searchString;
-            if (searchString !== otherTabSearchString) {
-                updateActions.push(fetchTransactionCategorization(otherTab, period, true, keepExistingListItems, searchString, undefined, true, true, isUncategorizedExpenseCategoryEnabled));
-            }
-        });
-    }
     return from(updateActions);
 }));

package/lib/esm/view/expenseAutomationView/reducers/transactionsViewReducer.js

@@ -156,12 +156,8 @@ const expenseAutomationTransactionsView = createSlice({
                 }
                 draft.transactionCategorizationView[selectedTab].uiState.pageToken =
                     pageToken ?? null;
-                // Only overwrite when explicitly set; undefined means a non-search fetch
-                // (tab switch, period change) should preserve the existing search string.
-                if (searchString !== undefined) {
-                    draft.transactionCategorizationView[selectedTab].uiState.searchString =
-                        searchString;
-                }
+                draft.transactionCategorizationView[selectedTab].uiState.searchString =
+                    searchString ?? '';
                 draft.transactionCategorizationView[selectedTab].error = undefined;
                 // Reset list when we change the sort order and fetch list again
                 if (resetListItems === true) {
@@ -309,12 +305,10 @@ const expenseAutomationTransactionsView = createSlice({
             }
         },
         updateTransactionFilters(draft, action) {
-            const { filters } = action.payload;
-            // Filters are tab-agnostic (payee/category/class/amount), so apply to
-            // all tabs so switching tabs after filtering shows consistent results.
-            TRANSACTIONS_TABS.forEach((tab) => {
-                draft.transactionCategorizationView[tab].filters = filters;
-            });
+            const { selectedTab, filters } = action.payload;
+            // `filters` is non-nullable per the payload type, so no runtime
+            // null-check is needed — dropping it removes a dead defensive branch.
+            draft.transactionCategorizationView[selectedTab].filters = filters;
         },
         saveTransactionCategorization: {
             prepare(selectedTab, transactionIds, cotTrackingByTransactionId, isUncategorizedExpenseCategoryEnabled) {

package/lib/view/expenseAutomationView/epics/transactionCategorization/fetchTransactionCategorizationEpic.js

@@ -11,10 +11,7 @@ const transactionCategorizationLocalDataHelper_1 = require("../../helpers/transa
 const transactionsViewReducer_1 = require("../../reducers/transactionsViewReducer");
 const completedSubTab_1 = require("../../types/completedSubTab");
 const transactionsViewState_1 = require("../../types/transactionsViewState");
-const fetchTransactionCategorizationEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(transactionsViewReducer_1.fetchTransactionCategorization.match), 
-// Per-tab switchMap: cancels in-flight requests for the same tab on a new
-// request, but allows both tabs to fetch concurrently (e.g. dual search).
-(0, operators_1.groupBy)((action) => action.payload.selectedTab), (0, operators_1.mergeMap)((group$) => group$.pipe((0, operators_1.switchMap)((action) => {
+const fetchTransactionCategorizationEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(transactionsViewReducer_1.fetchTransactionCategorization.match), (0, operators_1.switchMap)((action) => {
     const { expenseAutomationViewState: { selectedPeriodByTenantId }, expenseAutomationTransactionsViewState, } = state$.value;
     const { period, keepExistingListItems, selectedTab, refreshViewInBackground, } = action.payload;
     const uiState = expenseAutomationTransactionsViewState.transactionCategorizationView[selectedTab].uiState;
@@ -30,10 +27,6 @@ const fetchTransactionCategorizationEpic = (actions$, state$, zeniAPI) => action
         page_token: pageToken,
         page_size: 25,
         search_text: uiState.searchString,
-        // Always scope to the active tab's auto_categorized status;
-        // cross-status search (omit or true) is reserved for Receipts
-        // manual-match.
-        search_all_statuses: false,
         sub_tab: selectedTab === 'autoCategorized'
             ? expenseAutomationTransactionsViewState.selectedTransactionCategorizationCompletedSubTab
             : completedSubTab_1.DEFAULT_COMPLETED_SUB_TAB,
@@ -89,5 +82,5 @@ const fetchTransactionCategorizationEpic = (actions$, state$, zeniAPI) => action
         status: (0, responsePayload_1.createZeniAPIStatus)('Unexpected Error', 'fetch Transaction Categorization REST API call errored out' +
             JSON.stringify(error)),
     }))));
-}))));
+}));
 exports.fetchTransactionCategorizationEpic = fetchTransactionCategorizationEpic;

package/lib/view/expenseAutomationView/epics/transactionCategorization/fetchTransactionCategorizationViewEpic.js

@@ -10,7 +10,6 @@ const classListReducer_1 = require("../../../classList/classListReducer");
 const ownerListReducer_1 = require("../../../ownerList/ownerListReducer");
 const projectListReducer_1 = require("../../../projectList/projectListReducer");
 const transactionsViewReducer_1 = require("../../reducers/transactionsViewReducer");
-const transactionsViewState_1 = require("../../types/transactionsViewState");
 const fetchTransactionCategorizationViewEpic = (actions$, state$) => actions$.pipe((0, operators_1.filter)(transactionsViewReducer_1.fetchTransactionCategorizationView.match), (0, operators_1.mergeMap)((action) => {
     const { selectedTab, cacheOverride, keepExistingListItems, pageToken, period, refreshViewInBackground, searchString, resetListItems, isUncategorizedExpenseCategoryEnabled, } = action.payload;
     const updateActions = [];
@@ -48,21 +47,6 @@ const fetchTransactionCategorizationViewEpic = (actions$, state$) => actions$.pi
         transactionIds.length === 0) {
         updateActions.push((0, transactionsViewReducer_1.fetchTransactionCategorization)(selectedTab, period, cacheOverride, keepExistingListItems, searchString, pageToken, refreshViewInBackground, resetListItems, isUncategorizedExpenseCategoryEnabled));
     }
-    // When search changes (searchString defined, including empty string to
-    // clear), also fetch every other tab so all tabs always reflect the same
-    // search query. Skip if the other tab already has this search string to
-    // avoid redundant requests on noop updates. cacheOverride=true bypasses
-    // the cache check; pageToken reset to undefined so the other tab starts
-    // from page 1; refreshViewInBackground=true because the user isn't
-    // looking at the other tab, so a silent background fetch is correct.
-    if (searchString !== undefined) {
-        transactionsViewState_1.TRANSACTIONS_TABS.filter((tab) => tab !== selectedTab).forEach((otherTab) => {
-            const otherTabSearchString = expenseAutomationTransactionsViewState.transactionCategorizationView[otherTab].uiState.searchString;
-            if (searchString !== otherTabSearchString) {
-                updateActions.push((0, transactionsViewReducer_1.fetchTransactionCategorization)(otherTab, period, true, keepExistingListItems, searchString, undefined, true, true, isUncategorizedExpenseCategoryEnabled));
-            }
-        });
-    }
     return (0, rxjs_1.from)(updateActions);
 }));
 exports.fetchTransactionCategorizationViewEpic = fetchTransactionCategorizationViewEpic;

package/lib/view/expenseAutomationView/payload/transactionCategorizationPayload.d.ts

@@ -19,13 +19,6 @@ export interface TransactionCategorizationQueryPayload {
      * on the backend.
      */
     sub_tab: CompletedSubTab;
-    /**
-     * When `false`, the backend scopes the search to the active tab's
-     * categorization status (respects `auto_categorized`). When `true` or
-     * omitted, the backend searches across all statuses — the legacy behaviour
-     * that the Receipts manual-match flow relies on.
-     */
-    search_all_statuses?: boolean;
 }
 export interface TransactionCategorizationPayload {
     next_page_token: string | null;

package/lib/view/expenseAutomationView/reducers/transactionsViewReducer.js

@@ -163,12 +163,8 @@ const expenseAutomationTransactionsView = (0, toolkit_1.createSlice)({
                 }
                 draft.transactionCategorizationView[selectedTab].uiState.pageToken =
                     pageToken ?? null;
-                // Only overwrite when explicitly set; undefined means a non-search fetch
-                // (tab switch, period change) should preserve the existing search string.
-                if (searchString !== undefined) {
-                    draft.transactionCategorizationView[selectedTab].uiState.searchString =
-                        searchString;
-                }
+                draft.transactionCategorizationView[selectedTab].uiState.searchString =
+                    searchString ?? '';
                 draft.transactionCategorizationView[selectedTab].error = undefined;
                 // Reset list when we change the sort order and fetch list again
                 if (resetListItems === true) {
@@ -316,12 +312,10 @@ const expenseAutomationTransactionsView = (0, toolkit_1.createSlice)({
             }
         },
         updateTransactionFilters(draft, action) {
-            const { filters } = action.payload;
-            // Filters are tab-agnostic (payee/category/class/amount), so apply to
-            // all tabs so switching tabs after filtering shows consistent results.
-            transactionsViewState_1.TRANSACTIONS_TABS.forEach((tab) => {
-                draft.transactionCategorizationView[tab].filters = filters;
-            });
+            const { selectedTab, filters } = action.payload;
+            // `filters` is non-nullable per the payload type, so no runtime
+            // null-check is needed — dropping it removes a dead defensive branch.
+            draft.transactionCategorizationView[selectedTab].filters = filters;
         },
         saveTransactionCategorization: {
             prepare(selectedTab, transactionIds, cotTrackingByTransactionId, isUncategorizedExpenseCategoryEnabled) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.1.16-betaRD1",
+  "version": "5.1.17",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",